date:20160511


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47271/
---

Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
and Sumit Mohanty.


Bugs: AMBARI-16206
https://issues.apache.org/jira/browse/AMBARI-16206


Repository: ambari


Description
---

use cosistent naming in configurations for LOGSEARCH service ("Log Search" 
instead of Logsearch and LogSearch)


Diffs
-

  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json 
0ab2b19 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
 55e5efe 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml
 40d14af 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
 c0aa8f4 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
 f04a5c4 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
 ce53692 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
 46447d8 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json
 259fb28 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 9511738 
  ambari-web/app/models/quick_links.js b062895 

Diff: https://reviews.apache.org/r/47271/diff/


Testing
---

web and server pyton tests were successful


Thanks,

Oliver Szabo

Review Request 46661: Put HBase master UI into readonly mode for secure deployment for HDP 2.5

2016-05-11 Thread Ajit Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46661/
---

Review request for Ambari, Robert Levas, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-16164
https://issues.apache.org/jira/browse/AMBARI-16164


Repository: ambari


Description
---

Currently in secure deployment, user can request compaction / splitting through 
hbase master UI.
This potentially exposes vulnerability to various attacks.
There is config parameter, hbase.master.ui.readonly, with default value of 
false.
In secure deployment, Master UI should be put to readonly mode (setting the 
above parameter to true).
Admin can always request compaction / splitting through hbase shell.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
3d689d7dd4f9c5bd98d5d4e0152775fd7ea012a2 

Diff: https://reviews.apache.org/r/46661/diff/


Testing
---

Manual testing, sceenshot attached (after kerberizing cluster).


File Attachments


hbase-site.png
  
https://reviews.apache.org/media/uploaded/files/2016/05/11/75e8d2ae-99a4-4e8d-8a69-52cd974734fb__hbase-site.png


Thanks,

Ajit Kumar

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46944/
---

(Updated May 11, 2016, 10:48 p.m.)


Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Myroslav 
Papirkovskyy, Sumit Mohanty, and Sebastian Toader.


Changes
---

- there was a stackoverflow exception during ambari-server start in that case 
if you have a cluster already, therefore I put back the loadServices for their 
original places.
- I removed an unnecessary check in the ClusterImpl#addService (check service 
already exists). Only ServiceImpl#persist() use addService method and that is 
only called from ServiceResourceProvider. Before adding a service, the provider 
validates that service already exists or not, so that check is not needed at 
all. (other usages are all from tests)


Bugs: AMBARI-16230
https://issues.apache.org/jira/browse/AMBARI-16230


Repository: ambari


Description
---

2 different type of errors can occur during adding any new service to Ambari:

org.apache.ambari.server.AmbariException: Unable to create a default alert 
group for unknown service  in cluster

org.apache.ambari.server.ServiceNotFoundException: Service not found, 
clusterName=c1, serviceName=

The reason is that: ServiceInstalledEvent can be handled quicker than 
ServiceImpl.persist() can finish


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 47342f3 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
487489b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 108732f 
  ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 
a3d05a9 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
19146fd 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
 d1b27a9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
 1875ba6 

Diff: https://reviews.apache.org/r/46944/diff/


Testing (updated)
---

Unit Testing is in progress..
FT: deploy cluster, add service, restart ambari with deployed cluster.


Thanks,

Oliver Szabo

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/
---

(Updated May 11, 2016, 10:08 p.m.)

Review request for Ambari, Di Li and Richard Zang.

Bugs: AMBARI-15552
https://issues.apache.org/jira/browse/AMBARI-15552

Repository: ambari

Description
---

Reproduction Steps:
1. Go to Admin->Manage Ambari
2. Create a group with a few users belonging to it.
(I have created "mygroup" with "user1", "user2", "user3")
(attachments "user1.tiff", "mygroup.tiff" shows samples)
3. Go to Clusters->Roles on the left navigation menu.
4. The default view is the "Block" view for the roles. Assign "mygroup" a role,
say "Cluster User".
(attachment "block_view_original.tiff")
5. Click on "List" view, it will show Users by default. It correctly shows the
role "Cluster User" for each user in "mygroup".
(attachment "list_view_users.tiff")
6. Now, try adding a new Role, say "Service Operator", to one of the users, say
"user3".
(attachments "list_view_add_role_to_user_step1.tiff",
"list_view_add_role_to_user_step2.tiff")
7. After making this change, the role gets added for that user (in our case
"user3"), but the roles from other users in its group gets removed. Also, the
previous role for the user ("user3") is replaced by the new Role.
(attachment "list_view_add_role_to_user_step3.tiff")
8. You can confirm this from the the "Block" view.
(attachment "block_view_after_step3.tiff")

So, the problem here lies with the List view where it is not able to process
the changes in the Roles correctly. A change in the Role of a user causes the
following:

CASE-1: The displayed role (effective privilege) comes from an explicitly
assigned role to the user.
1.1) The new selected role correctly replaces the existing privilege that was
explicitly assigned to the user.
1.2) But if the user was assigned multiple roles explicilty (before the fix for
AMBARI-16102 got pushed in), then all the other roles, which are of lower
privilege than the role that got replaced, are still displayed in the Block
view (because those roles are still in the database). So, if the new selected
role happened to be of a lower privilege than and existing role of the user,
then even though the user sees a success Alert message, the effective privileg
he sees is different. For the Ambari user, this behavior is not easily
understandable.

CASE-2: The displayed role (effective privilege) comes from a group the user
belongs to.
2.1) If the new selected privilege is higher than the effective privilege
coming from the user's group(s), then the newly selected role replaces this
"group" privilege in the database, insetad of creating a new entry.
2.2) As a result of losing the group privilege, all the group members also lose
their privileges and they show "None" as their effective privilege.
2.3) If the newly selected privilege is lower than effective group privilege,
the Alert message shows a success of role change but the effective privilge is
still not the one that the Ambari user selected.

Expected results:
1. Updating a Role of a user must replace any/all of the explicit roles it has
been assigned through the Block View. (this addresses 1.2)
Note: Even though AMBARI-16102 has attempted to fix the Block view by allowing
only a user to have just one role assigned to it, there could be cases where
the earlier version of Block view has already allowed users to have multiple
roles. So, taking this into consideration, the fix must address removing any or
all of the roles the user was assigned explicitly.
2. Adding a Role to a user must not affect the Roles of other users in its
group. (addressing 2.1 and 2.2)
3. Selecting a "NONE" for a user role shows the Alert "User's role chnaged to
None". This may not reflect the correct privilege status as the user might
have some effective privilege coming from its group(s). In the fix, the Alert
must show the relevant message.
4. Alert messages must show more informative messages of what is happening with
the user's privileges and why. (addressing 1.2 and 2.3)

Diffs
-

ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
32f46c1
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js
ff388cd

ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js
edf16be

Diff: https://reviews.apache.org/r/46808/diff/

Testing
---

The testing done mainly checks the logic used to update the privileges of the
user/group which is done after a REST call to retrieve the privileges.

The test cases have mocks setup for server calls. The response from the server
calls are also mocked to work with a particular set of users and groups.

The logic in the .then() clause following the server

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/
---

(Updated May 11, 2016, 10:08 p.m.)

Review request for Ambari, Di Li and Richard Zang.

Bugs: AMBARI-15552
https://issues.apache.org/jira/browse/AMBARI-15552

Repository: ambari

Description
---

So, the problem here lies with the List view where it is not able to process
the changes in the Roles correctly. A change in the Role of a user causes the
following:

Diffs (updated)
-

ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
11a73f6
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js
ff388cd

ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js
edf16be

Diff: https://reviews.apache.org/r/46808/diff/

Testing
---

The testing done mainly checks the logic used to update the privileges of the
user/group which is done after a REST call to retrieve the privileges.

The test cases have mocks setup for server calls. The response from the server
calls are also mocked to work with a particular set of users and groups.

The logic in the .then() clause following

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly



> On May 10, 2016, 10:28 p.m., Richard Zang wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js,
> >  line 162
> > 
> >
> > effectivePrivilegeFromGroups has been calculated on line 152 already.

Hello Richard,
Thank you for pointing this out. It was a redundant call. I have removed this 
statement in the new patch "AMBARI-15552-May-11.patch".


> On May 10, 2016, 10:28 p.m., Richard Zang wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js,
> >  line 181
> > 
> >
> > loadUser() needs to be called strictly after delete/add operation to 
> > have the up-to-date roles loaded. It's better to put it in the then block. 
> > This can be tested in the case I mentioned earlier: mygroup has "cluster 
> > user" role and aaa bbb ccc are in mygroup. Change aaa to "cluster 
> > administrator", confirm, then change aaa back to None, aaa stays at 
> > "cluster administrator" because loadUser() happens before delete finishes.

As per your suggestion, I have added "addPrivilege(user)" to the then clause of 
the deletePrivilege calls. Since I use individual delete calls for the various 
privilege IDs, I make use of "Prromise.all().then()" to ensure that 
addPrivilege() gets called only after all the delete calls are complete. The 
patch "AMBARI-15552-May-11.patch" contains these changes.
I couldn't figure out using "deletePrivileges()" to delete a set of privileges 
and so made use of these individual calls. If you think using the individual 
"deletePrivileges()" call is workable in this case, could you please provide me 
with the information on the valid attributes for the body.

Thank you!


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132555
---


On May 10, 2016, 7:49 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
> 
> (Updated May 10, 2016, 7:49 p.m.)
> 
> 
> Review request for Ambari, Di Li and Richard Zang.
> 
> 
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it. 
> (I have created "mygroup" with "user1", "user2", "user3") 
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a 
> role, say "Cluster User". 
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows 
> the role "Cluster User" for each user in "mygroup". 
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users, 
> say "user3". 
> (attachments "list_view_add_role_to_user_step1.tiff", 
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case 
> "user3"), but the roles from other users in its group gets removed. Also, the 
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view. 
> (attachment "block_view_after_step3.tiff")
> 
> So, the problem here lies with the List view where it is not able to process 
> the changes in the Roles correctly. A change in the Role of a user causes the 
> following:
> 
> CASE-1: The displayed role (effective privilege) comes from an explicitly 
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was 
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix 
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower 
> privilege than the role that got replaced, are still displayed in the Block 
> view (because those roles are still in the database). So, if the new selected 
> role happened to be of a lower privilege than and existing role of the user, 
> then even though the user sees a success Alert message, the effective 
> privileg he sees is different. For the Ambari user, this behavior is not 
> easily understandable.
> 
> CASE-2: The displayed role (effective privilege) comes from a group the user 
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege 
>

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly



> On May 10, 2016, 10:31 p.m., Richard Zang wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js,
> >  line 165
> > 
> >
> > if user change permission to None, currentIndex will be -1. I would 
> > recommend creating a function like getRoleRank which will give out a rank 
> > for all roles including None and View User.

I have added a new function $scope.getRoleRank(permission_name) that returns 
the index of the permission. As per your suggestions, I have added VIEW.USER 
and CLUSTER.NONE to the list of OrderedRoles. CLUSTER.NONE is the last in the 
ordered list with an index of '6'.
I have updated the code accordingly in the patch "AMBARI-15552-May-11.patch".


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132558
---


On May 10, 2016, 7:49 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
> 
> (Updated May 10, 2016, 7:49 p.m.)
> 
> 
> Review request for Ambari, Di Li and Richard Zang.
> 
> 
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it. 
> (I have created "mygroup" with "user1", "user2", "user3") 
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a 
> role, say "Cluster User". 
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows 
> the role "Cluster User" for each user in "mygroup". 
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users, 
> say "user3". 
> (attachments "list_view_add_role_to_user_step1.tiff", 
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case 
> "user3"), but the roles from other users in its group gets removed. Also, the 
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view. 
> (attachment "block_view_after_step3.tiff")
> 
> So, the problem here lies with the List view where it is not able to process 
> the changes in the Roles correctly. A change in the Role of a user causes the 
> following:
> 
> CASE-1: The displayed role (effective privilege) comes from an explicitly 
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was 
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix 
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower 
> privilege than the role that got replaced, are still displayed in the Block 
> view (because those roles are still in the database). So, if the new selected 
> role happened to be of a lower privilege than and existing role of the user, 
> then even though the user sees a success Alert message, the effective 
> privileg he sees is different. For the Ambari user, this behavior is not 
> easily understandable.
> 
> CASE-2: The displayed role (effective privilege) comes from a group the user 
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege 
> coming from the user's group(s), then the newly selected role replaces this 
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also 
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege, 
> the Alert message shows a success of role change but the effective privilge 
> is still not the one that the Ambari user selected.
> 
> 
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it 
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by 
> allowing only a user to have just one role assigned to it, there could be 
> cases where the earlier version of Block view has already allowed users to 
> have multiple roles. So, taking this into consideration, the fix must address 
> removing any or all of the roles the user was assigned explicitly.
> 2.

Re: Review Request 47009: Falcon server start fails

2016-05-11 Thread Tom Beerbower


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/
---

(Updated May 11, 2016, 8:52 p.m.)


Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.


Changes
---

Updated diff


Bugs: AMBARI-16263
https://issues.apache.org/jira/browse/AMBARI-16263


Repository: ambari


Description
---

Deployed HDP-2.5 and Falcon server failed to start.


cat /var/log/falcon/falcon.out.20160504002*
Error: Could not find or load main class org.apache.falcon.FalconServer
Error: Could not find or load main class org.apache.falcon.FalconServer
Error: Could not find or load main class org.apache.falcon.FalconServer


The command to start, in Ambari is:


Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000'] 
{'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path': 
['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}


Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/* 
/server/webapp/falcon/WEB-INF/lib/'
is what is causing it. If falcon webapp is already exploded it will fail for 
falcon webapp itself. That step should not be done and we should change it to 
add falcon hook into webapp.jar itself post deployment like what we do for 
Oozie with prepare-war or added to server classpath explicitly


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
 3fdf2e6 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 bf7f437 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
 4b7c0c3 

Diff: https://reviews.apache.org/r/47009/diff/


Testing
---

mvn clean test


Thanks,

Tom Beerbower

Re: Review Request 47256: Atlas Integration : Atlas fails to come up with solr as indexing search when the zookeeper quorum has more than one host

2016-05-11 Thread Tom Beerbower


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47256/
---

(Updated May 11, 2016, 8:41 p.m.)


Review request for Ambari, John Speidel and Nate Cole.


Bugs: AMBARI-16464
https://issues.apache.org/jira/browse/AMBARI-16464


Repository: ambari


Description (updated)
---

Atlas fails to communicate with solr when the zookeeper quorum has more than 
one host, as a result of this atlas fails to come up.

The config parameter "atlas.graph.index.search.solr.zookeeper-url" value is set 
to "zookeeper_quorum/logsearch". Since there are more than one zookeeper 
servers deployed, this value evaluates to 
"[os-r6-apathan-atlas-erie-nosec-3.openstacklocal:2181, 
os-r6-apathan-atlas-erie-nosec-2.openstacklocal:2181/logsearch]".

The value was set to match the value of the ZK connection string in the 
logsearch solr-env.sh ...
# Set the ZooKeeper connection string if using an external ZooKeeper 
ensemble
# e.g. host1:2181,host2:2181/chroot
# Leave empty if not using SolrCloud

ZK_HOST="c6401.ambari.apache.org:2181,c6402.ambari.apache.org:2181,c6403.ambari.apache.org:2181/logsearch"

It looks like for atlas.graph.index.search.solr.zookeeper-url it should be ...

c6401.ambari.apache.org:2181/logsearch,c6402.ambari.apache.org:2181/logsearch,c6403.ambari.apache.org:2181/logsearch

Also needed to update the atlas user-credential.properites and policy-store.txt 
to get Atlas to deploy (due to recent changes in Atlas).


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/files/policy-store.txt
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/files/users-credentials.properties
 4d264a0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 8e2fcc2 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 51fa039 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
 78600ee 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
3d689d7 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
8ae2c11 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 422b1c9 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py e9ddc25 

Diff: https://reviews.apache.org/r/47256/diff/


Testing
---

Updated unit tests.

mvn clean test


Thanks,

Tom Beerbower

Re: Review Request 47233: Files view: typo in message shown on upload files window


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47233/#review132739
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 11, 2016, 1:26 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47233/
> ---
> 
> (Updated May 11, 2016, 1:26 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16450
> https://issues.apache.org/jira/browse/AMBARI-16450
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update the message.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/files/src/main/resources/ui/app/templates/components/upload-file.hbs
>  62714f9 
> 
> Diff: https://reviews.apache.org/r/47233/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47248: DevDeploy: ambari-server start failed

2016-05-11 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47248/#review132728
---


Ship it!




Ship It!

- Sumit Mohanty


On May 11, 2016, 6:30 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47248/
> ---
> 
> (Updated May 11, 2016, 6:30 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16460
> https://issues.apache.org/jira/browse/AMBARI-16460
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> 2016-05-11 16:51:17,485  INFO - *** Check 
> database started ***
> 2016-05-11 16:51:25,237  INFO - Checking for configs not mapped to any cluster
> 2016-05-11 16:51:25,268  INFO - Checking for configs selected more than once
> 2016-05-11 16:51:25,271  INFO - Checking for hosts without state
> 2016-05-11 16:51:25,278  INFO - Checking host component states count equals 
> host component desired states count
> 2016-05-11 16:51:25,285  INFO - Checking services and their configs
> 2016-05-11 16:51:28,813 ERROR - Unexpected error, database check failed
> com.google.inject.ProvisionException: Guice provision errors:
> 
> 1) Error injecting method, Exception [EclipseLink-4011] (Eclipse Persistence 
> Services - 2.6.2.v20151217-774c696): 
> org.eclipse.persistence.exceptions.DatabaseException
> Exception Description: Error preallocating sequence numbers.  The sequence 
> table information is not complete.
>   at 
> org.apache.ambari.server.api.services.AmbariMetaInfo.init(AmbariMetaInfo.java:253)
>   at 
> org.apache.ambari.server.api.services.AmbariMetaInfo.class(AmbariMetaInfo.java:133)
>   while locating org.apache.ambari.server.api.services.AmbariMetaInfo
> 
> 1 error
> at 
> com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:987)
> at 
> com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1013)
> at 
> org.apache.ambari.server.checks.DatabaseConsistencyCheckHelper.checkServiceConfigs(DatabaseConsistencyCheckHelper.java:401)
> at 
> org.apache.ambari.server.checks.DatabaseConsistencyChecker.main(DatabaseConsistencyChecker.java:115)
> Caused by: Exception [EclipseLink-4011] (Eclipse Persistence Services - 
> 2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
> Exception Description: Error preallocating sequence numbers.  The sequence 
> table information is not complete.
> at 
> org.eclipse.persistence.exceptions.DatabaseException.errorPreallocatingSequenceNumbers(DatabaseException.java:150)
> at 
> org.eclipse.persistence.sequencing.StandardSequence.getGeneratedVector(StandardSequence.java:73)
> at 
> org.eclipse.persistence.sequencing.Sequence.getGeneratedVector(Sequence.java:257)
> at 
> org.eclipse.persistence.internal.sequencing.SequencingManager$Preallocation_Transaction_NoAccessor_State.getNextValue(SequencingManager.java:485)
> at 
> org.eclipse.persistence.internal.sequencing.SequencingManager.getNextValue(SequencingManager.java:1107)
> at 
> org.eclipse.persistence.internal.sequencing.ClientSessionSequencing.getNextValue(ClientSessionSequencing.java:70)
> at 
> org.eclipse.persistence.internal.descriptors.ObjectBuilder.assignSequenceNumber(ObjectBuilder.java:362)
> at 
> org.eclipse.persistence.internal.descriptors.ObjectBuilder.assignSequenceNumber(ObjectBuilder.java:321)
> at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.assignSequenceNumber(UnitOfWorkImpl.java:486)
> at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.registerNotRegisteredNewObjectForPersist(UnitOfWorkImpl.java:4288)
> at 
> org.eclipse.persistence.internal.sessions.RepeatableWriteUnitOfWork.registerNotRegisteredNewObjectForPersist(RepeatableWriteUnitOfWork.java:521)
> at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.registerNewObjectForPersist(UnitOfWorkImpl.java:4233)
> at 
> org.eclipse.persistence.internal.jpa.EntityManagerImpl.persist(EntityManagerImpl.java:507)
> at org.apache.ambari.server.orm.dao.StackDAO.create(StackDAO.java:106)
> at 
> org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:128)
> at 
> org.apache.ambari.server.stack.StackManager.(StackManager.java:136)
> at 
> org.apache.ambari.server.stack.StackManager$$FastClassByGuice$$33e4ffe0.newInstance()
> at 
> com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40)
> at 
>

Re: Review Request 47248: DevDeploy: ambari-server start failed

2016-05-11 Thread Dmytro Grinenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47248/#review132726
---


Ship it!




Ship It!

- Dmytro Grinenko


On May 11, 2016, 6:30 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47248/
> ---
> 
> (Updated May 11, 2016, 6:30 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16460
> https://issues.apache.org/jira/browse/AMBARI-16460
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> 2016-05-11 16:51:17,485  INFO - *** Check 
> database started ***
> 2016-05-11 16:51:25,237  INFO - Checking for configs not mapped to any cluster
> 2016-05-11 16:51:25,268  INFO - Checking for configs selected more than once
> 2016-05-11 16:51:25,271  INFO - Checking for hosts without state
> 2016-05-11 16:51:25,278  INFO - Checking host component states count equals 
> host component desired states count
> 2016-05-11 16:51:25,285  INFO - Checking services and their configs
> 2016-05-11 16:51:28,813 ERROR - Unexpected error, database check failed
> com.google.inject.ProvisionException: Guice provision errors:
> 
> 1) Error injecting method, Exception [EclipseLink-4011] (Eclipse Persistence 
> Services - 2.6.2.v20151217-774c696): 
> org.eclipse.persistence.exceptions.DatabaseException
> Exception Description: Error preallocating sequence numbers.  The sequence 
> table information is not complete.
>   at 
> org.apache.ambari.server.api.services.AmbariMetaInfo.init(AmbariMetaInfo.java:253)
>   at 
> org.apache.ambari.server.api.services.AmbariMetaInfo.class(AmbariMetaInfo.java:133)
>   while locating org.apache.ambari.server.api.services.AmbariMetaInfo
> 
> 1 error
> at 
> com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:987)
> at 
> com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1013)
> at 
> org.apache.ambari.server.checks.DatabaseConsistencyCheckHelper.checkServiceConfigs(DatabaseConsistencyCheckHelper.java:401)
> at 
> org.apache.ambari.server.checks.DatabaseConsistencyChecker.main(DatabaseConsistencyChecker.java:115)
> Caused by: Exception [EclipseLink-4011] (Eclipse Persistence Services - 
> 2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
> Exception Description: Error preallocating sequence numbers.  The sequence 
> table information is not complete.
> at 
> org.eclipse.persistence.exceptions.DatabaseException.errorPreallocatingSequenceNumbers(DatabaseException.java:150)
> at 
> org.eclipse.persistence.sequencing.StandardSequence.getGeneratedVector(StandardSequence.java:73)
> at 
> org.eclipse.persistence.sequencing.Sequence.getGeneratedVector(Sequence.java:257)
> at 
> org.eclipse.persistence.internal.sequencing.SequencingManager$Preallocation_Transaction_NoAccessor_State.getNextValue(SequencingManager.java:485)
> at 
> org.eclipse.persistence.internal.sequencing.SequencingManager.getNextValue(SequencingManager.java:1107)
> at 
> org.eclipse.persistence.internal.sequencing.ClientSessionSequencing.getNextValue(ClientSessionSequencing.java:70)
> at 
> org.eclipse.persistence.internal.descriptors.ObjectBuilder.assignSequenceNumber(ObjectBuilder.java:362)
> at 
> org.eclipse.persistence.internal.descriptors.ObjectBuilder.assignSequenceNumber(ObjectBuilder.java:321)
> at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.assignSequenceNumber(UnitOfWorkImpl.java:486)
> at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.registerNotRegisteredNewObjectForPersist(UnitOfWorkImpl.java:4288)
> at 
> org.eclipse.persistence.internal.sessions.RepeatableWriteUnitOfWork.registerNotRegisteredNewObjectForPersist(RepeatableWriteUnitOfWork.java:521)
> at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.registerNewObjectForPersist(UnitOfWorkImpl.java:4233)
> at 
> org.eclipse.persistence.internal.jpa.EntityManagerImpl.persist(EntityManagerImpl.java:507)
> at org.apache.ambari.server.orm.dao.StackDAO.create(StackDAO.java:106)
> at 
> org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:128)
> at 
> org.apache.ambari.server.stack.StackManager.(StackManager.java:136)
> at 
> org.apache.ambari.server.stack.StackManager$$FastClassByGuice$$33e4ffe0.newInstance()
> at 
> com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40)
> at 
>

Review Request 47248: DevDeploy: ambari-server start failed

2016-05-11 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47248/
---

Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-16460
https://issues.apache.org/jira/browse/AMBARI-16460


Repository: ambari


Description
---

{code}
2016-05-11 16:51:17,485  INFO - *** Check database 
started ***
2016-05-11 16:51:25,237  INFO - Checking for configs not mapped to any cluster
2016-05-11 16:51:25,268  INFO - Checking for configs selected more than once
2016-05-11 16:51:25,271  INFO - Checking for hosts without state
2016-05-11 16:51:25,278  INFO - Checking host component states count equals 
host component desired states count
2016-05-11 16:51:25,285  INFO - Checking services and their configs
2016-05-11 16:51:28,813 ERROR - Unexpected error, database check failed
com.google.inject.ProvisionException: Guice provision errors:

1) Error injecting method, Exception [EclipseLink-4011] (Eclipse Persistence 
Services - 2.6.2.v20151217-774c696): 
org.eclipse.persistence.exceptions.DatabaseException
Exception Description: Error preallocating sequence numbers.  The sequence 
table information is not complete.
  at 
org.apache.ambari.server.api.services.AmbariMetaInfo.init(AmbariMetaInfo.java:253)
  at 
org.apache.ambari.server.api.services.AmbariMetaInfo.class(AmbariMetaInfo.java:133)
  while locating org.apache.ambari.server.api.services.AmbariMetaInfo

1 error
at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:987)
at 
com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1013)
at 
org.apache.ambari.server.checks.DatabaseConsistencyCheckHelper.checkServiceConfigs(DatabaseConsistencyCheckHelper.java:401)
at 
org.apache.ambari.server.checks.DatabaseConsistencyChecker.main(DatabaseConsistencyChecker.java:115)
Caused by: Exception [EclipseLink-4011] (Eclipse Persistence Services - 
2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
Exception Description: Error preallocating sequence numbers.  The sequence 
table information is not complete.
at 
org.eclipse.persistence.exceptions.DatabaseException.errorPreallocatingSequenceNumbers(DatabaseException.java:150)
at 
org.eclipse.persistence.sequencing.StandardSequence.getGeneratedVector(StandardSequence.java:73)
at 
org.eclipse.persistence.sequencing.Sequence.getGeneratedVector(Sequence.java:257)
at 
org.eclipse.persistence.internal.sequencing.SequencingManager$Preallocation_Transaction_NoAccessor_State.getNextValue(SequencingManager.java:485)
at 
org.eclipse.persistence.internal.sequencing.SequencingManager.getNextValue(SequencingManager.java:1107)
at 
org.eclipse.persistence.internal.sequencing.ClientSessionSequencing.getNextValue(ClientSessionSequencing.java:70)
at 
org.eclipse.persistence.internal.descriptors.ObjectBuilder.assignSequenceNumber(ObjectBuilder.java:362)
at 
org.eclipse.persistence.internal.descriptors.ObjectBuilder.assignSequenceNumber(ObjectBuilder.java:321)
at 
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.assignSequenceNumber(UnitOfWorkImpl.java:486)
at 
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.registerNotRegisteredNewObjectForPersist(UnitOfWorkImpl.java:4288)
at 
org.eclipse.persistence.internal.sessions.RepeatableWriteUnitOfWork.registerNotRegisteredNewObjectForPersist(RepeatableWriteUnitOfWork.java:521)
at 
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.registerNewObjectForPersist(UnitOfWorkImpl.java:4233)
at 
org.eclipse.persistence.internal.jpa.EntityManagerImpl.persist(EntityManagerImpl.java:507)
at org.apache.ambari.server.orm.dao.StackDAO.create(StackDAO.java:106)
at 
org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:128)
at 
org.apache.ambari.server.stack.StackManager.(StackManager.java:136)
at 
org.apache.ambari.server.stack.StackManager$$FastClassByGuice$$33e4ffe0.newInstance()
at 
com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40)
at 
com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:60)
at 
com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85)
at 
com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254)
at 
com.google.inject.internal.InjectorImpl$4$1.call(InjectorImpl.java:978)
at 
com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1031)
at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:974)
at

Re: Review Request 47244: AMBARI-16440 : Flush metrics to collector if metric system is stopped gracefully in the Sink daemon

2016-05-11 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47244/#review132693
---




ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 (line 395)


Why not keep the same thread and just submit task to it?


- Sid Wagle


On May 11, 2016, 5 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47244/
> ---
> 
> (Updated May 11, 2016, 5 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16440
> https://issues.apache.org/jira/browse/AMBARI-16440
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HBase Regionserver daemons shuts down and restarts the Metric System for 
> every 5 minutes to make sure there is no growth of metrics. This causes AMS 
> Hadoop sink to lose metrics intermittently, which was buffered during that 
> time. This leads to holes in data and negative rates in graphs.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
>  3316a54 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  35b9459 
> 
> Diff: https://reviews.apache.org/r/47244/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> Unit tests pending.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-11 Thread Juanjo Marron



> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote:
> > I think we need more testing on this apart from unit tests to ensure all 
> > imports are there.
> 
> Juanjo  Marron wrote:
> Hi Jayush,
> 
> Thanks for the review.
> I'll add this couple of missing imports to ACCUMULO service check
> 
> I reviewed UTs, I did a fresh installation, no service-check run though. 
> Ill do service check as well from now. Any other test you think can be 
> required?
> 
> Also, Atlas installation was failing in trunk (even without this change 
> set) so I would need to retry on top of a stable trunk versions
> 
> Juanjo  Marron wrote:
> Please, wait review for now, more test on these services is being 
> performed
> Thanks
> 
> Juanjo  Marron wrote:
> Hi Jasyuh, please could you review the final patch?
> 
> Thanks
> 
> Jayush Luniya wrote:
> @Juanjo,
> I am out of office and will review this patch tomorrow once I am back.

Great! Thanks


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46853/#review131209
---


On May 3, 2016, 6:12 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46853/
> ---
> 
> (Updated May 3, 2016, 6:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16175
> https://issues.apache.org/jira/browse/AMBARI-16175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This  subtask cleans up import * from resource_management and replace it for 
> specific imports for:
> Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
>  09a3d90 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
>  33d3273 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/service_check.py
>  a7067cb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
>  3c3d804 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
>  eb1b6d7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
>  7fb9715 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
>  b769a0d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
>  cf0efef 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py
>  4d0d7f3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  a5abe1c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  32b8fdb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
>  21b491d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
>  3c4bffc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  2bdb4c0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  43c1ea6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  4b08cbc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  defd6f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  194a3fb 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  4c54214 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  64ace1a 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  a201619 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server_upgrade.py
>  6277086 
>   
>

Re: Review Request 47235: Takeover script on Paypal configs results in conflict message that look wrong

2016-05-11 Thread Srimanth Gunturi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47235/#review132678
---


Ship it!




Ship It!

- Srimanth Gunturi


On May 11, 2016, 1:54 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47235/
> ---
> 
> (Updated May 11, 2016, 1:54 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Sid Wagle.
> 
> 
> Bugs: AMBARI-16451
> https://issues.apache.org/jira/browse/AMBARI-16451
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Attaching the zip file with configs and conflicts.
> 
>   * The conflicting configs seem to have a lot of duplicate info  
> mapred-site :: dfs.datanode.du.reserved
> 
>   * Unable to handle empty config files:  
> Had to hand edit and add try / catch at :
> 
> > yaml.load(file).iteritems()
> 
> > parsed_configurations_from_path, parsed_properties_attributes =
> parser.read_data_to_map(path)
> 
> 
> 
> 
> Traceback (most recent call last):
>   File "./takeover_config_merge.py", line 393, in 
> sys.exit(main())
>   File "./takeover_config_merge.py", line 389, in main
> return configMerge.perform_merge()
>   File "./takeover_config_merge.py", line 279, in perform_merge
> parsed_configurations_from_path, parsed_properties_attributes = 
> parser.read_data_to_map(path)
>   File "./takeover_config_merge.py", line 86, in read_data_to_map
> for name, value in yaml.load(file).iteritems():
> AttributeError: 'NoneType' object has no attribute 'iteritems'
> 
> 
> _Instruction_
> 
> 
> 
> 
> ./takeover_config_merge.py -o blueprint -i files
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/takeover_config_merge.py 1432e4b 
> 
> Diff: https://reviews.apache.org/r/47235/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47202: Restarting Upgraded Component During a Paused Upgrade Downgrades Component To Old Version

2016-05-11 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47202/
---

(Updated May 11, 2016, 12:17 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-16439
https://issues.apache.org/jira/browse/AMBARI-16439


Repository: ambari


Description
---

There is a regression on the 2.4.0 line when restarting components during a 
paused upgrade. 

STR:
- Upgrade from HDP 2.3 to HDP 2.4, but don't finalize
- Suspend the upgrade on the finalization step
- Restart a ZooKeeper Server

The commands being sent down have 2.3.x instead of 2.4.0:
```
"commandParams": {
"service_package_folder": "common-services/ZOOKEEPER/3.4.5/package",
"script": "scripts/zookeeper_server.py",
"hooks_folder": "HDP/2.0.6/hooks",
"version": "2.3.4.0-3485",
"command_timeout": "1200",
"script_type": "PYTHON"
},

"hostLevelParams": {
"current_version": "2.3.4.0-3485",
"custom_command": "RESTART",
"stack_version": "2.4",
```

The problem is located in {{ClusterImpl}} in how it calculates the upgrade. In 
Ambari 2.2.2, it searched for upgrades, which also returned suspended upgrades. 
In 2.4.0, it only looks at a currently running upgrade:

- 2.4.0
`UpgradeEntity upgradeInProgress = getUpgradeEntity();`


- 2.2.2
`UpgradeEntity upgradeInProgress = this.getUpgradeInProgress();`


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 34a0918 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 c587e9f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 6dbceba 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 b14e9e5 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
cf2c9aa 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 f38c25a 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
 3a8b396 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47202/diff/


Testing (updated)
---

Manual upgrade/downgrad/suspend test on a running cluster

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 01:15 h
[INFO] Finished at: 2016-05-11T00:08:57-04:00
[INFO] Final Memory: 39M/410M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 47202: Restarting Upgraded Component During a Paused Upgrade Downgrades Component To Old Version

2016-05-11 Thread Jonathan Hurley



> On May 10, 2016, 9:19 p.m., Nate Cole wrote:
> > Good grief.  I think this was my bad code.

Good grief is right - looks like a really hard merge between 2.2.2 and 2.4.0 
which caused this. The side-effect of my fix, the repo version ID problem, was 
unexpected. I would like to say that this would only be passed down on installs 
instead of all "actions", but the quicker fix here was to just ignore it in the 
agent response if the cluster is upgrading.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47202/#review132591
---


On May 11, 2016, 12:17 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47202/
> ---
> 
> (Updated May 11, 2016, 12:17 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-16439
> https://issues.apache.org/jira/browse/AMBARI-16439
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There is a regression on the 2.4.0 line when restarting components during a 
> paused upgrade. 
> 
> STR:
> - Upgrade from HDP 2.3 to HDP 2.4, but don't finalize
> - Suspend the upgrade on the finalization step
> - Restart a ZooKeeper Server
> 
> The commands being sent down have 2.3.x instead of 2.4.0:
> ```
> "commandParams": {
> "service_package_folder": "common-services/ZOOKEEPER/3.4.5/package",
> "script": "scripts/zookeeper_server.py",
> "hooks_folder": "HDP/2.0.6/hooks",
> "version": "2.3.4.0-3485",
> "command_timeout": "1200",
> "script_type": "PYTHON"
> },
> 
> "hostLevelParams": {
> "current_version": "2.3.4.0-3485",
> "custom_command": "RESTART",
> "stack_version": "2.4",
> ```
> 
> The problem is located in {{ClusterImpl}} in how it calculates the upgrade. 
> In Ambari 2.2.2, it searched for upgrades, which also returned suspended 
> upgrades. In 2.4.0, it only looks at a currently running upgrade:
> 
> - 2.4.0
> `UpgradeEntity upgradeInProgress = getUpgradeEntity();`
> 
> 
> - 2.2.2
> `UpgradeEntity upgradeInProgress = this.getUpgradeInProgress();`
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  34a0918 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  c587e9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  6dbceba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  b14e9e5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> cf2c9aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  f38c25a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
>  3a8b396 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47202/diff/
> 
> 
> Testing
> ---
> 
> Manual upgrade/downgrad/suspend test on a running cluster
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:15 h
> [INFO] Finished at: 2016-05-11T00:08:57-04:00
> [INFO] Final Memory: 39M/410M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 47235: Takeover script on Paypal configs results in conflict message that look wrong

2016-05-11 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47235/#review132667
---


Ship it!




Ship It!

- Sid Wagle


On May 11, 2016, 1:54 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47235/
> ---
> 
> (Updated May 11, 2016, 1:54 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Sid Wagle.
> 
> 
> Bugs: AMBARI-16451
> https://issues.apache.org/jira/browse/AMBARI-16451
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Attaching the zip file with configs and conflicts.
> 
>   * The conflicting configs seem to have a lot of duplicate info  
> mapred-site :: dfs.datanode.du.reserved
> 
>   * Unable to handle empty config files:  
> Had to hand edit and add try / catch at :
> 
> > yaml.load(file).iteritems()
> 
> > parsed_configurations_from_path, parsed_properties_attributes =
> parser.read_data_to_map(path)
> 
> 
> 
> 
> Traceback (most recent call last):
>   File "./takeover_config_merge.py", line 393, in 
> sys.exit(main())
>   File "./takeover_config_merge.py", line 389, in main
> return configMerge.perform_merge()
>   File "./takeover_config_merge.py", line 279, in perform_merge
> parsed_configurations_from_path, parsed_properties_attributes = 
> parser.read_data_to_map(path)
>   File "./takeover_config_merge.py", line 86, in read_data_to_map
> for name, value in yaml.load(file).iteritems():
> AttributeError: 'NoneType' object has no attribute 'iteritems'
> 
> 
> _Instruction_
> 
> 
> 
> 
> ./takeover_config_merge.py -o blueprint -i files
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/takeover_config_merge.py 1432e4b 
> 
> Diff: https://reviews.apache.org/r/47235/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 47236: [Hive View] EXPLAIN text is spilling out


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47236/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16452
https://issues.apache.org/jira/browse/AMBARI-16452


Repository: ambari


Description
---

Added CSS to take care of text spill


Diffs
-

  contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 8f60595 

Diff: https://reviews.apache.org/r/47236/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Review Request 47239: [Move Master][History Server] Service check fails after moving HistoryServer to another host

2016-05-11 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47239/
---

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.


Bugs: AMBARI-16453
https://issues.apache.org/jira/browse/AMBARI-16453


Repository: ambari


Description
---

{code}
16/05/06 07:06:23 ERROR lzo.GPLNativeCodeLoader: Could not load native gpl 
library
java.lang.UnsatisfiedLinkError: no gplcompression in java.library.path
at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1867)
at java.lang.Runtime.loadLibrary0(Runtime.java:870)
at java.lang.System.loadLibrary(System.java:1122)
at 
com.hadoop.compression.lzo.GPLNativeCodeLoader.(GPLNativeCodeLoader.java:32)
at com.hadoop.compression.lzo.LzoCodec.(LzoCodec.java:71)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:348)
at 
org.apache.hadoop.conf.Configuration.getClassByNameOrNull(Configuration.java:2147)
at 
org.apache.hadoop.conf.Configuration.getClassByName(Configuration.java:2112)
at 
org.apache.hadoop.io.compress.CompressionCodecFactory.getCodecClasses(CompressionCodecFactory.java:132)
at 
org.apache.hadoop.io.compress.CompressionCodecFactory.(CompressionCodecFactory.java:179)
at 
org.apache.hadoop.mapreduce.lib.input.TextInputFormat.isSplitable(TextInputFormat.java:58)
at 
org.apache.hadoop.mapreduce.lib.input.FileInputFormat.getSplits(FileInputFormat.java:399)
at 
org.apache.hadoop.mapreduce.JobSubmitter.writeNewSplits(JobSubmitter.java:301)
at 
org.apache.hadoop.mapreduce.JobSubmitter.writeSplits(JobSubmitter.java:318)
at 
org.apache.hadoop.mapreduce.JobSubmitter.submitJobInternal(JobSubmitter.java:196)
at org.apache.hadoop.mapreduce.Job$10.run(Job.java:1290)
at org.apache.hadoop.mapreduce.Job$10.run(Job.java:1287)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1719)
at org.apache.hadoop.mapreduce.Job.submit(Job.java:1287)
at org.apache.hadoop.mapreduce.Job.waitForCompletion(Job.java:1308)
at org.apache.hadoop.examples.WordCount.main(WordCount.java:87)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.apache.hadoop.util.ProgramDriver$ProgramDescription.invoke(ProgramDriver.java:71)
at org.apache.hadoop.util.ProgramDriver.run(ProgramDriver.java:144)
at org.apache.hadoop.examples.ExampleDriver.main(ExampleDriver.java:74)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
16/05/06 07:06:23 ERROR lzo.LzoCodec: Cannot load native-lzo without 
native-hadoop
16/05/06 07:06:23 INFO mapreduce.JobSubmitter: number of splits:1
16/05/06 07:06:23 INFO mapreduce.JobSubmitter: Submitting tokens for job: 
job_1462518135627_0001
16/05/06 07:06:24 INFO impl.YarnClientImpl: Submitted application 
application_1462518135627_0001
16/05/06 07:06:24 INFO mapreduce.Job: The url to track the job: 
http://ambarirmps-5.openstacklocal:8088/proxy/application_1462518135627_0001/
16/05/06 07:06:24 INFO mapreduce.Job: Running job: job_1462518135627_0001
16/05/06 07:06:35 INFO mapreduce.Job: Job job_1462518135627_0001 running in 
uber mode : false
16/05/06 07:06:35 INFO mapreduce.Job:  map 0% reduce 0%
16/05/06 07:06:42 INFO mapreduce.Job:  map 100% reduce 0%

{code}


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 
40e05ff 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 
0ea7da9 

Diff: https://reviews.apache.org/r/47239/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 47117: HiveServer interactive fails to start

2016-05-11 Thread Daniel Gergely

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/
---

(Updated máj. 11, 2016, 2:53 du)

Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo,
Sandor Magyari, and Sebastian Toader.

Changes
---

Memory setting is needed to be added even if other llap related configs are
skipped. (hive.llap.daemon.yarn.container.mb must be greater or equal to
yarn.scheduler.allocation-minimum-mb, otherwise hive server interactive does
not start)

Bugs: AMBARI-16303
https://issues.apache.org/jira/browse/AMBARI-16303

Repository: ambari

Description
---

If Total Daemon Size of hive server interactive is less than yarn container
minimum size, then hive server interactive fails to start. Stack advisor was
corrected to take yarn container size into account.
The property *hive_server_interactive_host* was not resolved, not it is. It was
simply missing from the BlueprintConfigurationProcessor.

Diffs (updated)
-

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
29f937a
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
37e6ef6
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py e9ddc25

Diff: https://reviews.apache.org/r/47117/diff/

Testing
---

The stack advisor issue is checked manually.
The blueprint issue is also checked manually, a separated unit test checks if
the resolver itself works correctly.

Tests run: 4312, Failures: 0, Errors: 7, Skipped: 34
(failing tests are not related to this issue)

Thanks,

Daniel Gergely

Re: Review Request 47232: LogFeeder: abillity to enable/disable global exclusion filter (appendum patch)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47232/
---

(Updated May 11, 2016, 2:37 p.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.


Changes
---

added zkHosts param to logfeeder.properties


Bugs: AMBARI-16305
https://issues.apache.org/jira/browse/AMBARI-16305


Repository: ambari


Description
---

In logfeeder.properties, logfeeder.log.filter.enable=True instead of 
logfeeder.log.filter.enable=true


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 183425a 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
 bd93846 

Diff: https://reviews.apache.org/r/47232/diff/


Testing
---

Total run:1014
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

2016-05-11 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47237/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, and Richard Zang.


Bugs: AMBARI-16449
https://issues.apache.org/jira/browse/AMBARI-16449


Repository: ambari


Description
---

Change permission_label for role AMBARI.ADMINISTRATOR from "Administrator" to 
"Ambari Admin"


Diffs
-

  ambari-server/docs/api/v1/permission-get.md d949344 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
 2389d0d 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql d77a0b3 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 22413e0 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6000d24 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 67bd38a 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
ea7ab7a 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1c3393e 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 2245f77 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
 67a94ea 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java
 f03d240 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java
 bcfae8d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java
 4e0ba24 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java
 6cf520d 

Diff: https://reviews.apache.org/r/47237/diff/


Testing
---

Manually tested upgrade and new instance creation.

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 47226: AMBARI-16444 Ambari router field is not configurable in solr-client

2016-05-11 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47226/#review132657
---


Ship it!




Ship It!

- Robert Nettleton


On May 11, 2016, 9:32 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47226/
> ---
> 
> (Updated May 11, 2016, 9:32 a.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16444
> https://issues.apache.org/jira/browse/AMBARI-16444
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - router field not configurable corretly in the cli of solr-client.
> - also change default znode for logsearch solr
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
>  74ea547 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  ce53692 
> 
> Diff: https://reviews.apache.org/r/47226/diff/
> 
> 
> Testing
> ---
> 
> Total run:1014   
> Total errors:0   
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 47232: LogFeeder: abillity to enable/disable global exclusion filter (appendum patch)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47232/
---

Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-16305
https://issues.apache.org/jira/browse/AMBARI-16305


Repository: ambari


Description
---

In logfeeder.properties, logfeeder.log.filter.enable=True instead of 
logfeeder.log.filter.enable=true


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 183425a 

Diff: https://reviews.apache.org/r/47232/diff/


Testing
---

Total run:1014
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 47229: [UI Issue]Execution of empty pig script allowed from UI


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47229/#review132644
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 11, 2016, 11:36 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47229/
> ---
> 
> (Updated May 11, 2016, 11:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16447
> https://issues.apache.org/jira/browse/AMBARI-16447
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Added a condition for checking empty pig script.
> - If the script is empty, showing an error.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/scriptEdit.js 
> 60a04ce 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/translations.js 5bb8cf7 
> 
> Diff: https://reviews.apache.org/r/47229/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47227: [Hive View] Error while Closing unsaved Sheet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47227/#review132643
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 11, 2016, 9:45 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47227/
> ---
> 
> (Updated May 11, 2016, 9:45 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16445
> https://issues.apache.org/jira/browse/AMBARI-16445
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Introducing a condition which checks if 'query' is model type, it applies the 
> rollback() method only when it is of model type.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/open-queries.js
>  a4048be 
> 
> Diff: https://reviews.apache.org/r/47227/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 47229: [UI Issue]Execution of empty pig script allowed from UI


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47229/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16447
https://issues.apache.org/jira/browse/AMBARI-16447


Repository: ambari


Description
---

- Added a condition for checking empty pig script.
- If the script is empty, showing an error.


Diffs
-

  contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/scriptEdit.js 
60a04ce 
  contrib/views/pig/src/main/resources/ui/pig-web/app/translations.js 5bb8cf7 

Diff: https://reviews.apache.org/r/47229/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 47226: AMBARI-16444 Ambari router field is not configurable in solr-client

2016-05-11 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47226/#review132637
---


Ship it!




Ship It!

- Miklos Gergely


On May 11, 2016, 9:32 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47226/
> ---
> 
> (Updated May 11, 2016, 9:32 a.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16444
> https://issues.apache.org/jira/browse/AMBARI-16444
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - router field not configurable corretly in the cli of solr-client.
> - also change default znode for logsearch solr
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
>  74ea547 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  ce53692 
> 
> Diff: https://reviews.apache.org/r/47226/diff/
> 
> 
> Testing
> ---
> 
> Total run:1014   
> Total errors:0   
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 47224: [Hive View] - Save Default Settings should not permit empty parameter values


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47224/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16443
https://issues.apache.org/jira/browse/AMBARI-16443


Repository: ambari


Description
---

- Introduced a settingException variable
- settingException variable gets the name and value for the failed setting 
parameter.
- we display error the error message for the failed setting while saving the 
settings.


Diffs
-

  contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
b813bbf 

Diff: https://reviews.apache.org/r/47224/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47027/#review132622
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 10, 2016, 3:25 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47027/
> ---
> 
> (Updated May 10, 2016, 3:25 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added AmbariClusterStreamProvider interface for connecting to Ambari Cluster 
> (Can be Remote or Local) that is attached to view instance.
> Added Cluster Type Enum (LOCAL_AMBARI, REMOTE_AMBARI, NONE) for 
> differentiating cluster type attached to view instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-views/src/main/java/org/apache/ambari/view/AmbariClusterStreamProvider.java
>  PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/AmbariHttpException.java 
> PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/AmbariStreamProvider.java 
> ce91676 
>   ambari-views/src/main/java/org/apache/ambari/view/ClusterType.java 
> PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 7b7b025 
>   
> ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 
> 0c3d3ce 
>   ambari-views/src/main/resources/view.xsd 04902e9 
>   
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
>  7f1d489 
>   contrib/views/capacity-scheduler/src/main/resources/view.xml 6dc3ffa 
>   
> contrib/views/capacity-scheduler/src/test/java/org/apache/ambari/view/capacityscheduler/ConfigurationServiceTest.java
>  62fa21e 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  83eae9b 
>   
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/BaseHttpClient.java
>  b4fccf9 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java
>  6b88b6f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/RemoteCluster.java
>  41dc88d 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
>  a8ef43f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuth.java
>  c9f735a 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
>  c8ca6cd 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  4518ac6 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/RemoteClusterTest.java
>  ec4df7d 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
>  455ca20 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuthTest.java
>  27e98f2 
> 
> Diff: https://reviews.apache.org/r/47027/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47023: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Server Side changes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47023/#review132621
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 10, 2016, 3:29 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47023/
> ---
> 
> (Updated May 10, 2016, 3:29 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added RemotAmbariClusterEntity, RemoteAmbariClusterDao to store remote 
> cluster credential.
> Added RemoteClusterResourceProvider for accessing Remote Cluster through api.
> Added RemoteAmbariCluster impementation for view.Cluster that can be accessed 
> through ViewContextImpl.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RemoteClusterResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  0b77511 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RemoteClustersService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  4e7a032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
>  605f68d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  386e657 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteAmbariClusterDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterServiceEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
>  29dc2a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  2d6e5ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariConfigurationReadException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariStreamProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
>  1dacd92 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java
>  ba7f446 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> d2d48a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
>  bb6a93c 
>   ambari-server/src/main/resources/META-INF/persistence.xml ce563cb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewAmbariStreamProviderTest.java
>  8549d4a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
>  a41e137 
> 
> Diff: https://reviews.apache.org/r/47023/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132620
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 10, 2016, 5:15 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 10, 2016, 5:15 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47025: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Admin changes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47025/#review132619
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 11, 2016, 7:05 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47025/
> ---
> 
> (Updated May 11, 2016, 7:05 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added Remote Cluster Section in ambari-admin. This allows add, delete, create 
> and listing of Remote Ambari Managed Cluster.
> Added Remote Cluster section in View Instance Create/Edit page. This helps in 
> linking view instance to a Remote Cluster
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/index.html 8d7e8e7 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
>  127bc74 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
>  480f85d 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersCreateCtrl.js
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersEditCtrl.js
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js
>  PRE-CREATION 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> 80a5352 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 0566969 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js
>  PRE-CREATION 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js 
> 780352d 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c573b72 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html
>  eaff70b 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> 4003137 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 
> f93867c 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/modals/changePassword.html
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/remoteClusterPage.html
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47025/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47025: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Admin changes

2016-05-11 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47025/
---

(Updated May 11, 2016, 7:05 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore, 
Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Removed fileBrowser.js dependency


Bugs: AMBARI-16274
https://issues.apache.org/jira/browse/AMBARI-16274


Repository: ambari


Description
---

Added Remote Cluster Section in ambari-admin. This allows add, delete, create 
and listing of Remote Ambari Managed Cluster.
Added Remote Cluster section in View Instance Create/Edit page. This helps in 
linking view instance to a Remote Cluster


Diffs (updated)
-

  ambari-admin/src/main/resources/ui/admin-web/app/index.html 8d7e8e7 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
 127bc74 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
 480f85d 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersCreateCtrl.js
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersEditCtrl.js
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js
 PRE-CREATION 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
80a5352 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 0566969 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js
 PRE-CREATION 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js 
780352d 
  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c573b72 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html 
eaff70b 
  ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
4003137 
  ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 
f93867c 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html 
PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/modals/changePassword.html
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/remoteClusterPage.html
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47025/diff/


Testing
---

Manual Testing.


Thanks,

Gaurav Nagar

Re: Review Request 47025: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Admin changes