Re: Review Request 47288: AMBARI-16225. Storm Ambari view should work with Firefox 25

[Sriharsha Chintalapani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47288/
---

(Updated May 17, 2016, 5:51 a.m.)


Review request for Ambari and Srimanth Gunturi.


Bugs: AMBARI-16225
https://issues.apache.org/jira/browse/AMBARI-16225


Repository: ambari


Description
---

Storm Ambari view should work with Firefox 25


Diffs
-

  contrib/views/storm/src/main/resources/scripts/collections/BaseCollection.js 
29b1ce9 
  contrib/views/storm/src/main/resources/scripts/components/Breadcrumbs.jsx 
75c2fa9 
  contrib/views/storm/src/main/resources/scripts/components/Modal.jsx e37b734 
  contrib/views/storm/src/main/resources/scripts/components/RadialChart.jsx 
f28b08a 
  contrib/views/storm/src/main/resources/scripts/components/SpoutGraph.jsx 
cec4c85 
  contrib/views/storm/src/main/resources/scripts/components/Table.jsx 3b0ad50 
  contrib/views/storm/src/main/resources/scripts/components/TopologyGraph.jsx 
e74a251 
  contrib/views/storm/src/main/resources/scripts/containers/NimbusSummary.jsx 
ee901b9 
  
contrib/views/storm/src/main/resources/scripts/containers/SupervisorSummary.jsx 
e403b86 
  
contrib/views/storm/src/main/resources/scripts/containers/TopologyConfiguration.jsx
 dd2ad64 
  
contrib/views/storm/src/main/resources/scripts/containers/TopologyDetailGraph.jsx
 64fdee1 
  contrib/views/storm/src/main/resources/scripts/containers/TopologyListing.jsx 
9ce19f0 
  contrib/views/storm/src/main/resources/scripts/modules/Table/Pagination.jsx 
41a763c 
  contrib/views/storm/src/main/resources/scripts/router/Router.js 24fc1e0 
  contrib/views/storm/src/main/resources/scripts/views/ComponentDetailView.jsx 
14f7527 
  contrib/views/storm/src/main/resources/scripts/views/ProfilingView.jsx 
eb9d0d1 
  contrib/views/storm/src/main/resources/scripts/views/RebalanceView.jsx 
96f01a6 
  contrib/views/storm/src/main/resources/scripts/views/TopologyDetailView.jsx 
bf66903 

Diff: https://reviews.apache.org/r/47288/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47438/#review133478
---



Just realized I am missing UpgradeCatalog changes, will add subsequent patch.

- Sid Wagle


On May 17, 2016, 12:51 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47438/
> ---
> 
> (Updated May 17, 2016, 12:51 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Srimanth 
> Gunturi.
> 
> 
> Bugs: AMBARI-16695
> https://issues.apache.org/jira/browse/AMBARI-16695
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are new HDFS alerts that watch growth rates. Some (like RPC) have 
> "minimum" values, meaning we ignore growth until we are past a certain value 
> (like latency in seconds).
> 
> There are a few other alerts that I think also need minimums.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 
> aedbdfe 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
>  3296493 
> 
> Diff: https://reviews.apache.org/r/47438/diff/
> 
> 
> Testing
> ---
> 
> Deployed manually to verify nothing breaks.
> 
> --
> Ran 261 tests in 6.682s
> 
> OK
> --
> Total run:1016
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47438/
---

(Updated May 17, 2016, 12:51 a.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Srimanth 
Gunturi.


Changes
---

Comment typo.


Bugs: AMBARI-16695
https://issues.apache.org/jira/browse/AMBARI-16695


Repository: ambari


Description
---

There are new HDFS alerts that watch growth rates. Some (like RPC) have 
"minimum" values, meaning we ignore growth until we are past a certain value 
(like latency in seconds).

There are a few other alerts that I think also need minimums.


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 
aedbdfe 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
 3296493 

Diff: https://reviews.apache.org/r/47438/diff/


Testing
---

Deployed manually to verify nothing breaks.

--
Ran 261 tests in 6.682s

OK
--
Total run:1016
Total errors:0
Total failures:0
OK


Thanks,

Sid Wagle

Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47438/
---

Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Srimanth 
Gunturi.


Bugs: AMBARI-16695
https://issues.apache.org/jira/browse/AMBARI-16695


Repository: ambari


Description
---

There are new HDFS alerts that watch growth rates. Some (like RPC) have 
"minimum" values, meaning we ignore growth until we are past a certain value 
(like latency in seconds).

There are a few other alerts that I think also need minimums.


Diffs
-

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 
aedbdfe 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
 3296493 

Diff: https://reviews.apache.org/r/47438/diff/


Testing
---

Deployed manually to verify nothing breaks.

--
Ran 261 tests in 6.682s

OK
--
Total run:1016
Total errors:0
Total failures:0
OK


Thanks,

Sid Wagle

Re: Review Request 47434: Remove unused parameters from hawq-site.xml

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47434/#review133471
---


Ship it!




Ship It!

- Alexander Denissov


On May 17, 2016, 12:14 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47434/
> ---
> 
> (Updated May 17, 2016, 12:14 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16694
> https://issues.apache.org/jira/browse/AMBARI-16694
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove the below unused parameters from hawq-site.xml
> hawq_re_cgroup_hierarchy_name
> hawq_re_cgroup_mount_point
> hawq_re_cpu_enable
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  170e8cf 
> 
> Diff: https://reviews.apache.org/r/47434/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/
---

(Updated May 17, 2016, 12:17 a.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Changes
---

Remove mis-uploaded file


Bugs: AMBARI-15612
https://issues.apache.org/jira/browse/AMBARI-15612


Repository: ambari


Description
---

Add Livy to HDP 2.5 as slave component of Spark.

Move the spark stack definiation to commoon-services and then


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 2e18443 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 9e9cadc 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 c5f3eb6 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
 694f046 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
 86e7f7d 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 3ec5d05 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
6e506a0 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
f7e15aa 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-defaults.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-spark-blacklist.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
d1129cd 

Diff: https://reviews.apache.org/r/46727/diff/


Testing
---

Manully verify it. Livy is installed correctly in non-secure and secure cluster.


Thanks,

Jeff Zhang

Review Request 47434: Remove unused parameters from hawq-site.xml

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47434/
---

Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
Diachenko.


Bugs: AMBARI-16694
https://issues.apache.org/jira/browse/AMBARI-16694


Repository: ambari


Description
---

Remove the below unused parameters from hawq-site.xml
hawq_re_cgroup_hierarchy_name
hawq_re_cgroup_mount_point
hawq_re_cpu_enable


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 170e8cf 

Diff: https://reviews.apache.org/r/47434/diff/


Testing
---

yes.


Thanks,

bhuvnesh chaudhary

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/
---

(Updated May 17, 2016, 12:11 a.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Changes
---

Change the cardinality of livy and add new conf file spark-blacklist.proerties.


Bugs: AMBARI-15612
https://issues.apache.org/jira/browse/AMBARI-15612


Repository: ambari


Description
---

Add Livy to HDP 2.5 as slave component of Spark.

Move the spark stack definiation to commoon-services and then


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 2e18443 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 9e9cadc 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 c5f3eb6 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
 694f046 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
 86e7f7d 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 3ec5d05 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
6e506a0 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
f7e15aa 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-defaults.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-spark-blacklist.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
d1129cd 
  ambari-server/src/test/python/stacks/2.5/SPARK/test_livy_server.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/46727/diff/


Testing
---

Manully verify it. Livy is installed correctly in non-secure and secure cluster.


Thanks,

Jeff Zhang

Re: Review Request 47420: Support grafana dashboards to be defined based on stack

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47420/#review133463
---


Ship it!




Ship It!

- Jayush Luniya


On May 16, 2016, 9:56 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47420/
> ---
> 
> (Updated May 16, 2016, 9:56 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16686
> https://issues.apache.org/jira/browse/AMBARI-16686
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Grafana dashboard definition should be based on the stack that is deployed by 
> Ambari.
> 
> Currently we create same dashboard definitions for all stacks which might not 
> have the supported services defined.
> 
> The dashboards need to be classified per stack basis.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-misc.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-performance.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-datanodes.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-namenodes.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hivemetastore.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hiverserver2.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-heatmaps.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-overview.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-applications.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-jobhistoryserver.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-nodemanagers.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-queues.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-resourcemanagers.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-timelineserver.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-system-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-system-servers.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-home.json
>  9d983e4 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-misc.json
>  705f73c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-performance.json
>  50e20a3 
>   
> 

Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables

[Ajit Kumar]

> On May 16, 2016, 9:47 p.m., Sid Wagle wrote:
> > What about RCA tables not a part of Ambari DB ?

Only postgres-embedded-create.sql has ambarirca db. Users who are facing this 
issue have stand alone DB server and don't use postgres-embedded. Ideally we 
should remove ambarirca db from postgres-embedded-create.sql as well.


- Ajit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43126/#review133450
---


On May 16, 2016, 9:28 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43126/
> ---
> 
> (Updated May 16, 2016, 9:28 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16692
> https://issues.apache.org/jira/browse/AMBARI-16692
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RCA Database tables is not used anymore. This older, un-necessary data causes 
> many Ambari DB queries to return more slowly than necessary. If the database 
> gets large enough, it can have significant impact on the way ambari-server 
> functions.
> The Ambari Server upgrade process should detect the presence of these older, 
> deprecated tables, and automate the process of cleaning up this data.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  3547ad3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  f36e640 
> 
> Diff: https://reviews.apache.org/r/43126/diff/
> 
> 
> Testing
> ---
> 
> Unit test
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 47420: Support grafana dashboards to be defined based on stack

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47420/
---

(Updated May 16, 2016, 9:56 p.m.)


Review request for Ambari, Aravindan Vijayan, Jayush Luniya, and Sumit Mohanty.


Bugs: AMBARI-16686
https://issues.apache.org/jira/browse/AMBARI-16686


Repository: ambari


Description
---

Grafana dashboard definition should be based on the stack that is deployed by 
Ambari.

Currently we create same dashboard definitions for all stacks which might not 
have the supported services defined.

The dashboards need to be classified per stack basis.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-home.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-misc.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-performance.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-datanodes.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-home.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-namenodes.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hivemetastore.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hiverserver2.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-home.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-heatmaps.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-overview.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-applications.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-home.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-jobhistoryserver.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-nodemanagers.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-queues.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-resourcemanagers.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-timelineserver.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-system-home.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-system-servers.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-home.json
 9d983e4 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-misc.json
 705f73c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-performance.json
 50e20a3 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hdfs-datanodes.json
 05a1e4c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hdfs-home.json
 09929ec 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hdfs-namenodes.json
 ebf7a4c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hive-hivemetastore.json
 9d6b710 
  

Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

[Josh Elser]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47428/
---

Review request for Ambari and Robert Levas.


Bugs: AMBARI-16171
https://issues.apache.org/jira/browse/AMBARI-16171


Repository: ambari


Description
---

The up-coming version of Phoenix will contain some new functionality to support 
Kerberos authentication of clients via SPNEGO with the Phoenix Query Server 
(PQS).

Presently, Ambari will configure PQS to use the hbase service keytab which will 
result in the SPNEGO authentication failing as the RFC requires that the 
"primary" component of the Kerberos principal for the server is "HTTP". Thus, 
we need to ensure that we switch PQS over to use the spnego.service.keytab as 
the keytab and "HTTP/_HOST@REALM" as the principal.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 1f3b1d3 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json 
c9536f8 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 f36e640 

Diff: https://reviews.apache.org/r/47428/diff/


Testing
---

Unit testing, still working through a "real" Ambari upgrade


Thanks,

Josh Elser

Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43126/#review133450
---



What about RCA tables not a part of Ambari DB ?

- Sid Wagle


On May 16, 2016, 9:28 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43126/
> ---
> 
> (Updated May 16, 2016, 9:28 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16692
> https://issues.apache.org/jira/browse/AMBARI-16692
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RCA Database tables is not used anymore. This older, un-necessary data causes 
> many Ambari DB queries to return more slowly than necessary. If the database 
> gets large enough, it can have significant impact on the way ambari-server 
> functions.
> The Ambari Server upgrade process should detect the presence of these older, 
> deprecated tables, and automate the process of cleaning up this data.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  3547ad3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  f36e640 
> 
> Diff: https://reviews.apache.org/r/43126/diff/
> 
> 
> Testing
> ---
> 
> Unit test
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Review Request 43126: Ambari Upgrade should clean older RCA Database tables

[Ajit Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43126/
---

Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-16692
https://issues.apache.org/jira/browse/AMBARI-16692


Repository: ambari


Description
---

RCA Database tables is not used anymore. This older, un-necessary data causes 
many Ambari DB queries to return more slowly than necessary. If the database 
gets large enough, it can have significant impact on the way ambari-server 
functions.
The Ambari Server upgrade process should detect the presence of these older, 
deprecated tables, and automate the process of cleaning up this data.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 3547ad3 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 f36e640 

Diff: https://reviews.apache.org/r/43126/diff/


Testing
---

Unit test


Thanks,

Ajit Kumar

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47421/#review133444
---


Ship it!




Ship It!

- Jayush Luniya


On May 16, 2016, 6:50 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47421/
> ---
> 
> (Updated May 16, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-16687
> https://issues.apache.org/jira/browse/AMBARI-16687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During an upgrade from HDP 2.x to 2.y, all of the configuration tasks are 
> being shown as skipped. This is due to AMBARI-15222 where the configuration 
> packs were being calculated incorrectly resulting in empty maps.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  b069862 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionDirectory.java
>  f2e00fe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
>  564b5bd 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
> 257893f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  1fa4d00 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> bf041de 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 45e2f94 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7873853 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1cd2ffa 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> f71ef1a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9c6a02d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> a7dbba3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  2e5c002 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 1745de8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
>  771f830 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 
> cb034d0 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 
> 623b45c 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml
>  4932e92 
> 
> Diff: https://reviews.apache.org/r/47421/diff/
> 
> 
> Testing
> ---
> 
> Wrote a new unit test which validates all upgrade XML files which have 
> configuration tasks.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47421/#review133443
---




ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
(line 1183)


How did we live with this so far?


- Jayush Luniya


On May 16, 2016, 6:50 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47421/
> ---
> 
> (Updated May 16, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-16687
> https://issues.apache.org/jira/browse/AMBARI-16687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During an upgrade from HDP 2.x to 2.y, all of the configuration tasks are 
> being shown as skipped. This is due to AMBARI-15222 where the configuration 
> packs were being calculated incorrectly resulting in empty maps.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  b069862 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionDirectory.java
>  f2e00fe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
>  564b5bd 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
> 257893f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  1fa4d00 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> bf041de 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 45e2f94 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7873853 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1cd2ffa 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> f71ef1a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9c6a02d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> a7dbba3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  2e5c002 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 1745de8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
>  771f830 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 
> cb034d0 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 
> 623b45c 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml
>  4932e92 
> 
> Diff: https://reviews.apache.org/r/47421/diff/
> 
> 
> Testing
> ---
> 
> Wrote a new unit test which validates all upgrade XML files which have 
> configuration tasks.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 47420: Support grafana dashboards to be defined based on stack

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47420/#review133436
---




ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-system-home.json
 (line 1)


Might want to put system dashboards in grafana-dashboards/default so that 
for all stacks atleast we have system dashboards?


- Jayush Luniya


On May 16, 2016, 6:49 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47420/
> ---
> 
> (Updated May 16, 2016, 6:49 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16686
> https://issues.apache.org/jira/browse/AMBARI-16686
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Grafana dashboard definition should be based on the stack that is deployed by 
> Ambari.
> 
> Currently we create same dashboard definitions for all stacks which might not 
> have the supported services defined.
> 
> The dashboards need to be classified per stack basis.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-misc.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-performance.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-datanodes.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-namenodes.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hivemetastore.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hiverserver2.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-heatmaps.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-overview.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-system-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-system-servers.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-applications.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-jobhistoryserver.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-nodemanagers.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-queues.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-resourcemanagers.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-timelineserver.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-home.json
>  9d983e4 
>   
> 

Re: Review Request 47422: AMBARI-16688: Ambari users page is not showing type for users

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47422/#review133434
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On May 16, 2016, 7:08 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47422/
> ---
> 
> (Updated May 16, 2016, 7:08 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang.
> 
> 
> Bugs: AMBARI-16688
> https://issues.apache.org/jira/browse/AMBARI-16688
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Login to ambari
> Navigate to Users page 
> Add few users
> Verify type is displayed for each User
> Actual: Type is displayed as blank for users currently.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/User.js 
> c6765d0 
> 
> Diff: https://reviews.apache.org/r/47422/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
> 
> PhantomJS 1.9.7 (Mac OS X): Executed 70 of 70 SUCCESS (0.502 secs / 0.499 
> secs)
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47421/#review133427
---




ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
 


Do we need a safeguard so that any intermediate stacks outside of the range 
are inogred?


- Alejandro Fernandez


On May 16, 2016, 6:50 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47421/
> ---
> 
> (Updated May 16, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-16687
> https://issues.apache.org/jira/browse/AMBARI-16687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During an upgrade from HDP 2.x to 2.y, all of the configuration tasks are 
> being shown as skipped. This is due to AMBARI-15222 where the configuration 
> packs were being calculated incorrectly resulting in empty maps.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  b069862 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionDirectory.java
>  f2e00fe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
>  564b5bd 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
> 257893f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  1fa4d00 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> bf041de 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 45e2f94 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7873853 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1cd2ffa 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> f71ef1a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9c6a02d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> a7dbba3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  2e5c002 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 1745de8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
>  771f830 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 
> cb034d0 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 
> 623b45c 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml
>  4932e92 
> 
> Diff: https://reviews.apache.org/r/47421/diff/
> 
> 
> Testing
> ---
> 
> Wrote a new unit test which validates all upgrade XML files which have 
> configuration tasks.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

[Nate Cole]

> On May 16, 2016, 2:54 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml,
> >  line 1184
> > 
> >
> > Wow ... just ... wow

!


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47421/#review133407
---


On May 16, 2016, 2:50 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47421/
> ---
> 
> (Updated May 16, 2016, 2:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-16687
> https://issues.apache.org/jira/browse/AMBARI-16687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During an upgrade from HDP 2.x to 2.y, all of the configuration tasks are 
> being shown as skipped. This is due to AMBARI-15222 where the configuration 
> packs were being calculated incorrectly resulting in empty maps.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  b069862 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionDirectory.java
>  f2e00fe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
>  564b5bd 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
> 257893f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  1fa4d00 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> bf041de 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 45e2f94 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7873853 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1cd2ffa 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> f71ef1a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9c6a02d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> a7dbba3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  2e5c002 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 1745de8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
>  771f830 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 
> cb034d0 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 
> 623b45c 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml
>  4932e92 
> 
> Diff: https://reviews.apache.org/r/47421/diff/
> 
> 
> Testing
> ---
> 
> Wrote a new unit test which validates all upgrade XML files which have 
> configuration tasks.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47421/#review133418
---


Ship it!




Ship It!

- Nate Cole


On May 16, 2016, 2:50 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47421/
> ---
> 
> (Updated May 16, 2016, 2:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-16687
> https://issues.apache.org/jira/browse/AMBARI-16687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During an upgrade from HDP 2.x to 2.y, all of the configuration tasks are 
> being shown as skipped. This is due to AMBARI-15222 where the configuration 
> packs were being calculated incorrectly resulting in empty maps.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  b069862 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionDirectory.java
>  f2e00fe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
>  564b5bd 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
> 257893f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  1fa4d00 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> bf041de 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 45e2f94 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7873853 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1cd2ffa 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> f71ef1a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9c6a02d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> a7dbba3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  2e5c002 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 1745de8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
>  771f830 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 
> cb034d0 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 
> 623b45c 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml
>  4932e92 
> 
> Diff: https://reviews.apache.org/r/47421/diff/
> 
> 
> Testing
> ---
> 
> Wrote a new unit test which validates all upgrade XML files which have 
> configuration tasks.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 47420: Support grafana dashboards to be defined based on stack

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47420/#review133411
---


Ship it!




Ship It!

- Aravindan Vijayan


On May 16, 2016, 6:49 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47420/
> ---
> 
> (Updated May 16, 2016, 6:49 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16686
> https://issues.apache.org/jira/browse/AMBARI-16686
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Grafana dashboard definition should be based on the stack that is deployed by 
> Ambari.
> 
> Currently we create same dashboard definitions for all stacks which might not 
> have the supported services defined.
> 
> The dashboards need to be classified per stack basis.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-misc.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-performance.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-datanodes.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-namenodes.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hivemetastore.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hiverserver2.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-heatmaps.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-overview.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-system-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-system-servers.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-applications.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-home.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-jobhistoryserver.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-nodemanagers.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-queues.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-resourcemanagers.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-timelineserver.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-home.json
>  9d983e4 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-misc.json
>  705f73c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-performance.json
>  50e20a3 
>   
> 

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47421/#review133407
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 (line 854)


Centralized this behavior so that unit tests could use it as well.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 (lines 1739 - 1761)


Bulk of the changed logic is here. Basically start out with the source 
stack (HDP 2.2 and merge in any defined "intermediate" configs)



ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
 


Intermediate should mean "in between". In this case, on a HDP 2.1 to 2.3 
upgrade, 2.2 is the only one "in between" ...



ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
(line 1183)


Wow ... just ... wow


- Jonathan Hurley


On May 16, 2016, 2:50 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47421/
> ---
> 
> (Updated May 16, 2016, 2:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-16687
> https://issues.apache.org/jira/browse/AMBARI-16687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During an upgrade from HDP 2.x to 2.y, all of the configuration tasks are 
> being shown as skipped. This is due to AMBARI-15222 where the configuration 
> packs were being calculated incorrectly resulting in empty maps.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  b069862 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionDirectory.java
>  f2e00fe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
>  564b5bd 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
> 257893f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  1fa4d00 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> bf041de 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 45e2f94 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7873853 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1cd2ffa 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> f71ef1a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9c6a02d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> a7dbba3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  2e5c002 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 1745de8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
>  771f830 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 
> cb034d0 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 
> 623b45c 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml
>  4932e92 
> 
> Diff: https://reviews.apache.org/r/47421/diff/
> 
> 
> Testing
> ---
> 
> Wrote a new unit test which validates all upgrade XML files which have 
> configuration tasks.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47421/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
Luniya, and Nate Cole.


Bugs: AMBARI-16687
https://issues.apache.org/jira/browse/AMBARI-16687


Repository: ambari


Description
---

During an upgrade from HDP 2.x to 2.y, all of the configuration tasks are being 
shown as skipped. This is due to AMBARI-15222 where the configuration packs 
were being calculated incorrectly resulting in empty maps.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 b069862 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionDirectory.java
 f2e00fe 
  
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
 564b5bd 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
257893f 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
 1fa4d00 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
bf041de 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
45e2f94 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 7873853 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
1cd2ffa 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
f71ef1a 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
9c6a02d 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a7dbba3 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 2e5c002 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
1745de8 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
 771f830 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
 PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 
cb034d0 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 
623b45c 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml
 4932e92 

Diff: https://reviews.apache.org/r/47421/diff/


Testing
---

Wrote a new unit test which validates all upgrade XML files which have 
configuration tasks.


Thanks,

Jonathan Hurley

Review Request 47420: Support grafana dashboards to be defined based on stack

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47420/
---

Review request for Ambari, Aravindan Vijayan, Jayush Luniya, and Sumit Mohanty.


Bugs: AMBARI-16686
https://issues.apache.org/jira/browse/AMBARI-16686


Repository: ambari


Description
---

Grafana dashboard definition should be based on the stack that is deployed by 
Ambari.

Currently we create same dashboard definitions for all stacks which might not 
have the supported services defined.

The dashboards need to be classified per stack basis.


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-home.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-misc.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-performance.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-datanodes.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-home.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-namenodes.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hivemetastore.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hiverserver2.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-home.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-heatmaps.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-overview.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-system-home.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-system-servers.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-applications.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-home.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-jobhistoryserver.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-nodemanagers.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-queues.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-resourcemanagers.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-timelineserver.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-home.json
 9d983e4 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-misc.json
 705f73c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-performance.json
 50e20a3 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hdfs-datanodes.json
 05a1e4c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hdfs-home.json
 09929ec 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hdfs-namenodes.json
 ebf7a4c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hive-hivemetastore.json
 9d6b710 
  

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46962/#review133399
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 44)


Use explicit imports.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 267)


Use standard formatting with only a single space.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 277)


Use javadoc instead of // comments.

Also, the formatting in this function is not consistent in terms of spaces, 
especially near parentheses and curly braces.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 312)


Catch NumberFormatException instead



contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
 (line 441)


Space after ","
Same in 2 LOG statements below.


- Alejandro Fernandez


On May 16, 2016, 1:59 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46962/
> ---
> 
> (Updated May 16, 2016, 1:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16242
> https://issues.apache.org/jira/browse/AMBARI-16242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : 
> the id for dynamic entity was created in the application with the use of 
> instance data for that view. This data is dependent on users and created 
> separate sequences for each user. So the id for one user was also generated 
> for other user. Hence the data in db of one user was getting overriden by 
> other user. 
> 
> In this patch : 
> Now the id is generated using table_sequence techique of JPA. table for 
> sequence is ambari_sequence. UpgradeCatalog240.java will add the current 
> sequence number for existing tables and for new table the sequence name will 
> be added automatically. As sequence size of 50 is provided for better 
> performances
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  dc8d9b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
>  0ed260d 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java
>  1e8f07f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
>  f7f883b 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java
>  7ae7721 
> 
> Diff: https://reviews.apache.org/r/46962/diff/
> 
> 
> Testing
> ---
> 
> Following manual testing has been done.
> 1. upgrade script creates correct current sequences. Done by manually 
> upgrading old ambari with existing views. Next job will allocate 50 more ids
> 2. for new tables the entry in ambari_sequence is automatically added and the 
> ids will start from 1.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review133396
---


Ship it!





ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
 (line 31)


May want to prepend "params." to make it clear where "livy_server_start" is 
coming from.
Same with livy_server_stop below.


- Alejandro Fernandez


On May 14, 2016, 12:56 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated May 14, 2016, 12:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  2e18443 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  9e9cadc 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  3ec5d05 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 6e506a0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> d1129cd 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> ---
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

[Ajit Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46962/#review133376
---



Minor code formatting comments.


ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 305)


space after if



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 309)


You can use Math.max as well



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 312)


space after }, catch



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 318)


Is maxId == 0 valid?



ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
 (line 51)


No wild card imports.



ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
 (line 414)


It is good practise to use {} even for 1 line if blocks.

space should be after if and not after (



contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java
 (line 61)


Indexed newBean = (Indexed) BeanUtils.cloneBean(obj);



contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java
 (line 53)


Indexed newBean = (Indexed) BeanUtils.cloneBean(obj);


- Ajit Kumar


On May 16, 2016, 1:59 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46962/
> ---
> 
> (Updated May 16, 2016, 1:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16242
> https://issues.apache.org/jira/browse/AMBARI-16242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : 
> the id for dynamic entity was created in the application with the use of 
> instance data for that view. This data is dependent on users and created 
> separate sequences for each user. So the id for one user was also generated 
> for other user. Hence the data in db of one user was getting overriden by 
> other user. 
> 
> In this patch : 
> Now the id is generated using table_sequence techique of JPA. table for 
> sequence is ambari_sequence. UpgradeCatalog240.java will add the current 
> sequence number for existing tables and for new table the sequence name will 
> be added automatically. As sequence size of 50 is provided for better 
> performances
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  dc8d9b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
>  0ed260d 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java
>  1e8f07f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
>  f7f883b 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java
>  7ae7721 
> 
> Diff: https://reviews.apache.org/r/46962/diff/
> 
> 
> Testing
> ---
> 
> Following manual testing has been done.
> 1. upgrade script creates correct current sequences. Done by manually 
> upgrading old ambari with existing views. Next job will allocate 50 more ids
> 2. for new tables the entry in ambari_sequence is automatically added and the 
> ids will start from 1.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47417: Replace '*' to hdp version in lzo packages

[Andrew Onischuk]

> On May 16, 2016, 4:42 p.m., Andrew Onischuk wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py,
> >  line 32
> > 
> >
> > I think this should be os-depend. Otherwise you'll get a problem on 
> > Ubuntu.

or I may be mistaken I am not sure. Please check if delimiter for those version 
is the same on centos on ubuntu


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47417/#review133378
---


On May 16, 2016, 4 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47417/
> ---
> 
> (Updated May 16, 2016, 4 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16683
> https://issues.apache.org/jira/browse/AMBARI-16683
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As i understood(according to discussion with Andrew O) we had some jira for 
> '*' to hdp version replacement in all packages. But here it was not replaced:
> {code}
> def get_lzo_packages(stack_version_unformatted):
>   lzo_packages = []
>  
>   if OSCheck.is_redhat_family() or OSCheck.is_suse_family():
> lzo_packages += ["lzo", "hadoop-lzo-native"]
>   elif OSCheck.is_ubuntu_family():
> lzo_packages += ["liblzo2-2"]
> 
>   if stack_version_unformatted and 
> check_stack_feature(StackFeature.ROLLING_UPGRADE, stack_version_unformatted):
> lzo_packages += ["hadooplzo_*"]
>   else:
> lzo_packages += ["hadoop-lzo"]
> 
>   return lzo_packages
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
>  e189d62 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py
>  fe488c3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  784da9c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  75924c5 
> 
> Diff: https://reviews.apache.org/r/47417/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 47417: Replace '*' to hdp version in lzo packages

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47417/#review133378
---




ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
 (line 32)


I think this should be os-depend. Otherwise you'll get a problem on Ubuntu.


- Andrew Onischuk


On May 16, 2016, 4 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47417/
> ---
> 
> (Updated May 16, 2016, 4 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16683
> https://issues.apache.org/jira/browse/AMBARI-16683
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As i understood(according to discussion with Andrew O) we had some jira for 
> '*' to hdp version replacement in all packages. But here it was not replaced:
> {code}
> def get_lzo_packages(stack_version_unformatted):
>   lzo_packages = []
>  
>   if OSCheck.is_redhat_family() or OSCheck.is_suse_family():
> lzo_packages += ["lzo", "hadoop-lzo-native"]
>   elif OSCheck.is_ubuntu_family():
> lzo_packages += ["liblzo2-2"]
> 
>   if stack_version_unformatted and 
> check_stack_feature(StackFeature.ROLLING_UPGRADE, stack_version_unformatted):
> lzo_packages += ["hadooplzo_*"]
>   else:
> lzo_packages += ["hadoop-lzo"]
> 
>   return lzo_packages
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
>  e189d62 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py
>  fe488c3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  784da9c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  75924c5 
> 
> Diff: https://reviews.apache.org/r/47417/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

[Keta Patel]

> On May 13, 2016, 10:24 p.m., Richard Zang wrote:
> > Ship It!
> 
> Keta Patel wrote:
> Thank you Richard!
> Could you please help me push in the changes.

Thank you Richard!

Committed to
Trunk:
https://github.com/apache/ambari/commit/e306c393d05ea3d6c28f004a4528f522b5e771cf

Ambari-2.4:
https://github.com/apache/ambari/commit/dfac1a7e00c326d284f1865d9ac1fe6bb9952498

Closing the Review Board request.


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review133219
---


On May 13, 2016, 5:29 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
> 
> (Updated May 13, 2016, 5:29 p.m.)
> 
> 
> Review request for Ambari, Di Li and Richard Zang.
> 
> 
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it. 
> (I have created "mygroup" with "user1", "user2", "user3") 
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a 
> role, say "Cluster User". 
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows 
> the role "Cluster User" for each user in "mygroup". 
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users, 
> say "user3". 
> (attachments "list_view_add_role_to_user_step1.tiff", 
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case 
> "user3"), but the roles from other users in its group gets removed. Also, the 
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view. 
> (attachment "block_view_after_step3.tiff")
> 
> So, the problem here lies with the List view where it is not able to process 
> the changes in the Roles correctly. A change in the Role of a user causes the 
> following:
> 
> CASE-1: The displayed role (effective privilege) comes from an explicitly 
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was 
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix 
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower 
> privilege than the role that got replaced, are still displayed in the Block 
> view (because those roles are still in the database). So, if the new selected 
> role happened to be of a lower privilege than and existing role of the user, 
> then even though the user sees a success Alert message, the effective 
> privileg he sees is different. For the Ambari user, this behavior is not 
> easily understandable.
> 
> CASE-2: The displayed role (effective privilege) comes from a group the user 
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege 
> coming from the user's group(s), then the newly selected role replaces this 
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also 
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege, 
> the Alert message shows a success of role change but the effective privilge 
> is still not the one that the Ambari user selected.
> 
> 
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it 
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by 
> allowing only a user to have just one role assigned to it, there could be 
> cases where the earlier version of Block view has already allowed users to 
> have multiple roles. So, taking this into consideration, the fix must address 
> removing any or all of the roles the user was assigned explicitly.
> 2. Adding a Role to a user must not affect the Roles of other users in its 
> group. (addressing 2.1 and 2.2)
> 3. Selecting a "NONE" for a user role shows the Alert "User's role chnaged to 
> None". This  may not reflect the correct privilege status as the user might 
> have some effective privilege coming from its group(s). In the fix, the Alert 
> must show the relevant message.
> 4. Alert 

Review Request 47417: Replace '*' to hdp version in lzo packages

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47417/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sumit 
Mohanty.


Bugs: AMBARI-16683
https://issues.apache.org/jira/browse/AMBARI-16683


Repository: ambari


Description
---

As i understood(according to discussion with Andrew O) we had some jira for '*' 
to hdp version replacement in all packages. But here it was not replaced:
{code}
def get_lzo_packages(stack_version_unformatted):
  lzo_packages = []
 
  if OSCheck.is_redhat_family() or OSCheck.is_suse_family():
lzo_packages += ["lzo", "hadoop-lzo-native"]
  elif OSCheck.is_ubuntu_family():
lzo_packages += ["liblzo2-2"]

  if stack_version_unformatted and 
check_stack_feature(StackFeature.ROLLING_UPGRADE, stack_version_unformatted):
lzo_packages += ["hadooplzo_*"]
  else:
lzo_packages += ["hadoop-lzo"]

  return lzo_packages
{code}


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
 e189d62 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py
 fe488c3 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 784da9c 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 75924c5 

Diff: https://reviews.apache.org/r/47417/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

[DIPAYAN BHOWMICK]

> On May 16, 2016, 1:58 p.m., DIPAYAN BHOWMICK wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java,
> >  line 367
> > 
> >
> > Remove these lines

Fixit and commit.


- DIPAYAN


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46962/#review133351
---


On May 4, 2016, 6:46 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46962/
> ---
> 
> (Updated May 4, 2016, 6:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-16242
> https://issues.apache.org/jira/browse/AMBARI-16242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : 
> the id for dynamic entity was created in the application with the use of 
> instance data for that view. This data is dependent on users and created 
> separate sequences for each user. So the id for one user was also generated 
> for other user. Hence the data in db of one user was getting overriden by 
> other user. 
> 
> In this patch : 
> Now the id is generated using table_sequence techique of JPA. table for 
> sequence is ambari_sequence. UpgradeCatalog240.java will add the current 
> sequence number for existing tables and for new table the sequence name will 
> be added automatically. As sequence size of 50 is provided for better 
> performances
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  dc8d9b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
>  0ed260d 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java
>  1e8f07f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
>  f7f883b 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java
>  7ae7721 
> 
> Diff: https://reviews.apache.org/r/46962/diff/
> 
> 
> Testing
> ---
> 
> Following manual testing has been done.
> 1. upgrade script creates correct current sequences. Done by manually 
> upgrading old ambari with existing views. Next job will allocate 50 more ids
> 2. for new tables the entry in ambari_sequence is automatically added and the 
> ids will start from 1.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46962/#review133352
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 4, 2016, 6:46 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46962/
> ---
> 
> (Updated May 4, 2016, 6:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-16242
> https://issues.apache.org/jira/browse/AMBARI-16242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : 
> the id for dynamic entity was created in the application with the use of 
> instance data for that view. This data is dependent on users and created 
> separate sequences for each user. So the id for one user was also generated 
> for other user. Hence the data in db of one user was getting overriden by 
> other user. 
> 
> In this patch : 
> Now the id is generated using table_sequence techique of JPA. table for 
> sequence is ambari_sequence. UpgradeCatalog240.java will add the current 
> sequence number for existing tables and for new table the sequence name will 
> be added automatically. As sequence size of 50 is provided for better 
> performances
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  dc8d9b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
>  0ed260d 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java
>  1e8f07f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
>  f7f883b 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java
>  7ae7721 
> 
> Diff: https://reviews.apache.org/r/46962/diff/
> 
> 
> Testing
> ---
> 
> Following manual testing has been done.
> 1. upgrade script creates correct current sequences. Done by manually 
> upgrading old ambari with existing views. Next job will allocate 50 more ids
> 2. for new tables the entry in ambari_sequence is automatically added and the 
> ids will start from 1.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47405: Sticky bit keeps getting changed back to 777 after restart causing security checks to fail

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47405/#review133350
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On May 16, 2016, 6:37 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47405/
> ---
> 
> (Updated May 16, 2016, 6:37 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16677
> https://issues.apache.org/jira/browse/AMBARI-16677
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/install-helper.sh 04f1e49 
>   ambari-server/src/main/python/bootstrap.py ad428af 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
>  8770df9 
>   ambari-server/src/test/python/TestBootstrap.py b60c35d 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py
>  a3567d5 
> 
> Diff: https://reviews.apache.org/r/47405/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47350: use schematool from hive2

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47350/#review133349
---


Ship it!




Ship It!

- Andrew Onischuk


On May 16, 2016, 12:18 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47350/
> ---
> 
> (Updated May 16, 2016, 12:18 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16662
> https://issues.apache.org/jira/browse/AMBARI-16662
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> hive2 has some changes to the metastore schema, but it is compatible with 
> hive1. 
> We should run the schematool from hive2 instead of hive1 so that the schema 
> is compatible for both versions.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  7b16474 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  169f7ea 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  4f8aa49 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-site.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47350/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 47124: Hive View : Upload Table- Error on uploading csv with 1 row

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47124/#review133348
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On May 14, 2016, 8:25 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47124/
> ---
> 
> (Updated May 14, 2016, 8:25 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16266
> https://issues.apache.org/jira/browse/AMBARI-16266
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : Uploading csv files with exactly 1 row gives error. This was 
> because "is first row header" was by default assumed to be true, and that 
> left no rows in the file for data. 
> In this patch : "is first row header" is assumed to be false by default. more 
> options added for header option like EMBEDDED and NONE for clear definition. 
> Handled this on UI and backend.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/TableInput.java
>  4a50e93 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadFromHdfsInput.java
>  9b052ab 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  4afe80b 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseOptions.java
>  adbdf7f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java
>  d94ad3c 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  d883743 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  b7d9011 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserCSVTest.java
>  479c934 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserJSONTest.java
>  555d8e3 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserXMLTest.java
>  f925dc3 
> 
> Diff: https://reviews.apache.org/r/47124/diff/
> 
> 
> Testing
> ---
> 
> Tests modified to account for change as the header line will not be included 
> into the preview rows returned by parser. Explicit tests added for single row 
> csv, json and xml.
> 
> Results :
> 
> Tests run: 101, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> File Attachments
> 
> 
> AMBARI-16266_trunk.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/10/73f61edb-b15d-4cab-b2f2-96c50d467e8e__AMBARI-16266_trunk.patch
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47305: Hive View Synchronized Around Entire Connection Creation Causing Deadlock

[Rohit Choudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47305/#review133347
---


Ship it!




Ship It!

- Rohit Choudhary


On May 12, 2016, 2:04 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47305/
> ---
> 
> (Updated May 12, 2016, 2:04 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Mahadev Konar, 
> Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16146
> https://issues.apache.org/jira/browse/AMBARI-16146
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : The synchronized UserLocalConnection.initialValue() was taking time 
> to get hive connection and all other threads were blocking to get inside this 
> synchronized block.
> 
> In this patch : 
> 1. Removed synchronized from UserLocalConnection.initialValue() and from 
> UserLocalHiveAuthCredentials.initialValue()
> 2. Introduced locking on specific key and not the complete method. Key would 
> be like Connection_INSTANCE-NAME:USER-NAME. So threads for other keys will 
> not get into contension with this lock. This avoids blocking of thread that 
> do not want to initialize different keys.
> 3. Used tryLock and fail with exception if lock cannot be obtained 
> immediately. This avoids blocking of threads that want to initialize same key 
> as one key should be initialized only once.
> 4. corrected synchronization at several places inside UserLocal class.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalConnection.java
>  c80a4c4 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalHiveAuthCredentials.java
>  9c72863 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocal.java 
> 40c8e6e 
> 
> Diff: https://reviews.apache.org/r/47305/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done by introducing Thread.sleep in 
> UserLocalConnection.initialValue() and creating more requests with following 
> combinations and logs.
> 0. first thread for connection + user + view combination obtains the lock and 
> goes inside UserLocalConnection.initialValue() and sleeps
> 1. same user, same hive view requests for connections fails to get lock with 
> exception.
> 2. same user, different hive view -- if first request gets new lock and goes 
> inside UserLocalConnection.initialValue().
> 3. same user, different hive view -- if connection created once then works 
> fine. does not block.
> 4. different user, same view -- gets new lock and goes inside 
> UserLocalConnection.initialValue() if first, else works fine.
> 5. different user, different view -- works as 4.
> 6. once the first thread come out of initialValue(), rest threads don't try 
> to get lock and don't fail either, works fine.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47305: Hive View Synchronized Around Entire Connection Creation Causing Deadlock

[Jonathan Hurley]

> On May 13, 2016, 8:34 a.m., Jonathan Hurley wrote:
> > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocal.java,
> >  lines 87-89
> > 
> >
> > Double-checked locking here; you'll need to make this volatile if 
> > you're keeping this code.
> 
> Nitiraj Rathore wrote:
> Do you mean to make viewSingletonObjects volatile? I don't think making 
> viewSingletonObjects as volatile is required here as we are not changing the 
> reference of viewSingletonObjects or assigning it new value. It is assigned 
> once statically. And we are using contains method to check for existence of 
> key inside that map. I would welcome any reason for making it volatile.

I took a look at the implementation for the CHMap and it does look like it will 
commit to memory correctly. So we can drop this.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47305/#review133079
---


On May 12, 2016, 10:04 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47305/
> ---
> 
> (Updated May 12, 2016, 10:04 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Mahadev Konar, 
> Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16146
> https://issues.apache.org/jira/browse/AMBARI-16146
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : The synchronized UserLocalConnection.initialValue() was taking time 
> to get hive connection and all other threads were blocking to get inside this 
> synchronized block.
> 
> In this patch : 
> 1. Removed synchronized from UserLocalConnection.initialValue() and from 
> UserLocalHiveAuthCredentials.initialValue()
> 2. Introduced locking on specific key and not the complete method. Key would 
> be like Connection_INSTANCE-NAME:USER-NAME. So threads for other keys will 
> not get into contension with this lock. This avoids blocking of thread that 
> do not want to initialize different keys.
> 3. Used tryLock and fail with exception if lock cannot be obtained 
> immediately. This avoids blocking of threads that want to initialize same key 
> as one key should be initialized only once.
> 4. corrected synchronization at several places inside UserLocal class.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalConnection.java
>  c80a4c4 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalHiveAuthCredentials.java
>  9c72863 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocal.java 
> 40c8e6e 
> 
> Diff: https://reviews.apache.org/r/47305/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done by introducing Thread.sleep in 
> UserLocalConnection.initialValue() and creating more requests with following 
> combinations and logs.
> 0. first thread for connection + user + view combination obtains the lock and 
> goes inside UserLocalConnection.initialValue() and sleeps
> 1. same user, same hive view requests for connections fails to get lock with 
> exception.
> 2. same user, different hive view -- if first request gets new lock and goes 
> inside UserLocalConnection.initialValue().
> 3. same user, different hive view -- if connection created once then works 
> fine. does not block.
> 4. different user, same view -- gets new lock and goes inside 
> UserLocalConnection.initialValue() if first, else works fine.
> 5. different user, different view -- works as 4.
> 6. once the first thread come out of initialValue(), rest threads don't try 
> to get lock and don't fail either, works fine.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47305: Hive View Synchronized Around Entire Connection Creation Causing Deadlock

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47305/#review133346
---


Ship it!




Ship It!

- Jonathan Hurley


On May 12, 2016, 10:04 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47305/
> ---
> 
> (Updated May 12, 2016, 10:04 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Mahadev Konar, 
> Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16146
> https://issues.apache.org/jira/browse/AMBARI-16146
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : The synchronized UserLocalConnection.initialValue() was taking time 
> to get hive connection and all other threads were blocking to get inside this 
> synchronized block.
> 
> In this patch : 
> 1. Removed synchronized from UserLocalConnection.initialValue() and from 
> UserLocalHiveAuthCredentials.initialValue()
> 2. Introduced locking on specific key and not the complete method. Key would 
> be like Connection_INSTANCE-NAME:USER-NAME. So threads for other keys will 
> not get into contension with this lock. This avoids blocking of thread that 
> do not want to initialize different keys.
> 3. Used tryLock and fail with exception if lock cannot be obtained 
> immediately. This avoids blocking of threads that want to initialize same key 
> as one key should be initialized only once.
> 4. corrected synchronization at several places inside UserLocal class.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalConnection.java
>  c80a4c4 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalHiveAuthCredentials.java
>  9c72863 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocal.java 
> 40c8e6e 
> 
> Diff: https://reviews.apache.org/r/47305/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done by introducing Thread.sleep in 
> UserLocalConnection.initialValue() and creating more requests with following 
> combinations and logs.
> 0. first thread for connection + user + view combination obtains the lock and 
> goes inside UserLocalConnection.initialValue() and sleeps
> 1. same user, same hive view requests for connections fails to get lock with 
> exception.
> 2. same user, different hive view -- if first request gets new lock and goes 
> inside UserLocalConnection.initialValue().
> 3. same user, different hive view -- if connection created once then works 
> fine. does not block.
> 4. different user, same view -- gets new lock and goes inside 
> UserLocalConnection.initialValue() if first, else works fine.
> 5. different user, different view -- works as 4.
> 6. once the first thread come out of initialValue(), rest threads don't try 
> to get lock and don't fail either, works fine.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47235: Takeover script configs results in conflict message that look wrong

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47235/
---

(Updated May 16, 2016, 9:19 a.m.)


Review request for Ambari, Srimanth Gunturi and Sid Wagle.


Summary (updated)
-

Takeover script configs results in conflict message that look wrong


Bugs: AMBARI-16451
https://issues.apache.org/jira/browse/AMBARI-16451


Repository: ambari


Description
---

Attaching the zip file with configs and conflicts.

  * The conflicting configs seem to have a lot of duplicate info  
mapred-site :: dfs.datanode.du.reserved

  * Unable to handle empty config files:  
Had to hand edit and add try / catch at :

> yaml.load(file).iteritems()

> parsed_configurations_from_path, parsed_properties_attributes =
parser.read_data_to_map(path)




Traceback (most recent call last):
  File "./takeover_config_merge.py", line 393, in 
sys.exit(main())
  File "./takeover_config_merge.py", line 389, in main
return configMerge.perform_merge()
  File "./takeover_config_merge.py", line 279, in perform_merge
parsed_configurations_from_path, parsed_properties_attributes = 
parser.read_data_to_map(path)
  File "./takeover_config_merge.py", line 86, in read_data_to_map
for name, value in yaml.load(file).iteritems():
AttributeError: 'NoneType' object has no attribute 'iteritems'


_Instruction_




./takeover_config_merge.py -o blueprint -i files


Diffs
-

  ambari-server/src/main/resources/scripts/takeover_config_merge.py 1432e4b 

Diff: https://reviews.apache.org/r/47235/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 47306: Ambari Admin Privilege required for Pig and Hive View. 403 error received when opening Pig View by a non-admin user

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47306/#review133340
---


Ship it!




Ship It!

- Nitiraj Rathore


On May 12, 2016, 1:29 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47306/
> ---
> 
> (Updated May 12, 2016, 1:29 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16634
> https://issues.apache.org/jira/browse/AMBARI-16634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Extended view Cluster interface to return hosts for service component.
> Used this method for geting the hosts for hive server, webhcat. Instead of 
> using Ambari Api in attached mode.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ClusterImpl.java 
> 529e09a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
>  f661844 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ClusterImplTest.java
>  daf87ec 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java
>  ce8fe7d 
>   ambari-views/src/main/java/org/apache/ambari/view/cluster/Cluster.java 
> f1b8177 
>   
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
>  718c5a5 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
>  1442748 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java
>  6072d28 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
>  1bace94 
> 
> Diff: https://reviews.apache.org/r/47306/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>