Review Request 49222: AMBARI-17436: Additional Ambari change for Falcon

[Venkat Ranganathan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49222/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-17436
https://issues.apache.org/jira/browse/AMBARI-17436


Repository: ambari


Description
---

Description
Add one new property to oozie-site.xml
change permissions for the extension folders
change the hive location from /apps/data-mirroring to extensions-dir/mirroring/


Diffs
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 6cb4089 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/oozie-site.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/49222/diff/


Testing
---


Thanks,

Venkat Ranganathan

Re: Review Request 49221: Smart configs for Atlas to setup authentication as either LDAP or AD

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49221/#review139423
---




ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 (line 262)


For now, set all props to required with value as " " til Atlas team can 
tell me which ones are required/optional.



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
(line 123)


Added smart config theme



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
68)


This will no longer be needed once I know exactly which configs are 
required.


- Alejandro Fernandez


On June 25, 2016, 12:06 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49221/
> ---
> 
> (Updated June 25, 2016, 12:06 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Abhay Kulkarni, Robert Levas, Swapan 
> Shridhar, and Suma Shivaprasad.
> 
> 
> Bugs: AMBARI-17221
> https://issues.apache.org/jira/browse/AMBARI-17221
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> LDAP/AD authentication to Atlas was added in ATLAS-869. Ambari should support 
> Smart configs for Atlas to either use LDAP or AD.
> 
> Following configurations should be shown only when 
> "atlas.authentication.method.ldap.type" is set to "ldap":
> 
> * atlas.authentication.method.ldap.url=
> * atlas.authentication.method.ldap.userDNpattern=uid=
> * atlas.authentication.method.ldap.groupSearchBase=
> * atlas.authentication.method.ldap.groupSearchFilter=
> * atlas.authentication.method.ldap.groupRoleAttribute=cn
> * atlas.authentication.method.ldap.base.dn=
> * atlas.authentication.method.ldap.bind.dn=
> * atlas.authentication.method.ldap.bind.password=
> * atlas.authentication.method.ldap.referral=ignore
> * atlas.authentication.method.ldap.user.searchfilter=
> * atlas.authentication.method.ldap.default.role=ROLE_USER
> 
> Following configurations should be shown only when 
> "atlas.authentication.method.ldap.type" is set to "ad":
> 
> * atlas.authentication.method.ldap.ad.domain=
> * atlas.authentication.method.ldap.ad.url=
> * atlas.authentication.method.ldap.ad.base.dn=
> * atlas.authentication.method.ldap.ad.bind.dn=
> * atlas.authentication.method.ldap.ad.bind.password=
> * atlas.authentication.method.ldap.ad.referral=ignore
> * atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
> * atlas.authentication.method.ldap.ad.default.role=ROLE_USER
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  25df1c5 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
> 9f3eda9 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/themes/theme.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
>  5606ce6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  a5a63ba 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 614f0b1 
> 
> Diff: https://reviews.apache.org/r/49221/diff/
> 
> 
> Testing
> ---
> 
> Installed Atlas with HDP 2.5
> 
> Python unit tests passed.
> 
> ---
> Total run:1061
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 49221: [PREVIEW] Smart configs for Atlas to setup authentication as either LDAP or AD

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49221/
---

(Updated June 25, 2016, 12:08 a.m.)


Review request for Ambari, Jaimin Jetly, Abhay Kulkarni, Robert Levas, Swapan 
Shridhar, and Suma Shivaprasad.


Summary (updated)
-

[PREVIEW] Smart configs for Atlas to setup authentication as either LDAP or AD


Bugs: AMBARI-17221
https://issues.apache.org/jira/browse/AMBARI-17221


Repository: ambari


Description
---

LDAP/AD authentication to Atlas was added in ATLAS-869. Ambari should support 
Smart configs for Atlas to either use LDAP or AD.

Following configurations should be shown only when 
"atlas.authentication.method.ldap.type" is set to "ldap":

* atlas.authentication.method.ldap.url=
* atlas.authentication.method.ldap.userDNpattern=uid=
* atlas.authentication.method.ldap.groupSearchBase=
* atlas.authentication.method.ldap.groupSearchFilter=
* atlas.authentication.method.ldap.groupRoleAttribute=cn
* atlas.authentication.method.ldap.base.dn=
* atlas.authentication.method.ldap.bind.dn=
* atlas.authentication.method.ldap.bind.password=
* atlas.authentication.method.ldap.referral=ignore
* atlas.authentication.method.ldap.user.searchfilter=
* atlas.authentication.method.ldap.default.role=ROLE_USER

Following configurations should be shown only when 
"atlas.authentication.method.ldap.type" is set to "ad":

* atlas.authentication.method.ldap.ad.domain=
* atlas.authentication.method.ldap.ad.url=
* atlas.authentication.method.ldap.ad.base.dn=
* atlas.authentication.method.ldap.ad.bind.dn=
* atlas.authentication.method.ldap.ad.bind.password=
* atlas.authentication.method.ldap.ad.referral=ignore
* atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
* atlas.authentication.method.ldap.ad.default.role=ROLE_USER


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 25df1c5 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
9f3eda9 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/themes/theme.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
 5606ce6 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
 a5a63ba 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
614f0b1 

Diff: https://reviews.apache.org/r/49221/diff/


Testing
---

Installed Atlas with HDP 2.5

Python unit tests passed.

---
Total run:1061
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Review Request 49221: Smart configs for Atlas to setup authentication as either LDAP or AD

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49221/
---

Review request for Ambari, Jaimin Jetly, Abhay Kulkarni, Robert Levas, Swapan 
Shridhar, and Suma Shivaprasad.


Bugs: AMBARI-17221
https://issues.apache.org/jira/browse/AMBARI-17221


Repository: ambari


Description
---

LDAP/AD authentication to Atlas was added in ATLAS-869. Ambari should support 
Smart configs for Atlas to either use LDAP or AD.

Following configurations should be shown only when 
"atlas.authentication.method.ldap.type" is set to "ldap":

* atlas.authentication.method.ldap.url=
* atlas.authentication.method.ldap.userDNpattern=uid=
* atlas.authentication.method.ldap.groupSearchBase=
* atlas.authentication.method.ldap.groupSearchFilter=
* atlas.authentication.method.ldap.groupRoleAttribute=cn
* atlas.authentication.method.ldap.base.dn=
* atlas.authentication.method.ldap.bind.dn=
* atlas.authentication.method.ldap.bind.password=
* atlas.authentication.method.ldap.referral=ignore
* atlas.authentication.method.ldap.user.searchfilter=
* atlas.authentication.method.ldap.default.role=ROLE_USER

Following configurations should be shown only when 
"atlas.authentication.method.ldap.type" is set to "ad":

* atlas.authentication.method.ldap.ad.domain=
* atlas.authentication.method.ldap.ad.url=
* atlas.authentication.method.ldap.ad.base.dn=
* atlas.authentication.method.ldap.ad.bind.dn=
* atlas.authentication.method.ldap.ad.bind.password=
* atlas.authentication.method.ldap.ad.referral=ignore
* atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
* atlas.authentication.method.ldap.ad.default.role=ROLE_USER


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 25df1c5 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
9f3eda9 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/themes/theme.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
 5606ce6 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
 a5a63ba 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
614f0b1 

Diff: https://reviews.apache.org/r/49221/diff/


Testing
---

Installed Atlas with HDP 2.5

Python unit tests passed.

---
Total run:1061
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 49220: AMBARI-17434. Keep empty value for Hive2/hive-interactive-site.xml config 'hive.llap.io.memory.mode'.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49220/#review139421
---


Ship it!




Ship It!

- Sumit Mohanty


On June 24, 2016, 11:45 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49220/
> ---
> 
> (Updated June 24, 2016, 11:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17434
> https://issues.apache.org/jira/browse/AMBARI-17434
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - 'hive.llap.io.memory.mode' config should be empty at all times.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  45d94cd 
> 
> Diff: https://reviews.apache.org/r/49220/diff/
> 
> 
> Testing
> ---
> 
> Tested Ambari install via Blueprints with Hive service and HSI ON.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 49150: AMBARI-17379: set verbose on HostCleanup.py does not work

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49150/#review139415
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 23, 2016, 12:39 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49150/
> ---
> 
> (Updated June 23, 2016, 12:39 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17379
> https://issues.apache.org/jira/browse/AMBARI-17379
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HostCleanup.py allows users to run it with the verbose option by passing in 
> '-v' command line parameter. Currently the parameter does not trigger the 
> verbose output.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 1655fbd 
> 
> Diff: https://reviews.apache.org/r/49150/diff/
> 
> 
> Testing
> ---
> 
> unit test for HostCleanup.py
> Patch a cluster with the new script and run HostCleanup.py with -v option
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 49036: Allow https prtotocol for Log Search

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49036/
---

(Updated June 24, 2016, 8:39 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

Hide passwords in the logs.


Bugs: AMBARI-17348
https://issues.apache.org/jira/browse/AMBARI-17348


Repository: ambari


Description
---

Add a property to choose whether or not the Log Search UI should run using 
https.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 171ea8c 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 376dfee 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 993c532 
  ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 6c687b9 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 38946f6 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 a5eebc2 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
 26a303c 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
 e0d42d3 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
 155ff04 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 d21a97f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
 2993190 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
 3f5db30 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2
 aba06c6 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
 7b0aed3 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-solr-env.sh.j2
 2b17e63 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
 fc71dfc 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 848be40 
  ambari-web/app/data/HDP2/site_properties.js e1adbb9 

Diff: https://reviews.apache.org/r/49036/diff/


Testing
---

Tested on local cluster, works fine with every combination of with/without SSL 
Solr connect, and http/https protocol for Log Search UI.

ambari-server:
OK
--
Total run:1072
Total errors:0
Total failures:0


Thanks,

Miklos Gergely

Re: Review Request 49124: AMBARI-17387 Changing HDP repo URL does not leads to sending written URL to ambari-server while registering new HDP version

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49124/#review139398
---


Ship it!




Ship It!

- Jaimin Jetly


On June 22, 2016, 11:53 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49124/
> ---
> 
> (Updated June 22, 2016, 11:53 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-17387
> https://issues.apache.org/jira/browse/AMBARI-17387
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
>   Deploy cluster HDP 2.3
>   Register HDP 2.5.0.0 latest (e.g 2.5.0.0-664)
>   Try to register 2.5.0.0, but with other URL (e.g for HDP 2.5.0.0-569)
> Result: internal server error " Base url 
> http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/BUILDS/2.5.0.0-664
>  is already defined for another repository version"
> But in this case we were trying to register 
> http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/BUILDS/2.5.0.0-569
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  6cf6849 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> f896c02 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> 1131041 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html
>  ea577f6 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  6268030 
> 
> Diff: https://reviews.apache.org/r/49124/diff/
> 
> 
> Testing
> ---
> 
> ambari-admin:
> Executed 76 of 76 SUCCESS (0.128 secs / 0.378 secs)
> Manual testing done
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Review Request 49213: Ambari Is Initializing the Metastore Using the Wrong schematool Binary on HDP 2.5

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49213/
---

Review request for Ambari and Nate Cole.


Bugs: AMBARI-17431
https://issues.apache.org/jira/browse/AMBARI-17431


Repository: ambari


Description
---

On HDP 2.5 installations, the {{hive-metastore}} component's {{schematool}} is 
being used to create the schema. This is incorrect in that the {{hive2}} 
{{schematool}} should be used since it's compatible with Hive LLAP and 
{{HiveServer2}}.

{noformat}
mysql> select * from VERSION;
+++---+
| VER_ID | SCHEMA_VERSION | VERSION_COMMENT   |
+++---+
|  1 | 1.2.1000   | Hive release version 1.2.1000 |
+++---+
1 row in set (0.00 sec)
{noformat}


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 2afee3b 

Diff: https://reviews.apache.org/r/49213/diff/


Testing
---

Deployed an HDP 2.5 stack and verified the schema:

mysql> select * from VERSION;
++++
| VER_ID | SCHEMA_VERSION | VERSION_COMMENT|
++++
|  1 | 2.1.0  | Hive release version 2.1.0 |
++++
1 row in set (0.00 sec)


Thanks,

Jonathan Hurley

Re: Review Request 49036: Allow https prtotocol for Log Search

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49036/
---

(Updated June 24, 2016, 5:13 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

solr_cloud_util was updated too to support solr SSL and it is using long option 
names now


Bugs: AMBARI-17348
https://issues.apache.org/jira/browse/AMBARI-17348


Repository: ambari


Description
---

Add a property to choose whether or not the Log Search UI should run using 
https.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 171ea8c 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 376dfee 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 993c532 
  ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 6c687b9 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 38946f6 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 a5eebc2 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
 26a303c 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
 e0d42d3 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
 155ff04 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 d21a97f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
 2993190 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
 3f5db30 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2
 aba06c6 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
 7b0aed3 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-solr-env.sh.j2
 2b17e63 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
 fc71dfc 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 848be40 
  ambari-web/app/data/HDP2/site_properties.js e1adbb9 

Diff: https://reviews.apache.org/r/49036/diff/


Testing
---

Tested on local cluster, works fine with every combination of with/without SSL 
Solr connect, and http/https protocol for Log Search UI.

ambari-server:
OK
--
Total run:1072
Total errors:0
Total failures:0


Thanks,

Miklos Gergely

Re: Review Request 49204: Incorrect error message for invalid category in Host Combo Search Box

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49204/#review139385
---


Ship it!




Ship It!

- Alexandr Antonenko


On June 24, 2016, 4:35 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49204/
> ---
> 
> (Updated June 24, 2016, 4:35 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Richard Zang.
> 
> 
> Bugs: AMBARI-17410
> https://issues.apache.org/jira/browse/AMBARI-17410
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. In the host combo box, if an invalid category is entered, an error is 
> displayed 
> [object Object] is not a valid category.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/main/host/combo_search_box.js 54c2df4 
> 
> Diff: https://reviews.apache.org/r/49204/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> Ran mvn test in ambari-web
> 
> 28977 tests complete (36 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 49173: AMBARI-17416: AMS-Grafana: show 'alias' when there's no datapoint available

[Prajwal Rao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49173/#review139384
---




ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js (lines 100 - 
105)


All graphs on Kafka-Topics have legend hidden.



ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js (lines 128 - 
133)


All graphs on HBase-Users have legend hidden.

We do need to handle this on aggregate level dashboards and graphs, and I 
already have a separate fix for that.


- Prajwal Rao


On June 24, 2016, 1:42 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49173/
> ---
> 
> (Updated June 24, 2016, 1:42 a.m.)
> 
> 
> Review request for Ambari, Prajwal Rao, Sriharsha Chintalapani, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-17416
> https://issues.apache.org/jira/browse/AMBARI-17416
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When there's no datapoint available, AMS Grafana plugin just ignores alias 
> and shows metric name instead. It seems to be not consistent in point of 
> view, and not good UX I think.
> 
> It'd be great AMS Grafana shows alias whenever there're datapoints available 
> or not.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 6a4f01b 
> 
> Diff: https://reviews.apache.org/r/49173/diff/
> 
> 
> Testing
> ---
> 
> Tested manually. Actually this is tiny fix so we can imagine how it will make 
> change.
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 49205: Fix serviceconfig NPE in db consistency checker

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49205/#review139380
---


Ship it!




Ship It!

- Dmytro Sen


On Июнь 24, 2016, 4:32 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49205/
> ---
> 
> (Updated Июнь 24, 2016, 4:32 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, 
> Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17430
> https://issues.apache.org/jira/browse/AMBARI-17430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During testting discovered this issue:
> {code}
> 2016-06-23 18:07:46,467 ERROR - Unexpected error, database check failed
> java.lang.NullPointerException
>   at 
> org.apache.ambari.server.checks.DatabaseConsistencyCheckHelper.checkServiceConfigs(DatabaseConsistencyCheckHelper.java:514)
>   at 
> org.apache.ambari.server.checks.DatabaseConsistencyChecker.main(DatabaseConsistencyChecker.java:115)
> {code}
> It should be fixed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  d85b6f2 
> 
> Diff: https://reviews.apache.org/r/49205/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 49204: Incorrect error message for invalid category in Host Combo Search Box

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49204/
---

Review request for Ambari, Alexandr Antonenko and Richard Zang.


Bugs: AMBARI-17410
https://issues.apache.org/jira/browse/AMBARI-17410


Repository: ambari


Description
---

1. In the host combo box, if an invalid category is entered, an error is 
displayed 
[object Object] is not a valid category.


Diffs
-

  ambari-web/app/views/main/host/combo_search_box.js 54c2df4 

Diff: https://reviews.apache.org/r/49204/diff/


Testing
---

Manual testing.
Ran mvn test in ambari-web

28977 tests complete (36 seconds)
154 tests pending


Thanks,

Sangeeta Ravindran

Review Request 49205: Fix serviceconfig NPE in db consistency checker

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49205/
---

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, 
Myroslav Papirkovskyy, and Sumit Mohanty.


Bugs: AMBARI-17430
https://issues.apache.org/jira/browse/AMBARI-17430


Repository: ambari


Description
---

During testting discovered this issue:
{code}
2016-06-23 18:07:46,467 ERROR - Unexpected error, database check failed
java.lang.NullPointerException
at 
org.apache.ambari.server.checks.DatabaseConsistencyCheckHelper.checkServiceConfigs(DatabaseConsistencyCheckHelper.java:514)
at 
org.apache.ambari.server.checks.DatabaseConsistencyChecker.main(DatabaseConsistencyChecker.java:115)
{code}
It should be fixed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 d85b6f2 

Diff: https://reviews.apache.org/r/49205/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 49145: Ability to add "javax.jdo.option.ConnectionPassword" to hive clients from ambari

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49145/
---

(Updated June 24, 2016, 4:07 p.m.)


Review request for Ambari, Robert Levas and Vitalyi Brodetskyi.


Bugs: AMBARI-17223
https://issues.apache.org/jira/browse/AMBARI-17223


Repository: ambari


Description
---

Problem is that they need to access the "javax.jdo.option.ConnectionPassword"
password but Ambari is pushing only to /etc/hive/conf.server/hive-site.xml. I
have instructed and recommended various workarounds and even suggest modifying
their app. Even having a static hive-site.xm with the information they did not
accept and asked to open an enhancement request. The enhancement is to allow
adding "javax.jdo.option.ConnectionPassword" to hive clients from ambari and
have a separate hive-site.xml path for clients.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 622ee88 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 349668f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 9a86827 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
4feba62 
  ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
c30f28f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
 931d58b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
 61437d5 
  ambari-server/src/main/resources/configuration-schema.xsd 0e17b0e 
  
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
 229f7e1 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
 1743bf8 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
 0ff143c 
  
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HIVE/configuration/hive-site.xml
 5a3cb6c 

Diff: https://reviews.apache.org/r/49145/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 49203: Add missing components to LogSearch (part II)

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49203/
---

(Updated June 24, 2016, 3:19 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-17424
https://issues.apache.org/jira/browse/AMBARI-17424


Repository: ambari


Description
---

Adding logs for
Log Search - Solr
HBase - Phoenix Server
Flume - Flume Handler
Zeppelin - Zeppelin


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
 73400e3 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/metainfo.xml 
0396c28 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
e3a8f98 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 d21a97f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-flume.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hbase.json.j2
 fb47e77 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-logsearch.json.j2
 ba151b9 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-zeppelin.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
 c40a593 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/metainfo.xml 
0614cf7 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 0613770 

Diff: https://reviews.apache.org/r/49203/diff/


Testing
---

ambari-server

OK
--
Total run:1072
Total errors:0
Total failures:0


Thanks,

Miklos Gergely

Re: Review Request 49195: Add missing components to Log Search (part I)

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49195/
---

(Updated June 24, 2016, 3:08 p.m.)


Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
and Sumit Mohanty.


Changes
---

- fixed SPARK pattern


Bugs: AMBARI-17423
https://issues.apache.org/jira/browse/AMBARI-17423


Repository: ambari


Description
---

contains the following components:
-SPARK
-SPARK2
-METRICS_GRAFANA
-NFS_GATEWAY
-SmartSense
-WEBHCAT_SERVER
-LIVY

dropped:
-HIVE_SERVER_INTERACTIVE (logging to actual folder where we run the process)
-MYSQL_SERVER (we cannot be sure that is the mysql installed by ambari, it can 
be any mysql server)
and other clients are dropped as well


Add widgets as well on Log Search side.
SmartSense metainfo.xml is not in ambari repository so that was not added


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
 73400e3 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
 4f6979b 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 d21a97f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
 c85a06a 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ams.json.j2
 34c1ed4 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hdfs.json.j2
 730ef99 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hive.json.j2
 131ae86 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hst.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-spark.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-spark2.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-yarn.json.j2
 fb35620 
  ambari-server/src/main/resources/common-services/SPARK/1.2.1/metainfo.xml 
86af492 
  ambari-server/src/main/resources/common-services/SPARK/1.4.1/metainfo.xml 
99bab04 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
783f049 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
67303b6 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 0613770 

Diff: https://reviews.apache.org/r/49195/diff/


Testing
---

Total run:1072
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 49162: Update Zeppelin service definition

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49162/#review139374
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On June 23, 2016, 7:07 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49162/
> ---
> 
> (Updated June 23, 2016, 7:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17406
> https://issues.apache.org/jira/browse/AMBARI-17406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - comment session manager config in shiro.ini
> - fix default value for zeppelin kerberos properties
> - extract kerberos config update to a new function
> - prevent overwriting interpreter config
> - set default value for spark and livy master
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  844ae98 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  f2899d0 
> 
> Diff: https://reviews.apache.org/r/49162/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 49195: Add missing components to Log Search (part I)

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49195/#review139373
---


Ship it!




Ship It!

- Miklos Gergely


On June 24, 2016, 2:14 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49195/
> ---
> 
> (Updated June 24, 2016, 2:14 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17423
> https://issues.apache.org/jira/browse/AMBARI-17423
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> contains the following components:
> -SPARK
> -SPARK2
> -METRICS_GRAFANA
> -NFS_GATEWAY
> -SmartSense
> -WEBHCAT_SERVER
> -LIVY
> 
> dropped:
> -HIVE_SERVER_INTERACTIVE (logging to actual folder where we run the process)
> -MYSQL_SERVER (we cannot be sure that is the mysql installed by ambari, it 
> can be any mysql server)
> and other clients are dropped as well
> 
> 
> Add widgets as well on Log Search side.
> SmartSense metainfo.xml is not in ambari repository so that was not added
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
>  73400e3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
>  4f6979b 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  d21a97f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
>  c85a06a 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ams.json.j2
>  34c1ed4 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hdfs.json.j2
>  730ef99 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hive.json.j2
>  131ae86 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hst.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-spark.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-spark2.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-yarn.json.j2
>  fb35620 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.1/metainfo.xml 
> 86af492 
>   ambari-server/src/main/resources/common-services/SPARK/1.4.1/metainfo.xml 
> 99bab04 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
> 783f049 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> 67303b6 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 
> 0613770 
> 
> Diff: https://reviews.apache.org/r/49195/diff/
> 
> 
> Testing
> ---
> 
> Total run:1072
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 49203: Add missing components to LogSearch (part II)

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49203/
---

(Updated June 24, 2016, 2:54 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

forgot to add test changes


Bugs: AMBARI-17424
https://issues.apache.org/jira/browse/AMBARI-17424


Repository: ambari


Description
---

Adding logs for
Log Search - Solr
HBase - Phoenix Server
Flume - Flume Handler
Zeppelin - Zeppelin


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
 73400e3 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/metainfo.xml 
0396c28 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
e3a8f98 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 d21a97f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-flume.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hbase.json.j2
 fb47e77 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-logsearch.json.j2
 ba151b9 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-zeppelin.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
 f609156 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/metainfo.xml 
0614cf7 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 0613770 

Diff: https://reviews.apache.org/r/49203/diff/


Testing
---

ambari-server

OK
--
Total run:1072
Total errors:0
Total failures:0


Thanks,

Miklos Gergely

Re: Review Request 49203: Add missing components to LogSearch (part II)

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49203/#review139372
---


Ship it!




Ship It!

- Oliver Szabo


On June 24, 2016, 2:48 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49203/
> ---
> 
> (Updated June 24, 2016, 2:48 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17424
> https://issues.apache.org/jira/browse/AMBARI-17424
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding logs for
> Log Search - Solr
> HBase - Phoenix Server
> Flume - Flume Handler
> Zeppelin - Zeppelin
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
>  73400e3 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/metainfo.xml 
> 0396c28 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> e3a8f98 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  d21a97f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-flume.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hbase.json.j2
>  fb47e77 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-logsearch.json.j2
>  ba151b9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-zeppelin.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  f609156 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/metainfo.xml 
> 0614cf7 
> 
> Diff: https://reviews.apache.org/r/49203/diff/
> 
> 
> Testing
> ---
> 
> ambari-server
> 
> OK
> --
> Total run:1072
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 49203: Add missing components to LogSearch (part II)

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49203/
---

Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-17424
https://issues.apache.org/jira/browse/AMBARI-17424


Repository: ambari


Description
---

Adding logs for
Log Search - Solr
HBase - Phoenix Server
Flume - Flume Handler
Zeppelin - Zeppelin


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
 73400e3 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/metainfo.xml 
0396c28 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
e3a8f98 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 d21a97f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-flume.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hbase.json.j2
 fb47e77 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-logsearch.json.j2
 ba151b9 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-zeppelin.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
 f609156 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/metainfo.xml 
0614cf7 

Diff: https://reviews.apache.org/r/49203/diff/


Testing
---

ambari-server

OK
--
Total run:1072
Total errors:0
Total failures:0


Thanks,

Miklos Gergely

Re: Review Request 49119: AMBARI-17383: User names should be case insensitive

[Robert Levas]

> On June 23, 2016, 3:31 a.m., Myroslav Papirkovskyy wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/User.java,
> >  line 49
> > 
> >
> > IMO user name should be stored and returned in original case.
> > Only comparison should be case insensitive.
> 
> Robert Levas wrote:
> I agree that the name should be stored lowercase.
> 
> Nahappan Somasundaram wrote:
> This is required for backward compatibility. If the DB contains user 
> names in uppercase or mixed case, say like ABCD, then querying it will fail:
> 
> curl -u admin:admin -X GET http://localhost:8080/api/v1/users/abcd

I think both should happen... store usernames as tolower, and maintain a 
lowercase username in the logic to ensure unifirmity.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49119/#review139221
---


On June 23, 2016, 11:19 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49119/
> ---
> 
> (Updated June 23, 2016, 11:19 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17383
> https://issues.apache.org/jira/browse/AMBARI-17383
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-17383: User names should be case insensitive
> 
> ** Issue: **
> It should not be possible to add user names that differ only by case. 
> 
> ** Fix: **
> 1. Make a case insensitive string comparision against the DB Users table to 
> see if the input user name already exists.
> 2. Added a new UT to test this change.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  9f82a908114a920087524ea9a42628500972c64d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 
> d209cfcfc5ce5a78354220cf084e9a394841af49 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  0bf7ec269f00cbe2506eae1e5692a73af74b1d99 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  a8c9b19ade9a31a303095527059c03f2b3341913 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/User.java
>  720918b646d4a70b9b53a1d2da05dd391adb03e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  1a7b58db3759dff876ca0e909ab62170c8f49955 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
>  dc22bb914df36bb9b3fbf27d3c2fbf1251489553 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/SecurityHelperImplTest.java
>  a509f541438981a5302f6646df387f27f6095d01 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariUserAuthenticationFilterTest.java
>  b20607814f872547d5f03fbd9a76e7c15c328a96 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
>  44fb73c2644a75a8165425b97137dac20042972b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  4ff751dcbad83ca0eeb27a81fd261e51ec0bd975 
> 
> Diff: https://reviews.apache.org/r/49119/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [5.972s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.038s]
> [INFO] Ambari Web  SUCCESS [24.668s]
> [INFO] Ambari Views .. SUCCESS [1.161s]
> [INFO] Ambari Admin View . SUCCESS [9.686s]
> [INFO] ambari-metrics  SUCCESS [0.711s]
> [INFO] Ambari Metrics Common . SUCCESS [0.868s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.184s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.648s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.671s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.630s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.722s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.332s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.885s]
> [INFO] Ambari Metrics Assembly 

Re: Review Request 49195: Add missing components to Log Search (part I)

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49195/
---

(Updated June 24, 2016, 2:14 p.m.)


Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
and Sumit Mohanty.


Changes
---

- fix ams_monitor log
- fix small typo


Bugs: AMBARI-17423
https://issues.apache.org/jira/browse/AMBARI-17423


Repository: ambari


Description
---

contains the following components:
-SPARK
-SPARK2
-METRICS_GRAFANA
-NFS_GATEWAY
-SmartSense
-WEBHCAT_SERVER
-LIVY

dropped:
-HIVE_SERVER_INTERACTIVE (logging to actual folder where we run the process)
-MYSQL_SERVER (we cannot be sure that is the mysql installed by ambari, it can 
be any mysql server)
and other clients are dropped as well


Add widgets as well on Log Search side.
SmartSense metainfo.xml is not in ambari repository so that was not added


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
 73400e3 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
 4f6979b 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 d21a97f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
 c85a06a 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ams.json.j2
 34c1ed4 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hdfs.json.j2
 730ef99 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hive.json.j2
 131ae86 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hst.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-spark.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-spark2.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-yarn.json.j2
 fb35620 
  ambari-server/src/main/resources/common-services/SPARK/1.2.1/metainfo.xml 
86af492 
  ambari-server/src/main/resources/common-services/SPARK/1.4.1/metainfo.xml 
99bab04 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
783f049 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
67303b6 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 0613770 

Diff: https://reviews.apache.org/r/49195/diff/


Testing
---

Total run:1072
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 49198: Support Atlas in kerberized environment, submit Service Check as smokeuser

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49198/#review139369
---




ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
 (line 36)


This command needs to be executed as params.smoke_test_user, else it will 
not have access to the smoke test user's Kerberos ticket cache.



ambari-server/src/test/python/stacks/2.3/ATLAS/test_service_check.py (line 58)


user = 'ambari-qa'


- Robert Levas


On June 24, 2016, 9:10 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49198/
> ---
> 
> (Updated June 24, 2016, 9:10 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmytro Grinenko.
> 
> 
> Bugs: AMBARI-17427
> https://issues.apache.org/jira/browse/AMBARI-17427
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas Service Check should use smokeuser instead of atlas user.
> 
> {code}
> 2016-06-19 10:46:19,971 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> 2016-06-19 10:46:19,979 - Execute['/usr/bin/kinit -kt 
> /etc/security/keytabs/smokeuser.headless.keytab ambari-qa-...@example.com'] 
> {'user': 'atlas'}
> 2016-06-19 10:46:20,198 - Execute['curl --negotiate -u : -b ~/cookiejar.txt 
> -c ~/cookiejar.txt -s -o /dev/null -w "%{http_code}" 
> http://mneethiraj-0618-1.openstacklocal:21000/'] {'tries': 5, 'user': 
> 'atlas', 'try_sleep': 10}
> 2016-06-19 10:46:50,438 - Retrying after 10 seconds. Reason: Execution of 
> 'curl --negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null 
> -w "%{http_code}" http://mneethiraj-0618-1.openstacklocal:21000/' returned 
> 52. 000
> 2016-06-19 10:47:30,610 - Retrying after 10 seconds. Reason: Execution of 
> 'curl --negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null 
> -w "%{http_code}" http://mneethiraj-0618-1.openstacklocal:21000/' returned 
> 52. 000
> 2016-06-19 10:48:10,738 - Retrying after 10 seconds. Reason: Execution of 
> 'curl --negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null 
> -w "%{http_code}" http://mneethiraj-0618-1.openstacklocal:21000/' returned 
> 52. 000
> 2016-06-19 10:48:50,863 - Retrying after 10 seconds. Reason: Execution of 
> 'curl --negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null 
> -w "%{http_code}" http://mneethiraj-0618-1.openstacklocal:21000/' returned 
> 52. 000
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  194a3fb 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_service_check.py 
> 49395a7 
> 
> Diff: https://reviews.apache.org/r/49198/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and test on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 49198: Support Atlas in kerberized environment, submit Service Check as smokeuser

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49198/#review139370
---


Ship it!




Ship It!

- Dmytro Grinenko


On June 24, 2016, 1:10 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49198/
> ---
> 
> (Updated June 24, 2016, 1:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmytro Grinenko.
> 
> 
> Bugs: AMBARI-17427
> https://issues.apache.org/jira/browse/AMBARI-17427
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas Service Check should use smokeuser instead of atlas user.
> 
> {code}
> 2016-06-19 10:46:19,971 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> 2016-06-19 10:46:19,979 - Execute['/usr/bin/kinit -kt 
> /etc/security/keytabs/smokeuser.headless.keytab ambari-qa-...@example.com'] 
> {'user': 'atlas'}
> 2016-06-19 10:46:20,198 - Execute['curl --negotiate -u : -b ~/cookiejar.txt 
> -c ~/cookiejar.txt -s -o /dev/null -w "%{http_code}" 
> http://mneethiraj-0618-1.openstacklocal:21000/'] {'tries': 5, 'user': 
> 'atlas', 'try_sleep': 10}
> 2016-06-19 10:46:50,438 - Retrying after 10 seconds. Reason: Execution of 
> 'curl --negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null 
> -w "%{http_code}" http://mneethiraj-0618-1.openstacklocal:21000/' returned 
> 52. 000
> 2016-06-19 10:47:30,610 - Retrying after 10 seconds. Reason: Execution of 
> 'curl --negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null 
> -w "%{http_code}" http://mneethiraj-0618-1.openstacklocal:21000/' returned 
> 52. 000
> 2016-06-19 10:48:10,738 - Retrying after 10 seconds. Reason: Execution of 
> 'curl --negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null 
> -w "%{http_code}" http://mneethiraj-0618-1.openstacklocal:21000/' returned 
> 52. 000
> 2016-06-19 10:48:50,863 - Retrying after 10 seconds. Reason: Execution of 
> 'curl --negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null 
> -w "%{http_code}" http://mneethiraj-0618-1.openstacklocal:21000/' returned 
> 52. 000
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  194a3fb 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_service_check.py 
> 49395a7 
> 
> Diff: https://reviews.apache.org/r/49198/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and test on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 49199: Falcon client install failed

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49199/#review139368
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Червень 24, 2016, 4:20 після полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49199/
> ---
> 
> (Updated Червень 24, 2016, 4:20 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, 
> Vitalyi Brodetskyi, and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-17428
> https://issues.apache.org/jira/browse/AMBARI-17428
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Falcon client failed and is blocking UI installs :
> 
> "Traceback (most recent call last):\n  File 
> \"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py\",
>  line 80, in \nFalconClient().execute()\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
>  line 280, in execute\nmethod(env)\n  File 
> \"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py\",
>  line 45, in install\nself.configure(env)\n  File 
> \"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py\",
>  line 33, in configure\nfalcon('client', action='config')\n  File 
> \"/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py\", line 
> 89, in thunk\nreturn fn(*args, **kwargs)\n  File 
> \"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py\",
>  line 84, in falcon\nowner = params.falcon_user)\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/core/ba
 se.py\", line 155, in __init__\nself.env.run()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 160, in run\nself.run_action(resource, action)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 124, in run_action\nprovider_action()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/properties_file.py\",
 line 54, in action_create\nmode = self.resource.mode\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/base.py\", line 
155, in __init__\nself.env.run()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 160, in run\nself.run_action(resource, action)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 124, in run_action\nprovider_action()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py\",
 line 123, in action_cr
 eate\ncontent = self._get_content()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py\",
 line 160, in _get_content\nreturn content()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/source.py\", line 
51, in __call__\nreturn self.get_content()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/source.py\", line 
142, in get_content\nrendered = self.template.render(self.context)\n  File 
\"/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py\", line 891, in 
render\nreturn self.environment.handle_exception(exc_info, True)\n  File 
\"\", line 2, in top-level template code\n  File 
\"/usr/lib/python2.6/site-packages/ambari_jinja2/filters.py\", line 176, in 
do_dictsort\nreturn sorted(value.items(), key=sort_func)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py\",
 line 73, in __getattr__\nraise Fail(\"Configuration paramet
 er '\" + self.name + \"' was not found in configurations 
dictionary!\")\nresource_management.core.exceptions.Fail: Configuration 
parameter 'falcon-client.properties' was not found in configurations 
dictionary!",
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-client.properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml
>  985e7f4 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  2bdaa48 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/configuration/falcon-client.properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/metainfo.xml
>  2e444b1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/params.py
>  41ecafa 
> 
> Diff: https://reviews.apache.org/r/49199/diff/
> 
> 
> 

Review Request 49199: Falcon client install failed

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49199/
---

Review request for Ambari, Myroslav Papirkovskyy and Vitalyi Brodetskyi.


Bugs: AMBARI-17428
https://issues.apache.org/jira/browse/AMBARI-17428


Repository: ambari


Description
---

Falcon client failed and is blocking UI installs :

"Traceback (most recent call last):\n  File 
\"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py\",
 line 80, in \nFalconClient().execute()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
 line 280, in execute\nmethod(env)\n  File 
\"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py\",
 line 45, in install\nself.configure(env)\n  File 
\"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py\",
 line 33, in configure\nfalcon('client', action='config')\n  File 
\"/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py\", line 89, 
in thunk\nreturn fn(*args, **kwargs)\n  File 
\"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py\",
 line 84, in falcon\nowner = params.falcon_user)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/base
 .py\", line 155, in __init__\nself.env.run()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 160, in run\nself.run_action(resource, action)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 124, in run_action\nprovider_action()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/properties_file.py\",
 line 54, in action_create\nmode = self.resource.mode\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/base.py\", line 
155, in __init__\nself.env.run()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 160, in run\nself.run_action(resource, action)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 124, in run_action\nprovider_action()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py\",
 line 123, in action_crea
 te\ncontent = self._get_content()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py\",
 line 160, in _get_content\nreturn content()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/source.py\", line 
51, in __call__\nreturn self.get_content()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/source.py\", line 
142, in get_content\nrendered = self.template.render(self.context)\n  File 
\"/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py\", line 891, in 
render\nreturn self.environment.handle_exception(exc_info, True)\n  File 
\"\", line 2, in top-level template code\n  File 
\"/usr/lib/python2.6/site-packages/ambari_jinja2/filters.py\", line 176, in 
do_dictsort\nreturn sorted(value.items(), key=sort_func)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py\",
 line 73, in __getattr__\nraise Fail(\"Configuration parameter
  '\" + self.name + \"' was not found in configurations 
dictionary!\")\nresource_management.core.exceptions.Fail: Configuration 
parameter 'falcon-client.properties' was not found in configurations 
dictionary!",


Diffs
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-client.properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml 
985e7f4 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 2bdaa48 
  
ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/configuration/falcon-client.properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/metainfo.xml
 2e444b1 
  
ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/params.py
 41ecafa 

Diff: https://reviews.apache.org/r/49199/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Review Request 49198: Support Atlas in kerberized environment, submit Service Check as smokeuser

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49198/
---

Review request for Ambari, Alejandro Fernandez and Dmytro Grinenko.


Bugs: AMBARI-17427
https://issues.apache.org/jira/browse/AMBARI-17427


Repository: ambari


Description
---

Atlas Service Check should use smokeuser instead of atlas user.

{code}
2016-06-19 10:46:19,971 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
2016-06-19 10:46:19,979 - Execute['/usr/bin/kinit -kt 
/etc/security/keytabs/smokeuser.headless.keytab ambari-qa-...@example.com'] 
{'user': 'atlas'}
2016-06-19 10:46:20,198 - Execute['curl --negotiate -u : -b ~/cookiejar.txt -c 
~/cookiejar.txt -s -o /dev/null -w "%{http_code}" 
http://mneethiraj-0618-1.openstacklocal:21000/'] {'tries': 5, 'user': 'atlas', 
'try_sleep': 10}
2016-06-19 10:46:50,438 - Retrying after 10 seconds. Reason: Execution of 'curl 
--negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null -w 
"%{http_code}" http://mneethiraj-0618-1.openstacklocal:21000/' returned 52. 000
2016-06-19 10:47:30,610 - Retrying after 10 seconds. Reason: Execution of 'curl 
--negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null -w 
"%{http_code}" http://mneethiraj-0618-1.openstacklocal:21000/' returned 52. 000
2016-06-19 10:48:10,738 - Retrying after 10 seconds. Reason: Execution of 'curl 
--negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null -w 
"%{http_code}" http://mneethiraj-0618-1.openstacklocal:21000/' returned 52. 000
2016-06-19 10:48:50,863 - Retrying after 10 seconds. Reason: Execution of 'curl 
--negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null -w 
"%{http_code}" http://mneethiraj-0618-1.openstacklocal:21000/' returned 52. 000
{code}


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
 194a3fb 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_service_check.py 49395a7 

Diff: https://reviews.apache.org/r/49198/diff/


Testing
---

mvn clean test and test on live cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 49195: Add missing components to Log Search (part I)

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49195/
---

(Updated June 24, 2016, 1:05 p.m.)


Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
and Sumit Mohanty.


Bugs: AMBARI-17423
https://issues.apache.org/jira/browse/AMBARI-17423


Repository: ambari


Description (updated)
---

contains the following components:
-SPARK
-SPARK2
-METRICS_GRAFANA
-NFS_GATEWAY
-SmartSense
-WEBHCAT_SERVER
-LIVY

dropped:
-HIVE_SERVER_INTERACTIVE (logging to actual folder where we run the process)
-MYSQL_SERVER (we cannot be sure that is the mysql installed by ambari, it can 
be any mysql server)
and other clients are dropped as well


Add widgets as well on Log Search side.
SmartSense metainfo.xml is not in ambari repository so that was not added


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
 73400e3 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
 4f6979b 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 d21a97f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
 c85a06a 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ams.json.j2
 34c1ed4 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hdfs.json.j2
 730ef99 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hive.json.j2
 131ae86 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hst.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-spark.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-spark2.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-yarn.json.j2
 fb35620 
  ambari-server/src/main/resources/common-services/SPARK/1.2.1/metainfo.xml 
86af492 
  ambari-server/src/main/resources/common-services/SPARK/1.4.1/metainfo.xml 
99bab04 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
783f049 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
67303b6 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 0613770 

Diff: https://reviews.apache.org/r/49195/diff/


Testing
---

Total run:1072
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 49197: Ambari server setup failed on debian with postgres local db

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49197/#review139366
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Червень 24, 2016, 12:43 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49197/
> ---
> 
> (Updated Червень 24, 2016, 12:43 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17426
> https://issues.apache.org/jira/browse/AMBARI-17426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We have tests where we cleanup existing cluster and reinstall Ambari again -
> perform install, setup and start Ambari server. Starting up AMbari server is
> failing with the below erro
> 
> 
> 
> 
> Using python  /usr/bin/python
> Starting ambari-server
> ERROR: Exiting with exit code 1. 
> REASON: Unable to detect a system user for Ambari Server.
> - If this is a new setup, then run the "ambari-server setup" command to 
> create the user
> - If this is an upgrade of an existing setup, run the "ambari-server 
> upgrade" command.
> Refer to the Ambari documentation for more information on setup and 
> upgrade.
> 
> 
> Please see the logs [here](http://qelog.hortonworks.com/log/nat-os-d7-luls-
> ambari-blueprints-3/test-logs/ambari-blueprints/artifacts/screenshots/com.hw.a
> mbari.ui.tests.heavyweights.TestSingleNodeClustersViaBlueprint/testA_PrepareCl
> uster/_23_0_54_11_Exceptions_appeared_during_install/test_logs/test_TestSingle
> NodeClustersViaBlueprint_debug.log). We can see that at the beginning Ambari
> server is up and running fine. BUt after cleanup and reinstall server is not
> coming up. Could you please help take a look.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> 5a3e290 
> 
> Diff: https://reviews.apache.org/r/49197/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 49197: Ambari server setup failed on debian with postgres local db

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49197/
---

(Updated June 24, 2016, 12:43 p.m.)


Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-17426
https://issues.apache.org/jira/browse/AMBARI-17426


Repository: ambari


Description
---

We have tests where we cleanup existing cluster and reinstall Ambari again -
perform install, setup and start Ambari server. Starting up AMbari server is
failing with the below erro




Using python  /usr/bin/python
Starting ambari-server
ERROR: Exiting with exit code 1. 
REASON: Unable to detect a system user for Ambari Server.
- If this is a new setup, then run the "ambari-server setup" command to 
create the user
- If this is an upgrade of an existing setup, run the "ambari-server 
upgrade" command.
Refer to the Ambari documentation for more information on setup and upgrade.


Please see the logs [here](http://qelog.hortonworks.com/log/nat-os-d7-luls-
ambari-blueprints-3/test-logs/ambari-blueprints/artifacts/screenshots/com.hw.a
mbari.ui.tests.heavyweights.TestSingleNodeClustersViaBlueprint/testA_PrepareCl
uster/_23_0_54_11_Exceptions_appeared_during_install/test_logs/test_TestSingle
NodeClustersViaBlueprint_debug.log). We can see that at the beginning Ambari
server is up and running fine. BUt after cleanup and reinstall server is not
coming up. Could you please help take a look.


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 5a3e290 

Diff: https://reviews.apache.org/r/49197/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 49197: Ambari server setup failed on debian with postgres local db

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49197/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-17426
https://issues.apache.org/jira/browse/AMBARI-17426


Repository: ambari


Description
---

We have tests where we cleanup existing cluster and reinstall Ambari again -
perform install, setup and start Ambari server. Starting up AMbari server is
failing with the below erro




Using python  /usr/bin/python
Starting ambari-server
ERROR: Exiting with exit code 1. 
REASON: Unable to detect a system user for Ambari Server.
- If this is a new setup, then run the "ambari-server setup" command to 
create the user
- If this is an upgrade of an existing setup, run the "ambari-server 
upgrade" command.
Refer to the Ambari documentation for more information on setup and upgrade.


Please see the logs [here](http://qelog.hortonworks.com/log/nat-os-d7-luls-
ambari-blueprints-3/test-logs/ambari-blueprints/artifacts/screenshots/com.hw.a
mbari.ui.tests.heavyweights.TestSingleNodeClustersViaBlueprint/testA_PrepareCl
uster/_23_0_54_11_Exceptions_appeared_during_install/test_logs/test_TestSingle
NodeClustersViaBlueprint_debug.log). We can see that at the beginning Ambari
server is up and running fine. BUt after cleanup and reinstall server is not
coming up. Could you please help take a look.


Diffs
-

  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 
0ff0ba5 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 5a3e290 

Diff: https://reviews.apache.org/r/49197/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 49195: Add missing components to Log Search (part I)

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49195/
---

Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
and Sumit Mohanty.


Bugs: AMBARI-17423
https://issues.apache.org/jira/browse/AMBARI-17423


Repository: ambari


Description
---

contains the following components:
-SPARK
-SPARK2
-METRICS_GRAFANA
-NFS_GATEWAY
-SmartSense
-WEBHCAT_SERVER
-LIVY

dropped:
-HIVE_SERVER_INTERACTIVE (logging to hive log)
-MYSQL_SERVER (we cannot be sure that is the mysql installed by ambari, it can 
be any mysql server)
and other clients are dropped as well


Add widgets as well on Log Search side.
SmartSense metainfo.xml is not in ambari repository so that was not added


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
 73400e3 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
 4f6979b 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 d21a97f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
 c85a06a 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ams.json.j2
 34c1ed4 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hdfs.json.j2
 730ef99 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hive.json.j2
 131ae86 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hst.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-spark.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-spark2.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-yarn.json.j2
 fb35620 
  ambari-server/src/main/resources/common-services/SPARK/1.2.1/metainfo.xml 
86af492 
  ambari-server/src/main/resources/common-services/SPARK/1.4.1/metainfo.xml 
99bab04 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
783f049 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
67303b6 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 0613770 

Diff: https://reviews.apache.org/r/49195/diff/


Testing
---

Total run:1072
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49193/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-16756
https://issues.apache.org/jira/browse/AMBARI-16756


Repository: ambari


Description
---

Updated ambari Ranger and Ranger KMS code for stop and status call from stack 
2.5 onwards


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 be2a4c8 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml
 3187971 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 ab5be74 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 0d9ce5f 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
 8313b18 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 ad0ac60 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py
 6cb69fb 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 5847984 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
 9360e70 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 452be86 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 574264e 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml
 ae45552 

Diff: https://reviews.apache.org/r/49193/diff/


Testing
---

Testes Ranger and Ranger KMS on centos 6


Thanks,

Mugdha Varadkar

Review Request 49194: [Hive view] hiveserver service check fails for LDAP configured hive view

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49194/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-17425
https://issues.apache.org/jira/browse/AMBARI-17425


Repository: ambari


Description
---

- Created a new service for LDAP authentication
- Used the same serivice at mutliple plcaes


Diffs
-

  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js 
2c3cd5e 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
36faa86 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/splash.js 
6f495ed 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/services/ldap-authentication.js
 PRE-CREATION 
  contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js 
ec8352b 

Diff: https://reviews.apache.org/r/49194/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49188/
---

Review request for Ambari, Alejandro Fernandez and Andrew Onischuk.


Bugs: AMBARI-17419
https://issues.apache.org/jira/browse/AMBARI-17419


Repository: ambari


Description
---

Trying do disable auto-start for ambari-server by executing update-rc.d 
ambari-server disable is failing with update-rc.d: error: ambari-server 
Default-Start contains no runlevels, aborting.

Added LSB to ambari-server and amabri-agent to define the default start and 
stop levels


Diffs
-

  ambari-agent/etc/init.d/ambari-agent b2c3109 
  ambari-server/sbin/ambari-server 72d94ed 

Diff: https://reviews.apache.org/r/49188/diff/


Testing
---


Thanks,

Sebastian Toader

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Akhil PB]

> On June 22, 2016, 10:42 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js,
> >  line 45
> > 
> >
> > Where is isNotOperator used?

I guess its not used, just defined thinking that it might be useful in future.


> On June 22, 2016, 10:42 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js, line 
> > 290
> > 
> >
> > Where is the values of store passed?

Intended to pass store to getNodeLabels api in adapter. But it is not used 
inside this api. I guess i can remove it.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139046
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Akhil PB]

> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js,
> >  line 25
> > 
> >
> > Trailing space must be removed.

Will remove the spaces.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> 

Re: Review Request 49179: AMBARI-17418. Fix for LLAP calculation to happen on invocation by Blueprints and HIVE SERVER INTERACTIVE is ON (1st invocation to Stack Advisor). Also, reverts AMBARI-17283.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49179/#review139346
---


Ship it!




Ship It!

- Sumit Mohanty


On June 24, 2016, 6:14 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49179/
> ---
> 
> (Updated June 24, 2016, 6:14 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17418
> https://issues.apache.org/jira/browse/AMBARI-17418
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-17418. Fix for LLAP calculation to happen on invocation by Blueprints 
> and HIVE SERVER INTERACTIVE is ON (1st invocation to Stack Advisor).
> 
> - LLAP configs will be calulated for when Stack Advisor calls is made by 
> Blueprints where services["changed-configurations"] is empty.
> - This is required when SA call is made by Blueprints and Hive Server 
> Interactive (HSI) is ON, the LLAP calculations should happen. We detect that 
> it is the BP call by checking services["changed-configurations"]  being empty.
> 
> 
> - Also reverts AMBARI-17283. Display LLAP calculated configs as 'Labels' 
> (non-editable) on 'Hive Server Interactive' Panel and Textboxes (editable) in 
> HIVE Advanced section.
>   - This is causing a parity issue in terms of what values gets shown up in 
> Advanced section (when user changes it) and what the *_copy   configs shows 
> it in HSI panel, if user decides to discrd the value suggested by SA.
>   - It is safe right now to revert this patch and let user change LLAP 
> configs from HSI panel itself, as there will be only one point on display to 
> know the current value and change it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  c2e1c0a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  a0076b3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json
>  81277a8 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 6b1d631 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> e4fad77 
> 
> Diff: https://reviews.apache.org/r/49179/diff/
> 
> 
> Testing
> ---
> 
> - Fixed Python UT's
> - Added Python Ut for checking when services['changed-configurations'] is 
> passed-in as empty.
> - Pyython UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 49179: AMBARI-17418. Fix for LLAP calculation to happen on invocation by Blueprints and HIVE SERVER INTERACTIVE is ON (1st invocation to Stack Advisor). Also, reverts AMBARI-17283.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49179/
---

(Updated June 24, 2016, 6:14 a.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

- Added theme.json as part of revert for AMBARI-17283.


Bugs: AMBARI-17418
https://issues.apache.org/jira/browse/AMBARI-17418


Repository: ambari


Description
---

AMBARI-17418. Fix for LLAP calculation to happen on invocation by Blueprints 
and HIVE SERVER INTERACTIVE is ON (1st invocation to Stack Advisor).

- LLAP configs will be calulated for when Stack Advisor calls is made by 
Blueprints where services["changed-configurations"] is empty.
- This is required when SA call is made by Blueprints and Hive Server 
Interactive (HSI) is ON, the LLAP calculations should happen. We detect that it 
is the BP call by checking services["changed-configurations"]  being empty.


- Also reverts AMBARI-17283. Display LLAP calculated configs as 'Labels' 
(non-editable) on 'Hive Server Interactive' Panel and Textboxes (editable) in 
HIVE Advanced section.
  - This is causing a parity issue in terms of what values gets shown up in 
Advanced section (when user changes it) and what the *_copy   configs shows it 
in HSI panel, if user decides to discrd the value suggested by SA.
  - It is safe right now to revert this patch and let user change LLAP configs 
from HSI panel itself, as there will be only one point on display to know the 
current value and change it.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 c2e1c0a 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 a0076b3 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json 
81277a8 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
6b1d631 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py e4fad77 

Diff: https://reviews.apache.org/r/49179/diff/


Testing
---

- Fixed Python UT's
- Added Python Ut for checking when services['changed-configurations'] is 
passed-in as empty.
- Pyython UT passes.


Thanks,

Swapan Shridhar