Re: Review Request 49222: AMBARI-17436: Additional Ambari change for Falcon

2016-06-25 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49222/#review139481
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 25, 2016, 1:27 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49222/
> ---
> 
> (Updated June 25, 2016, 1:27 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17436
> https://issues.apache.org/jira/browse/AMBARI-17436
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Description
> Add one new property to oozie-site.xml
> change permissions for the extension folders
> change the hive location from /apps/data-mirroring to 
> extensions-dir/mirroring/
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  6cb4089 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/oozie-site.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49222/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 49222: AMBARI-17436: Additional Ambari change for Falcon

2016-06-25 Thread Venkat Ranganathan 


> On June 25, 2016, 8:03 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py,
> >  line 149
> > 
> >
> > Is falcon now creating this folder?

We no longer use /apps/data-mirroring.   Instead we use 
/mirroring as the directory


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49222/#review139471
---


On June 24, 2016, 6:27 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49222/
> ---
> 
> (Updated June 24, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17436
> https://issues.apache.org/jira/browse/AMBARI-17436
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Description
> Add one new property to oozie-site.xml
> change permissions for the extension folders
> change the hive location from /apps/data-mirroring to 
> extensions-dir/mirroring/
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  6cb4089 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/oozie-site.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49222/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Review Request 49235: AMBARI-17390: Need to create field "text" in history collection

2016-06-25 Thread Don Bosco Durai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49235/
---

Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Miklos Gergely, 
Oliver Szabo, and Sumit Mohanty.


Bugs: AMBARI-17390
https://issues.apache.org/jira/browse/AMBARI-17390


Repository: ambari


Description
---

Added additional field called "text.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/configsets/history/conf/managed-schema
 fed5cd9 

Diff: https://reviews.apache.org/r/49235/diff/


Testing
---

Tested creating 3 node hadoop cluster


Thanks,

Don Bosco Durai

Re: Review Request 49222: AMBARI-17436: Additional Ambari change for Falcon

2016-06-25 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49222/#review139471
---




ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 


Is falcon now creating this folder?


- Alejandro Fernandez


On June 25, 2016, 1:27 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49222/
> ---
> 
> (Updated June 25, 2016, 1:27 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17436
> https://issues.apache.org/jira/browse/AMBARI-17436
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Description
> Add one new property to oozie-site.xml
> change permissions for the extension folders
> change the hive location from /apps/data-mirroring to 
> extensions-dir/mirroring/
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  6cb4089 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/oozie-site.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49222/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-06-25 Thread Masahiro Tanaka 


> On June 26, 2016, 1:56 a.m., Jonathan Hurley wrote:
> > ambari-agent/conf/unix/ambari-agent.ini, line 40
> > 
> >
> > This is still not supportable as it's based off of a specific alert 
> > name. Also, it's on a per-agent basis where it should be on a 
> > per-definition basis. 
> > 
> > What we should be doing for this is extending the Alert Definition for 
> > type PORT to include this optional information.

Okay, so I'll entend alerts.json (adding an attribute to specify some command) 
which is in ZOOKEEPER like below:
```
(snip)
"ZOOKEEPER_SERVER": [
  {
"name": "zookeeper_server_process",
"label": "ZooKeeper Server Process",
"description": "This host-level alert is triggered if the ZooKeeper 
server process cannot be determined to be up and listening on the network.",
"interval": 1,
"scope": "ANY",
"source": {
  "type": "PORT",
  "uri": "{{zoo.cfg/clientPort}}",
  "default_port": 2181,
  "socket_command": "ruok",# insert this line
  "reporting": {
  
(snip)
```
and update some other related codes.Thanks for suggestion.


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/#review139466
---


On June 25, 2016, 1:54 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48972/
> ---
> 
> (Updated June 25, 2016, 1:54 p.m.)
> 
> 
> Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17253
> https://issues.apache.org/jira/browse/AMBARI-17253
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are too many WARNING in ZooKeeper log.
> ```
> 2016-06-15 21:02:15,405 - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of 
> stream exception
> EndOfStreamException: Unable to read additional data from client sessionid 
> 0x0, likely client has closed socket
> at 
> org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228)
> at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208)
> at java.lang.Thread.run(Thread.java:745)
> ```
> 
> It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port 
> to do monitoring.
> We should use 'ruok' to monitor zookeepers.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 914e09a 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0 
>   ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 
>   ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py 
> 1202c81 
>   ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c 
> 
> Diff: https://reviews.apache.org/r/48972/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-06-25 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/#review139466
---




ambari-agent/conf/unix/ambari-agent.ini (line 40)


This is still not supportable as it's based off of a specific alert name. 
Also, it's on a per-agent basis where it should be on a per-definition basis. 

What we should be doing for this is extending the Alert Definition for type 
PORT to include this optional information.


- Jonathan Hurley


On June 25, 2016, 9:54 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48972/
> ---
> 
> (Updated June 25, 2016, 9:54 a.m.)
> 
> 
> Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17253
> https://issues.apache.org/jira/browse/AMBARI-17253
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are too many WARNING in ZooKeeper log.
> ```
> 2016-06-15 21:02:15,405 - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of 
> stream exception
> EndOfStreamException: Unable to read additional data from client sessionid 
> 0x0, likely client has closed socket
> at 
> org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228)
> at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208)
> at java.lang.Thread.run(Thread.java:745)
> ```
> 
> It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port 
> to do monitoring.
> We should use 'ruok' to monitor zookeepers.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 914e09a 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0 
>   ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 
>   ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py 
> 1202c81 
>   ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c 
> 
> Diff: https://reviews.apache.org/r/48972/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 49036: Allow https prtotocol for Log Search

2016-06-25 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49036/
---

(Updated June 26, 2016, 12:11 a.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

adding unit test changes


Bugs: AMBARI-17348
https://issues.apache.org/jira/browse/AMBARI-17348


Repository: ambari


Description
---

Add a property to choose whether or not the Log Search UI should run using 
https.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 171ea8c 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 376dfee 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 993c532 
  ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 6c687b9 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 38946f6 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 a5eebc2 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
 26a303c 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
 e0d42d3 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
 155ff04 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 23a9c09 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
 2993190 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
 3f5db30 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2
 aba06c6 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
 7b0aed3 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-solr-env.sh.j2
 2b17e63 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
 fc71dfc 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
d8b24ea 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 45bded1 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 848be40 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 2d4b7cd 
  ambari-web/app/data/HDP2/site_properties.js e1adbb9 

Diff: https://reviews.apache.org/r/49036/diff/


Testing
---

Tested on local cluster, works fine with every combination of with/without SSL 
Solr connect, and http/https protocol for Log Search UI.

ambari-server:
OK
--
Total run:1072
Total errors:0
Total failures:0


Thanks,

Miklos Gergely

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-06-25 Thread Masahiro Tanaka 


> On June 25, 2016, 10:29 p.m., Nate Cole wrote:
> > Latest patch still seems like forced solution.  Why not just allow the 
> > alert definition to provide "data" attribute (or whatever) in json that 
> > port_alert can use?

Thanks for reviewing. I've tried to chagne the code as you said, but that 
requires to change the Ambari metadata DB schema.
It seemed exaggerated to me, but the fact is remained that my latest patch 
isn't a simple solution.

Which one do you (or community) prefer? I'll try to follw the idea.


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/#review139457
---


On June 25, 2016, 1:54 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48972/
> ---
> 
> (Updated June 25, 2016, 1:54 p.m.)
> 
> 
> Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17253
> https://issues.apache.org/jira/browse/AMBARI-17253
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are too many WARNING in ZooKeeper log.
> ```
> 2016-06-15 21:02:15,405 - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of 
> stream exception
> EndOfStreamException: Unable to read additional data from client sessionid 
> 0x0, likely client has closed socket
> at 
> org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228)
> at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208)
> at java.lang.Thread.run(Thread.java:745)
> ```
> 
> It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port 
> to do monitoring.
> We should use 'ruok' to monitor zookeepers.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 914e09a 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0 
>   ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 
>   ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py 
> 1202c81 
>   ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c 
> 
> Diff: https://reviews.apache.org/r/48972/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

2016-06-25 Thread Sebastian Toader 


> On June 24, 2016, 8:04 p.m., Alejandro Fernandez wrote:
> > ambari-agent/etc/init.d/ambari-agent, line 22
> > 
> >
> > These are only code comments, what's the fix?

Newer linux distributions use systemd for managing services. systemd supports 
the  '/etc/init.d' scripts as well via 'insserv' but that requires this LSB 
section to be added to the start script of the service.

Without this when someone executes 'update-rc.d ambari-server disable' to 
remove ambari to be restarted in case the host is rebooted the user will get an 
error: 'update-rc.d: error: ambari-server Default-Start contains no runlevels, 
aborting.' 

This is the format how Linux Standard Base has to be specified.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49188/#review139390
---


On June 24, 2016, 9:56 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49188/
> ---
> 
> (Updated June 24, 2016, 9:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-17419
> https://issues.apache.org/jira/browse/AMBARI-17419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Trying do disable auto-start for ambari-server by executing update-rc.d 
> ambari-server disable is failing with update-rc.d: error: ambari-server 
> Default-Start contains no runlevels, aborting.
> 
> Added LSB to ambari-server and amabri-agent to define the default start and 
> stop levels
> 
> 
> Diffs
> -
> 
>   ambari-agent/etc/init.d/ambari-agent b2c3109 
>   ambari-server/sbin/ambari-server 72d94ed 
> 
> Diff: https://reviews.apache.org/r/49188/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-06-25 Thread Masahiro Tanaka 


> On June 21, 2016, 3:05 p.m., Jonathan Hurley wrote:
> > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines 
> > 133-135
> > 
> >
> > We don't hardcode specific workarounds into the alerts framework. It's 
> > not maintainable.
> 
> Masahiro Tanaka wrote:
> Thank you for reviewing Jonathan! I'll update the patch to respond to 
> your comment.

I adde a new property `port_alert_socket_commands` in `ambari-agent.ini` to 
specify the workaround and use it in `port_alert.py`. Could you please check it?


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/#review138843
---


On June 25, 2016, 1:54 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48972/
> ---
> 
> (Updated June 25, 2016, 1:54 p.m.)
> 
> 
> Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17253
> https://issues.apache.org/jira/browse/AMBARI-17253
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are too many WARNING in ZooKeeper log.
> ```
> 2016-06-15 21:02:15,405 - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of 
> stream exception
> EndOfStreamException: Unable to read additional data from client sessionid 
> 0x0, likely client has closed socket
> at 
> org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228)
> at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208)
> at java.lang.Thread.run(Thread.java:745)
> ```
> 
> It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port 
> to do monitoring.
> We should use 'ruok' to monitor zookeepers.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 914e09a 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0 
>   ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 
>   ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py 
> 1202c81 
>   ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c 
> 
> Diff: https://reviews.apache.org/r/48972/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-06-25 Thread Masahiro Tanaka 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/
---

(Updated June 25, 2016, 1:54 p.m.)


Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole.


Changes
---

Update the patch


Bugs: AMBARI-17253
https://issues.apache.org/jira/browse/AMBARI-17253


Repository: ambari


Description
---

There are too many WARNING in ZooKeeper log.
```
2016-06-15 21:02:15,405 - WARN  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of 
stream exception
EndOfStreamException: Unable to read additional data from client sessionid 0x0, 
likely client has closed socket
at 
org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228)
at 
org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208)
at java.lang.Thread.run(Thread.java:745)
```

It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port to 
do monitoring.
We should use 'ruok' to monitor zookeepers.


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 914e09a 
  ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0 
  ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 
  ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py 
1202c81 
  ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c 

Diff: https://reviews.apache.org/r/48972/diff/


Testing
---

mvn clean test

```
+1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
This message is automatically generated.
```


Thanks,

Masahiro Tanaka