date:20160630


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49455/#review140277
---




ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 (line 632)


Can we use reflection to look up the package name instead of hardcoding it?


- Alejandro Fernandez


On June 30, 2016, 4:15 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49455/
> ---
> 
> (Updated June 30, 2016, 4:15 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Sumit Mohanty, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-17505
> https://issues.apache.org/jira/browse/AMBARI-17505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> During startup the ambari server scasns the classpath for finding components 
> to be bound in the IoC context.
> When binding upgrade check implementations the full ambari package is scanned 
> that leads to prolonged startup time.
> 
> Solution:
> As upgrade check implementations reside in a dedicated package, the scanner 
> is modified to lookup them in this very package.
> (on the local env this shortens the startup time by ~25 seconds)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  e0bda13 
> 
> Diff: https://reviews.apache.org/r/49455/diff/
> 
> 
> Testing
> ---
> 
> Unit tests running.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack



> On June 30, 2016, 9:55 p.m., Jayush Luniya wrote:
> > Can you add more details in the description on how this logic will work? I 
> > dont have much insights into LogSearch. 
> > 
> > Instead of creating HadoopServiceConfig.json.j2 can we not add a 
> > service_name property in the service templates? Example 
> > ambari/ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2
> >  could have service_name : "ACCUMULO" so that the list of templates can be 
> > filtered based on service_names in the stack definition.
> > 
> > Long term we should definitely push this down to the service-level. We wont 
> > be able to support logsearch for custom services.
> 
> Oliver Szabo wrote:
> we will push down to services, with logsearch.json in all services, we 
> already designed that how we will do, but that will be a much bigger change

HadoopServiceConfig.json is for logsearch portal UI itself, the input configs 
are for logfeeder. (thas why the mapping is not there)

about our long term solution:

we will have a logsearch.json, same as like kerberos.json, and we will do 
exactly that you described with service name mappings, templates etc. we will 
send the content with commandJsons (only with logsearch/logfeeder role)
example content:
"service": "ACCUMULO",
"service_name": "Accumulo",
"logs" : { ... }.
...
"template" : {
   // input template with configuration references like: ${log.dir}
}


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49429/#review140243
---


On June 30, 2016, 11:48 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49429/
> ---
> 
> (Updated June 30, 2016, 11:48 a.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Jayush Luniya, Oliver Szabo, 
> Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17492
> https://issues.apache.org/jira/browse/AMBARI-17492
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster with HDF stack should show only HDF services, HDP cluster should not 
> show NiFi
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 958232e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  bdb5fb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  8bb6225 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  fe7e757 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  a89b3d6 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  bfab139 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> 48e071d 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733 
> 
> Diff: https://reviews.apache.org/r/49429/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> ambari-server:
> OK
> --
> Total run:1085
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack



> On June 30, 2016, 9:55 p.m., Jayush Luniya wrote:
> > Can you add more details in the description on how this logic will work? I 
> > dont have much insights into LogSearch. 
> > 
> > Instead of creating HadoopServiceConfig.json.j2 can we not add a 
> > service_name property in the service templates? Example 
> > ambari/ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2
> >  could have service_name : "ACCUMULO" so that the list of templates can be 
> > filtered based on service_names in the stack definition.
> > 
> > Long term we should definitely push this down to the service-level. We wont 
> > be able to support logsearch for custom services.

we will push down to services, with logsearch.json in all services, we already 
designed that how we will do, but that will be a much bigger change


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49429/#review140243
---


On June 30, 2016, 11:48 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49429/
> ---
> 
> (Updated June 30, 2016, 11:48 a.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Jayush Luniya, Oliver Szabo, 
> Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17492
> https://issues.apache.org/jira/browse/AMBARI-17492
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster with HDF stack should show only HDF services, HDP cluster should not 
> show NiFi
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 958232e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  bdb5fb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  8bb6225 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  fe7e757 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  a89b3d6 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  bfab139 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> 48e071d 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733 
> 
> Diff: https://reviews.apache.org/r/49429/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> ambari-server:
> OK
> --
> Total run:1085
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 49476: Display LLAP calculated configs as 'Labels' (non-editable) on 'Hive Server Interactive' Panel and Textboxes (editable) in HIVE Advanced section.

2016-06-30 Thread Jaimin Jetly


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49476/
---

Review request for Ambari, Andriy Babiichuk, Zhe (Joe) Wang, Richard Zang, 
Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-17283
https://issues.apache.org/jira/browse/AMBARI-17283


Repository: ambari


Description
---

Display LLAP calculated configs as 'Labels' (non-editable) on 'Hive Server 
Interactive' Panel and Textboxes (editable) in HIVE Advanced section.

Following configs need to be shown as Labels on Hive Server Interactive Panel.
hive-interactive-site/hive.llap.daemon.yarn.container.mb
hive-interactive-site/hive.llap.daemon.num.executors
hive-interactive-site/hive.llap.io.memory.size
hive-interactive-env/num_llap_nodes
User will have the option to edit them on HIVE Advanced page.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
 931d58b 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json 
c6cb873 
  ambari-web/app/controllers/main/service/info/configs.js bc91b72 
  ambari-web/app/mappers/configs/themes_mapper.js a2bfd99 
  ambari-web/app/models/configs/objects/service_config_property.js 73960b3 
  ambari-web/app/utils/config.js a9cb5e9 
  ambari-web/app/views/common/configs/widgets/config_widget_view.js 86ae3f3 
  ambari-web/test/controllers/main/service/info/config_test.js 1c8cbfd 

Diff: https://reviews.apache.org/r/49476/diff/


Testing
---

Verified on deployed cluster that the patch resolves the issue.
Verified that all ambari-web unit tests passes with the patch:
28937 tests complete (29 seconds)
154 tests pending


Thanks,

Jaimin Jetly

Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack

2016-06-30 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49429/#review140243
---



Can you add more details in the description on how this logic will work? I dont 
have much insights into LogSearch. 

Instead of creating HadoopServiceConfig.json.j2 can we not add a service_name 
property in the service templates? Example 
ambari/ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2
 could have service_name : "ACCUMULO" so that the list of templates can be 
filtered based on service_names in the stack definition.

Long term we should definitely push this down to the service-level. We wont be 
able to support logsearch for custom services.

- Jayush Luniya


On June 30, 2016, 11:48 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49429/
> ---
> 
> (Updated June 30, 2016, 11:48 a.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Jayush Luniya, Oliver Szabo, 
> Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17492
> https://issues.apache.org/jira/browse/AMBARI-17492
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster with HDF stack should show only HDF services, HDP cluster should not 
> show NiFi
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 958232e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  bdb5fb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  8bb6225 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  fe7e757 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  a89b3d6 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  bfab139 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> 48e071d 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733 
> 
> Diff: https://reviews.apache.org/r/49429/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> ambari-server:
> OK
> --
> Total run:1085
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 49455: Optimized classpath scannig for upgrade check impelemtations

2016-06-30 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49455/#review140240
---




ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 (line 632)


Make "org.apache.ambari.server.checks" string constant.


- Sebastian Toader


On June 30, 2016, 6:15 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49455/
> ---
> 
> (Updated June 30, 2016, 6:15 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Sumit Mohanty, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-17505
> https://issues.apache.org/jira/browse/AMBARI-17505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> During startup the ambari server scasns the classpath for finding components 
> to be bound in the IoC context.
> When binding upgrade check implementations the full ambari package is scanned 
> that leads to prolonged startup time.
> 
> Solution:
> As upgrade check implementations reside in a dedicated package, the scanner 
> is modified to lookup them in this very package.
> (on the local env this shortens the startup time by ~25 seconds)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  e0bda13 
> 
> Diff: https://reviews.apache.org/r/49455/diff/
> 
> 
> Testing
> ---
> 
> Unit tests running.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Review Request 49475: Hosts filter works incorrect with Flume

2016-06-30 Thread Richard Zang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49475/
---

Review request for Ambari and Zhe (Joe) Wang.


Bugs: AMBARI-17511
https://issues.apache.org/jira/browse/AMBARI-17511


Repository: ambari


Description
---

Add separate map for services.


Diffs
-

  ambari-web/app/views/main/host/combo_search_box.js 29a35ef 

Diff: https://reviews.apache.org/r/49475/diff/


Testing
---

Manually tested on live cluster.
 28939 tests complete (27 seconds)
  154 tests pending


Thanks,

Richard Zang

Re: Review Request 49438: Editable solrconfig.xml for Logsearch (+ atlas)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49438/
---

(Updated June 30, 2016, 9:15 p.m.)


Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Miklos 
Gergely, Robert Nettleton, and Sumit Mohanty.


Changes
---

- default log location inside jinja template too (if params not accessible from 
solr_cloud_util.py)
- fix permissions in solr config set of atlas


Bugs: AMBARI-17499
https://issues.apache.org/jira/browse/AMBARI-17499


Repository: ambari


Description
---

- we can upload the whole solr config folder on bootsrapping logsearch or 
atlas, but later we cannot really edit it
-> add abillity to reupload solrconfig.xml (but no any change in solr schema), 
but only if solrconfig.xml content is provided

add some refactoring too for solr_cloud_util:
- its not needed to generate a random number for solr_cloud_util
- its not needed to generate a tmp folder name (where ambari downloads the solr 
config)


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 038f64d 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 a34925f 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
ffa9e13 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 bfab139 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/solr-client-log4j.properties.j2
 67806d7 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 e35ea5f 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
1109e51 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 48e071d 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 65bd1d2 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 10c40f4 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py 53a854c 

Diff: https://reviews.apache.org/r/49438/diff/


Testing
---

Total run:1086
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Review Request 49474: Ambari LogSearch Integration should request logging metadata on a separate thread

2016-06-30 Thread Robert Nettleton

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49474/
---

Review request for Ambari, Jonathan Hurley, Mahadev Konar, Oliver Szabo, and
Sumit Mohanty.

Bugs: AMBARI-17510
https://issues.apache.org/jira/browse/AMBARI-17510

Repository: ambari

Description
---

This patch implements some updates to the Ambari LogSearch integration layer in
order to resolve AMBARI-17510.

The initial implementation of the LoggingSearchPropertyProvider directly made
calls to the LogSearch Server's REST endpoint, in order to obtain LogSearch
metadata, and to attach this information to the Ambari HostComponent REST
resource. Recent testing has shown that there are some deployment scenarios
(larger clusters, rolling upgrade) that demonstrate a performance problem in
the LogSearch integration code.

This patch addresses this problem by implementing the following:

1. A new, injectable service
(org.apache.ambari.server.controller.logging.LogSearchDataRetrievalService) has
been introduced into the LoggingSearchPropertyProvider. The property provider
now consults this service to obtain the required LogSearch data. This new
service is based on Jonathan Hurley's work in
org.apache.ambari.server.state.services.MetricsRetrievalService.
2. The LogSearchDataRetrievalService utilizes an internal cache to maintain a
map of the LogSearch data, which typically will not change. If the cache does
not contain this information for a given HostComponent, the retrieval service
will make the required REST call to the LogSearch service to obtain this data,
and then add this to the cache. The remote REST call now happens on a separate
thread from the Ambari REST request handler, which removes the possibility of
causing degradation on the Ambari REST endpoing.
3. The LoggingRequestHelperImpl class has been slightly updated, in order to
add 5 second connect/read timeouts on the LogSearch requests. This should
prevent any threads from hanging infinitely if the LogSearch server is slow to
respond. In a future patch, we might want to make these timeouts configurable.

Diffs
-

ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
947a9f4

ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
fe7e757

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
5ac66d8

ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java
PRE-CREATION

ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
d8c71e2

ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
ff7e7f5

ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
593f660

Diff: https://reviews.apache.org/r/49474/diff/

Testing
---

1. Ran the ambari-server "mvn clean test" suite, and all Java and Python unit
tests passed with this change applied.
2. Deployed a 3-node cluster with HDFS, Yarn, and LogSearch selected with this
patch applied. Verified that the cluster deployed successfully, and that the
"host_components" REST resource (the resource associated with this performance
problem) returns properly. Ran 6-7 separate REST clients making concurrent
requests on the "host_componets" resource in Ambari for over 40 minutes, and
verified that there is no noticeable slowdown. Verified that ambari-server
remains responsive after this test. Also verified via DEBUG-level logging that
the LogSearch remote REST requests are indeed happening on a separate thread
now.
3. Deployed a 3-node cluster with HDFS and Yarn selected (LogSearch not
selected) with this patch applied. Verified that the cluster deploys properly,
and that the Ambari REST "host_components" resource returns properly when
LogSearch is not included in the cluster.

Thanks,

Robert Nettleton

Re: Review Request 49385: Hive and Oozie db displayed incorrectly on the installer review page

2016-06-30 Thread Sangeeta Ravindran

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49385/
---

(Updated June 30, 2016, 8:57 p.m.)

Review request for Ambari, Alexandr Antonenko and Andrii Tkach.

Bugs: AMBARI-17469
https://issues.apache.org/jira/browse/AMBARI-17469

Repository: ambari

Description
---

During Hive install, in the review page, the default value of
hive_admin_database (MySQL) is concatenated to the selected database type, no
matter which database is selected. For e.g. if Existing PostgreSQL Database is
selected as the Hive database, the review page displays the following for Hive
database:

Database : MySQL (Existing PostgreSQL Database)

In case of Oozie, because there is no oozie_admin_database property, a blank is
displayed for database although an existing database was selected

Database :

This seems to be because of the logic in the method that determines the
database value to be displayed.

var dbFull = serviceConfigProperties.findProperty('name',
serviceName.toLowerCase() + '_database'),
db = serviceConfigProperties.findProperty('name',
serviceName.toLowerCase() + '_ambari_database');
return db && dbFull ? db.value + ' (' + dbFull.value + ')' : '';

The value of hive_ambari_database returns MySQL and hence in case of Hive,
MySQL always gets appended.

There is no oozie_ambari_database property defined. Hence db is undefined and
an emtpy string is returned instead of the actual database type selected.

Fix involves changing the logic to not include the value of
serviceName_ambari_database since it will not have the right value unless the
default value is selected for Hive/Oozie database.

Diffs (updated)
-

ambari-web/app/controllers/wizard/step8_controller.js 3971cf5
ambari-web/test/controllers/wizard/step8_test.js 74e042b

Diff: https://reviews.apache.org/r/49385/diff/

Testing
---

Manual testing.
Added a test case to verify the value displayed for database.
Ran mvn test

28979 tests complete (48 seconds)
154 tests pending

File Attachments (updated)

Updated Patch with review comments incorporated

https://reviews.apache.org/media/uploaded/files/2016/06/30/e5fa58fa-3940-4c82-ad92-c8070c824528__AMBARI-17469.patch

Thanks,

Sangeeta Ravindran

Re: Review Request 49467: AMBARI-17508. Remove the file existence check (run.sh) after LLAP package creation command.

2016-06-30 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49467/#review140232
---


Ship it!




Ship It!

- Sumit Mohanty


On June 30, 2016, 7:08 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49467/
> ---
> 
> (Updated June 30, 2016, 7:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17508
> https://issues.apache.org/jira/browse/AMBARI-17508
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Removed the file existence check as the code is in try-except code which 
> will anyways be caught, if non-existent.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  255396f 
> 
> Diff: https://reviews.apache.org/r/49467/diff/
> 
> 
> Testing
> ---
> 
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 49467: AMBARI-17508. Remove the file existence check (run.sh) after LLAP package creation command.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49467/#review140230
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 30, 2016, 7:08 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49467/
> ---
> 
> (Updated June 30, 2016, 7:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17508
> https://issues.apache.org/jira/browse/AMBARI-17508
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Removed the file existence check as the code is in try-except code which 
> will anyways be caught, if non-existent.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  255396f 
> 
> Diff: https://reviews.apache.org/r/49467/diff/
> 
> 
> Testing
> ---
> 
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 49437: RU/EU Install packages fails on suse


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49437/#review140213
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 30, 2016, 12:05 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49437/
> ---
> 
> (Updated June 30, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-17502
> https://issues.apache.org/jira/browse/AMBARI-17502
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> No handlers could be found for logger "root"
> 2016-06-30 10:39:21,730 - Could not install packages. Error: Execution of 
> '/usr/bin/zypper --quiet --non-interactiveverify --dry-run' returned 2. 
> Unknown option '--non-interactiveverify'
> Unknown option '--dry-run'
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 166, in actionexecute
> ret_code = self.install_packages(package_list)
>   File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 400, in install_packages
> if not verifyDependencies():
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
>  line 309, in verifyDependencies
> code, out = rmf_shell.checked_call(cmd, sudo=True)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 71, in inner
> result = function(command, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 93, in checked_call
> tries=tries, try_sleep=try_sleep)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 141, in _call_wrapper
> result = _call(command, **kwargs_copy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 294, in _call
> raise Fail(err_msg)
> Fail: Execution of '/usr/bin/zypper --quiet --non-interactiveverify 
> --dry-run' returned 2. Unknown option '--non-interactiveverify'
> Unknown option '--dry-run'
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 469, in 
> InstallPackages().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 280, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 179, in actionexecute
> raise Fail("Failed to distribute repositories/install packages")
> resource_management.core.exceptions.Fail: Failed to distribute 
> repositories/install packages
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
>  7805907 
> 
> Diff: https://reviews.apache.org/r/49437/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 49454: Atlas empty required config is present after Upgrade from 2.2.0.0 to 2.4.0.0


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49454/#review140210
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 30, 2016, 5:57 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49454/
> ---
> 
> (Updated June 30, 2016, 5:57 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17506
> https://issues.apache.org/jira/browse/AMBARI-17506
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1) Install old version (2.2.0.0) regarding description
> 2) Make ambari only upgrade
> Atlas empty required config is present after Upgrade from 2.2.0.0 to 2.4.0.0
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  1437251 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  5f3d603 
> 
> Diff: https://reviews.apache.org/r/49454/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 49454: Atlas empty required config is present after Upgrade from 2.2.0.0 to 2.4.0.0

2016-06-30 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49454/#review140206
---


Ship it!




Ship It!

- Sumit Mohanty


On June 30, 2016, 5:57 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49454/
> ---
> 
> (Updated June 30, 2016, 5:57 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17506
> https://issues.apache.org/jira/browse/AMBARI-17506
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1) Install old version (2.2.0.0) regarding description
> 2) Make ambari only upgrade
> Atlas empty required config is present after Upgrade from 2.2.0.0 to 2.4.0.0
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  1437251 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  5f3d603 
> 
> Diff: https://reviews.apache.org/r/49454/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 49454: Atlas empty required config is present after Upgrade from 2.2.0.0 to 2.4.0.0

2016-06-30 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49454/
---

(Updated Червень 30, 2016, 5:57 після полудня)


Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-17506
https://issues.apache.org/jira/browse/AMBARI-17506


Repository: ambari


Description
---

STR:
1) Install old version (2.2.0.0) regarding description
2) Make ambari only upgrade
Atlas empty required config is present after Upgrade from 2.2.0.0 to 2.4.0.0


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 1437251 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
 5f3d603 

Diff: https://reviews.apache.org/r/49454/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 48840: AMBARI-17249 Storm metrics sink should include worker host and port to metric name when metrics are coming from SystemBolt

2016-06-30 Thread Aravindan Vijayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48840/#review140197
---


Ship it!




Ship It!

- Aravindan Vijayan


On June 17, 2016, 6:23 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48840/
> ---
> 
> (Updated June 17, 2016, 6:23 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17249
> https://issues.apache.org/jira/browse/AMBARI-17249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Background: SystemBolt is reserved component for each worker which exposes 
> worker level metrics like Memory, GC, and uptime, and so on.
> 
> All SystemBolts have -1 as task id, so identifying SystemBolt components to 
> task id as same as normal components will fail. Since each worker is 
> identified by (worker host, port) pair, we can add hostname and port to 
> metric name to make metric name unique.
> 
> Since it's only for SystemBolt, instead of adding hostname and port to all of 
> metrics, we can add these to specific metrics which are coming from 
> SystemBolt.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  eb572b3 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  c4b54b4 
> 
> Diff: https://reviews.apache.org/r/48840/diff/
> 
> 
> Testing
> ---
> 
> mvn test succeed
> applied and tested manually (via 2.4 branch)
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 49328: AMBARI-17465 - Management packs should be able to install extensions


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49328/#review140196
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 30, 2016, 5:16 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49328/
> ---
> 
> (Updated June 30, 2016, 5:16 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Mahadev Konar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17465
> https://issues.apache.org/jira/browse/AMBARI-17465
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently management packs (AMBARI-14854) can only add stacks and addon 
> services. Now that AMBARI-12885 has been resolved, the management packs 
> should be able to add extensions as well.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py e868f96 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 98811f5 
> 
> Diff: https://reviews.apache.org/r/49328/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> ambari-server install-mpack 
> --mpack=/root/mpacks/hdp-ambari-mpack-1.0.0.0.tar.gz --purge -v
> ambari-server install-mpack 
> --mpack=/root/mpacks/myservice-ambari-mpack-1.0.0.0.tar.gz -v
> ambari-server install-mpack 
> --mpack=/root/mpacks/myservice2-ambari-mpack-1.0.0.0.tar.gz -v
> ambari-server install-mpack --mpack=/root/mpacks/myextension-1.0.0.0.tar.gz -v
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 49328: AMBARI-17465 - Management packs should be able to install extensions

2016-06-30 Thread Tim Thorpe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49328/
---

(Updated June 30, 2016, 5:16 p.m.)


Review request for Ambari, Jayush Luniya, Mahadev Konar, and Sumit Mohanty.


Changes
---

Added more comments to the extension functions


Bugs: AMBARI-17465
https://issues.apache.org/jira/browse/AMBARI-17465


Repository: ambari


Description
---

Currently management packs (AMBARI-14854) can only add stacks and addon 
services. Now that AMBARI-12885 has been resolved, the management packs should 
be able to add extensions as well.


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py e868f96 
  ambari-server/src/main/python/ambari_server/setupMpacks.py 98811f5 

Diff: https://reviews.apache.org/r/49328/diff/


Testing
---

Manual testing

ambari-server install-mpack 
--mpack=/root/mpacks/hdp-ambari-mpack-1.0.0.0.tar.gz --purge -v
ambari-server install-mpack 
--mpack=/root/mpacks/myservice-ambari-mpack-1.0.0.0.tar.gz -v
ambari-server install-mpack 
--mpack=/root/mpacks/myservice2-ambari-mpack-1.0.0.0.tar.gz -v
ambari-server install-mpack --mpack=/root/mpacks/myextension-1.0.0.0.tar.gz -v


Thanks,

Tim Thorpe

Re: Review Request 49455: Optimized classpath scannig for upgrade check impelemtations


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49455/
---

(Updated June 30, 2016, 4:15 p.m.)


Review request for Ambari, Daniel Gergely, Sumit Mohanty, and Sebastian Toader.


Summary (updated)
-

Optimized classpath scannig for upgrade check impelemtations


Bugs: AMBARI-17505
https://issues.apache.org/jira/browse/AMBARI-17505


Repository: ambari


Description
---

Problem:
During startup the ambari server scasns the classpath for finding components to 
be bound in the IoC context.
When binding upgrade check implementations the full ambari package is scanned 
that leads to prolonged startup time.

Solution:
As upgrade check implementations reside in a dedicated package, the scanner is 
modified to lookup them in this very package.
(on the local env this shortens the startup time by ~25 seconds)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 e0bda13 

Diff: https://reviews.apache.org/r/49455/diff/


Testing
---

Unit tests running.


Thanks,

Laszlo Puskas

Re: Review Request 49455: Optimized classpath scannig for upgrade checks impelemtation


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49455/
---

(Updated June 30, 2016, 4:12 p.m.)


Review request for Ambari, Daniel Gergely, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-17505
https://issues.apache.org/jira/browse/AMBARI-17505


Repository: ambari


Description (updated)
---

Problem:
During startup the ambari server scasns the classpath for finding components to 
be bound in the IoC context.
When binding upgrade check implementations the full ambari package is scanned 
that leads to prolonged startup time.

Solution:
As upgrade check implementations reside in a dedicated package, the scanner is 
modified to lookup them in this very package.
(on the local env this shortens the startup time by ~25 seconds)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 e0bda13 

Diff: https://reviews.apache.org/r/49455/diff/


Testing
---

Unit tests running.


Thanks,

Laszlo Puskas

Review Request 49455: Optimized classpath scannig for upgrade checks impelemtation


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49455/
---

Review request for Ambari, Sumit Mohanty and Sebastian Toader.


Bugs: AMBARI-17505
https://issues.apache.org/jira/browse/AMBARI-17505


Repository: ambari


Description
---

Problem:
During startup the ambari server scasns the classpath for finding components to 
be bound in the IoC context.
When binding upgrade check implementations the full ambari package is scanned 
that leads to prolonged startup time.

Solution:
As upgrade check implementations reside in a dedicated package, the scanner is 
modified to lookup them in this very package.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 e0bda13 

Diff: https://reviews.apache.org/r/49455/diff/


Testing
---

Unit tests running.


Thanks,

Laszlo Puskas

Re: Review Request 49452: Support Atlas in kerberized environment, submit Service Check as smokeuser. Additional patch

2016-06-30 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49452/#review140176
---


Ship it!




Ship It!

- Robert Levas


On June 30, 2016, 10:46 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49452/
> ---
> 
> (Updated June 30, 2016, 10:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-17427
> https://issues.apache.org/jira/browse/AMBARI-17427
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix comment at review https://reviews.apache.org/r/49198/
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  6b03d50 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_service_check.py 
> a8b54cb 
> 
> Diff: https://reviews.apache.org/r/49452/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 49454: Atlas empty required config is present after Upgrade from 2.2.0.0 to 2.4.0.0

2016-06-30 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49454/#review140174
---


Ship it!




Ship It!

- Dmytro Sen


On Июнь 30, 2016, 3:23 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49454/
> ---
> 
> (Updated Июнь 30, 2016, 3:23 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17506
> https://issues.apache.org/jira/browse/AMBARI-17506
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1) Install old version (2.2.0.0) regarding description
> 2) Make ambari only upgrade
> Atlas empty required config is present after Upgrade from 2.2.0.0 to 2.4.0.0
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  1437251 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  5f3d603 
> 
> Diff: https://reviews.apache.org/r/49454/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 49454: Atlas empty required config is present after Upgrade from 2.2.0.0 to 2.4.0.0

2016-06-30 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49454/
---

Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-17506
https://issues.apache.org/jira/browse/AMBARI-17506


Repository: ambari


Description
---

STR:
1) Install old version (2.2.0.0) regarding description
2) Make ambari only upgrade
Atlas empty required config is present after Upgrade from 2.2.0.0 to 2.4.0.0


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 1437251 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
 5f3d603 

Diff: https://reviews.apache.org/r/49454/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 49452: Support Atlas in kerberized environment, submit Service Check as smokeuser. Additional patch

2016-06-30 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49452/
---

Review request for Ambari, Alejandro Fernandez and Robert Levas.


Bugs: AMBARI-17427
https://issues.apache.org/jira/browse/AMBARI-17427


Repository: ambari


Description
---

Fix comment at review https://reviews.apache.org/r/49198/


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
 6b03d50 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_service_check.py a8b54cb 

Diff: https://reviews.apache.org/r/49452/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

2016-06-30 Thread Anita Jebaraj



> On June 30, 2016, 8:23 a.m., Alexandr Antonenko wrote:
> > ambari-web/app/views/main/host/details/host_component_view.js, line 196
> > 
> >
> > this will not work out, as there is no hive-env, only "hive-site". You 
> > have to do a request to get this config

Hi, yes hive-env will not be available, so I did a getConfigByTags() at the 
load of the host summary page, so that the value for hive-env will be obtained.


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49287/#review140121
---


On June 27, 2016, 11:20 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49287/
> ---
> 
> (Updated June 27, 2016, 11:20 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-17358
> https://issues.apache.org/jira/browse/AMBARI-17358
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> When user switches from MySQL to Existing database in hive and stop the MySQL 
> Server
> 
> 1) Ambari UI > Hive > Service Actions > Stop becomes unavailable, so Hive 
> can't be stopped anymore
> 
> 2) Hive status is showing up as red Triangle indicating there is a problem 
> with Hive
> 
> Providing an option to delete MySQL server when an existing database is used 
> in Hive would help in overcoming the issues.
> 
> 
> Solution:
> An option is included to delete MySQL Server, the delete will be enabled only 
> when Hive is using an existing(or external) database and the MySQL server is 
> not started.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/stack_service_component.js a350f15 
>   ambari-web/app/routes/main.js 4545f54 
>   ambari-web/app/views/main/host/details/host_component_view.js 910c71f 
>   ambari-web/test/models/stack_service_component_test.js 7e971ce 
>   ambari-web/test/views/main/host/details/host_component_view_test.js 648f0f6 
> 
> Diff: https://reviews.apache.org/r/49287/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 
> 28974 tests complete (43 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 49450: Port changes of AMBARI-17421 to hive-jdbc view

2016-06-30 Thread Ashwin Rajeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49450/#review140166
---


Ship it!




Ship It!

- Ashwin Rajeev


On June 30, 2016, 1:57 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49450/
> ---
> 
> (Updated June 30, 2016, 1:57 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17501
> https://issues.apache.org/jira/browse/AMBARI-17501
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ported and resolved conflicts. also added timeout of 1 sec before fetching 
> the status of job in loop
> 
> 
> Diffs
> -
> 
>   contrib/views/hive-next/pom.xml d108095 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java
>  083423a 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java
>  53b91db 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/viewJobs/JobImpl.java
>  17d585f 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/TableDataReader.java
>  d7dba85 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/TableInput.java
>  9c27b24 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadFromHdfsInput.java
>  8214579 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  e0bc083 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/DataParser.java
>  0aec39f 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/IParser.java
>  dc0c552 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseOptions.java
>  53af85a 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java
>  2623c4c 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/RowIterator.java
>  747e7ff 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVIterator.java
>  c4abb99 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVParser.java
>  daff342 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/commonscsv/CSVIterator.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/commonscsv/CSVParser.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/opencsv/OpenCSVIterator.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/opencsv/OpenCSVParser.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/InsertFromQueryInput.java
>  22dec67 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java
>  a9bc2b9 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java
>  2b91d7b 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  6fa6cfd 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  a00f0b4 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
> f0c9a4c 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  5e3a519 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/CSVParserTest.java
>  fab1328 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserCSVTest.java
>  6b57228 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserJSONTest.java
>  1ea7ec2 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserXMLTest.java
>  2faf4e9 
>   
>

Re: Review Request 39599: [Preview] Express Upgrade: Hbase restart fails due to JAVA_HOME issues

2016-06-30 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39599/#review140162
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 23, 2015, 6:32 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39599/
> ---
> 
> (Updated Oct. 23, 2015, 6:32 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmytro Grinenko.
> 
> 
> Bugs: AMBARI-13547
> https://issues.apache.org/jira/browse/AMBARI-13547
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Looks like configure() was never called for HBASE after hdp-select. 
> As a result, hbase-env is missing for hbase at all after EU 2.1->2.3
> 
> ll /usr/hdp/2.3.0.0-2557/hbase/conf/
> total 0
> 
> I guessed it's because new-style start() with upgrade_type arg is not 
> implemented yet in HBASE script (I saw relevant legacy and new-style logic at 
> script.py).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  74cfde6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  56dde25 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  44feb0c 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  edcf041 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
>  8f4a6d0 
> 
> Diff: https://reviews.apache.org/r/39599/diff/
> 
> 
> Testing
> ---
> 
> But current patch does not solve an issue. Maybe I'm missing something and 
> it's a known issue?
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 49449: AMBARI-17415 Ambari configuration for ranger-tagsync needs to support property for atlas keystore filename

2016-06-30 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49449/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Srimanth Gunturi, 
and Velmurugan Periasamy.


Bugs: AMBARI-17415
https://issues.apache.org/jira/browse/AMBARI-17415


Repository: ambari


Description
---

Ranger-Tagsync configuration with Ambari needs to:
1. Provide reasonable defaults for Atlas Endpoint (from Atlas URL) and 
Atlas-source-download-interval (6) when Atlasrest is selected as tag-source.
2. Support properties ranger.tagsync.source.atlasrest.username (default: admin) 
and ranger.tagsync.source.atlasrest.keystore.filename(default: 
/usr/hdp/current/ranger-tagsync/conf/atlasuser.jceks)
3. stack validations for storm and kafka while enabling ranger plugin in 
non-kerberos env.


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
 7985f58 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
38586e4 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
6a3df08 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
88c1915 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml
 c3fe932 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
9426571 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 08b9554 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 62d926e 

Diff: https://reviews.apache.org/r/49449/diff/


Testing
---

Tested Ranger on centos 6


Thanks,

Mugdha Varadkar

Review Request 49450: Port changes of AMBARI-17421 to hive-jdbc view


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49450/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-17501
https://issues.apache.org/jira/browse/AMBARI-17501


Repository: ambari


Description
---

ported and resolved conflicts. also added timeout of 1 sec before fetching the 
status of job in loop


Diffs
-

  contrib/views/hive-next/pom.xml d108095 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java
 083423a 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java
 53b91db 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/viewJobs/JobImpl.java
 17d585f 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java
 PRE-CREATION 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/TableDataReader.java
 d7dba85 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/TableInput.java
 9c27b24 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadFromHdfsInput.java
 8214579 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
 e0bc083 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/DataParser.java
 0aec39f 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/IParser.java
 dc0c552 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseOptions.java
 53af85a 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java
 2623c4c 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/RowIterator.java
 747e7ff 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVIterator.java
 c4abb99 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVParser.java
 daff342 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/commonscsv/CSVIterator.java
 PRE-CREATION 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/commonscsv/CSVParser.java
 PRE-CREATION 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/opencsv/OpenCSVIterator.java
 PRE-CREATION 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/opencsv/OpenCSVParser.java
 PRE-CREATION 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/InsertFromQueryInput.java
 22dec67 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java
 a9bc2b9 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java
 PRE-CREATION 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java
 2b91d7b 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 6fa6cfd 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js 
a00f0b4 
  contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
f0c9a4c 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
 5e3a519 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/CSVParserTest.java
 fab1328 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserCSVTest.java
 6b57228 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserJSONTest.java
 1ea7ec2 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserXMLTest.java
 2faf4e9 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/OpenCSVParserTest.java
 PRE-CREATION 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/OpenCSVTest.java
 PRE-CREATION 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java
 f549206 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/TableDataReaderTest.java
 d65cdb0 

Diff: https://reviews.apache.org/r/49450/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Re: Review Request 49438: Editable solrconfig.xml for Logsearch (+ atlas)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49438/
---

(Updated June 30, 2016, 1:50 p.m.)


Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Miklos 
Gergely, Robert Nettleton, and Sumit Mohanty.


Changes
---

- add configuration dependencies too


Bugs: AMBARI-17499
https://issues.apache.org/jira/browse/AMBARI-17499


Repository: ambari


Description
---

- we can upload the whole solr config folder on bootsrapping logsearch or 
atlas, but later we cannot really edit it
-> add abillity to reupload solrconfig.xml (but no any change in solr schema), 
but only if solrconfig.xml content is provided

add some refactoring too for solr_cloud_util:
- its not needed to generate a random number for solr_cloud_util
- its not needed to generate a tmp folder name (where ambari downloads the solr 
config)


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 038f64d 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 a34925f 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
ffa9e13 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 bfab139 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 e35ea5f 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
1109e51 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 48e071d 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 65bd1d2 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 10c40f4 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py 53a854c 

Diff: https://reviews.apache.org/r/49438/diff/


Testing
---

Total run:1086
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 49328: AMBARI-17465 - Management packs should be able to install extensions

2016-06-30 Thread Tim Thorpe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49328/
---

(Updated June 30, 2016, 1:38 p.m.)


Review request for Ambari, Jayush Luniya, Mahadev Konar, and Sumit Mohanty.


Changes
---

Changed testing to include regression tests from original mpacks JIRA 
(AMBARI-15663)


Bugs: AMBARI-17465
https://issues.apache.org/jira/browse/AMBARI-17465


Repository: ambari


Description
---

Currently management packs (AMBARI-14854) can only add stacks and addon 
services. Now that AMBARI-12885 has been resolved, the management packs should 
be able to add extensions as well.


Diffs
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py e868f96 
  ambari-server/src/main/python/ambari_server/setupMpacks.py 98811f5 

Diff: https://reviews.apache.org/r/49328/diff/


Testing (updated)
---

Manual testing

ambari-server install-mpack 
--mpack=/root/mpacks/hdp-ambari-mpack-1.0.0.0.tar.gz --purge -v
ambari-server install-mpack 
--mpack=/root/mpacks/myservice-ambari-mpack-1.0.0.0.tar.gz -v
ambari-server install-mpack 
--mpack=/root/mpacks/myservice2-ambari-mpack-1.0.0.0.tar.gz -v
ambari-server install-mpack --mpack=/root/mpacks/myextension-1.0.0.0.tar.gz -v


Thanks,

Tim Thorpe

Re: Review Request 49438: Editable solrconfig.xml for Logsearch (+ atlas)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49438/
---

(Updated June 30, 2016, 1:11 p.m.)


Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Miklos 
Gergely, Robert Nettleton, and Sumit Mohanty.


Changes
---

- rebase: edit conflicts


Bugs: AMBARI-17499
https://issues.apache.org/jira/browse/AMBARI-17499


Repository: ambari


Description
---

- we can upload the whole solr config folder on bootsrapping logsearch or 
atlas, but later we cannot really edit it
-> add abillity to reupload solrconfig.xml (but no any change in solr schema), 
but only if solrconfig.xml content is provided

add some refactoring too for solr_cloud_util:
- its not needed to generate a random number for solr_cloud_util
- its not needed to generate a tmp folder name (where ambari downloads the solr 
config)


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 038f64d 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 a34925f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 bfab139 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 e35ea5f 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
1109e51 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 48e071d 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 65bd1d2 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 10c40f4 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py 53a854c 

Diff: https://reviews.apache.org/r/49438/diff/


Testing
---

Total run:1086
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 49383: Add a validation of required services during a blueprint deployment

2016-06-30 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49383/#review140154
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
 (line 134)


I think this can be made ```final``` as it's being initialised from 
constructor. Also if this map shouldn't be changed once initialised let's make 
it immutable (guava's ImmutableMap provides easy functions for easily create 
and populate immutable maps).


- Sebastian Toader


On June 29, 2016, 6:14 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49383/
> ---
> 
> (Updated June 29, 2016, 6:14 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Sebastian Toader, and Vitalyi 
> Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a validation of required services during a blueprint deployment.  
> Currently a blueprint deployment allows to install YARN without HDFS.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  16f75ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  de5e2b3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  b85d454 
> 
> Diff: https://reviews.apache.org/r/49383/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 49437: RU/EU Install packages fails on suse

2016-06-30 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49437/#review140152
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On June 30, 2016, 3:05 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49437/
> ---
> 
> (Updated June 30, 2016, 3:05 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-17502
> https://issues.apache.org/jira/browse/AMBARI-17502
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> No handlers could be found for logger "root"
> 2016-06-30 10:39:21,730 - Could not install packages. Error: Execution of 
> '/usr/bin/zypper --quiet --non-interactiveverify --dry-run' returned 2. 
> Unknown option '--non-interactiveverify'
> Unknown option '--dry-run'
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 166, in actionexecute
> ret_code = self.install_packages(package_list)
>   File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 400, in install_packages
> if not verifyDependencies():
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
>  line 309, in verifyDependencies
> code, out = rmf_shell.checked_call(cmd, sudo=True)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 71, in inner
> result = function(command, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 93, in checked_call
> tries=tries, try_sleep=try_sleep)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 141, in _call_wrapper
> result = _call(command, **kwargs_copy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 294, in _call
> raise Fail(err_msg)
> Fail: Execution of '/usr/bin/zypper --quiet --non-interactiveverify 
> --dry-run' returned 2. Unknown option '--non-interactiveverify'
> Unknown option '--dry-run'
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 469, in 
> InstallPackages().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 280, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 179, in actionexecute
> raise Fail("Failed to distribute repositories/install packages")
> resource_management.core.exceptions.Fail: Failed to distribute 
> repositories/install packages
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
>  7805907 
> 
> Diff: https://reviews.apache.org/r/49437/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 49383: Add a validation of required services during a blueprint deployment


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49383/#review140150
---


Ship it!




Ship It!

- Laszlo Puskas


On June 29, 2016, 4:14 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49383/
> ---
> 
> (Updated June 29, 2016, 4:14 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Sebastian Toader, and Vitalyi 
> Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a validation of required services during a blueprint deployment.  
> Currently a blueprint deployment allows to install YARN without HDFS.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  16f75ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  de5e2b3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  b85d454 
> 
> Diff: https://reviews.apache.org/r/49383/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 49439: porting changes of AMBARI-17081 and AMBARI-16427 in hive2 view

2016-06-30 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49439/#review140149
---


Ship it!




Ship It!

- Gaurav Nagar


On June 30, 2016, 12:11 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49439/
> ---
> 
> (Updated June 30, 2016, 12:11 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17487
> https://issues.apache.org/jira/browse/AMBARI-17487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> patches added and conflicts resolved
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseUtils.java
>  d00dc24 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java
>  847a4b8 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/validated-text-field.js
>  50cea36 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  84637e5 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  578101f 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
> d72ae8c 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  f334a3d 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/ParseUtilsTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49439/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 49438: Editable solrconfig.xml for Logsearch (+ atlas)

2016-06-30 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49438/#review140148
---


Ship it!




Ship It!

- Miklos Gergely


On June 30, 2016, 12:13 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49438/
> ---
> 
> (Updated June 30, 2016, 12:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Miklos 
> Gergely, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17499
> https://issues.apache.org/jira/browse/AMBARI-17499
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - we can upload the whole solr config folder on bootsrapping logsearch or 
> atlas, but later we cannot really edit it
> -> add abillity to reupload solrconfig.xml (but no any change in solr 
> schema), but only if solrconfig.xml content is provided
> 
> add some refactoring too for solr_cloud_util:
> - its not needed to generate a random number for solr_cloud_util
> - its not needed to generate a tmp folder name (where ambari downloads the 
> solr config)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  038f64d 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  a34925f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  bfab139 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  23bb764 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> 1109e51 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> 48e071d 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 65bd1d2 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 
> 9b2ef3f 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 53a854c 
> 
> Diff: https://reviews.apache.org/r/49438/diff/
> 
> 
> Testing
> ---
> 
> Total run:1086
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 49433: Pig - Pig Helper - Relational Operator - GROUP and COGROUP function when selected, param section display incorrect number of param

2016-06-30 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49433/
---

(Updated June 30, 2016, 12:16 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Corrected Ambari bug


Bugs: AMBARI-17495
https://issues.apache.org/jira/browse/AMBARI-17495


Repository: ambari


Description
---

Corrected the params for GROUP and COGROUP


Diffs
-

  
contrib/views/pig/src/main/resources/ui/pig-web/app/assets/data/pigHelpers.json 
90d11ac 
  
contrib/views/pig/src/main/resources/ui/pig-web/app/components/helpers-data.js 
b36fee0 

Diff: https://reviews.apache.org/r/49433/diff/


Testing
---

Maunally Tested.


Thanks,

Gaurav Nagar

Re: Review Request 49439: porting changes of AMBARI-17081 and AMBARI-16427 in hive2 view


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49439/#review140145
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On June 30, 2016, 12:11 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49439/
> ---
> 
> (Updated June 30, 2016, 12:11 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17487
> https://issues.apache.org/jira/browse/AMBARI-17487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> patches added and conflicts resolved
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseUtils.java
>  d00dc24 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java
>  847a4b8 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/validated-text-field.js
>  50cea36 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  84637e5 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  578101f 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
> d72ae8c 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  f334a3d 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/ParseUtilsTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49439/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 49438: Editable solrconfig.xml for Logsearch (+ atlas)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49438/
---

Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Miklos 
Gergely, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-17499
https://issues.apache.org/jira/browse/AMBARI-17499


Repository: ambari


Description
---

- we can upload the whole solr config folder on bootsrapping logsearch or 
atlas, but later we cannot really edit it
-> add abillity to reupload solrconfig.xml (but no any change in solr schema), 
but only if solrconfig.xml content is provided

add some refactoring too for solr_cloud_util:
- its not needed to generate a random number for solr_cloud_util
- its not needed to generate a tmp folder name (where ambari downloads the solr 
config)


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 038f64d 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 a34925f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 bfab139 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 23bb764 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
1109e51 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 48e071d 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 65bd1d2 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 9b2ef3f 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py 53a854c 

Diff: https://reviews.apache.org/r/49438/diff/


Testing
---

Total run:1086
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Review Request 49439: porting changes of AMBARI-17081 and AMBARI-16427 in hive2 view


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49439/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-17487
https://issues.apache.org/jira/browse/AMBARI-17487


Repository: ambari


Description
---

patches added and conflicts resolved


Diffs
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseUtils.java
 d00dc24 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java
 847a4b8 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/validated-text-field.js
 50cea36 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 84637e5 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js 
578101f 
  contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
d72ae8c 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
 f334a3d 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/ParseUtilsTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/49439/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Review Request 49437: RU/EU Install packages fails on suse

2016-06-30 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49437/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17502
https://issues.apache.org/jira/browse/AMBARI-17502


Repository: ambari


Description
---

No handlers could be found for logger "root"
2016-06-30 10:39:21,730 - Could not install packages. Error: Execution of 
'/usr/bin/zypper --quiet --non-interactiveverify --dry-run' returned 2. Unknown 
option '--non-interactiveverify'
Unknown option '--dry-run'
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
166, in actionexecute
ret_code = self.install_packages(package_list)
  File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
400, in install_packages
if not verifyDependencies():
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
 line 309, in verifyDependencies
code, out = rmf_shell.checked_call(cmd, sudo=True)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 71, 
in inner
result = function(command, **kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 93, 
in checked_call
tries=tries, try_sleep=try_sleep)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 141, 
in _call_wrapper
result = _call(command, **kwargs_copy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 294, 
in _call
raise Fail(err_msg)
Fail: Execution of '/usr/bin/zypper --quiet --non-interactiveverify 
--dry-run' returned 2. Unknown option '--non-interactiveverify'
Unknown option '--dry-run'
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
469, in 
InstallPackages().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 280, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
179, in actionexecute
raise Fail("Failed to distribute repositories/install packages")
resource_management.core.exceptions.Fail: Failed to distribute 
repositories/install packages


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
 7805907 

Diff: https://reviews.apache.org/r/49437/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 49432: porting changes of AMBARI-16980 to hive2

2016-06-30 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49432/#review140142
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On June 30, 2016, 10:56 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49432/
> ---
> 
> (Updated June 30, 2016, 10:56 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17484
> https://issues.apache.org/jira/browse/AMBARI-17484
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> changes include the history tab performance improvement
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/persistence/utils/ItemNotFound.java
>  ad2adce 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java
>  f184150 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java
>  3bc396d 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/atsJobs/ATSParser.java
>  e465276 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/atsJobs/ATSRequestsDelegate.java
>  ac8cd22 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/atsJobs/ATSRequestsDelegateImpl.java
>  67497fd 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/atsJobs/IATSParser.java
>  e545c50 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/viewJobs/Job.java
>  816e77a 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/viewJobs/JobControllerImpl.java
>  e94d727 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/viewJobs/JobImpl.java
>  b71e2f7 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/viewJobs/JobInfo.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/number-range-widget.js
>  5d62b59 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/history.js
>  8c4ed2f 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  d2f6aaf 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/models/job.js 
> 9079b5a 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/history.js 
> 0aa3d41 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/history.js
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/history.hbs
>  052498e 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/utils/constants.js 
> e40e447 
> 
> Diff: https://reviews.apache.org/r/49432/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 49433: Pig - Pig Helper - Relational Operator - GROUP and COGROUP function when selected, param section display incorrect number of param

2016-06-30 Thread Ashwin Rajeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49433/#review140135
---


Ship it!




Ship It!

- Ashwin Rajeev


On June 30, 2016, 11 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49433/
> ---
> 
> (Updated June 30, 2016, 11 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17459
> https://issues.apache.org/jira/browse/AMBARI-17459
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Corrected the params for GROUP and COGROUP
> 
> 
> Diffs
> -
> 
>   
> contrib/views/pig/src/main/resources/ui/pig-web/app/assets/data/pigHelpers.json
>  90d11ac 
>   
> contrib/views/pig/src/main/resources/ui/pig-web/app/components/helpers-data.js
>  b36fee0 
> 
> Diff: https://reviews.apache.org/r/49433/diff/
> 
> 
> Testing
> ---
> 
> Maunally Tested.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Review Request 49433: Pig - Pig Helper - Relational Operator - GROUP and COGROUP function when selected, param section display incorrect number of param

2016-06-30 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49433/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-17459
https://issues.apache.org/jira/browse/AMBARI-17459


Repository: ambari


Description
---

Corrected the params for GROUP and COGROUP


Diffs
-

  
contrib/views/pig/src/main/resources/ui/pig-web/app/assets/data/pigHelpers.json 
90d11ac 
  
contrib/views/pig/src/main/resources/ui/pig-web/app/components/helpers-data.js 
b36fee0 

Diff: https://reviews.apache.org/r/49433/diff/


Testing
---

Maunally Tested.


Thanks,

Gaurav Nagar

Review Request 49432: porting changes of AMBARI-16980 to hive2


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49432/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-17484
https://issues.apache.org/jira/browse/AMBARI-17484


Repository: ambari


Description
---

changes include the history tab performance improvement


Diffs
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/persistence/utils/ItemNotFound.java
 ad2adce 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java
 f184150 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java
 3bc396d 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/atsJobs/ATSParser.java
 e465276 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/atsJobs/ATSRequestsDelegate.java
 ac8cd22 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/atsJobs/ATSRequestsDelegateImpl.java
 67497fd 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/atsJobs/IATSParser.java
 e545c50 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/viewJobs/Job.java
 816e77a 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/viewJobs/JobControllerImpl.java
 e94d727 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/viewJobs/JobImpl.java
 b71e2f7 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/viewJobs/JobInfo.java
 PRE-CREATION 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/number-range-widget.js
 5d62b59 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/history.js
 8c4ed2f 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js 
d2f6aaf 
  contrib/views/hive-next/src/main/resources/ui/hive-web/app/models/job.js 
9079b5a 
  contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/history.js 
0aa3d41 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/history.js 
PRE-CREATION 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/history.hbs
 052498e 
  contrib/views/hive-next/src/main/resources/ui/hive-web/app/utils/constants.js 
e40e447 

Diff: https://reviews.apache.org/r/49432/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Re: Review Request 49385: Hive and Oozie db displayed incorrectly on the installer review page

2016-06-30 Thread Andrii Tkach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49385/#review140134
---




ambari-web/test/controllers/wizard/step8_test.js (line 898)


Remove unnecessary logs



ambari-web/test/controllers/wizard/step8_test.js (line 924)


stub and restore should be placed in beforeEach and afterEach 
correspondingly. Use this.mock = sinon.stub(...) and then this.mock.returns in 
it(...)


- Andrii Tkach


On June 29, 2016, 5:21 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49385/
> ---
> 
> (Updated June 29, 2016, 5:21 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
> 
> 
> Bugs: AMBARI-17469
> https://issues.apache.org/jira/browse/AMBARI-17469
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During Hive install, in the review page, the default value of 
> hive_admin_database (MySQL) is concatenated to the selected database type, no 
> matter which database is selected.  For e.g. if Existing PostgreSQL Database 
> is selected as the Hive database, the review page displays the following for 
> Hive database: 
> 
> Database : MySQL (Existing PostgreSQL Database)
>  
> In case of Oozie, because there is no oozie_admin_database property, a blank 
> is displayed for database although an existing database was selected
>  
> Database :  
>  
> This seems to be because of the logic in the method that determines the 
> database value to be displayed.
>  
> var dbFull = serviceConfigProperties.findProperty('name', 
> serviceName.toLowerCase() + '_database'),
>  db = serviceConfigProperties.findProperty('name', 
> serviceName.toLowerCase() + '_ambari_database');
> return db && dbFull ? db.value + ' (' + dbFull.value + ')' : '';
> 
> The value of hive_ambari_database returns MySQL and hence in case of Hive, 
> MySQL always gets appended.
>  
> There is no oozie_ambari_database property defined. Hence db is undefined and 
> an emtpy string is returned instead of the actual database type selected.
>  
> Fix involves changing the logic to not include the value of 
> serviceName_ambari_database since it will not have the right value unless the 
> default value is selected for Hive/Oozie database.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 3971cf5 
>   ambari-web/test/controllers/wizard/step8_test.js 74e042b 
> 
> Diff: https://reviews.apache.org/r/49385/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> Added a test case to verify the value displayed for database.
> Ran mvn test
> 
> 28979 tests complete (48 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack

2016-06-30 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49429/
---

(Updated June 30, 2016, 10:33 a.m.)


Review request for Ambari, Don Bosco Durai, Oliver Szabo, Robert Nettleton, and 
Sumit Mohanty.


Changes
---

Remove HadoopServiceConfig.json from the rpm


Bugs: AMBARI-17492
https://issues.apache.org/jira/browse/AMBARI-17492


Repository: ambari


Description
---

Cluster with HDF stack should show only HDF services, HDP cluster should not 
show NiFi


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-assembly/pom.xml 958232e 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 bdb5fb1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 8bb6225 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 fe7e757 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 a89b3d6 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 bfab139 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 48e071d 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733 

Diff: https://reviews.apache.org/r/49429/diff/


Testing
---

Tested on local cluster.

ambari-server:
OK
--
Total run:1085
Total errors:0
Total failures:0


Thanks,

Miklos Gergely

Re: Review Request 49431: Falcon start fails non-root + umask 027

2016-06-30 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49431/#review140131
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Червень 30, 2016, 10:01 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49431/
> ---
> 
> (Updated Червень 30, 2016, 10:01 до полудня)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-17494
> https://issues.apache.org/jira/browse/AMBARI-17494
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py",
>  line 177, in 
> FalconServer().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 280, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py",
>  line 49, in start
> self.configure(env, upgrade_type=upgrade_type)
>   File 
> "/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py",
>  line 44, in configure
> falcon('server', action='config', upgrade_type=upgrade_type)
>   File 
> "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, 
> in thunk
> return fn(*args, **kwargs)
>   File 
> "/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py",
>  line 163, in falcon
> source = params.falcon_extensions_source_dir)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 
> 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 458, in action_create_on_execute
> self.action_delayed("create")
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 455, in action_delayed
> self.get_hdfs_resource_executor().action_delayed(action_name, self)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 254, in action_delayed
> self._create_resource()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 271, in _create_resource
> self._copy_from_local_directory(self.main_resource.resource.target, 
> self.main_resource.resource.source)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 280, in _copy_from_local_directory
> self._copy_from_local_directory(new_target, new_source)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 274, in _copy_from_local_directory
> for next_path_part in os.listdir(source):
> OSError: [Errno 13] Permission denied: 
> '/usr/hdp/current/falcon-server/extensions/mirroring'
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/resource_management/core/sudo.py 4ea44bc 
>   
> ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py
>  12d9ee4 
> 
> Diff: https://reviews.apache.org/r/49431/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 49431: Falcon start fails non-root + umask 027

2016-06-30 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49431/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17494
https://issues.apache.org/jira/browse/AMBARI-17494


Repository: ambari


Description
---

Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py",
 line 177, in 
FalconServer().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 280, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py",
 line 49, in start
self.configure(env, upgrade_type=upgrade_type)
  File 
"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py",
 line 44, in configure
falcon('server', action='config', upgrade_type=upgrade_type)
  File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
line 89, in thunk
return fn(*args, **kwargs)
  File 
"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py",
 line 163, in falcon
source = params.falcon_extensions_source_dir)
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 458, in action_create_on_execute
self.action_delayed("create")
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 455, in action_delayed
self.get_hdfs_resource_executor().action_delayed(action_name, self)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 254, in action_delayed
self._create_resource()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 271, in _create_resource
self._copy_from_local_directory(self.main_resource.resource.target, 
self.main_resource.resource.source)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 280, in _copy_from_local_directory
self._copy_from_local_directory(new_target, new_source)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 274, in _copy_from_local_directory
for next_path_part in os.listdir(source):
OSError: [Errno 13] Permission denied: 
'/usr/hdp/current/falcon-server/extensions/mirroring'


Diffs
-

  ambari-common/src/main/python/resource_management/core/sudo.py 4ea44bc 
  
ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py
 12d9ee4 

Diff: https://reviews.apache.org/r/49431/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 49256: Hive view : Upload Table feature should support various column and row delimiters


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49256/#review140127
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On June 30, 2016, 9:31 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49256/
> ---
> 
> (Updated June 30, 2016, 9:31 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17421
> https://issues.apache.org/jira/browse/AMBARI-17421
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ealier user defined delimiters in CSV were not supported : 
> In this patch : 
> Following support has been added to upload feature.
> 1. when "File type" is selected there will be a settings button which can be 
> clicked to open following CSV specific configurations
> Column delimiter: select from dropdown : printable and non printable ascii 
> characters supported.
> Escape Character: select from dropdown : printable and non printable ascii 
> characters supported.
> Quote Character: select from dropdown : printable and non printable ascii 
> characters supported.
> Is first row header ?: checkbox to specify if the first row of CSV is header
> 2. when "Stored As" is TEXTFILE the setting button next to it will be enabled 
> for further settings
> Fields Terminated By: the field terminator for hive table
> Escape By: the escape character for hive table.
> 3. When "Stored As" is not TEXTFILE a field called "Contains endlines?" will 
> be visible.
> User has to check this field if the they field values contains endline (\n) 
> characters. If this is checked the temporary table is created with Hex 
> encoding of fields with datatype STRING, VARCHAR and CHAR to preserve endline 
> characters properly. If user does not select this and fields contain endline 
> characters then behaviour of upload is unexpected. Endline characters are not 
> supported in TEXTFILE hive storage type.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive/pom.xml 444cd98 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java
>  5164a4d 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
>  a540ca0 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobImpl.java
>  2e5f0f7 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/CSVParams.java
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/TableDataReader.java
>  e9bdb92 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/TableInput.java
>  f7fbbba 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadFromHdfsInput.java
>  14bd27a 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  ad10751 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/DataParser.java
>  d03dd7e 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/IParser.java
>  8b75c04 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseOptions.java
>  e592b5f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java
>  49f47c7 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/RowIterator.java
>  69fe864 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVIterator.java
>  3342f49 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVParser.java
>  a48041c 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/commonscsv/CSVIterator.java
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/commonscsv/CSVParser.java
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/opencsv/OpenCSVIterator.java
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/opencsv/OpenCSVParser.java
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/query/InsertFromQueryInput.java
>  5befc51 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/query/QueryGenerator.java
>  6bab229 
>   
>

Re: Review Request 49379: Hive2 view : port changes of following 10 bugs in hive2 view


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49379/#review140126
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On June 29, 2016, 2:46 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49379/
> ---
> 
> (Updated June 29, 2016, 2:46 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17480
> https://issues.apache.org/jira/browse/AMBARI-17480
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> port following change in hive2
> AMBARI-16266
> AMBARI-16424
> AMBARI-16425
> AMBARI-16422
> AMBARI-16726
> AMBARI-16675
> AMBARI-16429
> AMBARI-16242
> AMBARI-16418
> AMBARI-16428
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/persistence/DataStoreStorage.java
>  9adf129 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java
>  4293b1b 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java
>  975036e 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadFromHdfsInput.java
>  7a7f77c 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  59e969d 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/DataParser.java
>  6edc97c 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/IParser.java
>  401ef48 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseUtils.java
>  fefacce 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java
>  79c5482 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVParser.java
>  74cc060 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/json/JSONParser.java
>  772b6fd 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/xml/XMLParser.java
>  51671e5 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/file-upload.js
>  1bd8eee 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/upload-table.js
>  ef4df43 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/file-upload.js
>  1cd05ae 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/validated-text-field.js
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js
>  4f3261c 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  cb267a0 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  b3630c1 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/history.js 
> 848bee8 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/job.js 
> 6cb4170 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
> 8f60595 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/components/validated-text-field.hbs
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  b7d9011 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/CSVParserTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserCSVTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserJSONTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserXMLTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/JsonParserTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/TableDataReaderTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/XMLParserTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49379/diff/
> 
> 
> Testing
> ---
> 
> added test cases and also manual testing where

Re: Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

2016-06-30 Thread Alexandr Antonenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49287/#review140121
---




ambari-web/app/views/main/host/details/host_component_view.js (line 196)


this will not work out, as there is no hive-env, only "hive-site". You have 
to do a request to get this config


- Alexandr Antonenko


On June 27, 2016, 11:20 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49287/
> ---
> 
> (Updated June 27, 2016, 11:20 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-17358
> https://issues.apache.org/jira/browse/AMBARI-17358
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> When user switches from MySQL to Existing database in hive and stop the MySQL 
> Server
> 
> 1) Ambari UI > Hive > Service Actions > Stop becomes unavailable, so Hive 
> can't be stopped anymore
> 
> 2) Hive status is showing up as red Triangle indicating there is a problem 
> with Hive
> 
> Providing an option to delete MySQL server when an existing database is used 
> in Hive would help in overcoming the issues.
> 
> 
> Solution:
> An option is included to delete MySQL Server, the delete will be enabled only 
> when Hive is using an existing(or external) database and the MySQL server is 
> not started.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/stack_service_component.js a350f15 
>   ambari-web/app/routes/main.js 4545f54 
>   ambari-web/app/views/main/host/details/host_component_view.js 910c71f 
>   ambari-web/test/models/stack_service_component_test.js 7e971ce 
>   ambari-web/test/views/main/host/details/host_component_view_test.js 648f0f6 
> 
> Diff: https://reviews.apache.org/r/49287/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 
> 28974 tests complete (43 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 49265: When querying host role command entities, the number of parameters should be limited

2016-06-30 Thread Daniel Gergely



> On jún. 27, 2016, 5:36 du, Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java,
> >  line 288
> > 
> >
> > What's the root cause of more than 1k rows being returned?
> > RU/EU?
> 
> Daniel Gergely wrote:
> The number of returned lines is irrelevant here. The problem is the 
> number of parameters in the prepared statement. The query above has "task_id 
> IN ?1" part and "?1" is replaced with a collection. If that collection has 
> many elements, the prepared statement looks like "task_id IN 
> (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,...)". There is an upper limit 
> for the number of parameters on the sql server side. This was handled for 
> oracle only, but mssql has a limit as well, so it has no point to apply the 
> logic only for oracle, rather now it is configurable.
> The number of parameteres is high when stage summaries are being created 
> and cache is empty (e.g.: because of an earlier host removal or an ambari 
> server restart). That case all tasks are in the collection, so in the case of 
> a 200 nodes cluster the number of tasks can be over 2200. (mssql rejected the 
> request, because the upper limit for number of parameteres in this case was 
> 2100)
> 
> What does "RU/EU" mean?
> 
> Sebastian Toader wrote:
> RU - rolling upgrade, EU - express upgrade
> 
> Daniel Gergely wrote:
> I see. It is not related to upgrade process at all.
> 
> Alejandro Fernandez wrote:
> My point is that we need to know what actually made this request.
> I understand why it is being segmented, but I'm curious if the caller is 
> inefficient and actually queries sequential task_ids, in which case we can 
> use task_id >= x and task_id <= y.

It is not necessary sequential. The problem is with the design: the filtering 
is done on ambari-server side, not in the db. So what the method receives is a 
list of taskIds (not the information with which db filtering could be done). 
This method is called when creating a summary for stages (e.g. for the ui), so 
all the tasks are requested. In the case of a large cluster, the mentioned 
limit is hit. (it is 1000 for oracle, 2100 for mssql, 65536 for mysql, and 
unlimited for postgres)


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49265/#review139611
---


On jún. 27, 2016, 2:01 du, Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49265/
> ---
> 
> (Updated jún. 27, 2016, 2:01 du)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17449
> https://issues.apache.org/jira/browse/AMBARI-17449
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the case of a larger cluster, the number of host role commands can be high 
> (magnitude of thousands). Database servers usually have a limit on the number 
> of parameters, so reaching this limit causes a failure.
> Paging should be introduced to have only a smaller number of parameters in a 
> single query and do multiple queries to obtain the final result.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2eb0734 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/DaoUtils.java 
> 7f157ec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  1768f21 
> 
> Diff: https://reviews.apache.org/r/49265/diff/
> 
> 
> Testing
> ---
> 
> Running locally...
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 49362: Add additional parameters to hawq-site.xml

2016-06-30 Thread Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49362/
---

(Updated June 30, 2016, 12:40 a.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.


Bugs: AMBARI-17473
https://issues.apache.org/jira/browse/AMBARI-17473


Repository: ambari


Description
---

Add additional parameters to hawq-site.xml


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 6e21d84 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
 1d27052 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
f0e8b33 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
d7940a1 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 12f4fa1 

Diff: https://reviews.apache.org/r/49362/diff/


Testing
---

Manually tested.


Thanks,

Matt

Re: Review Request 49427: Hive2 view : port changes of following 8 UI bugs in hive2 view


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49427/#review140112
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On June 30, 2016, 6:32 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49427/
> ---
> 
> (Updated June 30, 2016, 6:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17482
> https://issues.apache.org/jira/browse/AMBARI-17482
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> port following change in hive2
> AMBARI-16443
> AMBARI-16445
> AMBARI-16452
> AMBARI-16132
> AMBARI-16626
> AMBARI-16738
> AMBARI-16825
> AMBARI-17060
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/date-range-widget.js
>  9e38786 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/databases.js
>  b76bca3 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index/history-query/explain.js
>  20092e2 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/open-queries.js
>  a4048be 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  b3630c1 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/settings.js
>  b813bbf 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
> 8f60595 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/components/tree-view.hbs
>  cb83ec3 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/databases-search-results.hbs
>  007d9ca 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/databases.hbs
>  290cdac 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/index/history-query/explain.hbs
>  3f8810f 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/tests/helpers/api-mock.js
>  ed4822d 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/tests/helpers/dbclick.js
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/tests/integration/database-test.js
>  52cda77 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/tests/integration/query-editor-test.js
>  b409e12 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/tests/integration/saved-queries-test.js
>  c444523 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/tests/integration/udfs-test.js
>  95a0043 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/tests/unit/components/udf-tr-view-test.js
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/tests/unit/controllers/udfs-test.js
>  5bd369e 
> 
> Diff: https://reviews.apache.org/r/49427/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 49427: Hive2 view : port changes of following 8 UI bugs in hive2 view