Re: Review Request 51677: AMBARI-18327: multiple clicks on "Next" button of Step-4 (Choose Services) causes skipping of steps while installing a cluster

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51677/#review147972
---



In step-4 the flag "nextBtnClickInProgress" was not set anywhere -> We set 
nextBtnClickInProgress in router for step 4

So if a timeout was manually added in the "submit" function of the controller, 
we could allow multiple clicks to be registered -> I think this is not the 
right way to test and create bugs based on such synthetic test case. Because if 
I will wrap with timeout your newly added line where you set 
nextBtnClickInProgress to true, results will be the same, I will be able to 
perform multiple clicks.

I was not able to reproduce this issue manually on latest trunk. 

This behavior is reproducible only when the host is slow, which would allow 
enough time to click the Next button multiple times -> Even when I set 
throttling to 50 kb/s and delay 500ms (the slowest setting in chrome network 
tab) I'm unable to reproduce

I think what we have in router for step 4 is enough to prevent multiple clicks

- Alexandr Antonenko


On Sept. 6, 2016, 10:41 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51677/
> ---
> 
> (Updated Sept. 6, 2016, 10:41 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18327
> https://issues.apache.org/jira/browse/AMBARI-18327
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While installing a cluster if the Ambari user happened to click the "Next" 
> button of Step-4 (Choose Services step) more than once, then it could lead to 
> skipping directly to step-6 or 7 or 8 depending on the number of times the 
> click got registered. This behavior is reproducible only when the host is 
> slow, which would allow enough time to click the Next button multiple times.
> 
> This issue is related to AMBARI-14574, and is a revised fix for the Step-4.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step4_controller.js 04e6784 
> 
> Diff: https://reviews.apache.org/r/51677/diff/
> 
> 
> Testing
> ---
> 
> **FIX:**
> In step-4 the flag "nextBtnClickInProgress" was not set anywhere. So if a 
> timeout was manually added in the "submit" function of the controller, we 
> could allow multiple clicks to be registered and these would be processed 
> allowing steps to be skipped. In the revised fix, the flag 
> "nextBtnClickInProgress" is set in the "submit" function. 
> "nextBtnClickInProgress" causes "isSubmitDisabled" function also to return 
> "true" or "false" depending on whether it is "true" or "false" respectively. 
> For this reason, we also need to reset the "nextBtnClickInProgress" flag at 
> the end of "validate" function so that the subsequent valid "submit" calls, 
> on closing pop-up(s) can be processed. 
> 
> **TESTING:**
> ambari-web unit tests affter applying the patch:
> 
>   30182 tests complete (46 seconds)
>   151 tests pending
> 
> 
> Also, did manual testing by adding a timeout in the submit() of 
> step4_controller.js to allow multiple clicks to be registered on the Next 
> button.
> 
> 
> Thanks,
> 
> Keta Patel
> 
>

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

[Sid Wagle]

> On Sept. 6, 2016, 11:55 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java,
> >  line 332
> > 
> >
> > This query is not correct.
> > 
> > try,
> > select component_name from (select component_name, count(*) as num from 
> > (select component_name, current_state from hostcomponentstate group by 
> > component_name, current_state) as agg group by component_name) as result 
> > where num > 1;

Why is the query wrong?


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51629/#review147949
---


On Sept. 6, 2016, 10:29 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51629/
> ---
> 
> (Updated Sept. 6, 2016, 10:29 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18309
> https://issues.apache.org/jira/browse/AMBARI-18309
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add db consistency check for hostcomponent tables, for each component we 
> should have only one state.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  f302b8b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  535d74f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  4663310 
> 
> Diff: https://reviews.apache.org/r/51629/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51600: WebHCat service check should not depend on Pig

[Andrew Onischuk]

> On Sept. 6, 2016, 8:52 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py,
> >  line 578
> > 
> >
> > If a service is deleted, so we still pass in the configs? We may 
> > instead want to check how many hosts have PIG client installed.

Good point, but we don't pass client hosts in configurations. Because 1K node 
it would generate too large heartbeats


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51600/#review147916
---


On Sept. 2, 2016, 2:23 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51600/
> ---
> 
> (Updated Sept. 2, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18304
> https://issues.apache.org/jira/browse/AMBARI-18304
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently WebHCat service check fails on a cluster where Pig is not installed.
> We should eliminate the WebHCat dependency over Pig.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd61631 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  71f930e 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 273bd96 
> 
> Diff: https://reviews.apache.org/r/51600/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 51685: AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server log file

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51685/#review147964
---


Ship it!




Ship It!

- Sumit Mohanty


On Sept. 7, 2016, 2:14 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51685/
> ---
> 
> (Updated Sept. 7, 2016, 2:14 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-18328
> https://issues.apache.org/jira/browse/AMBARI-18328
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server 
> log file
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  de998cea801dba4b554255b209d20fb61bca36cc 
> 
> Diff: https://reviews.apache.org/r/51685/diff/
> 
> 
> Testing
> ---
> 
> ** Manual Testing **
> Deployed a VM with the latest trunk build and patched ambari-server JAR with 
> the one from the local build. Ran a blueprint deployed and verified that the 
> *settings* section of the blueprint was logged in 
> /var/log/ambari-server/ambari-server.log.
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Review Request 51685: AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server log file

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51685/
---

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-18328
https://issues.apache.org/jira/browse/AMBARI-18328


Repository: ambari


Description
---

AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server 
log file


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
 de998cea801dba4b554255b209d20fb61bca36cc 

Diff: https://reviews.apache.org/r/51685/diff/


Testing
---

** Manual Testing **
Deployed a VM with the latest trunk build and patched ambari-server JAR with 
the one from the local build. Ran a blueprint deployed and verified that the 
*settings* section of the blueprint was logged in 
/var/log/ambari-server/ambari-server.log.


Thanks,

Nahappan Somasundaram

Re: Review Request 49804: improve resourcemanager HA description

[wang yaoxin]

> On 九月 6, 2016, 7:41 p.m., Nate Cole wrote:
> > Ship It!

Thank you , but I don't have the authority to ship, so i will trouble you to  
commit the patch!


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49804/#review147904
---


On 九月 6, 2016, 9:57 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49804/
> ---
> 
> (Updated 九月 6, 2016, 9:57 a.m.)
> 
> 
> Review request for Ambari, jun aoki, Nate Cole, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-17518
> https://issues.apache.org/jira/browse/AMBARI-17518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> improve the resourcemanager HA description
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/host_component.js 973b809 
> 
> Diff: https://reviews.apache.org/r/49804/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51629/#review147949
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 332)


This query is not correct.

try,
select component_name from (select component_name, count(*) as num from 
(select component_name, current_state from hostcomponentstate group by 
component_name, current_state) as agg group by component_name) as result where 
num > 1;


- Alejandro Fernandez


On Sept. 6, 2016, 10:29 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51629/
> ---
> 
> (Updated Sept. 6, 2016, 10:29 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18309
> https://issues.apache.org/jira/browse/AMBARI-18309
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add db consistency check for hostcomponent tables, for each component we 
> should have only one state.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  f302b8b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  535d74f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  4663310 
> 
> Diff: https://reviews.apache.org/r/51629/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51629/#review147948
---


Ship it!




Ship It!

- Sid Wagle


On Sept. 6, 2016, 10:29 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51629/
> ---
> 
> (Updated Sept. 6, 2016, 10:29 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18309
> https://issues.apache.org/jira/browse/AMBARI-18309
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add db consistency check for hostcomponent tables, for each component we 
> should have only one state.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  f302b8b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  535d74f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  4663310 
> 
> Diff: https://reviews.apache.org/r/51629/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51678: Code review request for AMBARI-18290 (Ambari does not support HBase on HTTPS mode)

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51678/#review147946
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 (line 660)


This breaks class convention. The return statement should be sufficient if 
you add to EnumMap property is added for HBASE_MASTER-HTTPS



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 (line 1210)


What about HBASE_REGIONSERVER JMX calls ?


- Sid Wagle


On Sept. 6, 2016, 10:56 p.m., Amarnath reddy pappu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51678/
> ---
> 
> (Updated Sept. 6, 2016, 10:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-18290
> https://issues.apache.org/jira/browse/AMBARI-18290
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If HTTPS is enabled for HBase, Ambari still tries to communicate on HTTP port 
> to fetch JMX properties. because of that Ambari shows incorrect 
> Active/Standby node information.
> 
> Have made code changes to read the "hbase.http.policy" property and then 
> decide the protocol.
> 
> Note: I have not made any changes to Ambari Web. If HTTPS is enabled for 
> HBase then all quick links should be opened on HTTPS. Currently Ambari checks 
>  "dfs.http.policy" HDFS/Hadoop property and decide whether for all the quick 
> links.  it does not check HBase "hbase.http.policy" property to decide. am 
> leaving this functionality as it is.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  066d5c4 
> 
> Diff: https://reviews.apache.org/r/51678/diff/
> 
> 
> Testing
> ---
> 
> Test cases executed
> --
> 1. Install Ambari2.4, install HBase service, in summary it should show 
> "Active HBase Master"  properly
> 2. Install Ambari2.4, install HBase service and enable HTTPS, in summary it 
> should show "Active HBase Master"  properly
> 3. Install Ambari2.4, install HBase service and add one more HBase master. it 
> should show one node as active and other is standby
> 4. Install Ambari2.4, install HBase service and add one more HBase master and 
> enable HTTPS. it should show one node as active and other is standby
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Re: Review Request 51678: Code review request for AMBARI-18290 (Ambari does not support HBase on HTTPS mode)

[Amarnath reddy pappu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51678/
---

(Updated Sept. 6, 2016, 10:56 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and 
Sid Wagle.


Bugs: AMBARI-18290
https://issues.apache.org/jira/browse/AMBARI-18290


Repository: ambari


Description (updated)
---

If HTTPS is enabled for HBase, Ambari still tries to communicate on HTTP port 
to fetch JMX properties. because of that Ambari shows incorrect Active/Standby 
node information.

Have made code changes to read the "hbase.http.policy" property and then decide 
the protocol.

Note: I have not made any changes to Ambari Web. If HTTPS is enabled for HBase 
then all quick links should be opened on HTTPS. Currently Ambari checks  
"dfs.http.policy" HDFS/Hadoop property and decide whether for all the quick 
links.  it does not check HBase "hbase.http.policy" property to decide. am 
leaving this functionality as it is.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 066d5c4 

Diff: https://reviews.apache.org/r/51678/diff/


Testing
---

Test cases executed
--
1. Install Ambari2.4, install HBase service, in summary it should show "Active 
HBase Master"  properly
2. Install Ambari2.4, install HBase service and enable HTTPS, in summary it 
should show "Active HBase Master"  properly
3. Install Ambari2.4, install HBase service and add one more HBase master. it 
should show one node as active and other is standby
4. Install Ambari2.4, install HBase service and add one more HBase master and 
enable HTTPS. it should show one node as active and other is standby


Thanks,

Amarnath reddy pappu

Review Request 51678: Code review request for AMBARI-18290 (Ambari does not support HBase on HTTPS mode)

[Amarnath reddy pappu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51678/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and 
Sid Wagle.


Bugs: AMBARI-18290
https://issues.apache.org/jira/browse/AMBARI-18290


Repository: ambari


Description
---

If HTTPS is enabled for HBase, Ambari still tries to communicate on HTTP port 
to fetch JMX properties.
Have made code changes to read the "hbase.http.policy" property and then decide 
the protocol.

Note: I have not made any changes to Ambari Web. If HTTPS is enabled for HBase 
then all quick links should be opened on HTTPS. Currently Ambari checks  
"dfs.http.policy" HDFS/Hadoop property and decide whether for all the quick 
links.  it does not check HBase "hbase.http.policy" property to decide. am 
leaving this functionality as it is.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 066d5c4 

Diff: https://reviews.apache.org/r/51678/diff/


Testing
---

Test cases executed
--
1. Install Ambari2.4, install HBase service, in summary it should show "Active 
HBase Master"  properly
2. Install Ambari2.4, install HBase service and enable HTTPS, in summary it 
should show "Active HBase Master"  properly
3. Install Ambari2.4, install HBase service and add one more HBase master. it 
should show one node as active and other is standby
4. Install Ambari2.4, install HBase service and add one more HBase master and 
enable HTTPS. it should show one node as active and other is standby


Thanks,

Amarnath reddy pappu

Re: Review Request 51354: Clean up Log Feeder

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51354/
---

(Updated Sept. 6, 2016, 10:51 p.m.)


Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and 
Robert Nettleton.


Changes
---

Logger is called LOG all over the component following the convention in Ambari


Bugs: AMBARI-18246
https://issues.apache.org/jira/browse/AMBARI-18246


Repository: ambari


Description
---

- long methods were broken up to smaller independent parts
- narrowed the scope of too widely defined variables
- fixed visibilities of the methods/fields
- converted constants / enums to use java conventions for names
- maximum line length is 120 characters, fixed unnecessary short lines
- rearranged the functions so that they follow the order of the lifecycle of 
these components
- refactored some overcomplicated parts
- removed unused codes


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
 373d743 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigBlock.java
 287982f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
 ab371f1 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
 372c208 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterJSON.java
 2954106 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
 7adb468 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 5feb9c4 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
 c9f5ded 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java
 48a7f1d 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMgr.java
 b18c9b0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
 c9d28bd 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
 5ba56a5 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
 a2a9db2 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java
 c57c028 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
 ae0cfc0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederConstants.java
 09673a0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogfeederScheduler.java
 bc807193 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java
 b5e4eb3 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/DefaultDataFilter.java
 04d2ca4 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/FilterLogData.java
 3a8eae9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/Mapper.java
 906dd25 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
 6dbf8be 
  

Re: Review Request 51677: AMBARI-18327: multiple clicks on "Next" button of Step-4 (Choose Services) causes skipping of steps while installing a cluster

[Keta Patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51677/
---

(Updated Sept. 6, 2016, 10:41 p.m.)


Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-18327
https://issues.apache.org/jira/browse/AMBARI-18327


Repository: ambari


Description
---

While installing a cluster if the Ambari user happened to click the "Next" 
button of Step-4 (Choose Services step) more than once, then it could lead to 
skipping directly to step-6 or 7 or 8 depending on the number of times the 
click got registered. This behavior is reproducible only when the host is slow, 
which would allow enough time to click the Next button multiple times.

This issue is related to AMBARI-14574, and is a revised fix for the Step-4.


Diffs
-

  ambari-web/app/controllers/wizard/step4_controller.js 04e6784 

Diff: https://reviews.apache.org/r/51677/diff/


Testing (updated)
---

**FIX:**
In step-4 the flag "nextBtnClickInProgress" was not set anywhere. So if a 
timeout was manually added in the "submit" function of the controller, we could 
allow multiple clicks to be registered and these would be processed allowing 
steps to be skipped. In the revised fix, the flag "nextBtnClickInProgress" is 
set in the "submit" function. "nextBtnClickInProgress" causes 
"isSubmitDisabled" function also to return "true" or "false" depending on 
whether it is "true" or "false" respectively. For this reason, we also need to 
reset the "nextBtnClickInProgress" flag at the end of "validate" function so 
that the subsequent valid "submit" calls, on closing pop-up(s) can be 
processed. 

**TESTING:**
ambari-web unit tests affter applying the patch:

  30182 tests complete (46 seconds)
  151 tests pending


Also, did manual testing by adding a timeout in the submit() of 
step4_controller.js to allow multiple clicks to be registered on the Next 
button.


Thanks,

Keta Patel

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51629/
---

(Updated Вер. 6, 2016, 10:29 після полудня)


Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle.


Bugs: AMBARI-18309
https://issues.apache.org/jira/browse/AMBARI-18309


Repository: ambari


Description
---

Add db consistency check for hostcomponent tables, for each component we should 
have only one state.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 f302b8b 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
 535d74f 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 4663310 

Diff: https://reviews.apache.org/r/51629/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 51677: AMBARI-18327: multiple clicks on "Next" button of Step-4 (Choose Services) causes skipping of steps while installing a cluster

[Keta Patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51677/
---

Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-18327
https://issues.apache.org/jira/browse/AMBARI-18327


Repository: ambari


Description
---

While installing a cluster if the Ambari user happened to click the "Next" 
button of Step-4 (Choose Services step) more than once, then it could lead to 
skipping directly to step-6 or 7 or 8 depending on the number of times the 
click got registered. This behavior is reproducible only when the host is slow, 
which would allow enough time to click the Next button multiple times.

This issue is related to AMBARI-14574, and is a revised fix for the Step-4.


Diffs
-

  ambari-web/app/controllers/wizard/step4_controller.js 04e6784 

Diff: https://reviews.apache.org/r/51677/diff/


Testing
---

ambari-web unit tests affter applying the patch:

  30182 tests complete (46 seconds)
  151 tests pending


Also, did manual testing by adding a timeout in the submit() of 
step4_controller.js to allow multiple clicks to be registered on the Next 
button.


Thanks,

Keta Patel

Re: Review Request 51354: Clean up Log Feeder

[Oliver Szabo]

> On Sept. 6, 2016, 5:45 p.m., Robert Nettleton wrote:
> > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/CompressionUtil.java,
> >  line 33
> > 
> >
> > I'm seeing this change throughout as well.  
> > 
> > Why are the loggers being renamed?  I just checked a sample of the 
> > Ambari code, and most classes appear to use LOG as the name.  I'm not sure 
> > there is much reason to change this, as having a common name reduces 
> > confusion for code maintenance across packages.
> 
> Miklos Gergely wrote:
> In the logsearch project it's almost always logger. In java the all 
> capital variable name means that it's a constant, and an instance of the 
> Logger class has modifiable state, so no constant can be created from it. So 
> even if it's a static final variable it's still not a constant.

widely/mostly LOG/LOGGER is used, i think its better to be LOG, i also noticed 
that during logsearch refactoring, but i did not include these in my chanhges


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51354/#review147866
---


On Sept. 6, 2016, 1:46 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51354/
> ---
> 
> (Updated Sept. 6, 2016, 1:46 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-18246
> https://issues.apache.org/jira/browse/AMBARI-18246
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - long methods were broken up to smaller independent parts
> - narrowed the scope of too widely defined variables
> - fixed visibilities of the methods/fields
> - converted constants / enums to use java conventions for names
> - maximum line length is 120 characters, fixed unnecessary short lines
> - rearranged the functions so that they follow the order of the lifecycle of 
> these components
> - refactored some overcomplicated parts
> - removed unused codes
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  373d743 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigBlock.java
>  287982f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
>  ab371f1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  372c208 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterJSON.java
>  2954106 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
>  7adb468 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  5feb9c4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  c9f5ded 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java
>  48a7f1d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMgr.java
>  b18c9b0 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
>  c9d28bd 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
>  5ba56a5 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
>  a2a9db2 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java
>  c57c028 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
>  ae0cfc0 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java
>  PRE-CREATION 
>   
> 

Re: Review Request 51600: WebHCat service check should not depend on Pig

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51600/#review147916
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 (line 578)


If a service is deleted, so we still pass in the configs? We may instead 
want to check how many hosts have PIG client installed.


- Alejandro Fernandez


On Sept. 2, 2016, 2:23 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51600/
> ---
> 
> (Updated Sept. 2, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18304
> https://issues.apache.org/jira/browse/AMBARI-18304
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently WebHCat service check fails on a cluster where Pig is not installed.
> We should eliminate the WebHCat dependency over Pig.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd61631 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  71f930e 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 273bd96 
> 
> Diff: https://reviews.apache.org/r/51600/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 51575: Provide stack-advisor support for Microsoft-R service

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51575/#review147915
---


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 1, 2016, 1:36 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51575/
> ---
> 
> (Updated Sept. 1, 2016, 1:36 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17891
> https://issues.apache.org/jira/browse/AMBARI-17891
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update existing service_advisor.py for Microsoft-R service to conform to the 
> updated interface (changed in AMBARI-16663).  Also fix leftover comment.
> 
> 
> Diffs
> -
> 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  554be2d 
> 
> Diff: https://reviews.apache.org/r/51575/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on local cluster (created cluster with HDFS, YARN, and 
> ZooKeeper; added Microsoft-R service via web UI; verified that service 
> advisor is invoked in both recommend-component-layout and 
> validate-component-layout requests, and that it correctly 
> recommends/validates service colocation).
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 51550: [AMBARI-18284] Ambari PigView stores the pig scripts in HDFS in non UTF-8 format

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51550/#review147905
---



Ping.  Can this be pushed and close this review?

- Nate Cole


On Aug. 31, 2016, 4:08 a.m., Jay SenSharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51550/
> ---
> 
> (Updated Aug. 31, 2016, 4:08 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jonathan 
> Hurley, Nate Cole, Pallav Kulshreshtha, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18284
> https://issues.apache.org/jira/browse/AMBARI-18284
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari PigView stores the pig scripts in HDFS in non UTF-8 format. So when 
> next time pig view loads the scripts from HDFS those have junk characters.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java
>  9dea2a2 
> 
> Diff: https://reviews.apache.org/r/51550/diff/
> 
> 
> Testing
> ---
> 
> Test Succeeded fine. After aplying the fix the PigView shows the script with 
> the correct characters.
> 
> 
> Thanks,
> 
> Jay SenSharma
> 
>

Re: Review Request 49804: improve resourcemanager HA description

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49804/#review147904
---


Ship it!




Ship It!

- Nate Cole


On Sept. 6, 2016, 5:57 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49804/
> ---
> 
> (Updated Sept. 6, 2016, 5:57 a.m.)
> 
> 
> Review request for Ambari, jun aoki, Nate Cole, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-17518
> https://issues.apache.org/jira/browse/AMBARI-17518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> improve the resourcemanager HA description
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/host_component.js 973b809 
> 
> Diff: https://reviews.apache.org/r/49804/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 51659: Ambari cannot install HDP from mirror list

[Nate Cole]

> On Sept. 6, 2016, 2:04 p.m., Alejandro Fernandez wrote:
> > What is the format of the mirror list?

+1 for this - I would prefer if mirrors is not just some CSV but was structured 
(set of items, etc).


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51659/#review147878
---


On Sept. 6, 2016, 1:23 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51659/
> ---
> 
> (Updated Sept. 6, 2016, 1:23 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-18325
> https://issues.apache.org/jira/browse/AMBARI-18325
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should update the code and be able to use a mirror list instead of a 
> single url.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  92d47df 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  6aa0853 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java
>  84929bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  3b5b0a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
>  8d6e6e2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  49d53a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 
> da7f021 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 0606f2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  29776ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
>  3c7c001 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  50d6028 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java
>  b1c643a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java
>  8c629ca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
>  143f9af 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  538fa48 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  3ad1f1f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeUtilTest.java
>  35650a1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
>  dcac986 
> 
> Diff: https://reviews.apache.org/r/51659/diff/
> 
> 
> Testing
> ---
> 
> preview of patch (works on live cluster)
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 51663: Add custom jdbc path to ambari-server classpath

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51663/#review147895
---


Ship it!




Ship It!

- Sumit Mohanty


On Sept. 6, 2016, 7 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51663/
> ---
> 
> (Updated Sept. 6, 2016, 7 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18326
> https://issues.apache.org/jira/browse/AMBARI-18326
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to add custom jdbc path to ambari-server classpath
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> bb3f826 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> c595e41 
> 
> Diff: https://reviews.apache.org/r/51663/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51354: Clean up Log Feeder

[Miklos Gergely]

> On Sept. 6, 2016, 5:45 p.m., Robert Nettleton wrote:
> > Overall, the patch looks fine to me.  Just a few minor issues that should 
> > be addressed.
> > 
> > More generally, I would recommend that refactorings like this be submitted 
> > in smaller chunks.  The current patch's size makes a thorough review rather 
> > difficult and time-consuming.  I'm ok with moving forward with the patch 
> > as-is, once these minor issues are settled, but I'd ask that these types of 
> > changes be done in smaller pieces in the future. 
> > 
> > Thanks.

Generally I agree, but in this case we already have a lot of patches that 
should be applied once the branch 2.5 will be available, so we didn't wanted to 
increase the number of patches any more. Furthermore I thought that there are a 
lot of issues with the code, which should be fixed, so this is kind of a 
general clean up, later we may do smaller refactorings.


- Miklos


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51354/#review147866
---


On Sept. 6, 2016, 1:46 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51354/
> ---
> 
> (Updated Sept. 6, 2016, 1:46 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-18246
> https://issues.apache.org/jira/browse/AMBARI-18246
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - long methods were broken up to smaller independent parts
> - narrowed the scope of too widely defined variables
> - fixed visibilities of the methods/fields
> - converted constants / enums to use java conventions for names
> - maximum line length is 120 characters, fixed unnecessary short lines
> - rearranged the functions so that they follow the order of the lifecycle of 
> these components
> - refactored some overcomplicated parts
> - removed unused codes
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  373d743 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigBlock.java
>  287982f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
>  ab371f1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  372c208 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterJSON.java
>  2954106 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
>  7adb468 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  5feb9c4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  c9f5ded 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java
>  48a7f1d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMgr.java
>  b18c9b0 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
>  c9d28bd 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
>  5ba56a5 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
>  a2a9db2 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java
>  c57c028 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
>  ae0cfc0 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
>  PRE-CREATION 

Re: Review Request 51663: Add custom jdbc path to ambari-server classpath

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51663/
---

(Updated Вер. 6, 2016, 7 після полудня)


Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-18326
https://issues.apache.org/jira/browse/AMBARI-18326


Repository: ambari


Description
---

We need to add custom jdbc path to ambari-server classpath


Diffs (updated)
-

  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
bb3f826 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py c595e41 

Diff: https://reviews.apache.org/r/51663/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 51354: Clean up Log Feeder

[Miklos Gergely]

> On Sept. 6, 2016, 5:45 p.m., Robert Nettleton wrote:
> > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/CompressionUtil.java,
> >  line 33
> > 
> >
> > I'm seeing this change throughout as well.  
> > 
> > Why are the loggers being renamed?  I just checked a sample of the 
> > Ambari code, and most classes appear to use LOG as the name.  I'm not sure 
> > there is much reason to change this, as having a common name reduces 
> > confusion for code maintenance across packages.

In the logsearch project it's almost always logger. In java the all capital 
variable name means that it's a constant, and an instance of the Logger class 
has modifiable state, so no constant can be created from it. So even if it's a 
static final variable it's still not a constant.


> On Sept. 6, 2016, 5:45 p.m., Robert Nettleton wrote:
> > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java,
> >  line 1
> > 
> >
> > Minor issue:
> > 
> > Why is the * being removed in these changes?  This breaks the 
> > convention used in the Ambari headers throughout.  
> > 
> > Was this a typo, or is there a specific reason for this change?

In the logsearch project it is almost always one star, so it is consistent with 
this service's code. The license is a "normal" comment, not a javadoc comment, 
that is why it should be only one star.


- Miklos


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51354/#review147866
---


On Sept. 6, 2016, 1:46 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51354/
> ---
> 
> (Updated Sept. 6, 2016, 1:46 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-18246
> https://issues.apache.org/jira/browse/AMBARI-18246
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - long methods were broken up to smaller independent parts
> - narrowed the scope of too widely defined variables
> - fixed visibilities of the methods/fields
> - converted constants / enums to use java conventions for names
> - maximum line length is 120 characters, fixed unnecessary short lines
> - rearranged the functions so that they follow the order of the lifecycle of 
> these components
> - refactored some overcomplicated parts
> - removed unused codes
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  373d743 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigBlock.java
>  287982f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
>  ab371f1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  372c208 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterJSON.java
>  2954106 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
>  7adb468 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  5feb9c4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  c9f5ded 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java
>  48a7f1d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMgr.java
>  b18c9b0 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
>  c9d28bd 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
>  5ba56a5 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
>  a2a9db2 
>   
> 

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/#review147888
---


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 1, 2016, 6:11 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51562/
> ---
> 
> (Updated Sept. 1, 2016, 6:11 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18289
> https://issues.apache.org/jira/browse/AMBARI-18289
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> Negative values are being reported for IOPS in the "system servers" dashboard
> 
> BUG
> This was a dockerized environment. Negative rate values were seen because 
> read/write counters were dropping below the previous values at random times. 
> On further investigation, it revealed that this was due to the docker volume 
> groups present on the host. It is expected of docker containers to add/remove 
> the volume groups during the lifecyle of a container. So, when a volume group 
> goes away, the read/write counters do not contribute to the total counter 
> values, thus making the value go below the last seen value.
> 
> FIX
> Have a provision to discard such "special" disk partitions through a skip 
> pattern. If skipped, they will not contribute to the global counter metric. 
> Individual disk counter metrics can be used to get disk specific counter 
> values.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 3e5d861 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  02f0ce3 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py
>  845b270 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4135d32 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  2503c43 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  383a0de 
> 
> Diff: https://reviews.apache.org/r/51562/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 51663: Add custom jdbc path to ambari-server classpath

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51663/
---

Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-18326
https://issues.apache.org/jira/browse/AMBARI-18326


Repository: ambari


Description
---

We need to add custom jdbc path to ambari-server classpath


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
bb3f826 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py c595e41 

Diff: https://reviews.apache.org/r/51663/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51629/#review147879
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 328)


select component_name from (select component_name, count(*) as num from 
(select component_name, current_state from hostcomponentstate group by 
component_name, current_state) as agg group by component_name) as result where 
num > 1;



ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 381)


Typo, "than" instead of "then"


- Alejandro Fernandez


On Sept. 6, 2016, 12:06 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51629/
> ---
> 
> (Updated Sept. 6, 2016, 12:06 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18309
> https://issues.apache.org/jira/browse/AMBARI-18309
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add db consistency check for hostcomponent tables, for each component we 
> should have only one state.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  f302b8b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  535d74f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  4663310 
> 
> Diff: https://reviews.apache.org/r/51629/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51659: Ambari cannot install HDP from mirror list

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51659/#review147878
---



What is the format of the mirror list?

- Alejandro Fernandez


On Sept. 6, 2016, 5:23 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51659/
> ---
> 
> (Updated Sept. 6, 2016, 5:23 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-18325
> https://issues.apache.org/jira/browse/AMBARI-18325
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should update the code and be able to use a mirror list instead of a 
> single url.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  92d47df 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  6aa0853 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java
>  84929bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  3b5b0a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
>  8d6e6e2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  49d53a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 
> da7f021 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 0606f2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  29776ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
>  3c7c001 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  50d6028 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java
>  b1c643a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java
>  8c629ca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
>  143f9af 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  538fa48 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  3ad1f1f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeUtilTest.java
>  35650a1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
>  dcac986 
> 
> Diff: https://reviews.apache.org/r/51659/diff/
> 
> 
> Testing
> ---
> 
> preview of patch (works on live cluster)
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 51354: Clean up Log Feeder

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51354/#review147866
---


Fix it, then Ship it!




Overall, the patch looks fine to me.  Just a few minor issues that should be 
addressed.

More generally, I would recommend that refactorings like this be submitted in 
smaller chunks.  The current patch's size makes a thorough review rather 
difficult and time-consuming.  I'm ok with moving forward with the patch as-is, 
once these minor issues are settled, but I'd ask that these types of changes be 
done in smaller pieces in the future. 

Thanks.


ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
 (line 1)


Minor issue:

Why is the * being removed in these changes?  This breaks the convention 
used in the Ambari headers throughout.  

Was this a typo, or is there a specific reason for this change?



ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/CompressionUtil.java
 (line 33)


I'm seeing this change throughout as well.  

Why are the loggers being renamed?  I just checked a sample of the Ambari 
code, and most classes appear to use LOG as the name.  I'm not sure there is 
much reason to change this, as having a common name reduces confusion for code 
maintenance across packages.


- Robert Nettleton


On Sept. 6, 2016, 1:46 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51354/
> ---
> 
> (Updated Sept. 6, 2016, 1:46 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-18246
> https://issues.apache.org/jira/browse/AMBARI-18246
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - long methods were broken up to smaller independent parts
> - narrowed the scope of too widely defined variables
> - fixed visibilities of the methods/fields
> - converted constants / enums to use java conventions for names
> - maximum line length is 120 characters, fixed unnecessary short lines
> - rearranged the functions so that they follow the order of the lifecycle of 
> these components
> - refactored some overcomplicated parts
> - removed unused codes
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  373d743 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigBlock.java
>  287982f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
>  ab371f1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  372c208 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterJSON.java
>  2954106 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
>  7adb468 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  5feb9c4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  c9f5ded 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java
>  48a7f1d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMgr.java
>  b18c9b0 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
>  c9d28bd 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
>  5ba56a5 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
>  a2a9db2 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java
>  c57c028 
>   
> 

Re: Review Request 51657: Support round-robin scheduling with failover for monitors with distributed collector

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51657/#review147868
---


Fix it, then Ship it!





ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
(line 103)


There should be a log statement here.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 (line 715)


We should not have these congigs in ams-site cause it is not seriealized on 
monitor side.

Rather this should be in ams-env. It would ask for restarting collector but 
that is limitation casue we do not manage the monitopr configs, in future we 
shoould allow monitor confgis managed from Ambari.


- Sid Wagle


On Sept. 6, 2016, 4:53 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51657/
> ---
> 
> (Updated Sept. 6, 2016, 4:53 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-17456
> https://issues.apache.org/jira/browse/AMBARI-17456
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> _Tasks_:
> 
> - Monitors get a fix set of collector nodes, every restart gets a refresh 
> of available collector nodes
> - Round-robin the write for available collectors
> - Use failed attempts to blacklist collectors
> - Use configurable interval to white-list already black-listed collectors.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 3e5d861 
>   
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini 
> bc2b461 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  02f0ce3 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
>  c2ee448 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 6997108 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/event_definition.py
>  f356b03 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
>  be0608f 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  c02df71 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  fc95aa7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  383a0de 
> 
> Diff: https://reviews.apache.org/r/51657/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 51659: Ambari cannot install HDP from mirror list

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51659/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-18325
https://issues.apache.org/jira/browse/AMBARI-18325


Repository: ambari


Description
---

Ambari should update the code and be able to use a mirror list instead of a 
single url.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 92d47df 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 6aa0853 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java
 84929bf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
 3b5b0a7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
 8d6e6e2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
 49d53a9 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 
da7f021 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
0606f2a 
  
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 
29776ed 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
 3c7c001 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
 50d6028 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java
 b1c643a 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java
 8c629ca 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
 143f9af 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 538fa48 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 3ad1f1f 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeUtilTest.java
 35650a1 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
 dcac986 

Diff: https://reviews.apache.org/r/51659/diff/


Testing
---

preview of patch (works on live cluster)


Thanks,

Dmitro Lisnichenko

Re: Review Request 51657: Support round-robin scheduling with failover for monitors with distributed collector

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51657/
---

(Updated Сен. 6, 2016, 4:53 п.п.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-17456
https://issues.apache.org/jira/browse/AMBARI-17456


Repository: ambari


Description
---

_Tasks_:

- Monitors get a fix set of collector nodes, every restart gets a refresh 
of available collector nodes
- Round-robin the write for available collectors
- Use failed attempts to blacklist collectors
- Use configurable interval to white-list already black-listed collectors.


Diffs
-

  ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
3e5d861 
  ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini 
bc2b461 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 02f0ce3 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
 c2ee448 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
6997108 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/event_definition.py
 f356b03 
  
ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
 be0608f 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 c02df71 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 fc95aa7 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 383a0de 

Diff: https://reviews.apache.org/r/51657/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Review Request 51657: Support round-robin scheduling with failover for monitors with distributed collector

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51657/
---

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-17456
https://issues.apache.org/jira/browse/AMBARI-17456


Repository: ambari


Description
---

_Tasks_:

- Monitors get a fix set of collector nodes, every restart gets a refresh 
of available collector nodes
- Round-robin the write for available collectors
- Use failed attempts to blacklist collectors
- Use configurable interval to white-list already black-listed collectors.


Diffs
-

  ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
3e5d861 
  ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini 
bc2b461 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 02f0ce3 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
 c2ee448 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
6997108 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/event_definition.py
 f356b03 
  
ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
 be0608f 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 c02df71 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 fc95aa7 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 383a0de 

Diff: https://reviews.apache.org/r/51657/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

[Dmytro Sen]

> On Авг. 19, 2016, 6:18 п.п., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py,
> >  line 497
> > 
> >
> > We have sharding on sink side, so we should be giving all hosts to the 
> > sink for that to work.

I'll add it in a separate jira, as of now not all the sinks are ready to read 
all hosts, some of them extect to read only one amd hostname from configs.


> On Авг. 19, 2016, 6:18 п.п., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py,
> >  line 132
> > 
> >
> > AGain we have host:port for the sinks which should be used by sinks why 
> > do we need to do the single host property here ?

I'll add it in a separate jira, as of now not all the sinks are ready to read 
all hosts, some of them extect to read only one amd hostname from configs.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51207/#review146200
---


On Авг. 18, 2016, 3:46 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51207/
> ---
> 
> (Updated Авг. 18, 2016, 3:46 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-18199
> https://issues.apache.org/jira/browse/AMBARI-18199
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On adding additional Collector the webapp address contains wrong hostname.
> 
> java.net.BindException: Port in use: ambari-sid-5.com:6188
> at 
> org.apache.hadoop.http.HttpServer2.openListeners(HttpServer2.java:919)
> at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:856)
> at 
> org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:374)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.startWebApp(ApplicationHistoryServer.java:180)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.serviceStart(ApplicationHistoryServer.java:92)
> at 
> org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.launchAppHistoryServer(ApplicationHistoryServer.java:138)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.main(ApplicationHistoryServer.java:147)
> Caused by: java.net.BindException: Cannot assign requested address
> 
> Stop storing collector hostnames in timeline.metrics.service.webapp.address 
> property
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py e114daa 
>   ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  7352f33 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  c02df71 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  fc95aa7 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
>  fe00140 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  f3643b1 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
>  f0a1d5c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  37e2426 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  d5451b2 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  d0ac3a4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  699c51f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 7133c27 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py
>  5bd2a9e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  2c32f7c 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py
>  5bfbfc6 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 28624fd 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
> ceedb67 
>   
> 

Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

[Dmytro Sen]

> On Авг. 19, 2016, 6:20 п.п., Sid Wagle wrote:
> > The path does everythong expected for the 0.0.0.0:6188 revert and the alert 
> > definition, however not sure about the param.py changes for 1 host these 
> > should not be required since we should be gettign all collectors as 
> > host1:port1,host:2port2 with the changes done for HA.

I'll add it in a separate jira, as of now not all the sinks are ready to read 
all hosts, some of them extect to read only one amd hostname from configs.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51207/#review146203
---


On Авг. 18, 2016, 3:46 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51207/
> ---
> 
> (Updated Авг. 18, 2016, 3:46 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-18199
> https://issues.apache.org/jira/browse/AMBARI-18199
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On adding additional Collector the webapp address contains wrong hostname.
> 
> java.net.BindException: Port in use: ambari-sid-5.com:6188
> at 
> org.apache.hadoop.http.HttpServer2.openListeners(HttpServer2.java:919)
> at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:856)
> at 
> org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:374)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.startWebApp(ApplicationHistoryServer.java:180)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.serviceStart(ApplicationHistoryServer.java:92)
> at 
> org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.launchAppHistoryServer(ApplicationHistoryServer.java:138)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.main(ApplicationHistoryServer.java:147)
> Caused by: java.net.BindException: Cannot assign requested address
> 
> Stop storing collector hostnames in timeline.metrics.service.webapp.address 
> property
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py e114daa 
>   ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  7352f33 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  c02df71 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  fc95aa7 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
>  fe00140 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  f3643b1 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
>  f0a1d5c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  37e2426 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  d5451b2 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  d0ac3a4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  699c51f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 7133c27 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py
>  5bd2a9e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  2c32f7c 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py
>  5bfbfc6 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 28624fd 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
> ceedb67 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 
> 3692691 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_with_bucket.json 
> 54172f3 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 081a66a 
>   
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json
>  7b07d87 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 
> cf84bb7 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 
> 6874db5 
>   
> 

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51629/#review147849
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 332)


Although this query works, this has a dependency on host table. So what if 
the hosts table is clean and only hostcomponentstate has inconsistency?

IMO, self join would be safest bet to find discrepancy.


- Sid Wagle


On Sept. 6, 2016, 12:06 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51629/
> ---
> 
> (Updated Sept. 6, 2016, 12:06 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18309
> https://issues.apache.org/jira/browse/AMBARI-18309
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add db consistency check for hostcomponent tables, for each component we 
> should have only one state.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  f302b8b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  535d74f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  4663310 
> 
> Diff: https://reviews.apache.org/r/51629/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51370: DB consistency check should tolerate services with no configuration

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51370/#review147839
---


Ship it!




Ship It!

- Laszlo Puskas


On Sept. 6, 2016, 2:28 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51370/
> ---
> 
> (Updated Sept. 6, 2016, 2:28 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Oliver 
> Szabo, Sumit Mohanty, Sebastian Toader, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18254
> https://issues.apache.org/jira/browse/AMBARI-18254
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Services with no configs triggered an error in DB consistency checker during 
> Ambari server start. Since the Microsoft R mpack has no configs at all, 
> installing the Microsoft R mpack would result in error during server start. 
> This patch lowers the check to warning level.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  36a2d99 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  a7c77e1 
> 
> Diff: https://reviews.apache.org/r/51370/diff/
> 
> 
> Testing
> ---
> 
> 1. Tested manually
> 2. Wrote a new unit tests
> 3. All unit tests in ambari-servers passed.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 51632: Refactor logsearch portal code

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51632/#review147833
---


Ship it!




Ship It!

- Miklos Gergely


On Sept. 5, 2016, 4:46 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51632/
> ---
> 
> (Updated Sept. 5, 2016, 4:46 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18310
> https://issues.apache.org/jira/browse/AMBARI-18310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - rename/move auditLogRest/manager and serviceLogRest/manager (review board 
> shows it as new added code)
> - using @Inject instead of @Autowired
> - using objects instead of strings for Solr responses (later I want to use 
> spring data solr project to get rid of query generation custom code) ... for 
> that i will fill the Criteria objects with fields as well (now those are only 
> markers)
> - adding converters between requests and search criterias
> - rename and refactor a lot of Vxxx objects, and use them as response objects 
> on endpoints, because of this rest api documentations can show them as they 
> are (not as strings)
> - use javaConfig instead of xml for spring (now security part still in xml, 
> but i will change that later too)
> - move Configuration values into objects, trying to get rid of Property Helper
> 
> Because that is a pretty big change, I created that review, its not done yet 
> (there are still Vxxx objects and also i need to get rid of xml 
> configurations or web.xml as well), also after the documentation was created, 
> there are a lot of unused (or almost duplicated like: 
> componentName/component_name/component) query params there (from the UI), so 
> i will need some manual testing to make sure i can remove them.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml b36c9bb 
>   ambari-logsearch/ambari-logsearch-portal/production/build.js afeea67 
>   ambari-logsearch/ambari-logsearch-portal/production/r.js 6e6ffd0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/managed-schema
>  f58652c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/hadoop_logs/conf/managed-schema
>  3b4cf19 
>   ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/README.md 
> 3cc4915 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/reset_collections.sh
>  7c742c0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/restart_solr.sh
>  bd436bb 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/update_config.sh
>  93e3496 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  15355a1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ConfigHelper.java
>  edb4ffa 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  5235fab 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  142b29b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/Marker.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertyMapper.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/SearchCriteria.java
>  6b74144 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrColumnConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrKerberosConfig.java
>  PRE-CREATION 
>   
> 

Re: Review Request 51370: DB consistency check should tolerate services with no configuration

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51370/#review147830
---




ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 (line 300)


Use annotations to create mocks where possible. EasyMockRule should be used 
for that to work.
(As a reference check the TopologyManagerTest - follow the usage only, not 
the tests ;P)


- Laszlo Puskas


On Aug. 25, 2016, 11:26 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51370/
> ---
> 
> (Updated Aug. 25, 2016, 11:26 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Oliver 
> Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18254
> https://issues.apache.org/jira/browse/AMBARI-18254
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Services with no configs triggered an error in DB consistency checker during 
> Ambari server start. Since the Microsoft R mpack has no configs at all, 
> installing the Microsoft R mpack would result in error during server start. 
> This patch lowers the check to warning level.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  36a2d99 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  a7c77e1 
> 
> Diff: https://reviews.apache.org/r/51370/diff/
> 
> 
> Testing
> ---
> 
> 1. Tested manually
> 2. Wrote a new unit tests
> 3. All unit tests in ambari-servers passed.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 51370: DB consistency check should tolerate services with no configuration

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51370/#review147829
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 89)


Ideally the injector shouldn't be used at all in this class (the fix though 
goes to another patch)


- Laszlo Puskas


On Aug. 25, 2016, 11:26 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51370/
> ---
> 
> (Updated Aug. 25, 2016, 11:26 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Oliver 
> Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18254
> https://issues.apache.org/jira/browse/AMBARI-18254
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Services with no configs triggered an error in DB consistency checker during 
> Ambari server start. Since the Microsoft R mpack has no configs at all, 
> installing the Microsoft R mpack would result in error during server start. 
> This patch lowers the check to warning level.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  36a2d99 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  a7c77e1 
> 
> Diff: https://reviews.apache.org/r/51370/diff/
> 
> 
> Testing
> ---
> 
> 1. Tested manually
> 2. Wrote a new unit tests
> 3. All unit tests in ambari-servers passed.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 51354: Clean up Log Feeder skeleton

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51354/
---

(Updated Sept. 6, 2016, 1:20 p.m.)


Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and 
Robert Nettleton.


Changes
---

Renamed Mgr to Manager, VClassName to ClassName


Bugs: AMBARI-18246
https://issues.apache.org/jira/browse/AMBARI-18246


Repository: ambari


Description
---

- long methods were broken up to smaller independent parts
- narrowed the scope of too widely defined variables
- fixed visibilities of the methods/fields
- converted constants / enums to use java conventions for names
- maximum line length is 120 characters, fixed unnecessary short lines
- rearranged the functions so that they follow the order of the lifecycle of 
these components
- refactored some overcomplicated parts
- removed unused codes


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
 373d743 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigBlock.java
 287982f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
 ab371f1 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
 372c208 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterJSON.java
 2954106 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
 7adb468 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 5feb9c4 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
 c9f5ded 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java
 48a7f1d 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMgr.java
 b18c9b0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
 c9d28bd 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
 5ba56a5 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
 a2a9db2 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java
 c57c028 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
 ae0cfc0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederConstants.java
 09673a0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogfeederScheduler.java
 bc807193 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java
 b5e4eb3 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/DefaultDataFilter.java
 04d2ca4 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/FilterLogData.java
 3a8eae9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/Mapper.java
 906dd25 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
 6dbf8be 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldName.java
 c692a9d 
  

Re: Review Request 51597: Desired state of client component should not be changed in case configuration changes are applied through a "Restart"

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51597/#review147821
---


Ship it!




Ship It!

- Sandor Magyari


On Sept. 2, 2016, 12:11 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51597/
> ---
> 
> (Updated Sept. 2, 2016, 12:11 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18302
> https://issues.apache.org/jira/browse/AMBARI-18302
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Configuration changes are propagated to host components by issuing a restart 
> of the affected components.
> In case of master components this action will start the affected components 
> (regardless it is in INSTALLED or STARTED state) and the desired state will 
> be set to STARTED.
> In Ambari client components are always expected to be in INSTALLED state. 
> However upon configuration changes, the desired state of these components are 
> also set to STARTED. This may be misleading for ambari API users that 
> determine component states by checking the desired state and actual state. 
> (The actual state in case of client components will always be INSTALLED)
> This issue addresses this problem by not updating the desired state when 
> client components are restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  8c8ae10 
> 
> Diff: https://reviews.apache.org/r/51597/diff/
> 
> 
> Testing
> ---
> 
> Unit tests running.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 51354: Clean up Log Feeder skeleton

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51354/
---

(Updated Sept. 6, 2016, 12:13 p.m.)


Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and 
Robert Nettleton.


Changes
---

More Cleanup


Bugs: AMBARI-18246
https://issues.apache.org/jira/browse/AMBARI-18246


Repository: ambari


Description
---

- long methods were broken up to smaller independent parts
- narrowed the scope of too widely defined variables
- fixed visibilities of the methods/fields
- converted constants / enums to use java conventions for names
- maximum line length is 120 characters, fixed unnecessary short lines
- rearranged the functions so that they follow the order of the lifecycle of 
these components
- refactored some overcomplicated parts
- removed unused codes


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
 373d743 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigBlock.java
 287982f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
 ab371f1 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
 372c208 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterJSON.java
 2954106 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
 7adb468 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 5feb9c4 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
 c9f5ded 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java
 48a7f1d 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMgr.java
 b18c9b0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
 c9d28bd 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
 5ba56a5 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
 a2a9db2 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java
 c57c028 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
 ae0cfc0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederConstants.java
 09673a0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogfeederScheduler.java
 bc807193 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/VLogfeederFilter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/VLogfeederFilterWrapper.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java
 b5e4eb3 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/DefaultDataFilter.java
 04d2ca4 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/FilterLogData.java
 3a8eae9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/Mapper.java
 906dd25 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
 6dbf8be 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldName.java
 c692a9d 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldValue.java
 e618261 
  

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

[Vitalyi Brodetskyi]

> On Вер. 5, 2016, 9:41 після полудня, Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java,
> >  line 328
> > 
> >
> > This does't look right, the component needs to be on the smae host as 
> > well. Wouldn't this always return true on a multi-host cluster ?

Sorry, i thought about that but forgot to add it.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51629/#review147782
---


On Вер. 6, 2016, 12:06 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51629/
> ---
> 
> (Updated Вер. 6, 2016, 12:06 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18309
> https://issues.apache.org/jira/browse/AMBARI-18309
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add db consistency check for hostcomponent tables, for each component we 
> should have only one state.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  f302b8b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  535d74f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  4663310 
> 
> Diff: https://reviews.apache.org/r/51629/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51629/
---

(Updated Вер. 6, 2016, 12:06 після полудня)


Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle.


Bugs: AMBARI-18309
https://issues.apache.org/jira/browse/AMBARI-18309


Repository: ambari


Description
---

Add db consistency check for hostcomponent tables, for each component we should 
have only one state.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 f302b8b 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
 535d74f 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 4663310 

Diff: https://reviews.apache.org/r/51629/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 51648: Ambari server start should log the class path being used

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51648/#review147811
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Sept. 6, 2016, 1:03 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51648/
> ---
> 
> (Updated Sept. 6, 2016, 1:03 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18315
> https://issues.apache.org/jira/browse/AMBARI-18315
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari server start should log the class path used while starting the server.
> This will help debug few issues we see where cluster start intermittently
> fails with class not found exception.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  d20b1d7 
> 
> Diff: https://reviews.apache.org/r/51648/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 51648: Ambari server start should log the class path being used

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51648/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18315
https://issues.apache.org/jira/browse/AMBARI-18315


Repository: ambari


Description
---

Ambari server start should log the class path used while starting the server.
This will help debug few issues we see where cluster start intermittently
fails with class not found exception.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 d20b1d7 

Diff: https://reviews.apache.org/r/51648/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

[Akhil PB]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51647/
---

Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath 
Somarajapuram.


Bugs: AMBARI-18313
https://issues.apache.org/jira/browse/AMBARI-18313


Repository: ambari


Description
---

XML diff tool to show changes made.
View capacity scheduler XML.
Queue capacity chart - chart showing capacities of queue using sunburst chart.
Bug fixes.


Diffs
-

  contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/index.html 
2cdfe39 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/javascripts/difflib.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/stylesheets/diffview.css
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
8dd7108 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
 7776452 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js
 f8978c2 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
 64a28343 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 107b377 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
 2690c40 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/xmldiffViewer.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
 c079079 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 447cae0 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 7c62ef0 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 6a6717a 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
 40e3e24 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
0f68a10 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js fd996ae 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 bd875ba 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
2c9609f 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 14625c1 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
 5a54d85 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
 922e27e 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
 873fb6f 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
 d594c7e 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 608758f 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
 809c1c0 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 0c70ee5 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
 66ef1ad 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
 fb34d51 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
 33540e9 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 a7ae9b0 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/sunburstChart.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/xmldiffViewer.hbs
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/bower.json 911856f 

Diff: https://reviews.apache.org/r/51647/diff/


Testing
---

Manual unit testing


Thanks,

Akhil PB

Re: Review Request 51640: After staring rm ha, the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing

[alice alice]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51640/
---

(Updated 九月 6, 2016, 8:01 a.m.)


Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.


Bugs: AMBARI-18312
https://issues.apache.org/jira/browse/AMBARI-18312


Repository: ambari


Description
---

1?when deploying rm ha,the config of 'yarn.resoucemanager.admin.address.rm1' 
and 'yarn.resoucemanager.admin.address.rm2' are missing; so we need to config 
these.


Diffs
-

  
ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step3_controller.js
 36dcfb8 
  ambari-web/app/data/HDP2/rm_ha_properties.js fb1bd13 
  ambari-web/app/utils/configs/rm_ha_config_initializer.js dac68d9 

Diff: https://reviews.apache.org/r/51640/diff/


Testing
---

done it


Thanks,

alice alice

Re: Review Request 51632: Refactor logsearch portal code

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51632/#review147797
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 5, 2016, 6:46 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51632/
> ---
> 
> (Updated Sept. 5, 2016, 6:46 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18310
> https://issues.apache.org/jira/browse/AMBARI-18310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - rename/move auditLogRest/manager and serviceLogRest/manager (review board 
> shows it as new added code)
> - using @Inject instead of @Autowired
> - using objects instead of strings for Solr responses (later I want to use 
> spring data solr project to get rid of query generation custom code) ... for 
> that i will fill the Criteria objects with fields as well (now those are only 
> markers)
> - adding converters between requests and search criterias
> - rename and refactor a lot of Vxxx objects, and use them as response objects 
> on endpoints, because of this rest api documentations can show them as they 
> are (not as strings)
> - use javaConfig instead of xml for spring (now security part still in xml, 
> but i will change that later too)
> - move Configuration values into objects, trying to get rid of Property Helper
> 
> Because that is a pretty big change, I created that review, its not done yet 
> (there are still Vxxx objects and also i need to get rid of xml 
> configurations or web.xml as well), also after the documentation was created, 
> there are a lot of unused (or almost duplicated like: 
> componentName/component_name/component) query params there (from the UI), so 
> i will need some manual testing to make sure i can remove them.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml b36c9bb 
>   ambari-logsearch/ambari-logsearch-portal/production/build.js afeea67 
>   ambari-logsearch/ambari-logsearch-portal/production/r.js 6e6ffd0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/managed-schema
>  f58652c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/hadoop_logs/conf/managed-schema
>  3b4cf19 
>   ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/README.md 
> 3cc4915 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/reset_collections.sh
>  7c742c0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/restart_solr.sh
>  bd436bb 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/update_config.sh
>  93e3496 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  15355a1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ConfigHelper.java
>  edb4ffa 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  5235fab 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  142b29b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/Marker.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertyMapper.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/SearchCriteria.java
>  6b74144 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrColumnConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrKerberosConfig.java
>  PRE-CREATION 
>   
> 

Re: Review Request 51597: Desired state of client component should not be changed in case configuration changes are applied through a "Restart"

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51597/#review147796
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 2, 2016, 2:11 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51597/
> ---
> 
> (Updated Sept. 2, 2016, 2:11 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18302
> https://issues.apache.org/jira/browse/AMBARI-18302
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Configuration changes are propagated to host components by issuing a restart 
> of the affected components.
> In case of master components this action will start the affected components 
> (regardless it is in INSTALLED or STARTED state) and the desired state will 
> be set to STARTED.
> In Ambari client components are always expected to be in INSTALLED state. 
> However upon configuration changes, the desired state of these components are 
> also set to STARTED. This may be misleading for ambari API users that 
> determine component states by checking the desired state and actual state. 
> (The actual state in case of client components will always be INSTALLED)
> This issue addresses this problem by not updating the desired state when 
> client components are restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  8c8ae10 
> 
> Diff: https://reviews.apache.org/r/51597/diff/
> 
> 
> Testing
> ---
> 
> Unit tests running.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>