Re: Review Request 51894: View instance cloning functionality

2016-09-16 Thread Sangeeta Ravindran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51894/
---

(Updated Sept. 16, 2016, 10:59 p.m.)


Review request for Ambari, Alexandr Antonenko and Di Li.


Changes
---

Added new patch with test case


Bugs: AMBARI-18378
https://issues.apache.org/jira/browse/AMBARI-18378


Repository: ambari


Description
---

This task is for providing an option to clone / copy a view instance.
A new "copy" icon will appear next to a view instance. Clicking on this opens 
up the existing view with instance name and display name of the view appended 
with _Copy.
This will be useful when creating multiple view instances with mild 
configuration differences between them.


Diffs (updated)
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
 20bd25c 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
0aefaba 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 239e39e 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html 
924885f 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
 bc441cd 
  
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js
 117021e 

Diff: https://reviews.apache.org/r/51894/diff/


Testing
---

Manual testing with different types of view instances.
Currently there are no automated tests for ambari-admin.


File Attachments (updated)


AMBARI-18378.patch
  
https://reviews.apache.org/media/uploaded/files/2016/09/16/cd344c4a-e087-46a3-953a-f8f8ae6f7764__AMBARI-18378.patch


Thanks,

Sangeeta Ravindran

Re: Review Request 51894: View instance cloning functionality

2016-09-16 Thread Sangeeta Ravindran 


> On Sept. 15, 2016, 9:50 a.m., Alexandr Antonenko wrote:
> > Ship It!

Thanks Alexandr. I have added a new patch with a test case.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51894/#review149041
---


On Sept. 14, 2016, 6:55 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51894/
> ---
> 
> (Updated Sept. 14, 2016, 6:55 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18378
> https://issues.apache.org/jira/browse/AMBARI-18378
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This task is for providing an option to clone / copy a view instance.
> A new "copy" icon will appear next to a view instance. Clicking on this opens 
> up the existing view with instance name and display name of the view appended 
> with _Copy.
> This will be useful when creating multiple view instances with mild 
> configuration differences between them.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
>  20bd25c 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> 0aefaba 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 239e39e 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html
>  924885f 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  bc441cd 
> 
> Diff: https://reviews.apache.org/r/51894/diff/
> 
> 
> Testing
> ---
> 
> Manual testing with different types of view instances.
> Currently there are no automated tests for ambari-admin.
> 
> 
> File Attachments
> 
> 
> AMBARI-18378.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/14/f1299304-2bad-42d2-8509-831aba536e9a__AMBARI-18378.patch
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 51969: AMBARI-18413: RecoveryManager may be logging too often

2016-09-16 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51969/#review149289
---


Ship it!




Ship It!

- Sumit Mohanty


On Sept. 16, 2016, 9:37 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51969/
> ---
> 
> (Updated Sept. 16, 2016, 9:37 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18413
> https://issues.apache.org/jira/browse/AMBARI-18413
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18413: RecoveryManager may be logging too often
> 
> **Issue: **
> Heartbeat interval in Controller.py is inversely proportional to the number 
> of nodes in the cluster. For a small cluster, with 1-9 nodes, the frequency 
> of heartbeat is 1 second. This causes get_recovery_commands() to be called 
> every second thereby logging every second in 
> RecoveryManager::requires_recovery(component).
> 
> **Fix: **
> In the heartbeat loop in Controller.py, call get_recovery_commands() every 
> HEARTBEAT_IDLE_INTERVAL_DEFAULT_MAX_SEC seconds which is currently set to 10 
> seconds.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 
> a05011a70aeb02e7336e796c8481ace21c095d7d 
> 
> Diff: https://reviews.apache.org/r/51969/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.938s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.038s]
> [INFO] Ambari Web  SUCCESS [49.323s]
> [INFO] Ambari Views .. SUCCESS [1.238s]
> [INFO] Ambari Admin View . SUCCESS [8.422s]
> [INFO] ambari-metrics  SUCCESS [0.674s]
> [INFO] Ambari Metrics Common . SUCCESS [3.808s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.957s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.151s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.343s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [3.463s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.550s]
> [INFO] Ambari Metrics Collector .. SUCCESS [11.210s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.094s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.992s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:20.958s]
> [INFO] Ambari Server . SUCCESS [3:20.499s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.272s]
> [INFO] Ambari Agent .. SUCCESS [28.364s]
> [INFO] Ambari Client . SUCCESS [0.068s]
> [INFO] Ambari Python Client .. SUCCESS [0.976s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.604s]
> [INFO] Ambari Shell .. SUCCESS [0.077s]
> [INFO] Ambari Python Shell ... SUCCESS [0.858s]
> [INFO] Ambari Groovy Shell ... SUCCESS [1.145s]
> [INFO] ambari-logsearch .. SUCCESS [0.270s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.281s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.407s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.756s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [4.872s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.103s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 7:09.767s
> [INFO] Finished at: Fri Sep 16 12:46:20 PDT 2016
> [INFO] Final Memory: 304M/1196M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipSurefireTests **
> 
> --
> Ran 444 tests in 23.052s
> 
> OK
> 
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 148 licence.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
>

Re: Review Request 51813: Modify the AMS stack scripts to support distributed collector

2016-09-16 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51813/#review149268
---


Ship it!




Ship It!

- Aravindan Vijayan


On Sept. 16, 2016, 1:06 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51813/
> ---
> 
> (Updated Sept. 16, 2016, 1:06 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-17457
> https://issues.apache.org/jira/browse/AMBARI-17457
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix service check to andle AMS HA
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 
> 7b4e8f5 
>   ambari-common/src/main/python/ambari_commons/parallel_processing.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
>  e8c12ed 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  22024bb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
>  ddd3e42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metrics_grafana_datasource.json.j2
>  678d769 
> 
> Diff: https://reviews.apache.org/r/51813/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 51969: AMBARI-18413: RecoveryManager may be logging too often

2016-09-16 Thread Nahappan Somasundaram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51969/
---

Review request for Ambari, Sumit Mohanty and Sebastian Toader.


Bugs: AMBARI-18413
https://issues.apache.org/jira/browse/AMBARI-18413


Repository: ambari


Description
---

AMBARI-18413: RecoveryManager may be logging too often

**Issue: **
Heartbeat interval in Controller.py is inversely proportional to the number of 
nodes in the cluster. For a small cluster, with 1-9 nodes, the frequency of 
heartbeat is 1 second. This causes get_recovery_commands() to be called every 
second thereby logging every second in 
RecoveryManager::requires_recovery(component).

**Fix: **
In the heartbeat loop in Controller.py, call get_recovery_commands() every 
HEARTBEAT_IDLE_INTERVAL_DEFAULT_MAX_SEC seconds which is currently set to 10 
seconds.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/Controller.py 
a05011a70aeb02e7336e796c8481ace21c095d7d 

Diff: https://reviews.apache.org/r/51969/diff/


Testing
---

** 1. mvn clean install -DskipTests **
[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.938s]
[INFO] Apache Ambari Project POM . SUCCESS [0.038s]
[INFO] Ambari Web  SUCCESS [49.323s]
[INFO] Ambari Views .. SUCCESS [1.238s]
[INFO] Ambari Admin View . SUCCESS [8.422s]
[INFO] ambari-metrics  SUCCESS [0.674s]
[INFO] Ambari Metrics Common . SUCCESS [3.808s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.957s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.151s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.343s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [3.463s]
[INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.550s]
[INFO] Ambari Metrics Collector .. SUCCESS [11.210s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.094s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.992s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:20.958s]
[INFO] Ambari Server . SUCCESS [3:20.499s]
[INFO] Ambari Functional Tests ... SUCCESS [2.272s]
[INFO] Ambari Agent .. SUCCESS [28.364s]
[INFO] Ambari Client . SUCCESS [0.068s]
[INFO] Ambari Python Client .. SUCCESS [0.976s]
[INFO] Ambari Groovy Client .. SUCCESS [2.604s]
[INFO] Ambari Shell .. SUCCESS [0.077s]
[INFO] Ambari Python Shell ... SUCCESS [0.858s]
[INFO] Ambari Groovy Shell ... SUCCESS [1.145s]
[INFO] ambari-logsearch .. SUCCESS [0.270s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.281s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.407s]
[INFO] Ambari Logsearch Portal ... SUCCESS [7.756s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [4.872s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.103s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 7:09.767s
[INFO] Finished at: Fri Sep 16 12:46:20 PDT 2016
[INFO] Final Memory: 304M/1196M
[INFO] 

** 2. mvn test -DskipSurefireTests **
--
Ran 268 tests in 6.688s

OK
--
Total run:1126
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:09.146s
[INFO] Finished at: Fri Sep 16 13:21:43 PDT 2016
[INFO] Final Memory: 47M/821M
[INFO] 

** 3. Manual tests **
* Setup a VM with the latest trunk build and replaced ** 
/usr/lib/python2.6/site-packages/ambari_agent/Controller.py ** with the fix. 
* Enabled auto-start for all services
* Deployed a few services and observed that ** tail -f 
/var/log/ambari-agent/ambari-agent.log | grep RecoveryManager ** spewed lot 
less

Re: Review Request 51971: AMBARI-17456 : Support round-robin scheduling with failover for monitors with distributed collector (Commit 2)

2016-09-16 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51971/#review149259
---


Ship it!




Ship It!

- Sid Wagle


On Sept. 16, 2016, 8:16 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51971/
> ---
> 
> (Updated Sept. 16, 2016, 8:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17456
> https://issues.apache.org/jira/browse/AMBARI-17456
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Follow up bug fix for AMBARI-17456 (https://reviews.apache.org/r/51657/)
> 
> BUG
> The config_reader was expecting a string like "host1,host2" for 
> metrics_server_hosts, but params.py was passing in "['host1','host2']". Hence 
> emitter got bad hostnames like "['host1'" and "'host2']" after split.
> 
> Also, brought back the "hostname" config in metric_monitor.ini since that can 
> be used to pass in the correct hostname as managed by ambari. That is used to 
> denote the current host rather than the collector host.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  2e8a170 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  b011fd5 
> 
> Diff: https://reviews.apache.org/r/51971/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 51971: AMBARI-17456 : Support round-robin scheduling with failover for monitors with distributed collector (Commit 2)

2016-09-16 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51971/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-17456
https://issues.apache.org/jira/browse/AMBARI-17456


Repository: ambari


Description
---

Follow up bug fix for AMBARI-17456 (https://reviews.apache.org/r/51657/)

BUG
The config_reader was expecting a string like "host1,host2" for 
metrics_server_hosts, but params.py was passing in "['host1','host2']". Hence 
emitter got bad hostnames like "['host1'" and "'host2']" after split.

Also, brought back the "hostname" config in metric_monitor.ini since that can 
be used to pass in the correct hostname as managed by ambari. That is used to 
denote the current host rather than the collector host.


Diffs
-

  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 2e8a170 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 b011fd5 

Diff: https://reviews.apache.org/r/51971/diff/


Testing
---

Manually tested
Unit tests pass.


Thanks,

Aravindan Vijayan

Re: Review Request 51961: Prerequisite checks should only check services that are getting upgraded

2016-09-16 Thread Nate Cole 


> On Sept. 16, 2016, 1:54 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java,
> >  line 161
> > 
> >
> > %s but no param?

Ha!  Good catch; will fix.


> On Sept. 16, 2016, 1:54 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java,
> >  line 153
> > 
> >
> > Do we use a case here instead to catch future updates to this enum?

The other two types both specify services, so it seemed a bit overkill to make 
it a case.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51961/#review149223
---


On Sept. 16, 2016, 1:25 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51961/
> ---
> 
> (Updated Sept. 16, 2016, 1:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-18391
> https://issues.apache.org/jira/browse/AMBARI-18391
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updates prereq checks for specific services for VDF.
> 
> There is another anti-pattern discovered here which will be addressed in a 
> future patch: we are requiring super.isAllowed() in subclasses.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  4bc64d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  25aa62b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  6d5f23e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  55c8815 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheckTest.java
>  bfe0c3e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java
>  87d4167 
> 
> Diff: https://reviews.apache.org/r/51961/diff/
> 
> 
> Testing
> ---
> 
> Tests run: 4680, Failures: 0, Errors: 0, Skipped: 36
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36:29.565s
> [INFO] Finished at: Fri Sep 16 13:14:35 EDT 2016
> [INFO] Final Memory: 35M/665M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 51961: Prerequisite checks should only check services that are getting upgraded

2016-09-16 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51961/#review149223
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 (line 151)


Do we use a case here instead to catch future updates to this enum?



ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 (line 159)


%s but no param?


- Jonathan Hurley


On Sept. 16, 2016, 1:25 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51961/
> ---
> 
> (Updated Sept. 16, 2016, 1:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-18391
> https://issues.apache.org/jira/browse/AMBARI-18391
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updates prereq checks for specific services for VDF.
> 
> There is another anti-pattern discovered here which will be addressed in a 
> future patch: we are requiring super.isAllowed() in subclasses.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  4bc64d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  25aa62b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  6d5f23e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  55c8815 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheckTest.java
>  bfe0c3e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java
>  87d4167 
> 
> Diff: https://reviews.apache.org/r/51961/diff/
> 
> 
> Testing
> ---
> 
> Tests run: 4680, Failures: 0, Errors: 0, Skipped: 36
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36:29.565s
> [INFO] Finished at: Fri Sep 16 13:14:35 EDT 2016
> [INFO] Final Memory: 35M/665M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 51961: Prerequisite checks should only check services that are getting upgraded

2016-09-16 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51961/#review149217
---


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 16, 2016, 5:25 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51961/
> ---
> 
> (Updated Sept. 16, 2016, 5:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-18391
> https://issues.apache.org/jira/browse/AMBARI-18391
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updates prereq checks for specific services for VDF.
> 
> There is another anti-pattern discovered here which will be addressed in a 
> future patch: we are requiring super.isAllowed() in subclasses.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  4bc64d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  25aa62b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  6d5f23e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  55c8815 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheckTest.java
>  bfe0c3e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java
>  87d4167 
> 
> Diff: https://reviews.apache.org/r/51961/diff/
> 
> 
> Testing
> ---
> 
> Tests run: 4680, Failures: 0, Errors: 0, Skipped: 36
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36:29.565s
> [INFO] Finished at: Fri Sep 16 13:14:35 EDT 2016
> [INFO] Final Memory: 35M/665M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 51961: Prerequisite checks should only check services that are getting upgraded

2016-09-16 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51961/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
Jonathan Hurley.


Bugs: AMBARI-18391
https://issues.apache.org/jira/browse/AMBARI-18391


Repository: ambari


Description
---

Updates prereq checks for specific services for VDF.

There is another anti-pattern discovered here which will be addressed in a 
future patch: we are requiring super.isAllowed() in subclasses.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 4bc64d4 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 25aa62b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
 6d5f23e 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
 55c8815 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheckTest.java
 bfe0c3e 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java
 87d4167 

Diff: https://reviews.apache.org/r/51961/diff/


Testing
---

Tests run: 4680, Failures: 0, Errors: 0, Skipped: 36

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 36:29.565s
[INFO] Finished at: Fri Sep 16 13:14:35 EDT 2016
[INFO] Final Memory: 35M/665M
[INFO] 


Thanks,

Nate Cole

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-16 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51906/#review149214
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 (line 188)


Why is this needed ? There is already a action="create_on_execute"


- Sebastian Toader


On Sept. 16, 2016, 4:57 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51906/
> ---
> 
> (Updated Sept. 16, 2016, 4:57 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18349
> https://issues.apache.org/jira/browse/AMBARI-18349
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A. Add `role_command_order.json` to make sure name node, node manager, 
> resource manager are started before running Microsoft R service check
> B. Create `/user/RevoShare` on HDFS if necessary when starting services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  ba9c8fb 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/service_check.py
>  547476b 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/role_command_order.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51906/diff/
> 
> 
> Testing
> ---
> 
> A. Role command order
>1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
>2. Create cluster via web UI with HDFS, YARN, ZooKeeper, Microsoft R
>3. Verify name node, node manager, resource manager, data node are started 
> before Microsoft R service check
>4. Verify stage_id for NAMENODE-START, NODEMANAGER-START, 
> RESOURCEMANAGER-START are smaller than stage_id for 
> MICROSOFT_R_SERVICE_CHECK-SERVICE_CHECK:
> ```
> select request_id, stage_id, task_id, role, role_command from 
> host_role_command order by request_id, stage_id, task_id;
> ```
> B. RevoShare
>1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
>2. Create cluster via blueprint with HDFS, YARN, ZooKeeper, Microsoft R
>3. Verify `/user/RevoShare` directory exists: `hdfs dfs -ls /user/`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 51754: AMBARI-18337 Syntax Error in Ambari HAWQ Unit test with Python 2.6

2016-09-16 Thread Alexander Denissov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51754/#review149208
---


Ship it!




Ship It!

- Alexander Denissov


On Sept. 9, 2016, 1:21 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51754/
> ---
> 
> (Updated Sept. 9, 2016, 1:21 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-18337
> https://issues.apache.org/jira/browse/AMBARI-18337
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With Python 2.6, ` {"A", "B"}  ` syntax isn't allowed.
> 
> Ref. https://docs.python.org/2/library/stdtypes.html#set-types-set-frozenset
> 
> ```
> As of Python 2.7, non-empty sets (not frozensets) can be created by placing a 
> comma-separated list of elements within braces, for example: {'jack', 
> 'sjoerd'}, in addition to the set constructor.
> ```
> 
> Error
> 
> ```
> Traceback (most recent call last):
>   File "unitTests.py", line 129, in stack_test_executor
> modules]
>   File "/usr/lib64/python2.6/unittest.py", line 575, in loadTestsFromName
> module = __import__('.'.join(parts_copy))
>   File 
> "/tmp/ambari/ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py",
>  li
> ne 646
> self.assertFalse({'HAWQMASTER', 'HAWQSTANDBY'}.issubset(hostComponents))
>   ^
> SyntaxError: invalid syntax
> ```
> 
> 
> Diffs
> -
> 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> 71c109f 
> 
> Diff: https://reviews.apache.org/r/51754/diff/
> 
> 
> Testing
> ---
> 
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12827665/AMBARI-18337.patch
> against trunk revision .
> 
> +1 @author. The patch does not contain any @author tags.
> 
> +1 tests included. The patch appears to include 1 new or modified test files.
> 
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> 
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> 
> +1 core tests. The patch passed unit tests in ambari-server.
> 
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/8623//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/8623//console
> 
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-09-16 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51815/#review149205
---



Thanks for providing this patch.  This is a feature in Blueprints that is 
sorely needed, and will be beneficial for Blueprints generally. 

I would ask, if possible, that some consideration be put into making the XML 
syntax for specifying conditions on dependencies a little more generic, and 
then making the two conditional types implemented here be subtypes of the 
generic type.  My thinking here is that having this be just a little more 
flexible may benefit Blueprints in the future, as more conditional types may be 
required for different usage types.  

I agree completely that conditions based on configuration are the most common, 
and the two conditional types implemented are likely to be used in a variety of 
ways across the stacks, but it would be great if these were treated as specific 
sub-types of the condition, to make future conditions easier to add. 

Can you please add Jayush Lunia to this review list?  I believe he's looking at 
some stack-level refactorings, so it would be good to get his input as well.

Thanks.


ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
 (line 37)


I think this is a great idea, but I'd recommend a slightly more generic 
approach.

Adding conditional dependencies is a great idea, and I would agree that by 
far that the most common case is configuration types. 

That being said, it might be a good idea to consider making this a little 
more generic, and then having the 'config-type-exists' and 
'property-value-equals' conditions be specific cases of that generic type. 

It might be useful to add a new 'condition-type' field to 
DependencyConditionInfo, so that the stacks indicate the type of condition.  
This will make it easier to visually parse the stacks in the future, and allows 
for more conditional types to be added.  

Having this be a little more generic would allow future conditional types 
to be added without too much effort.  Off the top of my head, I can't think of 
any, but I would expect that future use cases might open up possibilities of 
declaring conditions in a variety of ways, to simplify stack development and 
maintenance.



ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
 (line 87)


Minor issue:

I couldn't find any usages of this field.  Is this used in the unit tests?



ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
 (line 357)


Minor issue:

Could you maybe rename this method, so that the intent of the test is a 
little clearer?  

Maybe something to indicate that the conditionally dependent component is 
missing.

Sorry to nit-pick here, but that might make it easier to maintain this test 
over time. 

Thanks.


- Robert Nettleton


On Sept. 13, 2016, 9:28 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51815/
> ---
> 
> (Updated Sept. 13, 2016, 9:28 p.m.)
> 
> 
> Review request for Ambari, Shantanu Mundkur, Di Li, Juanjo  Marron, Laszlo 
> Puskas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18355
> https://issues.apache.org/jira/browse/AMBARI-18355
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently stack definitions do not list conditional dependencies, adding 
> those to the stack definitions would make it easy to validate errors in case 
> of blueprint deployment. Please refer to document attached to Jira
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java
>  e3db662 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  a5f33ff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 65d166a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  b1de8ef 
> 
> Diff: https://reviews.apache.org/r/51815/diff/
> 
> 
> Testing
> ---
> 
> Written Junit test cases. Perfomred manual testing to check the Namenode HA 
> component dependency. Was able to proceed with the installation for valid 
> blueprint. and got validation error message while registering blueprint when 
> the Blueprint did not satisfy the conditional dependencies.
> 
> 
>

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-16 Thread Attila Doroszlai 


> On Sept. 16, 2016, 9:14 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py,
> >  line 107
> > 
> >
> > We should not rely on the availability of NN as only HDFS has NN other 
> > DFS implementation don't.
> > 
> > I think it's safer to check if ```params.default_fs``` is defined as 
> > that tells wether there is a DFS available and how that can be referred to.
> > 
> > When testing this please ensure that you test with both webhdfs enables 
> > and disabled (see ```params.is_webhdfs_enabled```, dfs.webhdfs.enabled 
> > config property)

Thank you for the webhdfs hint.  According to my tests, "create_on_execute" is 
enough in itself if webhdfs is enabled, but the "execute" step is necessary if 
it is disabled.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51906/#review149175
---


On Sept. 16, 2016, 4:57 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51906/
> ---
> 
> (Updated Sept. 16, 2016, 4:57 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18349
> https://issues.apache.org/jira/browse/AMBARI-18349
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A. Add `role_command_order.json` to make sure name node, node manager, 
> resource manager are started before running Microsoft R service check
> B. Create `/user/RevoShare` on HDFS if necessary when starting services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  ba9c8fb 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/service_check.py
>  547476b 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/role_command_order.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51906/diff/
> 
> 
> Testing
> ---
> 
> A. Role command order
>1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
>2. Create cluster via web UI with HDFS, YARN, ZooKeeper, Microsoft R
>3. Verify name node, node manager, resource manager, data node are started 
> before Microsoft R service check
>4. Verify stage_id for NAMENODE-START, NODEMANAGER-START, 
> RESOURCEMANAGER-START are smaller than stage_id for 
> MICROSOFT_R_SERVICE_CHECK-SERVICE_CHECK:
> ```
> select request_id, stage_id, task_id, role, role_command from 
> host_role_command order by request_id, stage_id, task_id;
> ```
> B. RevoShare
>1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
>2. Create cluster via blueprint with HDFS, YARN, ZooKeeper, Microsoft R
>3. Verify `/user/RevoShare` directory exists: `hdfs dfs -ls /user/`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 51814: Update sinks to read multiple collector hostnames from configs

2016-09-16 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51814/
---

(Updated Сен. 16, 2016, 2:59 п.п.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-18362
https://issues.apache.org/jira/browse/AMBARI-18362


Repository: ambari


Description
---

Update sinks to read multiple collector hostnames from configs


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java
 da61d83 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrAmsClient.java
 85ea69d 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 426eb42 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
 7fadeb2 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java
 ccaa574 
  
ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
 1b36e9a 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 b720ba9 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 f44ca35 
  
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
 9c16564 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 73381d9 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 0d3b770 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 9082e70 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 f6531c8 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 4618618 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
 4c111f1 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2
 3cd535e 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
 586cd47 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
 b839eb8 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
 d3a9294 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2
 b960296 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 49b684b 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
 e62ce9e 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
 818 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 5f78a1f 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2
 88be81b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2
 3d71867 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2
 ba44af5 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2
 77f128b 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 ab4d701 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
 6cc85f4 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 f631ac9 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 f96aeeb 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2
 a9760cb 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
 1f0875f 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 49a14d0

Re: Review Request 51910: Update version-builder to include unique element

2016-09-16 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51910/#review149202
---


Ship it!




Ship It!

- Nate Cole


On Sept. 15, 2016, 12:08 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51910/
> ---
> 
> (Updated Sept. 15, 2016, 12:08 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18397
> https://issues.apache.org/jira/browse/AMBARI-18397
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Previous patch added a unique element to repositories that allows the backend 
> to determine whether a URL can be reused for other repos (HDP cannot be 
> reused, therefore is unique.  HDP-UTILS *can* be reused, therefore 
> unique=false).
> 
> Now, we need to add that to the VDF builder before we hand to RE to implement 
> this element.
> 
> This entails updating the {{contrib/version-builder}} script and making sure 
> existing VDF without the element will still work (they better).
> 
> 
> Diffs
> -
> 
>   contrib/version-builder/example.py b9cdf56 
>   contrib/version-builder/example.sh bc76fd0 
>   contrib/version-builder/version_builder.py 2c07b0c 
> 
> Diff: https://reviews.apache.org/r/51910/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-16 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51906/
---

(Updated Sept. 16, 2016, 4:57 p.m.)


Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, and 
Sebastian Toader.


Changes
---

* Extracted dir creation to a separate method
 * Replaced `has_namenode` condition with `default_fs` check
 * Add `"execute"` call (needed for the case when WebHDFS is disabled)
 * Also added `"execute"` call to `service_check.py`


Bugs: AMBARI-18349
https://issues.apache.org/jira/browse/AMBARI-18349


Repository: ambari


Description
---

A. Add `role_command_order.json` to make sure name node, node manager, resource 
manager are started before running Microsoft R service check
B. Create `/user/RevoShare` on HDFS if necessary when starting services


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 ba9c8fb 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/service_check.py
 547476b 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/role_command_order.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/51906/diff/


Testing
---

A. Role command order
   1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
   2. Create cluster via web UI with HDFS, YARN, ZooKeeper, Microsoft R
   3. Verify name node, node manager, resource manager, data node are started 
before Microsoft R service check
   4. Verify stage_id for NAMENODE-START, NODEMANAGER-START, 
RESOURCEMANAGER-START are smaller than stage_id for 
MICROSOFT_R_SERVICE_CHECK-SERVICE_CHECK:
```
select request_id, stage_id, task_id, role, role_command from host_role_command 
order by request_id, stage_id, task_id;
```
B. RevoShare
   1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
   2. Create cluster via blueprint with HDFS, YARN, ZooKeeper, Microsoft R
   3. Verify `/user/RevoShare` directory exists: `hdfs dfs -ls /user/`


Thanks,

Attila Doroszlai

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review149199
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 16, 2016, 1:44 p.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated Sept. 16, 2016, 1:44 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread wang yaoxin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/
---

(Updated 九月 16, 2016, 1:44 p.m.)


Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.


Changes
---

the new patch


Bugs: AMBARI-18374
https://issues.apache.org/jira/browse/AMBARI-18374


Repository: ambari


Description
---

when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
null

2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
Operation(Request from server), RequestType(POST), 
url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
Accepted), Command(RESTART), Cluster name(null)

2016-09-13T17:29:22.042+0800, User(admin), 
Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
RequestId(15)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 075e328 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 1074f0e 

Diff: https://reviews.apache.org/r/51843/diff/


Testing
---

done!


Thanks,

wang yaoxin

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review149198
---




ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 (line 22)


Hi Wang,

Could you please re-post your patch?  

I just attempted to review, and the patch appears to be corrupted, as 
Sandor mentioned.

Thanks.


- Robert Nettleton


On Sept. 16, 2016, 12:54 p.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated Sept. 16, 2016, 12:54 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread Sandor Magyari 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review149197
---


Ship it!




Could you please paste the unitest result to 'Testing Done' section. Aslo the 
latest patch seems to be correupted.

- Sandor Magyari


On Sept. 16, 2016, 12:54 p.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated Sept. 16, 2016, 12:54 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 51813: Modify the AMS stack scripts to support distributed collector

2016-09-16 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51813/
---

(Updated Сен. 16, 2016, 1:06 п.п.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-17457
https://issues.apache.org/jira/browse/AMBARI-17457


Repository: ambari


Description
---

Fix service check to andle AMS HA


Diffs (updated)
-

  ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 7b4e8f5 
  ambari-common/src/main/python/ambari_commons/parallel_processing.py 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
 e8c12ed 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 22024bb 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
 ddd3e42 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metrics_grafana_datasource.json.j2
 678d769 

Diff: https://reviews.apache.org/r/51813/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 51382: AMBARI-18250

2016-09-16 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51382/#review149192
---



Can this review be closed now? If so, please go ahead and close it.

- Jonathan Hurley


On Aug. 24, 2016, 2:25 p.m., Jay SenSharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51382/
> ---
> 
> (Updated Aug. 24, 2016, 2:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-18250
> https://issues.apache.org/jira/browse/AMBARI-18250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Pig View Caching issue causes File does not exist: 
> /user//pig/jobs/job_id/stdout and stderr intermittently
> 
> 
> Diffs
> -
> 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/initialize.js 38ee093 
> 
> Diff: https://reviews.apache.org/r/51382/diff/
> 
> 
> Testing
> ---
> 
> done. Issue is intermittent and can not be reproduced everytime.
> 
> 
> Thanks,
> 
> Jay SenSharma
> 
>

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread wang yaoxin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/
---

(Updated 九月 16, 2016, 12:54 p.m.)


Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.


Bugs: AMBARI-18374
https://issues.apache.org/jira/browse/AMBARI-18374


Repository: ambari


Description
---

when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
null

2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
Operation(Request from server), RequestType(POST), 
url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
Accepted), Command(RESTART), Cluster name(null)

2016-09-13T17:29:22.042+0800, User(admin), 
Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
RequestId(15)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 075e328 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 1074f0e 

Diff: https://reviews.apache.org/r/51843/diff/


Testing
---

done!


Thanks,

wang yaoxin

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread wang yaoxin 


> On 九月 16, 2016, 10:58 a.m., Oliver Szabo wrote:
> > after applying the diff i got:
> > [ERROR] 
> > /Users/oszabo/prj/ambari/ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java:[103,5]
> >  cannot find symbol
> >   symbol:   class Map
> >   location: class 
> > org.apache.ambari.server.audit.request.eventcreator.RequestEventCreator
> >   
> > I think java.util.Map is not imported in the RequestEventCreator

Hi ,Oliver, thank you for your kind-hearted offer, I have attach a new patch 
AMBARI-18374_02.patch


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review149186
---


On 九月 16, 2016, 10:06 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated 九月 16, 2016, 10:06 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review149186
---



after applying the diff i got:
[ERROR] 
/Users/oszabo/prj/ambari/ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java:[103,5]
 cannot find symbol
  symbol:   class Map
  location: class 
org.apache.ambari.server.audit.request.eventcreator.RequestEventCreator
  
I think java.util.Map is not imported in the RequestEventCreator

- Oliver Szabo


On Sept. 16, 2016, 10:06 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated Sept. 16, 2016, 10:06 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread wang yaoxin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/
---

(Updated 九月 16, 2016, 10:06 a.m.)


Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.


Bugs: AMBARI-18374
https://issues.apache.org/jira/browse/AMBARI-18374


Repository: ambari


Description
---

when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
null

2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
Operation(Request from server), RequestType(POST), 
url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
Accepted), Command(RESTART), Cluster name(null)

2016-09-13T17:29:22.042+0800, User(admin), 
Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
RequestId(15)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 075e328 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 1074f0e 

Diff: https://reviews.apache.org/r/51843/diff/


Testing
---

done!


Thanks,

wang yaoxin

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-16 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51906/#review149175
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 (line 107)


We should not rely on the availability of NN as only HDFS has NN other DFS 
implementation don't.

I think it's safer to check if ```params.default_fs``` is defined as that 
tells wether there is a DFS available and how that can be referred to.

When testing this please ensure that you test with both webhdfs enables and 
disabled (see ```params.is_webhdfs_enabled```, dfs.webhdfs.enabled config 
property)



ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 (lines 107 - 116)


Factor this out into a separate method


- Sebastian Toader


On Sept. 15, 2016, 1:45 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51906/
> ---
> 
> (Updated Sept. 15, 2016, 1:45 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18349
> https://issues.apache.org/jira/browse/AMBARI-18349
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A. Add `role_command_order.json` to make sure name node, node manager, 
> resource manager are started before running Microsoft R service check
> B. Create `/user/RevoShare` on HDFS if necessary when starting services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  ba9c8fb 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/role_command_order.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51906/diff/
> 
> 
> Testing
> ---
> 
> A. Role command order
>1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
>2. Create cluster via web UI with HDFS, YARN, ZooKeeper, Microsoft R
>3. Verify name node, node manager, resource manager, data node are started 
> before Microsoft R service check
>4. Verify stage_id for NAMENODE-START, NODEMANAGER-START, 
> RESOURCEMANAGER-START are smaller than stage_id for 
> MICROSOFT_R_SERVICE_CHECK-SERVICE_CHECK:
> ```
> select request_id, stage_id, task_id, role, role_command from 
> host_role_command order by request_id, stage_id, task_id;
> ```
> B. RevoShare
>1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
>2. Create cluster via blueprint with HDFS, YARN, ZooKeeper, Microsoft R
>3. Verify `/user/RevoShare` directory exists: `hdfs dfs -ls /user/`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>