Re: Review Request 51894: View instance cloning functionality

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51894/#review149364
---


Ship it!




Ship It!

- Alexandr Antonenko


On Sept. 16, 2016, 10:59 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51894/
> ---
> 
> (Updated Sept. 16, 2016, 10:59 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18378
> https://issues.apache.org/jira/browse/AMBARI-18378
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This task is for providing an option to clone / copy a view instance.
> A new "copy" icon will appear next to a view instance. Clicking on this opens 
> up the existing view with instance name and display name of the view appended 
> with _Copy.
> This will be useful when creating multiple view instances with mild 
> configuration differences between them.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
>  20bd25c 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> 0aefaba 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 239e39e 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html
>  924885f 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  bc441cd 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js
>  117021e 
> 
> Diff: https://reviews.apache.org/r/51894/diff/
> 
> 
> Testing
> ---
> 
> Manual testing with different types of view instances.
> Currently there are no automated tests for ambari-admin.
> 
> 
> File Attachments
> 
> 
> AMBARI-18378.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/16/cd344c4a-e087-46a3-953a-f8f8ae6f7764__AMBARI-18378.patch
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 49802: Host Namenode Rebalance HDFS failed

[wang yaoxin]

> On 九月 14, 2016, 5:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py,
> >  line 283
> > 
> >
> > Why would the json data be None?

Rebalance HDFS in the host web view, it will not show the Rebalance HDFS dialog 
to fill the disk capacity value, so the default threshold should be the default 
value, but the namenode.py not given a default value, so rebalance hdfs wil 
fail. It would be difficult to change from fore-end, moreover, the change may 
not fit into fore-end's design ,and I sense the bug is a serious issue, so I 
think it is better to give it the default value in the namenode.py .


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49802/#review148934
---


On 九月 14, 2016, 8:07 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49802/
> ---
> 
> (Updated 九月 14, 2016, 8:07 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, JaimejucoummaUW 
> JaimejucoummaUW, Zhe (Joe) Wang, Kuldeep Mishra, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17546
> https://issues.apache.org/jira/browse/AMBARI-17546
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> the host view ,excute namenode rebalance HDFS, json none lead fail
> 
> Rebalance HDFS in the host web view , it will not show the Rebalance HDFS 
> dialog to fill the disk capacity value, so rebalance hdfs wil fail. It would 
> be difficult to change from fore-end, moreover, the change may not fit into 
> fore-end's design ,and I sense the bug is a serious issue, so I think it is 
> better to give it the default value in the namenode.py .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  df02311 
> 
> Diff: https://reviews.apache.org/r/49802/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

[wang yaoxin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/
---

(Updated 九月 18, 2016, 9:20 a.m.)


Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.


Bugs: AMBARI-18374
https://issues.apache.org/jira/browse/AMBARI-18374


Repository: ambari


Description
---

when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
null

2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
Operation(Request from server), RequestType(POST), 
url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
Accepted), Command(RESTART), Cluster name(null)

2016-09-13T17:29:22.042+0800, User(admin), 
Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
RequestId(15)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 075e328 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 1074f0e 

Diff: https://reviews.apache.org/r/51843/diff/


Testing
---

done!


Thanks,

wang yaoxin