Re: Review Request 51754: AMBARI-18337 Syntax Error in Ambari HAWQ Unit test with Python 2.6

2016-09-19 Thread Masahiro Tanaka 


> On 9月 10, 2016, 6:06 a.m., Lav Jain wrote:
> > Ship It!

Thanks Lav Jain, could you commit this?


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51754/#review148370
---


On 9月 9, 2016, 10:21 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51754/
> ---
> 
> (Updated 9月 9, 2016, 10:21 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-18337
> https://issues.apache.org/jira/browse/AMBARI-18337
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With Python 2.6, ` {"A", "B"}  ` syntax isn't allowed.
> 
> Ref. https://docs.python.org/2/library/stdtypes.html#set-types-set-frozenset
> 
> ```
> As of Python 2.7, non-empty sets (not frozensets) can be created by placing a 
> comma-separated list of elements within braces, for example: {'jack', 
> 'sjoerd'}, in addition to the set constructor.
> ```
> 
> Error
> 
> ```
> Traceback (most recent call last):
>   File "unitTests.py", line 129, in stack_test_executor
> modules]
>   File "/usr/lib64/python2.6/unittest.py", line 575, in loadTestsFromName
> module = __import__('.'.join(parts_copy))
>   File 
> "/tmp/ambari/ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py",
>  li
> ne 646
> self.assertFalse({'HAWQMASTER', 'HAWQSTANDBY'}.issubset(hostComponents))
>   ^
> SyntaxError: invalid syntax
> ```
> 
> 
> Diffs
> -
> 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> 71c109f 
> 
> Diff: https://reviews.apache.org/r/51754/diff/
> 
> 
> Testing
> ---
> 
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12827665/AMBARI-18337.patch
> against trunk revision .
> 
> +1 @author. The patch does not contain any @author tags.
> 
> +1 tests included. The patch appears to include 1 new or modified test files.
> 
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> 
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> 
> +1 core tests. The patch passed unit tests in ambari-server.
> 
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/8623//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/8623//console
> 
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 51754: AMBARI-18337 Syntax Error in Ambari HAWQ Unit test with Python 2.6

2016-09-19 Thread Masahiro Tanaka 


> On 9月 17, 2016, 1:20 a.m., Alexander Denissov wrote:
> > Ship It!

Thanks Alexander Denissov!


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51754/#review149208
---


On 9月 9, 2016, 10:21 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51754/
> ---
> 
> (Updated 9月 9, 2016, 10:21 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-18337
> https://issues.apache.org/jira/browse/AMBARI-18337
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With Python 2.6, ` {"A", "B"}  ` syntax isn't allowed.
> 
> Ref. https://docs.python.org/2/library/stdtypes.html#set-types-set-frozenset
> 
> ```
> As of Python 2.7, non-empty sets (not frozensets) can be created by placing a 
> comma-separated list of elements within braces, for example: {'jack', 
> 'sjoerd'}, in addition to the set constructor.
> ```
> 
> Error
> 
> ```
> Traceback (most recent call last):
>   File "unitTests.py", line 129, in stack_test_executor
> modules]
>   File "/usr/lib64/python2.6/unittest.py", line 575, in loadTestsFromName
> module = __import__('.'.join(parts_copy))
>   File 
> "/tmp/ambari/ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py",
>  li
> ne 646
> self.assertFalse({'HAWQMASTER', 'HAWQSTANDBY'}.issubset(hostComponents))
>   ^
> SyntaxError: invalid syntax
> ```
> 
> 
> Diffs
> -
> 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> 71c109f 
> 
> Diff: https://reviews.apache.org/r/51754/diff/
> 
> 
> Testing
> ---
> 
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12827665/AMBARI-18337.patch
> against trunk revision .
> 
> +1 @author. The patch does not contain any @author tags.
> 
> +1 tests included. The patch appears to include 1 new or modified test files.
> 
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> 
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> 
> +1 core tests. The patch passed unit tests in ambari-server.
> 
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/8623//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/8623//console
> 
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Review Request 52072: AMBARI-18390 : Configuration warnings during "Add Service" Wizard includes seemingly nonsensical heapsize recommendations for AMS heap sizes.

2016-09-19 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52072/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18390
https://issues.apache.org/jira/browse/AMBARI-18390


Repository: ambari


Description
---

AMS stack validations for Metrics collector and HBase heap sizes based on 
unused memory on host were wrongly calculated.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
fd0dfed 

Diff: https://reviews.apache.org/r/52072/diff/


Testing
---

Manually tested.
Ambari-server python unit tests pass.


Thanks,

Aravindan Vijayan

Re: Review Request 52068: Create authentication filter to perform Kerberos authentication for Ambari

2016-09-19 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52068/#review149557
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
 (line 53)


`ConfigureAmbariIdentitiesServerAction` was renamed crom 
`ConfigureAmbariIndetityServerAction` and modified to handle the SPNEGO 
princial needed for Kerberos authentication.


- Robert Levas


On Sept. 19, 2016, 6:18 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52068/
> ---
> 
> (Updated Sept. 19, 2016, 6:18 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-18406
> https://issues.apache.org/jira/browse/AMBARI-18406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Users should be able to authenticate to use Ambari by providing a Kerberos 
> token using SPNEGO - Simple and Protected GSSAPI Negotiation Mechanism.  This 
> includes access to the Ambari REST API as well as the Ambari web-based UI. 
> 
> The implementation should support the ability to perform the full SPNEGO 
> handshake as well as access requests directly providing the appropriate HTTP 
> header containing the Kerberos token. For example:
> 
> ```
> Authorization: Negotiate YIICcgY...r/vJcLO
> ```
> In the full handshake model
> - The client requests access to a web resource
> - The server responds with an HTTP 401 status (`Unauthorized`), including the 
> header `WWW-Authenticate: Negotiate`
> - The client generates the Kerberos data and creates a new request containing 
> the authentication header - `Authorization: Negotiate YIICcgY...r/vJcLO`
> 
> Since Ambari needs to generally return a HTTP status of 403 ({{Forbidden}}) 
> when authentication is needed, a _hint_ must be sent along with the request 
> indicate to Ambari that Kerberos authentication is desired.  If this _hint_ 
> is received, then Ambari will respond with the appropriate status and header 
> to initiate SPNEGO with the client. This _hint_ is an Ambari-specific header 
> named "X-Negotiate-Authentication" with the value of "true":
> 
> ```
> X-Negotiate-Authentication: true
> ```
> 
> No matter what the handshake mechanism is (or lack of), once the Kerberos 
> token is received by Ambari, Ambari is to parse and validate the token.  If a 
> failure occurs, Ambari is to respond with the appropriate HTTP status and 
> related header(s).  Upon success, the user's principal name is retrieved and 
> converted into a _local_ user name.  The use of an auth-to-local rule set 
> processor may be needed to perform this translation.  Using this _local_ 
> username, an appropriate Ambari user account is located and used as the 
> authenticated users identity - details, privileges, etc Failure to find 
> an appropriate Ambari user account is to result in an authentication failure 
> response.
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 2615b46 
>   ambari-server/pom.xml 323ce22 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  b2fa4c0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  c4d21fc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  5bc5cd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/AmbariEntryPoint.java
>  2028f46 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationFilter.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosTicketValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  b6b0713 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIndetityServerAction.java
>  96540ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  e31e6ff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  db210e0 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml a86973c 
>   
>

Review Request 52068: Create authentication filter to perform Kerberos authentication for Ambari

2016-09-19 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52068/
---

Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Nate 
Cole.


Bugs: AMBARI-18406
https://issues.apache.org/jira/browse/AMBARI-18406


Repository: ambari


Description
---

Users should be able to authenticate to use Ambari by providing a Kerberos 
token using SPNEGO - Simple and Protected GSSAPI Negotiation Mechanism.  This 
includes access to the Ambari REST API as well as the Ambari web-based UI. 

The implementation should support the ability to perform the full SPNEGO 
handshake as well as access requests directly providing the appropriate HTTP 
header containing the Kerberos token. For example:

```
Authorization: Negotiate YIICcgY...r/vJcLO
```
In the full handshake model
- The client requests access to a web resource
- The server responds with an HTTP 401 status (`Unauthorized`), including the 
header `WWW-Authenticate: Negotiate`
- The client generates the Kerberos data and creates a new request containing 
the authentication header - `Authorization: Negotiate YIICcgY...r/vJcLO`

Since Ambari needs to generally return a HTTP status of 403 ({{Forbidden}}) 
when authentication is needed, a _hint_ must be sent along with the request 
indicate to Ambari that Kerberos authentication is desired.  If this _hint_ is 
received, then Ambari will respond with the appropriate status and header to 
initiate SPNEGO with the client. This _hint_ is an Ambari-specific header named 
"X-Negotiate-Authentication" with the value of "true":

```
X-Negotiate-Authentication: true
```

No matter what the handshake mechanism is (or lack of), once the Kerberos token 
is received by Ambari, Ambari is to parse and validate the token.  If a failure 
occurs, Ambari is to respond with the appropriate HTTP status and related 
header(s).  Upon success, the user's principal name is retrieved and converted 
into a _local_ user name.  The use of an auth-to-local rule set processor may 
be needed to perform this translation.  Using this _local_ username, an 
appropriate Ambari user account is located and used as the authenticated users 
identity - details, privileges, etc Failure to find an appropriate Ambari 
user account is to result in an authentication failure response.


Diffs
-

  ambari-project/pom.xml 2615b46 
  ambari-server/pom.xml 323ce22 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 b2fa4c0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 c4d21fc 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 5bc5cd8 
  
ambari-server/src/main/java/org/apache/ambari/server/security/AmbariEntryPoint.java
 2028f46 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationFilter.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosTicketValidator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 b6b0713 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIndetityServerAction.java
 96540ef 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 e31e6ff 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
 db210e0 
  ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml a86973c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 3c97ce9 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsServiceTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationFilterTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosTicketValidatorTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/52068/diff/


Testing
---

Manual testing

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-19 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52044/
---

(Updated Вер. 19, 2016, 9:10 після полудня)


Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sumit 
Mohanty.


Bugs: AMBARI-18420
https://issues.apache.org/jira/browse/AMBARI-18420


Repository: ambari


Description
---

||Test||Count||Time (s)||
|org.apache.ambari.server.orm.dao.AlertDispatchDAOTest|26|62.096|
|org.apache.ambari.server.serveraction.upgrades.ConfigureActionTest 
|17|51.291|
|org.apache.ambari.server.orm.TestOrmImpl|11|33.667|
|org.apache.ambari.server.state.ServiceTest|9|30.218|
|org.apache.ambari.server.controller.test.BufferedThreadPoolExecutorCompletionServiceTest|4|36.114|


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java
 77ff4a2 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
 b6f5ec2 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
 ede1f1f 
  ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 
ce1c7e6 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
 2518e0a 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 9b9fee5 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
 be0aeef 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
 cb63b0f 
  ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 
79fe0e9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
 afcc90e 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
 50ba3ef 

Diff: https://reviews.apache.org/r/52044/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-19 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52044/
---

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sumit 
Mohanty.


Bugs: AMBARI-18420
https://issues.apache.org/jira/browse/AMBARI-18420


Repository: ambari


Description
---

||Test||Count||Time (s)||
|org.apache.ambari.server.orm.dao.AlertDispatchDAOTest|26|62.096|
|org.apache.ambari.server.serveraction.upgrades.ConfigureActionTest 
|17|51.291|
|org.apache.ambari.server.orm.TestOrmImpl|11|33.667|
|org.apache.ambari.server.state.ServiceTest|9|30.218|
|org.apache.ambari.server.controller.test.BufferedThreadPoolExecutorCompletionServiceTest|4|36.114|


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java
 77ff4a2 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
 b6f5ec2 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
 ede1f1f 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/TestConcurrencyOrmImpl.java
 PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 
ce1c7e6 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
 2518e0a 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 9b9fee5 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
 be0aeef 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
 cb63b0f 
  ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 
79fe0e9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
 afcc90e 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
 50ba3ef 

Diff: https://reviews.apache.org/r/52044/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-19 Thread Sid Wagle 


> On Sept. 19, 2016, 9:18 a.m., Robert Levas wrote:
> > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py,
> >  line 112
> > 
> >
> > The path to the SPNEGO keytab file and the SPNEGO principal name must 
> > not be hard coded.  There should be a relevant config property for this and 
> > it should be set via the Kerberos descriptor.

Ahh thanks Robert for pointing out the keytab, I missed that part. @Qin: This 
should be easy to add by editing 
common-services/AMBARI_METRICS/0.1.0/kerberos.json.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51724/#review149443
---


On Sept. 19, 2016, 3:53 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51724/
> ---
> 
> (Updated Sept. 19, 2016, 3:53 p.m.)
> 
> 
> Review request for Ambari, Di Li, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17898
> https://issues.apache.org/jira/browse/AMBARI-17898
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ()This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> 
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector (in AMS distributed mode) web-console will be Kerberos HTTP 
> SPNEGO enabled too. But Ambari Metrics Monitor, a client of Ambari Metrics 
> Collector, currently does not support Kerberos HTTP SPNEGO authentication.
> 
> /var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
> 2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
> http://metrics-collector:6188/ws/v1/timeline/metrics
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
> server. HTTP Error 401: Authentication required
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml d73a0af 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 59ca5d7 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  44692f6 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 050af16 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/faked_kerberos.py
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  3908b27 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  65129f8 
> 
> Diff: https://reviews.apache.org/r/51724/diff/
> 
> 
> Testing
> ---
> 
> 1. passed existing unittest cases.
> 2. manually tested with HDP-2.5.0.0/trunk 
>1) Non http spnego enabled clusters
>2) http spnego enabled cluster - tested the trunk's monitor code against a 
> http spnego enabled cluster 
>   http spnego enabled cluster is currently broken in trunk: the 
> distributed metrics collector's http server currently will not started with 
> http spnego enabled. so I had to manually test the trunk's monitor code with 
> http spnego enabled collector on a branch2.4 cluster. Need to mention that 
> the testing should be valid because the code change area is monitor code and 
> the trunk and branch2.4's collectors are same.
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-19 Thread Qin Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51724/
---

(Updated Sept. 19, 2016, 3:53 p.m.)


Review request for Ambari, Di Li, Dmytro Sen, and Sid Wagle.


Changes
---

new changes:
1. update ambari-metrics-assembly/pom.xml to include ipa lib to rpm
2. rebase emitter.py with recent change and issue warning if kerberos module is 
not found.


Bugs: AMBARI-17898
https://issues.apache.org/jira/browse/AMBARI-17898


Repository: ambari


Description
---

()This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
authenticate".

In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
Metrics Collector (in AMS distributed mode) web-console will be Kerberos HTTP 
SPNEGO enabled too. But Ambari Metrics Monitor, a client of Ambari Metrics 
Collector, currently does not support Kerberos HTTP SPNEGO authentication.

/var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
http://metrics-collector:6188/ws/v1/timeline/metrics
2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
server. HTTP Error 401: Authentication required
2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...


Diffs (updated)
-

  ambari-metrics/ambari-metrics-assembly/pom.xml d73a0af 
  ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
59ca5d7 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 44692f6 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
050af16 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/faked_kerberos.py
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 3908b27 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 65129f8 

Diff: https://reviews.apache.org/r/51724/diff/


Testing (updated)
---

1. passed existing unittest cases.
2. manually tested with HDP-2.5.0.0/trunk 
   1) Non http spnego enabled clusters
   2) http spnego enabled cluster - tested the trunk's monitor code against a 
http spnego enabled cluster 
  http spnego enabled cluster is currently broken in trunk: the distributed 
metrics collector's http server currently will not started with http spnego 
enabled. so I had to manually test the trunk's monitor code with http spnego 
enabled collector on a branch2.4 cluster. Need to mention that the testing 
should be valid because the code change area is monitor code and the trunk and 
branch2.4's collectors are same.


Thanks,

Qin Liu

Re: Review Request 51894: View instance cloning functionality

2016-09-19 Thread Sangeeta Ravindran 


> On Sept. 19, 2016, 1:31 p.m., Di Li wrote:
> > Ship It!

Thank you Di.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51894/#review149466
---


On Sept. 16, 2016, 10:59 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51894/
> ---
> 
> (Updated Sept. 16, 2016, 10:59 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18378
> https://issues.apache.org/jira/browse/AMBARI-18378
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This task is for providing an option to clone / copy a view instance.
> A new "copy" icon will appear next to a view instance. Clicking on this opens 
> up the existing view with instance name and display name of the view appended 
> with _Copy.
> This will be useful when creating multiple view instances with mild 
> configuration differences between them.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
>  20bd25c 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> 0aefaba 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 239e39e 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html
>  924885f 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  bc441cd 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js
>  117021e 
> 
> Diff: https://reviews.apache.org/r/51894/diff/
> 
> 
> Testing
> ---
> 
> Manual testing with different types of view instances.
> Currently there are no automated tests for ambari-admin.
> 
> 
> File Attachments
> 
> 
> AMBARI-18378.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/16/cd344c4a-e087-46a3-953a-f8f8ae6f7764__AMBARI-18378.patch
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 51894: View instance cloning functionality

2016-09-19 Thread Sangeeta Ravindran 


> On Sept. 18, 2016, 11:51 a.m., Alexandr Antonenko wrote:
> > Ship It!

Thank you Alexandr. Can you please help push the fix?


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51894/#review149364
---


On Sept. 16, 2016, 10:59 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51894/
> ---
> 
> (Updated Sept. 16, 2016, 10:59 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18378
> https://issues.apache.org/jira/browse/AMBARI-18378
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This task is for providing an option to clone / copy a view instance.
> A new "copy" icon will appear next to a view instance. Clicking on this opens 
> up the existing view with instance name and display name of the view appended 
> with _Copy.
> This will be useful when creating multiple view instances with mild 
> configuration differences between them.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
>  20bd25c 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> 0aefaba 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 239e39e 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html
>  924885f 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  bc441cd 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js
>  117021e 
> 
> Diff: https://reviews.apache.org/r/51894/diff/
> 
> 
> Testing
> ---
> 
> Manual testing with different types of view instances.
> Currently there are no automated tests for ambari-admin.
> 
> 
> File Attachments
> 
> 
> AMBARI-18378.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/16/cd344c4a-e087-46a3-953a-f8f8ae6f7764__AMBARI-18378.patch
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

2016-09-19 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52043/#review149480
---


Ship it!




- Laszlo Puskas


On Sept. 19, 2016, 3:21 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52043/
> ---
> 
> (Updated Sept. 19, 2016, 3:21 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Oliver 
> Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18419
> https://issues.apache.org/jira/browse/AMBARI-18419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Introduce Maven project property `el.log` to control log level for 
> eclipselink-staticweave-maven-plugin
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 323ce22 
> 
> Diff: https://reviews.apache.org/r/52043/diff/
> 
> 
> Testing
> ---
> 
> ```bash
> mvn -pl ambari-server -Drat.skip -DskipTests test-compile
> # -> verify output contains all messages from EclipseLink, including lines 
> starting with "[EL Config]" and "[EL Finest]"
> 
> mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=INFO test-compile
> # -> verify output does not contain lines starting with "[EL Config]" and 
> "[EL Finest]", only "[EL Warning]"
> 
> mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=OFF test-compile
> # -> verify output does not contain any lines starting with "[EL "
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

2016-09-19 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52043/
---

Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Oliver Szabo, 
and Sebastian Toader.


Bugs: AMBARI-18419
https://issues.apache.org/jira/browse/AMBARI-18419


Repository: ambari


Description
---

Introduce Maven project property `el.log` to control log level for 
eclipselink-staticweave-maven-plugin


Diffs
-

  ambari-server/pom.xml 323ce22 

Diff: https://reviews.apache.org/r/52043/diff/


Testing
---

```bash
mvn -pl ambari-server -Drat.skip -DskipTests test-compile
# -> verify output contains all messages from EclipseLink, including lines 
starting with "[EL Config]" and "[EL Finest]"

mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=INFO test-compile
# -> verify output does not contain lines starting with "[EL Config]" and "[EL 
Finest]", only "[EL Warning]"

mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=OFF test-compile
# -> verify output does not contain any lines starting with "[EL "
```


Thanks,

Attila Doroszlai

Re: Review Request 51599: AMBARI-18292 Support dispatching notifications of assigned alert states for script-based alert dispatcher

2016-09-19 Thread Jonathan Hurley 


> On Sept. 3, 2016, 3:17 p.m., Jonathan Hurley wrote:
> > This is not the correct way to accomplish this. Instead, when you create 
> > the alert target, you can specify which alert states the alert target cares 
> > about:
> > 
> > ```
> > {
> >   "AlertTarget": {
> > "name": "Simple",
> > "description": "This target does not work and is only an exmaple of 
> > setting states",
> > "alert_states": ["OK", "WARNING"]
> > "notification_type": "FOO",
> > "groups": [1,2,3]
> >   }
> > }
> > ```
> > 
> > This is also accomplished through the Web Client when created/editing the 
> > target.
> 
> yao lei wrote:
> thanks for your explaination.
> Do your mean that we can creating or editing the  alert target on web ui?
> 
> Jonathan Hurley wrote:
> Yes you can.
> 
> yao lei wrote:
> Thanks your reply.
> I think i need to upgrade my current ambari  2.1.1
> 
> yao lei wrote:
> Hi,jhurley.
> I am sorry to bother you again.
> I can't find the operation on Web Client to create alert target which 
> notification_type is ALERT_SCRIPT.
> It seems that Ambari only support creating/editing alert notifications of 
> type EMAIL/SNMP  ( Alerts -> Actions -> Manage Notifications -> Icon plus -> 
> Create Alert Notification)
> My Ambari verison now is 2.4.0.1

That's correct - creating a SCRIPT type dispatcher is not supported in the web 
client yet. I believe the web client is working on scoping an alert wizard for 
2.5.0, but until then you'd need to use a POST to create it.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51599/#review147727
---


On Sept. 3, 2016, 10:36 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51599/
> ---
> 
> (Updated Sept. 3, 2016, 10:36 a.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-18292
> https://issues.apache.org/jira/browse/AMBARI-18292
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> By default, Ambari allow all notifications of all kinds of alert states 
> (OK,WARNING,CRITICAL,UNKNOWN) to dispatch in script-based alert dispatcher.
> However, sometimes we hope to filter notification of some alert states 
> This patch will resolve this by setting 
> 'notification.dispatch.alert.script.states' in ambari.properties as following:
> 
> #Only dispatch WARNING and CRITICAL state notification 
> notification.dispatch.alert.script.states=WARNING,CRITICAL
> 
> If you don't set this property that means all notifications will be 
> dispatched.
> 
> I think making the desired alerts notifications configurable may be useful 
> for Ambari users.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
>  907588d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcherTest.java
>  9e0e406 
> 
> Diff: https://reviews.apache.org/r/51599/diff/
> 
> 
> Testing
> ---
> 
> Tested
> 
> Running 
> org.apache.ambari.server.notifications.dispatchers.AlertScriptDispatcherTest
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.096 sec - in
> 
> 
> Thanks,
> 
> yao lei
> 
>

Review Request 52038: AMBARI-18418 StackServiceDirectory debug messages are logged with placeholders

2016-09-19 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52038/
---

Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Oliver Szabo, and 
Sebastian Toader.


Bugs: AMBARI-18418
https://issues.apache.org/jira/browse/AMBARI-18418


Repository: ambari


Description
---

Replaced String.format placeholders with Log4J placeholders


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
 a8b4632 

Diff: https://reviews.apache.org/r/52038/diff/


Testing
---

* Set `log4j.rootLogger=DEBUG,file` in 
`/etc/ambari-server/conf/log4j.properties`
 * Start Ambari server (no cluster needed)
 * Verify `StackServiceDirectory` messages contain service name, stack name, 
not %s placeholders
   Example:
 wrong: `19 Sep 2016 14:01:08,380 DEBUG [main] StackServiceDirectory:159 - 
Service package folder %s for service %s for stack %s does not exist.`
 good: `19 Sep 2016 14:07:22,651 DEBUG [main] StackServiceDirectory:159 - 
Service package folder 
/var/lib/ambari-server/resources/stacks/HDP/2.4/services/ACCUMULO/package for 
service ACCUMULO for stack HDP-2.4 does not exist.`


Thanks,

Attila Doroszlai

Re: Review Request 52035: Improve agent logging to add more relevant message

2016-09-19 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52035/#review149471
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Sept. 19, 2016, 4:51 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52035/
> ---
> 
> (Updated Sept. 19, 2016, 4:51 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18417
> https://issues.apache.org/jira/browse/AMBARI-18417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Looking at the agent, it logs the following:
> 
> 
> 
> 
> INFO 2016-09-16 15:52:29,659 Controller.py:277 - Heartbeat with server is 
> running...
> INFO 2016-09-16 15:52:49,475 Heartbeat.py:90 - Adding host info/state to 
> heartbeat message.
> INFO 2016-09-16 15:52:49,737 logger.py:71 - call[['test', '-w', '/']] 
> {'sudo': True, 'timeout': 5}
> INFO 2016-09-16 15:52:49,746 logger.py:71 - call returned (0, '')
> INFO 2016-09-16 15:52:49,747 logger.py:71 - call[['test', '-w', 
> '/sys/fs/cgroup']] {'sudo': True, 'timeout': 5}
> INFO 2016-09-16 15:52:49,757 logger.py:71 - call returned (0, '')
> INFO 2016-09-16 15:52:49,757 logger.py:71 - call[['test', '-w', '/dev']] 
> {'sudo': True, 'timeout': 5}
> INFO 2016-09-16 15:52:49,766 logger.py:71 - call returned (0, '')
> INFO 2016-09-16 15:52:49,767 logger.py:71 - call[['test', '-w', '/run']] 
> {'sudo': True, 'timeout': 5}
> INFO 2016-09-16 15:52:49,776 logger.py:71 - call returned (0, '')
> INFO 2016-09-16 15:52:49,776 logger.py:71 - call[['test', '-w', 
> '/run/lock']] {'sudo': True, 'timeout': 5}
> INFO 2016-09-16 15:52:49,785 logger.py:71 - call returned (0, '')
> INFO 2016-09-16 15:52:49,785 logger.py:71 - call[['test', '-w', 
> '/run/shm']] {'sudo': True, 'timeout': 5}
> INFO 2016-09-16 15:52:49,794 logger.py:71 - call returned (0, '')
> INFO 2016-09-16 15:52:49,794 logger.py:71 - call[['test', '-w', 
> '/run/user']] {'sudo': True, 'timeout': 5}
> INFO 2016-09-16 15:52:49,802 logger.py:71 - call returned (0, '')
> INFO 2016-09-16 15:52:49,803 logger.py:71 - call[['test', '-w', 
> '/grid/0']] {'sudo': True, 'timeout': 5}
> INFO 2016-09-16 15:52:49,813 logger.py:71 - call returned (0, '')
> INFO 2016-09-16 15:52:49,813 logger.py:71 - call[['test', '-w', '/tmp']] 
> {'sudo': True, 'timeout': 5}
> INFO 2016-09-16 15:52:49,826 logger.py:71 - call returned (0, '')
> 
> 
> Can we
> 
>   * Add the heartbeat id to the log
>   * Remove the logs about **call** or change them to DEBUG
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 7100656 
>   ambari-agent/src/main/python/ambari_agent/Hardware.py 17acdf2 
> 
> Diff: https://reviews.apache.org/r/52035/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 52032: Optimize stack manager initialization for Ambari Server Unit Tests

2016-09-19 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52032/#review149469
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Вер. 19, 2016, 12:29 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52032/
> ---
> 
> (Updated Вер. 19, 2016, 12:29 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18416
> https://issues.apache.org/jira/browse/AMBARI-18416
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack dirs scanning occurs on every test module creation. It
> takes about 0.5 second for each test method.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
> 6c0d5e4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  0f8ed9c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  40a11fe 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  a521139 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
>  e327a04 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMock.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  34bac2a 
> 
> Diff: https://reviews.apache.org/r/52032/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 52035: Improve agent logging to add more relevant message

2016-09-19 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52035/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18417
https://issues.apache.org/jira/browse/AMBARI-18417


Repository: ambari


Description
---

Looking at the agent, it logs the following:




INFO 2016-09-16 15:52:29,659 Controller.py:277 - Heartbeat with server is 
running...
INFO 2016-09-16 15:52:49,475 Heartbeat.py:90 - Adding host info/state to 
heartbeat message.
INFO 2016-09-16 15:52:49,737 logger.py:71 - call[['test', '-w', '/']] 
{'sudo': True, 'timeout': 5}
INFO 2016-09-16 15:52:49,746 logger.py:71 - call returned (0, '')
INFO 2016-09-16 15:52:49,747 logger.py:71 - call[['test', '-w', 
'/sys/fs/cgroup']] {'sudo': True, 'timeout': 5}
INFO 2016-09-16 15:52:49,757 logger.py:71 - call returned (0, '')
INFO 2016-09-16 15:52:49,757 logger.py:71 - call[['test', '-w', '/dev']] 
{'sudo': True, 'timeout': 5}
INFO 2016-09-16 15:52:49,766 logger.py:71 - call returned (0, '')
INFO 2016-09-16 15:52:49,767 logger.py:71 - call[['test', '-w', '/run']] 
{'sudo': True, 'timeout': 5}
INFO 2016-09-16 15:52:49,776 logger.py:71 - call returned (0, '')
INFO 2016-09-16 15:52:49,776 logger.py:71 - call[['test', '-w', 
'/run/lock']] {'sudo': True, 'timeout': 5}
INFO 2016-09-16 15:52:49,785 logger.py:71 - call returned (0, '')
INFO 2016-09-16 15:52:49,785 logger.py:71 - call[['test', '-w', 
'/run/shm']] {'sudo': True, 'timeout': 5}
INFO 2016-09-16 15:52:49,794 logger.py:71 - call returned (0, '')
INFO 2016-09-16 15:52:49,794 logger.py:71 - call[['test', '-w', 
'/run/user']] {'sudo': True, 'timeout': 5}
INFO 2016-09-16 15:52:49,802 logger.py:71 - call returned (0, '')
INFO 2016-09-16 15:52:49,803 logger.py:71 - call[['test', '-w', '/grid/0']] 
{'sudo': True, 'timeout': 5}
INFO 2016-09-16 15:52:49,813 logger.py:71 - call returned (0, '')
INFO 2016-09-16 15:52:49,813 logger.py:71 - call[['test', '-w', '/tmp']] 
{'sudo': True, 'timeout': 5}
INFO 2016-09-16 15:52:49,826 logger.py:71 - call returned (0, '')


Can we

  * Add the heartbeat id to the log
  * Remove the logs about **call** or change them to DEBUG


Diffs
-

  ambari-agent/src/main/python/ambari_agent/Controller.py 7100656 
  ambari-agent/src/main/python/ambari_agent/Hardware.py 17acdf2 

Diff: https://reviews.apache.org/r/52035/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 51894: View instance cloning functionality

2016-09-19 Thread Di Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51894/#review149466
---


Ship it!




Ship It!

- Di Li


On Sept. 16, 2016, 10:59 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51894/
> ---
> 
> (Updated Sept. 16, 2016, 10:59 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18378
> https://issues.apache.org/jira/browse/AMBARI-18378
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This task is for providing an option to clone / copy a view instance.
> A new "copy" icon will appear next to a view instance. Clicking on this opens 
> up the existing view with instance name and display name of the view appended 
> with _Copy.
> This will be useful when creating multiple view instances with mild 
> configuration differences between them.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
>  20bd25c 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> 0aefaba 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 239e39e 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html
>  924885f 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  bc441cd 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js
>  117021e 
> 
> Diff: https://reviews.apache.org/r/51894/diff/
> 
> 
> Testing
> ---
> 
> Manual testing with different types of view instances.
> Currently there are no automated tests for ambari-admin.
> 
> 
> File Attachments
> 
> 
> AMBARI-18378.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/16/cd344c4a-e087-46a3-953a-f8f8ae6f7764__AMBARI-18378.patch
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-19 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51906/#review149463
---


Ship it!




Ship It!

- Balázs Bence Sári


On Sept. 16, 2016, 2:57 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51906/
> ---
> 
> (Updated Sept. 16, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18349
> https://issues.apache.org/jira/browse/AMBARI-18349
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A. Add `role_command_order.json` to make sure name node, node manager, 
> resource manager are started before running Microsoft R service check
> B. Create `/user/RevoShare` on HDFS if necessary when starting services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  ba9c8fb 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/service_check.py
>  547476b 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/role_command_order.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51906/diff/
> 
> 
> Testing
> ---
> 
> A. Role command order
>1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
>2. Create cluster via web UI with HDFS, YARN, ZooKeeper, Microsoft R
>3. Verify name node, node manager, resource manager, data node are started 
> before Microsoft R service check
>4. Verify stage_id for NAMENODE-START, NODEMANAGER-START, 
> RESOURCEMANAGER-START are smaller than stage_id for 
> MICROSOFT_R_SERVICE_CHECK-SERVICE_CHECK:
> ```
> select request_id, stage_id, task_id, role, role_command from 
> host_role_command order by request_id, stage_id, task_id;
> ```
> B. RevoShare
>1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
>2. Create cluster via blueprint with HDFS, YARN, ZooKeeper, Microsoft R
>3. Verify `/user/RevoShare` directory exists: `hdfs dfs -ls /user/`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-19 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51906/#review149461
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 16, 2016, 4:57 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51906/
> ---
> 
> (Updated Sept. 16, 2016, 4:57 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18349
> https://issues.apache.org/jira/browse/AMBARI-18349
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A. Add `role_command_order.json` to make sure name node, node manager, 
> resource manager are started before running Microsoft R service check
> B. Create `/user/RevoShare` on HDFS if necessary when starting services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  ba9c8fb 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/service_check.py
>  547476b 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/role_command_order.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51906/diff/
> 
> 
> Testing
> ---
> 
> A. Role command order
>1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
>2. Create cluster via web UI with HDFS, YARN, ZooKeeper, Microsoft R
>3. Verify name node, node manager, resource manager, data node are started 
> before Microsoft R service check
>4. Verify stage_id for NAMENODE-START, NODEMANAGER-START, 
> RESOURCEMANAGER-START are smaller than stage_id for 
> MICROSOFT_R_SERVICE_CHECK-SERVICE_CHECK:
> ```
> select request_id, stage_id, task_id, role, role_command from 
> host_role_command order by request_id, stage_id, task_id;
> ```
> B. RevoShare
>1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
>2. Create cluster via blueprint with HDFS, YARN, ZooKeeper, Microsoft R
>3. Verify `/user/RevoShare` directory exists: `hdfs dfs -ls /user/`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-19 Thread Attila Doroszlai 


> On Sept. 16, 2016, 7:01 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py,
> >  line 188
> > 
> >
> > Why is this needed ? There is already a action="create_on_execute"

According to my tests, "create_on_execute" is enough in itself if webhdfs is 
enabled, but the "execute" step is necessary if it is disabled.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51906/#review149214
---


On Sept. 16, 2016, 4:57 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51906/
> ---
> 
> (Updated Sept. 16, 2016, 4:57 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18349
> https://issues.apache.org/jira/browse/AMBARI-18349
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A. Add `role_command_order.json` to make sure name node, node manager, 
> resource manager are started before running Microsoft R service check
> B. Create `/user/RevoShare` on HDFS if necessary when starting services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  ba9c8fb 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/service_check.py
>  547476b 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/role_command_order.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51906/diff/
> 
> 
> Testing
> ---
> 
> A. Role command order
>1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
>2. Create cluster via web UI with HDFS, YARN, ZooKeeper, Microsoft R
>3. Verify name node, node manager, resource manager, data node are started 
> before Microsoft R service check
>4. Verify stage_id for NAMENODE-START, NODEMANAGER-START, 
> RESOURCEMANAGER-START are smaller than stage_id for 
> MICROSOFT_R_SERVICE_CHECK-SERVICE_CHECK:
> ```
> select request_id, stage_id, task_id, role, role_command from 
> host_role_command order by request_id, stage_id, task_id;
> ```
> B. RevoShare
>1. Install Ambari (trunk), add Microsoft R mpack, start Ambari
>2. Create cluster via blueprint with HDFS, YARN, ZooKeeper, Microsoft R
>3. Verify `/user/RevoShare` directory exists: `hdfs dfs -ls /user/`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 52027: Stack definition: service component 'cardinality' inheritance not working properly

2016-09-19 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52027/#review149456
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Вер. 19, 2016, 11:08 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52027/
> ---
> 
> (Updated Вер. 19, 2016, 11:08 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18415
> https://issues.apache.org/jira/browse/AMBARI-18415
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the stack definition if a property of service component is not defined in
> one specific version than it will be inherited from the parent version.
> 
> The `ComponentInfo.cardinality` always has a default value of "0+" from the
> moment the object is instantiated thus the inheritance logic is never applied.
> This leads to if a specific version of a service component doesn't have a
> property set in stack definition it won't inherit it from its parent but
> rather will take the "0+" default value.
> 
> This is not the correct behaviour. First the inheritance should be applied and
> only set `cardinality` to "0+" only if it can't be inherited from the parents
> (as it's not defined in any of the parents up in the inheritance chain)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  537ae32 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 2dae526 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  905707c 
> 
> Diff: https://reviews.apache.org/r/52027/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 52027: Stack definition: service component 'cardinality' inheritance not working properly

2016-09-19 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52027/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-18415
https://issues.apache.org/jira/browse/AMBARI-18415


Repository: ambari


Description
---

In the stack definition if a property of service component is not defined in
one specific version than it will be inherited from the parent version.

The `ComponentInfo.cardinality` always has a default value of "0+" from the
moment the object is instantiated thus the inheritance logic is never applied.
This leads to if a specific version of a service component doesn't have a
property set in stack definition it won't inherit it from its parent but
rather will take the "0+" default value.

This is not the correct behaviour. First the inheritance should be applied and
only set `cardinality` to "0+" only if it can't be inherited from the parents
(as it's not defined in any of the parents up in the inheritance chain)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java 
537ae32 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
2dae526 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
 905707c 

Diff: https://reviews.apache.org/r/52027/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 51330: Certain configuration files cannot be modified through Ambari api.

2016-09-19 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51330/#review149451
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Вер. 19, 2016, 10:26 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51330/
> ---
> 
> (Updated Вер. 19, 2016, 10:26 до полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18237
> https://issues.apache.org/jira/browse/AMBARI-18237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Certain configuration files like hadoop-metrics2.properties are not exposed to
> Ambari api calls, therefore cannot be modified by Ambari REST api calls.
> Ambari QE team uses these configuration files to modify it for HDP stack
> tests.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  49a14d0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  ba9c8fb 
> 
> Diff: https://reviews.apache.org/r/51330/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 51330: Certain configuration files cannot be modified through Ambari api.

2016-09-19 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51330/
---

(Updated Sept. 19, 2016, 10:26 a.m.)


Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.


Bugs: AMBARI-18237
https://issues.apache.org/jira/browse/AMBARI-18237


Repository: ambari


Description
---

Certain configuration files like hadoop-metrics2.properties are not exposed to
Ambari api calls, therefore cannot be modified by Ambari REST api calls.
Ambari QE team uses these configuration files to modify it for HDP stack
tests.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 49a14d0 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 ba9c8fb 

Diff: https://reviews.apache.org/r/51330/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-19 Thread Sandor Magyari 
Hi Wang!

The patch is committed to trunk & branch-2.5, you can close now the related 
review request. Please make sure, next time to attach the result of unit tests 
to the Testing section of review request.

BR
Sandor

From: wang yaoxin 
> on behalf of 
wang yaoxin 
>
Reply-To: wang yaoxin 
>
Date: Sunday 18 September 2016 11:21
To: Jonathan Hurley >, 
Sebastian Toader >, 
Oliver Szabo >, Robert 
Nettleton >
Cc: Sandor Magyari >, 
Attila Doroszlai 
>, wang yaoxin 
>, 
Ambari >
Subject: Re: Review Request 51843: rolling restart datanode cluster name in 
audit log show null

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/51843/


On 九月 16th, 2016, 4:35 p.m. UTC, Attila Doroszlai wrote:

ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java(Diff
 revision 4)

72

AuditEvent event = AuditEventCreatorTestHelper.getEvent(creator, request, 
result);


After adding the missing import, the test fails at this line causes:

Running org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.161 sec <<< 
FAILURE! - in 
org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest
postScheduleTest(org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest)
  Time elapsed: 0.006 sec  <<< FAILURE!
java.lang.AssertionError: Nothing captured yet
at 
org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest.postScheduleTest(RequestEventCreatorTest.java:73)


Hi Attila, thank you , I have update the diff ,and now it's OK


- wang


On 九月 18th, 2016, 9:20 a.m. UTC, wang yaoxin wrote:

Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.
By wang yaoxin.

Updated 九月 18, 2016, 9:20 a.m.

Bugs: AMBARI-18374
Repository: ambari
Description

when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
null

2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
Operation(Request from server), RequestType(POST), 
url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
Accepted), Command(RESTART), Cluster name(null)

2016-09-13T17:29:22.042+0800, User(admin), 
Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
RequestId(15)


Testing

done!


Diffs

  *   
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 (075e328)
  *   
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 (1074f0e)

View Diff

Re: Review Request 51961: Prerequisite checks should only check services that are getting upgraded

2016-09-19 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51961/#review149442
---


Ship it!





ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java
 (line 91)


todo seems to be not required here


- Dmitro Lisnichenko


On Sept. 16, 2016, 8:25 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51961/
> ---
> 
> (Updated Sept. 16, 2016, 8:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-18391
> https://issues.apache.org/jira/browse/AMBARI-18391
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updates prereq checks for specific services for VDF.
> 
> There is another anti-pattern discovered here which will be addressed in a 
> future patch: we are requiring super.isAllowed() in subclasses.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  4bc64d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  25aa62b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  6d5f23e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  55c8815 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheckTest.java
>  bfe0c3e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java
>  87d4167 
> 
> Diff: https://reviews.apache.org/r/51961/diff/
> 
> 
> Testing
> ---
> 
> Tests run: 4680, Failures: 0, Errors: 0, Skipped: 36
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36:29.565s
> [INFO] Finished at: Fri Sep 16 13:14:35 EDT 2016
> [INFO] Final Memory: 35M/665M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>