Re: Review Request 55597: Add upgrade logic for the heap dump control option added in HDP 2.6 stack.

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55597/#review161811
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
 (lines 469 - 506)


This is really the bulk of this review. Take the Insert instances and apply 
prepend/append logic. The work should be idempotent; I accomplish this simply 
by checking for whether the property already contains the new content. I know 
it's not perfect, but it'll satisfy every upgrade story we have so far.


- Jonathan Hurley


On Jan. 16, 2017, 9:54 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55597/
> ---
> 
> (Updated Jan. 16, 2017, 9:54 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19574
> https://issues.apache.org/jira/browse/AMBARI-19574
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There's a fuller description in the Jira issue, but just to sum up for easy 
> of reading:
> 
> - Hive added some properties in HDP 2.6
> - To upgrade these properties, existing content would need to be modified. 
> Unfortunately, find/replace isn't an option here
> - I created a very simple  directive to prepend/append properties
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  97280ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
>  5428ea7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
>  d7bb338 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 40052d8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  09608a0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 949a174 
>   ambari-server/src/main/resources/upgrade-config.xsd e274451 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
>  92fa084 
> 
> Diff: https://reviews.apache.org/r/55597/diff/
> 
> 
> Testing
> ---
> 
> Tests run: 4857, Failures: 0, Errors: 0, Skipped: 38
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:49 min
> [INFO] Finished at: 2017-01-16T20:53:37-05:00
> [INFO] Final Memory: 55M/708M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 55597: Add upgrade logic for the heap dump control option added in HDP 2.6 stack.

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55597/
---

(Updated Jan. 16, 2017, 9:54 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.


Bugs: AMBARI-19574
https://issues.apache.org/jira/browse/AMBARI-19574


Repository: ambari


Description (updated)
---

There's a fuller description in the Jira issue, but just to sum up for easy of 
reading:

- Hive added some properties in HDP 2.6
- To upgrade these properties, existing content would need to be modified. 
Unfortunately, find/replace isn't an option here
- I created a very simple  directive to prepend/append properties


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
 97280ee 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
 5428ea7 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
 d7bb338 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
40052d8 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 09608a0 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
949a174 
  ambari-server/src/main/resources/upgrade-config.xsd e274451 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
 92fa084 

Diff: https://reviews.apache.org/r/55597/diff/


Testing
---

Tests run: 4857, Failures: 0, Errors: 0, Skipped: 38

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 26:49 min
[INFO] Finished at: 2017-01-16T20:53:37-05:00
[INFO] Final Memory: 55M/708M
[INFO] 


Thanks,

Jonathan Hurley

Review Request 55597: Add upgrade logic for the heap dump control option added in HDP 2.6 stack.

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55597/
---

Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.


Bugs: AMBARI-19574
https://issues.apache.org/jira/browse/AMBARI-19574


Repository: ambari


Description
---

There's a fuller description in the Jira issue, but just to some up for easy of 
reading:

- Hive added some properties in HDP 2.6
- To upgrade these properties, existing content would need to be modified. 
Unfortunately, find/replace isn't an option here
- I created a very simple  directive to prepend/append properties


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
 97280ee 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
 5428ea7 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
 d7bb338 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
40052d8 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 09608a0 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
949a174 
  ambari-server/src/main/resources/upgrade-config.xsd e274451 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
 92fa084 

Diff: https://reviews.apache.org/r/55597/diff/


Testing
---

Tests run: 4857, Failures: 0, Errors: 0, Skipped: 38

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 26:49 min
[INFO] Finished at: 2017-01-16T20:53:37-05:00
[INFO] Final Memory: 55M/708M
[INFO] 


Thanks,

Jonathan Hurley

Review Request 55596: AMBARI-19576 - Downgrade request fails as existing Upgrade request is considered 'in progress'

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55596/
---

Review request for Ambari, Jaimin Jetly and Xi Wang.


Bugs: AMBARI-19576
https://issues.apache.org/jira/browse/AMBARI-19576


Repository: ambari


Description
---

Wait for the request_status = ABORTED before initializing downgrade.


Diffs
-

  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 3058580 
  ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 
78e81a0 

Diff: https://reviews.apache.org/r/55596/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  30297 passing (21s)
  157 pending


Thanks,

Richard Zang

Re: Review Request 55529: HDP 3.0 TP - create Service Advisor for HDFS

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55529/#review161806
---


Ship it!




Ship It!

- Sid Wagle


On Jan. 16, 2017, 11:30 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55529/
> ---
> 
> (Updated Jan. 16, 2017, 11:30 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19097
> https://issues.apache.org/jira/browse/AMBARI-19097
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a Service Advisor script for HDFS in HDP 3.0 Tech Preview.
> The Service Advisor must encapsulate all of the logic inherited/overwritten 
> from HDP 2.0.6 through HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.9/service_advisor.py
>  82316f4 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 
> 5172042 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 9816702 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> b275b00 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 8980398 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py 
> 4e4ef51 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 
> 26292d9 
>   ambari-server/src/main/resources/stacks/stack_advisor.py cc556c6 
>   ambari-server/src/test/python/TestStackAdvisor.py 87d2d15 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 1145154 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
> 
> Diff: https://reviews.apache.org/r/55529/diff/
> 
> 
> Testing
> ---
> 
> Verified recommendation and validation of HDFS while deploying HDP 3.0
> 
> Python unit tests passed.
> 
> Total run:1157
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 55593: AMBARI-19547. HSI tez am memory set to 0, incorrect calculations for non llap queues

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55593/#review161804
---


Ship it!




Ship It!

- Sumit Mohanty


On Jan. 17, 2017, 12:41 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55593/
> ---
> 
> (Updated Jan. 17, 2017, 12:41 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-19547
> https://issues.apache.org/jira/browse/AMBARI-19547
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Path by Siddharth Seth.
> 
> Patch contains the following changes.
> - Sets the am parameter to SET_ON_FIRST_INVOCATION so that it is computed.
> - Modifies the way #nodes is calculated for non ambari controlled queues (BUG 
> related to the computed size of the daemon being too large in this case)
> - Adds an improvement to the queue capacity determination (queue name check)
> - Re-adds most logging that was removed in AMBARI-19171Link
> - Modifies the display-name and description of some config parameters.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  f2f0554 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  a1f6d22 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  2fb1553 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
>  b331736 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> b08ce75 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml
>  1c6bc3f 
> 
> Diff: https://reviews.apache.org/r/55593/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 55593: AMBARI-19547. HSI tez am memory set to 0, incorrect calcaultions for non llap queues

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55593/#review161803
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 


Required.


- Swapan Shridhar


On Jan. 17, 2017, 12:24 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55593/
> ---
> 
> (Updated Jan. 17, 2017, 12:24 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-19547
> https://issues.apache.org/jira/browse/AMBARI-19547
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Path by Siddharth Seth.
> 
> Patch contains the following changes.
> - Sets the am parameter to SET_ON_FIRST_INVOCATION so that it is computed.
> - Modifies the way #nodes is calculated for non ambari controlled queues (BUG 
> related to the computed size of the daemon being too large in this case)
> - Adds an improvement to the queue capacity determination (queue name check)
> - Re-adds most logging that was removed in AMBARI-19171Link
> - Modifies the display-name and description of some config parameters.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  f2f0554 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  a1f6d22 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  2fb1553 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
>  b331736 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> b08ce75 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml
>  1c6bc3f 
> 
> Diff: https://reviews.apache.org/r/55593/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 55593: AMBARI-19547. HSI tez am memory set to 0, incorrect calcaultions for non llap queues

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55593/#review161802
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 292)


Extra space.



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
796)


Extra 1 at the end.



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
802)


Extra 1 at the end.



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
897)


typo : down


- Swapan Shridhar


On Jan. 17, 2017, 12:24 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55593/
> ---
> 
> (Updated Jan. 17, 2017, 12:24 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-19547
> https://issues.apache.org/jira/browse/AMBARI-19547
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Path by Siddharth Seth.
> 
> Patch contains the following changes.
> - Sets the am parameter to SET_ON_FIRST_INVOCATION so that it is computed.
> - Modifies the way #nodes is calculated for non ambari controlled queues (BUG 
> related to the computed size of the daemon being too large in this case)
> - Adds an improvement to the queue capacity determination (queue name check)
> - Re-adds most logging that was removed in AMBARI-19171Link
> - Modifies the display-name and description of some config parameters.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  f2f0554 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  a1f6d22 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  2fb1553 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
>  b331736 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> b08ce75 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml
>  1c6bc3f 
> 
> Diff: https://reviews.apache.org/r/55593/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 55593: AMBARI-19547. HSI tez am memory set to 0, incorrect calcaultions for non llap queues

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55593/
---

Review request for Ambari, Sumit Mohanty and Swapan Shridhar.


Bugs: AMBARI-19547
https://issues.apache.org/jira/browse/AMBARI-19547


Repository: ambari


Description
---

Path by Siddharth Seth.

Patch contains the following changes.
- Sets the am parameter to SET_ON_FIRST_INVOCATION so that it is computed.
- Modifies the way #nodes is calculated for non ambari controlled queues (BUG 
related to the computed size of the daemon being too large in this case)
- Adds an improvement to the queue capacity determination (queue name check)
- Re-adds most logging that was removed in AMBARI-19171Link
- Modifies the display-name and description of some config parameters.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 f2f0554 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 a1f6d22 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 2fb1553 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
 b331736 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
b08ce75 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml
 1c6bc3f 

Diff: https://reviews.apache.org/r/55593/diff/


Testing
---

Yes


Thanks,

Swapan Shridhar

Re: Review Request 55529: HDP 3.0 TP - create Service Advisor for HDFS

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55529/
---

(Updated Jan. 16, 2017, 11:30 p.m.)


Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Sumit Mohanty, 
and Sid Wagle.


Changes
---

Rebased.


Summary (updated)
-

HDP 3.0 TP - create Service Advisor for HDFS


Bugs: AMBARI-19097
https://issues.apache.org/jira/browse/AMBARI-19097


Repository: ambari


Description
---

Create a Service Advisor script for HDFS in HDP 3.0 Tech Preview.
The Service Advisor must encapsulate all of the logic inherited/overwritten 
from HDP 2.0.6 through HDP 2.6


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.9/service_advisor.py
 82316f4 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 
5172042 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
9816702 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
b275b00 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
8980398 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py 
4e4ef51 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 
26292d9 
  ambari-server/src/main/resources/stacks/stack_advisor.py cc556c6 
  ambari-server/src/test/python/TestStackAdvisor.py 87d2d15 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
1145154 
  ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py f9fb1f5 

Diff: https://reviews.apache.org/r/55529/diff/


Testing
---

Verified recommendation and validation of HDFS while deploying HDP 3.0

Python unit tests passed.

Total run:1157
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55478/
---

(Updated Jan. 16, 2017, 10:16 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
Mohanty.


Changes
---

Incorporated review comments


Bugs: AMBARI-19541
https://issues.apache.org/jira/browse/AMBARI-19541


Repository: ambari


Description
---

Add log rotation settings - handle HDP upgrade scenario
Changes:
1. Add a new task called "regex-replace" for configure-upgrade.xml
2. Add log4j changes for each service in upgrade-<>.xml and nonrolling-<>.xml


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
 5428ea7 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
 d7bb338 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
a1f03e8 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 8dff078 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 404d162 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 549e5a4 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
6d44b57 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
d525520 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
136fafe 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 db3580d 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 23b2694 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
518a157 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
dc21124 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
40052d8 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 09608a0 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
949a174 
  ambari-server/src/main/resources/upgrade-config.xsd e274451 

Diff: https://reviews.apache.org/r/55478/diff/


Testing
---

NonRolling Upgrade path 2.5-2.6
-Verified that the log4j changes appear for 
(HDFS,YARN,ZOOKEEPER,AMS,OOZIE,KNOX,KAFKA,HBASE,FALCON) services.


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 55291: AMBARI-19411: Atlas AMS support

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55291/
---

(Updated Jan. 16, 2017, 10 p.m.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Changes
---

Atlas version changes. Added metrics.json and empty widgets.json


Repository: ambari


Description
---

AMBARI-19411: Atlas AMS support


Diffs (updated)
-

  ambari-metrics/ambari-metrics-assembly/pom.xml cdcc2a7181 
  ambari-metrics/ambari-metrics-assembly/src/main/package/deb/control/postinst 
e75d557027 
  
ambari-metrics/ambari-metrics-assembly/src/main/package/rpm/sink/postinstall.sh 
e75d557027 
  ambari-metrics/ambari-metrics-atlas-sink/pom.xml PRE-CREATION 
  ambari-metrics/ambari-metrics-atlas-sink/src/main/assemblies/empty.xml 
PRE-CREATION 
  
ambari-metrics/ambari-metrics-atlas-sink/src/main/assemblies/jar-with-common.xml
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-atlas-sink/src/main/java/org/apache/hadoop/metrics/sink/atlas/AtlasMetricsReporter.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-atlas-sink/src/test/java/org/apache/hadoop/metrics2/sink/atlas/AtlasMetricsReporterTest.java
 PRE-CREATION 
  ambari-metrics/pom.xml 2d88912695 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 94193be5ee 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0.0/configuration/application-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0.0/configuration/atlas-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0.0/configuration/atlas-solrconfig.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0.0/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0.0/metainfo.xml 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0.0/metrics.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0.0/quicklinks/quicklinks.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0.0/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0.0/themes/theme.json
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0.0/widgets.json 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
 47e1fb5376 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-env.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/55291/diff/


Testing
---


Thanks,

Apoorv Naik

Re: Review Request 55574: Setup the correct authentication and authorization between ZooKeeper and oozie

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55574/#review161790
---


Ship it!




Ship It!

- Oliver Szabo


On Jan. 16, 2017, 7:07 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55574/
> ---
> 
> (Updated Jan. 16, 2017, 7:07 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-19568
> https://issues.apache.org/jira/browse/AMBARI-19568
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The communication between ZooKeeper and Oozie must be secure when kerberos is 
> enabled. This can be achieved setting by oozie.zookeeper.secure property to 
> true in oozie-site.xml. This makes oozie to install secure permissions to its 
> znodes. These permissions should be removed when we disable kerberos.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  14a0b23 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  e0778da 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  f9c608e 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/templates/zkmigrator_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/kerberos.json
>  d2e2ab8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  fd7fac9 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json
>  dd87b72 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> d24d0b9 
>   
> contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/properties/stack_features.json
>  645e357 
> 
> Diff: https://reviews.apache.org/r/55574/diff/
> 
> 
> Testing
> ---
> 
> Manual testing:
>   - created a cluster with oozie
>   - enabled oozie ha mode
>   - enabled kerberos
>   - checked that ACLs on /oozie was sasl:oozie:crdwa
>   - disabled kerberos
>   - checked that ACLs on /oozie was world:anyone:crdwa
>  
> Run all tests in ambari-server and ambari-agent. Failure was irrelevant.
> 
> FAIL: test_start_default (test_kms_server.TestRangerKMS)
> Traceback (most recent call last):
>   File 
> "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1199, in patched
> return func(*args, **keywargs)
>   File 
> "/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py",
>  line 73, in test_start_default
> mode = 0644
>   File 
> "/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
>  line 282, in assertResourceCalled
> self.assertEquals(kwargs, resource.arguments)
> AssertionError: {'owner': 'kms', 'content': '\n2017-01-16 
> 17:18:35\n< [truncated]... != {'content': 
> '\n2017-01-16 17:18:34\n', 'owne 
> [truncated]...
> - {'content': '\n2017-01-16 17:18:35\n',
> ?   ^
> 
> + {'content': '\n2017-01-16 17:18:34\n',
> ?
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 55291: AMBARI-19411: Atlas AMS support

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55291/
---

(Updated Jan. 16, 2017, 9:50 p.m.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Changes
---

Config name changes and some code refactoring.


Repository: ambari


Description
---

AMBARI-19411: Atlas AMS support


Diffs (updated)
-

  ambari-metrics/ambari-metrics-assembly/pom.xml cdcc2a7181 
  ambari-metrics/ambari-metrics-assembly/src/main/package/deb/control/postinst 
e75d557027 
  
ambari-metrics/ambari-metrics-assembly/src/main/package/rpm/sink/postinstall.sh 
e75d557027 
  ambari-metrics/ambari-metrics-atlas-sink/pom.xml PRE-CREATION 
  ambari-metrics/ambari-metrics-atlas-sink/src/main/assemblies/empty.xml 
PRE-CREATION 
  
ambari-metrics/ambari-metrics-atlas-sink/src/main/assemblies/jar-with-common.xml
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-atlas-sink/src/main/java/org/apache/hadoop/metrics/sink/atlas/AtlasMetricsReporter.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-atlas-sink/src/test/java/org/apache/hadoop/metrics2/sink/atlas/AtlasMetricsReporterTest.java
 PRE-CREATION 
  ambari-metrics/pom.xml 2d88912695 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 94193be5ee 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0/configuration/application-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0/configuration/atlas-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0/configuration/atlas-solrconfig.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0/quicklinks/quicklinks.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.8.0.0/themes/theme.json
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
 47e1fb5376 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-env.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/55291/diff/


Testing
---


Thanks,

Apoorv Naik

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/#review161781
---


Ship it!




Ship It!

- Jayush Luniya


On Jan. 16, 2017, 6:45 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55538/
> ---
> 
> (Updated Jan. 16, 2017, 6:45 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19545
> https://issues.apache.org/jira/browse/AMBARI-19545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
> to desired location
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  21135ea5c65563716dc1fe5db0d533970d9fdb53 
> 
> Diff: https://reviews.apache.org/r/55538/diff/
> 
> 
> Testing
> ---
> 
> ** 1. Manual testing **
> 
> Deployed all the modified files to a VM and manually verified that the JCEKS 
> files were generated at the location specified in the configuration, and that 
> the ACLs were also applied correctly.
> 
> ** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36.153s
> [INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
> [INFO] Final Memory: 56M/603M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Review Request 55586: Cannot change group/user privileges in list view if the user has VIEW.USER privilege

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55586/
---

Review request for Ambari, Oleg Nechiporenko and Richard Zang.


Bugs: AMBARI-19542
https://issues.apache.org/jira/browse/AMBARI-19542


Repository: ambari


Description
---

1. Create a view for e.g. Capacity Scheduler view and grant a group / user 
permissions for the view.
2. Go to Roles list view. Try to assign the group / user a different role via 
the List view.

There is no response in the UI and the role is not updated. On the browser 
console, the following erorr can be seen.

DELETE 
http://9.30.56.80:8081/api/v1/clusters/C1/privileges?PrivilegeInfo/privilege_id.in(416)
 500 (Internal Server Error)

In the ambari-server.log, the following exception is seen:

Caused by: org.apache.ambari.server.AmbariException: Can't remove VIEW 
permission from a CAPACITY-SCHEDULER{1.0.0} resource.
at 
org.apache.ambari.server.controller.internal.PrivilegeResourceProvider$2.invoke(PrivilegeResourceProvider.java:460)

This does not happen when roles are assigned via the Block view.

This seems to be because the VIEW.USER privilege is also being passed in as one 
of the privileges to be deleted when the role is being changed in the List view.

To fix this, the arrayOfPrivileges passed in for deletion to the backend should 
not contain VIEW.USER privilege.


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
 9869d0b 

Diff: https://reviews.apache.org/r/55586/diff/


Testing
---

Manual testing
Ran mvn test


Thanks,

Sangeeta Ravindran

Re: Review Request 55574: Setup the correct authentication and authorization between ZooKeeper and oozie

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55574/#review161779
---


Ship it!




Ship It!

- Sebastian Toader


On Jan. 16, 2017, 8:07 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55574/
> ---
> 
> (Updated Jan. 16, 2017, 8:07 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-19568
> https://issues.apache.org/jira/browse/AMBARI-19568
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The communication between ZooKeeper and Oozie must be secure when kerberos is 
> enabled. This can be achieved setting by oozie.zookeeper.secure property to 
> true in oozie-site.xml. This makes oozie to install secure permissions to its 
> znodes. These permissions should be removed when we disable kerberos.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  14a0b23 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  e0778da 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  f9c608e 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/templates/zkmigrator_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/kerberos.json
>  d2e2ab8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  fd7fac9 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json
>  dd87b72 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> d24d0b9 
>   
> contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/properties/stack_features.json
>  645e357 
> 
> Diff: https://reviews.apache.org/r/55574/diff/
> 
> 
> Testing
> ---
> 
> Manual testing:
>   - created a cluster with oozie
>   - enabled oozie ha mode
>   - enabled kerberos
>   - checked that ACLs on /oozie was sasl:oozie:crdwa
>   - disabled kerberos
>   - checked that ACLs on /oozie was world:anyone:crdwa
>  
> Run all tests in ambari-server and ambari-agent. Failure was irrelevant.
> 
> FAIL: test_start_default (test_kms_server.TestRangerKMS)
> Traceback (most recent call last):
>   File 
> "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1199, in patched
> return func(*args, **keywargs)
>   File 
> "/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py",
>  line 73, in test_start_default
> mode = 0644
>   File 
> "/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
>  line 282, in assertResourceCalled
> self.assertEquals(kwargs, resource.arguments)
> AssertionError: {'owner': 'kms', 'content': '\n2017-01-16 
> 17:18:35\n< [truncated]... != {'content': 
> '\n2017-01-16 17:18:34\n', 'owne 
> [truncated]...
> - {'content': '\n2017-01-16 17:18:35\n',
> ?   ^
> 
> + {'content': '\n2017-01-16 17:18:34\n',
> ?
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 55574: Setup the correct authentication and authorization between ZooKeeper and oozie

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55574/#review161778
---


Ship it!




Ship It!

- Robert Levas


On Jan. 16, 2017, 2:07 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55574/
> ---
> 
> (Updated Jan. 16, 2017, 2:07 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-19568
> https://issues.apache.org/jira/browse/AMBARI-19568
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The communication between ZooKeeper and Oozie must be secure when kerberos is 
> enabled. This can be achieved setting by oozie.zookeeper.secure property to 
> true in oozie-site.xml. This makes oozie to install secure permissions to its 
> znodes. These permissions should be removed when we disable kerberos.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  14a0b23 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  e0778da 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  f9c608e 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/templates/zkmigrator_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/kerberos.json
>  d2e2ab8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  fd7fac9 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json
>  dd87b72 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> d24d0b9 
>   
> contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/properties/stack_features.json
>  645e357 
> 
> Diff: https://reviews.apache.org/r/55574/diff/
> 
> 
> Testing
> ---
> 
> Manual testing:
>   - created a cluster with oozie
>   - enabled oozie ha mode
>   - enabled kerberos
>   - checked that ACLs on /oozie was sasl:oozie:crdwa
>   - disabled kerberos
>   - checked that ACLs on /oozie was world:anyone:crdwa
>  
> Run all tests in ambari-server and ambari-agent. Failure was irrelevant.
> 
> FAIL: test_start_default (test_kms_server.TestRangerKMS)
> Traceback (most recent call last):
>   File 
> "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1199, in patched
> return func(*args, **keywargs)
>   File 
> "/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py",
>  line 73, in test_start_default
> mode = 0644
>   File 
> "/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
>  line 282, in assertResourceCalled
> self.assertEquals(kwargs, resource.arguments)
> AssertionError: {'owner': 'kms', 'content': '\n2017-01-16 
> 17:18:35\n< [truncated]... != {'content': 
> '\n2017-01-16 17:18:34\n', 'owne 
> [truncated]...
> - {'content': '\n2017-01-16 17:18:35\n',
> ?   ^
> 
> + {'content': '\n2017-01-16 17:18:34\n',
> ?
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 54994: Enable alert scripts from stack extensions

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54994/#review161775
---



hi Diego, 

Can you please close this one since the fix is delivered to trunk ?

- Di Li


On Dec. 22, 2016, 8:59 p.m., Diego Santesteban wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54994/
> ---
> 
> (Updated Dec. 22, 2016, 8:59 p.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19283
> https://issues.apache.org/jira/browse/AMBARI-19283
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I added an "extensions_dir" parameter to the AlertSchedulerHandler class 
> initializer, and made necessary changes to implement the parameter in 
> script_alert.py, supply the parameter from Controller.py.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 234795b 
>   ambari-agent/src/main/python/ambari_agent/FileCache.py a9ea8f6 
>   ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 8dfa73e 
>   ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py 
> 1202c81 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py 2bddc43 
> 
> Diff: https://reviews.apache.org/r/54994/diff/
> 
> 
> Testing
> ---
> 
> I modified the existing tests to use the new "extensions_dir" parameter in 
> AlertSchedulerHandler, and added a new test case that ensures the parameter 
> is being used correctly. Then I executed 'mvn clean test' in the ambari-agent 
> directory, and all tests ran clean
> 
> 
> Output (partial):
> 
> test_execute_alert (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... 
> ok
> test_execute_alert_emptyCommands 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_execute_alert_from_extension 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_execute_alert_noneCommands 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_execute_alert_noneScheduler 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_ams 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_metric 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_none 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_port 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_web 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_load_definitions (TestAlertSchedulerHandler.TestAlertSchedulerHandler) 
> ... ok
> test_load_definitions_noFile 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_start (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> 
> 
> Thanks,
> 
> Diego Santesteban
> 
>

Review Request 55574: Setup the correct authentication and authorization between ZooKeeper and oozie

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55574/
---

Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, and 
Sebastian Toader.


Bugs: AMBARI-19568
https://issues.apache.org/jira/browse/AMBARI-19568


Repository: ambari


Description
---

The communication between ZooKeeper and Oozie must be secure when kerberos is 
enabled. This can be achieved setting by oozie.zookeeper.secure property to 
true in oozie-site.xml. This makes oozie to install secure permissions to its 
znodes. These permissions should be removed when we disable kerberos.


Diffs
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 14a0b23 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
 e0778da 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 f9c608e 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/templates/zkmigrator_jaas.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/kerberos.json 
d2e2ab8 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 fd7fac9 
  
ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json 
dd87b72 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d24d0b9 
  
contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/properties/stack_features.json
 645e357 

Diff: https://reviews.apache.org/r/55574/diff/


Testing
---

Manual testing:
  - created a cluster with oozie
  - enabled oozie ha mode
  - enabled kerberos
  - checked that ACLs on /oozie was sasl:oozie:crdwa
  - disabled kerberos
  - checked that ACLs on /oozie was world:anyone:crdwa
 
Run all tests in ambari-server and ambari-agent. Failure was irrelevant.

FAIL: test_start_default (test_kms_server.TestRangerKMS)
Traceback (most recent call last):
  File 
"/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py", 
line 1199, in patched
return func(*args, **keywargs)
  File 
"/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py",
 line 73, in test_start_default
mode = 0644
  File 
"/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
 line 282, in assertResourceCalled
self.assertEquals(kwargs, resource.arguments)
AssertionError: {'owner': 'kms', 'content': '\n2017-01-16 
17:18:35\n< [truncated]... != {'content': 
'\n2017-01-16 17:18:34\n', 'owne 
[truncated]...
- {'content': '\n2017-01-16 17:18:35\n',
?   ^

+ {'content': '\n2017-01-16 17:18:34\n',
?


Thanks,

Attila Magyar

Re: Review Request 55556: ranger_usersync should install with ranger_admin in the same host

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6/#review161773
---




ambari-web/app/models/stack_service_component.js (line 200)


Can this come from metainfo instead of being hardcoded on the UI?

Please add Jaimin Jetly for input.


- Alejandro Fernandez


On Jan. 16, 2017, 2:32 p.m., alice alice wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6/
> ---
> 
> (Updated Jan. 16, 2017, 2:32 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Zhe (Joe) 
> Wang, Richard Zang, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19557
> https://issues.apache.org/jira/browse/AMBARI-19557
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> http://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.3.0/bk_Ranger_Install_Guide/content/ch03s01.html??
> The Ranger Admin and Ranger Usersync services must be installed on the same 
> cluster node.
> so we'd betted install ranger_admin and ranger_usersync in same cluster node 
> in instaling at managing master hostcomponent
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/stack_service_component.js 17c2aa1 
> 
> Diff: https://reviews.apache.org/r/6/diff/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> Thanks,
> 
> alice alice
> 
>

Re: Review Request 55504: AMBARI-19529 : Atlas service check should fail only if all metadata servers are down.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55504/#review161771
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 13, 2017, 4:28 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55504/
> ---
> 
> (Updated Jan. 13, 2017, 4:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19529
> https://issues.apache.org/jira/browse/AMBARI-19529
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On Atlas-HA environments, Atlas service check fails even if one of the hosts 
> is down, the service check should only fail when All the Atlas metadata 
> servers are down.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  3525f3e 
> 
> Diff: https://reviews.apache.org/r/55504/diff/
> 
> 
> Testing
> ---
> 
> Verified fresh installation on centos-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 55515: Perf: Create Rolling and Express Upgrade Packs

[Jonathan Hurley]

> On Jan. 16, 2017, 8:03 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml,
> >  line 29
> > 
> >
> > Any reason this 100% dummy stack would use actual hadoop names? It 
> > would cause ligitimate greps to return lots of "who cares" hits from this 
> > stack.
> 
> Dmitro Lisnichenko wrote:
> I think Alejandro is planning to use PERF stack also for testing HA 
> modes, because actual hadoop names were present at original PERF stack
> 
> Alejandro Fernandez wrote:
> I'm ok if a future patch changes the name by appending "FAKE", but I 
> still think a grep would should up.
> We actually want to borrow a lot of the metainfo and configs from actual 
> services.

Why is that? The "PERF" stack could be all Disney names for all we care - the 
point is to demonstrate that:

- Ambari has no hard codings for specific services/components
- That Ambari can scale

None of that requires real metainfo - it's just confusing.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55515/#review161725
---


On Jan. 13, 2017, 2:03 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55515/
> ---
> 
> (Updated Jan. 13, 2017, 2:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18739
> https://issues.apache.org/jira/browse/AMBARI-18739
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Also includes code for AMBARI-18738. Perf: Allow components to report their 
> version using distro-select and change configs using conf-select
> 
> In order to run Rolling/Express Upgrade, will need to create the 
> Rolling/NonRolling Upgrade Packs and potentially config packs if we decide to 
> do it across major versions.
> 
> This means each service will need to support start commands with the 
> upgrade_type option, have symlinks already in distro-select, etc.
> 
> At first, this can be a handful of services.
> The goal is to simulate Rolling/Express Upgrade on the PERF stack.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py d75fc0cef2 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  513ceac8dd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  615a0cdcbc 
>   ambari-common/src/main/python/resource_management/libraries/script/dummy.py 
> 3dcece501d 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 
> 4dec16f372 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> d70e87fb1e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/distro-select.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/metainfo.xml 
> 15c5cfddd2 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
> 53cc11b7eb 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml 
> f1f4b7d1ac 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/metainfo.xml 
> 42edc8d493 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/datanode.py
>  6fc338b1da 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/journalnode.py
>  96be63060a 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/namenode.py
>  c3488e8bcc 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SLEEPY/metainfo.xml 
> 5b4dbd4a2d 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/metainfo.xml 
> 21e685ad80 
>   

Re: Review Request 55515: Perf: Create Rolling and Express Upgrade Packs

[Jonathan Hurley]

> On Jan. 16, 2017, 1:40 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/PERF/install_packages.py, line 41
> > 
> >
> > How much of this was copied from the one in HDP?
> > Can we derive both from a base class?

As the PERF stack is a fake stack used for specific tests, I don't think any 
production code should be derived from it. 

It's fine if PERF extends/overrides real stack code and alters behavior, but we 
should not have both test and production code trying to have shared logic. a


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55515/#review161768
---


On Jan. 13, 2017, 2:03 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55515/
> ---
> 
> (Updated Jan. 13, 2017, 2:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18739
> https://issues.apache.org/jira/browse/AMBARI-18739
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Also includes code for AMBARI-18738. Perf: Allow components to report their 
> version using distro-select and change configs using conf-select
> 
> In order to run Rolling/Express Upgrade, will need to create the 
> Rolling/NonRolling Upgrade Packs and potentially config packs if we decide to 
> do it across major versions.
> 
> This means each service will need to support start commands with the 
> upgrade_type option, have symlinks already in distro-select, etc.
> 
> At first, this can be a handful of services.
> The goal is to simulate Rolling/Express Upgrade on the PERF stack.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py d75fc0cef2 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  513ceac8dd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  615a0cdcbc 
>   ambari-common/src/main/python/resource_management/libraries/script/dummy.py 
> 3dcece501d 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 
> 4dec16f372 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> d70e87fb1e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/distro-select.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/metainfo.xml 
> 15c5cfddd2 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
> 53cc11b7eb 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml 
> f1f4b7d1ac 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/metainfo.xml 
> 42edc8d493 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/datanode.py
>  6fc338b1da 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/journalnode.py
>  96be63060a 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/namenode.py
>  c3488e8bcc 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SLEEPY/metainfo.xml 
> 5b4dbd4a2d 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/metainfo.xml 
> 21e685ad80 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/metainfo.xml 
> bb2191b267 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/ZOOKEEPER/metainfo.xml
>  57667bb888 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/nonrolling-upgrade-2.0.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/upgrade-2.0.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/install_packages.py 
> 

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/
---

(Updated Jan. 16, 2017, 10:45 a.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
Sumit Mohanty.


Changes
---

Use StaticFile() instead of shutil.move()


Bugs: AMBARI-19545
https://issues.apache.org/jira/browse/AMBARI-19545


Repository: ambari


Description
---

AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
to desired location


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 21135ea5c65563716dc1fe5db0d533970d9fdb53 

Diff: https://reviews.apache.org/r/55538/diff/


Testing
---

** 1. Manual testing **

Deployed all the modified files to a VM and manually verified that the JCEKS 
files were generated at the location specified in the configuration, and that 
the ACLs were also applied correctly.

** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **

Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 36.153s
[INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
[INFO] Final Memory: 56M/603M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 55515: Perf: Create Rolling and Express Upgrade Packs

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55515/#review161768
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/distro-select.py
 (line 27)


Nice, this is a nice template for other stacks.



ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
 (line 30)


let's make a variable here for the stack name and version so it's easier to 
find any hardcodings.



ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/nonrolling-upgrade-2.0.xml
 (line 22)


Nice!



ambari-server/src/main/resources/stacks/PERF/install_packages.py (line 41)


How much of this was copied from the one in HDP?
Can we derive both from a base class?


- Alejandro Fernandez


On Jan. 13, 2017, 7:03 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55515/
> ---
> 
> (Updated Jan. 13, 2017, 7:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18739
> https://issues.apache.org/jira/browse/AMBARI-18739
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Also includes code for AMBARI-18738. Perf: Allow components to report their 
> version using distro-select and change configs using conf-select
> 
> In order to run Rolling/Express Upgrade, will need to create the 
> Rolling/NonRolling Upgrade Packs and potentially config packs if we decide to 
> do it across major versions.
> 
> This means each service will need to support start commands with the 
> upgrade_type option, have symlinks already in distro-select, etc.
> 
> At first, this can be a handful of services.
> The goal is to simulate Rolling/Express Upgrade on the PERF stack.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py d75fc0cef2 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  513ceac8dd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  615a0cdcbc 
>   ambari-common/src/main/python/resource_management/libraries/script/dummy.py 
> 3dcece501d 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 
> 4dec16f372 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> d70e87fb1e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/distro-select.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/metainfo.xml 
> 15c5cfddd2 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
> 53cc11b7eb 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml 
> f1f4b7d1ac 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/metainfo.xml 
> 42edc8d493 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/datanode.py
>  6fc338b1da 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/journalnode.py
>  96be63060a 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/namenode.py
>  c3488e8bcc 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SLEEPY/metainfo.xml 
> 5b4dbd4a2d 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/metainfo.xml 
> 21e685ad80 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/metainfo.xml 
> bb2191b267 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/ZOOKEEPER/metainfo.xml
>  57667bb888 

Re: Review Request 55515: Perf: Create Rolling and Express Upgrade Packs

[Alejandro Fernandez]

> On Jan. 16, 2017, 1:03 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml,
> >  line 29
> > 
> >
> > Any reason this 100% dummy stack would use actual hadoop names? It 
> > would cause ligitimate greps to return lots of "who cares" hits from this 
> > stack.
> 
> Dmitro Lisnichenko wrote:
> I think Alejandro is planning to use PERF stack also for testing HA 
> modes, because actual hadoop names were present at original PERF stack

I'm ok if a future patch changes the name by appending "FAKE", but I still 
think a grep would should up.
We actually want to borrow a lot of the metainfo and configs from actual 
services.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55515/#review161725
---


On Jan. 13, 2017, 7:03 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55515/
> ---
> 
> (Updated Jan. 13, 2017, 7:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18739
> https://issues.apache.org/jira/browse/AMBARI-18739
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Also includes code for AMBARI-18738. Perf: Allow components to report their 
> version using distro-select and change configs using conf-select
> 
> In order to run Rolling/Express Upgrade, will need to create the 
> Rolling/NonRolling Upgrade Packs and potentially config packs if we decide to 
> do it across major versions.
> 
> This means each service will need to support start commands with the 
> upgrade_type option, have symlinks already in distro-select, etc.
> 
> At first, this can be a handful of services.
> The goal is to simulate Rolling/Express Upgrade on the PERF stack.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py d75fc0cef2 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  513ceac8dd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  615a0cdcbc 
>   ambari-common/src/main/python/resource_management/libraries/script/dummy.py 
> 3dcece501d 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 
> 4dec16f372 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> d70e87fb1e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/distro-select.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/metainfo.xml 
> 15c5cfddd2 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
> 53cc11b7eb 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml 
> f1f4b7d1ac 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/metainfo.xml 
> 42edc8d493 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/datanode.py
>  6fc338b1da 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/journalnode.py
>  96be63060a 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/namenode.py
>  c3488e8bcc 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SLEEPY/metainfo.xml 
> 5b4dbd4a2d 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/metainfo.xml 
> 21e685ad80 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/metainfo.xml 
> bb2191b267 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/ZOOKEEPER/metainfo.xml
>  57667bb888 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/nonrolling-upgrade-2.0.xml
>  PRE-CREATION 
>   

Re: Review Request 55584: AMBARI-19537: Provide default value for yarn leveldb state store path

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55584/#review161763
---


Ship it!




Ship It!

- Tim Thorpe


On Jan. 16, 2017, 6:12 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55584/
> ---
> 
> (Updated Jan. 16, 2017, 6:12 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19537
> https://issues.apache.org/jira/browse/AMBARI-19537
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide default value for yarn leveldb state store path
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  2fb7bff 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
>  23a25a0 
> 
> Diff: https://reviews.apache.org/r/55584/diff/
> 
> 
> Testing
> ---
> 
> existing unit tests
> build rpms off trunk source code and deploy a cluster.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 55584: AMBARI-19537: Provide default value for yarn leveldb state store path

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55584/
---

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-19537
https://issues.apache.org/jira/browse/AMBARI-19537


Repository: ambari


Description
---

Provide default value for yarn leveldb state store path


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 2fb7bff 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
 23a25a0 

Diff: https://reviews.apache.org/r/55584/diff/


Testing
---

existing unit tests
build rpms off trunk source code and deploy a cluster.


Thanks,

Di Li

Re: Review Request 55182: Add common log rotation settings to ranger, ranger-kms and falcon

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55182/#review161762
---


Ship it!




Ship It!

- Jayush Luniya


On Jan. 5, 2017, 4:33 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55182/
> ---
> 
> (Updated Jan. 5, 2017, 4:33 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19368
> https://issues.apache.org/jira/browse/AMBARI-19368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add common log rotation settings to ranger, ranger-kms and falcon
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml
>  ecf68a9 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  4a12b9f 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  6d1ae03 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  ddbd9d7 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  ac4e54e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml
>  9f0cdbf 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml
>  afeb422 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml
>  768c153 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml
>  20b2dc1 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  7fb8ba6 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  82dcb6b 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py 
> 8079147 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 4ad5c0f 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json 49c8a7b 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 
> f2a0405 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 
> 8e8e68b 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py 
> f5e55b3 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 
> 36fa15b 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> 3d79e0a 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 
> 32219b3 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 
> 42f75e2 
> 
> Diff: https://reviews.apache.org/r/55182/diff/
> 
> 
> Testing
> ---
> 
> Verified changes through API and Database
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55524: Add log rotation settings to Hive, Druid, Storm

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55524/#review161759
---


Ship it!




Ship It!

- Jayush Luniya


On Jan. 13, 2017, 9:48 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55524/
> ---
> 
> (Updated Jan. 13, 2017, 9:48 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19538
> https://issues.apache.org/jira/browse/AMBARI-19538
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add log rotation settings to Hive, Druid, Storm
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  f612766 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  c83b16e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-log4j.xml
>  cc837bb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-log4j.xml
>  96562df 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  58f01e6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  a515b62 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  aa116d6 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-cluster-log4j.xml
>  58e1791 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-worker-log4j.xml
>  adf57fa 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  c167d7c 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-cluster-log4j.xml
>  1709f0d 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-worker-log4j.xml
>  a1029a2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
>  6953530 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 2653254 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> bf9c208 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 6e97d15 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 
> 2b26dd8 
> 
> Diff: https://reviews.apache.org/r/55524/diff/
> 
> 
> Testing
> ---
> 
> Verified log4j rotation changes:
> UI
> DB
> API
> Disk
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/#review161758
---




ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 (line 68)


Please replace
  shutil.move(src_provider_path, dest_provider_path)
File(dest_provider_path,
  owner = params.oozie_user,
  group = params.user_group,
  mode = 0640
)

into

File(dest_provider_path,
  owner = params.oozie_user,
  group = params.user_group,
  mode = 0640,
  content = StaticFile(src_provider_path)
)


- Andrew Onischuk


On Jan. 16, 2017, 5:30 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55538/
> ---
> 
> (Updated Jan. 16, 2017, 5:30 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19545
> https://issues.apache.org/jira/browse/AMBARI-19545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
> to desired location
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  21135ea5c65563716dc1fe5db0d533970d9fdb53 
> 
> Diff: https://reviews.apache.org/r/55538/diff/
> 
> 
> Testing
> ---
> 
> ** 1. Manual testing **
> 
> Deployed all the modified files to a VM and manually verified that the JCEKS 
> files were generated at the location specified in the configuration, and that 
> the ACLs were also applied correctly.
> 
> ** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36.153s
> [INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
> [INFO] Final Memory: 56M/603M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/
---

(Updated Jan. 16, 2017, 9:30 a.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
Sumit Mohanty.


Changes
---

Added Andrew Onishuk to the review.


Bugs: AMBARI-19545
https://issues.apache.org/jira/browse/AMBARI-19545


Repository: ambari


Description
---

AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
to desired location


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 21135ea5c65563716dc1fe5db0d533970d9fdb53 

Diff: https://reviews.apache.org/r/55538/diff/


Testing
---

** 1. Manual testing **

Deployed all the modified files to a VM and manually verified that the JCEKS 
files were generated at the location specified in the configuration, and that 
the ACLs were also applied correctly.

** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **

Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 36.153s
[INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
[INFO] Final Memory: 56M/603M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 55582: Move Master and HA wizards for all components should show config changes that will be done as part of the wizard

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55582/#review161754
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Янв. 16, 2017, 4:48 п.п., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55582/
> ---
> 
> (Updated Янв. 16, 2017, 4:48 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19572
> https://issues.apache.org/jira/browse/AMBARI-19572
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Move master and HA wizard usually shows config changes on "Review" page. 
> As part of this ticket, we need to verify that this is being done for such 
> wizards for all components and we are not missing for any component. 
> Basically no config is being changed without letting user preview it on "Move 
> Master" and "component HA" wizard for any component.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step1_controller.js 
> 9f30bb7 
>   ambari-web/app/controllers/main/service/reassign/step3_controller.js 
> d717dea 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> c9cc28f 
>   ambari-web/app/controllers/main/service/reassign_controller.js 07d6e2c 
>   ambari-web/app/messages.js 7ed5826 
>   ambari-web/app/routes/reassign_master_routes.js 10ad0e9 
>   ambari-web/app/styles/wizard.less 2dbdd03 
>   ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs 
> 0cd177d 
>   ambari-web/app/templates/main/service/reassign/step3.hbs 1f88fb5 
>   ambari-web/app/views/main/service/reassign/step3_view.js 003fcb6 
>   ambari-web/app/views/main/service/reassign/step5_view.js 3a063b5 
>   ambari-web/test/controllers/main/service/reassign/step1_controller_test.js 
> a43d91f 
>   ambari-web/test/controllers/main/service/reassign/step3_controller_test.js 
> e433f47 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 9a73524 
> 
> Diff: https://reviews.apache.org/r/55582/diff/
> 
> 
> Testing
> ---
> 
> 20389 tests complete (35 seconds)
>   153 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Review Request 55582: Move Master and HA wizards for all components should show config changes that will be done as part of the wizard

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55582/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19572
https://issues.apache.org/jira/browse/AMBARI-19572


Repository: ambari


Description
---

Move master and HA wizard usually shows config changes on "Review" page. 
As part of this ticket, we need to verify that this is being done for such 
wizards for all components and we are not missing for any component. Basically 
no config is being changed without letting user preview it on "Move Master" and 
"component HA" wizard for any component.


Diffs
-

  ambari-web/app/controllers/main/service/reassign/step1_controller.js 9f30bb7 
  ambari-web/app/controllers/main/service/reassign/step3_controller.js d717dea 
  ambari-web/app/controllers/main/service/reassign/step4_controller.js c9cc28f 
  ambari-web/app/controllers/main/service/reassign_controller.js 07d6e2c 
  ambari-web/app/messages.js 7ed5826 
  ambari-web/app/routes/reassign_master_routes.js 10ad0e9 
  ambari-web/app/styles/wizard.less 2dbdd03 
  ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs 
0cd177d 
  ambari-web/app/templates/main/service/reassign/step3.hbs 1f88fb5 
  ambari-web/app/views/main/service/reassign/step3_view.js 003fcb6 
  ambari-web/app/views/main/service/reassign/step5_view.js 3a063b5 
  ambari-web/test/controllers/main/service/reassign/step1_controller_test.js 
a43d91f 
  ambari-web/test/controllers/main/service/reassign/step3_controller_test.js 
e433f47 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
9a73524 

Diff: https://reviews.apache.org/r/55582/diff/


Testing
---

20389 tests complete (35 seconds)
  153 tests pending


Thanks,

Andriy Babiichuk

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/
---

(Updated Jan. 16, 2017, 8:03 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.


Changes
---

Use the configuration directory specified in the stack scripts instead of 
hard-coding them in the configs.


Bugs: AMBARI-19545
https://issues.apache.org/jira/browse/AMBARI-19545


Repository: ambari


Description
---

AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
to desired location


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 21135ea5c65563716dc1fe5db0d533970d9fdb53 

Diff: https://reviews.apache.org/r/55538/diff/


Testing
---

** 1. Manual testing **

Deployed all the modified files to a VM and manually verified that the JCEKS 
files were generated at the location specified in the configuration, and that 
the ACLs were also applied correctly.

** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **

Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 36.153s
[INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
[INFO] Final Memory: 56M/603M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 55513: Use common property for principal name prefix to help with customization of unique principal names

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55513/#review161749
---


Ship it!




Ship It!

- Sebastian Toader


On Jan. 13, 2017, 7:14 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55513/
> ---
> 
> (Updated Jan. 13, 2017, 7:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Attila Magyar, Eugene 
> Chekanskiy, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19430
> https://issues.apache.org/jira/browse/AMBARI-19430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use common property for principal name prefix to help with customization of 
> unique principal names.  
> 
> All _headless_ Kerberos identities have a non-unique principal name (across 
> clusters). To help this issue, the cluster name is appended to these 
> principal names by adding "-${cluster-name|toLower()}" after the principal 
> name component. If the user wants to change this convention, they will need 
> to find all _headless_ principals and make the change. On top of that, when 
> adding new components, they will need to remember to make the change to new 
> _headless_ principal names. 
> 
> A better solution is to provide a _global_ property named "principal_suffix" 
> and use that in each _headless_ principal name. By default the value for this 
> property will be
> 
> ```
> principal_suffix="-${cluster_name|toLower()}"
> ```
> 
> If the user would like not use a prefix (in the event there is only a single 
> cluster connecting to the KDC), the value can be changed to
> 
> ```
> principal_suffix=""
> ```
> 
> Finally if the user would like to use some other randomizer, they can set the 
> value to something else. For example
> 
> ```
> principal_suffix="_12345"
> ```
> 
> The property is set in the Kerberos descriptor's "properties" block.   For 
> example:
> 
> ```
> {
>   "properties": {
> "realm": "${kerberos-env/realm}",
> ...,
> "principal_suffix": "-${cluster_name|toLower()}"
>   },
>   "identities": [
> ..., 
> {
>   "name": "smokeuser",
>   "principal": {
> "value": "${cluster-env/smokeuser}${principal_suffix}@${realm}",
> "type": "user",
> "configuration": "cluster-env/smokeuser_principal_name",
> "local_username": "${cluster-env/smokeuser}"
>   },
>   ...
> }
>   ],
>   "services": [
> {
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json
>  d53205d 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
>  caef123 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  636d36e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> f30c9e4 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json 
> 1dd801b 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.1/kerberos.json 
> fa6af33 
>   ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
> e7f78cd 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> 20e1dc0 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 
> fcfe524 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> 3068226 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
>  7c4c04c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json 9579d0f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/ECS/kerberos.json
>  9668354 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/HBASE/kerberos.json
>  20b10f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/ACCUMULO/kerberos.json
>  678a2b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/kerberos.json
>  0fec0ab 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 9ed40ef 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
> 9000e95 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> bd6c6c1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
> ae0d631 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
> a16e2e1 
>   ambari-server/src/main/resources/stacks/HDP/3.0/kerberos.json 9579d0f 
>   ambari-server/src/main/resources/stacks/PERF/1.0/kerberos.json a2a667b 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/kerberos.json
>  3bf5fbd 
>   
> 

Re: Review Request 55513: Use common property for principal name prefix to help with customization of unique principal names

[Robert Levas]

> On Jan. 16, 2017, 3:04 a.m., Sebastian Toader wrote:
> > Does this require any UI/backend api changes in order to allow users to 
> > change the ```principal_suffix``` later?

No UI changes are necessay.  The UI will automatically pick up the 
prefix_suffix property and label it as "Prefix Suffix" in the Enable Kerberos 
wizard and the Kerberos administration page.  If changed from the Kerberos 
administration page, Ambari will recreate the identities and keytab files.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55513/#review161690
---


On Jan. 13, 2017, 1:14 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55513/
> ---
> 
> (Updated Jan. 13, 2017, 1:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Attila Magyar, Eugene 
> Chekanskiy, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19430
> https://issues.apache.org/jira/browse/AMBARI-19430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use common property for principal name prefix to help with customization of 
> unique principal names.  
> 
> All _headless_ Kerberos identities have a non-unique principal name (across 
> clusters). To help this issue, the cluster name is appended to these 
> principal names by adding "-${cluster-name|toLower()}" after the principal 
> name component. If the user wants to change this convention, they will need 
> to find all _headless_ principals and make the change. On top of that, when 
> adding new components, they will need to remember to make the change to new 
> _headless_ principal names. 
> 
> A better solution is to provide a _global_ property named "principal_suffix" 
> and use that in each _headless_ principal name. By default the value for this 
> property will be
> 
> ```
> principal_suffix="-${cluster_name|toLower()}"
> ```
> 
> If the user would like not use a prefix (in the event there is only a single 
> cluster connecting to the KDC), the value can be changed to
> 
> ```
> principal_suffix=""
> ```
> 
> Finally if the user would like to use some other randomizer, they can set the 
> value to something else. For example
> 
> ```
> principal_suffix="_12345"
> ```
> 
> The property is set in the Kerberos descriptor's "properties" block.   For 
> example:
> 
> ```
> {
>   "properties": {
> "realm": "${kerberos-env/realm}",
> ...,
> "principal_suffix": "-${cluster_name|toLower()}"
>   },
>   "identities": [
> ..., 
> {
>   "name": "smokeuser",
>   "principal": {
> "value": "${cluster-env/smokeuser}${principal_suffix}@${realm}",
> "type": "user",
> "configuration": "cluster-env/smokeuser_principal_name",
> "local_username": "${cluster-env/smokeuser}"
>   },
>   ...
> }
>   ],
>   "services": [
> {
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json
>  d53205d 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
>  caef123 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  636d36e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> f30c9e4 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json 
> 1dd801b 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.1/kerberos.json 
> fa6af33 
>   ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
> e7f78cd 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> 20e1dc0 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 
> fcfe524 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> 3068226 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
>  7c4c04c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json 9579d0f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/ECS/kerberos.json
>  9668354 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/HBASE/kerberos.json
>  20b10f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/ACCUMULO/kerberos.json
>  678a2b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/kerberos.json
>  0fec0ab 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 9ed40ef 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
> 9000e95 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> bd6c6c1 
>   
> 

Re: Review Request 55579: Check python code for RU/EU checks to see if HOU should be considered

[Jonathan Hurley]

> On Jan. 16, 2017, 10:46 a.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml,
> >  lines 71-79
> > 
> >
> > Is this a holdover or just a miss from a previous commit?  It doesn't 
> > seem like it belongs with this patch.

Ugh! Nice catch - yes, this was from a git mistake. Thanks for catching...


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55579/#review161745
---


On Jan. 16, 2017, 9:49 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55579/
> ---
> 
> (Updated Jan. 16, 2017, 9:49 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-19571
> https://issues.apache.org/jira/browse/AMBARI-19571
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some python code, for example HDFS, change command arguments based on whether 
> an RU or EU is in-progress.  This JIRA should be used to comb-over all the 
> python code to see if there are any HOU considerations.
> 
> - Overall, I found that there wasn't too much to do as AMBARI-19344 fixed 
> much of the special-casing
> - I did go through and use constants where necessary to help us find usage in 
> the future
> - Some areas were doing `if upgrade_type is not None` - I think that this is 
> still OK for HOU. Although it may not be _necessary_ to perform operations 
> like rebuild WARs or backup directories, I don't think it hurts during a HOU.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  130c021 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  46df454 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/journalnode.py
>  46df454 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_server.py
>  3f2502a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 40052d8 
> 
> Diff: https://reviews.apache.org/r/55579/diff/
> 
> 
> Testing
> ---
> 
> --
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 52.931 s
> [INFO] Finished at: 2017-01-16T08:31:18-05:00
> [INFO] Final Memory: 19M/245M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 55515: Perf: Create Rolling and Express Upgrade Packs

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55515/#review161746
---




ambari-agent/src/main/python/ambari_agent/PythonExecutor.py (line 178)


By the way, we have always been passing full agent environment to python 
scripts. This environment was just dropped on first Execute()/shell.call() 
invocation and not passed to subscripts


- Dmitro Lisnichenko


On Jan. 13, 2017, 9:03 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55515/
> ---
> 
> (Updated Jan. 13, 2017, 9:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18739
> https://issues.apache.org/jira/browse/AMBARI-18739
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Also includes code for AMBARI-18738. Perf: Allow components to report their 
> version using distro-select and change configs using conf-select
> 
> In order to run Rolling/Express Upgrade, will need to create the 
> Rolling/NonRolling Upgrade Packs and potentially config packs if we decide to 
> do it across major versions.
> 
> This means each service will need to support start commands with the 
> upgrade_type option, have symlinks already in distro-select, etc.
> 
> At first, this can be a handful of services.
> The goal is to simulate Rolling/Express Upgrade on the PERF stack.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py d75fc0cef2 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  513ceac8dd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  615a0cdcbc 
>   ambari-common/src/main/python/resource_management/libraries/script/dummy.py 
> 3dcece501d 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 
> 4dec16f372 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> d70e87fb1e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/distro-select.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/metainfo.xml 
> 15c5cfddd2 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
> 53cc11b7eb 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml 
> f1f4b7d1ac 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/metainfo.xml 
> 42edc8d493 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/datanode.py
>  6fc338b1da 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/journalnode.py
>  96be63060a 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/namenode.py
>  c3488e8bcc 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SLEEPY/metainfo.xml 
> 5b4dbd4a2d 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/metainfo.xml 
> 21e685ad80 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/metainfo.xml 
> bb2191b267 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/ZOOKEEPER/metainfo.xml
>  57667bb888 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/nonrolling-upgrade-2.0.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/upgrade-2.0.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/install_packages.py 
> PRE-CREATION 
>   contrib/utils/perf/deploy-gce-perf-cluster.py 8ba7e42e0b 
> 
> Diff: https://reviews.apache.org/r/55515/diff/
> 
> 
> Testing
> ---
> 
> Tested on my local 3-node cluster (both upgrade and downgrade). 
> Script for creating Perf cluster downloads Ambari code from 

Re: Review Request 55579: Check python code for RU/EU checks to see if HOU should be considered

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55579/#review161745
---


Ship it!





ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
(lines 71 - 79)


Is this a holdover or just a miss from a previous commit?  It doesn't seem 
like it belongs with this patch.


- Nate Cole


On Jan. 16, 2017, 9:49 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55579/
> ---
> 
> (Updated Jan. 16, 2017, 9:49 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-19571
> https://issues.apache.org/jira/browse/AMBARI-19571
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some python code, for example HDFS, change command arguments based on whether 
> an RU or EU is in-progress.  This JIRA should be used to comb-over all the 
> python code to see if there are any HOU considerations.
> 
> - Overall, I found that there wasn't too much to do as AMBARI-19344 fixed 
> much of the special-casing
> - I did go through and use constants where necessary to help us find usage in 
> the future
> - Some areas were doing `if upgrade_type is not None` - I think that this is 
> still OK for HOU. Although it may not be _necessary_ to perform operations 
> like rebuild WARs or backup directories, I don't think it hurts during a HOU.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  130c021 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  46df454 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/journalnode.py
>  46df454 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_server.py
>  3f2502a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 40052d8 
> 
> Diff: https://reviews.apache.org/r/55579/diff/
> 
> 
> Testing
> ---
> 
> --
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 52.931 s
> [INFO] Finished at: 2017-01-16T08:31:18-05:00
> [INFO] Final Memory: 19M/245M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 55515: Perf: Create Rolling and Express Upgrade Packs

[Dmitro Lisnichenko]

> On Jan. 16, 2017, 3:03 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml,
> >  line 29
> > 
> >
> > Any reason this 100% dummy stack would use actual hadoop names? It 
> > would cause ligitimate greps to return lots of "who cares" hits from this 
> > stack.

I think Alejandro is planning to use PERF stack also for testing HA modes, 
because actual hadoop names were present at original PERF stack


> On Jan. 16, 2017, 3:03 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py,
> >  line 132
> > 
> >
> > This seems like it could change the behavior of all upgrades - what are 
> > the implications of passing in the `os.environ` to Execute/shell?
> 
> Nate Cole wrote:
> Agreed - the custom script also has access to os.environ, so it seems 
> like this is just adding more work when the perf stack can check it anyway.

The issue with environment is that by default Execute starts scripts with clean 
(like a new login shell) environment. That's why it's not possible to extract 
our env variables from a perf script. We use 
AGENT_CACHE_DIR/AMBARI_AGENT_HOST_DIR at distr-select tool to determine which 
agent started this script. Distr-select output may be specific for every agent. 
Otherwise, I don't see how I can archieve that given that all agents are 
running in a single process space, and not in different docker containers.

We may consider whitelisting AGENT_CACHE_DIR/AMBARI_AGENT_HOST_DIR variables at 
Execute and other RMF utils, in order to get them always passed into a child 
environment. Does that sound like a good approach?


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55515/#review161725
---


On Jan. 13, 2017, 9:03 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55515/
> ---
> 
> (Updated Jan. 13, 2017, 9:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18739
> https://issues.apache.org/jira/browse/AMBARI-18739
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Also includes code for AMBARI-18738. Perf: Allow components to report their 
> version using distro-select and change configs using conf-select
> 
> In order to run Rolling/Express Upgrade, will need to create the 
> Rolling/NonRolling Upgrade Packs and potentially config packs if we decide to 
> do it across major versions.
> 
> This means each service will need to support start commands with the 
> upgrade_type option, have symlinks already in distro-select, etc.
> 
> At first, this can be a handful of services.
> The goal is to simulate Rolling/Express Upgrade on the PERF stack.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py d75fc0cef2 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  513ceac8dd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  615a0cdcbc 
>   ambari-common/src/main/python/resource_management/libraries/script/dummy.py 
> 3dcece501d 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 
> 4dec16f372 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> d70e87fb1e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/distro-select.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/metainfo.xml 
> 15c5cfddd2 
>   
> 

Re: Review Request 55575: Ambari trunk build failing due to checkstyle

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55575/#review161741
---


Ship it!




Thanks!

- Attila Doroszlai


On Jan. 16, 2017, 3:14 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55575/
> ---
> 
> (Updated Jan. 16, 2017, 3:14 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Pallav Kulshreshtha, Rohit Choudhary, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19569
> https://issues.apache.org/jira/browse/AMBARI-19569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Corrected the order of imports as per checkstyle
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ClusterImpl.java 
> 05bbaa2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
>  8b7bed3 
> 
> Diff: https://reviews.apache.org/r/55575/diff/
> 
> 
> Testing
> ---
> 
> manually run the  mvn clean checkstyle:check in ambari-server trunk branch to 
> confirm
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 55579: Check python code for RU/EU checks to see if HOU should be considered

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55579/
---

Review request for Ambari and Nate Cole.


Bugs: AMBARI-19571
https://issues.apache.org/jira/browse/AMBARI-19571


Repository: ambari


Description
---

Some python code, for example HDFS, change command arguments based on whether 
an RU or EU is in-progress.  This JIRA should be used to comb-over all the 
python code to see if there are any HOU considerations.

- Overall, I found that there wasn't too much to do as AMBARI-19344 fixed much 
of the special-casing
- I did go through and use constants where necessary to help us find usage in 
the future
- Some areas were doing `if upgrade_type is not None` - I think that this is 
still OK for HOU. Although it may not be _necessary_ to perform operations like 
rebuild WARs or backup directories, I don't think it hurts during a HOU.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
 130c021 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
 46df454 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/journalnode.py
 46df454 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_server.py
 3f2502a 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
40052d8 

Diff: https://reviews.apache.org/r/55579/diff/


Testing
---

--
Total run:1159
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 52.931 s
[INFO] Finished at: 2017-01-16T08:31:18-05:00
[INFO] Final Memory: 19M/245M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 55575: Ambari trunk build failing due to checkstyle

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55575/#review161735
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 16, 2017, 2:14 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55575/
> ---
> 
> (Updated Jan. 16, 2017, 2:14 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Pallav Kulshreshtha, Rohit Choudhary, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19569
> https://issues.apache.org/jira/browse/AMBARI-19569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Corrected the order of imports as per checkstyle
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ClusterImpl.java 
> 05bbaa2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
>  8b7bed3 
> 
> Diff: https://reviews.apache.org/r/55575/diff/
> 
> 
> Testing
> ---
> 
> manually run the  mvn clean checkstyle:check in ambari-server trunk branch to 
> confirm
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 55575: Ambari trunk build failing due to checkstyle

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55575/#review161734
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 16, 2017, 2:14 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55575/
> ---
> 
> (Updated Jan. 16, 2017, 2:14 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Pallav Kulshreshtha, Rohit Choudhary, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19569
> https://issues.apache.org/jira/browse/AMBARI-19569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Corrected the order of imports as per checkstyle
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ClusterImpl.java 
> 05bbaa2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
>  8b7bed3 
> 
> Diff: https://reviews.apache.org/r/55575/diff/
> 
> 
> Testing
> ---
> 
> manually run the  mvn clean checkstyle:check in ambari-server trunk branch to 
> confirm
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 55556: ranger_usersync should install with ranger_admin in the same host

[alice alice]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6/
---

(Updated 一月 16, 2017, 2:32 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Zhe (Joe) Wang, 
Richard Zang, Sumit Mohanty, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-19557
https://issues.apache.org/jira/browse/AMBARI-19557


Repository: ambari


Description
---

http://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.3.0/bk_Ranger_Install_Guide/content/ch03s01.html??
The Ranger Admin and Ranger Usersync services must be installed on the same 
cluster node.
so we'd betted install ranger_admin and ranger_usersync in same cluster node in 
instaling at managing master hostcomponent


Diffs
-

  ambari-web/app/models/stack_service_component.js 17c2aa1 

Diff: https://reviews.apache.org/r/6/diff/


Testing
---

done it


Thanks,

alice alice

Re: Review Request 55515: Perf: Create Rolling and Express Upgrade Packs

[Nate Cole]

> On Jan. 16, 2017, 8:03 a.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py,
> >  line 132
> > 
> >
> > This seems like it could change the behavior of all upgrades - what are 
> > the implications of passing in the `os.environ` to Execute/shell?

Agreed - the custom script also has access to os.environ, so it seems like this 
is just adding more work when the perf stack can check it anyway.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55515/#review161725
---


On Jan. 13, 2017, 2:03 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55515/
> ---
> 
> (Updated Jan. 13, 2017, 2:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18739
> https://issues.apache.org/jira/browse/AMBARI-18739
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Also includes code for AMBARI-18738. Perf: Allow components to report their 
> version using distro-select and change configs using conf-select
> 
> In order to run Rolling/Express Upgrade, will need to create the 
> Rolling/NonRolling Upgrade Packs and potentially config packs if we decide to 
> do it across major versions.
> 
> This means each service will need to support start commands with the 
> upgrade_type option, have symlinks already in distro-select, etc.
> 
> At first, this can be a handful of services.
> The goal is to simulate Rolling/Express Upgrade on the PERF stack.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py d75fc0cef2 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  513ceac8dd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  615a0cdcbc 
>   ambari-common/src/main/python/resource_management/libraries/script/dummy.py 
> 3dcece501d 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 
> 4dec16f372 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> d70e87fb1e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/distro-select.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/metainfo.xml 
> 15c5cfddd2 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
> 53cc11b7eb 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml 
> f1f4b7d1ac 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/metainfo.xml 
> 42edc8d493 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/datanode.py
>  6fc338b1da 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/journalnode.py
>  96be63060a 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/namenode.py
>  c3488e8bcc 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SLEEPY/metainfo.xml 
> 5b4dbd4a2d 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/metainfo.xml 
> 21e685ad80 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/metainfo.xml 
> bb2191b267 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/ZOOKEEPER/metainfo.xml
>  57667bb888 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/nonrolling-upgrade-2.0.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/upgrade-2.0.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/install_packages.py 
> PRE-CREATION 
>   contrib/utils/perf/deploy-gce-perf-cluster.py 8ba7e42e0b 
> 

Re: Review Request 55575: Ambari trunk build failing due to checkstyle

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55575/#review161732
---


Ship it!




Ship It!

- Sebastian Toader


On Jan. 16, 2017, 3:14 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55575/
> ---
> 
> (Updated Jan. 16, 2017, 3:14 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Pallav Kulshreshtha, Rohit Choudhary, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19569
> https://issues.apache.org/jira/browse/AMBARI-19569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Corrected the order of imports as per checkstyle
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ClusterImpl.java 
> 05bbaa2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
>  8b7bed3 
> 
> Diff: https://reviews.apache.org/r/55575/diff/
> 
> 
> Testing
> ---
> 
> manually run the  mvn clean checkstyle:check in ambari-server trunk branch to 
> confirm
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 55575: Ambari trunk build failing due to checkstyle

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55575/
---

Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
Pallav Kulshreshtha, Rohit Choudhary, and Sebastian Toader.


Bugs: AMBARI-19569
https://issues.apache.org/jira/browse/AMBARI-19569


Repository: ambari


Description
---

Corrected the order of imports as per checkstyle


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/view/ClusterImpl.java 
05bbaa2 
  
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
 8b7bed3 

Diff: https://reviews.apache.org/r/55575/diff/


Testing
---

manually run the  mvn clean checkstyle:check in ambari-server trunk branch to 
confirm


Thanks,

Nitiraj Rathore

Re: Review Request 55523: When viewing details of a group, the group type is sometimes empty

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55523/#review161730
---


Ship it!




Ship It!

- Di Li


On Jan. 13, 2017, 9:43 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55523/
> ---
> 
> (Updated Jan. 13, 2017, 9:43 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-19535
> https://issues.apache.org/jira/browse/AMBARI-19535
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When you click on a Group and view its details, sometimes the Type shows an 
> empty value. 
> 
> The following error can be seen on the web console.
> 
> vendor.js:22245 TypeError: Cannot read property 'LABEL_KEY' of undefined at 
> main.js:2278 at wrappedCallback (vendor.js:23746) at vendor.js:23832 at 
> Scope.$eval (vendor.js:24875) at Scope.$digest (vendor.js:24687) at 
> Scope.$apply (vendor.js:24979) at done (vendor.js:20552) at completeRequest 
> (vendor.js:20766) at XMLHttpRequest.xhr.onreadystatechange (vendor.js:20705)
> 
> This is happenening because the REST call that fetches group type details 
> (getGroupType) does not always return before the groupTypeName is set in 
> getMembers. 
> To fix this, moved the code for setting groupTypeName to the getGroupType 
> method. The groupTypeName is now set once the group type has been retrieved 
> by the REST call.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js
>  aa6af2a 
> 
> Diff: https://reviews.apache.org/r/55523/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> Ran mvn test.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55478/#review161728
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml (lines 
527 - 534)


Missing 



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml (lines 
885 - 892)


Missing 



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml (lines 
560 - 567)


Missing 



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml (line 
631)


Collapse to 



ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml (lines 
612 - 619)


Missing 


- Jonathan Hurley


On Jan. 14, 2017, 12:06 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55478/
> ---
> 
> (Updated Jan. 14, 2017, 12:06 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-19541
> https://issues.apache.org/jira/browse/AMBARI-19541
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add log rotation settings - handle HDP upgrade scenario
> Changes:
> 1. Add a new task called "regex-replace" for configure-upgrade.xml
> 2. Add log4j changes for each service in upgrade-<>.xml and nonrolling-<>.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
>  5428ea7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
>  d7bb338 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> a1f03e8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  8c9414a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  4018da0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  42918ff 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> f80fcd8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> f150651 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 136fafe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  f58ca84 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  58ca724 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 2fb1367 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 9b3ce4e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 40052d8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  78418b0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 4abf0ec 
>   ambari-server/src/main/resources/upgrade-config.xsd e274451 
> 
> Diff: https://reviews.apache.org/r/55478/diff/
> 
> 
> Testing
> ---
> 
> NonRolling Upgrade path 2.5-2.6
> -Verified that the log4j changes appear for 
> (HDFS,YARN,ZOOKEEPER,AMS,OOZIE,KNOX,KAFKA,HBASE,FALCON) services.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

[Jonathan Hurley]

> On Jan. 13, 2017, 8:56 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java,
> >  line 226
> > 
> >
> > I don't think you want "desiredConfig" here - at the point where this 
> > runs in the upgrade, desired configurations are already moved to the new 
> > stack. That could cause invalid replacements.
> 
> Madhuvanthi Radhakrishnan wrote:
> Hi Jonathan,
> Since upgrade values do not automatically pick up the new values, I 
> thought these fixes are meant to be made in the final/desired configs. Also,
> In the final replacement stage, it is using the desiredConfig's content 
> to replace the values.
> In ConfigureAction.java - line 432 String replaced = 
> StringUtils.replace(toReplace, replacement.find, replacement.replaceWith);
> The toReplace is coming from newValues.get(replacement.key);
> Map newValues = new HashMap(base);
> Map base = config.getProperties();
> Config config = cluster.getConfig(configType, desiredConfig.getTag());
> 
> Please correct me if I am wrong. Thank you.

Hmmm - I suppose it's a double edged sword. You may need to replace values 
which were merged in correctly and at the same time, you might desire to not do 
that. To fix it, we'd need to explicitely state which configs (current, 
effective, desired) we wanted to change. That's too granular and kind of nuts. 
Let's drop this one.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55478/#review161523
---


On Jan. 14, 2017, 12:06 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55478/
> ---
> 
> (Updated Jan. 14, 2017, 12:06 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-19541
> https://issues.apache.org/jira/browse/AMBARI-19541
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add log rotation settings - handle HDP upgrade scenario
> Changes:
> 1. Add a new task called "regex-replace" for configure-upgrade.xml
> 2. Add log4j changes for each service in upgrade-<>.xml and nonrolling-<>.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
>  5428ea7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
>  d7bb338 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> a1f03e8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  8c9414a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  4018da0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  42918ff 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> f80fcd8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> f150651 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 136fafe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  f58ca84 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  58ca724 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 2fb1367 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 9b3ce4e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 40052d8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  78418b0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 4abf0ec 
>   ambari-server/src/main/resources/upgrade-config.xsd e274451 
> 
> Diff: https://reviews.apache.org/r/55478/diff/
> 
> 
> Testing
> ---
> 
> NonRolling Upgrade path 2.5-2.6
> -Verified that the log4j changes appear for 
> (HDFS,YARN,ZOOKEEPER,AMS,OOZIE,KNOX,KAFKA,HBASE,FALCON) services.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55515: Perf: Create Rolling and Express Upgrade Packs

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55515/#review161725
---




ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 (line 132)


This seems like it could change the behavior of all upgrades - what are the 
implications of passing in the `os.environ` to Execute/shell?



ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml 
(line 29)


Any reason this 100% dummy stack would use actual hadoop names? It would 
cause ligitimate greps to return lots of "who cares" hits from this stack.


- Jonathan Hurley


On Jan. 13, 2017, 2:03 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55515/
> ---
> 
> (Updated Jan. 13, 2017, 2:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18739
> https://issues.apache.org/jira/browse/AMBARI-18739
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Also includes code for AMBARI-18738. Perf: Allow components to report their 
> version using distro-select and change configs using conf-select
> 
> In order to run Rolling/Express Upgrade, will need to create the 
> Rolling/NonRolling Upgrade Packs and potentially config packs if we decide to 
> do it across major versions.
> 
> This means each service will need to support start commands with the 
> upgrade_type option, have symlinks already in distro-select, etc.
> 
> At first, this can be a handful of services.
> The goal is to simulate Rolling/Express Upgrade on the PERF stack.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py d75fc0cef2 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  513ceac8dd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  615a0cdcbc 
>   ambari-common/src/main/python/resource_management/libraries/script/dummy.py 
> 3dcece501d 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 
> 4dec16f372 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> d70e87fb1e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/distro-select.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/metainfo.xml 
> 15c5cfddd2 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
> 53cc11b7eb 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml 
> f1f4b7d1ac 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/metainfo.xml 
> 42edc8d493 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/datanode.py
>  6fc338b1da 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/journalnode.py
>  96be63060a 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/namenode.py
>  c3488e8bcc 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SLEEPY/metainfo.xml 
> 5b4dbd4a2d 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/metainfo.xml 
> 21e685ad80 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/metainfo.xml 
> bb2191b267 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/ZOOKEEPER/metainfo.xml
>  57667bb888 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/nonrolling-upgrade-2.0.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/upgrade-2.0.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/install_packages.py 
> PRE-CREATION 
>   

Re: Review Request 55494: Ambari agents not recovering from heart beat lost state immediately after successful re-registering with server

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55494/#review161724
---


Ship it!




Ship It!

- Andrew Onischuk


On Jan. 13, 2017, 1:59 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55494/
> ---
> 
> (Updated Jan. 13, 2017, 1:59 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Sandor Magyari, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-19520
> https://issues.apache.org/jira/browse/AMBARI-19520
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> 
> In case ambari server is restarted after restart will ask agents to 
> re-register with the server.
> Once the agent successfully re-registered with the server it should be 
> transition out from heartbeat lost state. However in some cases it takes a 
> while until agents transition out from heartbeat lost state thus the server 
> may request the agent to re-register again.
> 
> Solution:
> Ensure upon agent re-regsitration that StatusCommandExecutor child process is 
> spawned before status commands received from the server (in the response to 
> the registration) are added to the status command queue.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 6b1b196 
>   ambari-agent/src/main/python/ambari_agent/main.py 2e0517b 
> 
> Diff: https://reviews.apache.org/r/55494/diff/
> 
> 
> Testing
> ---
> 
> Manually tested covering:
> 1. Restart agent
> 2. Restart amabari-server with agents being up and running
> 3. Kill StatusCommandExecutor child process
> 
> Unit test results:
> 
> Total run:1158
> Total errors:0
> Total failures:0
> OK
> 
> Ran 452 tests in 20.976s
> 
> OK
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [10.142s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.029s]
> [INFO] Ambari Views .. SUCCESS [1.707s]
> [INFO] utility ... SUCCESS [1.189s]
> [INFO] ambari-metrics  SUCCESS [0.473s]
> [INFO] Ambari Metrics Common . SUCCESS [1.012s]
> [INFO] Ambari Server . SUCCESS [1:45.492s]
> [INFO] Ambari Agent .. SUCCESS [25.860s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 55513: Use common property for principal name prefix to help with customization of unique principal names

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55513/#review161720
---


Ship it!




Ship It!

- Laszlo Puskas


On Jan. 13, 2017, 6:14 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55513/
> ---
> 
> (Updated Jan. 13, 2017, 6:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Attila Magyar, Eugene 
> Chekanskiy, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19430
> https://issues.apache.org/jira/browse/AMBARI-19430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use common property for principal name prefix to help with customization of 
> unique principal names.  
> 
> All _headless_ Kerberos identities have a non-unique principal name (across 
> clusters). To help this issue, the cluster name is appended to these 
> principal names by adding "-${cluster-name|toLower()}" after the principal 
> name component. If the user wants to change this convention, they will need 
> to find all _headless_ principals and make the change. On top of that, when 
> adding new components, they will need to remember to make the change to new 
> _headless_ principal names. 
> 
> A better solution is to provide a _global_ property named "principal_suffix" 
> and use that in each _headless_ principal name. By default the value for this 
> property will be
> 
> ```
> principal_suffix="-${cluster_name|toLower()}"
> ```
> 
> If the user would like not use a prefix (in the event there is only a single 
> cluster connecting to the KDC), the value can be changed to
> 
> ```
> principal_suffix=""
> ```
> 
> Finally if the user would like to use some other randomizer, they can set the 
> value to something else. For example
> 
> ```
> principal_suffix="_12345"
> ```
> 
> The property is set in the Kerberos descriptor's "properties" block.   For 
> example:
> 
> ```
> {
>   "properties": {
> "realm": "${kerberos-env/realm}",
> ...,
> "principal_suffix": "-${cluster_name|toLower()}"
>   },
>   "identities": [
> ..., 
> {
>   "name": "smokeuser",
>   "principal": {
> "value": "${cluster-env/smokeuser}${principal_suffix}@${realm}",
> "type": "user",
> "configuration": "cluster-env/smokeuser_principal_name",
> "local_username": "${cluster-env/smokeuser}"
>   },
>   ...
> }
>   ],
>   "services": [
> {
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json
>  d53205d 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
>  caef123 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  636d36e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> f30c9e4 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json 
> 1dd801b 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.1/kerberos.json 
> fa6af33 
>   ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
> e7f78cd 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> 20e1dc0 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 
> fcfe524 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> 3068226 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
>  7c4c04c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json 9579d0f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/ECS/kerberos.json
>  9668354 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/HBASE/kerberos.json
>  20b10f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/ACCUMULO/kerberos.json
>  678a2b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/kerberos.json
>  0fec0ab 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 9ed40ef 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
> 9000e95 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> bd6c6c1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
> ae0d631 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
> a16e2e1 
>   ambari-server/src/main/resources/stacks/HDP/3.0/kerberos.json 9579d0f 
>   ambari-server/src/main/resources/stacks/PERF/1.0/kerberos.json a2a667b 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/kerberos.json
>  3bf5fbd 
>   
> 

Review Request 55573: Hive View 2.0: Export Query Result

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55573/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19566
https://issues.apache.org/jira/browse/AMBARI-19566


Repository: ambari


Description
---

Added save as HDFS and download As Csv feature.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/job.js e2f342e 
  contrib/views/hive20/src/main/resources/ui/app/components/export-result.js 
PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js 
429dfb3 
  contrib/views/hive20/src/main/resources/ui/app/components/save-hdfs.js 
05b3b33 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
d4c82fa 
  contrib/views/hive20/src/main/resources/ui/app/services/query.js d95a2e5 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/export-result.hbs
 PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
 4bda978 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/save-hdfs.hbs
 5b53102 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
120a045 

Diff: https://reviews.apache.org/r/55573/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 55569: Log Namenode formatting output into ambari-agent command logs

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55569/#review161719
---


Ship it!




Ship It!

- Attila Magyar


On Jan. 16, 2017, 11:07 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55569/
> ---
> 
> (Updated Jan. 16, 2017, 11:07 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-19559
> https://issues.apache.org/jira/browse/AMBARI-19559
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> NN is being formatted during it's first startup. The script used for 
> formatting NN logs to standard output which currently is being collected only 
> in DEBUG mode by ambari agent thus is lost in production environments where 
> the agent usually runs in non-DEBUG mode. The NN formatting log is useful for 
> trouble shooting thus these should be collected and written out into the NN 
> start command output log.
> This can be done by adding logoutput=True option to the NN format script 
> invocation within NN start script.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  cc03bb3 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py
>  2c0d691 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/hdfs_namenode.py
>  35e16d5 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py f76a7d7 
> 
> Diff: https://reviews.apache.org/r/55569/diff/
> 
> 
> Testing
> ---
> 
> Testing manually cluster creation with both using the wizzard and blueprint 
> (NN non-HA and HA).
> 
> Unit tests:
> 
> mvn test -Drat.skip=true -Dcheckstyle.skip -DskipSurefireTests
> 
> OK
> --
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 55572: NFS Gateway start fails during EU to HDP-2.5.3 with portmap error

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55572/#review161718
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 16, 2017, 2:33 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55572/
> ---
> 
> (Updated Jan. 16, 2017, 2:33 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19567
> https://issues.apache.org/jira/browse/AMBARI-19567
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Steps**
> 
>   1. Deploy cluster with Ambari version: 2.2.2.0 and HDP version: 2.4.3.0-227
>   2. Upgrade Ambari to Target Version: 2.5.0.0-513 (Hash: 
> 4f01102c087344f9aca78574756741ac190f9b19)
>   3. Register HDP-2.5.3.0 and install the bits
>   4. Start Express Upgrade to HDP-2.5.3.0
> 
> **Result**  
> NFS gateway start failed with error:
> 
> 
> 
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py",
>  line 147, in 
> NFSGateway().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 287, in execute
> method(env)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 729, in restart
> self.start(env, upgrade_type=upgrade_type)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py",
>  line 58, in start
> nfsgateway(action="start")
>   File 
> "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py",
>  line 61, in nfsgateway
> prepare_rpcbind()
>   File 
> "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py",
>  line 52, in prepare_rpcbind
> raise Fail("Failed to start rpcbind or portmap")
> resource_management.core.exceptions.Fail: Failed to start rpcbind or 
> portmap
> 
> 
> Checked on one of the hosts:
> 
> 
> 
> 
> [root@natr76-utrs-dgm20tofnmlevelsecha-r7-1 ~]# systemctl status 
> rpcbind.service
> ? rpcbind.service - RPC bind service
>Loaded: loaded (/usr/lib/systemd/system/rpcbind.service; enabled; 
> vendor preset: enabled)
>Active: failed (Result: exit-code) since Sun 2017-01-01 14:37:45 UTC; 
> 20h ago
>   Process: 31808 ExecStart=/sbin/rpcbind -w $RPCBIND_ARGS (code=exited, 
> status=127)
>  Main PID: 925 (code=exited, status=2)
> 
> Jan 01 14:37:45 natr76-utrs-dgm20tofnmlevelsecha-r7-1 systemd[1]: 
> Starting RPC bind service...
> Jan 01 14:37:45 natr76-utrs-dgm20tofnmlevelsecha-r7-1 rpcbind[31808]: 
> /sbin/rpcbind: symbol lookup error: /sbin/rpcbind: undefined symbol: 
> libtirpc_set_debug
> Jan 01 14:37:45 natr76-utrs-dgm20tofnmlevelsecha-r7-1 systemd[1]: 
> rpcbind.service: control process exited, code=exited status=127
> Jan 01 14:37:45 natr76-utrs-dgm20tofnmlevelsecha-r7-1 systemd[1]: Failed 
> to start RPC bind service.
> Jan 01 14:37:45 natr76-utrs-dgm20tofnmlevelsecha-r7-1 systemd[1]: Unit 
> rpcbind.service entered failed state.
> Jan 01 14:37:45 natr76-utrs-dgm20tofnmlevelsecha-r7-1 systemd[1]: 
> rpcbind.service failed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 9c1387d 
> 
> Diff: https://reviews.apache.org/r/55572/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 55572: NFS Gateway start fails during EU to HDP-2.5.3 with portmap error

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55572/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-19567
https://issues.apache.org/jira/browse/AMBARI-19567


Repository: ambari


Description
---

**Steps**

  1. Deploy cluster with Ambari version: 2.2.2.0 and HDP version: 2.4.3.0-227
  2. Upgrade Ambari to Target Version: 2.5.0.0-513 (Hash: 
4f01102c087344f9aca78574756741ac190f9b19)
  3. Register HDP-2.5.3.0 and install the bits
  4. Start Express Upgrade to HDP-2.5.3.0

**Result**  
NFS gateway start failed with error:




Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py",
 line 147, in 
NFSGateway().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 287, in execute
method(env)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 729, in restart
self.start(env, upgrade_type=upgrade_type)
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py",
 line 58, in start
nfsgateway(action="start")
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py",
 line 61, in nfsgateway
prepare_rpcbind()
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py",
 line 52, in prepare_rpcbind
raise Fail("Failed to start rpcbind or portmap")
resource_management.core.exceptions.Fail: Failed to start rpcbind or portmap


Checked on one of the hosts:




[root@natr76-utrs-dgm20tofnmlevelsecha-r7-1 ~]# systemctl status 
rpcbind.service
? rpcbind.service - RPC bind service
   Loaded: loaded (/usr/lib/systemd/system/rpcbind.service; enabled; vendor 
preset: enabled)
   Active: failed (Result: exit-code) since Sun 2017-01-01 14:37:45 UTC; 
20h ago
  Process: 31808 ExecStart=/sbin/rpcbind -w $RPCBIND_ARGS (code=exited, 
status=127)
 Main PID: 925 (code=exited, status=2)

Jan 01 14:37:45 natr76-utrs-dgm20tofnmlevelsecha-r7-1 systemd[1]: Starting 
RPC bind service...
Jan 01 14:37:45 natr76-utrs-dgm20tofnmlevelsecha-r7-1 rpcbind[31808]: 
/sbin/rpcbind: symbol lookup error: /sbin/rpcbind: undefined symbol: 
libtirpc_set_debug
Jan 01 14:37:45 natr76-utrs-dgm20tofnmlevelsecha-r7-1 systemd[1]: 
rpcbind.service: control process exited, code=exited status=127
Jan 01 14:37:45 natr76-utrs-dgm20tofnmlevelsecha-r7-1 systemd[1]: Failed to 
start RPC bind service.
Jan 01 14:37:45 natr76-utrs-dgm20tofnmlevelsecha-r7-1 systemd[1]: Unit 
rpcbind.service entered failed state.
Jan 01 14:37:45 natr76-utrs-dgm20tofnmlevelsecha-r7-1 systemd[1]: 
rpcbind.service failed.


Diffs
-

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
9c1387d 

Diff: https://reviews.apache.org/r/55572/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 55569: Log Namenode formatting output into ambari-agent command logs

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55569/#review161716
---


Ship it!




Ship It!

- Attila Doroszlai


On Jan. 16, 2017, 12:07 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55569/
> ---
> 
> (Updated Jan. 16, 2017, 12:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-19559
> https://issues.apache.org/jira/browse/AMBARI-19559
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> NN is being formatted during it's first startup. The script used for 
> formatting NN logs to standard output which currently is being collected only 
> in DEBUG mode by ambari agent thus is lost in production environments where 
> the agent usually runs in non-DEBUG mode. The NN formatting log is useful for 
> trouble shooting thus these should be collected and written out into the NN 
> start command output log.
> This can be done by adding logoutput=True option to the NN format script 
> invocation within NN start script.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  cc03bb3 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py
>  2c0d691 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/hdfs_namenode.py
>  35e16d5 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py f76a7d7 
> 
> Diff: https://reviews.apache.org/r/55569/diff/
> 
> 
> Testing
> ---
> 
> Testing manually cluster creation with both using the wizzard and blueprint 
> (NN non-HA and HA).
> 
> Unit tests:
> 
> mvn test -Drat.skip=true -Dcheckstyle.skip -DskipSurefireTests
> 
> OK
> --
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 55568: Devdeploy: Hcat client install fails on sles

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55568/#review161714
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 16, 2017, 12:30 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55568/
> ---
> 
> (Updated Jan. 16, 2017, 12:30 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19564
> https://issues.apache.org/jira/browse/AMBARI-19564
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py",
>  line 85, in 
> HCatClient().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 287, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py",
>  line 35, in install
> self.install_packages(env)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 578, in install_packages
> retry_count=agent_stack_retry_count)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 
> 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py",
>  line 54, in action_install
> self.install_package(package_name, self.resource.use_repos, 
> self.resource.skip_repos)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py",
>  line 59, in install_package
> self.checked_call_with_retries(cmd, sudo=True, 
> logoutput=self.get_logoutput())
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py",
>  line 86, in checked_call_with_retries
> return self._call_with_retries(cmd, is_checked=True, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py",
>  line 98, in _call_with_retries
> code, out = func(cmd, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 72, in inner
> result = function(command, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 102, in checked_call
> tries=tries, try_sleep=try_sleep, 
> timeout_kill_strategy=timeout_kill_strategy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 150, in _call_wrapper
> result = _call(command, **kwargs_copy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 303, in _call
> raise ExecutionFailed(err_msg, code, out, err)
> resource_management.core.exceptions.ExecutionFailed: Execution of 
> '/usr/bin/zypper --quiet install --auto-agree-with-licenses --no-confirm 
> mysql-connector-java' returned 106. New repository or package signing key 
> received:
> 
>   Repository:   scvutilaccount's Home Project (SLE_11_SP3) hosted in 
> hwx
>   Key Name: home:scvutilaccount OBS Project 
> 
>   Key Fingerprint:  4548523B 6F245323 1C356242 F652B5D8 7C4D5AE7  
>   
>   Key Created:  Fri Oct 31 10:47:30 2014  
>   
>   Key Expires:  Sun Jan  8 10:47:30 2017 (EXPIRED)
>   
>   Rpm Name: gpg-pubkey-7c4d5ae7-545368c2
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 
> 66227c6 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py
>  265c162 
> 
> Diff: https://reviews.apache.org/r/55568/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 55567: AMBARI-19563:Dashboard-Show YARN RM URL in actions and flow graph and organize tabs

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55567/#review161712
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 16, 2017, 10:32 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55567/
> ---
> 
> (Updated Jan. 16, 2017, 10:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19563
> https://issues.apache.org/jira/browse/AMBARI-19563
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Console Url is available which takes to RM UI. But not very intuitive. 
> -We can add link in action column in actions row.
> -Also flow graph can be moved after actions column 
> -Also in flow graph, show RM url
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> 32f5ef4 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-details.js
>  4873a31 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs
>  32e468f 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action-info.hbs
>  8d1e09c 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
>  114ca37 
> 
> Diff: https://reviews.apache.org/r/55567/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 55570: Ambari-agent: /var/lib/ambari-agent/cred/lib is not created and populated with credential store JARs and dependencies

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55570/#review161708
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 16, 2017, 1:12 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55570/
> ---
> 
> (Updated Jan. 16, 2017, 1:12 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19565
> https://issues.apache.org/jira/browse/AMBARI-19565
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When installing ambari-agent, /var/lib/ambari-agent/cred/lib folder should be
> created and populated with the following JARs:
> 
> commons-cli-1.2.jar  
> commons-collections-3.2.2.jar  
> commons-configuration-1.10.jar  
> commons-io-2.4.jar  
> commons-lang-2.6.jar  
> commons-logging-1.2.jar  
> credentialbuilder-0.6.0.2.5.0.0-1245.jar  
> guava-17.0.jar  
> hadoop-auth-2.7.3.2.5.0.0-1245.jar  
> hadoop-common-2.7.3.2.5.0.0-1245.jar  
> htrace-core-3.1.0-incubating.jar  
> slf4j-api-1.7.5.jar
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml 510f6f6 
>   ambari-agent/src/packages/tarball/all.xml f8a54e3 
> 
> Diff: https://reviews.apache.org/r/55570/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 55570: Ambari-agent: /var/lib/ambari-agent/cred/lib is not created and populated with credential store JARs and dependencies

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55570/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-19565
https://issues.apache.org/jira/browse/AMBARI-19565


Repository: ambari


Description
---

When installing ambari-agent, /var/lib/ambari-agent/cred/lib folder should be
created and populated with the following JARs:

commons-cli-1.2.jar  
commons-collections-3.2.2.jar  
commons-configuration-1.10.jar  
commons-io-2.4.jar  
commons-lang-2.6.jar  
commons-logging-1.2.jar  
credentialbuilder-0.6.0.2.5.0.0-1245.jar  
guava-17.0.jar  
hadoop-auth-2.7.3.2.5.0.0-1245.jar  
hadoop-common-2.7.3.2.5.0.0-1245.jar  
htrace-core-3.1.0-incubating.jar  
slf4j-api-1.7.5.jar


Diffs
-

  ambari-agent/pom.xml 510f6f6 
  ambari-agent/src/packages/tarball/all.xml f8a54e3 

Diff: https://reviews.apache.org/r/55570/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 55569: Log Namenode formatting output into ambari-agent command logs

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55569/
---

Review request for Ambari, Attila Doroszlai, Attila Magyar, and Sandor Magyari.


Bugs: AMBARI-19559
https://issues.apache.org/jira/browse/AMBARI-19559


Repository: ambari


Description
---

NN is being formatted during it's first startup. The script used for formatting 
NN logs to standard output which currently is being collected only in DEBUG 
mode by ambari agent thus is lost in production environments where the agent 
usually runs in non-DEBUG mode. The NN formatting log is useful for trouble 
shooting thus these should be collected and written out into the NN start 
command output log.
This can be done by adding logoutput=True option to the NN format script 
invocation within NN start script.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
 cc03bb3 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py
 2c0d691 
  
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/hdfs_namenode.py
 35e16d5 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py f76a7d7 

Diff: https://reviews.apache.org/r/55569/diff/


Testing
---

Testing manually cluster creation with both using the wizzard and blueprint (NN 
non-HA and HA).

Unit tests:

mvn test -Drat.skip=true -Dcheckstyle.skip -DskipSurefireTests

OK
--
Total run:1159
Total errors:0
Total failures:0
OK


Thanks,

Sebastian Toader

Review Request 55567: AMBARI-19563:Dashboard-Show YARN RM URL in actions and flow graph and organize tabs

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55567/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19563
https://issues.apache.org/jira/browse/AMBARI-19563


Repository: ambari


Description
---

Console Url is available which takes to RM UI. But not very intuitive. 
-We can add link in action column in actions row.
-Also flow graph can be moved after actions column 
-Also in flow graph, show RM url


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
32f5ef4 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-details.js
 4873a31 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs
 32e468f 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action-info.hbs
 8d1e09c 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
 114ca37 

Diff: https://reviews.apache.org/r/55567/diff/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Review Request 55568: Devdeploy: Hcat client install fails on sles

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55568/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-19564
https://issues.apache.org/jira/browse/AMBARI-19564


Repository: ambari


Description
---

Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py",
 line 85, in 
HCatClient().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 287, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py",
 line 35, in install
self.install_packages(env)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 578, in install_packages
retry_count=agent_stack_retry_count)
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py",
 line 54, in action_install
self.install_package(package_name, self.resource.use_repos, 
self.resource.skip_repos)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py",
 line 59, in install_package
self.checked_call_with_retries(cmd, sudo=True, 
logoutput=self.get_logoutput())
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py",
 line 86, in checked_call_with_retries
return self._call_with_retries(cmd, is_checked=True, **kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py",
 line 98, in _call_with_retries
code, out = func(cmd, **kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 72, 
in inner
result = function(command, **kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 102, 
in checked_call
tries=tries, try_sleep=try_sleep, 
timeout_kill_strategy=timeout_kill_strategy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 150, 
in _call_wrapper
result = _call(command, **kwargs_copy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 303, 
in _call
raise ExecutionFailed(err_msg, code, out, err)
resource_management.core.exceptions.ExecutionFailed: Execution of 
'/usr/bin/zypper --quiet install --auto-agree-with-licenses --no-confirm 
mysql-connector-java' returned 106. New repository or package signing key 
received:

  Repository:   scvutilaccount's Home Project (SLE_11_SP3) hosted in 
hwx
  Key Name: home:scvutilaccount OBS Project 

  Key Fingerprint:  4548523B 6F245323 1C356242 F652B5D8 7C4D5AE7

  Key Created:  Fri Oct 31 10:47:30 2014

  Key Expires:  Sun Jan  8 10:47:30 2017 (EXPIRED)  

  Rpm Name: gpg-pubkey-7c4d5ae7-545368c2


Diffs
-

  ambari-agent/src/test/python/resource_management/TestPackageResource.py 
66227c6 
  
ambari-common/src/main/python/resource_management/core/providers/package/zypper.py
 265c162 

Diff: https://reviews.apache.org/r/55568/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 55566: AMBARI-19562: Save is not present for coordinator and bundle.

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55566/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19562
https://issues.apache.org/jira/browse/AMBARI-19562


Repository: ambari


Description
---

Save should be available for coordinator and bundle.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
c6a24b8 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
743a163 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
9007838 
  contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 
d91c52a 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
0bb2fb8 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
 249877b 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
 7ee7ecd 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 01356b2 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs
 65bac42 

Diff: https://reviews.apache.org/r/55566/diff/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 55529: PREVIEW. HDP 3.0 TP - create Service Advisor for HDFS

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55529/#review161700
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 14, 2017, 3:37 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55529/
> ---
> 
> (Updated Jan. 14, 2017, 3:37 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19097
> https://issues.apache.org/jira/browse/AMBARI-19097
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a Service Advisor script for HDFS in HDP 3.0 Tech Preview.
> The Service Advisor must encapsulate all of the logic inherited/overwritten 
> from HDP 2.0.6 through HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.9/service_advisor.py
>  82316f4 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 
> 5172042 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 9b217b3 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> 6ae29cb 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> b601179 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py 
> 4e4ef51 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 
> 26292d9 
>   ambari-server/src/main/resources/stacks/stack_advisor.py d648a53 
>   ambari-server/src/test/python/TestStackAdvisor.py 87d2d15 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 355e211 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
> 
> Diff: https://reviews.apache.org/r/55529/diff/
> 
> 
> Testing
> ---
> 
> Verified recommendation and validation of HDFS while deploying HDP 3.0
> 
> Python unit tests passed.
> 
> Total run:1157
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 55494: Ambari agents not recovering from heart beat lost state immediately after successful re-registering with server

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55494/#review161699
---


Ship it!




Ship It!

- Sandor Magyari


On Jan. 13, 2017, 1:59 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55494/
> ---
> 
> (Updated Jan. 13, 2017, 1:59 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Sandor Magyari, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-19520
> https://issues.apache.org/jira/browse/AMBARI-19520
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> 
> In case ambari server is restarted after restart will ask agents to 
> re-register with the server.
> Once the agent successfully re-registered with the server it should be 
> transition out from heartbeat lost state. However in some cases it takes a 
> while until agents transition out from heartbeat lost state thus the server 
> may request the agent to re-register again.
> 
> Solution:
> Ensure upon agent re-regsitration that StatusCommandExecutor child process is 
> spawned before status commands received from the server (in the response to 
> the registration) are added to the status command queue.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 6b1b196 
>   ambari-agent/src/main/python/ambari_agent/main.py 2e0517b 
> 
> Diff: https://reviews.apache.org/r/55494/diff/
> 
> 
> Testing
> ---
> 
> Manually tested covering:
> 1. Restart agent
> 2. Restart amabari-server with agents being up and running
> 3. Kill StatusCommandExecutor child process
> 
> Unit test results:
> 
> Total run:1158
> Total errors:0
> Total failures:0
> OK
> 
> Ran 452 tests in 20.976s
> 
> OK
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [10.142s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.029s]
> [INFO] Ambari Views .. SUCCESS [1.707s]
> [INFO] utility ... SUCCESS [1.189s]
> [INFO] ambari-metrics  SUCCESS [0.473s]
> [INFO] Ambari Metrics Common . SUCCESS [1.012s]
> [INFO] Ambari Server . SUCCESS [1:45.492s]
> [INFO] Ambari Agent .. SUCCESS [25.860s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 55560: Timezone for timestamps in Upgrade History not consistent with Background Operations

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55560/#review161698
---


Ship it!




Ship It!

- Denys Buzhor


On Jan. 16, 2017, 9:23 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55560/
> ---
> 
> (Updated Jan. 16, 2017, 9:23 a.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-19560
> https://issues.apache.org/jira/browse/ambari-19560
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Looks like the timestamp in Upgrade History are shown as per current 
> machine's timezone; while the timestamp entries in Background Operations 
> Window is in GMT
> 
> This causes confusion while trying to correlate events that happen after 
> upgrade, as my machine's timezone is GMT+5.30, so the post upgrade events 
> appear to show up few hours before the upgrade time reported in 'Upgrade 
> History'
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 
> 8df8349 
> 
> Diff: https://reviews.apache.org/r/55560/diff/
> 
> 
> Testing
> ---
> 
> 20389 tests complete (31 seconds)
>   153 tests pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 55560: Timezone for timestamps in Upgrade History not consistent with Background Operations

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55560/
---

Review request for Ambari and Denys Buzhor.


Bugs: ambari-19560
https://issues.apache.org/jira/browse/ambari-19560


Repository: ambari


Description
---

Looks like the timestamp in Upgrade History are shown as per current machine's 
timezone; while the timestamp entries in Background Operations Window is in GMT

This causes confusion while trying to correlate events that happen after 
upgrade, as my machine's timezone is GMT+5.30, so the post upgrade events 
appear to show up few hours before the upgrade time reported in 'Upgrade 
History'


Diffs
-

  ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 8df8349 

Diff: https://reviews.apache.org/r/55560/diff/


Testing
---

20389 tests complete (31 seconds)
  153 tests pending


Thanks,

Oleg Nechiporenko

Re: Review Request 55513: Use common property for principal name prefix to help with customization of unique principal names

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55513/#review161690
---



Does this require any UI/backend api changes in order to allow users to change 
the ```principal_suffix``` later?

- Sebastian Toader


On Jan. 13, 2017, 7:14 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55513/
> ---
> 
> (Updated Jan. 13, 2017, 7:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Attila Magyar, Eugene 
> Chekanskiy, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19430
> https://issues.apache.org/jira/browse/AMBARI-19430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use common property for principal name prefix to help with customization of 
> unique principal names.  
> 
> All _headless_ Kerberos identities have a non-unique principal name (across 
> clusters). To help this issue, the cluster name is appended to these 
> principal names by adding "-${cluster-name|toLower()}" after the principal 
> name component. If the user wants to change this convention, they will need 
> to find all _headless_ principals and make the change. On top of that, when 
> adding new components, they will need to remember to make the change to new 
> _headless_ principal names. 
> 
> A better solution is to provide a _global_ property named "principal_suffix" 
> and use that in each _headless_ principal name. By default the value for this 
> property will be
> 
> ```
> principal_suffix="-${cluster_name|toLower()}"
> ```
> 
> If the user would like not use a prefix (in the event there is only a single 
> cluster connecting to the KDC), the value can be changed to
> 
> ```
> principal_suffix=""
> ```
> 
> Finally if the user would like to use some other randomizer, they can set the 
> value to something else. For example
> 
> ```
> principal_suffix="_12345"
> ```
> 
> The property is set in the Kerberos descriptor's "properties" block.   For 
> example:
> 
> ```
> {
>   "properties": {
> "realm": "${kerberos-env/realm}",
> ...,
> "principal_suffix": "-${cluster_name|toLower()}"
>   },
>   "identities": [
> ..., 
> {
>   "name": "smokeuser",
>   "principal": {
> "value": "${cluster-env/smokeuser}${principal_suffix}@${realm}",
> "type": "user",
> "configuration": "cluster-env/smokeuser_principal_name",
> "local_username": "${cluster-env/smokeuser}"
>   },
>   ...
> }
>   ],
>   "services": [
> {
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json
>  d53205d 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
>  caef123 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  636d36e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> f30c9e4 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json 
> 1dd801b 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.1/kerberos.json 
> fa6af33 
>   ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
> e7f78cd 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> 20e1dc0 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 
> fcfe524 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> 3068226 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
>  7c4c04c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json 9579d0f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/ECS/kerberos.json
>  9668354 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/HBASE/kerberos.json
>  20b10f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/ACCUMULO/kerberos.json
>  678a2b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/kerberos.json
>  0fec0ab 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 9ed40ef 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
> 9000e95 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> bd6c6c1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
> ae0d631 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
> a16e2e1 
>   ambari-server/src/main/resources/stacks/HDP/3.0/kerberos.json 9579d0f 
>   ambari-server/src/main/resources/stacks/PERF/1.0/kerberos.json a2a667b 
>   
> 

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55424/#review161689
---


Ship it!




Ship It!

- Dmytro Grinenko


On Jan. 12, 2017, 2:09 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55424/
> ---
> 
> (Updated Jan. 12, 2017, 2:09 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Robert Levas.
> 
> 
> Bugs: AMBARI-19464
> https://issues.apache.org/jira/browse/AMBARI-19464
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18335 addresses an issue where configuration properties in the 
> Kerberos descriptor don't change during a stack upgrade. It accounts for both 
> upgrade/downgrade scenarios and situations where properties are added/removed.
> However, it does not take into account the potential for a property to be 
> customized by the user (not a new property, but a property which the user 
> changes the value of). In this case, the downgrade would be destructive, 
> overriding the user's values with those from the downgrade stack.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ArtifactEntity.java
>  8972e6d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java
>  f1eab38 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptorTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55424/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>