Re: Review Request 56558: Control Log Level for all Hive components for log4j

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56558/#review165223
---


Ship it!




Based on 
https://issues.apache.org/jira/secure/attachment/12852169/AMBARI-19968.patch

- Sumit Mohanty


On Feb. 10, 2017, 10:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56558/
> ---
> 
> (Updated Feb. 10, 2017, 10:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-19968
> https://issues.apache.org/jira/browse/AMBARI-19968
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Control Log Level for all Hive components for log4j
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java
>  d92c04d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  a2879da 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  b4e4a03 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  928bf06 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/beeline-log4j2.xml
>  efe9d6e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml
>  14e58bd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml
>  3b935f8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml
>  01d556f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
>  ff93265 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
>  bc0c7de 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/webhcat-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json
>  9caf51e 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py d102b9d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> e942201 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ec3e8f0 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> dde7933 
> 
> Diff: https://reviews.apache.org/r/56558/diff/
> 
> 
> Testing
> ---
> 
> Check UI if new drop down is visible
> Change value and check from API, disk if the loglevels change for the 
> hive-log4j files
> Enable Hive-interactive and check if the changes are seen in hive log4j2 files
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 56558: Control Log Level for all Hive components for log4j

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56558/#review165211
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j.xml
 (line 112)


Can we set these to false as well? For all the three additions.


- Sumit Mohanty


On Feb. 10, 2017, 10:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56558/
> ---
> 
> (Updated Feb. 10, 2017, 10:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-19968
> https://issues.apache.org/jira/browse/AMBARI-19968
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Control Log Level for all Hive components for log4j
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java
>  d92c04d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  a2879da 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  b4e4a03 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  928bf06 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/beeline-log4j2.xml
>  efe9d6e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml
>  14e58bd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml
>  3b935f8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml
>  01d556f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
>  ff93265 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
>  bc0c7de 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/webhcat-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json
>  9caf51e 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py d102b9d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> e942201 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ec3e8f0 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> dde7933 
> 
> Diff: https://reviews.apache.org/r/56558/diff/
> 
> 
> Testing
> ---
> 
> Check UI if new drop down is visible
> Change value and check from API, disk if the loglevels change for the 
> hive-log4j files
> Enable Hive-interactive and check if the changes are seen in hive log4j2 files
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 56563: AMBARI-19971. HiveServerInteractive. (1). Use the correct value for Node(s) used for running LLAP Daemon(s). (2). Set 'num_llap_nodes' calculated value only for non Ambari ma

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56563/#review165194
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 10, 2017, 10:05 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56563/
> ---
> 
> (Updated Feb. 10, 2017, 10:05 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Siddharth 
> Seth.
> 
> 
> Bugs: AMBARI-19971
> https://issues.apache.org/jira/browse/AMBARI-19971
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **(1). Use the correct value for Node(s) used for running LLAP Daemon(s).** 
> 
> - **Existing :** While starting LLAP, it was not taken into account removing 
> the Nodes used for SLider and Tez AM from 'num_llap_nodes' value, before 
> using it for starting LLAP by passing 'num_llap_nodes''s value to --instances 
> parameter.
> - **Fix:** Introduced new config 'num_llap_nodes_for_llap_daemons' which has 
> the updated value substracting the nodes used by Tez and SLider AM's.
> 
> 
> **(2). Set 'num_llap_nodes' calculated value only for non Ambari managed 
> queue.**
> 
> **Fix:** With AMBARI-19814 patch, UI shows 'num_llap_nodes' slider as READ 
> only for non Ambari managed queue for LLAP. We will be setting the calculated 
> 'num_llap_nodes' slider value only for non-Ambari managed queue. For Ambari 
> managed queue named 'llap', user has the liberty of entering the value. We 
> may end up using less nodes than that, as part of calculation, but we dont 
> want to override the User entered value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  1f1d9a8 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  a5618ca 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  e636e0c 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 99b6776 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml
>  af656f4 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> ec56bad 
> 
> Diff: https://reviews.apache.org/r/56563/diff/
> 
> 
> Testing
> ---
> 
> - Python UT's updated. Passes.
> - 
> - Tested on cluster manually.
> 
> Test where 'num_llap_nodes_for_llap_daemons' caluclated is different from 
> 'num_llap_nodes'
> ==
> 
> - YARN min container size and YARN NM node size : 12 GB 
> - 'num_llap_nodes_for_llap_daemons' can be <= 'num_llap_nodes'.
> 
> **Screenshot showing 'num_llap_nodes'** : num_llap_nodes.png
> **Screenshot showing 'num_llap_nodes_for_llap_daemons'** : 
> num_llap_nodes_for_llap_daemons.png 
> 
> 
> 'num_llap_nodes_for_llap_daemons' config value is used as value for 
> "--instances" in below comamnd, used to start LLAP.
> 
> ===
> 
> /usr/hdp/current/hive-server2-hive2/bin/hive --service llap 
> --slider-am-container-mb 12288 --size 12288m --cache 9216m --xmx 2457m 
> --loglevel INFO  --output 
> /var/lib/ambari-agent/tmp/llap-slider2017-02-10_21-31-47 --slider-placement 0 
> --skiphadoopversion --skiphbasecp --instances 3 --logger query-routing --args 
> " -XX:+AlwaysPreTouch -XX:+UseG1GC -XX:TLABSize=8m -XX:+ResizeTLAB 
> -XX:+UseNUMA -XX:+AggressiveOpts -XX:InitiatingHeapOccupancyPercent=80 
> -XX:MaxGCPauseMillis=200 -XX:MetaspaceSize=1024m"
> ===
> ===
> 
> 
> File Attachments
> 
> 
> num_llap_nodes
>   
> https://reviews.apache.org/media/uploaded/files/2017/02/10/a0c9e06f-1f1e-4ac4-bff7-e0900e4ad599__Screen_Shot_2017-02-10_at_1.43.45_PM.png
> num_llap_nodes_for_llap_daemons
>   
> https://reviews.apache.org/media/uploaded/files/2017/02/10/fc9ff535-e4b7-4085-b39d-0b4951a4d176__Screen_Shot_2017-02-10_at_1.44.23_PM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 56563: AMBARI-19971. HiveServerInteractive. (1). Use the correct value for Node(s) used for running LLAP Daemon(s). (2). Set 'num_llap_nodes' calculated value only for non Ambari manage

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56563/
---

Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Siddharth 
Seth.


Bugs: AMBARI-19971
https://issues.apache.org/jira/browse/AMBARI-19971


Repository: ambari


Description
---

**(1). Use the correct value for Node(s) used for running LLAP Daemon(s).** 

- **Existing :** While starting LLAP, it was not taken into account removing 
the Nodes used for SLider and Tez AM from 'num_llap_nodes' value, before using 
it for starting LLAP by passing 'num_llap_nodes''s value to --instances 
parameter.
- **Fix:** Introduced new config 'num_llap_nodes_for_llap_daemons' which has 
the updated value substracting the nodes used by Tez and SLider AM's.


**(2). Set 'num_llap_nodes' calculated value only for non Ambari managed 
queue.**

**Fix:** With AMBARI-19814 patch, UI shows 'num_llap_nodes' slider as READ only 
for non Ambari managed queue for LLAP. We will be setting the calculated 
'num_llap_nodes' slider value only for non-Ambari managed queue. For Ambari 
managed queue named 'llap', user has the liberty of entering the value. We may 
end up using less nodes than that, as part of calculation, but we dont want to 
override the User entered value.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 1f1d9a8 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 a5618ca 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 e636e0c 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
99b6776 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml
 af656f4 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py ec56bad 

Diff: https://reviews.apache.org/r/56563/diff/


Testing
---

- Python UT's updated. Passes.
- 
- Tested on cluster manually.

Test where 'num_llap_nodes_for_llap_daemons' caluclated is different from 
'num_llap_nodes'
==

- YARN min container size and YARN NM node size : 12 GB 
- 'num_llap_nodes_for_llap_daemons' can be <= 'num_llap_nodes'.

**Screenshot showing 'num_llap_nodes'** : num_llap_nodes.png
**Screenshot showing 'num_llap_nodes_for_llap_daemons'** : 
num_llap_nodes_for_llap_daemons.png 


'num_llap_nodes_for_llap_daemons' config value is used as value for 
"--instances" in below comamnd, used to start LLAP.

===

/usr/hdp/current/hive-server2-hive2/bin/hive --service llap 
--slider-am-container-mb 12288 --size 12288m --cache 9216m --xmx 2457m 
--loglevel INFO  --output 
/var/lib/ambari-agent/tmp/llap-slider2017-02-10_21-31-47 --slider-placement 0 
--skiphadoopversion --skiphbasecp --instances 3 --logger query-routing --args " 
-XX:+AlwaysPreTouch -XX:+UseG1GC -XX:TLABSize=8m -XX:+ResizeTLAB -XX:+UseNUMA 
-XX:+AggressiveOpts -XX:InitiatingHeapOccupancyPercent=80 
-XX:MaxGCPauseMillis=200 -XX:MetaspaceSize=1024m"
===
===


File Attachments


num_llap_nodes
  
https://reviews.apache.org/media/uploaded/files/2017/02/10/a0c9e06f-1f1e-4ac4-bff7-e0900e4ad599__Screen_Shot_2017-02-10_at_1.43.45_PM.png
num_llap_nodes_for_llap_daemons
  
https://reviews.apache.org/media/uploaded/files/2017/02/10/fc9ff535-e4b7-4085-b39d-0b4951a4d176__Screen_Shot_2017-02-10_at_1.44.23_PM.png


Thanks,

Swapan Shridhar

Re: Review Request 56558: Control Log Level for all Hive components for log4j

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56558/
---

(Updated Feb. 10, 2017, 10:04 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-19968
https://issues.apache.org/jira/browse/AMBARI-19968


Repository: ambari


Description
---

Control Log Level for all Hive components for log4j


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java 
d92c04d 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 a2879da 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 b4e4a03 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 928bf06 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/beeline-log4j2.xml
 efe9d6e 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml
 14e58bd 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml
 3b935f8 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml
 01d556f 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
 ff93265 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
 bc0c7de 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/webhcat-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json 
9caf51e 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py d102b9d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
e942201 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ec3e8f0 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py dde7933 

Diff: https://reviews.apache.org/r/56558/diff/


Testing
---

Check UI if new drop down is visible
Change value and check from API, disk if the loglevels change for the 
hive-log4j files
Enable Hive-interactive and check if the changes are seen in hive log4j2 files


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 55173: Flume metrics can't show if hostname of flume agent is not lowercase

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55173/#review165164
---


Ship it!




Hi Yao Lei,

Thank you for the contribution. I have opened up a Jira to make sure this is 
correctly addressed throuhout AMS.
https://issues.apache.org/jira/browse/AMBARI-19969

I am committing you patch to trunk.

- Sid Wagle


On Jan. 9, 2017, 6:27 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55173/
> ---
> 
> (Updated Jan. 9, 2017, 6:27 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Matt, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-19357
> https://issues.apache.org/jira/browse/AMBARI-19357
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If hostname of flume agent is uppercase or mixed-case?web client will not 
> show flume metrics normally.
> This is because we will query metric records by lowercase hostname used in 
> ambari ,but the hostname in METRIC_RECORD is not lowercase (see attached 
> picture),so we will not get any records.
> This patch amis to convert hostname of metric record of flume to lowercase 
> before inserting into ams hbase.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
>  c1b684b 
> 
> Diff: https://reviews.apache.org/r/55173/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> yao lei
> 
>

Review Request 56558: Control Log Level for all Hive components for log4j

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56558/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-19968
https://issues.apache.org/jira/browse/AMBARI-19968


Repository: ambari


Description
---

Control Log Level for all Hive components for log4j


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java 
d92c04d 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 a2879da 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 b4e4a03 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 928bf06 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/beeline-log4j2.xml
 efe9d6e 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml
 14e58bd 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml
 3b935f8 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml
 01d556f 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
 ff93265 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
 bc0c7de 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/webhcat-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json 
9caf51e 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py d102b9d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
e942201 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ec3e8f0 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py dde7933 

Diff: https://reviews.apache.org/r/56558/diff/


Testing
---

Check UI if new drop down is visible
Change value and check from API, disk if the loglevels change for the 
hive-log4j files
Enable Hive-interactive and check if the changes are seen in hive log4j2 files


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 56547: Deviation alerts fail with "No JSON object could be decoded"

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56547/#review165146
---




ambari-common/src/main/python/ambari_commons/network.py (line 26)


Add basic comments.



ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/alerts/alert_metrics_deviation.py
 (line 316)


Is there a config for what this path should be?


- Alejandro Fernandez


On Feb. 10, 2017, 4:04 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56547/
> ---
> 
> (Updated Feb. 10, 2017, 4:04 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19963
> https://issues.apache.org/jira/browse/AMBARI-19963
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deviation alerts fail with
> ERROR 2017-02-09 17:50:12,896 base_alert.py:132 - 
> [Alert][namenode_service_rpc_processing_latency_hourly] Unable to execute 
> alert. No JSON object could be decoded
> Traceback (most recent call last):
>   File "/usr/lib/python2.6/site-packages/ambari_agent/alerts/base_alert.py", 
> line 112, in collect
> res = self._collect()
>   File 
> "/usr/lib/python2.6/site-packages/ambari_agent/alerts/script_alert.py", line 
> 115, in _collect
> result = cmd_module.execute(configurations, self.parameters, 
> self.host_name)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py",
>  line 326, in execute
> data_json = json.loads(data)
>   File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
> return _default_decoder.decode(s)
>   File "/usr/lib64/python2.7/json/decoder.py", line 366, in decode
> obj, end = self.raw_decode(s, idx=_w(s, 0).end())
>   File "/usr/lib64/python2.7/json/decoder.py", line 384, in raw_decode
> raise ValueError("No JSON object could be decoded")
> ValueError: No JSON object could be decoded
> on AMS with collector HTTPS enabled
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/network.py PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
>  84dcd99 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/network.py
>  672ee53 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
>  2bc4363 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
>  8a06f56 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/alerts/alert_metrics_deviation.py
>  8a06f56 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py
>  1e35e6f 
> 
> Diff: https://reviews.apache.org/r/56547/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 55609: Add Livy session recovery configurations in Ambari

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review165145
---




ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
 (line 47)


Should these permissions be more restrictive?


- Alejandro Fernandez


On Feb. 10, 2017, 7:41 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Feb. 10, 2017, 7:41 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  82cd0b2 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  07b704f 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  c19f88c 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
>  f2178f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  23583c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  231ef70 
>   ambari-server/src/test/python/stacks/2.5/SPARK/test_spark_livy.py b56474a 
>   ambari-server/src/test/python/stacks/2.6/SPARK2/test_spark_livy2.py 6244d87 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 56501: Increase SNMP Unit Test Coverage

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56501/
---

(Updated Фев. 10, 2017, 6:01 п.п.)


Review request for Ambari and Jonathan Hurley.


Bugs: AMBARI-19944
https://issues.apache.org/jira/browse/AMBARI-19944


Repository: ambari


Description
---

The current unit tests for SNMP alert notifications do not provide enough of an 
end-to-end coverage there should be. We should mock SNMP4J classes to ensure 
that the alert framework is capable of completing an end-to-end dispatch of a 
trap. This includes:
Instrumenting the SNMP4J dispatcher to intercept the SNMP message and 
validating the OIDs stored
Instrumenting Ambari alert code so that an AlertNotice is picked up and 
converted into a delivered SNMP message.
This unit test needs to cover test cases:
4 Verify AMBARI_SNMP trap is working fine when alerts are triggered (Need to 
confirm whether covered in unit tests)
1 Setup a SNMP trap receiver server on one of the hosts
2 Create AMBARI_SNMP trap notification to use the receiver started in Step 1
3 Trigger an alert to be in CRIT status. E.g STOP MR to trigger HistoryServer 
Alert
4 Verify the traps are received by the receiver and verify the OID received is 
correct


Diffs (updated)
-

  
ambari-server/src/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java
 07094a8 

Diff: https://reviews.apache.org/r/56501/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 56552: Ambari Server Unit Test Failures

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56552/
---

(Updated Feb. 10, 2017, 12:41 p.m.)


Review request for Ambari, Nate Cole and Robert Levas.


Changes
---

Wrong diff originally...


Bugs: AMBARI-19967
https://issues.apache.org/jira/browse/AMBARI-19967


Repository: ambari


Description
---

The `AlertDataManagerTest` is exposing a problem with concurrent creation of 
alert groups where an exception is thrown during concurrent UT creation due to 
a UNIQUE violation:

javax.persistence.PersistenceException:
Exception [EclipseLink-4002] (Eclipse Persistence Services - 
2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
Internal Exception: org.h2.jdbc.JdbcSQLException: Unique index or primary key 
violation: "UNQ_ALERT_GROUP_0_INDEX_9 ON AMBARI.ALERT_GROUP(CLUSTER_ID, 
GROUP_NAME) VALUES (1, 'HDFS', 2)"; SQL statement:
INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
service_name) VALUES (?, ?, ?, ?, ?) [23505-193]
Error Code: 23505
Call: INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
service_name) VALUES (?, ?, ?, ?, ?)
bind => [5 parameters bound]
at 
org.apache.ambari.server.state.cluster.AlertDataManagerTest.setup(AlertDataManagerTest.java:149)

This is actually a problem both in the tests and the code for Ambari. We can 
replace one of the locks and also synchronize the event publishing.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
 703ff58 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
 3b9c97a 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java
 b660631 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
 1ec6d40 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java
 4ad93e6 

Diff: https://reviews.apache.org/r/56552/diff/


Testing
---

Results :

Tests run: 4912, Failures: 0, Errors: 0, Skipped: 39

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 17:10 min
[INFO] Finished at: 2017-02-10T11:42:49-05:00
[INFO] Final Memory: 62M/662M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 56550: Set recommended tooltip appears in front of icon

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56550/#review165138
---


Ship it!




Ship It!

- Denys Buzhor


On Feb. 10, 2017, 4:52 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56550/
> ---
> 
> (Updated Feb. 10, 2017, 4:52 p.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: AMBARI-19964
> https://issues.apache.org/jira/browse/AMBARI-19964
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Go to installer step7 wizard and try to click on set recommended icon for 
> DataNode maximum Java heap size
> 
> 
> Diffs
> -
> 
>   ambari-web/app/app.js 53394a0 
>   ambari-web/app/templates/common/configs/widgets/controls.hbs 52cccd4 
>   ambari-web/app/utils/bootstrap_reopen.js PRE-CREATION 
>   ambari-web/app/views/common/configs/service_configs_by_category_view.js 
> f4f35c8 
>   ambari-web/app/views/common/configs/widgets/config_widget_view.js e93baa2 
> 
> Diff: https://reviews.apache.org/r/56550/diff/
> 
> 
> Testing
> ---
> 
> Results of running unit tests:
> 30319 passing (26s)
>   157 pending
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>

Review Request 56552: Ambari Server Unit Test Failures

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56552/
---

Review request for Ambari, Nate Cole and Robert Levas.


Bugs: AMBARI-19967
https://issues.apache.org/jira/browse/AMBARI-19967


Repository: ambari


Description
---

The `AlertDataManagerTest` is exposing a problem with concurrent creation of 
alert groups where an exception is thrown during concurrent UT creation due to 
a UNIQUE violation:

javax.persistence.PersistenceException:
Exception [EclipseLink-4002] (Eclipse Persistence Services - 
2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
Internal Exception: org.h2.jdbc.JdbcSQLException: Unique index or primary key 
violation: "UNQ_ALERT_GROUP_0_INDEX_9 ON AMBARI.ALERT_GROUP(CLUSTER_ID, 
GROUP_NAME) VALUES (1, 'HDFS', 2)"; SQL statement:
INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
service_name) VALUES (?, ?, ?, ?, ?) [23505-193]
Error Code: 23505
Call: INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
service_name) VALUES (?, ?, ?, ?, ?)
bind => [5 parameters bound]
at 
org.apache.ambari.server.state.cluster.AlertDataManagerTest.setup(AlertDataManagerTest.java:149)

This is actually a problem both in the tests and the code for Ambari. We can 
replace one of the locks and also synchronize the event publishing.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
 703ff58 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
 3b9c97a 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
 1ec6d40 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java
 4ad93e6 

Diff: https://reviews.apache.org/r/56552/diff/


Testing
---

Results :

Tests run: 4912, Failures: 0, Errors: 0, Skipped: 39

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 17:10 min
[INFO] Finished at: 2017-02-10T11:42:49-05:00
[INFO] Final Memory: 62M/662M
[INFO] 


Thanks,

Jonathan Hurley

Review Request 56550: Set recommended tooltip appears in front of icon

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56550/
---

Review request for Ambari and Denys Buzhor.


Bugs: AMBARI-19964
https://issues.apache.org/jira/browse/AMBARI-19964


Repository: ambari


Description
---

Go to installer step7 wizard and try to click on set recommended icon for 
DataNode maximum Java heap size


Diffs
-

  ambari-web/app/app.js 53394a0 
  ambari-web/app/templates/common/configs/widgets/controls.hbs 52cccd4 
  ambari-web/app/utils/bootstrap_reopen.js PRE-CREATION 
  ambari-web/app/views/common/configs/service_configs_by_category_view.js 
f4f35c8 
  ambari-web/app/views/common/configs/widgets/config_widget_view.js e93baa2 

Diff: https://reviews.apache.org/r/56550/diff/


Testing
---

Results of running unit tests:
30319 passing (26s)
  157 pending


Thanks,

Aleksandr Kovalenko

Re: Review Request 56548: Clicking on the login button (or hitting page refresh) to seeing the dashboard takes a while on a 1000-node cluster

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56548/#review165135
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Фев. 10, 2017, 4:18 п.п., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56548/
> ---
> 
> (Updated Фев. 10, 2017, 4:18 п.п.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-19962
> https://issues.apache.org/jira/browse/AMBARI-19962
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log in to Dashboard is really slow (about 15 seconds on a 1000-node cluster). 
> This does not include the time to load the widget graphs (loading the widget 
> takes additional ~5 seconds on top).
> Let's identify the bottlenecks and how we can make this much faster (a few 
> seconds is ideal).
> 
> 
> Diffs
> -
> 
>   ambari-web/app/router.js d671e86 
>   ambari-web/app/utils/ajax/ajax.js e344128 
> 
> Diff: https://reviews.apache.org/r/56548/diff/
> 
> 
> Testing
> ---
> 
> 20345 passing (31s)
> 153 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Re: Review Request 55609: Add Livy session recovery configurations in Ambari

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review165132
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 10, 2017, 7:41 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Feb. 10, 2017, 7:41 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  82cd0b2 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  07b704f 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  c19f88c 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
>  f2178f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  23583c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  231ef70 
>   ambari-server/src/test/python/stacks/2.5/SPARK/test_spark_livy.py b56474a 
>   ambari-server/src/test/python/stacks/2.6/SPARK2/test_spark_livy2.py 6244d87 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Review Request 56548: Clicking on the login button (or hitting page refresh) to seeing the dashboard takes a while on a 1000-node cluster

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56548/
---

Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.


Bugs: AMBARI-19962
https://issues.apache.org/jira/browse/AMBARI-19962


Repository: ambari


Description
---

Log in to Dashboard is really slow (about 15 seconds on a 1000-node cluster). 
This does not include the time to load the widget graphs (loading the widget 
takes additional ~5 seconds on top).
Let's identify the bottlenecks and how we can make this much faster (a few 
seconds is ideal).


Diffs
-

  ambari-web/app/router.js d671e86 
  ambari-web/app/utils/ajax/ajax.js e344128 

Diff: https://reviews.apache.org/r/56548/diff/


Testing
---

20345 passing (31s)
153 pending


Thanks,

Andrii Tkach

Re: Review Request 56547: Deviation alerts fail with "No JSON object could be decoded"

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56547/#review165130
---


Ship it!




Ship It!

- Sid Wagle


On Feb. 10, 2017, 4:04 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56547/
> ---
> 
> (Updated Feb. 10, 2017, 4:04 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19963
> https://issues.apache.org/jira/browse/AMBARI-19963
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deviation alerts fail with
> ERROR 2017-02-09 17:50:12,896 base_alert.py:132 - 
> [Alert][namenode_service_rpc_processing_latency_hourly] Unable to execute 
> alert. No JSON object could be decoded
> Traceback (most recent call last):
>   File "/usr/lib/python2.6/site-packages/ambari_agent/alerts/base_alert.py", 
> line 112, in collect
> res = self._collect()
>   File 
> "/usr/lib/python2.6/site-packages/ambari_agent/alerts/script_alert.py", line 
> 115, in _collect
> result = cmd_module.execute(configurations, self.parameters, 
> self.host_name)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py",
>  line 326, in execute
> data_json = json.loads(data)
>   File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
> return _default_decoder.decode(s)
>   File "/usr/lib64/python2.7/json/decoder.py", line 366, in decode
> obj, end = self.raw_decode(s, idx=_w(s, 0).end())
>   File "/usr/lib64/python2.7/json/decoder.py", line 384, in raw_decode
> raise ValueError("No JSON object could be decoded")
> ValueError: No JSON object could be decoded
> on AMS with collector HTTPS enabled
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/network.py PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
>  84dcd99 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/network.py
>  672ee53 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
>  2bc4363 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
>  8a06f56 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/alerts/alert_metrics_deviation.py
>  8a06f56 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py
>  1e35e6f 
> 
> Diff: https://reviews.apache.org/r/56547/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 56547: Deviation alerts fail with "No JSON object could be decoded"

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56547/
---

Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-19963
https://issues.apache.org/jira/browse/AMBARI-19963


Repository: ambari


Description
---

Deviation alerts fail with
ERROR 2017-02-09 17:50:12,896 base_alert.py:132 - 
[Alert][namenode_service_rpc_processing_latency_hourly] Unable to execute 
alert. No JSON object could be decoded
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/ambari_agent/alerts/base_alert.py", 
line 112, in collect
res = self._collect()
  File "/usr/lib/python2.6/site-packages/ambari_agent/alerts/script_alert.py", 
line 115, in _collect
result = cmd_module.execute(configurations, self.parameters, self.host_name)
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py",
 line 326, in execute
data_json = json.loads(data)
  File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
return _default_decoder.decode(s)
  File "/usr/lib64/python2.7/json/decoder.py", line 366, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib64/python2.7/json/decoder.py", line 384, in raw_decode
raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
on AMS with collector HTTPS enabled


Diffs
-

  ambari-common/src/main/python/ambari_commons/network.py PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
 84dcd99 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/network.py
 672ee53 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
 2bc4363 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
 8a06f56 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/alerts/alert_metrics_deviation.py
 8a06f56 
  
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py 
1e35e6f 

Diff: https://reviews.apache.org/r/56547/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

[Balázs Bence Sári]

> On Feb. 10, 2017, 2:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  lines 715-729
> > 
> >
> > This is strange - why not make the DatabaseConsistencyCheckHelper do 
> > this exception handling/logic and call it directly instead of having yet 
> > another method call in AmbariServer?  Separation of concerns would be 
> > helpful.

I agree with this finding. I copied existing behavior that's why it is here. 
I'll move it to DB checker.


> On Feb. 10, 2017, 2:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  lines 724-726
> > 
> >
> > Use logging here, not System.out.println(...)

I copied existing behavior. I think the reason why it is here that the python 
script checks the standard out, so the intention is to make sure this line 
appears there, irrespectively of the logging config.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165122
---


On Feb. 10, 2017, 12:21 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 10, 2017, 12:21 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 56545: AMBARI-19959. Allow skipping view extraction in ambari-server setup

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56545/
---

Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian 
Toader.


Bugs: AMBARI-19959
https://issues.apache.org/jira/browse/AMBARI-19959


Repository: ambari


Description
---

Added `--skip-view-extraction` flag, defaults to false.


Diffs
-

  ambari-server/src/main/python/ambari-server.py 
5d4f5d7b66f1e34061a3b5d1eddfe3cf931bd23f 
  ambari-server/src/main/python/ambari_server/serverSetup.py 
8a06034933b44cc9070b2d031dddad3505280c98 
  ambari-server/src/test/python/TestAmbariServer.py 
7dae7c0af5211d180294a867743445aba2f105ac 

Diff: https://reviews.apache.org/r/56545/diff/


Testing
---

Manual tested:

```
# ambari-server setup --silent
[...]
Creating tables...
done.
Extracting system views...
...ambari-admin-3.0.0.0.255.jar
..
Adjusting ambari-server permissions and ownership...
Ambari Server 'setup' completed successfully.

# ambari-server setup --silent --skip-view-extraction
[...]
Creating tables...
done.
Adjusting ambari-server permissions and ownership...
Ambari Server 'setup' completed successfully.
```


Unit tests:

```
$ mvn -am -pl ambari-server -DskipSurefireTests -DfailIfNoTests=false clean test
...
Total run:1183
Total errors:0
Total failures:0
OK
...
[INFO] Ambari Server . SUCCESS
```


Thanks,

Attila Doroszlai

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165122
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 (lines 715 - 729)


This is strange - why not make the DatabaseConsistencyCheckHelper do this 
exception handling/logic and call it directly instead of having yet another 
method call in AmbariServer?  Separation of concerns would be helpful.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 (lines 724 - 726)


Use logging here, not System.out.println(...)



ambari-server/src/main/python/ambari_server_main.py (line 247)


+1 for Jonathan's comments.  String comparison is evil.


- Nate Cole


On Feb. 10, 2017, 7:21 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 10, 2017, 7:21 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56544: No config properties are changed after deleting service if it's performed after service page refresh

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56544/#review165120
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Фев. 10, 2017, 1:58 п.п., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56544/
> ---
> 
> (Updated Фев. 10, 2017, 1:58 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19960
> https://issues.apache.org/jira/browse/AMBARI-19960
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **STR**
> 1. Navigate to the page of any service which requires reconfiguration on its 
> deleting.
> 2. Refresh page.
> 3. Delete service.
> 
> **Result**
> No config properties are changed.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/item.js 7010ab5 
>   ambari-web/test/controllers/main/service/item_test.js 302a9a5 
> 
> Diff: https://reviews.apache.org/r/56544/diff/
> 
> 
> Testing
> ---
> 
> 20345 passing (21s)
>   153 pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Review Request 56544: No config properties are changed after deleting service if it's performed after service page refresh

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56544/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19960
https://issues.apache.org/jira/browse/AMBARI-19960


Repository: ambari


Description
---

**STR**
1. Navigate to the page of any service which requires reconfiguration on its 
deleting.
2. Refresh page.
3. Delete service.

**Result**
No config properties are changed.


Diffs
-

  ambari-web/app/controllers/main/service/item.js 7010ab5 
  ambari-web/test/controllers/main/service/item_test.js 302a9a5 

Diff: https://reviews.apache.org/r/56544/diff/


Testing
---

20345 passing (21s)
  153 pending


Thanks,

Andriy Babiichuk

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165119
---


Ship it!




Ship It!

- Sebastian Toader


On Feb. 10, 2017, 1:21 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 10, 2017, 1:21 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165118
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 (line 714)


Doc.



ambari-server/src/main/python/ambari_server_main.py (line 247)


Could we make this a marker that's more "enum"-like ... Changing a string 
in Java by accident would cause side effects here that nobody would catch.


- Jonathan Hurley


On Feb. 10, 2017, 7:21 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 10, 2017, 7:21 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

[Balázs Bence Sári]

> On Feb. 10, 2017, 12:54 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java,
> >  line 689
> > 
> >
> > It would be useful to log the schema name that is first on the search 
> > path as well.

The whole search path is logged out, so it is easy to see which is the first 
item. E.g:

2017-02-09 22:46:25,936 ERROR [main] checks.DatabaseConsistencyCheckHelper 
(DatabaseConsistencyCheckHelper.java:checkSchemaName(658)) - The schema 
[ambari] defined for Ambari in ambari.properties is not first on the search 
path: [public, ambari]. This can lead to problems.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165115
---


On Feb. 10, 2017, 12:21 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 10, 2017, 12:21 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56059: Broken kill_process_with_children shell single liner

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/
---

(Updated Feb. 10, 2017, 3:15 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Dmytro 
Grinenko, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-19768
https://issues.apache.org/jira/browse/AMBARI-19768


Repository: ambari


Description
---

This single liner does not work correctly in some cases
{code}CMD = """ps xf | awk -v PID=""" + str(pid) + \
  """ ' $1 == PID { P = $1; next } P && /_/ { P = P " " $1;""" + \
  """K=P } P && !/_/ { P="" }  END { print "kill -""" \
  + str(signal) + """ "K }' | sh """
{code}
  
*Example*
{code}((sleep 3141592) & ((sleep 3141592) & (sleep 3141592))

ps xf

 3231 ?Ss 0:01  \_ sshd: root@pts/0 
 3233 pts/0Ss 0:00  |   \_ -bash
17984 pts/0S+ 0:00  |   \_ -bash
17985 pts/0S+ 0:00  |   \_ sleep 3141592
17986 pts/0S+ 0:00  |   \_ -bash
17987 pts/0S+ 0:00  |   \_ sleep 3141592
17988 pts/0S+ 0:00  |   \_ sleep 3141592
17738 ?Ss 0:00  \_ sshd: root@pts/1 
17740 pts/1Ss 0:00  \_ -bash
17989 pts/1R+ 0:00  \_ ps xf

ps xf | awk -v PID=17987 ' $1 == PID { P = $1; next } P && /_/ { P = P " " 
$1;K=P } P && !/_/ { P="" }  END { print "kill "K }'

(PID=17987)
result : "kill 17987 17988 17738 17740 18083 18084"
but right will only "kill 17987"

(PID=17985)
result : "kill 17985 17986 17987 17988 17738 17740 18697 18698"
right : "kill 17985"

(PID=17986)
result : "kill 17986 17987 17988 17738 17740 18980 18981"
right : "kill 17986 17987 17988"
{code}


Diffs
-

  ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py PRE-CREATION 
  ambari-agent/src/test/python/ambari_agent/TestShell.py 8d375e3915 
  ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION 
  ambari-common/src/main/python/ambari_commons/shell.py 8d26599df8 

Diff: https://reviews.apache.org/r/56059/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165115
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 657)


It would be useful to log the schema name that is first on the search path 
as well.


- Sebastian Toader


On Feb. 10, 2017, 1:21 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 10, 2017, 1:21 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56491: Fix default value for storm.messaging.netty.max_retries parameters in Ambari

[Sebastian Toader]

> On Feb. 9, 2017, 6 p.m., Sebastian Toader wrote:
> > Did the manual testing covered both Ambari upgrade and HDP upgrade 
> > scenarios to ensure that it works as expected? Also please include Jaimin 
> > Jetly to the list of reviewers in order to review the UI part.
> 
> Tibor Kiss wrote:
> Added Jaimin.
> Nope, I did not covered upgrade pathes. Is that a requirement?

After an Ambari and HDP upgrade the cluster should be still operational thus 
this scenario needs to tested to ensure it's not breaking anything on existing 
clusters.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56491/#review164940
---


On Feb. 9, 2017, 6:11 p.m., Tibor Kiss wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56491/
> ---
> 
> (Updated Feb. 9, 2017, 6:11 p.m.)
> 
> 
> Review request for Ambari, Andriy Babiichuk, Attila Doroszlai, Alexandr 
> Antonenko, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19850
> https://issues.apache.org/jira/browse/AMBARI-19850
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19850. Default value for storm.messaging.netty.max_retries is incorrect
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-site.xml
>  d830ace 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/STORM/configuration/storm-site.xml
>  e089ae0 
>   ambari-server/src/test/python/stacks/2.0.6/configs/altfs_plus_hdfs.json 
> ea00a37 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json 
> adab92f 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json
>  e81fe9e 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
> 71423c8 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json 
> 8c17e86 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 
> 571b737 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 
> 7fdb449 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_oozie_mysql.json 
> 7378b68 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_update_exclude_file_only.json
>  2ea07e4 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_with_bucket.json 
> 5080d30 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 6ec9ec9 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json 
> b197fde 
>   ambari-server/src/test/python/stacks/2.0.6/configs/oozie_existing_sqla.json 
> 8d12b98 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 5327865 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json 
> bf4ff12 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
> fa4cc9d 
>   ambari-server/src/test/python/stacks/2.1/configs/default-storm-start.json 
> 27cb63e 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb 
>   ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json 
> 1b027b7 
>   ambari-server/src/test/python/stacks/2.1/configs/secured.json 61b359c 
>   ambari-server/src/test/python/stacks/2.3/configs/ats_1_5.json b4342ad 
>   ambari-server/src/test/python/stacks/2.3/configs/default.hbasedecom.json 
> ad21c9b 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json fd482db 
>   ambari-server/src/test/python/stacks/2.3/configs/storm_default.json 351025d 
>   ambari-server/src/test/python/stacks/2.3/configs/storm_default_secure.json 
> daa9030 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 9dcb451 
>   
> ambari-server/src/test/python/stacks/2.5/configs/hsi_default_for_restart.json 
> 52b3983 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_ha.json 3fd9f72 
>   ambari-web/app/assets/data/configurations/cluster_level_configs.json 
> 2a46b2e 
>   ambari-web/app/assets/data/configurations/config_versions.json c9af200 
>   ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json e0aa9eb 
>   ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/STORM.json 58fd2a7 
>   
> contrib/views/slider/src/main/resources/ui/app/assets/data/apptypes/all_fields.json
>  19e3479 
> 
> Diff: https://reviews.apache.org/r/56491/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Tibor Kiss
> 
>

Re: Review Request 56511: To make sure LLAP preemption happens correctly, should enable priority-utilization.underutilized-preemption.enabled=true when YARN preemption is enabled

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56511/#review165113
---


Ship it!




Ship It!

- Dmytro Sen


On Фев. 10, 2017, 12:40 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56511/
> ---
> 
> (Updated Фев. 10, 2017, 12:40 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-19947
> https://issues.apache.org/jira/browse/AMBARI-19947
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We requires admin enables YARN preemption to make sure LLAP daemon can be 
> launched in a shared cluster.
> And 
> yarn.scheduler.capacity.ordering-policy.priority-utilization.underutilized-preemption.enabled=true
>  need to be set to make preemption can happen under a fragmented cluster.
> So once admin enables preemption, we can automatically set 
> yarn.scheduler.capacity.ordering-policy.priority-utilization.underutilized-preemption.enabled
>  to true.
> This option 
> (yarn.scheduler.capacity.ordering-policy.priority-utilization.underutilized-preemption.enabled)
>  only supported by HDP-2.6 and after, it has no effect on HDP 2.5 and before.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
>  30dd474 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml
>  555768e 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 957d625 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration/yarn-site.xml
>  0f46d75 
> 
> Diff: https://reviews.apache.org/r/56511/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 56511: To make sure LLAP preemption happens correctly, should enable priority-utilization.underutilized-preemption.enabled=true when YARN preemption is enabled

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56511/
---

(Updated Лют. 10, 2017, 12:40 після полудня)


Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and Sid 
Wagle.


Bugs: AMBARI-19947
https://issues.apache.org/jira/browse/AMBARI-19947


Repository: ambari


Description
---

We requires admin enables YARN preemption to make sure LLAP daemon can be 
launched in a shared cluster.
And 
yarn.scheduler.capacity.ordering-policy.priority-utilization.underutilized-preemption.enabled=true
 need to be set to make preemption can happen under a fragmented cluster.
So once admin enables preemption, we can automatically set 
yarn.scheduler.capacity.ordering-policy.priority-utilization.underutilized-preemption.enabled
 to true.
This option 
(yarn.scheduler.capacity.ordering-policy.priority-utilization.underutilized-preemption.enabled)
 only supported by HDP-2.6 and after, it has no effect on HDP 2.5 and before.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
 30dd474 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml
 555768e 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
957d625 
  
ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration/yarn-site.xml
 0f46d75 

Diff: https://reviews.apache.org/r/56511/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 56542: Hive View 2.0 - deleting a saved query is buggy

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56542/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19958
https://issues.apache.org/jira/browse/AMBARI-19958


Repository: ambari


Description
---

Setting the controller value to reflect the changes.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js 
5ee757b 
  contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 
27d43d5 
  contrib/views/hive20/src/main/resources/ui/app/controllers/saved-query.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
dcf27b4 
  contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 7b9cb09 
  contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 
29ef4b5 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
2d6c5aa 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
36dc982 

Diff: https://reviews.apache.org/r/56542/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56059: Broken kill_process_with_children shell single liner

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review165112
---


Ship it!




Ship It!

- Andrew Onischuk


On Feb. 10, 2017, 10:13 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56059/
> ---
> 
> (Updated Feb. 10, 2017, 10:13 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Dmytro 
> Grinenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-19768
> https://issues.apache.org/jira/browse/AMBARI-19768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This single liner does not work correctly in some cases
> {code}CMD = """ps xf | awk -v PID=""" + str(pid) + \
>   """ ' $1 == PID { P = $1; next } P && /_/ { P = P " " $1;""" + \
>   """K=P } P && !/_/ { P="" }  END { print "kill -""" \
>   + str(signal) + """ "K }' | sh """
> {code}
>   
> *Example*
> {code}((sleep 3141592) & ((sleep 3141592) & (sleep 3141592))
> 
> ps xf
> 
>  3231 ?Ss 0:01  \_ sshd: root@pts/0 
>  3233 pts/0Ss 0:00  |   \_ -bash
> 17984 pts/0S+ 0:00  |   \_ -bash
> 17985 pts/0S+ 0:00  |   \_ sleep 3141592
> 17986 pts/0S+ 0:00  |   \_ -bash
> 17987 pts/0S+ 0:00  |   \_ sleep 3141592
> 17988 pts/0S+ 0:00  |   \_ sleep 3141592
> 17738 ?Ss 0:00  \_ sshd: root@pts/1 
> 17740 pts/1Ss 0:00  \_ -bash
> 17989 pts/1R+ 0:00  \_ ps xf
> 
> ps xf | awk -v PID=17987 ' $1 == PID { P = $1; next } P && /_/ { P = P " " 
> $1;K=P } P && !/_/ { P="" }  END { print "kill "K }'
> 
> (PID=17987)
> result : "kill 17987 17988 17738 17740 18083 18084"
> but right will only "kill 17987"
> 
> (PID=17985)
> result : "kill 17985 17986 17987 17988 17738 17740 18697 18698"
> right : "kill 17985"
> 
> (PID=17986)
> result : "kill 17986 17987 17988 17738 17740 18980 18981"
> right : "kill 17986 17987 17988"
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py PRE-CREATION 
>   ambari-agent/src/test/python/ambari_agent/TestShell.py 8d375e3915 
>   ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION 
>   ambari-common/src/main/python/ambari_commons/shell.py 8d26599df8 
> 
> Diff: https://reviews.apache.org/r/56059/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/
---

Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-19957
https://issues.apache.org/jira/browse/AMBARI-19957


Repository: ambari


Description
---

Postgres allows multiple schemas on a database user's search path, that is 
users can query from tables in different schemas without the need of prefixing 
the tables in the query. 

This can lead to confusion when after an unsuccessful upgrade DBA's restore the 
tables into a different schema (e.g. public) to Ambari's configured one. As a 
result, Ambari server may see different data than indended.

New consistency checks on server startup warn the user in such situations.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 7aa8652 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 1704546 
  ambari-server/src/main/python/ambari_server_main.py 7a21333 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 f73562d 

Diff: https://reviews.apache.org/r/56540/diff/


Testing
---

- Wrote new unit tests
- Run all tests for ambari-server (all passed)
- Performed manual testing


Thanks,

Balázs Bence Sári

Re: Review Request 56394: Provide user-warning while upgrading clusters to move certificates/keystores/truststores out of conf folder

[Vishal Suvagia]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56394/
---

(Updated Feb. 10, 2017, 12:07 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, 
Oliver Szabo, Sumit Mohanty, and Velmurugan Periasamy.


Changes
---

Made changes as suggested.


Bugs: AMBARI-19897
https://issues.apache.org/jira/browse/AMBARI-19897


Repository: ambari


Description
---

As certificates/ keystores/ truststores present in /etc/ranger/*/conf path, 
this may affect the upgrade scenarios, where user needs to manually move the 
files to new conf directories.
Hence users upgrading to new stacks should be warned on prior basis to do the 
same manually (i.e move certificates/keystores/truststores out of conf folder).


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 8d8f540 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerSSLConfigCheck.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 8da11ff 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
01fc102 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 046904b 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
70bb2ca 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 5b8351b 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
2f07c97 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/RangerSSLConfigCheckTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56394/diff/


Testing
---

Verified upgrade process after fresh install on Cent-os 6.


Thanks,

Vishal Suvagia

Re: Review Request 56491: Fix default value for storm.messaging.netty.max_retries parameters in Ambari

[Tibor Kiss]

> On Feb. 9, 2017, 5 p.m., Sebastian Toader wrote:
> > Did the manual testing covered both Ambari upgrade and HDP upgrade 
> > scenarios to ensure that it works as expected? Also please include Jaimin 
> > Jetly to the list of reviewers in order to review the UI part.

Added Jaimin.
Nope, I did not covered upgrade pathes. Is that a requirement?


- Tibor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56491/#review164940
---


On Feb. 9, 2017, 5:11 p.m., Tibor Kiss wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56491/
> ---
> 
> (Updated Feb. 9, 2017, 5:11 p.m.)
> 
> 
> Review request for Ambari, Andriy Babiichuk, Attila Doroszlai, Alexandr 
> Antonenko, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19850
> https://issues.apache.org/jira/browse/AMBARI-19850
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19850. Default value for storm.messaging.netty.max_retries is incorrect
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-site.xml
>  d830ace 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/STORM/configuration/storm-site.xml
>  e089ae0 
>   ambari-server/src/test/python/stacks/2.0.6/configs/altfs_plus_hdfs.json 
> ea00a37 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json 
> adab92f 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json
>  e81fe9e 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
> 71423c8 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json 
> 8c17e86 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 
> 571b737 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 
> 7fdb449 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_oozie_mysql.json 
> 7378b68 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_update_exclude_file_only.json
>  2ea07e4 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_with_bucket.json 
> 5080d30 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 6ec9ec9 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json 
> b197fde 
>   ambari-server/src/test/python/stacks/2.0.6/configs/oozie_existing_sqla.json 
> 8d12b98 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 5327865 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json 
> bf4ff12 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
> fa4cc9d 
>   ambari-server/src/test/python/stacks/2.1/configs/default-storm-start.json 
> 27cb63e 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb 
>   ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json 
> 1b027b7 
>   ambari-server/src/test/python/stacks/2.1/configs/secured.json 61b359c 
>   ambari-server/src/test/python/stacks/2.3/configs/ats_1_5.json b4342ad 
>   ambari-server/src/test/python/stacks/2.3/configs/default.hbasedecom.json 
> ad21c9b 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json fd482db 
>   ambari-server/src/test/python/stacks/2.3/configs/storm_default.json 351025d 
>   ambari-server/src/test/python/stacks/2.3/configs/storm_default_secure.json 
> daa9030 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 9dcb451 
>   
> ambari-server/src/test/python/stacks/2.5/configs/hsi_default_for_restart.json 
> 52b3983 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_ha.json 3fd9f72 
>   ambari-web/app/assets/data/configurations/cluster_level_configs.json 
> 2a46b2e 
>   ambari-web/app/assets/data/configurations/config_versions.json c9af200 
>   ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json e0aa9eb 
>   ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/STORM.json 58fd2a7 
>   
> contrib/views/slider/src/main/resources/ui/app/assets/data/apptypes/all_fields.json
>  19e3479 
> 
> Diff: https://reviews.apache.org/r/56491/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Tibor Kiss
> 
>

Re: Review Request 56539: AMBARI-19956. Workflow Manager Flow Graph should show line transition to decision path and error node.

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56539/#review165102
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 10, 2017, 10:11 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56539/
> ---
> 
> (Updated Feb. 10, 2017, 10:11 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19956
> https://issues.apache.org/jira/browse/AMBARI-19956
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Made the changes to cytoscape datanodes to show transitions to decision path 
> and error node
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> 6507c49 
> 
> Diff: https://reviews.apache.org/r/56539/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 56379: AMBARI-19418: Support setup queue priority in Ambari - Capacity scheduler view

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56379/#review165096
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 10, 2017, 7:38 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56379/
> ---
> 
> (Updated Feb. 10, 2017, 7:38 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-19418
> https://issues.apache.org/jira/browse/AMBARI-19418
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Feature to support queue priority config settings in YARN
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js
>  589dcd0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js
>  2f9f2fe 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 9198aa5 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 940d0f8 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js dce00c1 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs
>  87f00d9 
> 
> Diff: https://reviews.apache.org/r/56379/diff/
> 
> 
> Testing
> ---
> 
> Manunal Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 56539: AMBARI-19956. Workflow Manager Flow Graph should show line transition to decision path and error node.

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56539/#review165095
---


Ship it!




Ship It!

- belliraj hb


On Feb. 10, 2017, 10:11 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56539/
> ---
> 
> (Updated Feb. 10, 2017, 10:11 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19956
> https://issues.apache.org/jira/browse/AMBARI-19956
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Made the changes to cytoscape datanodes to show transitions to decision path 
> and error node
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> 6507c49 
> 
> Diff: https://reviews.apache.org/r/56539/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 56059: Broken kill_process_with_children shell single liner

[Dmitro Lisnichenko]

> On Feb. 8, 2017, 4:57 p.m., Andrew Onischuk wrote:
> > ambari-common/src/main/python/ambari_commons/process_utils.py, line 48
> > 
> >
> > Was this tested in non-root?
> > Should we maybe call it with ambari-sudo.sh to be able to kill 
> > sub-processes started as service users hdfs etc. when running in non-root
> 
> Nate Cole wrote:
> +1 on this

yes


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review164687
---


On Feb. 10, 2017, 12:13 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56059/
> ---
> 
> (Updated Feb. 10, 2017, 12:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Dmytro 
> Grinenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-19768
> https://issues.apache.org/jira/browse/AMBARI-19768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This single liner does not work correctly in some cases
> {code}CMD = """ps xf | awk -v PID=""" + str(pid) + \
>   """ ' $1 == PID { P = $1; next } P && /_/ { P = P " " $1;""" + \
>   """K=P } P && !/_/ { P="" }  END { print "kill -""" \
>   + str(signal) + """ "K }' | sh """
> {code}
>   
> *Example*
> {code}((sleep 3141592) & ((sleep 3141592) & (sleep 3141592))
> 
> ps xf
> 
>  3231 ?Ss 0:01  \_ sshd: root@pts/0 
>  3233 pts/0Ss 0:00  |   \_ -bash
> 17984 pts/0S+ 0:00  |   \_ -bash
> 17985 pts/0S+ 0:00  |   \_ sleep 3141592
> 17986 pts/0S+ 0:00  |   \_ -bash
> 17987 pts/0S+ 0:00  |   \_ sleep 3141592
> 17988 pts/0S+ 0:00  |   \_ sleep 3141592
> 17738 ?Ss 0:00  \_ sshd: root@pts/1 
> 17740 pts/1Ss 0:00  \_ -bash
> 17989 pts/1R+ 0:00  \_ ps xf
> 
> ps xf | awk -v PID=17987 ' $1 == PID { P = $1; next } P && /_/ { P = P " " 
> $1;K=P } P && !/_/ { P="" }  END { print "kill "K }'
> 
> (PID=17987)
> result : "kill 17987 17988 17738 17740 18083 18084"
> but right will only "kill 17987"
> 
> (PID=17985)
> result : "kill 17985 17986 17987 17988 17738 17740 18697 18698"
> right : "kill 17985"
> 
> (PID=17986)
> result : "kill 17986 17987 17988 17738 17740 18980 18981"
> right : "kill 17986 17987 17988"
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py PRE-CREATION 
>   ambari-agent/src/test/python/ambari_agent/TestShell.py 8d375e3915 
>   ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION 
>   ambari-common/src/main/python/ambari_commons/shell.py 8d26599df8 
> 
> Diff: https://reviews.apache.org/r/56059/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 56059: Broken kill_process_with_children shell single liner

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/
---

(Updated Feb. 10, 2017, 12:13 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Dmytro 
Grinenko, Jonathan Hurley, and Nate Cole.


Changes
---

Fixes


Bugs: AMBARI-19768
https://issues.apache.org/jira/browse/AMBARI-19768


Repository: ambari


Description
---

This single liner does not work correctly in some cases
{code}CMD = """ps xf | awk -v PID=""" + str(pid) + \
  """ ' $1 == PID { P = $1; next } P && /_/ { P = P " " $1;""" + \
  """K=P } P && !/_/ { P="" }  END { print "kill -""" \
  + str(signal) + """ "K }' | sh """
{code}
  
*Example*
{code}((sleep 3141592) & ((sleep 3141592) & (sleep 3141592))

ps xf

 3231 ?Ss 0:01  \_ sshd: root@pts/0 
 3233 pts/0Ss 0:00  |   \_ -bash
17984 pts/0S+ 0:00  |   \_ -bash
17985 pts/0S+ 0:00  |   \_ sleep 3141592
17986 pts/0S+ 0:00  |   \_ -bash
17987 pts/0S+ 0:00  |   \_ sleep 3141592
17988 pts/0S+ 0:00  |   \_ sleep 3141592
17738 ?Ss 0:00  \_ sshd: root@pts/1 
17740 pts/1Ss 0:00  \_ -bash
17989 pts/1R+ 0:00  \_ ps xf

ps xf | awk -v PID=17987 ' $1 == PID { P = $1; next } P && /_/ { P = P " " 
$1;K=P } P && !/_/ { P="" }  END { print "kill "K }'

(PID=17987)
result : "kill 17987 17988 17738 17740 18083 18084"
but right will only "kill 17987"

(PID=17985)
result : "kill 17985 17986 17987 17988 17738 17740 18697 18698"
right : "kill 17985"

(PID=17986)
result : "kill 17986 17987 17988 17738 17740 18980 18981"
right : "kill 17986 17987 17988"
{code}


Diffs (updated)
-

  ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py PRE-CREATION 
  ambari-agent/src/test/python/ambari_agent/TestShell.py 8d375e3915 
  ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION 
  ambari-common/src/main/python/ambari_commons/shell.py 8d26599df8 

Diff: https://reviews.apache.org/r/56059/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Review Request 56539: AMBARI-19956. Workflow Manager Flow Graph should show line transition to decision path and error node.

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56539/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19956
https://issues.apache.org/jira/browse/AMBARI-19956


Repository: ambari


Description
---

Made the changes to cytoscape datanodes to show transitions to decision path 
and error node


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
6507c49 

Diff: https://reviews.apache.org/r/56539/diff/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 56538: Hive view 2.0 upload table does not provide first row is header check box.

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56538/#review165090
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 10, 2017, 9:53 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56538/
> ---
> 
> (Updated Feb. 10, 2017, 9:53 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19955
> https://issues.apache.org/jira/browse/AMBARI-19955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added the first row is header checkbox and its functionality
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/csv-format-params.js
>  7a14ba8 
>   contrib/views/hive20/src/main/resources/ui/app/models/column.js f38309b 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js
>  ba3260c 
>   contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 
> a5be574 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs
>  a7cb862 
> 
> Diff: https://reviews.apache.org/r/56538/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 56538: Hive view 2.0 upload table does not provide first row is header check box.

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56538/#review165089
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 10, 2017, 9:53 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56538/
> ---
> 
> (Updated Feb. 10, 2017, 9:53 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19955
> https://issues.apache.org/jira/browse/AMBARI-19955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added the first row is header checkbox and its functionality
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/csv-format-params.js
>  7a14ba8 
>   contrib/views/hive20/src/main/resources/ui/app/models/column.js f38309b 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js
>  ba3260c 
>   contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 
> a5be574 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs
>  a7cb862 
> 
> Diff: https://reviews.apache.org/r/56538/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 56538: Hive view 2.0 upload table does not provide first row is header check box.

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56538/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
and Rohit Choudhary.


Bugs: AMBARI-19955
https://issues.apache.org/jira/browse/AMBARI-19955


Repository: ambari


Description
---

added the first row is header checkbox and its functionality


Diffs
-

  
contrib/views/hive20/src/main/resources/ui/app/components/csv-format-params.js 
7a14ba8 
  contrib/views/hive20/src/main/resources/ui/app/models/column.js f38309b 
  
contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js
 ba3260c 
  contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 
a5be574 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs
 a7cb862 

Diff: https://reviews.apache.org/r/56538/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Re: Review Request 56379: AMBARI-19418: Support setup queue priority in Ambari - Capacity scheduler view

[Sreenath Somarajapuram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56379/#review165086
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On Feb. 10, 2017, 7:38 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56379/
> ---
> 
> (Updated Feb. 10, 2017, 7:38 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-19418
> https://issues.apache.org/jira/browse/AMBARI-19418
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Feature to support queue priority config settings in YARN
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js
>  589dcd0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js
>  2f9f2fe 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 9198aa5 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 940d0f8 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js dce00c1 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs
>  87f00d9 
> 
> Diff: https://reviews.apache.org/r/56379/diff/
> 
> 
> Testing
> ---
> 
> Manunal Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 56532: AMBARI-19954:Workflow designer is getting hung while importing the workflow

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56532/#review165072
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 10, 2017, 7:19 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56532/
> ---
> 
> (Updated Feb. 10, 2017, 7:19 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19954
> https://issues.apache.org/jira/browse/AMBARI-19954
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by adding batch rendering in cytoscape and by using cytoscape APIs to 
> find the descendent nodes rather than traversing the workflow DAG.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js
>  e4b2224 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> fd7a258 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/transition-config.js
>  ca45b1f 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
>  17fb4a0 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  b9ecb11 
> 
> Diff: https://reviews.apache.org/r/56532/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56379: AMBARI-19418: Support setup queue priority in Ambari - Capacity scheduler view

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56379/#review165071
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 10, 2017, 7:38 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56379/
> ---
> 
> (Updated Feb. 10, 2017, 7:38 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-19418
> https://issues.apache.org/jira/browse/AMBARI-19418
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Feature to support queue priority config settings in YARN
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js
>  589dcd0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js
>  2f9f2fe 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 9198aa5 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 940d0f8 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js dce00c1 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs
>  87f00d9 
> 
> Diff: https://reviews.apache.org/r/56379/diff/
> 
> 
> Testing
> ---
> 
> Manunal Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>