Review Request 56777: AMBARI-20058 - 'Final' is not shown correctly in config diff tool and in older versions

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56777/
---

Review request for Ambari, Andriy Babiichuk and Oleg Nechiporenko.


Bugs: AMBARI-20058
https://issues.apache.org/jira/browse/AMBARI-20058


Repository: ambari


Description
---

This issue was introduced in AMBARI-15459
Fix the condition of showing override differently.


Diffs
-

  ambari-web/app/templates/common/configs/service_config_category.hbs fbcb828 
  ambari-web/app/views/common/configs/controls_view.js 8894ea6 

Diff: https://reviews.apache.org/r/56777/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  20340 passing (23s)
  153 pending


Thanks,

Richard Zang

Re: Review Request 56772: Storm config change results in Consistency check failed

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56772/#review165892
---


Ship it!




Ship It!

- Alexandr Antonenko


On Feb. 16, 2017, 11:28 p.m., Denys Buzhor wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56772/
> ---
> 
> (Updated Feb. 16, 2017, 11:28 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-20059
> https://issues.apache.org/jira/browse/AMBARI-20059
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> steps to reproduce:
> # install cluster with Storm and Ranger
> # go to Services -> Storm -> Configs
> # change any config
> # save configs
> 
> observes configuration validation failure due to absent Yarn configs.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/info/configs.js d95a2d281f 
>   ambari-web/app/mixins/common/track_request_mixin.js 4efcecb59d 
>   ambari-web/test/controllers/main/service/info/config_test.js 4cc2ef898a 
> 
> Diff: https://reviews.apache.org/r/56772/diff/
> 
> 
> Testing
> ---
> 
> 20344 passing (24s)
>   153 pending
> 
> 
> Thanks,
> 
> Denys Buzhor
> 
>

Review Request 56772: Storm config change results in Consistency check failed

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56772/
---

Review request for Ambari and Alexandr Antonenko.


Bugs: AMBARI-20059
https://issues.apache.org/jira/browse/AMBARI-20059


Repository: ambari


Description
---

steps to reproduce:
# install cluster with Storm and Ranger
# go to Services -> Storm -> Configs
# change any config
# save configs

observes configuration validation failure due to absent Yarn configs.


Diffs
-

  ambari-web/app/controllers/main/service/info/configs.js d95a2d281f 
  ambari-web/app/mixins/common/track_request_mixin.js 4efcecb59d 
  ambari-web/test/controllers/main/service/info/config_test.js 4cc2ef898a 

Diff: https://reviews.apache.org/r/56772/diff/


Testing
---

20344 passing (24s)
  153 pending


Thanks,

Denys Buzhor

Re: Review Request 56766: Remove Entities Associated With clusterconfigmapping

[Jonathan Hurley]

> On Feb. 16, 2017, 4:55 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java,
> >  line 227
> > 
> >
> > Looks like a NOOP. Should be deleted?

Ah, yes, I think this is covered by the above query which checks against the 
service configs. I shall remove it.


> On Feb. 16, 2017, 4:55 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java,
> >  line 2562
> > 
> >
> > Any reason for copy here? Doesn't look like original collection is 
> > modified.

Hm - I think I was copying it to get it into a list in order to find by ID 
- however, this wasn't needed, so I can remove this as well.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56766/#review165884
---


On Feb. 16, 2017, 4:12 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56766/
> ---
> 
> (Updated Feb. 16, 2017, 4:12 p.m.)
> 
> 
> Review request for Ambari, Nate Cole, Robert Levas, Sebastian Toader, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20054
> https://issues.apache.org/jira/browse/AMBARI-20054
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Please see the Epic (https://issues.apache.org/jira/browse/AMBARI-20053) for 
> a full description. Additionally, supporting work (such as Ambari upgrade) is 
> tracked in that epic via other Jiras (like AMBARI-20055)
> 
> This review is for AMBARI-20054, which tracks the work needed to remove the 
> `clusterconfigmapping` table and transfer its responsibility into the 
> `clusterconfig` table.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  926ec65 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
>  d35fc1a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
> b727c72 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
>  d14e60e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigMappingEntity.java
>  5748dc9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigMappingEntityPK.java
>  e5ba5af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
>  2e0a15d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java
>  dae7ef8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DesiredConfig.java 
> 80d05f7 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 713c189 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  db4aa21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 328fe22 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f007b53 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f6cb896 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 19253e8 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b13a9e3 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql cf2954a 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 16c269a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java
>  a0732ab 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/DesiredConfigTest.java
>  09aaa92 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
>  6cdfbad 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
>  5b54af4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 
> d418a80 
> 
> Diff: https://reviews.apache.org/r/56766/diff/
> 
> 
> Testing
> ---
> 
> - Cluster deployment from scratch
> - New configurations created and reverted to
> - Stack upgrade, downgrade, upgrade/finalize
> - Configuration group creation
> 
> Tests run: 4918, Failures: 0, Errors: 0, Skipped: 39
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 17:24 min
> [INFO] Finished at: 2017-02-16T15:02:06-05:00
> [INFO] Final Memory: 59M/661M
> [INFO] 
> 

Re: Review Request 56766: Remove Entities Associated With clusterconfigmapping

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56766/#review165884
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 227)


Looks like a NOOP. Should be deleted?



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
(line 194)


minor nit: "may not be selected"



ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 (line 2560)


Any reason for copy here? Doesn't look like original collection is modified.


- Sid Wagle


On Feb. 16, 2017, 9:12 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56766/
> ---
> 
> (Updated Feb. 16, 2017, 9:12 p.m.)
> 
> 
> Review request for Ambari, Nate Cole, Robert Levas, Sebastian Toader, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20054
> https://issues.apache.org/jira/browse/AMBARI-20054
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Please see the Epic (https://issues.apache.org/jira/browse/AMBARI-20053) for 
> a full description. Additionally, supporting work (such as Ambari upgrade) is 
> tracked in that epic via other Jiras (like AMBARI-20055)
> 
> This review is for AMBARI-20054, which tracks the work needed to remove the 
> `clusterconfigmapping` table and transfer its responsibility into the 
> `clusterconfig` table.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  926ec65 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
>  d35fc1a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
> b727c72 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
>  d14e60e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigMappingEntity.java
>  5748dc9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigMappingEntityPK.java
>  e5ba5af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
>  2e0a15d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java
>  dae7ef8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DesiredConfig.java 
> 80d05f7 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 713c189 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  db4aa21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 328fe22 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f007b53 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f6cb896 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 19253e8 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b13a9e3 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql cf2954a 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 16c269a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java
>  a0732ab 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/DesiredConfigTest.java
>  09aaa92 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
>  6cdfbad 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
>  5b54af4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 
> d418a80 
> 
> Diff: https://reviews.apache.org/r/56766/diff/
> 
> 
> Testing
> ---
> 
> - Cluster deployment from scratch
> - New configurations created and reverted to
> - Stack upgrade, downgrade, upgrade/finalize
> - Configuration group creation
> 
> Tests run: 4918, Failures: 0, Errors: 0, Skipped: 39
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 17:24 min
> [INFO] Finished at: 2017-02-16T15:02:06-05:00
> [INFO] Final Memory: 59M/661M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 56765: AMBARI-20056 : FIFO compaction resulting in too many store files on large cluster

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56765/#review165882
---


Fix it, then Ship it!





ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 (line 635)


We shuld make blocking store files configurable.


- Sid Wagle


On Feb. 16, 2017, 9:10 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56765/
> ---
> 
> (Updated Feb. 16, 2017, 9:10 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20056
> https://issues.apache.org/jira/browse/AMBARI-20056
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> On a 500 node cluster AMS can become in-operational after creating 18K store 
> files and no compaction.
> 
> 
> FIX
> Set Data Tiered compaction for all tables except METRIC_RECORD. This will 
> allow number of store files to go down over time. 
> 
> As part of this effort, I refined the segment of the code where AMS HBase 
> tables policies are set such that any compaction policy can be set for 
> precision and aggregate tables.
> 
> Defaults
> Precision Table (METRIC_RECORD)
> hbase.hstore.defaultengine.compactionpolicy.class : 
> org.apache.hadoop.hbase.regionserver.compactions.FIFOCompactionPolicy
> 
> Aggregate Tables
> hbase.hstore.engine.class : 
> org.apache.hadoop.hbase.regionserver.DateTieredStoreEngine
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  b249d05 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  ad05025 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  7bbd5aa 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  3bc1929 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  0d0b8a2 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  76f8660 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  112f212 
> 
> Diff: https://reviews.apache.org/r/56765/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> mvn clean test on Ambari metrics.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 56678: PixieDust - Decrease Service Check running time under 3 mins

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56678/
---

(Updated Feb. 16, 2017, 11:16 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Changes
---

addressed comments


Bugs: AMBARI-20017
https://issues.apache.org/jira/browse/AMBARI-20017


Repository: ambari


Description
---

Right now, Ambari has a timeout of 5-10 mins for Service Checks.
We need to ensure service checks pass in less than 3 mins for all services.

This means we need to potentially use a different configuration property if one 
doesn't exist already so that QE can set it during the Ambari devdeploy tests 
(in order to speed up the tests).

This will likely result in bugs in either the Ambari python scripts or the 
actual services, for which we will create Jiras and assign to the appropriate 
stack team.

This patch implements cluster_env/strict_service_check_type property. Possible 
values are minimal (handled inside service check, runs shorter service check 
action) and full (default action). If value is minimal, I also reduce service 
check timeout when generating command on server in 2 times. This way we adapt 
to service check timeouts that may be different for different services. If 
service check takes 9 minutes of 10-minute timeout to pass on our non-busy 
cluster, then it will probably take more then 10 minutes on customers real 
cluster, and that is bad thing (bug).


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 b601893 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
13d0993 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
3af8f08 

Diff: https://reviews.apache.org/r/56678/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Review Request 56766: Remove Entities Associated With clusterconfigmapping

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56766/
---

Review request for Ambari, Nate Cole, Robert Levas, Sebastian Toader, and Sid 
Wagle.


Bugs: AMBARI-20054
https://issues.apache.org/jira/browse/AMBARI-20054


Repository: ambari


Description
---

Please see the Epic (https://issues.apache.org/jira/browse/AMBARI-20053) for a 
full description. Additionally, supporting work (such as Ambari upgrade) is 
tracked in that epic via other Jiras (like AMBARI-20055)

This review is for AMBARI-20054, which tracks the work needed to remove the 
`clusterconfigmapping` table and transfer its responsibility into the 
`clusterconfig` table.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 926ec65 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
 d35fc1a 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
b727c72 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
 d14e60e 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigMappingEntity.java
 5748dc9 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigMappingEntityPK.java
 e5ba5af 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
 2e0a15d 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java
 dae7ef8 
  ambari-server/src/main/java/org/apache/ambari/server/state/DesiredConfig.java 
80d05f7 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
713c189 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 db4aa21 
  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
328fe22 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f007b53 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f6cb896 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 19253e8 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b13a9e3 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql cf2954a 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 16c269a 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java
 a0732ab 
  
ambari-server/src/test/java/org/apache/ambari/server/state/DesiredConfigTest.java
 09aaa92 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
 6cdfbad 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
 5b54af4 
  ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 
d418a80 

Diff: https://reviews.apache.org/r/56766/diff/


Testing
---

- Cluster deployment from scratch
- New configurations created and reverted to
- Stack upgrade, downgrade, upgrade/finalize
- Configuration group creation

Tests run: 4918, Failures: 0, Errors: 0, Skipped: 39

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 17:24 min
[INFO] Finished at: 2017-02-16T15:02:06-05:00
[INFO] Final Memory: 59M/661M
[INFO] 


Thanks,

Jonathan Hurley

Review Request 56765: AMBARI-20056 : FIFO compaction resulting in too many store files on large cluster

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56765/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-20056
https://issues.apache.org/jira/browse/AMBARI-20056


Repository: ambari


Description
---

PROBLEM
On a 500 node cluster AMS can become in-operational after creating 18K store 
files and no compaction.


FIX
Set Data Tiered compaction for all tables except METRIC_RECORD. This will allow 
number of store files to go down over time. 

As part of this effort, I refined the segment of the code where AMS HBase 
tables policies are set such that any compaction policy can be set for 
precision and aggregate tables.

Defaults
Precision Table (METRIC_RECORD)
hbase.hstore.defaultengine.compactionpolicy.class : 
org.apache.hadoop.hbase.regionserver.compactions.FIFOCompactionPolicy

Aggregate Tables
hbase.hstore.engine.class : 
org.apache.hadoop.hbase.regionserver.DateTieredStoreEngine


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 b249d05 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 ad05025 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 7bbd5aa 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
 3bc1929 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 0d0b8a2 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 76f8660 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 112f212 

Diff: https://reviews.apache.org/r/56765/diff/


Testing
---

Manually tested.
mvn clean test on Ambari metrics.


Thanks,

Aravindan Vijayan

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/
---

(Updated Feb. 16, 2017, 7:28 p.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
Nettleton.


Changes
---

- update solr test (update permission)


Bugs: AMBARI-20013
https://issues.apache.org/jira/browse/AMBARI-20013


Repository: ambari


Description
---

- make sure solr keytab and solr user is created on logsearch/ranger/atlas hosts
- created a new solr_cloud_util method called add roles (curl for adding user 
roles)
- updated secure znode method (adding infra-solr by default)
- move generated security.json into a static file
- added a custom security.json which can be used instead of the generated 
security.json

In ranger/atlas stack, the following calls can be used for securing znode and 
update user-roles:

solr_cloud_util.secure_znode(config=params.config, 
zookeeper_quorum=params.zookeeper_quorum,
 
solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
 jaas_file=params.logsearch_jaas_file,
 java64_home=params.java64_home, 
sasl_users=["myuser1@HOST", "myuser2"])
 
and 

solr_cloud_util.add_solr_roles(params.config,
   roles = ["ranger_audit_user"],
   new_service_principals = ["audituser1", 
"audituser2"])
   
about ranger plugins:

there is a way to use these methods in other services like storm etc. , the 
problem is its needed to infra-solr be started, so if we include these in a lot 
of other services, it can really slows down the deployment. that is the reason 
why i kept the property dependencies in infra-solr-security-json config. other 
then that, with the changes ranger can start successfully if its added later to 
the cluster, and for plugins, infra-solr will be flagged to be restarted.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 4628211 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 e193a8c 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 ab9aa61 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 8d72f42 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 ed764f0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 2232bb2 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 682fc9f 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
bc8e351 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
49d1b10 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 fecd802 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 ba91e20 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 0b4532b 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 ae49c4f 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
253e32e 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
1bbf75e 
  ambari-server/src/test/python/stacks/2.3/configs/secure.json 4501b81 
  ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
cd88fec 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py db9cbb9 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py b01e7da 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 8dda363 

Diff: https://reviews.apache.org/r/56671/diff/


Testing
---

unit tests done.


Thanks,

Oliver Szabo

Re: Review Request 56710: Relax ranger config DB consistency check rules

[Alejandro Fernandez]

> On Feb. 15, 2017, 9:05 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java,
> >  line 905
> > 
> >
> > We shouldn't be hardcoding service names or config types in a check 
> > like this.
> > If this is preventing the user from starting Ambari Server, then we 
> > should make this type of check be a warning as opposed to a hard error, or 
> > annotate a service or config-type with a tag to relax its validation in 
> > this check.
> > 
> > Please add Jayush to the code review.
> 
> Andrew Onischuk wrote:
> This a one-case scenario. I would say, adding an xml syntax to 
> metainfo.xml to Relax on given service for given config-type would be an 
> overkill.
> 
> Jayush Luniya wrote:
> Agreed for 2.5 we should just address this for RANGER in code. I dont 
> think we can make the DB check a warning if some crucial config types are 
> missing. In the long term we can look at a cleaner solution.

Eventually Atlas may need the same thing. I'm ok with it for now then, but we 
should really try to move such definitions to the service metainfo.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165756
---


On Feb. 16, 2017, 11:24 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> ---
> 
> (Updated Feb. 16, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  878d0fa 
> 
> Diff: https://reviews.apache.org/r/56710/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56761: Hosts filter component list is not sorted so it is difficult to use

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56761/#review165867
---


Ship it!




Ship It!

- Andriy Babiichuk


On Лют. 16, 2017, 4:14 після полудня, Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56761/
> ---
> 
> (Updated Лют. 16, 2017, 4:14 після полудня)
> 
> 
> Review request for Ambari and Andriy Babiichuk.
> 
> 
> Bugs: AMBARI-20051
> https://issues.apache.org/jira/browse/AMBARI-20051
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hosts filter component list is not sorted so it is difficult to use
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/main/host/combo_search_box.js 2f9900a 
>   ambari-web/test/views/main/host/combo_search_box_test.js c82167c 
> 
> Diff: https://reviews.apache.org/r/56761/diff/
> 
> 
> Testing
> ---
> 
> 30314 passing (23s)
>   157 pending
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>

Review Request 56761: Hosts filter component list is not sorted so it is difficult to use

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56761/
---

Review request for Ambari and Andriy Babiichuk.


Bugs: AMBARI-20051
https://issues.apache.org/jira/browse/AMBARI-20051


Repository: ambari


Description
---

Hosts filter component list is not sorted so it is difficult to use


Diffs
-

  ambari-web/app/views/main/host/combo_search_box.js 2f9900a 
  ambari-web/test/views/main/host/combo_search_box_test.js c82167c 

Diff: https://reviews.apache.org/r/56761/diff/


Testing
---

30314 passing (23s)
  157 pending


Thanks,

Aleksandr Kovalenko

Re: Review Request 56641: Change Livy recovery folder permission to 0700

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56641/#review165864
---


Ship it!




Ship It!

- Jayush Luniya


On Feb. 14, 2017, 5:29 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56641/
> ---
> 
> (Updated Feb. 14, 2017, 5:29 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17
> https://issues.apache.org/jira/browse/AMBARI-17
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change Livy recovery folder permission to 0700
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  32615c3 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
>  2e92509 
>   ambari-server/src/test/python/stacks/2.5/SPARK/test_spark_livy.py b9199c7 
>   ambari-server/src/test/python/stacks/2.6/SPARK2/test_spark_livy2.py 75aec84 
> 
> Diff: https://reviews.apache.org/r/56641/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Review Request 56759: AMBARI-20047 : Repository config user needs to set customized service user in Ranger when service plugin is enabled.

[Vishal Suvagia]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56759/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, 
Oliver Szabo, Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-20047
https://issues.apache.org/jira/browse/AMBARI-20047


Repository: ambari


Description
---

The property REPOSITORY_CONFIG_USERNAME in Advanced ranger-*-plugin-properties 
is not updated to the custom user-name when services are using custom users.
This causes issues especially in cases of Test connection, and policy user 
which is given default permissions in Ranger.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 a12116d 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/ranger-atlas-plugin-properties.xml
 d8885e5 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HBASE/configuration/ranger-hbase-plugin-properties.xml
 d8885e5 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
 6e93879 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/ranger-hive-plugin-properties.xml
 d8885e5 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml
 d8885e5 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/ranger-yarn-plugin-properties.xml
 d8885e5 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
969c3dd 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py b7f8cbb 

Diff: https://reviews.apache.org/r/56759/diff/


Testing
---

Verified with a fresh installation on CentOS-6.


Thanks,

Vishal Suvagia

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/
---

(Updated Feb. 16, 2017, 3:57 p.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
Nettleton.


Changes
---

small additions:
- make sure both security.json are generated
- do not accept spaces for custom-security.json
- change both security.json files permission


Bugs: AMBARI-20013
https://issues.apache.org/jira/browse/AMBARI-20013


Repository: ambari


Description
---

- make sure solr keytab and solr user is created on logsearch/ranger/atlas hosts
- created a new solr_cloud_util method called add roles (curl for adding user 
roles)
- updated secure znode method (adding infra-solr by default)
- move generated security.json into a static file
- added a custom security.json which can be used instead of the generated 
security.json

In ranger/atlas stack, the following calls can be used for securing znode and 
update user-roles:

solr_cloud_util.secure_znode(config=params.config, 
zookeeper_quorum=params.zookeeper_quorum,
 
solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
 jaas_file=params.logsearch_jaas_file,
 java64_home=params.java64_home, 
sasl_users=["myuser1@HOST", "myuser2"])
 
and 

solr_cloud_util.add_solr_roles(params.config,
   roles = ["ranger_audit_user"],
   new_service_principals = ["audituser1", 
"audituser2"])
   
about ranger plugins:

there is a way to use these methods in other services like storm etc. , the 
problem is its needed to infra-solr be started, so if we include these in a lot 
of other services, it can really slows down the deployment. that is the reason 
why i kept the property dependencies in infra-solr-security-json config. other 
then that, with the changes ranger can start successfully if its added later to 
the cluster, and for plugins, infra-solr will be flagged to be restarted.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 4628211 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 e193a8c 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 ab9aa61 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 8d72f42 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 ed764f0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 2232bb2 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 682fc9f 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
bc8e351 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
49d1b10 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 fecd802 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 ba91e20 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 0b4532b 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 ae49c4f 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
253e32e 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
1bbf75e 
  ambari-server/src/test/python/stacks/2.3/configs/secure.json 4501b81 
  ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
cd88fec 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py db9cbb9 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py b01e7da 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 8dda363 

Diff: https://reviews.apache.org/r/56671/diff/


Testing
---

unit tests done.


Thanks,

Oliver Szabo

Re: Review Request 56743: LogFeeder Simulator Enhancements for 3000-node cluster testing

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56743/#review165859
---


Fix it, then Ship it!




Overall, I think the patch is fine, but some modifications or further 
investigation might be required to determine how the hosts in the simulation 
should be named.

Could you please add Yusaku, Alejandro, and Sid to this review?


ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
 (line 83)


I'm not sure if this will work in the context of the 3000-node cluster 
effort, since the ambari-agent will simulate multiple hosts as wel.

Perhaps we should allow for a user to either specify the hostnames to use, 
or maybe specify a pattern or prefix to use in the host naming.  

For the sake of consistency, and for debugging these larger test clusters, 
it might be better to be able to correlate between the hostnames used by the 
ambari-agent simulator and the hostnames used by the LogFeeder simulator.


- Robert Nettleton


On Feb. 16, 2017, 9:54 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56743/
> ---
> 
> (Updated Feb. 16, 2017, 9:54 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20038
> https://issues.apache.org/jira/browse/AMBARI-20038
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The number of simulators set via logfeeder.simulate.input_number should work 
> as imitating separate hosts, having separate queues pushing data from to the 
> solr.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  24651ba 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigBlock.java
>  47ddc51 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
>  684f3c4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
>  be97a52 
> 
> Diff: https://reviews.apache.org/r/56743/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 56606: Allow user to view Tez View after executing query

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/#review165860
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 16, 2017, 2:33 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56606/
> ---
> 
> (Updated Feb. 16, 2017, 2:33 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19989
> https://issues.apache.org/jira/browse/AMBARI-19989
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As per the parity with Hive View 1.5, allow user to traverse to tez view from 
> the query page after executing a query.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 88202ff 
>   contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 5b2b5c2 
> 
> Diff: https://reviews.apache.org/r/56606/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Review Request 56759: AMBARI-20047 : Repository config user needs to set customized service user in Ranger when service plugin is enabled.

[Vishal Suvagia]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56759/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, 
Oliver Szabo, Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-20047
https://issues.apache.org/jira/browse/AMBARI-20047


Repository: ambari


Description
---

The property REPOSITORY_CONFIG_USERNAME in Advanced ranger-*-plugin-properties 
is not updated to the custom user-name when services are using custom users.
This causes issues especially in cases of Test connection, and policy user 
which is given default permissions in Ranger.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 a12116d 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/ranger-atlas-plugin-properties.xml
 d8885e5 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HBASE/configuration/ranger-hbase-plugin-properties.xml
 d8885e5 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
 6e93879 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/ranger-hive-plugin-properties.xml
 d8885e5 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml
 d8885e5 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/ranger-yarn-plugin-properties.xml
 d8885e5 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
969c3dd 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py b7f8cbb 

Diff: https://reviews.apache.org/r/56759/diff/


Testing
---

Verified with a fresh installation on CentOS-6.


Thanks,

Vishal Suvagia

Re: Review Request 56710: Relax ranger config DB consistency check rules

[Jayush Luniya]

> On Feb. 15, 2017, 9:05 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java,
> >  line 905
> > 
> >
> > We shouldn't be hardcoding service names or config types in a check 
> > like this.
> > If this is preventing the user from starting Ambari Server, then we 
> > should make this type of check be a warning as opposed to a hard error, or 
> > annotate a service or config-type with a tag to relax its validation in 
> > this check.
> > 
> > Please add Jayush to the code review.
> 
> Andrew Onischuk wrote:
> This a one-case scenario. I would say, adding an xml syntax to 
> metainfo.xml to Relax on given service for given config-type would be an 
> overkill.

Agreed for 2.5 we should just address this for RANGER in code. I dont think we 
can make the DB check a warning if some crucial config types are missing. In 
the long term we can look at a cleaner solution.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165756
---


On Feb. 16, 2017, 11:24 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> ---
> 
> (Updated Feb. 16, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  878d0fa 
> 
> Diff: https://reviews.apache.org/r/56710/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56751: One way SSL fallback logic can cause some agents to be connected with 2-way SSL

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56751/#review165856
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Лют. 16, 2017, 1:49 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56751/
> ---
> 
> (Updated Лют. 16, 2017, 1:49 після полудня)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-20049
> https://issues.apache.org/jira/browse/AMBARI-20049
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We have fallback logic since a long time in the agent to try to connect to the
> server with 2-way SSL if one-way SSL throws an exception. This can cause some
> agents to connect with 2-way SSL (connection timeout exception for one-way
> SSL) and thereby a cluster having a mix of agents, some connected with one-way
> SSL and some connected with 2-way SSL.
> 
> Investigate why we have had this logic and if it is no longer appropriate,
> remove this fallback logic.
> 
>  agent/src/main/python/ambari_agent/security.py#L57-L67>
> 
> 
> 
> 
> if not self.two_way_ssl_required:
>   try:
> sock = self.create_connection()
> self.sock = ssl.wrap_socket(sock, cert_reqs=ssl.CERT_NONE)
> logger.info('SSL connection established. Two-way SSL 
> authentication is '
> 'turned off on the server.')
>   except (ssl.SSLError, AttributeError):
> self.two_way_ssl_required = True
> logger.info(
>   'Insecure connection to https://' + self.host + ':' + self.port 
> +
>   '/ failed. Reconnecting using two-way SSL authentication..')
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/security.py 779b85c 
>   ambari-agent/src/test/python/ambari_agent/TestSecurity.py 9e28ae7 
> 
> Diff: https://reviews.apache.org/r/56751/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56606: Allow user to view Tez View after executing query

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/
---

(Updated Feb. 16, 2017, 2:33 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19989
https://issues.apache.org/jira/browse/AMBARI-19989


Repository: ambari


Description
---

As per the parity with Hive View 1.5, allow user to traverse to tez view from 
the query page after executing a query.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
88202ff 
  contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
5b2b5c2 

Diff: https://reviews.apache.org/r/56606/diff/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56743: LogFeeder Simulator Enhancements for 3000-node cluster testing

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56743/#review165850
---


Ship it!




Ship It!

- Oliver Szabo


On Feb. 16, 2017, 9:54 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56743/
> ---
> 
> (Updated Feb. 16, 2017, 9:54 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20038
> https://issues.apache.org/jira/browse/AMBARI-20038
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The number of simulators set via logfeeder.simulate.input_number should work 
> as imitating separate hosts, having separate queues pushing data from to the 
> solr.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  24651ba 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigBlock.java
>  47ddc51 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
>  684f3c4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
>  be97a52 
> 
> Diff: https://reviews.apache.org/r/56743/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 56756: Hive View 2.0: Visual Explain-The operators are being shown out of order

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56756/#review165849
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 16, 2017, 2:19 p.m., Abhishek Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56756/
> ---
> 
> (Updated Feb. 16, 2017, 2:19 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20048
> https://issues.apache.org/jira/browse/AMBARI-20048
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The operators are being shown out of order. It’s hard to think about what to 
> do with the plan output when the operators are out of order, so this needs to 
> be fixed first.
> 
> 
> Diffs
> -
> 
>   .gitignore a40e61a 
>   contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 
> 6805bb8 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 88202ff 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer.js 
> 2b59340 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js 
> PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56756/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Abhishek Kumar
> 
>

Review Request 56756: Hive View 2.0: Visual Explain-The operators are being shown out of order

[Abhishek Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56756/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20048
https://issues.apache.org/jira/browse/AMBARI-20048


Repository: ambari


Description
---

The operators are being shown out of order. It’s hard to think about what to do 
with the plan output when the operators are out of order, so this needs to be 
fixed first.


Diffs
-

  .gitignore a40e61a 
  contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 
6805bb8 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
88202ff 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
  contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer.js 
2b59340 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js 
PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js 
PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
 PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 
PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56756/diff/


Testing
---

Manually Tested


Thanks,

Abhishek Kumar

Review Request 56751: One way SSL fallback logic can cause some agents to be connected with 2-way SSL

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56751/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-20049
https://issues.apache.org/jira/browse/AMBARI-20049


Repository: ambari


Description
---

We have fallback logic since a long time in the agent to try to connect to the
server with 2-way SSL if one-way SSL throws an exception. This can cause some
agents to connect with 2-way SSL (connection timeout exception for one-way
SSL) and thereby a cluster having a mix of agents, some connected with one-way
SSL and some connected with 2-way SSL.

Investigate why we have had this logic and if it is no longer appropriate,
remove this fallback logic.






if not self.two_way_ssl_required:
  try:
sock = self.create_connection()
self.sock = ssl.wrap_socket(sock, cert_reqs=ssl.CERT_NONE)
logger.info('SSL connection established. Two-way SSL authentication 
is '
'turned off on the server.')
  except (ssl.SSLError, AttributeError):
self.two_way_ssl_required = True
logger.info(
  'Insecure connection to https://' + self.host + ':' + self.port +
  '/ failed. Reconnecting using two-way SSL authentication..')


Diffs
-

  ambari-agent/src/main/python/ambari_agent/security.py 779b85c 
  ambari-agent/src/test/python/ambari_agent/TestSecurity.py 9e28ae7 

Diff: https://reviews.apache.org/r/56751/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 56750: Don't rerender all widgets when on of them is changed

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56750/#review165841
---


Ship it!




Ship It!

- Denys Buzhor


On Feb. 16, 2017, 1:29 p.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56750/
> ---
> 
> (Updated Feb. 16, 2017, 1:29 p.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-20043
> https://issues.apache.org/jira/browse/ambari-20043
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Dashboard widgets are rerendered if some of them is changed. Actually only 
> this one should be updated and not other
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/test/tests.js d47d558 
>   ambari-web/app/data/dashboard_widgets.js PRE-CREATION 
>   ambari-web/app/messages.js 81833f3 
>   ambari-web/app/mixins/common/track_request_mixin.js 4efcecb 
>   ambari-web/app/mixins/main/dashboard/widgets/editable.js fcb6bfb 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js ddf2a26 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> 06bcffe 
>   ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs 7caf085 
>   
> ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs
>  86ffb47 
>   ambari-web/app/views.js 77b5d5a 
>   ambari-web/app/views/common/modal_popups/edit_dashboard_widget_popup.js 
> PRE-CREATION 
>   ambari-web/app/views/main/dashboard/widget.js e7a626c 
>   ambari-web/app/views/main/dashboard/widgets.js 572625d 
>   ambari-web/app/views/main/dashboard/widgets/text_widget.js daa354c 
>   
> ambari-web/test/views/common/modal_popups/edit_dashboard_widget_popup_test.js 
> PRE-CREATION 
>   ambari-web/test/views/main/dashboard/widget_test.js a504c6d 
>   ambari-web/test/views/main/dashboard/widgets_test.js 5d1ddb2 
> 
> Diff: https://reviews.apache.org/r/56750/diff/
> 
> 
> Testing
> ---
> 
> 20372 passing (22s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 56750: Don't rerender all widgets when on of them is changed

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56750/
---

Review request for Ambari and Denys Buzhor.


Bugs: ambari-20043
https://issues.apache.org/jira/browse/ambari-20043


Repository: ambari


Description
---

Dashboard widgets are rerendered if some of them is changed. Actually only this 
one should be updated and not other


Diffs
-

  ambari-web/app/assets/test/tests.js d47d558 
  ambari-web/app/data/dashboard_widgets.js PRE-CREATION 
  ambari-web/app/messages.js 81833f3 
  ambari-web/app/mixins/common/track_request_mixin.js 4efcecb 
  ambari-web/app/mixins/main/dashboard/widgets/editable.js fcb6bfb 
  ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js ddf2a26 
  ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
06bcffe 
  ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs 7caf085 
  
ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs 
86ffb47 
  ambari-web/app/views.js 77b5d5a 
  ambari-web/app/views/common/modal_popups/edit_dashboard_widget_popup.js 
PRE-CREATION 
  ambari-web/app/views/main/dashboard/widget.js e7a626c 
  ambari-web/app/views/main/dashboard/widgets.js 572625d 
  ambari-web/app/views/main/dashboard/widgets/text_widget.js daa354c 
  ambari-web/test/views/common/modal_popups/edit_dashboard_widget_popup_test.js 
PRE-CREATION 
  ambari-web/test/views/main/dashboard/widget_test.js a504c6d 
  ambari-web/test/views/main/dashboard/widgets_test.js 5d1ddb2 

Diff: https://reviews.apache.org/r/56750/diff/


Testing
---

20372 passing (22s)
  153 pending


Thanks,

Oleg Nechiporenko

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/
---

(Updated Feb. 16, 2017, 1:28 p.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
Nettleton.


Changes
---

add missing end property tag


Bugs: AMBARI-20013
https://issues.apache.org/jira/browse/AMBARI-20013


Repository: ambari


Description
---

- make sure solr keytab and solr user is created on logsearch/ranger/atlas hosts
- created a new solr_cloud_util method called add roles (curl for adding user 
roles)
- updated secure znode method (adding infra-solr by default)
- move generated security.json into a static file
- added a custom security.json which can be used instead of the generated 
security.json

In ranger/atlas stack, the following calls can be used for securing znode and 
update user-roles:

solr_cloud_util.secure_znode(config=params.config, 
zookeeper_quorum=params.zookeeper_quorum,
 
solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
 jaas_file=params.logsearch_jaas_file,
 java64_home=params.java64_home, 
sasl_users=["myuser1@HOST", "myuser2"])
 
and 

solr_cloud_util.add_solr_roles(params.config,
   roles = ["ranger_audit_user"],
   new_service_principals = ["audituser1", 
"audituser2"])
   
about ranger plugins:

there is a way to use these methods in other services like storm etc. , the 
problem is its needed to infra-solr be started, so if we include these in a lot 
of other services, it can really slows down the deployment. that is the reason 
why i kept the property dependencies in infra-solr-security-json config. other 
then that, with the changes ranger can start successfully if its added later to 
the cluster, and for plugins, infra-solr will be flagged to be restarted.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 4628211 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 e193a8c 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 ab9aa61 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 8d72f42 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 ed764f0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 2232bb2 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 682fc9f 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
bc8e351 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
49d1b10 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 fecd802 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 ba91e20 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 0b4532b 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 ae49c4f 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
253e32e 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
1bbf75e 
  ambari-server/src/test/python/stacks/2.3/configs/secure.json 4501b81 
  ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
cd88fec 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py db9cbb9 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py b01e7da 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 8dda363 

Diff: https://reviews.apache.org/r/56671/diff/


Testing
---

unit tests done.


Thanks,

Oliver Szabo

Re: Review Request 56748: More than one version of jetty jars found in Ambari rpm

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56748/#review165835
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Лют. 16, 2017, 12:30 після полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56748/
> ---
> 
> (Updated Лют. 16, 2017, 12:30 після полудня)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20045
> https://issues.apache.org/jira/browse/AMBARI-20045
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Got a warning on restart of my cluster:
> 
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> WARNING: Multiple versions of jetty-util.jar found in java class path 
> (/usr/lib/ambari-server/jetty-util-6.1.26.jar and 
> /usr/lib/ambari-server/jetty-util-8.1.19.v20160209.jar).
>  Make sure that you include only one jetty-util.jar in the java class path 
> '/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/mysql-connector-java.jar'.
> Ambari database consistency check started...
> 
> Noticed there are older jetty jars packaged with the rpm:
> 
> [root@perf-a-1 ~]# rpm -ql ambari-server-2.5.0.0-914.x86_64 | grep jetty
> /usr/lib/ambari-server/jetty-6.1.26.jar
> /usr/lib/ambari-server/jetty-util-6.1.26.jar
> /usr/lib/ambari-server/jetty-util-8.1.19.v20160209.jar
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 0508556 
> 
> Diff: https://reviews.apache.org/r/56748/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 56748: More than one version of jetty jars found in Ambari rpm

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56748/
---

Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-20045
https://issues.apache.org/jira/browse/AMBARI-20045


Repository: ambari


Description
---

Got a warning on restart of my cluster:

Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
WARNING: Multiple versions of jetty-util.jar found in java class path 
(/usr/lib/ambari-server/jetty-util-6.1.26.jar and 
/usr/lib/ambari-server/jetty-util-8.1.19.v20160209.jar).
 Make sure that you include only one jetty-util.jar in the java class path 
'/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/mysql-connector-java.jar'.
Ambari database consistency check started...

Noticed there are older jetty jars packaged with the rpm:

[root@perf-a-1 ~]# rpm -ql ambari-server-2.5.0.0-914.x86_64 | grep jetty
/usr/lib/ambari-server/jetty-6.1.26.jar
/usr/lib/ambari-server/jetty-util-6.1.26.jar
/usr/lib/ambari-server/jetty-util-8.1.19.v20160209.jar


Diffs
-

  ambari-server/src/main/python/ambari_server_main.py 7a21333 

Diff: https://reviews.apache.org/r/56748/diff/


Testing
---

Manual testing


Thanks,

Dmytro Sen

Re: Review Request 56627: Cluster deployment fails if cluster template has fewer host_groups than that in blueprint

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56627/#review165833
---



Yes Robert is right, so there's no such validation because in general is not 
necessary to have all hosts from all hostgroups. For ex. let's say you have a 
'worker' hostgroup which contains only Slave or Client components and you want 
to add hosts to this hostgroup later. In this case cluster deployment is 
started.
If you check ConfigureClusterTask.getTopologyRequiredHostGroups() basically 
those are the hostgroups that are required to start configurations and these 
are typically hostgroups containing Master components. 
 So if want to validate then we should validate these host groups are in 
Cluster template. The problem is that you can retrive this from 
ClusterConfigurationRequest.getRequiredHostGroups() which is created in 
TopologyManager.provisionCluster() (line:304) so at a later point then 
validateTopology, when cluster resources are already created. So in order to 
retrieve required HostGroups we need to create a lot of things like 
Cluster/components in db/memory which we need to revert all in case of throwing 
an exception from here TopologyManager.provisionCluster() (line:304).
 Another approach would be to check required HostGroups at the end of 
TopologyManager.provisionCluster() and in case of missing required hgroups we 
can return a message about this problem, which user can correct by sending a 
scale request specifying host(s) for missing hgroups.

- Sandor Magyari


On Feb. 15, 2017, 7:30 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56627/
> ---
> 
> (Updated Feb. 15, 2017, 7:30 p.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Nettleton, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-19991
> https://issues.apache.org/jira/browse/AMBARI-19991
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster creation REST API request gets accepted when, cluster template does 
> not list all the host_groups mentioned in the blueprint. But cluster 
> deployment fails showing error message in the logs
> Caused by: java.lang.IllegalArgumentException: 
> TopologyManager.ConfigureClusterTask - prerequisites for config request 
> processing not yet satisfied
> at 
> org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:908)
> at 
> org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:889)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
>  d0a4df9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java
>  1f31d05 
> 
> Diff: https://reviews.apache.org/r/56627/diff/
> 
> 
> Testing
> ---
> 
> Tested manually, updated test cases
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 56745: Workflow Manager workflow rendering is broken in designer page

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56745/#review165831
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 16, 2017, 10:58 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56745/
> ---
> 
> (Updated Feb. 16, 2017, 10:58 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-20040
> https://issues.apache.org/jira/browse/AMBARI-20040
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Error nodes are now displayed if transition points to kill node on an 
> non-error condition.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
>  4194d5e612 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 
> 5a074dfdac 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js
>  5282544a93 
> 
> Diff: https://reviews.apache.org/r/56745/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> belliraj hb
> 
>

Re: Review Request 56746: Custom job.properties are not retained in the workflow designer

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56746/#review165829
---


Ship it!




Ship It!

- belliraj hb


On Feb. 16, 2017, 11:40 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56746/
> ---
> 
> (Updated Feb. 16, 2017, 11:40 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20041
> https://issues.apache.org/jira/browse/AMBARI-20041
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Custom job.properties are not retained in the workflow designer.
> 
> Steps to reproduce :
> 1) Submit a workflow with custom job properties say 
> oozie.action.sharelib.for.sqoop=sqoop,hive.
> 2) From the dashboard, select this workflow.
> 3) When user tries to submit it again, previously included properties are not 
> visible to the user.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
>  f93e1b8 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
> f364e30 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> fe60793 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 25a3266 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  ff92f7d 
> 
> Diff: https://reviews.apache.org/r/56746/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Review Request 56746: Custom job.properties are not retained in the workflow designer

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56746/
---

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj 
Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-20041
https://issues.apache.org/jira/browse/AMBARI-20041


Repository: ambari


Description
---

Custom job.properties are not retained in the workflow designer.

Steps to reproduce :
1) Submit a workflow with custom job properties say 
oozie.action.sharelib.for.sqoop=sqoop,hive.
2) From the dashboard, select this workflow.
3) When user tries to submit it again, previously included properties are not 
visible to the user.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
 f93e1b8 
  contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
f364e30 
  contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
fe60793 
  contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 25a3266 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 ff92f7d 

Diff: https://reviews.apache.org/r/56746/diff/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56710: Relax ranger config DB consistency check rules

[Andrew Onischuk]

> On Feb. 15, 2017, 9:05 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java,
> >  line 905
> > 
> >
> > We shouldn't be hardcoding service names or config types in a check 
> > like this.
> > If this is preventing the user from starting Ambari Server, then we 
> > should make this type of check be a warning as opposed to a hard error, or 
> > annotate a service or config-type with a tag to relax its validation in 
> > this check.
> > 
> > Please add Jayush to the code review.

This a one-case scenario. I would say, adding an xml syntax to metainfo.xml to 
Relax on given service for given config-type would be an overkill.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165756
---


On Feb. 16, 2017, 11:24 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> ---
> 
> (Updated Feb. 16, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  878d0fa 
> 
> Diff: https://reviews.apache.org/r/56710/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56710: Relax ranger config DB consistency check rules

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/
---

(Updated Feb. 16, 2017, 11:24 a.m.)


Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.


Bugs: AMBARI-20024
https://issues.apache.org/jira/browse/AMBARI-20024


Repository: ambari


Description (updated)
---

.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 878d0fa 

Diff: https://reviews.apache.org/r/56710/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 56745: Workflow Manager workflow rendering is broken in designer page

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56745/#review165827
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 16, 2017, 10:58 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56745/
> ---
> 
> (Updated Feb. 16, 2017, 10:58 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-20040
> https://issues.apache.org/jira/browse/AMBARI-20040
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Error nodes are now displayed if transition points to kill node on an 
> non-error condition.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
>  4194d5e612 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 
> 5a074dfdac 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js
>  5282544a93 
> 
> Diff: https://reviews.apache.org/r/56745/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> belliraj hb
> 
>

Review Request 56745: Workflow Manager workflow rendering is broken in designer page

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56745/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
Kulshreshtha.


Bugs: AMBARI-20040
https://issues.apache.org/jira/browse/AMBARI-20040


Repository: ambari


Description
---

Error nodes are now displayed if transition points to kill node on an non-error 
condition.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
 4194d5e612 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 
5a074dfdac 
  
contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js
 5282544a93 

Diff: https://reviews.apache.org/r/56745/diff/


Testing
---

Manual testing


Thanks,

belliraj hb

Re: Review Request 56705: Hive server error on view navigation when wire encryption is enabled

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56705/#review165817
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 15, 2017, 1:01 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56705/
> ---
> 
> (Updated Feb. 15, 2017, 1:01 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20021
> https://issues.apache.org/jira/browse/AMBARI-20021
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> in ambari views : removed exclusion of httpcore and httpclient libraries and 
> added in dependencyManagement to version 4.4
> 
> 
> Diffs
> -
> 
>   contrib/views/commons/pom.xml 9dd18ac 
>   contrib/views/files/pom.xml 2e742df 
>   contrib/views/hive-next/pom.xml 19f55ee 
>   contrib/views/hive20/pom.xml cf5fdde 
>   contrib/views/pig/pom.xml 738d410 
>   contrib/views/pom.xml c8a88cb 
>   contrib/views/utils/pom.xml ead33b2 
>   contrib/views/wfmanager/pom.xml 06fbfeb 
> 
> Diff: https://reviews.apache.org/r/56705/diff/
> 
> 
> Testing
> ---
> 
> manual testing done on cluster with hdfs and s3 support
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 56705: Hive server error on view navigation when wire encryption is enabled

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56705/#review165816
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 15, 2017, 1:01 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56705/
> ---
> 
> (Updated Feb. 15, 2017, 1:01 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20021
> https://issues.apache.org/jira/browse/AMBARI-20021
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> in ambari views : removed exclusion of httpcore and httpclient libraries and 
> added in dependencyManagement to version 4.4
> 
> 
> Diffs
> -
> 
>   contrib/views/commons/pom.xml 9dd18ac 
>   contrib/views/files/pom.xml 2e742df 
>   contrib/views/hive-next/pom.xml 19f55ee 
>   contrib/views/hive20/pom.xml cf5fdde 
>   contrib/views/pig/pom.xml 738d410 
>   contrib/views/pom.xml c8a88cb 
>   contrib/views/utils/pom.xml ead33b2 
>   contrib/views/wfmanager/pom.xml 06fbfeb 
> 
> Diff: https://reviews.apache.org/r/56705/diff/
> 
> 
> Testing
> ---
> 
> manual testing done on cluster with hdfs and s3 support
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>