date:20170406

Re: Review Request 58257: Side Nav: improve views dropdown menu

2017-04-06 Thread Richard Zang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58257/#review171312
---


Ship it!




Ship It!

- Richard Zang


On April 7, 2017, 2:36 a.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58257/
> ---
> 
> (Updated April 7, 2017, 2:36 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20699
> https://issues.apache.org/jira/browse/AMBARI-20699
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Improve the current views menu on Side Nav.
> 
> Now: views menu is in dark background, and not intuitive to open/click on.
> 
> ToDo: Make it clickable and light background.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/theme/bootstrap-ambari.css b063fcfa34 
> 
> 
> Diff: https://reviews.apache.org/r/58257/diff/1/
> 
> 
> Testing
> ---
> 
> 20606 passing (25s)
>   128 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Review Request 58257: Side Nav: improve views dropdown menu

2017-04-06 Thread Xi Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58257/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, and Yusaku Sako.


Bugs: AMBARI-20699
https://issues.apache.org/jira/browse/AMBARI-20699


Repository: ambari


Description
---

Improve the current views menu on Side Nav.

Now: views menu is in dark background, and not intuitive to open/click on.

ToDo: Make it clickable and light background.


Diffs
-

  ambari-web/app/styles/theme/bootstrap-ambari.css b063fcfa34 


Diff: https://reviews.apache.org/r/58257/diff/1/


Testing
---

20606 passing (25s)
  128 pending


Thanks,

Xi Wang

Review Request 58256: Support creating/editing alert dispatch targets for script-based alert dispatchers by web wizard instead of command line

2017-04-06 Thread yao lei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58256/
---

Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, Andrii 
Tkach, Di Li, Jaimin Jetly, Zhe (Joe) Wang, Matt, Nate Cole, Richard Zang, and 
Yusaku Sako.


Bugs: AMBARI-18423
https://issues.apache.org/jira/browse/AMBARI-18423


Repository: ambari


Description
---

Ambari now support creating/editing three kinds of alert dispatch targets by 
web wizard, including EMAIL,SNMP,Custom SNMP.
If we want to create another kind of alert dispatch target ALERT_SCRIPT for 
script-based alert dispatcher,we have to execute a command manually like 
following:
{code}
POST api/v1/alert_targets

{
  "AlertTarget": {
"name": "syslogger",
"description": "Syslog Target",
"notification_type": "ALERT_SCRIPT",
"global": true
  }
}
{code}
or
{code}
POST api/v1/alert_targets

{
  "AlertTarget": {
"name": "syslogger",
"description": "Syslog Target",
"notification_type": "ALERT_SCRIPT",
"global": false,
"groups":[1,3]
"alert_states":["WARNING","CRITICAL","UNKNOWN"],
"properties": {
  "ambari.dispatch-property.script": 
"com.mycompany.dispatch.syslog.script"
}
  }
}
{code}
More details, please see 
https://cwiki.apache.org/confluence/display/AMBARI/Creating+a+Script-based+Alert+Dispatcher+-+2.4.0
We should do this by web wizard rather than command line, which will lead to 
more convenience
We think it is really helpeful for us when using script-based alert dispatcher.


Diffs
-

  
ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js 
73c19c6 
  ambari-web/app/messages.js a2edf06 
  ambari-web/app/templates/main/alerts/create_alert_notification.hbs 5b40bca 
  
ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
 31da561 


Diff: https://reviews.apache.org/r/58256/diff/1/


Testing
---

mvn test
20676 passing (34s)
128 pending


Thanks,

yao lei

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

2017-04-06 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review171285
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
Line 97 (original), 97 (patched)


Let's keep the property then, but mark it as deleted.
true


Also, perform the same change for Hive 3.0.0 in common-services


- Alejandro Fernandez


On March 16, 2017, 12:55 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> ---
> 
> (Updated March 16, 2017, 12:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-20443
> https://issues.apache.org/jira/browse/AMBARI-20443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Advanced hive-env, there is a parameter named hive_ambari_database. Though 
> I change the parameter, it looks like nothing has changed. I greped the 
> entire ambari source code, the parameter is not referenced.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  be79331 
> 
> 
> Diff: https://reviews.apache.org/r/57687/diff/1/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-06 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171283
---



Pushed to trunk

- Alejandro Fernandez


On April 5, 2017, 11:45 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 5, 2017, 11:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/4/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-06 Thread Amruta Borkar



> On April 6, 2017, 11:13 p.m., Alejandro Fernandez wrote:
> > Ship It!

Thank you Alejandro,

Could you please help me push this to trunk?


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171274
---


On April 5, 2017, 11:45 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 5, 2017, 11:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/4/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

2017-04-06 Thread Alejandro Fernandez



> On April 6, 2017, 11:06 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
> > Lines 306 (patched)
> > 
> >
> > From my experience, I've seen several cases where deleting records from 
> > the execution command, HRC, stage, request, etc. table also requires 
> > deleting records from the toplogy* tables.
> > 
> > Otherwise, Ambari still thinks that the cluster is still being deployed 
> > via blueprints and causes a lot of problems with configs.
> > 
> > Have you tested this in actual clusters deployed via BP and that have 
> > undergone EU/RU?
> 
> Vitalyi Brodetskyi wrote:
> Nope, i tested it on cluster deployed with UI. Please take a look at new 
> patch exactly on RequestDAO.cleanup() method. I've added there comments with 
> clarification. As we discussed earlier we don't want to touch Upgrade, so i'm 
> excluding stages and requests that i found in Upgrade tables. I tested it and 
> looks like it works fine (populated Upgrade tables manually). But i'm not 
> sure how will work cluster with BP, we really removing some rows from BP 
> tables, need to check.

I'm ok with not deleting from the upgrade table, but we have to be very careful 
since that has a FK request_id. In my opinion, we definitely need to be able to 
delete requests that used to belong to an upgrade.
For large clusters, those request, stage, HRC records are going to easily be 
100k rows.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/#review171264
---


On April 6, 2017, 11:26 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58228/
> ---
> 
> (Updated April 6, 2017, 11:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20687
> https://issues.apache.org/jira/browse/AMBARI-20687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add check for large tables into db consistency check.
> Add code to cleanup these tables into db-cleanup code.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  e7e9433 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> c132a3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 1dd3b54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  79b8bc9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 2696f66 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
> c2919b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExecutionCommandEntity.java
>  85f3a25 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  a809295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
>  f19aa72 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
>  ff14e3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java
>  8ee41d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RoleSuccessCriteriaEntity.java
>  3386c24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  d035729 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java
>  b90e192 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  c71d4e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  89574bc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java
>  560970a 
>   ambari-server/src/main/python/ambari-server.py 87cc6c2 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py abc8267 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  7d8ba50 
> 
> 
> Diff: https://reviews.apache.org/r/58228/diff/4/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

2017-04-06 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/
---

(Updated Квітень 6, 2017, 11:26 після полудня)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
Papirkovskyy, and Sid Wagle.


Bugs: AMBARI-20687
https://issues.apache.org/jira/browse/AMBARI-20687


Repository: ambari


Description
---

Add check for large tables into db consistency check.
Add code to cleanup these tables into db-cleanup code.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 e7e9433 
  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
c132a3d 
  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
1dd3b54 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
 79b8bc9 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
2696f66 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
c2919b2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExecutionCommandEntity.java
 85f3a25 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
 a809295 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
 f19aa72 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
 ff14e3a 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java
 8ee41d2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RoleSuccessCriteriaEntity.java
 3386c24 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
 d035729 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java
 b90e192 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
 c71d4e4 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
 89574bc 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java
 560970a 
  ambari-server/src/main/python/ambari-server.py 87cc6c2 
  ambari-server/src/main/python/ambari_server/dbCleanup.py abc8267 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 7d8ba50 


Diff: https://reviews.apache.org/r/58228/diff/4/

Changes: https://reviews.apache.org/r/58228/diff/3-4/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

2017-04-06 Thread Vitalyi Brodetskyi



> On Квітень 6, 2017, 11:06 після полудня, Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
> > Lines 306 (patched)
> > 
> >
> > From my experience, I've seen several cases where deleting records from 
> > the execution command, HRC, stage, request, etc. table also requires 
> > deleting records from the toplogy* tables.
> > 
> > Otherwise, Ambari still thinks that the cluster is still being deployed 
> > via blueprints and causes a lot of problems with configs.
> > 
> > Have you tested this in actual clusters deployed via BP and that have 
> > undergone EU/RU?

Nope, i tested it on cluster deployed with UI. Please take a look at new patch 
exactly on RequestDAO.cleanup() method. I've added there comments with 
clarification. As we discussed earlier we don't want to touch Upgrade, so i'm 
excluding stages and requests that i found in Upgrade tables. I tested it and 
looks like it works fine (populated Upgrade tables manually). But i'm not sure 
how will work cluster with BP, we really removing some rows from BP tables, 
need to check.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/#review171264
---


On Квітень 6, 2017, 11:05 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58228/
> ---
> 
> (Updated Квітень 6, 2017, 11:05 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20687
> https://issues.apache.org/jira/browse/AMBARI-20687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add check for large tables into db consistency check.
> Add code to cleanup these tables into db-cleanup code.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  e7e9433 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> c132a3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 1dd3b54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  79b8bc9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 2696f66 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
> c2919b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExecutionCommandEntity.java
>  85f3a25 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  a809295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
>  f19aa72 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
>  ff14e3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java
>  8ee41d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RoleSuccessCriteriaEntity.java
>  3386c24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  d035729 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java
>  b90e192 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  c71d4e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  89574bc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java
>  560970a 
>   ambari-server/src/main/python/ambari-server.py 87cc6c2 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py abc8267 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  7d8ba50 
> 
> 
> Diff: https://reviews.apache.org/r/58228/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-06 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171274
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 5, 2017, 11:45 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 5, 2017, 11:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/4/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58240: 'ambari-server upgrade' command does not change owner for all dirs

2017-04-06 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58240/#review171273
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 6, 2017, 6:10 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58240/
> ---
> 
> (Updated April 6, 2017, 6:10 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20695
> https://issues.apache.org/jira/browse/AMBARI-20695
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update owner for /var/lib/ambari-server/resources/dashboards, 
> /var/lib/ambari-server/resources//extensions, 
> /var/lib/ambari-server/resources//mpacks during upgrade.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 66b07a4 
> 
> 
> Diff: https://reviews.apache.org/r/58240/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

2017-04-06 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/#review171264
---




ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
Lines 259 (patched)


Technically, we should call this endRow since it's allowed to be the size 
of the collection.



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
Lines 273 (patched)


Java doc



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
Lines 306 (patched)


From my experience, I've seen several cases where deleting records from the 
execution command, HRC, stage, request, etc. table also requires deleting 
records from the toplogy* tables.

Otherwise, Ambari still thinks that the cluster is still being deployed via 
blueprints and causes a lot of problems with configs.

Have you tested this in actual clusters deployed via BP and that have 
undergone EU/RU?


- Alejandro Fernandez


On April 6, 2017, 11:05 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58228/
> ---
> 
> (Updated April 6, 2017, 11:05 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20687
> https://issues.apache.org/jira/browse/AMBARI-20687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add check for large tables into db consistency check.
> Add code to cleanup these tables into db-cleanup code.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  e7e9433 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> c132a3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 1dd3b54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  79b8bc9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 2696f66 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
> c2919b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExecutionCommandEntity.java
>  85f3a25 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  a809295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
>  f19aa72 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
>  ff14e3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java
>  8ee41d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RoleSuccessCriteriaEntity.java
>  3386c24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  d035729 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java
>  b90e192 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  c71d4e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  89574bc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java
>  560970a 
>   ambari-server/src/main/python/ambari-server.py 87cc6c2 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py abc8267 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  7d8ba50 
> 
> 
> Diff: https://reviews.apache.org/r/58228/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

2017-04-06 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/
---

(Updated Квітень 6, 2017, 11:05 після полудня)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
Papirkovskyy, and Sid Wagle.


Bugs: AMBARI-20687
https://issues.apache.org/jira/browse/AMBARI-20687


Repository: ambari


Description
---

Add check for large tables into db consistency check.
Add code to cleanup these tables into db-cleanup code.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 e7e9433 
  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
c132a3d 
  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
1dd3b54 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
 79b8bc9 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
2696f66 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
c2919b2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExecutionCommandEntity.java
 85f3a25 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
 a809295 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
 f19aa72 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
 ff14e3a 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java
 8ee41d2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RoleSuccessCriteriaEntity.java
 3386c24 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
 d035729 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java
 b90e192 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
 c71d4e4 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
 89574bc 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java
 560970a 
  ambari-server/src/main/python/ambari-server.py 87cc6c2 
  ambari-server/src/main/python/ambari_server/dbCleanup.py abc8267 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 7d8ba50 


Diff: https://reviews.apache.org/r/58228/diff/3/

Changes: https://reviews.apache.org/r/58228/diff/2-3/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 58244: Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin

2017-04-06 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58244/#review171258
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 6, 2017, 8:51 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58244/
> ---
> 
> (Updated April 6, 2017, 8:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Jayush Luniya.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 67532c5 
> 
> 
> Diff: https://reviews.apache.org/r/58244/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 58244: Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin

2017-04-06 Thread Bharat Viswanadham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58244/
---

(Updated April 6, 2017, 8:51 p.m.)


Review request for Ambari, Alejandro Fernandez, Di Li, and Jayush Luniya.


Repository: ambari


Description
---

Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
67532c5 


Diff: https://reviews.apache.org/r/58244/diff/2/

Changes: https://reviews.apache.org/r/58244/diff/1-2/


Testing
---


Thanks,

Bharat Viswanadham

Review Request 58244: Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin

2017-04-06 Thread Bharat Viswanadham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58244/
---

Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Repository: ambari


Description
---

Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
67532c5 


Diff: https://reviews.apache.org/r/58244/diff/1/


Testing
---


Thanks,

Bharat Viswanadham

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

2017-04-06 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/#review171242
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
Lines 948 (patched)


Lets rename as InternalStageTask



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
Lines 250 (patched)


minor nit: lowercase ids.


- Sid Wagle


On April 6, 2017, 7:10 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58228/
> ---
> 
> (Updated April 6, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20687
> https://issues.apache.org/jira/browse/AMBARI-20687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add check for large tables into db consistency check.
> Add code to cleanup these tables into db-cleanup code.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  e7e9433 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> c132a3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 1dd3b54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExecutionCommandDAO.java
>  7a3bc01 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  79b8bc9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 2696f66 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
> c2919b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExecutionCommandEntity.java
>  85f3a25 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  a809295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
>  f19aa72 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
>  ff14e3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java
>  8ee41d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RoleSuccessCriteriaEntity.java
>  3386c24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  49c1594 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java
>  b90e192 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  c71d4e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  7421ca1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java
>  560970a 
>   ambari-server/src/main/python/ambari-server.py 87cc6c2 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py abc8267 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  7d8ba50 
> 
> 
> Diff: https://reviews.apache.org/r/58228/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

2017-04-06 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/#review171240
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 234 (patched)


Documentation.



ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 257-269 (patched)


We support other DB types.



ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 277-278 (patched)


I would change this message so that it's just warning. There's no proof 
that removing data will actually speed it up :)

"The database table {} is currently %f MB and may impact performance. It is 
recommended that you reduce its size by executing \"ambari-server db-cleanup\"."



ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 283 (patched)


Use {} notation.



ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 293-294 (patched)


"The database table {} currently has {} rows and may impact performance. It 
is recommended that you reduce its size by executing \"ambari-server 
db-cleanup\"."



ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 296 (patched)


"The database table {} currently has {} rows and is within normal limits".



ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java
Lines 641 (patched)


Documentation.



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
Lines 948-975 (patched)


Documentation. Also this is a generic name. Can we do something better, 
like HostRoleCommandIds?



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
Lines 233-239 (patched)


Documentation.



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
Lines 241-247 (patched)


Documentation.



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
Lines 249-269 (patched)


Documentation.



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
Lines 250-251 (patched)


Don't capitalize Ids



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
Lines 252 (patched)


Why String.format? Why not just use the {} convention?



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
Lines 261-262 (patched)


Use {} notation



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java
Lines 371-379 (patched)


Documentation.


- Jonathan Hurley


On April 6, 2017, 3:10 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58228/
> ---
> 
> (Updated April 6, 2017, 3:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20687
> https://issues.apache.org/jira/browse/AMBARI-20687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add check for large tables into db consistency check.
> Add code to cleanup these tables into db-cleanup code.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  e7e9433 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> c132a3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 1dd3b54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExecutionCommandDAO.java
>  7a3bc01 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  79b8bc9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 2696f66 
>

Review Request 58240: 'ambari-server upgrade' command does not change owner for all dirs

2017-04-06 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58240/
---

Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-20695
https://issues.apache.org/jira/browse/AMBARI-20695


Repository: ambari


Description
---

Update owner for /var/lib/ambari-server/resources/dashboards, 
/var/lib/ambari-server/resources//extensions, 
/var/lib/ambari-server/resources//mpacks during upgrade.


Diffs
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 66b07a4 


Diff: https://reviews.apache.org/r/58240/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-06 Thread Amruta Borkar



> On April 5, 2017, 5:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> > Lines 525 (patched)
> > 
> >
> > Missing spaces after the periods

Thanks Alejandro,
Could you please help me ppush this to trunk?


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171149
---


On April 5, 2017, 11:45 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 5, 2017, 11:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/4/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Review Request 58237: Add Stomp client adapter

2017-04-06 Thread Andrii Tkach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58237/
---

Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-20694
https://issues.apache.org/jira/browse/AMBARI-20694


Repository: ambari


Description
---

Implement Stomp client that will handle communication with the server via 
WebSocket (or SockJS).


Diffs
-

  ambari-web/app/app.js 9c7d874 
  ambari-web/app/assets/test/tests.js ef8d0bc 
  ambari-web/app/utils/stomp_client.js PRE-CREATION 
  ambari-web/brunch-config.js 31eb1cb 
  ambari-web/test/utils/stomp_client_test.js PRE-CREATION 
  ambari-web/vendor/scripts/sockjs.min.js PRE-CREATION 
  ambari-web/vendor/scripts/stomp.min.js PRE-CREATION 


Diff: https://reviews.apache.org/r/58237/diff/1/


Testing
---

20690 passing (36s)
  128 pending


Thanks,

Andrii Tkach

Re: Review Request 58232: Hive view holds the operational logs open and also fills /tmp

2017-04-06 Thread DIPAYAN BHOWMICK


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58232/#review171204
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On April 6, 2017, 1:02 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58232/
> ---
> 
> (Updated April 6, 2017, 1:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20690
> https://issues.apache.org/jira/browse/AMBARI-20690
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> sync connections were not getting closed after 10 mins window of inactivity. 
> removed the incorrect call to stop scheduler
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/HiveActor.java
>  36bc430b7f 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java
>  997c28aab3 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/OperationController.java
>  98e60f2610 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/HiveActor.java
>  384b7982bd 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java
>  f93ecbffb3 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/OperationController.java
>  f751d8f54b 
> 
> 
> Diff: https://reviews.apache.org/r/58232/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 58232: Hive view holds the operational logs open and also fills /tmp

2017-04-06 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58232/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20690
https://issues.apache.org/jira/browse/AMBARI-20690


Repository: ambari


Description
---

sync connections were not getting closed after 10 mins window of inactivity. 
removed the incorrect call to stop scheduler


Diffs
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/HiveActor.java
 36bc430b7f 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java
 997c28aab3 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/OperationController.java
 98e60f2610 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/HiveActor.java
 384b7982bd 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java
 f93ecbffb3 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/OperationController.java
 f751d8f54b 


Diff: https://reviews.apache.org/r/58232/diff/1/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-06 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171200
---


Ship it!




Ship It!

- Di Li


On April 5, 2017, 11:45 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 5, 2017, 11:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/4/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58210: Implement a websocket adapter for stomp.py

2017-04-06 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58210/
---

(Updated April 6, 2017, 9:30 a.m.)


Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-20684
https://issues.apache.org/jira/browse/AMBARI-20684


Repository: ambari


Description
---

This is needed for stomp to work via websocket instead of tcp


Diffs (updated)
-

  LICENSE.txt f05016f 
  NOTICE.txt 50f982c 
  ambari-agent/conf/unix/install-helper.sh 35aec15 
  ambari-agent/pom.xml 4807a35 
  ambari-agent/src/main/python/ambari_agent/client_example.py PRE-CREATION 
  ambari-agent/src/packages/tarball/all.xml a22f0bb 
  ambari-common/src/main/python/ambari_stomp/adapter/websocket.py PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/__init__.py PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/client/__init__.py PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/client/geventclient.py 
PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/client/threadedclient.py 
PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/client/tornadoclient.py 
PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/compat.py PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/exc.py PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/framing.py PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/manager.py PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/messaging.py PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/streaming.py PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/utf8validator.py PRE-CREATION 
  ambari-common/src/main/python/ambari_ws4py/websocket.py PRE-CREATION 
  ambari-project/pom.xml 98da9f4 
  ambari-server/pom.xml 8b4c8d6 
  pom.xml f192895 


Diff: https://reviews.apache.org/r/58210/diff/2/

Changes: https://reviews.apache.org/r/58210/diff/1-2/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 58218: Upgrade Progress Dialog Executes Query Which Causes StackOverflow in JPA

2017-04-06 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58218/#review171192
---


Ship it!




Ship It!

- Robert Levas


On April 5, 2017, 7:20 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58218/
> ---
> 
> (Updated April 5, 2017, 7:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Robert Levas, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-20685
> https://issues.apache.org/jira/browse/AMBARI-20685
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Large rolling upgrades (1000 hosts with 10,000 host components) creates a 
> massive request object object with 10's of 1000's of stages and tasks. The 
> web client executes a {{GET}} command against the API to retrieve upgrade 
> groups/items. On a large upgrade, this causes the EclipseLink SQL generation 
> code to run out of stack frame space while recursively building a query. To 
> work around this, the stack frame size per thread can be increased using 
> {{-Xss}} along with a value like 32M.
> 
> {code}
> http://localhost:8080/api/v1/clusters/c1/upgrades/12?
> upgrade_groups/UpgradeGroup/status!=PENDING&
> fields=
>   Upgrade/progress_percent,
>   Upgrade/request_context,
>   Upgrade/request_status,
>   Upgrade/direction,
>   Upgrade/downgrade_allowed,
>   upgrade_groups/UpgradeGroup,
>   Upgrade/*,
>   upgrade_groups/upgrade_items/UpgradeItem/status,
>   minimal_response=true&_=1489680258782
> {code}
> 
> This call gets turn into a LOT of queries, but some seem to be based on the 
> number of stages. For example, this one on a very small upgrade produces very 
> poor SQL...
> 
> {code}
> SELECT
>   stage_id,
>   cluster_host_info,
>   cluster_id,
>   command_execution_type,
>   command_params,
>   display_status,
>   host_params,
>   log_info,
>   request_context,
>   request_id,
>   skippable,
>   status,
>   supports_auto_skip_failure
> FROM stage
> WHERE ((request_id = ?)
> AND stage_id = ?)
> OR (stage_id = ?))
> OR (stage_id = ?))
> OR (stage_id = ?))
> OR (stage_id = ?))
> OR (stage_id = ?))
> OR (stage_id = ?))
> OR (stage_id = ?)))
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
>  8759844 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java
>  bf0fa33 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  49c1594 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java
>  34d175c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> eee913a 
> 
> 
> Diff: https://reviews.apache.org/r/58218/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 17:46 min
> [INFO] Finished at: 2017-04-05T17:30:09-04:00
> [INFO] Final Memory: 67M/861M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 58230: Zooming workflows should happen more smoothly

2017-04-06 Thread Madhan Reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58230/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav 
Kulshreshtha.


Bugs: AMBARI-20689
https://issues.apache.org/jira/browse/AMBARI-20689


Repository: ambari


Description
---

Changed the zoom factor of the workflow.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
 03f0ae1 


Diff: https://reviews.apache.org/r/58230/diff/1/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

2017-04-06 Thread Masahiro Tanaka



> On 3月 17, 2017, 5:21 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> > Line 97 (original), 97 (patched)
> > 
> >
> > Does this config need to be deleted from existing clusters? Which stack 
> > versions does this affect?
> > 
> > If so, you can mark the property as , which will also cause 
> > Ambari to delete it during EU/RU
> 
> Masahiro Tanaka wrote:
> Sorry for late reply, and thank you for your reviewing.
> I'll check if existing clusters do not need this property.

I checked the Ambari source code, and found out that ambari 1.2.3 used 
`hive_ambari_database` in puppet manifest.
But it was disappered from ambari 1.2.4 (maybe in 
[AMBARI-2144](https://issues.apache.org/jira/browse/AMBARI-2144))


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review169205
---


On 3月 16, 2017, 9:55 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> ---
> 
> (Updated 3月 16, 2017, 9:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-20443
> https://issues.apache.org/jira/browse/AMBARI-20443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Advanced hive-env, there is a parameter named hive_ambari_database. Though 
> I change the parameter, it looks like nothing has changed. I greped the 
> entire ambari source code, the parameter is not referenced.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  be79331 
> 
> 
> Diff: https://reviews.apache.org/r/57687/diff/1/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 58257: Side Nav: improve views dropdown menu

Review Request 58257: Side Nav: improve views dropdown menu

Review Request 58256: Support creating/editing alert dispatch targets for script-based alert dispatchers by web wizard instead of command line

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

Re: Review Request 58240: 'ambari-server upgrade' command does not change owner for all dirs

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

Re: Review Request 58244: Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin

Re: Review Request 58244: Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin

Review Request 58244: Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

Review Request 58240: 'ambari-server upgrade' command does not change owner for all dirs

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

Review Request 58237: Add Stomp client adapter

Re: Review Request 58232: Hive view holds the operational logs open and also fills /tmp

Review Request 58232: Hive view holds the operational logs open and also fills /tmp

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

Re: Review Request 58210: Implement a websocket adapter for stomp.py

Re: Review Request 58218: Upgrade Progress Dialog Executes Query Which Causes StackOverflow in JPA

Review Request 58230: Zooming workflows should happen more smoothly

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

28 matches

Site Navigation

Mail list logo

Footer information