Re: Review Request 61500: Service Checks Will Run Multiple Times In Patch/Service Upgrades

2017-08-08 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61500/#review182462
---


Ship it!




I just had a quick question about the first check encountered being a service 
check. I see you added a test case for this, so I guess I'm just not seeing how 
it's covered here.


ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
Lines 501-503 (original), 509-527 (patched)


So, how does this guard against the first X services being skipped and the 
first group encountered is a ServiceCheck. Wouldn't `previousGroupHolder` be 
null in this case, so it would always add it?


- Jonathan Hurley


On Aug. 8, 2017, 12:03 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61500/
> ---
> 
> (Updated Aug. 8, 2017, 12:03 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21679
> https://issues.apache.org/jira/browse/AMBARI-21679
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are two issues with Service Checks and patches:
> 
> 1. A service check grouping can be orchestrated one right after the other if 
> the grouping in between them has no processing.
> 2. A service check grouping can be orchestrated before any components have 
> been scheduled.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 07012961af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  3deb7c866e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  fed5b77942 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
>  6a085f331f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  24a3fa2ce2 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml
>  f82b0258de 
> 
> 
> Diff: https://reviews.apache.org/r/61500/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 4481, Failures: 0, Errors: 0, Skipped: 31
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:58.183s
> [INFO] Finished at: Tue Aug 08 11:36:30 EDT 2017
> [INFO] Final Memory: 57M/637M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 61510: AMBARI-21686 : Implement a test driver that provides a set of metric series with different kinds of metric behavior

2017-08-08 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61510/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-21686
https://issues.apache.org/jira/browse/AMBARI-21686


Repository: ambari


Description
---

The generator is designed to generate the following series types.

 Uniform distributed series with some outliers.
 Normally distributed series with some outliers.
 Gradually increasing / decreasing series. (Monotonic Series)
 Step Function Series
 Series with a low value period and high value period (Not periodic)
 Steady series with a small period of turbulence and then back to steady.


Diffs
-

  ambari-metrics/ambari-metrics-alertservice/pom.xml 4afc80f 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/R/AmsRTest.java
 2bbc250 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/R/RFunctionInvoker.java
 2713b71 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/DataSet.java
 a709c73 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/MethodResult.java
 6bf58df 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/MetricAnomaly.java
 4dbb425 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/ResultSet.java
 9415c1b 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/SingleValuedTimelineMetric.java
 acd4452 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/StatisticUtils.java
 81bd77b 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/TimelineMetric.java
 88ad834 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/TimelineMetrics.java
 7df6a9c 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/methods/MetricAnomalyModel.java
 af33d26 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/methods/ema/EmaDS.java
 32cd96b 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/methods/ema/EmaModel.java
 13a0f55 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/methods/ema/EmaModelLoader.java
 0205844 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/methods/ema/EmaResult.java
 2d24a9c 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/methods/ema/TestEmaModel.java
 b851dab 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/AmbariServerInterface.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/MetricAnomalyDetectorTestInput.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/MetricAnomalyTester.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/MetricKafkaProducer.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/MetricSparkConsumer.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/MetricsCollectorInterface.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/PointInTimeADSystem.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/RFunctionInvoker.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/TestSeriesInputRequest.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/TrendADSystem.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/TrendMetric.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/common/DataSeries.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/common/ResultSet.java
 PRE-CREATION

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-08-08 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61024/#review182428
---




ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
Lines 165 (patched)


What are the performance implications?

Is this invoked on every call?



ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
Lines 184 (patched)


Why is this issuing an HTTP call instead of calling the method directly to 
make it more efficient?


- Alejandro Fernandez


On Aug. 8, 2017, 5:57 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61024/
> ---
> 
> (Updated Aug. 8, 2017, 5:57 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21545
> https://issues.apache.org/jira/browse/AMBARI-21545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ldap configuration can be included in recommendation requests and validation 
> requests. Configuration is passed down to stack advisor in services.json
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
>  d6714f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
>  0632361 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
>  7ba1b18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  356754d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
>  eaa4716 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java
>  6df8b8b 
> 
> 
> Diff: https://reviews.apache.org/r/61024/diff/3/
> 
> 
> Testing
> ---
> 
> - Tested the rest interface manually
> - Wrote new unit tests
> - Ambari-server unit tests: PENDING
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 61500: Service Checks Will Run Multiple Times In Patch/Service Upgrades

2017-08-08 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61500/#review182425
---


Ship it!




Ship It!

- Alejandro Fernandez


On Aug. 8, 2017, 4:03 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61500/
> ---
> 
> (Updated Aug. 8, 2017, 4:03 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21679
> https://issues.apache.org/jira/browse/AMBARI-21679
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are two issues with Service Checks and patches:
> 
> 1. A service check grouping can be orchestrated one right after the other if 
> the grouping in between them has no processing.
> 2. A service check grouping can be orchestrated before any components have 
> been scheduled.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 07012961af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  3deb7c866e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  fed5b77942 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
>  6a085f331f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  24a3fa2ce2 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml
>  f82b0258de 
> 
> 
> Diff: https://reviews.apache.org/r/61500/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 4481, Failures: 0, Errors: 0, Skipped: 31
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:58.183s
> [INFO] Finished at: Tue Aug 08 11:36:30 EDT 2017
> [INFO] Final Memory: 57M/637M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-08-08 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61024/
---

(Updated Aug. 8, 2017, 5:57 p.m.)


Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and 
Sebastian Toader.


Changes
---

Added one more unit test.


Bugs: AMBARI-21545
https://issues.apache.org/jira/browse/AMBARI-21545


Repository: ambari


Description
---

Ldap configuration can be included in recommendation requests and validation 
requests. Configuration is passed down to stack advisor in services.json


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
 d6714f9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
 0632361 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
 7ba1b18 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 356754d 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
 eaa4716 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java
 6df8b8b 


Diff: https://reviews.apache.org/r/61024/diff/3/

Changes: https://reviews.apache.org/r/61024/diff/2-3/


Testing
---

- Tested the rest interface manually
- Wrote new unit tests
- Ambari-server unit tests: PENDING


Thanks,

Balázs Bence Sári

Re: Review Request 61176: Apply zeppelin.server.kerberos.principal related changes to 0.6.0.3.0

2017-08-08 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61176/#review182411
---


Ship it!




Ship It!

- Gaurav Nagar


On July 27, 2017, 9:09 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61176/
> ---
> 
> (Updated July 27, 2017, 9:09 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21586
> https://issues.apache.org/jira/browse/AMBARI-21586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With AMBARI-18692, and AMBARI-21426 there were few changes in zeppelin-env.sh 
> that was applied to 0.6.0.2.5 but the same was not applied to 0.6.0.3.0. This 
> is to sync zeppelin-env.xml.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-env.xml
>  7bd597f6a6 
> 
> 
> Diff: https://reviews.apache.org/r/61176/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 7
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 61479: Add Secure Flag to Cookie / JSESSIONID in Zeppelin

2017-08-08 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61479/#review182410
---


Ship it!




Ship It!

- venkat sairam


On Aug. 7, 2017, 8:07 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61479/
> ---
> 
> (Updated Aug. 7, 2017, 8:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21675
> https://issues.apache.org/jira/browse/AMBARI-21675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The secure flag attribute must be set on session cookies containing session 
> tokens for Zeppelin Application
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>  971e4af1c6 
> 
> 
> Diff: https://reviews.apache.org/r/61479/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Review Request 61503: Service and Patch Upgrade Catalog Changes for 2.6.0

2017-08-08 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61503/
---

Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-21169
https://issues.apache.org/jira/browse/AMBARI-21169


Repository: ambari


Description
---

Implement the following upgrade catalog changes related to service/patch 
upgrades:

h5. {{servicecomponentdesiredstate}}
- Remove:  desired_stack_id BIGINT NOT NULL
- Remove: desired_version VARCHAR(255) NOT NULL DEFAULT 'UNKNOWN'
- Remove: FK on desired_stack_id (FK_scds_desired_stack_id)
- Add: desired_repo_version_id BIGINT NOT NULL
- Add: FK to repo_version_id (FK_scds_desired_repo_id)

h5. {{hostcomponentdesiredstate}}
- Remove: desired_stack_id BIGINT NOT NULL
- Remove: FK on desired_stack_id (FK_hcds_desired_stack_id)

h5. {{hostcomponentstate}}
- Remove: current_stack_id BIGINT NOT NULL
- Remove: FK on desired_stack_id (FK_hcs_current_stack_id)

h5. {{servicedesiredstate}}
- Remove: desired_stack_id BIGINT NOT NULL
- Add: desired_repo_version_id BIGINT NOT NULL
- Add: FK  to repo_version_id (FK_repo_version_id)

h5. {{host_version}}
- Change the {{UNIQUE}} constraint to allow for multiple {{CURRENT}} 
repositories per host. Restriction should also include the {{repo_version_id}} 
for uniqueness now.

h5. {{cluster_version}}
- This table was removed.

h5. {{servicecomponent_version}}
- Create this table and populate with data

h5. {{upgrade}}
- Add orchestration VARCHAR(255) NOT NULL DEFAULT 'STANDARD'


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
03136984ba 
  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
38d60e9a4a 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DbmsHelper.java
 00b02f1033 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/GenericDbmsHelper.java
 11cbcf922b 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/H2Helper.java
 100c8659ef 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/MySqlHelper.java
 ad26520e4a 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/OracleHelper.java
 73356d16e3 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/PostgresHelper.java
 46d7315d91 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
 35e5b1030f 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61503/diff/1/


Testing
---

running tests on live cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 61500: Service Checks Will Run Multiple Times In Patch/Service Upgrades

2017-08-08 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61500/
---

(Updated Aug. 8, 2017, 12:03 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-21679
https://issues.apache.org/jira/browse/AMBARI-21679


Repository: ambari


Description
---

There are two issues with Service Checks and patches:

1. A service check grouping can be orchestrated one right after the other if 
the grouping in between them has no processing.
2. A service check grouping can be orchestrated before any components have been 
scheduled.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
07012961af 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 3deb7c866e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 fed5b77942 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
 6a085f331f 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 24a3fa2ce2 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml
 f82b0258de 


Diff: https://reviews.apache.org/r/61500/diff/1/


Testing (updated)
---

Manual.  Automated:

Tests run: 4481, Failures: 0, Errors: 0, Skipped: 31

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 21:58.183s
[INFO] Finished at: Tue Aug 08 11:36:30 EDT 2017
[INFO] Final Memory: 57M/637M
[INFO] 


Thanks,

Nate Cole

Review Request 61500: Service Checks Will Run Multiple Times In Patch/Service Upgrades

2017-08-08 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61500/
---

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-21679
https://issues.apache.org/jira/browse/AMBARI-21679


Repository: ambari


Description
---

There are two issues with Service Checks and patches:

1. A service check grouping can be orchestrated one right after the other if 
the grouping in between them has no processing.
2. A service check grouping can be orchestrated before any components have been 
scheduled.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
07012961af 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 3deb7c866e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 fed5b77942 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
 6a085f331f 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 24a3fa2ce2 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml
 f82b0258de 


Diff: https://reviews.apache.org/r/61500/diff/1/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users

2017-08-08 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61453/#review182393
---


Ship it!




Ship It!

- Jonathan Hurley


On Aug. 7, 2017, 6:45 a.m., Aman Poonia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61453/
> ---
> 
> (Updated Aug. 7, 2017, 6:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-21634
> https://issues.apache.org/jira/browse/AMBARI-21634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make sure Ambari also considers NIS users
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 5f96df5b7a 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 027a0a885c 
> 
> 
> Diff: https://reviews.apache.org/r/61453/diff/1/
> 
> 
> Testing
> ---
> 
> Changed the TestHostInfo.py to include one valid and one invalid user. Also 
> tried it with NIS users and it works as expected.
> 
> 
> Thanks,
> 
> Aman Poonia
> 
>

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61490/#review182389
---


Ship it!




Ship It!

- Nate Cole


On Aug. 7, 2017, 11:48 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61490/
> ---
> 
> (Updated Aug. 7, 2017, 11:48 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21677
> https://issues.apache.org/jira/browse/AMBARI-21677
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With {{PATCH}} and {{SERVICE}} style upgrades, many of the upgrade pre-checks 
> would flag issues related to services or hosts which may not be a part of the 
> upgrade. If the upgrade is not a full-stack upgrade, then warnings and errors 
> related to services which are not part of the upgrade should be ignored.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  4f8a39d8a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
>  04b73fa160 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java
>  c41ad207a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
>  226d82c049 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java
>  d60433d141 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  a77d72b520 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
>  28d7d7884a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> 8feb77a8dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
>  c2ef4ad337 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheck.java
>  ea20a5535b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
>  2b1c62ede2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  8cd935bf1f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  613c5fc431 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
>  7c84e5c630 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/KafkaKerberosCheck.java
>  69721d9e3c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheck.java
>  06ca1629ce 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java
>  ec4ed09da4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  a55a1481d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerSSLConfigCheck.java
>  02f6559fe4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
>  0dbb1b5da1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
>  08f4fd8eed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheck.java
>  3970e9e698 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java
>  38a6702b2e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheck.java
>  35be754bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheck.java
>  5dadcddc20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  d838f6a20e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java
>  77605c1835 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
>  b5435f1830 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnRMHighAvailabilityCheck.java
>  9dd4877ae6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  ba4b61e078 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
>  8f15479a24 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  a96ca6c4a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/KafkaKerberosCheckTest.java
>  41962f9594 
> 
> 
> Diff: https://reviews.apache.org/r/61490/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-08-08 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61024/#review182388
---


Ship it!




Ship It!

- Laszlo Puskas


On Aug. 8, 2017, 1:40 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61024/
> ---
> 
> (Updated Aug. 8, 2017, 1:40 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21545
> https://issues.apache.org/jira/browse/AMBARI-21545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ldap configuration can be included in recommendation requests and validation 
> requests. Configuration is passed down to stack advisor in services.json
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
>  d6714f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
>  0632361 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
>  7ba1b18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  356754d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
>  eaa4716 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java
>  6df8b8b 
> 
> 
> Diff: https://reviews.apache.org/r/61024/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested the rest interface manually
> - Wrote new unit tests
> - Ambari-server unit tests: PENDING
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-08-08 Thread Balázs Bence Sári 


> On July 21, 2017, 12:41 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java
> > Lines 81 (patched)
> > 
> >
> > Can this be placed to a common place and avoid defining it in two 
> > places?

After the rewrite the property is only used in StackAdvisorCommand and its test.


> On July 21, 2017, 12:41 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java
> > Lines 345 (patched)
> > 
> >
> > Add some comment what this method does.

Methdod was deleted along with the rewrite.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61024/#review18
---


On Aug. 8, 2017, 1:40 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61024/
> ---
> 
> (Updated Aug. 8, 2017, 1:40 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21545
> https://issues.apache.org/jira/browse/AMBARI-21545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ldap configuration can be included in recommendation requests and validation 
> requests. Configuration is passed down to stack advisor in services.json
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
>  d6714f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
>  0632361 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
>  7ba1b18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  356754d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
>  eaa4716 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java
>  6df8b8b 
> 
> 
> Diff: https://reviews.apache.org/r/61024/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested the rest interface manually
> - Wrote new unit tests
> - Ambari-server unit tests: PENDING
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Jonathan Hurley 


> On Aug. 8, 2017, 1:31 a.m., Dmytro Grinenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
> > Line 249 (original), 255 (patched)
> > 
> >
> > could we put here some usefull information about request and kind of 
> > error occurs?

Actually, I just dropped the try/catch since all invokers of this expect 
AmbariException anyway.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61490/#review182361
---


On Aug. 7, 2017, 11:48 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61490/
> ---
> 
> (Updated Aug. 7, 2017, 11:48 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21677
> https://issues.apache.org/jira/browse/AMBARI-21677
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With {{PATCH}} and {{SERVICE}} style upgrades, many of the upgrade pre-checks 
> would flag issues related to services or hosts which may not be a part of the 
> upgrade. If the upgrade is not a full-stack upgrade, then warnings and errors 
> related to services which are not part of the upgrade should be ignored.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  4f8a39d8a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
>  04b73fa160 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java
>  c41ad207a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
>  226d82c049 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java
>  d60433d141 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  a77d72b520 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
>  28d7d7884a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> 8feb77a8dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
>  c2ef4ad337 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheck.java
>  ea20a5535b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
>  2b1c62ede2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  8cd935bf1f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  613c5fc431 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
>  7c84e5c630 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/KafkaKerberosCheck.java
>  69721d9e3c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheck.java
>  06ca1629ce 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java
>  ec4ed09da4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  a55a1481d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerSSLConfigCheck.java
>  02f6559fe4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
>  0dbb1b5da1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
>  08f4fd8eed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheck.java
>  3970e9e698 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java
>  38a6702b2e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheck.java
>  35be754bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheck.java
>  5dadcddc20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  d838f6a20e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java
>  77605c1835 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
>  b5435f1830 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnRMHighAvailabilityCheck.java
>  9dd4877ae6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Jonathan Hurley 


> On Aug. 8, 2017, 5:27 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
> > Lines 326 (patched)
> > 
> >
> > cbecks

Thanks! Fixed.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61490/#review182376
---


On Aug. 7, 2017, 11:48 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61490/
> ---
> 
> (Updated Aug. 7, 2017, 11:48 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21677
> https://issues.apache.org/jira/browse/AMBARI-21677
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With {{PATCH}} and {{SERVICE}} style upgrades, many of the upgrade pre-checks 
> would flag issues related to services or hosts which may not be a part of the 
> upgrade. If the upgrade is not a full-stack upgrade, then warnings and errors 
> related to services which are not part of the upgrade should be ignored.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  4f8a39d8a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
>  04b73fa160 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java
>  c41ad207a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
>  226d82c049 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java
>  d60433d141 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  a77d72b520 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
>  28d7d7884a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> 8feb77a8dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
>  c2ef4ad337 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheck.java
>  ea20a5535b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
>  2b1c62ede2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  8cd935bf1f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  613c5fc431 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
>  7c84e5c630 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/KafkaKerberosCheck.java
>  69721d9e3c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheck.java
>  06ca1629ce 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java
>  ec4ed09da4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  a55a1481d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerSSLConfigCheck.java
>  02f6559fe4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
>  0dbb1b5da1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
>  08f4fd8eed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheck.java
>  3970e9e698 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java
>  38a6702b2e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheck.java
>  35be754bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheck.java
>  5dadcddc20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  d838f6a20e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java
>  77605c1835 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
>  b5435f1830 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnRMHighAvailabilityCheck.java
>  9dd4877ae6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  ba4b61e078 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
>  8f15479a24 
>   
>

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-08-08 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61024/
---

(Updated Aug. 8, 2017, 1:40 p.m.)


Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and 
Sebastian Toader.


Changes
---

LDAP Config is retrieved from server within StackAdvisorCommand. In the 
previous version the LDAP config was sent with other configs with 
RecommendationRequest / ConfigurationRequest


Bugs: AMBARI-21545
https://issues.apache.org/jira/browse/AMBARI-21545


Repository: ambari


Description
---

Ldap configuration can be included in recommendation requests and validation 
requests. Configuration is passed down to stack advisor in services.json


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
 d6714f9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
 0632361 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
 7ba1b18 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 356754d 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
 eaa4716 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java
 6df8b8b 


Diff: https://reviews.apache.org/r/61024/diff/2/

Changes: https://reviews.apache.org/r/61024/diff/1-2/


Testing
---

- Tested the rest interface manually
- Wrote new unit tests
- Ambari-server unit tests: PENDING


Thanks,

Balázs Bence Sári

Re: Review Request 60668: Fixed outdated index.html generation in ambari-server/target/generated-sources/swagger

2017-08-08 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60668/#review182379
---


Ship it!




Ship It!

- Sebastian Toader


On July 5, 2017, 10:32 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60668/
> ---
> 
> (Updated July 5, 2017, 10:32 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21410
> https://issues.apache.org/jira/browse/AMBARI-21410
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The input for html generation is taken from the correct source 
> (ambari-server/target/generated-sources/swagger/swagger.json instead of 
> ambari-server/docs/api/generated/swagger.json).
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 878665e 
> 
> 
> Diff: https://reviews.apache.org/r/60668/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested docs generation both with and without the 
> -Dgenerate.swagger.resources flag.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61490/#review182376
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
Lines 326 (patched)


cbecks


- Dmitro Lisnichenko


On Aug. 8, 2017, 6:48 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61490/
> ---
> 
> (Updated Aug. 8, 2017, 6:48 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21677
> https://issues.apache.org/jira/browse/AMBARI-21677
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With {{PATCH}} and {{SERVICE}} style upgrades, many of the upgrade pre-checks 
> would flag issues related to services or hosts which may not be a part of the 
> upgrade. If the upgrade is not a full-stack upgrade, then warnings and errors 
> related to services which are not part of the upgrade should be ignored.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  4f8a39d8a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
>  04b73fa160 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java
>  c41ad207a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
>  226d82c049 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java
>  d60433d141 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  a77d72b520 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
>  28d7d7884a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> 8feb77a8dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
>  c2ef4ad337 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheck.java
>  ea20a5535b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
>  2b1c62ede2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  8cd935bf1f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  613c5fc431 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
>  7c84e5c630 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/KafkaKerberosCheck.java
>  69721d9e3c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheck.java
>  06ca1629ce 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java
>  ec4ed09da4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  a55a1481d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerSSLConfigCheck.java
>  02f6559fe4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
>  0dbb1b5da1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
>  08f4fd8eed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheck.java
>  3970e9e698 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java
>  38a6702b2e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheck.java
>  35be754bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheck.java
>  5dadcddc20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  d838f6a20e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java
>  77605c1835 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
>  b5435f1830 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnRMHighAvailabilityCheck.java
>  9dd4877ae6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  ba4b61e078 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
>  8f15479a24 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  a96ca6c4a3 
>   
>

Re: Review Request 61456: Create a topic to send alert_definitions

2017-08-08 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61456/
---

(Updated Aug. 8, 2017, 9:10 a.m.)


Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-21667
https://issues.apache.org/jira/browse/AMBARI-21667


Repository: ambari


Description (updated)
---

.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 6c1d29c 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 9507c9d 
  ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py 
PRE-CREATION 
  ambari-agent/src/main/python/ambari_agent/Constants.py 17ed2be 
  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 85840d0 
  ambari-agent/src/main/python/ambari_agent/InitializerModule.py 6ef4a04 
  ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py b75b540 
  ambari-agent/src/main/python/ambari_agent/alerts/collector.py adc7f47 
  ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py 803bdc6 
  ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1e32718 
  ambari-agent/src/main/python/ambari_agent/alerts/recovery_alert.py 3092a39 
  ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 945a222 
  ambari-agent/src/main/python/ambari_agent/apscheduler/threadpool.py d6624cc 
  
ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py
 PRE-CREATION 
  
ambari-agent/src/main/python/ambari_agent/listeners/HostLevelParamsEventListener.py
 5aee634 
  ambari-agent/src/main/python/ambari_agent/main.py 56962d3 
  ambari-agent/src/test/python/ambari_agent/BaseStompServerTestCase.py 5db53c8 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 88f1e69 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61456/diff/2/

Changes: https://reviews.apache.org/r/61456/diff/1-2/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users

2017-08-08 Thread Aman Poonia 


> On Aug. 7, 2017, 6:28 p.m., Alejandro Fernandez wrote:
> > What OS'es was this tested on?

Tested it on Centos-6.4. Python documentation says "It is available on all Unix 
versions".


- Aman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61453/#review182306
---


On Aug. 7, 2017, 10:45 a.m., Aman Poonia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61453/
> ---
> 
> (Updated Aug. 7, 2017, 10:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-21634
> https://issues.apache.org/jira/browse/AMBARI-21634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make sure Ambari also considers NIS users
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 5f96df5b7a 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 027a0a885c 
> 
> 
> Diff: https://reviews.apache.org/r/61453/diff/1/
> 
> 
> Testing
> ---
> 
> Changed the TestHostInfo.py to include one valid and one invalid user. Also 
> tried it with NIS users and it works as expected.
> 
> 
> Thanks,
> 
> Aman Poonia
> 
>