Re: Review Request 61993: Atlas should handle external Solr properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61993/#review184188 --- I know originally i recommended that change for atlas (and ranger as well), but on atlas side, external kerberos is not really handled, so maybe we can keep this open as it can cause complications on secured environment, I would say focus on the ranger change and keep this one open. - Oliver Szabo On Aug. 30, 2017, 4:04 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61993/ > --- > > (Updated Aug. 30, 2017, 4:04 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-21855 > https://issues.apache.org/jira/browse/AMBARI-21855 > > > Repository: ambari > > > Description > --- > > Atlas tries to create it's collection using the local ambari-infra Solr even > if it is specified to use an external one. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py > 0305b82 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 41be001 > > > Diff: https://reviews.apache.org/r/61993/diff/1/ > > > Testing > --- > > Tested on two clusters, one running the external solr, the other installed > Atlas, the collections were created. > > > Thanks, > > Miklos Gergely > >
Re: Review Request 61963: [AMBARI-21836] Fix ambari upgrade failure due to missing table issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61963/ --- (Updated Aug. 30, 2017, 7:40 p.m.) Review request for Ambari and Swapan Shridhar. Bugs: AMBARI-21836 https://issues.apache.org/jira/browse/AMBARI-21836 Repository: ambari Description --- [AMBARI-21836] Fix ambari upgrade failure due to missing table issue Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java b4e7a02778 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java b6c323e107 Diff: https://reviews.apache.org/r/61963/diff/1/ Testing --- Thanks, Nishant Bangarwa
Re: Review Request 61996: Integrate new Log Search UI with maven
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61996/#review184187 --- Ship it! Ship It! - Robert Nettleton On Aug. 30, 2017, 6:10 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61996/ > --- > > (Updated Aug. 30, 2017, 6:10 p.m.) > > > Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert > Nettleton. > > > Bugs: AMBARI-21857 > https://issues.apache.org/jira/browse/AMBARI-21857 > > > Repository: ambari > > > Description > --- > > Add new pom.xml file for the new logsearch web ui in order to package static > resources in jar (which are generated with yarn and angular-cli) > > The resource generation flow is the following: > - install (download or copy an already downloaded one) node and yarn in > target/webapp-build folder > - copy source files from the ui root folder into target/webapp-build > - run yarn install, then yarn build-prod > - copy target/webapp-build/dist to target/classes/dist > - during package phase target/classes content included in the generated jar > > Next steps from here: > Add the new ui dependency to logsearch server, during the logsearch portal > build, the dist static content will be packaged with the server files. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web-new/package.json b4902a3 > ambari-logsearch/ambari-logsearch-web-new/pom.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/61996/diff/1/ > > > Testing > --- > > done, manually, generated jar contains "dist/" folder. anyway, no mvn clean > test support yet. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 61993: Atlas should handle external Solr properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61993/#review184184 --- Ship it! The patch looks fine to me, but someone with Atlas expertise should probably review as well. Can you please add Vishal Suvagia to this review? Thanks. - Robert Nettleton On Aug. 30, 2017, 4:04 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61993/ > --- > > (Updated Aug. 30, 2017, 4:04 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-21855 > https://issues.apache.org/jira/browse/AMBARI-21855 > > > Repository: ambari > > > Description > --- > > Atlas tries to create it's collection using the local ambari-infra Solr even > if it is specified to use an external one. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py > 0305b82 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 41be001 > > > Diff: https://reviews.apache.org/r/61993/diff/1/ > > > Testing > --- > > Tested on two clusters, one running the external solr, the other installed > Atlas, the collections were created. > > > Thanks, > > Miklos Gergely > >
Review Request 61998: Update Ambari Metrics service check to support HTTP SPNEGO authentication
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61998/
---
Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Eric Yang, Robert
Levas, and Sid Wagle.
Bugs: AMBARI-21821
https://issues.apache.org/jira/browse/AMBARI-21821
Repository: ambari
Description
---
This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to
authenticate".
In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari
Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But
Ambari Metrics service check currently does not support Kerberos HTTP SPNEGO
authentication.
2017-08-24 16:13:44,078 - Ambari Metrics service check was started.
2017-08-24 16:13:44,109 - Generated metrics for host amshost.example.com :
{
"metrics": [
{
"metricname": "AMBARI_METRICS.SmokeTest.FakeMetric",
"appid": "amssmoketestfake",
"hostname": "host.example.com",
"timestamp": 1503616424000,
"starttime": 1503616424000,
"metrics":
{ "1503616424000": 0.164134766408, "1503616425000": 1503616424000 }
}
]
}
2017-08-24 16:13:44,114 - Connecting (POST) to
amshost.example.com:6188/ws/v1/timeline/metrics/
2017-08-24 16:13:44,117 - Http response for host amshost.example.com: 401
Authentication required
Diffs
-
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
6975bec
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
2b3dfa9
Diff: https://reviews.apache.org/r/61998/diff/1/
Testing
---
1. run the Hadoop QA testing twice and the testcase failures has nothing to do
with the patch
2. manually tested AMS service check on HDP/trunk cluster with combination of
HTTP SPNEGO/Non-HTTP SPNEGO, SSL/Non-SSL, AMS distributed/embedded.
Thanks,
Qin Liu
Review Request 61996: Integrate new Log Search UI with maven
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61996/ --- Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert Nettleton. Bugs: AMBARI-21857 https://issues.apache.org/jira/browse/AMBARI-21857 Repository: ambari Description --- Add new pom.xml file for the new logsearch web ui in order to package static resources in jar (which are generated with yarn and angular-cli) The resource generation flow is the following: - install (download or copy an already downloaded one) node and yarn in target/webapp-build folder - copy source files from the ui root folder into target/webapp-build - run yarn install, then yarn build-prod - copy target/webapp-build/dist to target/classes/dist - during package phase target/classes content included in the generated jar Next steps from here: Add the new ui dependency to logsearch server, during the logsearch portal build, the dist static content will be packaged with the server files. Diffs - ambari-logsearch/ambari-logsearch-web-new/package.json b4902a3 ambari-logsearch/ambari-logsearch-web-new/pom.xml PRE-CREATION Diff: https://reviews.apache.org/r/61996/diff/1/ Testing --- done, manually, generated jar contains "dist/" folder. anyway, no mvn clean test support yet. Thanks, Oliver Szabo
Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/ --- Review request for Ambari, Jayush Luniya and Sid Wagle. Bugs: AMBARI-21856 https://issues.apache.org/jira/browse/AMBARI-21856 Repository: ambari Description --- The problem is that Ambari is using the reponame name field as the distribution when it creates the repo definition file. Since both of these repos use same distribution (which is a common Debian pattern), they collide. Diffs - ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 749a95e ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java cbbe92e ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java b593c32 ambari-server/src/test/java/org/apache/ambari/server/stack/StackModuleTest.java 4698178 Diff: https://reviews.apache.org/r/61994/diff/1/ Testing --- test will be fixed after solution will be approved Thanks, Vitalyi Brodetskyi
Review Request 61993: Atlas should handle external Solr properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61993/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs: AMBARI-21855 https://issues.apache.org/jira/browse/AMBARI-21855 Repository: ambari Description --- Atlas tries to create it's collection using the local ambari-infra Solr even if it is specified to use an external one. Diffs - ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py 0305b82 ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 41be001 Diff: https://reviews.apache.org/r/61993/diff/1/ Testing --- Tested on two clusters, one running the external solr, the other installed Atlas, the collections were created. Thanks, Miklos Gergely
Re: Review Request 61715: package_regex in get_package_from_available() can match wrong pkg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61715/#review184142
---
Ship it!
Ship It!
- Dmytro Grinenko
On Aug. 29, 2017, 3:07 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61715/
> ---
>
> (Updated Aug. 29, 2017, 3:07 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-21744
> https://issues.apache.org/jira/browse/AMBARI-21744
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Due to the issue with regex (missing ^ and $ boundaries),
> resource_management.libraries.script.script.Script#get_package_from_available
> may return wrong package.
> {code}
> >>> list=['hbase_3_0_0_0_229-master', 'hbase_3_0_0_0_229']
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229-master'):
> ...print 'YES'
> ...
> YES
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229'):
> ...print 'YES'
> ...
> YES
> {code}
>
> In this case, the first package name from a list of available packages will
> be returned.
> The impact of bug is that we may install a wrong package if it's simillary
> named and goes first at list. Patch is a single-line fix.
>
>
> Diffs
> -
>
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py
> 313b666878
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py
> de2cced554
>
>
> Diff: https://reviews.apache.org/r/61715/diff/3/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
