Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not correct

[zhangxiaolu zhangxiaolu]

> On 六月 9, 2017, 11:57 a.m., Dmytro Sen wrote:
> > Ship It!
> 
> zhangxiaolu zhangxiaolu wrote:
> thank you for reviewing this patch. Could you be so kind as to commit the 
> patch for me please? Thanks in advance
> 
> Dmytro Sen wrote:
> Can't apply the patch on trunk. Could you update the patch?
> 
> zhangxiaolu zhangxiaolu wrote:
> OK.

thank you for reviewing this patch. Could you be so kind as to commit the patch 
for me please? Thanks in advance. Dmytro Sen 
Nate Cole


- zhangxiaolu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57583/#review177463
---


On 六月 23, 2017, 12:38 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57583/
> ---
> 
> (Updated 六月 23, 2017, 12:38 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, Vitalyi Brodetskyi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20437
> https://issues.apache.org/jira/browse/AMBARI-20437
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As the description of "HDFS Bytes Written" : dfs.datanode.BytesRead 
> and properties's display_unit is MB
> So in heatmap's page,values should be $
> {dfs.datanode.BytesRead._rate/1024}
> MB
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> bcfb2cc 
> 
> 
> Diff: https://reviews.apache.org/r/57583/diff/1/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20437.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/03/14/6cc045b4-f42b-4fc1-980b-62c8ec8a1154__AMBARI-20437.patch
> AMBARI-20437.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/23/792c2b2e-1fe7-4760-a42a-8de1ccc8469c__AMBARI-20437.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/#review185458
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 14, 2017, 10:47 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61994/
> ---
> 
> (Updated Sept. 14, 2017, 10:47 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21856
> https://issues.apache.org/jira/browse/AMBARI-21856
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is that Ambari is using the reponame name field as the 
> distribution when it creates the repo definition file. Since both of these 
> repos use same distribution (which is a common Debian pattern), they collide.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  32b8038 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  858a55f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  c78d88d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  0735e27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  88ece8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  e81d1af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  bad8195 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
> d43bdfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  854f03f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
>  5e1d5d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  17ded10 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  8427a1d 
>   ambari-server/src/main/resources/custom_actions/scripts/update_repo.py 
> 9f2107d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  058c45b 
>   ambari-server/src/main/resources/version_definition.xsd 832d7f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
>  18e2d3f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  3a7b19b 
> 
> 
> Diff: https://reviews.apache.org/r/61994/diff/4/
> 
> 
> Testing
> ---
> 
> test will be fixed after solution will be approved
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/
---

(Updated Вер. 14, 2017, 10:47 після полудня)


Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle.


Bugs: AMBARI-21856
https://issues.apache.org/jira/browse/AMBARI-21856


Repository: ambari


Description
---

The problem is that Ambari is using the reponame name field as the distribution 
when it creates the repo definition file. Since both of these repos use same 
distribution (which is a common Debian pattern), they collide.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
 32b8038 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
 858a55f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 c78d88d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
 0735e27 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
 88ece8f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
 e81d1af 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
 bad8195 
  ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
d43bdfa 
  
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 
854f03f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
 5e1d5d3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
 17ded10 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
 8427a1d 
  ambari-server/src/main/resources/custom_actions/scripts/update_repo.py 
9f2107d 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
 058c45b 
  ambari-server/src/main/resources/version_definition.xsd 832d7f9 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
 18e2d3f 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
 3a7b19b 


Diff: https://reviews.apache.org/r/61994/diff/4/

Changes: https://reviews.apache.org/r/61994/diff/3-4/


Testing
---

test will be fixed after solution will be approved


Thanks,

Vitalyi Brodetskyi

Re: Review Request 61510: AMBARI-21686 : Implement a test driver that provides a set of metric series with different kinds of metric behavior

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61510/#review185454
---


Ship it!




Ship It!

- Sid Wagle


On Aug. 8, 2017, 10:14 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61510/
> ---
> 
> (Updated Aug. 8, 2017, 10:14 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21686
> https://issues.apache.org/jira/browse/AMBARI-21686
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The generator is designed to generate the following series types.
> 
>  Uniform distributed series with some outliers.
>  Normally distributed series with some outliers.
>  Gradually increasing / decreasing series. (Monotonic Series)
>  Step Function Series
>  Series with a low value period and high value period (Not periodic)
>  Steady series with a small period of turbulence and then back to steady.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-alertservice/pom.xml 4afc80f 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/R/AmsRTest.java
>  2bbc250 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/R/RFunctionInvoker.java
>  2713b71 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/DataSet.java
>  a709c73 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/MethodResult.java
>  6bf58df 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/MetricAnomaly.java
>  4dbb425 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/ResultSet.java
>  9415c1b 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/SingleValuedTimelineMetric.java
>  acd4452 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/StatisticUtils.java
>  81bd77b 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/TimelineMetric.java
>  88ad834 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/common/TimelineMetrics.java
>  7df6a9c 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/methods/MetricAnomalyModel.java
>  af33d26 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/methods/ema/EmaDS.java
>  32cd96b 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/methods/ema/EmaModel.java
>  13a0f55 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/methods/ema/EmaModelLoader.java
>  0205844 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/methods/ema/EmaResult.java
>  2d24a9c 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/methods/ema/TestEmaModel.java
>  b851dab 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/AmbariServerInterface.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/MetricAnomalyDetectorTestInput.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/MetricAnomalyTester.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/MetricKafkaProducer.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/MetricSparkConsumer.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/MetricsCollectorInterface.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/PointInTimeADSystem.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/RFunctionInvoker.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-alertservice/src/main/java/org/apache/ambari/metrics/alertservice/prototype/TestSeriesInputRequest.java
>  PRE-CREATION 
>   
> 

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

[Robert Levas]

> On Sept. 14, 2017, 8:40 a.m., Jonathan Hurley wrote:
> > That's a lot of validation! I'm curious though - did you happen to look at 
> > something like http://json-schema.org/ instead of doing it explicitely in 
> > each descriptor class?
> 
> Laszlo Puskas wrote:
> +1
> 
> Robert Levas wrote:
> I tried to do this with a JSON schema validtor, but I was not sure what 
> validator would be appropriate - liscense, schema version, etc...  Also, 
> testing with com.networknt:json-schema-validator:0.1.7 led to dependency 
> conflicts. Do you have a suggestion for a validator implemention?
> 
> Jonathan Hurley wrote:
> I'm an XML-fanboy, so I've never used them either. But I was curious if 
> you had looked into it. You put a lot of code into this and I don't think the 
> commit should be held up. But it might be worth investigation for future 
> changes to the JSON...

@jhurley, you insprired me to look more into this.  JSON schema is really ugly 
and failed to provide some of the validation that I would like to do. Namely 
ensuring the list of objects contain objects with a unique name for the scope.  
This seems like something that would be provided, but is not.  Maybe I can 
ignore this dificency and do a one off check for this.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62290/#review185399
---


On Sept. 13, 2017, 3:52 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62290/
> ---
> 
> (Updated Sept. 13, 2017, 3:52 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Mugdha Varadkar, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21938
> https://issues.apache.org/jira/browse/AMBARI-21938
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validate kerberos.json files to ensure they meet the expected schema.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  0d1da9c743 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  5658133c9b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
>  768a17e3b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptor.java
>  7930e38f39 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  0eb3733584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  911723b80b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptor.java
>  a17caadda0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java
>  74254e3fe3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
>  5da33997ab 
>   ambari-server/src/main/resources/stacks/HDP/2.6/kerberos_preconfigure.json 
> c9d8c91372 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java
>  0f1dd55044 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  09699c6fd6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
>  e891fdea4e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  7fb56248e5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
>  d11962b9a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
>  8cdb39e02e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
>  b84223f421 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  e4d3c90767 
> 
> 
> Diff: https://reviews.apache.org/r/62290/diff/2/
> 
> 
> Testing
> ---
> 
> Ensured the following unit tests passed:
> 
> - org.apache.ambari.server.stack.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosComponentDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosConfigurationDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosIdentityDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosKeytabDescriptorTest
> - 

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

[Jonathan Hurley]

> On Sept. 14, 2017, 8:40 a.m., Jonathan Hurley wrote:
> > That's a lot of validation! I'm curious though - did you happen to look at 
> > something like http://json-schema.org/ instead of doing it explicitely in 
> > each descriptor class?
> 
> Laszlo Puskas wrote:
> +1
> 
> Robert Levas wrote:
> I tried to do this with a JSON schema validtor, but I was not sure what 
> validator would be appropriate - liscense, schema version, etc...  Also, 
> testing with com.networknt:json-schema-validator:0.1.7 led to dependency 
> conflicts. Do you have a suggestion for a validator implemention?

I'm an XML-fanboy, so I've never used them either. But I was curious if you had 
looked into it. You put a lot of code into this and I don't think the commit 
should be held up. But it might be worth investigation for future changes to 
the JSON...


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62290/#review185399
---


On Sept. 13, 2017, 3:52 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62290/
> ---
> 
> (Updated Sept. 13, 2017, 3:52 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Mugdha Varadkar, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21938
> https://issues.apache.org/jira/browse/AMBARI-21938
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validate kerberos.json files to ensure they meet the expected schema.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  0d1da9c743 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  5658133c9b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
>  768a17e3b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptor.java
>  7930e38f39 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  0eb3733584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  911723b80b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptor.java
>  a17caadda0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java
>  74254e3fe3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
>  5da33997ab 
>   ambari-server/src/main/resources/stacks/HDP/2.6/kerberos_preconfigure.json 
> c9d8c91372 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java
>  0f1dd55044 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  09699c6fd6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
>  e891fdea4e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  7fb56248e5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
>  d11962b9a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
>  8cdb39e02e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
>  b84223f421 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  e4d3c90767 
> 
> 
> Diff: https://reviews.apache.org/r/62290/diff/2/
> 
> 
> Testing
> ---
> 
> Ensured the following unit tests passed:
> 
> - org.apache.ambari.server.stack.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosComponentDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosConfigurationDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosIdentityDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosKeytabDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/#review185437
---




ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
Lines 126 (patched)


Can we make this as components instead of single component. We can consider 
components to be a comma separated list. Some debian repos also have multiple 
components although I don't think its commonly used. But just incase someone 
has a special case we don't have to revisit this.

https://wiki.debian.org/SourcesList

deb  http://deb.debian.org/debian stretch main contrib non-free
deb-src  http://deb.debian.org/debian stretch main contrib non-free

deb  http://deb.debian.org/debian stretch-updates main contrib non-free
deb-src  http://deb.debian.org/debian stretch-updates main contrib non-free

deb http://security.debian.org/ stretch/updates main contrib non-free
deb-src http://security.debian.org/ stretch/updates main contrib non-free


- Jayush Luniya


On Sept. 13, 2017, 5:37 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61994/
> ---
> 
> (Updated Sept. 13, 2017, 5:37 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21856
> https://issues.apache.org/jira/browse/AMBARI-21856
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is that Ambari is using the reponame name field as the 
> distribution when it creates the repo definition file. Since both of these 
> repos use same distribution (which is a common Debian pattern), they collide.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  32b8038 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  858a55f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  c78d88d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  0735e27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  88ece8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  bad8195 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
> d43bdfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  854f03f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
>  5e1d5d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  17ded10 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  8427a1d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  058c45b 
>   ambari-server/src/main/resources/version_definition.xsd 832d7f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
>  18e2d3f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  3a7b19b 
> 
> 
> Diff: https://reviews.apache.org/r/61994/diff/3/
> 
> 
> Testing
> ---
> 
> test will be fixed after solution will be approved
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

[Robert Levas]

> On Sept. 14, 2017, 8:40 a.m., Jonathan Hurley wrote:
> > That's a lot of validation! I'm curious though - did you happen to look at 
> > something like http://json-schema.org/ instead of doing it explicitely in 
> > each descriptor class?
> 
> Laszlo Puskas wrote:
> +1

I tried to do this with a JSON schema validtor, but I was not sure what 
validator would be appropriate - liscense, schema version, etc...  Also, 
testing with com.networknt:json-schema-validator:0.1.7 led to dependency 
conflicts. Do you have a suggestion for a validator implemention?


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62290/#review185399
---


On Sept. 13, 2017, 3:52 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62290/
> ---
> 
> (Updated Sept. 13, 2017, 3:52 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Mugdha Varadkar, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21938
> https://issues.apache.org/jira/browse/AMBARI-21938
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validate kerberos.json files to ensure they meet the expected schema.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  0d1da9c743 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  5658133c9b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
>  768a17e3b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptor.java
>  7930e38f39 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  0eb3733584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  911723b80b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptor.java
>  a17caadda0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java
>  74254e3fe3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
>  5da33997ab 
>   ambari-server/src/main/resources/stacks/HDP/2.6/kerberos_preconfigure.json 
> c9d8c91372 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java
>  0f1dd55044 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  09699c6fd6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
>  e891fdea4e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  7fb56248e5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
>  d11962b9a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
>  8cdb39e02e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
>  b84223f421 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  e4d3c90767 
> 
> 
> Diff: https://reviews.apache.org/r/62290/diff/2/
> 
> 
> Testing
> ---
> 
> Ensured the following unit tests passed:
> 
> - org.apache.ambari.server.stack.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosComponentDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosConfigurationDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosIdentityDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosKeytabDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62329: Fix broken zeppelin python unit test

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62329/
---

(Updated Sept. 14, 2017, 9:56 p.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
venkat sairam.


Bugs: AMBARI-21958
https://issues.apache.org/jira/browse/AMBARI-21958


Repository: ambari


Description
---

test_start_secured (test_zeppelin_master.TestZeppelinMaster) seems to be 
happening after AMBARI-21814 commit.


Diffs (updated)
-

  
ambari-server/src/test/python/stacks/2.5/ZEPPELIN/interpreter_json_generated.py 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
60c18c90c2 
  ambari-server/src/test/python/stacks/2.5/configs/default.json bcc3607705 
  ambari-server/src/test/python/stacks/2.5/configs/secured.json 914e6a490f 


Diff: https://reviews.apache.org/r/62329/diff/2/

Changes: https://reviews.apache.org/r/62329/diff/1-2/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62331/#review185419
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 14, 2017, 11:13 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62331/
> ---
> 
> (Updated Sept. 14, 2017, 11:13 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21690
> https://issues.apache.org/jira/browse/AMBARI-21690
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove repository_version and repository_version_id null checks for BP 
> deployments since we want to use the default if-not-specified.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  092339bb7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  8d891b9534 
> 
> 
> Diff: https://reviews.apache.org/r/62331/diff/1/
> 
> 
> Testing
> ---
> 
> Manual cluster deployment.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62330: Ambari schema upgrade from any version older than 2.5.1 fails due to incorrect version check

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62330/
---

(Updated Sept. 14, 2017, 6:58 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

fixed test


Bugs: AMBARI-21940
https://issues.apache.org/jira/browse/AMBARI-21940


Repository: ambari


Description
---

Perform an upgrade from Ambari version older than 2.5.1 (like 2.5.0 or 2.4.x) 
to 2.6.0

Fails with below error
{code}
12 Sep 2017 02:16:35,727  INFO [main] TransactionalLock$LockArea:121 - LockArea 
HRC_STATUS_CACHE is enabled
12 Sep 2017 02:16:36,091  INFO [main] LockFactory:53 - Lock profiling is 
disabled
12 Sep 2017 02:16:36,112  INFO [main] SchemaUpgradeHelper:391 - Upgrading 
schema to target version = 2.6.0.0
12 Sep 2017 02:16:36,115  INFO [main] SchemaUpgradeHelper:400 - Upgrading 
schema from source version = 2.5.0
12 Sep 2017 02:16:36,118 ERROR [main] SchemaUpgradeHelper:434 - Exception 
occurred during upgrade, failed
org.apache.ambari.server.AmbariException: Database version does not meet 
minimal upgrade requirements. Expected version should be not less than 2.5.1, 
current version is 2.5.0
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:405)
12 Sep 2017 02:16:40,419  INFO [main] Configuration:3044 - Reading password 
from existing file
12 Sep 2017 02:16:40,439  INFO [main] Configuration:3529 - Hosts Mapping File 
null
12 Sep 2017 02:16:40,439  INFO [main] HostsMap:60 - Using hostsmap file null
12 Sep 2017 02:16:41,290  INFO [main] ControllerModule:221 - Detected MYSQL as 
the database type from the JDBC URL
{code}


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
 961c4f8b33 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog2402.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelperTest.java
 937fea0363 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62330/diff/2/

Changes: https://reviews.apache.org/r/62330/diff/1-2/


Testing (updated)
---

unit tests
check on live cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 62329: Fix broken zeppelin python unit test

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62329/#review185417
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 14, 2017, 8:27 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62329/
> ---
> 
> (Updated Sept. 14, 2017, 8:27 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21958
> https://issues.apache.org/jira/browse/AMBARI-21958
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> test_start_secured (test_zeppelin_master.TestZeppelinMaster) seems to be 
> happening after AMBARI-21814 commit.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/python/stacks/2.5/ZEPPELIN/interpreter_json_template.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
> 60c18c90c2 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json bcc3607705 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json 914e6a490f 
> 
> 
> Diff: https://reviews.apache.org/r/62329/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62331/#review185415
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 14, 2017, 3:13 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62331/
> ---
> 
> (Updated Sept. 14, 2017, 3:13 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21690
> https://issues.apache.org/jira/browse/AMBARI-21690
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove repository_version and repository_version_id null checks for BP 
> deployments since we want to use the default if-not-specified.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  092339bb7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  8d891b9534 
> 
> 
> Diff: https://reviews.apache.org/r/62331/diff/1/
> 
> 
> Testing
> ---
> 
> Manual cluster deployment.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62331/#review185412
---


Ship it!




Ship It!

- Dmytro Grinenko


On Sept. 14, 2017, 3:13 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62331/
> ---
> 
> (Updated Sept. 14, 2017, 3:13 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21690
> https://issues.apache.org/jira/browse/AMBARI-21690
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove repository_version and repository_version_id null checks for BP 
> deployments since we want to use the default if-not-specified.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  092339bb7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  8d891b9534 
> 
> 
> Diff: https://reviews.apache.org/r/62331/diff/1/
> 
> 
> Testing
> ---
> 
> Manual cluster deployment.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62331/
---

Review request for Ambari, Dmytro Grinenko and Jonathan Hurley.


Bugs: AMBARI-21690
https://issues.apache.org/jira/browse/AMBARI-21690


Repository: ambari


Description
---

Remove repository_version and repository_version_id null checks for BP 
deployments since we want to use the default if-not-specified.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 092339bb7a 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
 8d891b9534 


Diff: https://reviews.apache.org/r/62331/diff/1/


Testing
---

Manual cluster deployment.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 62330: Ambari schema upgrade from any version older than 2.5.1 fails due to incorrect version check

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62330/#review185410
---


Ship it!




Ship It!

- Nate Cole


On Sept. 14, 2017, 9:43 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62330/
> ---
> 
> (Updated Sept. 14, 2017, 9:43 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21940
> https://issues.apache.org/jira/browse/AMBARI-21940
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Perform an upgrade from Ambari version older than 2.5.1 (like 2.5.0 or 2.4.x) 
> to 2.6.0
> 
> Fails with below error
> {code}
> 12 Sep 2017 02:16:35,727  INFO [main] TransactionalLock$LockArea:121 - 
> LockArea HRC_STATUS_CACHE is enabled
> 12 Sep 2017 02:16:36,091  INFO [main] LockFactory:53 - Lock profiling is 
> disabled
> 12 Sep 2017 02:16:36,112  INFO [main] SchemaUpgradeHelper:391 - Upgrading 
> schema to target version = 2.6.0.0
> 12 Sep 2017 02:16:36,115  INFO [main] SchemaUpgradeHelper:400 - Upgrading 
> schema from source version = 2.5.0
> 12 Sep 2017 02:16:36,118 ERROR [main] SchemaUpgradeHelper:434 - Exception 
> occurred during upgrade, failed
> org.apache.ambari.server.AmbariException: Database version does not meet 
> minimal upgrade requirements. Expected version should be not less than 2.5.1, 
> current version is 2.5.0
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:405)
> 12 Sep 2017 02:16:40,419  INFO [main] Configuration:3044 - Reading password 
> from existing file
> 12 Sep 2017 02:16:40,439  INFO [main] Configuration:3529 - Hosts Mapping File 
> null
> 12 Sep 2017 02:16:40,439  INFO [main] HostsMap:60 - Using hostsmap file null
> 12 Sep 2017 02:16:41,290  INFO [main] ControllerModule:221 - Detected MYSQL 
> as the database type from the JDBC URL
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  961c4f8b33 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog2402.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62330/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests are running
> check on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 62242: AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62242/#review185409
---



Committed to trunk. Please close this review.

- Jonathan Hurley


On Sept. 13, 2017, 2:31 p.m., Jason Golieb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62242/
> ---
> 
> (Updated Sept. 13, 2017, 2:31 p.m.)
> 
> 
> Review request for Ambari, Denys Buzhor, Jaimin Jetly, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21933
> https://issues.apache.org/jira/browse/AMBARI-21933
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Implement breadcrumb navigation in the Background Operations modal and the 
> drill-down views within it. This also affects the use of these views in the 
> High Availability wizard. The breadcrumbs will provide a better navigation 
> experience within this series of dialogs, helping the user to see the context 
> of the current view and to navigate back up the hierarchy more easily. It 
> will also be more consistent with the overall UX of Ambari 3.0.0.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/global/background_operations_controller.js 
> de420b5a131 
>   
> ambari-web/app/controllers/main/admin/highAvailability/progress_popup_controller.js
>  4cbe59b020c 
>   ambari-web/app/messages.js 87a5e97a68d 
>   ambari-web/app/styles/modal_popups.less f7fe88be71d 
>   ambari-web/app/templates/common/breadcrumbs.hbs 89353d9f065 
>   ambari-web/app/templates/common/host_progress_popup.hbs 03c014cefa0 
>   ambari-web/app/utils/host_progress_popup.js 5bd02cd76de 
>   ambari-web/app/views/common/breadcrumbs_view.js e35a1965215 
>   ambari-web/app/views/common/host_progress_popup_body_view.js 057f8bcf3c4 
>   ambari-web/test/controllers/global/background_operations_test.js 
> 4a8235c484b 
>   
> ambari-web/test/controllers/main/admin/highAvailability/progress_popup_controller_test.js
>  364d9b0b451 
>   ambari-web/test/utils/host_progress_popup_test.js dea2666fd47 
>   ambari-web/test/views/common/breadcrumbs_view_test.js eff19f63b88 
>   ambari-web/test/views/common/host_progress_popup_body_view_test.js 
> 5ccc0245101 
> 
> 
> Diff: https://reviews.apache.org/r/62242/diff/2/
> 
> 
> Testing
> ---
> 
> 21293 passing
> 
> 
> Thanks,
> 
> Jason Golieb
> 
>

Re: Review Request 62242: AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62242/#review185408
---


Ship it!




Ship It!

- Denys Buzhor


On Sept. 13, 2017, 6:31 p.m., Jason Golieb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62242/
> ---
> 
> (Updated Sept. 13, 2017, 6:31 p.m.)
> 
> 
> Review request for Ambari, Denys Buzhor, Jaimin Jetly, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21933
> https://issues.apache.org/jira/browse/AMBARI-21933
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Implement breadcrumb navigation in the Background Operations modal and the 
> drill-down views within it. This also affects the use of these views in the 
> High Availability wizard. The breadcrumbs will provide a better navigation 
> experience within this series of dialogs, helping the user to see the context 
> of the current view and to navigate back up the hierarchy more easily. It 
> will also be more consistent with the overall UX of Ambari 3.0.0.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/global/background_operations_controller.js 
> de420b5a131 
>   
> ambari-web/app/controllers/main/admin/highAvailability/progress_popup_controller.js
>  4cbe59b020c 
>   ambari-web/app/messages.js 87a5e97a68d 
>   ambari-web/app/styles/modal_popups.less f7fe88be71d 
>   ambari-web/app/templates/common/breadcrumbs.hbs 89353d9f065 
>   ambari-web/app/templates/common/host_progress_popup.hbs 03c014cefa0 
>   ambari-web/app/utils/host_progress_popup.js 5bd02cd76de 
>   ambari-web/app/views/common/breadcrumbs_view.js e35a1965215 
>   ambari-web/app/views/common/host_progress_popup_body_view.js 057f8bcf3c4 
>   ambari-web/test/controllers/global/background_operations_test.js 
> 4a8235c484b 
>   
> ambari-web/test/controllers/main/admin/highAvailability/progress_popup_controller_test.js
>  364d9b0b451 
>   ambari-web/test/utils/host_progress_popup_test.js dea2666fd47 
>   ambari-web/test/views/common/breadcrumbs_view_test.js eff19f63b88 
>   ambari-web/test/views/common/host_progress_popup_body_view_test.js 
> 5ccc0245101 
> 
> 
> Diff: https://reviews.apache.org/r/62242/diff/2/
> 
> 
> Testing
> ---
> 
> 21293 passing
> 
> 
> Thanks,
> 
> Jason Golieb
> 
>

Re: Review Request 62242: AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62242/#review185407
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Sept. 13, 2017, 6:31 p.m., Jason Golieb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62242/
> ---
> 
> (Updated Sept. 13, 2017, 6:31 p.m.)
> 
> 
> Review request for Ambari, Denys Buzhor, Jaimin Jetly, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21933
> https://issues.apache.org/jira/browse/AMBARI-21933
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Implement breadcrumb navigation in the Background Operations modal and the 
> drill-down views within it. This also affects the use of these views in the 
> High Availability wizard. The breadcrumbs will provide a better navigation 
> experience within this series of dialogs, helping the user to see the context 
> of the current view and to navigate back up the hierarchy more easily. It 
> will also be more consistent with the overall UX of Ambari 3.0.0.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/global/background_operations_controller.js 
> de420b5a131 
>   
> ambari-web/app/controllers/main/admin/highAvailability/progress_popup_controller.js
>  4cbe59b020c 
>   ambari-web/app/messages.js 87a5e97a68d 
>   ambari-web/app/styles/modal_popups.less f7fe88be71d 
>   ambari-web/app/templates/common/breadcrumbs.hbs 89353d9f065 
>   ambari-web/app/templates/common/host_progress_popup.hbs 03c014cefa0 
>   ambari-web/app/utils/host_progress_popup.js 5bd02cd76de 
>   ambari-web/app/views/common/breadcrumbs_view.js e35a1965215 
>   ambari-web/app/views/common/host_progress_popup_body_view.js 057f8bcf3c4 
>   ambari-web/test/controllers/global/background_operations_test.js 
> 4a8235c484b 
>   
> ambari-web/test/controllers/main/admin/highAvailability/progress_popup_controller_test.js
>  364d9b0b451 
>   ambari-web/test/utils/host_progress_popup_test.js dea2666fd47 
>   ambari-web/test/views/common/breadcrumbs_view_test.js eff19f63b88 
>   ambari-web/test/views/common/host_progress_popup_body_view_test.js 
> 5ccc0245101 
> 
> 
> Diff: https://reviews.apache.org/r/62242/diff/2/
> 
> 
> Testing
> ---
> 
> 21293 passing
> 
> 
> Thanks,
> 
> Jason Golieb
> 
>

Review Request 62330: Ambari schema upgrade from any version older than 2.5.1 fails due to incorrect version check

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62330/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-21940
https://issues.apache.org/jira/browse/AMBARI-21940


Repository: ambari


Description
---

Perform an upgrade from Ambari version older than 2.5.1 (like 2.5.0 or 2.4.x) 
to 2.6.0

Fails with below error
{code}
12 Sep 2017 02:16:35,727  INFO [main] TransactionalLock$LockArea:121 - LockArea 
HRC_STATUS_CACHE is enabled
12 Sep 2017 02:16:36,091  INFO [main] LockFactory:53 - Lock profiling is 
disabled
12 Sep 2017 02:16:36,112  INFO [main] SchemaUpgradeHelper:391 - Upgrading 
schema to target version = 2.6.0.0
12 Sep 2017 02:16:36,115  INFO [main] SchemaUpgradeHelper:400 - Upgrading 
schema from source version = 2.5.0
12 Sep 2017 02:16:36,118 ERROR [main] SchemaUpgradeHelper:434 - Exception 
occurred during upgrade, failed
org.apache.ambari.server.AmbariException: Database version does not meet 
minimal upgrade requirements. Expected version should be not less than 2.5.1, 
current version is 2.5.0
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:405)
12 Sep 2017 02:16:40,419  INFO [main] Configuration:3044 - Reading password 
from existing file
12 Sep 2017 02:16:40,439  INFO [main] Configuration:3529 - Hosts Mapping File 
null
12 Sep 2017 02:16:40,439  INFO [main] HostsMap:60 - Using hostsmap file null
12 Sep 2017 02:16:41,290  INFO [main] ControllerModule:221 - Detected MYSQL as 
the database type from the JDBC URL
{code}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
 961c4f8b33 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog2402.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62330/diff/1/


Testing
---

unit tests are running
check on live cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

[Laszlo Puskas]

> On Sept. 14, 2017, 12:40 p.m., Jonathan Hurley wrote:
> > That's a lot of validation! I'm curious though - did you happen to look at 
> > something like http://json-schema.org/ instead of doing it explicitely in 
> > each descriptor class?

+1


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62290/#review185399
---


On Sept. 13, 2017, 7:52 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62290/
> ---
> 
> (Updated Sept. 13, 2017, 7:52 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Mugdha Varadkar, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21938
> https://issues.apache.org/jira/browse/AMBARI-21938
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validate kerberos.json files to ensure they meet the expected schema.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  0d1da9c743 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  5658133c9b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
>  768a17e3b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptor.java
>  7930e38f39 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  0eb3733584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  911723b80b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptor.java
>  a17caadda0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java
>  74254e3fe3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
>  5da33997ab 
>   ambari-server/src/main/resources/stacks/HDP/2.6/kerberos_preconfigure.json 
> c9d8c91372 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java
>  0f1dd55044 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  09699c6fd6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
>  e891fdea4e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  7fb56248e5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
>  d11962b9a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
>  8cdb39e02e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
>  b84223f421 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  e4d3c90767 
> 
> 
> Diff: https://reviews.apache.org/r/62290/diff/2/
> 
> 
> Testing
> ---
> 
> Ensured the following unit tests passed:
> 
> - org.apache.ambari.server.stack.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosComponentDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosConfigurationDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosIdentityDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosKeytabDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62290/#review185405
---


Ship it!




Ship It!

- Laszlo Puskas


On Sept. 13, 2017, 7:52 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62290/
> ---
> 
> (Updated Sept. 13, 2017, 7:52 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Mugdha Varadkar, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21938
> https://issues.apache.org/jira/browse/AMBARI-21938
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validate kerberos.json files to ensure they meet the expected schema.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  0d1da9c743 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  5658133c9b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
>  768a17e3b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptor.java
>  7930e38f39 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  0eb3733584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  911723b80b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptor.java
>  a17caadda0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java
>  74254e3fe3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
>  5da33997ab 
>   ambari-server/src/main/resources/stacks/HDP/2.6/kerberos_preconfigure.json 
> c9d8c91372 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java
>  0f1dd55044 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  09699c6fd6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
>  e891fdea4e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  7fb56248e5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
>  d11962b9a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
>  8cdb39e02e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
>  b84223f421 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  e4d3c90767 
> 
> 
> Diff: https://reviews.apache.org/r/62290/diff/2/
> 
> 
> Testing
> ---
> 
> Ensured the following unit tests passed:
> 
> - org.apache.ambari.server.stack.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosComponentDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosConfigurationDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosIdentityDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosKeytabDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62329: Fix broken zeppelin python unit test

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62329/#review185404
---


Ship it!




Ship It!

- Gaurav Nagar


On Sept. 14, 2017, 12:27 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62329/
> ---
> 
> (Updated Sept. 14, 2017, 12:27 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21958
> https://issues.apache.org/jira/browse/AMBARI-21958
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> test_start_secured (test_zeppelin_master.TestZeppelinMaster) seems to be 
> happening after AMBARI-21814 commit.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/python/stacks/2.5/ZEPPELIN/interpreter_json_template.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
> 60c18c90c2 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json bcc3607705 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json 914e6a490f 
> 
> 
> Diff: https://reviews.apache.org/r/62329/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62290/#review185399
---


Ship it!




That's a lot of validation! I'm curious though - did you happen to look at 
something like http://json-schema.org/ instead of doing it explicitely in each 
descriptor class?


ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
Lines 271 (patched)


of


- Jonathan Hurley


On Sept. 13, 2017, 3:52 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62290/
> ---
> 
> (Updated Sept. 13, 2017, 3:52 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Mugdha Varadkar, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21938
> https://issues.apache.org/jira/browse/AMBARI-21938
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validate kerberos.json files to ensure they meet the expected schema.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  0d1da9c743 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  5658133c9b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
>  768a17e3b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptor.java
>  7930e38f39 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  0eb3733584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  911723b80b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptor.java
>  a17caadda0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java
>  74254e3fe3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
>  5da33997ab 
>   ambari-server/src/main/resources/stacks/HDP/2.6/kerberos_preconfigure.json 
> c9d8c91372 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java
>  0f1dd55044 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  09699c6fd6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
>  e891fdea4e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  7fb56248e5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
>  d11962b9a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
>  8cdb39e02e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
>  b84223f421 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  e4d3c90767 
> 
> 
> Diff: https://reviews.apache.org/r/62290/diff/2/
> 
> 
> Testing
> ---
> 
> Ensured the following unit tests passed:
> 
> - org.apache.ambari.server.stack.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosComponentDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosConfigurationDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosIdentityDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosKeytabDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 62329: Fix broken zeppelin python unit test

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62329/
---

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
venkat sairam.


Bugs: AMBARI-21958
https://issues.apache.org/jira/browse/AMBARI-21958


Repository: ambari


Description
---

test_start_secured (test_zeppelin_master.TestZeppelinMaster) seems to be 
happening after AMBARI-21814 commit.


Diffs
-

  
ambari-server/src/test/python/stacks/2.5/ZEPPELIN/interpreter_json_template.py 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
60c18c90c2 
  ambari-server/src/test/python/stacks/2.5/configs/default.json bcc3607705 
  ambari-server/src/test/python/stacks/2.5/configs/secured.json 914e6a490f 


Diff: https://reviews.apache.org/r/62329/diff/1/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62290/#review185398
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 13, 2017, 9:52 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62290/
> ---
> 
> (Updated Sept. 13, 2017, 9:52 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Mugdha Varadkar, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21938
> https://issues.apache.org/jira/browse/AMBARI-21938
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validate kerberos.json files to ensure they meet the expected schema.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  0d1da9c743 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  5658133c9b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
>  768a17e3b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptor.java
>  7930e38f39 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  0eb3733584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  911723b80b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptor.java
>  a17caadda0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java
>  74254e3fe3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
>  5da33997ab 
>   ambari-server/src/main/resources/stacks/HDP/2.6/kerberos_preconfigure.json 
> c9d8c91372 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java
>  0f1dd55044 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  09699c6fd6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
>  e891fdea4e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  7fb56248e5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
>  d11962b9a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
>  8cdb39e02e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
>  b84223f421 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  e4d3c90767 
> 
> 
> Diff: https://reviews.apache.org/r/62290/diff/2/
> 
> 
> Testing
> ---
> 
> Ensured the following unit tests passed:
> 
> - org.apache.ambari.server.stack.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosComponentDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosConfigurationDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosIdentityDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosKeytabDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
> - org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62289/#review185391
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Sept. 13, 2017, 9:25 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62289/
> ---
> 
> (Updated Sept. 13, 2017, 9:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21950
> https://issues.apache.org/jira/browse/AMBARI-21950
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The check for services in the VDF is being done AFTER setting all the hosts 
> to INSTALLING.
> 
> Added assertions to verify that is or is not happening.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  c2084b6954 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  06e8dfa8ba 
> 
> 
> Diff: https://reviews.apache.org/r/62289/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [WARNING] Tests run: 4861, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:08.786s
> [INFO] Finished at: Wed Sep 13 15:20:51 EDT 2017
> [INFO] Final Memory: 68M/1910M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

[Dmitro Lisnichenko]

> On Sept. 14, 2017, 2 p.m., Dmitro Lisnichenko wrote:
> > Ship It!

my bad


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62289/#review185391
---


On Sept. 13, 2017, 9:25 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62289/
> ---
> 
> (Updated Sept. 13, 2017, 9:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21950
> https://issues.apache.org/jira/browse/AMBARI-21950
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The check for services in the VDF is being done AFTER setting all the hosts 
> to INSTALLING.
> 
> Added assertions to verify that is or is not happening.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  c2084b6954 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  06e8dfa8ba 
> 
> 
> Diff: https://reviews.apache.org/r/62289/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [WARNING] Tests run: 4861, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:08.786s
> [INFO] Finished at: Wed Sep 13 15:20:51 EDT 2017
> [INFO] Final Memory: 68M/1910M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62205: Make Ambari changes for external-conf

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62205/#review185386
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Sept. 9, 2017, 5:15 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62205/
> ---
> 
> (Updated Sept. 9, 2017, 5:15 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21912
> https://issues.apache.org/jira/browse/AMBARI-21912
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When the user upgrades from HDP-2.5.x to HDP-2.6.x, they have to do these 
> manual steps listed here 
> https://community.hortonworks.com/articles/115251/running-jdbc-intepreter-with-phoenix-causes-broken.html,
>  to make JDBC(phoenix) works, i.e. to add `export 
> ZEPPELIN_INTP_CLASSPATH_OVERRIDES="{{external_dependency_conf}}"` in 
> zeppelin_env_content only in case of upgrade from HDP-2.5 to HDP-2.6
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> f89654e5f5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  b79f644fd3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  90a7d979b5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> f3b1fa6b37 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 5ee82c3c82 
> 
> 
> Diff: https://reviews.apache.org/r/62205/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62205: Make Ambari changes for external-conf

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62205/#review185385
---


Ship it!




Ship It!

- Gaurav Nagar


On Sept. 9, 2017, 5:15 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62205/
> ---
> 
> (Updated Sept. 9, 2017, 5:15 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21912
> https://issues.apache.org/jira/browse/AMBARI-21912
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When the user upgrades from HDP-2.5.x to HDP-2.6.x, they have to do these 
> manual steps listed here 
> https://community.hortonworks.com/articles/115251/running-jdbc-intepreter-with-phoenix-causes-broken.html,
>  to make JDBC(phoenix) works, i.e. to add `export 
> ZEPPELIN_INTP_CLASSPATH_OVERRIDES="{{external_dependency_conf}}"` in 
> zeppelin_env_content only in case of upgrade from HDP-2.5 to HDP-2.6
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> f89654e5f5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  b79f644fd3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  90a7d979b5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> f3b1fa6b37 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 5ee82c3c82 
> 
> 
> Diff: https://reviews.apache.org/r/62205/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62155: Add 0.7.x stack definition for Zeppelin

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62155/
---

(Updated Sept. 14, 2017, 2 p.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-21901
https://issues.apache.org/jira/browse/AMBARI-21901


Repository: ambari


Description
---

Currently, in Zeppelin, there are two stack definitions 0.6.0.2.5 and 
0.6.0.3.0. The ideas of this Jira are following:
 - rename 0.6.0.2.5 to 0.6.0
 - delete redundant 0.6.0.3.0
 - create another defination for 0.7.x as 0.7.0


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json 
8e9b6e7f4b 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
 7f0d9e49cf 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-log4j-properties.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
 e29eae321a 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/interpreter_json_template.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/service_check.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/spark2_config_template.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/templates/input.config-zeppelin.json.j2
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/quicklinks/quicklinks.json
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/role_command_order.json
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/alerts.json 
8e9b6e7f4b 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-config.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-env.xml
 b393def227 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-log4j-properties.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-shiro-ini.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/kerberos.json
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml
 7f2f57025f 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/alert_check_zeppelin.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/livy2_config_template.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/master.py
 ab798ec60c 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/params.py
 2340df9dea 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/service_check.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/spark2_config_template.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/status_params.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/templates/input.config-zeppelin.json.j2
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/quicklinks/quicklinks.json
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/role_command_order.json
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/service_advisor.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml 
ee189b1673 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/metainfo.xml 
d4292c8a7c 
  

Re: Review Request 62324: AMBARI-21955: Port Storm View from React.js to Vue.js

[Sanket Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62324/
---

(Updated Sept. 14, 2017, 7:11 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Sumit Mohanty, and Sriharsha 
Chintalapani.


Bugs: AMBARI-21955
https://issues.apache.org/jira/browse/AMBARI-21955


Repository: ambari


Description
---

The Apache Software Foundation Legal Affairs Committee has announced that the 
so-called 'Facebook BSD+Patents License' is no longer allowed to be used as a 
direct dependency in Apache projects.

Since Storm View is using React.js which is under the same Facebook's license, 
needs to get rid of and use Vue.js instead.


Diffs
-

  .gitignore a40e61a 
  contrib/views/storm/pom.xml cd92658 
  contrib/views/storm/src/main/resources/images/icon-bolt.png  
  contrib/views/storm/src/main/resources/images/icon-spout.png  
  contrib/views/storm/src/main/resources/images/loader.gif  
  contrib/views/storm/src/main/resources/index.html df94a76 
  
contrib/views/storm/src/main/resources/libs/Backbone-Paginator/js/backbone-paginator.min.js
 d8ccc65 
  contrib/views/storm/src/main/resources/libs/Backbone/js/Backbone.js f246b10 
  
contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-editable.css
 50543a7 
  
contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-slider.min.css
 d30595c 
  
contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-switch.min.css
 c63cfe2 
  contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap.css 
5a77806 
  
contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.eot
 b93a4953fff68df523aa7656497ee339d6026d64 
  
contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.svg
 94fb549 
  
contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.ttf
 1413fc609ab6f21774de0cb7e01360095584f65b 
  
contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff
 9e612858f802245ddcbf59788a0db942224bab35 
  
contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff2
 64539b54c3751a6d9adb44c8e3a45ba5a73b77f0 
  contrib/views/storm/src/main/resources/libs/Bootstrap/images/clear.png 
580b52a5be8a644f826def0c7ed6a13f90c0915c 
  contrib/views/storm/src/main/resources/libs/Bootstrap/images/loading.gif 
5b33f7e54f4e55b6b8774d86d96895db9af044b4 
  
contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-editable.min.js
 b786a84 
  
contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-notify.min.js
 01e7f30 
  
contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-slider.min.js
 e61cd83 
  
contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-switch.min.js
 9849658 
  contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap.min.js 
e79c065 
  
contrib/views/storm/src/main/resources/libs/Font-Awesome/css/font-awesome.min.css
 d0603cb 
  
contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/FontAwesome.otf 
3ed7f8b48ad9bfab52eb03822fefcd6b77d2e680 
  
contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.eot
 9b6afaedc0fd7aaf927a07f82da9c11022251b8b 
  
contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.svg
 d05688e 
  
contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.ttf
 26dea7951a73079223b50653c455c5adf46a4648 
  
contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff
 dc35ce3c2cf688c89b0bd0d4a82bc4be82b14c40 
  
contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff2
 500e5172534171f678e01f7569d66f9257036a09 
  contrib/views/storm/src/main/resources/libs/Underscore/js/Underscore.js 
dfd89b2 
  contrib/views/storm/src/main/resources/libs/bootbox/js/bootbox.min.js 0dc0cbd 
  contrib/views/storm/src/main/resources/libs/d3/js/d3-tip.min.js 4767cc0 
  contrib/views/storm/src/main/resources/libs/d3/js/d3.min.js 2856dd2 
  contrib/views/storm/src/main/resources/libs/dagre-d3/dagre-d3.min.js b4821d8 
  contrib/views/storm/src/main/resources/libs/jQuery/js/jquery-2.2.3.min.js 
b8c4187 
  contrib/views/storm/src/main/resources/libs/jsx/JSXTransformer.js efc63ff 
  contrib/views/storm/src/main/resources/libs/jsx/jsx.js 0a72088 
  contrib/views/storm/src/main/resources/libs/react/js/react-dom.js e9faebd 
  contrib/views/storm/src/main/resources/libs/react/js/react-with-addons.js 
5b451eb 
  contrib/views/storm/src/main/resources/libs/require-js/js/require.min.js 
a6d55d5 
  contrib/views/storm/src/main/resources/libs/require-text/js/text.js 49e242c 
  contrib/views/storm/src/main/resources/scripts/collections/BaseCollection.js 
ab1b64a