Re: Review Request 62324: AMBARI-21955: Port Storm View from React.js to Vue.js

2017-09-22 Thread Sanket Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62324/#review186045
---



Facebook is releasing React under MIT license 
(https://code.facebook.com/posts/300798627056246)

I guess we should hold merging this patch till this license gets released and 
just update the library later.

- Sanket Shah


On Sept. 14, 2017, 7:11 a.m., Sanket Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62324/
> ---
> 
> (Updated Sept. 14, 2017, 7:11 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Sumit Mohanty, and Sriharsha 
> Chintalapani.
> 
> 
> Bugs: AMBARI-21955
> https://issues.apache.org/jira/browse/AMBARI-21955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Apache Software Foundation Legal Affairs Committee has announced that the 
> so-called 'Facebook BSD+Patents License' is no longer allowed to be used as a 
> direct dependency in Apache projects.
> 
> Since Storm View is using React.js which is under the same Facebook's 
> license, needs to get rid of and use Vue.js instead.
> 
> 
> Diffs
> -
> 
>   .gitignore a40e61a 
>   contrib/views/storm/pom.xml cd92658 
>   contrib/views/storm/src/main/resources/images/icon-bolt.png  
>   contrib/views/storm/src/main/resources/images/icon-spout.png  
>   contrib/views/storm/src/main/resources/images/loader.gif  
>   contrib/views/storm/src/main/resources/index.html df94a76 
>   
> contrib/views/storm/src/main/resources/libs/Backbone-Paginator/js/backbone-paginator.min.js
>  d8ccc65 
>   contrib/views/storm/src/main/resources/libs/Backbone/js/Backbone.js f246b10 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-editable.css
>  50543a7 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-slider.min.css
>  d30595c 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-switch.min.css
>  c63cfe2 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap.css 
> 5a77806 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.eot
>  b93a4953fff68df523aa7656497ee339d6026d64 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.svg
>  94fb549 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.ttf
>  1413fc609ab6f21774de0cb7e01360095584f65b 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff
>  9e612858f802245ddcbf59788a0db942224bab35 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff2
>  64539b54c3751a6d9adb44c8e3a45ba5a73b77f0 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/clear.png 
> 580b52a5be8a644f826def0c7ed6a13f90c0915c 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/loading.gif 
> 5b33f7e54f4e55b6b8774d86d96895db9af044b4 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-editable.min.js
>  b786a84 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-notify.min.js
>  01e7f30 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-slider.min.js
>  e61cd83 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-switch.min.js
>  9849658 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap.min.js 
> e79c065 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/css/font-awesome.min.css
>  d0603cb 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/FontAwesome.otf
>  3ed7f8b48ad9bfab52eb03822fefcd6b77d2e680 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.eot
>  9b6afaedc0fd7aaf927a07f82da9c11022251b8b 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.svg
>  d05688e 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.ttf
>  26dea7951a73079223b50653c455c5adf46a4648 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff
>  dc35ce3c2cf688c89b0bd0d4a82bc4be82b14c40 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff2
>  500e5172534171f678e01f7569d66f9257036a09 
>   contrib/views/storm/src/main/resources/libs/Underscore/js/Underscore.js 
> dfd89b2 
>   contrib/views/storm/src/main/resources/libs/bootbox/js/bootbox.min.js 
> 0dc0cbd 
>   contrib/views/storm/src/main/resources/libs/d3/js/d3-tip.min.js 4767cc0 
>   contrib/views/storm/src/main/resources/libs/d3/js/d3.min.js 2856dd2 
>   contrib/views/storm/src/main/resources/libs/dagre-d3/dagre-d3

Re: Review Request 62351: AMBARI-21910 Ranger Usersync config to support nested group evaluation for LDAP Sync source property

2017-09-22 Thread Mugdha Varadkar 


> On Sept. 21, 2017, 3:19 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
> > Lines 398 (patched)
> > 
> >
> > Maybe a better title? Like "Enabling Nested Group Sync for Ranger"

Updated in latest patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62351/#review185894
---


On Sept. 22, 2017, 12:40 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62351/
> ---
> 
> (Updated Sept. 22, 2017, 12:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-21910
> https://issues.apache.org/jira/browse/AMBARI-21910
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of RANGER-1735, we are supporting nested groups in ranger usersync. 
> For this, introduced one new property 
> "ranger.usersync.ldap.grouphierarchylevels". The value should be an integer 
> with default value as 0. This property should be under Ranger --> Configs --> 
> Ranger User Info --> Group Configs tab.
> This property can be enabled with a flag labelled as "Sync Nested Groups". 
> 1. Default value for this flag is "No"
> 2. This flag is always shown under Group Configs (even when "Enable group 
> Sync" is set to "No")
> 3. If this flag is set to "No", then the value for 
> ranger.usersync.ldap.grouphierarchylevels is hidden and is set to "0". 
> 4. If this flag is set to "Yes", then 
> ranger.usersync.ldap.grouphierarchylevels is shown and allowed to set any 
> integer greater than 0.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerUsersyncConfigCalculation.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
>  627216e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-ugsync-site.xml
>  a994856 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
>  8068a38 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  535ac2e 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 74271cc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerUsersyncConfigCalculationTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62351/diff/3/
> 
> 
> Testing
> ---
> 
> Test Fresh Installs.
> Ambari upgrade with stack 2.6.
> Unit Test passed for UpgradeCatalog260Test.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 62351: AMBARI-21910 Ranger Usersync config to support nested group evaluation for LDAP Sync source property

2017-09-22 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62351/
---

(Updated Sept. 22, 2017, 12:40 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, 
Jayush Luniya, and Velmurugan Periasamy.


Bugs: AMBARI-21910
https://issues.apache.org/jira/browse/AMBARI-21910


Repository: ambari


Description
---

As part of RANGER-1735, we are supporting nested groups in ranger usersync. For 
this, introduced one new property "ranger.usersync.ldap.grouphierarchylevels". 
The value should be an integer with default value as 0. This property should be 
under Ranger --> Configs --> Ranger User Info --> Group Configs tab.
This property can be enabled with a flag labelled as "Sync Nested Groups". 
1. Default value for this flag is "No"
2. This flag is always shown under Group Configs (even when "Enable group Sync" 
is set to "No")
3. If this flag is set to "No", then the value for 
ranger.usersync.ldap.grouphierarchylevels is hidden and is set to "0". 
4. If this flag is set to "Yes", then ranger.usersync.ldap.grouphierarchylevels 
is shown and allowed to set any integer greater than 0.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerUsersyncConfigCalculation.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
 627216e 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-ugsync-site.xml
 a994856 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
 8068a38 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 535ac2e 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
74271cc 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerUsersyncConfigCalculationTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62351/diff/3/

Changes: https://reviews.apache.org/r/62351/diff/2-3/


Testing
---

Test Fresh Installs.
Ambari upgrade with stack 2.6.
Unit Test passed for UpgradeCatalog260Test.


Thanks,

Mugdha Varadkar

Re: Review Request 62501: configs.py does not work properly when dealing with files

2017-09-22 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62501/#review185968
---


Ship it!




Ship It!

- Dmytro Sen


On Sept. 22, 2017, 11:02 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62501/
> ---
> 
> (Updated Sept. 22, 2017, 11:02 a.m.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-22040
> https://issues.apache.org/jira/browse/AMBARI-22040
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> configs.py is used by users and support folks for modifying
> configurations. While this works well for getting and setting individual
> properties, it does not work well for dealing with json files. This is needed
> for edits to *env.sh or stack_features.
> 
> _Current behavior_:
> 
>   * Exporting ams-grafana-env does not give a properly formatted json file
>   * Cannot use a get change the json and set it back.
> 
> The expected behavior is to let the user modify the json file and re-import it
> into the cluster.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/configs.py 639f28e 
>   ambari-server/src/main/resources/scripts/configs.sh 5fc96fd 
> 
> 
> Diff: https://reviews.apache.org/r/62501/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 62501: configs.py does not work properly when dealing with files

2017-09-22 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62501/
---

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-22040
https://issues.apache.org/jira/browse/AMBARI-22040


Repository: ambari


Description
---

configs.py is used by users and support folks for modifying
configurations. While this works well for getting and setting individual
properties, it does not work well for dealing with json files. This is needed
for edits to *env.sh or stack_features.

_Current behavior_:

  * Exporting ams-grafana-env does not give a properly formatted json file
  * Cannot use a get change the json and set it back.

The expected behavior is to let the user modify the json file and re-import it
into the cluster.


Diffs
-

  ambari-server/src/main/resources/scripts/configs.py 639f28e 
  ambari-server/src/main/resources/scripts/configs.sh 5fc96fd 


Diff: https://reviews.apache.org/r/62501/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 62500: File "hdfs.headless.keytab" has incorrect permission

2017-09-22 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62500/#review185966
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Сен. 22, 2017, 10:31 д.п., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62500/
> ---
> 
> (Updated Сен. 22, 2017, 10:31 д.п.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22039
> https://issues.apache.org/jira/browse/AMBARI-22039
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Actual result:** Zeppelin Notebook can not start due to file 
> "hdfs.headless.keytab" has incorrect permission.
> 
> 
> 
> -r. 1 cstm-hdfs hadoop 313 ??? 21 05:32 
> /etc/security/keytabs/hdfs.headless.keytab
> 
> 
> Changed permission by hands the Zeppelin Notebook successfully started.  
> Cluster:
> 
> 
> 
> 
> http://172.27.52.205:8080
> 
> 
> Job for reproduce :
> 
> 
> 
> 
> 
> http://linux-jenkins.qe.hortonworks.com:8080/job/Nightly-Start-EC2-Run-HDP/641939/
> 
> 
> Artifacts:
> 
> 
> 
> 
> 
> https://testqelog.s3.amazonaws.com/qelogs/index.html?prefix=qelogs/nat/65233/stackdeploy/split-1/nat-yc-r6o12-stackdeploy/
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  7d44d16 
> 
> 
> Diff: https://reviews.apache.org/r/62500/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 62500: File "hdfs.headless.keytab" has incorrect permission

2017-09-22 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62500/#review185965
---


Ship it!




Ship It!

- Dmytro Sen


On Sept. 22, 2017, 10:31 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62500/
> ---
> 
> (Updated Sept. 22, 2017, 10:31 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22039
> https://issues.apache.org/jira/browse/AMBARI-22039
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Actual result:** Zeppelin Notebook can not start due to file 
> "hdfs.headless.keytab" has incorrect permission.
> 
> 
> 
> -r. 1 cstm-hdfs hadoop 313 ??? 21 05:32 
> /etc/security/keytabs/hdfs.headless.keytab
> 
> 
> Changed permission by hands the Zeppelin Notebook successfully started.  
> Cluster:
> 
> 
> 
> 
> http://172.27.52.205:8080
> 
> 
> Job for reproduce :
> 
> 
> 
> 
> 
> http://linux-jenkins.qe.hortonworks.com:8080/job/Nightly-Start-EC2-Run-HDP/641939/
> 
> 
> Artifacts:
> 
> 
> 
> 
> 
> https://testqelog.s3.amazonaws.com/qelogs/index.html?prefix=qelogs/nat/65233/stackdeploy/split-1/nat-yc-r6o12-stackdeploy/
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  7d44d16 
> 
> 
> Diff: https://reviews.apache.org/r/62500/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 62500: File "hdfs.headless.keytab" has incorrect permission

2017-09-22 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62500/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-22039
https://issues.apache.org/jira/browse/AMBARI-22039


Repository: ambari


Description
---

**Actual result:** Zeppelin Notebook can not start due to file 
"hdfs.headless.keytab" has incorrect permission.



-r. 1 cstm-hdfs hadoop 313 ??? 21 05:32 
/etc/security/keytabs/hdfs.headless.keytab


Changed permission by hands the Zeppelin Notebook successfully started.  
Cluster:




http://172.27.52.205:8080


Job for reproduce :





http://linux-jenkins.qe.hortonworks.com:8080/job/Nightly-Start-EC2-Run-HDP/641939/


Artifacts:





https://testqelog.s3.amazonaws.com/qelogs/index.html?prefix=qelogs/nat/65233/stackdeploy/split-1/nat-yc-r6o12-stackdeploy/


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 7d44d16 


Diff: https://reviews.apache.org/r/62500/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 62499: Log Search UI: implement application of selected text to service logs filters

2017-09-22 Thread Aleksandr Kovalenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62499/#review185963
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Сен. 22, 2017, 10:17 д.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62499/
> ---
> 
> (Updated Сен. 22, 2017, 10:17 д.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-22038
> https://issues.apache.org/jira/browse/AMBARI-22038
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should be able to add or exclude selected part of log message to filter 
> query.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts acf1b9f 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts
>  42b9451 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.html
>  1baebed 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.ts
>  3de664e 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts
>  9940d73 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html
>  dc76e79 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts
>  72ab222 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html
>  29a85c5 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less
>  584c1a7 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts
>  a081e1b 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts
>  65f0ee6 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.ts
>  b674ec6 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts
>  4730190 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 
> 627dc27 
>   ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 1235a80 
>   ambari-logsearch/ambari-logsearch-web/src/polyfills.ts 0ab921a 
> 
> 
> Diff: https://reviews.apache.org/r/62499/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 86 of 86 SUCCESS (2.094 secs / 2.08 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Review Request 62499: Log Search UI: implement application of selected text to service logs filters

2017-09-22 Thread Andrii Babiichuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62499/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-22038
https://issues.apache.org/jira/browse/AMBARI-22038


Repository: ambari


Description
---

User should be able to add or exclude selected part of log message to filter 
query.


Diffs
-

  ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts acf1b9f 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts 
PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts
 42b9451 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.html
 1baebed 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.ts
 3de664e 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts
 9940d73 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html
 dc76e79 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts
 72ab222 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html
 29a85c5 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less
 584c1a7 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts
 a081e1b 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts
 65f0ee6 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.ts
 b674ec6 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts
 4730190 
  ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 
627dc27 
  ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 1235a80 
  ambari-logsearch/ambari-logsearch-web/src/polyfills.ts 0ab921a 


Diff: https://reviews.apache.org/r/62499/diff/1/


Testing
---

Executed 86 of 86 SUCCESS (2.094 secs / 2.08 secs)


Thanks,

Andrii Babiichuk

Re: Review Request 62497: Log Search UI: host filter should be performed using hostList parameter

2017-09-22 Thread Oleg Nechiporenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62497/#review185958
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Сен. 22, 2017, 8:58 д.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62497/
> ---
> 
> (Updated Сен. 22, 2017, 8:58 д.п.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-22037
> https://issues.apache.org/jira/browse/AMBARI-22037
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hosts should be filtered using ```hostList``` request parameter instead of 
> ```host_name```, since it doesn't support conditions for multiple selection.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts
>  ef8cf28 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts
>  572af03 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.class.ts
>  c88ec46 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 
> 718149e 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts
>  a90d099 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/mock-api-data.service.ts
>  ec89d9f 
>   ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json e3f4c69 
> 
> 
> Diff: https://reviews.apache.org/r/62497/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 86 of 86 SUCCESS (1.902 secs / 1.883 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Review Request 62497: Log Search UI: host filter should be performed using hostList parameter

2017-09-22 Thread Andrii Babiichuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62497/
---

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-22037
https://issues.apache.org/jira/browse/AMBARI-22037


Repository: ambari


Description
---

Hosts should be filtered using ```hostList``` request parameter instead of 
```host_name```, since it doesn't support conditions for multiple selection.


Diffs
-

  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts
 ef8cf28 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts
 572af03 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.class.ts
 c88ec46 
  ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 
718149e 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts
 a90d099 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/mock-api-data.service.ts 
ec89d9f 
  ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json e3f4c69 


Diff: https://reviews.apache.org/r/62497/diff/1/


Testing
---

Executed 86 of 86 SUCCESS (1.902 secs / 1.883 secs)


Thanks,

Andrii Babiichuk

Re: Review Request 62461: Livy not working with the default configuration

2017-09-22 Thread Jeff Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62461/#review185949
---


Ship it!




Ship It!

- Jeff Zhang


On Sept. 21, 2017, 1 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62461/
> ---
> 
> (Updated Sept. 21, 2017, 1 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22021
> https://issues.apache.org/jira/browse/AMBARI-22021
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This started failing with ZEPPELIN-2909, which introduces `"className": 
> "org.apache.zeppelin.livy.LivySharedInterpreter"` and now Livy fails with 
> following exception;
> 
> 
> java.lang.NullPointerException
>   at 
> org.apache.zeppelin.livy.BaseLivyInterpreter.open(BaseLivyInterpreter.java:109)
>   at 
> org.apache.zeppelin.interpreter.LazyOpenInterpreter.open(LazyOpenInterpreter.java:69)
>   at 
> org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:493)
>   at org.apache.zeppelin.scheduler.Job.run(Job.java:175)
>   at 
> org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
>  6a9891972b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
>  71d381705a 
> 
> 
> Diff: https://reviews.apache.org/r/62461/diff/3/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62461: Livy not working with the default configuration

2017-09-22 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62461/#review185948
---


Ship it!




Ship It!

- venkat sairam


On Sept. 21, 2017, 1 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62461/
> ---
> 
> (Updated Sept. 21, 2017, 1 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22021
> https://issues.apache.org/jira/browse/AMBARI-22021
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This started failing with ZEPPELIN-2909, which introduces `"className": 
> "org.apache.zeppelin.livy.LivySharedInterpreter"` and now Livy fails with 
> following exception;
> 
> 
> java.lang.NullPointerException
>   at 
> org.apache.zeppelin.livy.BaseLivyInterpreter.open(BaseLivyInterpreter.java:109)
>   at 
> org.apache.zeppelin.interpreter.LazyOpenInterpreter.open(LazyOpenInterpreter.java:69)
>   at 
> org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:493)
>   at org.apache.zeppelin.scheduler.Job.run(Job.java:175)
>   at 
> org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
>  6a9891972b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
>  71d381705a 
> 
> 
> Diff: https://reviews.apache.org/r/62461/diff/3/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>