Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Madhuvanthi Radhakrishnan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/
---

(Updated Sept. 30, 2017, 5:31 a.m.)


Review request for Ambari, Jayush Luniya and Swapan Shridhar.


Changes
---

Review comment


Bugs: AMBARI-22100
https://issues.apache.org/jira/browse/AMBARI-22100


Repository: ambari


Description
---

Change temp directory for jceks file from service level to component level.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
8a433c83f4 


Diff: https://reviews.apache.org/r/62699/diff/3/

Changes: https://reviews.apache.org/r/62699/diff/2-3/


Testing
---

Ambari-2.6
HDP-2.6.0.0
Deploy Hive
Deploy Oozie

[root@storm-simple-patch-madhu-2 conf]# pwd
/var/lib/ambari-agent/cred/conf
[root@storm-simple-patch-madhu-2 conf]# ls
hive_metastore  hive_server  mysql_server  oozie_client  oozie_server

Run service checks


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/#review186778
---




ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py
Lines 284 (patched)


Need to check if 'role' is in commandJson first.

if 'role' in commandJson:
  roleName = commandJson['role']
  file_path = os.path.join(self.getProviderDirectory(roleName), 
"{0}.jceks".format(config_type))


- Jayush Luniya


On Sept. 30, 2017, 5:03 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62699/
> ---
> 
> (Updated Sept. 30, 2017, 5:03 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22100
> https://issues.apache.org/jira/browse/AMBARI-22100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change temp directory for jceks file from service level to component level.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8a433c83f4 
> 
> 
> Diff: https://reviews.apache.org/r/62699/diff/2/
> 
> 
> Testing
> ---
> 
> Ambari-2.6
> HDP-2.6.0.0
> Deploy Hive
> Deploy Oozie
> 
> [root@storm-simple-patch-madhu-2 conf]# pwd
> /var/lib/ambari-agent/cred/conf
> [root@storm-simple-patch-madhu-2 conf]# ls
> hive_metastore  hive_server  mysql_server  oozie_client  oozie_server
> 
> Run service checks
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62694: Entries related to hive query are found in RM UI after killing or stopping the execution of the query.

2017-09-29 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62694/#review186776
---


Ship it!




Ship It!

- Nitiraj Rathore


On Sept. 29, 2017, 5:05 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62694/
> ---
> 
> (Updated Sept. 29, 2017, 5:05 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-22096
> https://issues.apache.org/jira/browse/AMBARI-22096
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ember data API changes are made and the exceptions on JS side are handled
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 291c335 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 36abf49 
> 
> 
> Diff: https://reviews.apache.org/r/62694/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Madhuvanthi Radhakrishnan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/
---

(Updated Sept. 30, 2017, 5:03 a.m.)


Review request for Ambari, Jayush Luniya and Swapan Shridhar.


Changes
---

Review comments


Bugs: AMBARI-22100
https://issues.apache.org/jira/browse/AMBARI-22100


Repository: ambari


Description
---

Change temp directory for jceks file from service level to component level.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
8a433c83f4 


Diff: https://reviews.apache.org/r/62699/diff/2/

Changes: https://reviews.apache.org/r/62699/diff/1-2/


Testing (updated)
---

Ambari-2.6
HDP-2.6.0.0
Deploy Hive
Deploy Oozie

[root@storm-simple-patch-madhu-2 conf]# pwd
/var/lib/ambari-agent/cred/conf
[root@storm-simple-patch-madhu-2 conf]# ls
hive_metastore  hive_server  mysql_server  oozie_client  oozie_server

Run service checks


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 62694: Entries related to hive query are found in RM UI after killing or stopping the execution of the query.

2017-09-29 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62694/#review186775
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Sept. 29, 2017, 5:05 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62694/
> ---
> 
> (Updated Sept. 29, 2017, 5:05 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-22096
> https://issues.apache.org/jira/browse/AMBARI-22096
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ember data API changes are made and the exceptions on JS side are handled
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 291c335 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 36abf49 
> 
> 
> Diff: https://reviews.apache.org/r/62694/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 62688: AMBARI-22092. Blueprint cluster creation constantly throwing exceptions

2017-09-29 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62688/#review186766
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 29, 2017, 10:30 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62688/
> ---
> 
> (Updated Sept. 29, 2017, 10:30 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Jonathan Hurley, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-22092
> https://issues.apache.org/jira/browse/AMBARI-22092
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Improved logging in `AsyncCallableService`:
>  * Add task name to all log messages, since it is a generic service (although 
> currently only used for a single task).
>  * Introduced new "marker" exception to indicate that task should be retried 
> silently, without logging the exception.
>  * `TimeoutException` is not an error, no need to log with stack trace, 
> timeout is logged anyway.
>  * For other exceptions peel off the `ExecutionException` that the executor 
> framework wraps the actual exception in to reduce verboseness.
> 
> Improved host group-related messages:
>  * Warn if a host group is completely missing.
>  * Log completion of each host group only once.
>  * Log host groups still waiting for more hosts only once for each host count 
> (eg. log when waiting for 3 hosts, then only when waiting for 2 more hosts).
> 
> Minor bug fixes:
>  * `AsyncCallableService.timeout` is the total time allowed for repeated task 
> execution.  Hence, timeout for subsequent attempts (of `future.get()`) needs 
> to be reduced by the time passed since the task's initial attempt.
>  * `verify()` is a no-op (expects mocks as arg), `verifyAll()` was intended 
> to be called.
> 
> Moved timeout config logic to `ConfigureClusterTask`.
> Misc code cleanup.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AsyncCallableService.java
>  9a68ea7cd9ee62250fde33ceb0cf2b65b57ae883 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  9769fae4b851d8bdf908c2917d7af57ff0ea061e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/tasks/ConfigureClusterTask.java
>  60eaa591b9ac3b3ffa417d5c5d84144d4e68d9d1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/AsyncCallableServiceTest.java
>  4d962949400485f4d846d87ad74059e0c7eeb9df 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
>  0daa20fc5e8d1a55818840407aff9ebd1703cf5c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
>  bbf4fdbf01b6498c897093c0efd7a0957e041975 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  059a8be735e193fe523a32df945a7566dfc22dc7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigureClusterTaskTest.java
>  b2dac8f01a817a1f9b0ee6f02a976cdd3304fd94 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  ac643d7c661a1bcb8a0400bff94aeb257aec4101 
> 
> 
> Diff: https://reviews.apache.org/r/62688/diff/2/
> 
> 
> Testing
> ---
> 
> * Manually on cluster with Ambari 2.6: successful completion, successful on 
> retries and timeout.
> * Unit tests (modified ones are OK; result of the rest is pending)
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/#review186753
---




ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py
Line 284 (original), 284 (patched)


Will role ever be null? I am thinking about service checks etc. Might want 
to add service_name as fall back just in case.


- Jayush Luniya


On Sept. 29, 2017, 10:14 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62699/
> ---
> 
> (Updated Sept. 29, 2017, 10:14 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22100
> https://issues.apache.org/jira/browse/AMBARI-22100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change temp directory for jceks file from service level to component level.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8a433c83f4 
> 
> 
> Diff: https://reviews.apache.org/r/62699/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/#review186751
---


Ship it!




Ship It!

- Swapan Shridhar


On Sept. 29, 2017, 10:14 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62699/
> ---
> 
> (Updated Sept. 29, 2017, 10:14 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22100
> https://issues.apache.org/jira/browse/AMBARI-22100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change temp directory for jceks file from service level to component level.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8a433c83f4 
> 
> 
> Diff: https://reviews.apache.org/r/62699/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Madhuvanthi Radhakrishnan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/
---

Review request for Ambari, Jayush Luniya and Swapan Shridhar.


Bugs: AMBARI-22100
https://issues.apache.org/jira/browse/AMBARI-22100


Repository: ambari


Description
---

Change temp directory for jceks file from service level to component level.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
8a433c83f4 


Diff: https://reviews.apache.org/r/62699/diff/1/


Testing
---


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 62599: Remove user to group hardcoded logic in hooks

2017-09-29 Thread Madhuvanthi Radhakrishnan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62599/#review186499
---


Ship it!




- Madhuvanthi Radhakrishnan


On Sept. 27, 2017, 9:52 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62599/
> ---
> 
> (Updated Sept. 27, 2017, 9:52 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22068
> https://issues.apache.org/jira/browse/AMBARI-22068
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We added feature to tag a user property with corresponding user-group 
> properties to which a user should be added. We no longer should need the 
> hardcoded logic in the hooks adding users to groups. This can be entirely 
> stack driven after we update the user config properties for all services.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
>  e4aa21e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
>  52a5e6a 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4d33661 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
>  74d8600 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml
>  f97ca98 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  23b82e3 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  f45199f 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml
>  ccbda1e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
>  6393659 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml
>  733ca8b 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
>  bb671cc 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  e292e6e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  b2c364c 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  54a62e2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml
>  90ba1c8 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  ad81d66 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml
>  680e81f 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/configuration/knox-env.xml
>  e1ca45a 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  e861b6e 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-env.xml
>  b2d60c6 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
>  7748176 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-env.xml
>  0f67356 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml
>  cc62c8b 
>   
> ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/configuration/ranger-env.xml
>  ff44901 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml
>  e5c0673 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/configuration/kms-env.xml
>  acecdfe 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  55d67cc 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/configuration/livy-env.xml
>  cec8054 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/configuration/spark-env.xml
>  f980f9a 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  35d364f 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml
>  d9d548d 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.3.0/configuration/sqoop-env.xml
>  6e16ab33 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
>  3d4edad 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/configuration/storm-env.xml
>  3ee0602 
>   
> ambari-server/src/main/resources

Review Request 62694: Entries related to hive query are found in RM UI after killing or stopping the execution of the query.

2017-09-29 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62694/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-22096
https://issues.apache.org/jira/browse/AMBARI-22096


Repository: ambari


Description
---

Ember data API changes are made and the exceptions on JS side are handled


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
291c335 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 36abf49 


Diff: https://reviews.apache.org/r/62694/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 62675: Wrong Hadoop Home Directory Is Being Picked Up on MAINT/PATCH Upgraded Clusters

2017-09-29 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62675/#review186678
---


Ship it!




Ship It!

- Nate Cole


On Sept. 28, 2017, 2:27 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62675/
> ---
> 
> (Updated Sept. 28, 2017, 2:27 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-22083
> https://issues.apache.org/jira/browse/AMBARI-22083
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> - Install HDP 2.6.0.0 with HDFS and YARN/MapR
> - Perform a MAINT upgrade of HDFS to 2.6.3.0
> - Stop all services
> - Restart all services
> 
> The following is observed:
> - {{/usr/hdp/current/hadoop-client -> /usr/hdp/2.6.0.0/hadoop}}
> - HDFS picks up 2.6.0.0
> - YARN/MapR pick up 2.6.0.0
> 
> The upgraded components should pickup the version of the hadoop home 
> directory that is theirs.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/component_version.py
>  a1fd6b2e7c 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  ffcaad5cbc 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  f5068e4295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  0042f53c7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
> 5dec53c32f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py
>  12c9e1cc15 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  77e1bed96f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  f5b00aca5f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  7f5eff61d4 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/after-INSTALL/scripts/params.py
>  d3332db3af 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-ANY/scripts/params.py
>  5ffd28ca94 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-START/scripts/params.py
>  5c84a05b0d 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/after-INSTALL/scripts/params.py
>  c4970543d6 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/before-ANY/scripts/params.py
>  b0467a9a75 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/before-START/scripts/params.py
>  be9db58fef 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
>  4d7eaee3b9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  e0852256db 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
>  3997117ade 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  5ca2d94403 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/ECS/package/scripts/params.py
>  c304a93b5e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> 135b239b32 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 4ade11a1a2 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 972aa61116 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 24b0347c0d 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py ae51abf95c 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 0ce6282c89 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 
> 30e76ef14d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> ded4d45e14 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 
> 943c20149b 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> a5dac6c3fe 
>   
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_service_check.py 
> 468f6024f6 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 50b658311d 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 
> 75eff39bda 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py
>  48498be3e2 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py
>  9dceb69fee 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 239e2b5492 
>   ambari-serv

Re: Review Request 62688: AMBARI-22092. Blueprint cluster creation constantly throwing exceptions

2017-09-29 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62688/
---

(Updated Sept. 29, 2017, 4:30 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Jonathan Hurley, 
and Sandor Magyari.


Changes
---

fixed 3 unit tests


Bugs: AMBARI-22092
https://issues.apache.org/jira/browse/AMBARI-22092


Repository: ambari


Description
---

Improved logging in `AsyncCallableService`:
 * Add task name to all log messages, since it is a generic service (although 
currently only used for a single task).
 * Introduced new "marker" exception to indicate that task should be retried 
silently, without logging the exception.
 * `TimeoutException` is not an error, no need to log with stack trace, timeout 
is logged anyway.
 * For other exceptions peel off the `ExecutionException` that the executor 
framework wraps the actual exception in to reduce verboseness.

Improved host group-related messages:
 * Warn if a host group is completely missing.
 * Log completion of each host group only once.
 * Log host groups still waiting for more hosts only once for each host count 
(eg. log when waiting for 3 hosts, then only when waiting for 2 more hosts).

Minor bug fixes:
 * `AsyncCallableService.timeout` is the total time allowed for repeated task 
execution.  Hence, timeout for subsequent attempts (of `future.get()`) needs to 
be reduced by the time passed since the task's initial attempt.
 * `verify()` is a no-op (expects mocks as arg), `verifyAll()` was intended to 
be called.

Moved timeout config logic to `ConfigureClusterTask`.
Misc code cleanup.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/AsyncCallableService.java
 9a68ea7cd9ee62250fde33ceb0cf2b65b57ae883 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 9769fae4b851d8bdf908c2917d7af57ff0ea061e 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/tasks/ConfigureClusterTask.java
 60eaa591b9ac3b3ffa417d5c5d84144d4e68d9d1 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/AsyncCallableServiceTest.java
 4d962949400485f4d846d87ad74059e0c7eeb9df 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
 0daa20fc5e8d1a55818840407aff9ebd1703cf5c 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
 bbf4fdbf01b6498c897093c0efd7a0957e041975 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
 059a8be735e193fe523a32df945a7566dfc22dc7 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigureClusterTaskTest.java
 b2dac8f01a817a1f9b0ee6f02a976cdd3304fd94 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
 ac643d7c661a1bcb8a0400bff94aeb257aec4101 


Diff: https://reviews.apache.org/r/62688/diff/2/

Changes: https://reviews.apache.org/r/62688/diff/1-2/


Testing
---

* Manually on cluster with Ambari 2.6: successful completion, successful on 
retries and timeout.
* Unit tests (modified ones are OK; result of the rest is pending)


Thanks,

Attila Doroszlai

Re: Review Request 62688: AMBARI-22092. Blueprint cluster creation constantly throwing exceptions

2017-09-29 Thread Sandor Magyari 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62688/#review186672
---


Ship it!




Ship It!

- Sandor Magyari


On Sept. 29, 2017, 1:06 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62688/
> ---
> 
> (Updated Sept. 29, 2017, 1:06 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Jonathan Hurley, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-22092
> https://issues.apache.org/jira/browse/AMBARI-22092
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Improved logging in `AsyncCallableService`:
>  * Add task name to all log messages, since it is a generic service (although 
> currently only used for a single task).
>  * Introduced new "marker" exception to indicate that task should be retried 
> silently, without logging the exception.
>  * `TimeoutException` is not an error, no need to log with stack trace, 
> timeout is logged anyway.
>  * For other exceptions peel off the `ExecutionException` that the executor 
> framework wraps the actual exception in to reduce verboseness.
> 
> Improved host group-related messages:
>  * Warn if a host group is completely missing.
>  * Log completion of each host group only once.
>  * Log host groups still waiting for more hosts only once for each host count 
> (eg. log when waiting for 3 hosts, then only when waiting for 2 more hosts).
> 
> Minor bug fixes:
>  * `AsyncCallableService.timeout` is the total time allowed for repeated task 
> execution.  Hence, timeout for subsequent attempts (of `future.get()`) needs 
> to be reduced by the time passed since the task's initial attempt.
>  * `verify()` is a no-op (expects mocks as arg), `verifyAll()` was intended 
> to be called.
> 
> Moved timeout config logic to `ConfigureClusterTask`.
> Misc code cleanup.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AsyncCallableService.java
>  9a68ea7cd9ee62250fde33ceb0cf2b65b57ae883 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  9769fae4b851d8bdf908c2917d7af57ff0ea061e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/tasks/ConfigureClusterTask.java
>  60eaa591b9ac3b3ffa417d5c5d84144d4e68d9d1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/AsyncCallableServiceTest.java
>  4d962949400485f4d846d87ad74059e0c7eeb9df 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigureClusterTaskTest.java
>  b2dac8f01a817a1f9b0ee6f02a976cdd3304fd94 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  ac643d7c661a1bcb8a0400bff94aeb257aec4101 
> 
> 
> Diff: https://reviews.apache.org/r/62688/diff/1/
> 
> 
> Testing
> ---
> 
> * Manually on cluster with Ambari 2.6: successful completion, successful on 
> retries and timeout.
> * Unit tests (modified ones are OK; result of the rest is pending)
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62675: Wrong Hadoop Home Directory Is Being Picked Up on MAINT/PATCH Upgraded Clusters

2017-09-29 Thread Nate Cole 


> On Sept. 29, 2017, 3:18 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java
> > Lines 43 (patched)
> > 
> >
> > How it differs from componentName?
> 
> Jonathan Hurley wrote:
> It doesn't - normal execution commands use "role" but status commands use 
> "componentName". I actually prefer "componentName", but maybe we did this 
> because a "role" could also not be a component name. 
> 
> However, the Python code would just get more complicated if we have to 
> start double-checking for componentName & role everywhere, so I just decided 
> to make it easy and add it to this command as well. I'll doc this so others 
> understand why it was added.

It's fine for python code to make this easier, but why not just set "role" (the 
field) when setting componentName?  That way at least the java side stays 
"pure" without having to remember to set both (even though it looks like 
there's just one setter call).


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62675/#review186647
---


On Sept. 28, 2017, 2:27 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62675/
> ---
> 
> (Updated Sept. 28, 2017, 2:27 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-22083
> https://issues.apache.org/jira/browse/AMBARI-22083
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> - Install HDP 2.6.0.0 with HDFS and YARN/MapR
> - Perform a MAINT upgrade of HDFS to 2.6.3.0
> - Stop all services
> - Restart all services
> 
> The following is observed:
> - {{/usr/hdp/current/hadoop-client -> /usr/hdp/2.6.0.0/hadoop}}
> - HDFS picks up 2.6.0.0
> - YARN/MapR pick up 2.6.0.0
> 
> The upgraded components should pickup the version of the hadoop home 
> directory that is theirs.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/component_version.py
>  a1fd6b2e7c 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  ffcaad5cbc 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  f5068e4295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  0042f53c7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
> 5dec53c32f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  77e1bed96f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/after-INSTALL/scripts/params.py
>  d3332db3af 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-ANY/scripts/params.py
>  5ffd28ca94 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-START/scripts/params.py
>  5c84a05b0d 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/after-INSTALL/scripts/params.py
>  c4970543d6 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/before-ANY/scripts/params.py
>  b0467a9a75 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/before-START/scripts/params.py
>  be9db58fef 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
>  4d7eaee3b9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  1fd7f3ef76 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
>  3997117ade 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  5ca2d94403 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/ECS/package/scripts/params.py
>  c304a93b5e 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py
>  9dceb69fee 
> 
> 
> Diff: https://reviews.apache.org/r/62675/diff/1/
> 
> 
> Testing
> ---
> 
> End-to-End manual tests
> Lots of Python test fixes PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for alert definitions

2017-09-29 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/
---

(Updated Sept. 29, 2017, 3:39 p.m.)


Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor 
Magyari, Sebastian Toader, and Sid Wagle.


Changes
---

rebased after merge


Bugs: AMBARI-21803
https://issues.apache.org/jira/browse/AMBARI-21803


Repository: ambari


Description
---

* Added endpoint
* Created data structure to match expected JSON format
* Added @JsonProperty for all attributes (to explicitly specify names)
* Added @JsonInclude to avoid null values
* Extracted some common logic to parent classes
* Clarified `HostNotRegisteredException`
* Simplified some `equals()`/`hashCode()` methods
* Simplified map operations in `AgentSessionManager`
* Handle alert report with reduced content (no service/component names)


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py 
d3ab48e4da79cc7615bd5dedfec3754ffe5accc2 
  ambari-agent/src/main/python/ambari_agent/Constants.py 
4c0b01bdd664e23581c5c6a494bd20a2c8314058 
  
ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py
 494d0f3e9a21608d9bd3e5922309a7c013fd333e 
  
ambari-server/src/main/java/org/apache/ambari/server/HostNotRegisteredException.java
 9e7b3a7efbfe09bdfa8d1dc0203d9370da881cb1 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/AgentSessionManager.java
 1f64fc1d2800fa2b1a1c6d82a2ca855f9e30bbca 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java
 a4324ee9a23f86e1d99a441a2c49383282786aa2 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java
 0f0a4919ba7e1343c31c8397d5309542c2463287 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java
 0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java
 7035f38cfbb7a75bd4cb5721a542ef832a805c99 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java
 635611bf6d325deb33cde671556647b9c264a716 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java
 792f10ef33363fd57579792f51901681ad83aa0b 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java
 3d17ef2079049de49c5b64682a04a3578847d8d3 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java
 b7e680627f3fd42e87b7152f9ab9de29f63a44fa 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java
 0da5d831d546da98e2284b048b914f972cacfc05 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java
 3ee5ad6d00b4c4374cba48e80d1cb410500ee586 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/spring/ApiStompConfig.java
 170fa1704cd86c39db629aa74c54114d56b766dd 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java
 640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java
 e820401d460bc672596a4ede60abcd39646be49e 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java
 cbe6e3703960ce0af9563f41b63d2a71427b4267 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AmbariUpdateEvent.java
 90aa704ba1530cd77a13b77db5183f398a4f659e 
  
ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java
 66ab38ea39bea2c100a2245ad422a4c6a037d7ed 
  
ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java
 239b5b8184a02a057c2dc9d4a53c671dc06d9806 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentInstalledEvent.java
 0ba4ac2ee5d42d5bae3ca1ff6da6e35bb8d06fc8 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java
 8acc401c8367909944c8d38deda2cd8b5b6fe2a9 
  
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java
 1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a 
  
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java
 1b5b90b562babe4cea18a1bd93104d72922d31fa 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
 257e2fffe325eabfe4773445b0d3bb36d2c59729 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/requests/StateUpdateListener.java
 27af7178c497f8ac171b4c788a966cfcb6de9278 
  
ambar

Re: Review Request 62666: Upgrade Yarn version for Logsearch Web

2017-09-29 Thread Andrii Babiichuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62666/#review186669
---


Ship it!




Ship It!

- Andrii Babiichuk


On Вер. 28, 2017, 3:13 після полудня, Istvan Tobias wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62666/
> ---
> 
> (Updated Вер. 28, 2017, 3:13 після полудня)
> 
> 
> Review request for Ambari, Andrii Babiichuk and Oliver Szabo.
> 
> 
> Bugs: AMBARI-22079
> https://issues.apache.org/jira/browse/AMBARI-22079
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updating the package.json to use the latest node (8.6.0 - npm: 5.4.2) and 
> yarn (1.1.0). Upgraded maven pom file to use latest version of frontend 
> plugin.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/package.json 7cf636f73a 
>   ambari-logsearch/ambari-logsearch-web/pom.xml f27c2c6f7b 
>   ambari-logsearch/ambari-logsearch-web/yarn.lock c55bb4d279 
> 
> 
> Diff: https://reviews.apache.org/r/62666/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:31 min
> [INFO] Finished at: 2017-09-28T17:06:10+02:00
> [INFO] Final Memory: 17M/58M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Istvan Tobias
> 
>

Review Request 62688: AMBARI-22092. Blueprint cluster creation constantly throwing exceptions

2017-09-29 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62688/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Jonathan Hurley, 
and Sandor Magyari.


Bugs: AMBARI-22092
https://issues.apache.org/jira/browse/AMBARI-22092


Repository: ambari


Description
---

Improved logging in `AsyncCallableService`:
 * Add task name to all log messages, since it is a generic service (although 
currently only used for a single task).
 * Introduced new "marker" exception to indicate that task should be retried 
silently, without logging the exception.
 * `TimeoutException` is not an error, no need to log with stack trace, timeout 
is logged anyway.
 * For other exceptions peel off the `ExecutionException` that the executor 
framework wraps the actual exception in to reduce verboseness.

Improved host group-related messages:
 * Warn if a host group is completely missing.
 * Log completion of each host group only once.
 * Log host groups still waiting for more hosts only once for each host count 
(eg. log when waiting for 3 hosts, then only when waiting for 2 more hosts).

Minor bug fixes:
 * `AsyncCallableService.timeout` is the total time allowed for repeated task 
execution.  Hence, timeout for subsequent attempts (of `future.get()`) needs to 
be reduced by the time passed since the task's initial attempt.
 * `verify()` is a no-op (expects mocks as arg), `verifyAll()` was intended to 
be called.

Moved timeout config logic to `ConfigureClusterTask`.
Misc code cleanup.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/AsyncCallableService.java
 9a68ea7cd9ee62250fde33ceb0cf2b65b57ae883 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 9769fae4b851d8bdf908c2917d7af57ff0ea061e 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/tasks/ConfigureClusterTask.java
 60eaa591b9ac3b3ffa417d5c5d84144d4e68d9d1 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/AsyncCallableServiceTest.java
 4d962949400485f4d846d87ad74059e0c7eeb9df 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigureClusterTaskTest.java
 b2dac8f01a817a1f9b0ee6f02a976cdd3304fd94 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
 ac643d7c661a1bcb8a0400bff94aeb257aec4101 


Diff: https://reviews.apache.org/r/62688/diff/1/


Testing
---

* Manually on cluster with Ambari 2.6: successful completion, successful on 
retries and timeout.
* Unit tests (modified ones are OK; result of the rest is pending)


Thanks,

Attila Doroszlai

Re: Review Request 62689: Log Search UI: implement service logs actions functionality

2017-09-29 Thread Oleg Nechiporenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62689/#review186665
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Сен. 29, 2017, 12:49 п.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62689/
> ---
> 
> (Updated Сен. 29, 2017, 12:49 п.п.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-22093
> https://issues.apache.org/jira/browse/AMBARI-22093
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Implement Copy, Open Log and Context actions for logs list entries.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c4dc698 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.class.ts
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts 
> adb023b 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts
>  e36bf18 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.class.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.class.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.html
>  9536573 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts
>  f7227b1 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.html
>  316d3f9 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts
>  eacac04 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.ts
>  82656cf 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts
>  a01a3f3 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts
>  85e7ecb 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts
>  ae5a4af 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.html
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.less
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.html
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.less
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html
>  5145b76 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.spec.ts
>  811c6e6 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts
>  b1fad17 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html
>  2942b20 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less
>  577043f 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.spec.ts
>  8c67a13 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts
>  aeb55da 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.html
>  69b3887 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.less
>  9736628 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.spec.ts
>  42fba68 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.ts
>  53d58cf 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts
>  f92961e 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.c

Review Request 62689: Log Search UI: implement service logs actions functionality

2017-09-29 Thread Andrii Babiichuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62689/
---

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-22093
https://issues.apache.org/jira/browse/AMBARI-22093


Repository: ambari


Description
---

Implement Copy, Open Log and Context actions for logs list entries.


Diffs
-

  ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c4dc698 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.class.ts
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts 
adb023b 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts
 e36bf18 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.class.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.class.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.html
 9536573 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts
 f7227b1 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.html
 316d3f9 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts
 eacac04 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.ts
 82656cf 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts
 a01a3f3 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts
 85e7ecb 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts
 ae5a4af 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.html
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.less
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.html
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.less
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html
 5145b76 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.spec.ts
 811c6e6 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts
 b1fad17 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html
 2942b20 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less
 577043f 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.spec.ts
 8c67a13 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts
 aeb55da 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.html
 69b3887 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.less
 9736628 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.spec.ts
 42fba68 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.ts
 53d58cf 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts
 f92961e 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.component.spec.ts
 7d1e907 
  ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less 
88b0c91 
  ambari-logsearch/ambari-logsearch-web/src/app/models/app-state.model.ts 
28ae763 
  ambari-logsearch/ambari-logsearch-web/src/app/models/bar-graph.model.ts 
a197bf5 
  ambari-logsearch/ambari-logsearch-web/src/app/models/graph.model.ts 04966b2 
  ambari-logsearch/ambari-logsearch-web/src/app/models/log.model.ts 188bbd2 
  ambari-logsearch/ambari-logsearch-web/src/app/models/store.model.ts 31d52b3 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.spec.ts
 e737155 
  
ambari-l

Re: Review Request 62675: Wrong Hadoop Home Directory Is Being Picked Up on MAINT/PATCH Upgraded Clusters

2017-09-29 Thread Jonathan Hurley 


> On Sept. 29, 2017, 3:18 a.m., Dmitro Lisnichenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
> > Line 220 (original), 222 (patched)
> > 
> >
> > looks like doc is unfinished

Thanks - I usually go through my comments on patches like this once the unit 
tests are working again. I'll make sure to address this.


> On Sept. 29, 2017, 3:18 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java
> > Lines 43 (patched)
> > 
> >
> > How it differs from componentName?

It doesn't - normal execution commands use "role" but status commands use 
"componentName". I actually prefer "componentName", but maybe we did this 
because a "role" could also not be a component name. 

However, the Python code would just get more complicated if we have to start 
double-checking for componentName & role everywhere, so I just decided to make 
it easy and add it to this command as well. I'll doc this so others understand 
why it was added.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62675/#review186647
---


On Sept. 28, 2017, 2:27 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62675/
> ---
> 
> (Updated Sept. 28, 2017, 2:27 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-22083
> https://issues.apache.org/jira/browse/AMBARI-22083
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> - Install HDP 2.6.0.0 with HDFS and YARN/MapR
> - Perform a MAINT upgrade of HDFS to 2.6.3.0
> - Stop all services
> - Restart all services
> 
> The following is observed:
> - {{/usr/hdp/current/hadoop-client -> /usr/hdp/2.6.0.0/hadoop}}
> - HDFS picks up 2.6.0.0
> - YARN/MapR pick up 2.6.0.0
> 
> The upgraded components should pickup the version of the hadoop home 
> directory that is theirs.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/component_version.py
>  a1fd6b2e7c 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  ffcaad5cbc 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  f5068e4295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  0042f53c7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
> 5dec53c32f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  77e1bed96f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/after-INSTALL/scripts/params.py
>  d3332db3af 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-ANY/scripts/params.py
>  5ffd28ca94 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-START/scripts/params.py
>  5c84a05b0d 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/after-INSTALL/scripts/params.py
>  c4970543d6 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/before-ANY/scripts/params.py
>  b0467a9a75 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/before-START/scripts/params.py
>  be9db58fef 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
>  4d7eaee3b9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  1fd7f3ef76 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
>  3997117ade 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  5ca2d94403 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/ECS/package/scripts/params.py
>  c304a93b5e 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py
>  9dceb69fee 
> 
> 
> Diff: https://reviews.apache.org/r/62675/diff/1/
> 
> 
> Testing
> ---
> 
> End-to-End manual tests
> Lots of Python test fixes PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62683: Hive view2.0 Jobs worksheets doesn't have hyperlink whereas view1.5 History worksheets had hyperlinks pointing to fetched results

2017-09-29 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62683/#review186662
---


Ship it!




Ship It!

- Nitiraj Rathore


On Sept. 29, 2017, 4:37 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62683/
> ---
> 
> (Updated Sept. 29, 2017, 4:37 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-22091
> https://issues.apache.org/jira/browse/AMBARI-22091
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provided hyper link in jobs page which will fetch the jobs results.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/job-item.js 
> 42a3411 
>   contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js 
> 7e24843 
>   contrib/views/hive20/src/main/resources/ui/app/routes/jobs.js 3e88ac6 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 
> 76a7439 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> f6256898 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 522b2d3 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
>  16caad0 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs
>  d29ca73 
>   contrib/views/hive20/src/main/resources/ui/app/templates/jobs.hbs 4382b7a 
> 
> 
> Diff: https://reviews.apache.org/r/62683/diff/1/
> 
> 
> Testing
> ---
> 
> Manual tetsing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 62674: A couple of merge fixes for branch-3.0-perf

2017-09-29 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62674/
---

(Updated Sept. 29, 2017, 9:30 a.m.)


Review request for Ambari and Attila Doroszlai.


Bugs: AMBARI-22088
https://issues.apache.org/jira/browse/AMBARI-22088


Repository: ambari


Description
---

.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
9f3e9a27a8 
  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 2d9e5cc801 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 ea208e838e 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 5f4ba177e2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 d14bd33768 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 e0df48778b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 5d75b9921c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
 447d7e8fd4 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
c97f4cfc6f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 e6da65e745 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 8743f63aeb 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 ecb616a6b9 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/templates/input.config-zeppelin.json.j2
 2b373d54e5 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
4a89fd4b7b 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
 439a5542c9 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/DummyHeartbeatConstants.java
 69980dc6eb 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java
 f55db0831b 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 4b4da49762 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/RecoveryConfigHelperTest.java
 1b37435a89 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 883e8918b6 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
 ff6fab9e3b 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 677b607834 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
 3d25ef718e 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
 95a04deb6b 
  ambari-web/app/mixins/common/persist.js e69de29bb2 


Diff: https://reviews.apache.org/r/62674/diff/3/

Changes: https://reviews.apache.org/r/62674/diff/2-3/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 62675: Wrong Hadoop Home Directory Is Being Picked Up on MAINT/PATCH Upgraded Clusters

2017-09-29 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62675/#review186647
---




ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
Line 220 (original), 222 (patched)


looks like doc is unfinished



ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java
Lines 43 (patched)


How it differs from componentName?


- Dmitro Lisnichenko


On Sept. 28, 2017, 9:27 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62675/
> ---
> 
> (Updated Sept. 28, 2017, 9:27 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-22083
> https://issues.apache.org/jira/browse/AMBARI-22083
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> - Install HDP 2.6.0.0 with HDFS and YARN/MapR
> - Perform a MAINT upgrade of HDFS to 2.6.3.0
> - Stop all services
> - Restart all services
> 
> The following is observed:
> - {{/usr/hdp/current/hadoop-client -> /usr/hdp/2.6.0.0/hadoop}}
> - HDFS picks up 2.6.0.0
> - YARN/MapR pick up 2.6.0.0
> 
> The upgraded components should pickup the version of the hadoop home 
> directory that is theirs.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/component_version.py
>  a1fd6b2e7c 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  ffcaad5cbc 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  f5068e4295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  0042f53c7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
> 5dec53c32f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  77e1bed96f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/after-INSTALL/scripts/params.py
>  d3332db3af 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-ANY/scripts/params.py
>  5ffd28ca94 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-START/scripts/params.py
>  5c84a05b0d 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/after-INSTALL/scripts/params.py
>  c4970543d6 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/before-ANY/scripts/params.py
>  b0467a9a75 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/before-START/scripts/params.py
>  be9db58fef 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
>  4d7eaee3b9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  1fd7f3ef76 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
>  3997117ade 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  5ca2d94403 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/ECS/package/scripts/params.py
>  c304a93b5e 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py
>  9dceb69fee 
> 
> 
> Diff: https://reviews.apache.org/r/62675/diff/1/
> 
> 
> Testing
> ---
> 
> End-to-End manual tests
> Lots of Python test fixes PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>