Re: Review Request 62985: AMBARI-22232 : Need to add a new property to support proxy users property for Atlas service

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62985/#review188076
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 14, 2017, 7:17 a.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62985/
> ---
> 
> (Updated Oct. 14, 2017, 7:17 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Madhan Neethiraj, 
> Mugdha Varadkar, Nate Cole, and Nixon Rodrigues.
> 
> 
> Bugs: AMBARI-22232
> https://issues.apache.org/jira/browse/AMBARI-22232
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Atlas is enabled via proxy needs to know the proxy-users to authorize 
> them while accessing the Atlas service via proxy support using property 
> atlas.proxyusers with default value knox. Additional details on ATLAS-2166.
> 
> PS: Attached patch is applicable for trunk branch, patch for branch-2.6 is 
> attached on Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculation.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  1af3b18 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 0a01a04 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
>  c271dc3 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 94f28db 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  ebb81d9 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> ae5972e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculationTest.java
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> ade08c1 
> 
> 
> Diff: https://reviews.apache.org/r/62985/diff/2/
> 
> 
> Testing
> ---
> 
> Verified with fresh-install and EU on CentOS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 62998: In case only Hive Server Interactive is deployed with no Hive Server in the cluster the hive metastore warehouse directory is not created on DFS.

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62998/#review188073
---


Ship it!




Ship It!

- Attila Doroszlai


On Oct. 14, 2017, 8:05 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62998/
> ---
> 
> (Updated Oct. 14, 2017, 8:05 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Robert Levas, and 
> Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22243
> https://issues.apache.org/jira/browse/AMBARI-22243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The ware house directory creation logic was part only of HiveServer scripts. 
> The same logic had to be added to HiveServer Interactive scripts in order to 
> ensure that the warehouse directory is created if solely HiveServer 
> Interactive is deployed to the cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  2ed3e3a 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py
>  2ed3e3a 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 3dc78ab 
> 
> 
> Diff: https://reviews.apache.org/r/62998/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing using Blueprints (currently only with Blueprints it's possible 
> to deploy HiveServer Interactive with no HiveServer in the cluster)
> 
> 
> Unit tests:
> *mvn test  -DskipSurefireTests -am -pl ambari-server*
> 
> ```
> Total run:1204
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.473 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.003 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.727 
> s]
> [INFO] ambari-utility . SUCCESS [  2.642 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.185 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  0.351 
> s]
> [INFO] Ambari Service Advisor . SUCCESS [  0.374 
> s]
> [INFO] Ambari Server .. SUCCESS [01:32 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 62998: In case only Hive Server Interactive is deployed with no Hive Server in the cluster the hive metastore warehouse directory is not created on DFS.

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62998/#review188072
---


Ship it!




Ship It!

- Robert Levas


On Oct. 14, 2017, 2:05 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62998/
> ---
> 
> (Updated Oct. 14, 2017, 2:05 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Robert Levas, and 
> Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22243
> https://issues.apache.org/jira/browse/AMBARI-22243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The ware house directory creation logic was part only of HiveServer scripts. 
> The same logic had to be added to HiveServer Interactive scripts in order to 
> ensure that the warehouse directory is created if solely HiveServer 
> Interactive is deployed to the cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  2ed3e3a 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py
>  2ed3e3a 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 3dc78ab 
> 
> 
> Diff: https://reviews.apache.org/r/62998/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing using Blueprints (currently only with Blueprints it's possible 
> to deploy HiveServer Interactive with no HiveServer in the cluster)
> 
> 
> Unit tests:
> *mvn test  -DskipSurefireTests -am -pl ambari-server*
> 
> ```
> Total run:1204
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.473 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.003 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.727 
> s]
> [INFO] ambari-utility . SUCCESS [  2.642 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.185 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  0.351 
> s]
> [INFO] Ambari Service Advisor . SUCCESS [  0.374 
> s]
> [INFO] Ambari Server .. SUCCESS [01:32 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 62943: AMBARI-22220 - Should be able to switch the extension version to which a stack version is linked

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62943/#review188067
---


Ship it!




Ship It!

- Di Li


On Oct. 13, 2017, 6:40 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62943/
> ---
> 
> (Updated Oct. 13, 2017, 6:40 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jonathan Hurley, Jayush Luniya, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-0
> https://issues.apache.org/jira/browse/AMBARI-0
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the only way to switch the extension version to which a stack 
> version is linked is to perform the following actions:
> 
> Stop the extension services
> Reregister (delete) the extension services
> Unlink the old extension version
> Link the new extension version
> Add the extension services back
> 
> The REST API should allow us to do an update action on the extension link. In 
> this manner, if we were running an upgrade from HDP 2.6.1 to 2.6.3 (or 
> something similar) which both use the HDP 2.6 stack version then we could 
> perform the extension link switch as a manual step during the upgrade process.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  f0f13e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  b0eb8ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
>  0c8edfe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java
>  9b894ff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionHelper.java
>  91dc870 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java
>  cef30b5 
>   ambari-server/src/test/resources/extensions/EXT/0.2/metainfo.xml c95a20f 
>   ambari-server/src/test/resources/extensions/EXT/0.4/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/test/resources/extensions/EXT/0.4/services/OOZIE2/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/extensions/EXT/0.4/services/OOZIE2/themes/broken_theme.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62943/diff/1/
> 
> 
> Testing
> ---
> 
> mvn test 
> -Dtest=StackManagerCommonServicesTest,StackManagerTest,StackManagerMiscTest,StackManagerExtensionTest
> 
> Manual testing both valid and invalid extension version updates
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 62985: AMBARI-22232 : Need to add a new property to support proxy users property for Atlas service

[Vishal Suvagia via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62985/
---

(Updated Oct. 14, 2017, 11:17 a.m.)


Review request for Ambari, Gautam Borad, Jonathan Hurley, Madhan Neethiraj, 
Mugdha Varadkar, Nate Cole, and Nixon Rodrigues.


Changes
---

Updating patch to address review comments.
Seperate patch for branch-2.6 is attached on Apache JIRA


Bugs: AMBARI-22232
https://issues.apache.org/jira/browse/AMBARI-22232


Repository: ambari


Description
---

When Atlas is enabled via proxy needs to know the proxy-users to authorize them 
while accessing the Atlas service via proxy support using property 
atlas.proxyusers with default value knox. Additional details on ATLAS-2166.

PS: Attached patch is applicable for trunk branch, patch for branch-2.6 is 
attached on Apache JIRA.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculation.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 1af3b18 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
0a01a04 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
 c271dc3 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
94f28db 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 ebb81d9 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
ae5972e 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculationTest.java
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py ade08c1 


Diff: https://reviews.apache.org/r/62985/diff/2/

Changes: https://reviews.apache.org/r/62985/diff/1-2/


Testing
---

Verified with fresh-install and EU on CentOS 6.


Thanks,

Vishal Suvagia

Re: Review Request 62985: AMBARI-22232 : Need to add a new property to support proxy users property for Atlas service

[Vishal Suvagia via Review Board]

> On Oct. 14, 2017, 12:18 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculation.java
> > Lines 38 (patched)
> > 
> >
> > Hard coded? This can't be configured by administrators?

I agree, Administrators can configure the value. Here 'knox' is a default value 
required to be provided if Knox is externally configured to use Atlas via 
proxy, eventually if a custom-user is used for the external knox, then this 
value will need to be manually configured.
Here default value is referred from Atlas side implementation where 'knox' is 
the default value.Reference here -> 
https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java#L88


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62985/#review188051
---


On Oct. 13, 2017, 8:21 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62985/
> ---
> 
> (Updated Oct. 13, 2017, 8:21 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Madhan Neethiraj, 
> Mugdha Varadkar, Nate Cole, and Nixon Rodrigues.
> 
> 
> Bugs: AMBARI-22232
> https://issues.apache.org/jira/browse/AMBARI-22232
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Atlas is enabled via proxy needs to know the proxy-users to authorize 
> them while accessing the Atlas service via proxy support using property 
> atlas.proxyusers with default value knox. Additional details on ATLAS-2166.
> 
> PS: Attached patch is applicable for trunk branch, patch for branch-2.6 is 
> attached on Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculation.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  1af3b18 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 0a01a04 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
>  c271dc3 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 94f28db 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  ebb81d9 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> ae5972e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculationTest.java
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> ade08c1 
> 
> 
> Diff: https://reviews.apache.org/r/62985/diff/2/
> 
> 
> Testing
> ---
> 
> Verified with fresh-install and EU on CentOS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>