date:20180104

Re: Review Request 64948: Improved service/component dependency support (component level)

2018-01-04 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64948/
---

(Updated Jan. 5, 2018, 7:54 a.m.)


Review request for Ambari, Aleksandr Kovalenko, Nate Cole, Oleg Nechiporenko, 
and Robert Levas.


Changes
---

javadoc


Bugs: AMBARI-22449
https://issues.apache.org/jira/browse/AMBARI-22449


Repository: ambari


Description
---

Ambari checks if a component needs certain client components before adding a 
component. The dependency check should take compatible services (like 
ONEFS_CLIENT - HDFS_CLIENT) into consideration. The componentType is used to 
indicate HDFS compatiblity.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
 75fac6e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
 a221248 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
d361a29 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
6bbb583 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/metainfo.xml 
0c629f3 
  ambari-web/app/controllers/main/host/details.js e3b5471 
  ambari-web/app/controllers/wizard/step8_controller.js e64a09a 
  ambari-web/app/mappers/stack_service_mapper.js 368a182 
  ambari-web/app/models/stack_service_component.js 27aa8aa 
  ambari-web/test/controllers/main/host/details_test.js f9df36d 
  ambari-web/test/controllers/wizard/step8_test.js 2a52598 


Diff: https://reviews.apache.org/r/64948/diff/2/

Changes: https://reviews.apache.org/r/64948/diff/1-2/


Testing
---

1. installed HBASE + ONEFS
2. checked if ONEFS_CLIENT was installed automatically on the host wher 
HBASE_MASTER was located

1. tried to add an HBASE_MASTER afterwards to a host where no ONEFS_CLIENT was 
installed
2. ambari has shown a message about the missing client component
3. added a ONEFS_CLIENT to the host manually and retried adding HBASE_MASTER
4. HBASE_MASTER was successfully installed

existing tests: passed


Thanks,

Attila Magyar

Re: Review Request 64951: Idempotent issue on Ambari Upgrade, renameServiceDeletedColumn failed with column already exists exception

2018-01-04 Thread Dmytro Grinenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64951/#review194838
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
Lines 21 (patched)


please check 
https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambarim
 Java Import Order


- Dmytro Grinenko


On Jan. 4, 2018, 5 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64951/
> ---
> 
> (Updated Jan. 4, 2018, 5 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, and Dmytro Sen.
> 
> 
> Bugs: AMBARI-22724
> https://issues.apache.org/jira/browse/AMBARI-22724
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Issue discovered alongside with another bugs which leads upgrade to fail in 
> the middle with partially applying changes to DB. It leads to exception in 
> code: 
> 
> {code}
>   private void renameServiceDeletedColumn() throws AmbariException, 
> SQLException {
> if (dbAccessor.tableHasColumn(CLUSTER_CONFIG_TABLE, 
> SERVICE_DELETED_COLUMN)) {
>   dbAccessor.renameColumn(CLUSTER_CONFIG_TABLE, SERVICE_DELETED_COLUMN, 
> new DBAccessor.DBColumnInfo(UNMAPPED_COLUMN, Short.class, null, 0, false));
> }
>   }
> {code}
> 
> 
> Exception:  ERROR: column "unmapped" of relation "clusterconfig" already 
> exists   (err.png)
> 
> Table generated DDL from current state: 
> {code}
> -- auto-generated definition
> CREATE TABLE clusterconfig
> (
>   config_id  INT8(19)   NOT NULL
> CONSTRAINT pk_clusterconfig
> PRIMARY KEY,
>   version_tagVARCHAR(255)   NOT NULL,
>   versionINT8(19)   NOT NULL,
>   type_name  VARCHAR(255)   NOT NULL,
>   cluster_id INT8(19)   NOT NULL
> CONSTRAINT fk_clusterconfig_cluster_id
> REFERENCES clusters,
>   stack_id   INT8(19)   NOT NULL
> CONSTRAINT fk_clusterconfig_stack_id
> REFERENCES stack,
>   config_dataTEXT(max)  NOT NULL,
>   config_attributes  TEXT(max),
>   create_timestamp   INT8(19)   NOT NULL,
>   unmapped   INT2(5) DEFAULT 0  NOT NULL,
>   selected   INT2(5) DEFAULT 0  NOT NULL,
>   selected_timestamp INT8(19) DEFAULT 0 NOT NULL,
>   service_deletedINT2(5) DEFAULT 0  NOT NULL
> );
> 
> CREATE UNIQUE INDEX uq_config_type_tag
>   ON clusterconfig (cluster_id, type_name, version_tag);
> 
> CREATE UNIQUE INDEX uq_config_type_version
>   ON clusterconfig (cluster_id, type_name, version);
> 
> 
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
>  e6a7829 
> 
> 
> Diff: https://reviews.apache.org/r/64951/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 64956: Update Hadoop RPC Encryption Properties During Kerberization and Upgrade

2018-01-04 Thread Dmytro Grinenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64956/#review194837
---


Ship it!




Ship It!

- Dmytro Grinenko


On Jan. 4, 2018, 8:16 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64956/
> ---
> 
> (Updated Jan. 4, 2018, 8:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22725
> https://issues.apache.org/jira/browse/AMBARI-22725
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Clients should have the ability to choose encrypted communication over RPC 
> when talking to core hadoop components. Today, the properties that control 
> this are:
> 
> - {{core-site.xml : hadoop.rpc.protection = authentication}}
> - {{hdfs-site.xml : dfs.data.transfer.protection = authentication}}
> 
> The new value of {{privacy}} enables clients to choose an encrypted means of 
> communication. By keeping {{authentication}} first, it will be taken as the 
> default mechanism so that wire encryption is not automatically enabled by 
> accident.
> 
> The following properties should be changed to add {{privacy}}:
> 
> - {{core-site.xml : hadoop.rpc.protection = authentication,privacy}}
> - {{hdfs-site.xml : dfs.data.transfer.protection = authentication,privacy}}
> 
> The following are cases when this needs to be performed:
> - During Kerberization, the above two properties should be automatically 
> reconfigured.
> - During a stack upgrade to any version of HDP 2.6, they should be 
> automatically merged
> 
> Blueprint deployment is not a scenario being covered here.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  fbcde51b32 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  c1a05c03b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
>  7fd8938f7d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java
>  2167b7b464 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 0b0c9c56af 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/kerberos.json 
> f8bdc5cc5c 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> 94787225f1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  d506f1f16c 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 17a63943ba 
>   ambari-server/src/main/resources/upgrade-pack.xsd 9e50a087b6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  ac9be666c7 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_conditions.xml
>  61c891a4be 
> 
> 
> Diff: https://reviews.apache.org/r/64956/diff/2/
> 
> 
> Testing
> ---
> 
> --
> Total run:1201
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:01 min
> [INFO] Finished at: 2018-01-04T15:55:20-05:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 64956: Update Hadoop RPC Encryption Properties During Kerberization and Upgrade

2018-01-04 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64956/#review194787
---


Ship it!




Ship It!

- Nate Cole


On Jan. 4, 2018, 3:16 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64956/
> ---
> 
> (Updated Jan. 4, 2018, 3:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22725
> https://issues.apache.org/jira/browse/AMBARI-22725
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Clients should have the ability to choose encrypted communication over RPC 
> when talking to core hadoop components. Today, the properties that control 
> this are:
> 
> - {{core-site.xml : hadoop.rpc.protection = authentication}}
> - {{hdfs-site.xml : dfs.data.transfer.protection = authentication}}
> 
> The new value of {{privacy}} enables clients to choose an encrypted means of 
> communication. By keeping {{authentication}} first, it will be taken as the 
> default mechanism so that wire encryption is not automatically enabled by 
> accident.
> 
> The following properties should be changed to add {{privacy}}:
> 
> - {{core-site.xml : hadoop.rpc.protection = authentication,privacy}}
> - {{hdfs-site.xml : dfs.data.transfer.protection = authentication,privacy}}
> 
> The following are cases when this needs to be performed:
> - During Kerberization, the above two properties should be automatically 
> reconfigured.
> - During a stack upgrade to any version of HDP 2.6, they should be 
> automatically merged
> 
> Blueprint deployment is not a scenario being covered here.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  fbcde51b32 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  c1a05c03b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
>  7fd8938f7d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java
>  2167b7b464 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 0b0c9c56af 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/kerberos.json 
> f8bdc5cc5c 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> 94787225f1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  d506f1f16c 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 17a63943ba 
>   ambari-server/src/main/resources/upgrade-pack.xsd 9e50a087b6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  ac9be666c7 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_conditions.xml
>  61c891a4be 
> 
> 
> Diff: https://reviews.apache.org/r/64956/diff/2/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 64956: Update Hadoop RPC Encryption Properties During Kerberization and Upgrade

2018-01-04 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64956/
---

Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-22725
https://issues.apache.org/jira/browse/AMBARI-22725


Repository: ambari


Description
---

Clients should have the ability to choose encrypted communication over RPC when 
talking to core hadoop components. Today, the properties that control this are:

- {{core-site.xml : hadoop.rpc.protection = authentication}}
- {{hdfs-site.xml : dfs.data.transfer.protection = authentication}}

The new value of {{privacy}} enables clients to choose an encrypted means of 
communication. By keeping {{authentication}} first, it will be taken as the 
default mechanism so that wire encryption is not automatically enabled by 
accident.

The following properties should be changed to add {{privacy}}:

- {{core-site.xml : hadoop.rpc.protection = authentication,privacy}}
- {{hdfs-site.xml : dfs.data.transfer.protection = authentication,privacy}}

The following are cases when this needs to be performed:
- During Kerberization, the above two properties should be automatically 
reconfigured.
- During a stack upgrade to any version of HDP 2.6, they should be 
automatically merged

Blueprint deployment is not a scenario being covered here.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
 fbcde51b32 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 c1a05c03b4 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
 7fd8938f7d 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java
 2167b7b464 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
0b0c9c56af 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/kerberos.json 
f8bdc5cc5c 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
94787225f1 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 d506f1f16c 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
17a63943ba 
  ambari-server/src/main/resources/upgrade-pack.xsd 9e50a087b6 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 ac9be666c7 
  
ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_conditions.xml
 61c891a4be 


Diff: https://reviews.apache.org/r/64956/diff/1/


Testing
---

PENDING


Thanks,

Jonathan Hurley

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

2018-01-04 Thread Nate Cole



> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > 
> >
> > I'm no UI expert, but this entire new block seems to be doing repo 
> > stuff that already is on the UI.  Can you explain the gist here?
> 
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This 
> function makes an API call which gets information of all the bootstrapped 
> hosts .
> 
> Nate Cole wrote:
> I see.  We should probably have that returned as part of host 
> registration and read it from there instead of making another call.  Is that 
> possible in this patch?
> 
> Sonia Garudi wrote:
> The os types of the bootstrapped hosts can be obtained in the 
> registration success callback(isHostsRegisteredSuccessCallback) which would 
> eliminate the above API call. This would involve editing the 
> 'wizard.step3.is_hosts_registered' API call in ajax.js to include the 
> 'Hosts/os_type' field.
> Please let me know your suggestions.
> 
> Nate Cole wrote:
> That sounds reasonable instead of making another call.  Can we make that 
> an error/failure case after registration that we don't have a JAVA_HOME 
> matching the type?
> 
> Yussuf Shaikh wrote:
> Do you want us to fail the Host Registration if java home is not found 
> for host os_type?
> We were planning to just show a message on the host check warnings popup 
> that Host does not have proper Java Home set of its Os type and default java 
> home will be used. This assumption is because during normal(existing) flow 
> Amabari show warning for incorrect Java Home and does not fail registration.

No need to fail host registration.  The popup informational is fine.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
---


On Jan. 4, 2018, 7:07 a.m., Sonia Garudi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> ---
> 
> (Updated Jan. 4, 2018, 7:07 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Includes UI changes in ambari-web to check if the repo is selected or 
> provides prompt to the user to enter the HDP and HDP-utils repo URL's. 
> Includes necessary validation checks for the repo urls, allows user to select 
> the public and local repository and also provides functionality to skip 
> validation checks.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step3_controller.js 55f4323 
>   ambari-web/app/styles/wizard.less 4e680ca 
>   ambari-web/app/templates/wizard/step3.hbs ff436a8 
>   ambari-web/app/utils/ajax/ajax.js 483be5e 
>   ambari-web/app/views/wizard/step3_view.js 3249b24 
>   ambari-web/test/controllers/wizard/step3_test.js b8bc794 
> 
> 
> Diff: https://reviews.apache.org/r/64769/diff/4/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-web
> 
> 
> Thanks,
> 
> Sonia Garudi
> 
>

Re: Review Request 64952: Disabling Kerberos after enabled during Blueprint install fails with missing data directory error

2018-01-04 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64952/#review194769
---


Ship it!




Ship It!

- Robert Levas


On Jan. 4, 2018, 12:06 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64952/
> ---
> 
> (Updated Jan. 4, 2018, 12:06 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-22629
> https://issues.apache.org/jira/browse/AMBARI-22629
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Disabling Kerberos after enabled during Blueprint install fails with missing 
> data directory error.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  86d3ee03a0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  198fdf5e1f 
> 
> 
> Diff: https://reviews.apache.org/r/64952/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Review Request 64952: Disabling Kerberos after enabled during Blueprint install fails with missing data directory error

2018-01-04 Thread Eugene Chekanskiy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64952/
---

Review request for Ambari and Robert Levas.


Bugs: AMBARI-22629
https://issues.apache.org/jira/browse/AMBARI-22629


Repository: ambari


Description
---

Disabling Kerberos after enabled during Blueprint install fails with missing 
data directory error.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 86d3ee03a0 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 198fdf5e1f 


Diff: https://reviews.apache.org/r/64952/diff/1/


Testing
---

mvn clean test, cluster deploy


Thanks,

Eugene Chekanskiy

Review Request 64951: Idempotent issue on Ambari Upgrade, renameServiceDeletedColumn failed with column already exists exception

2018-01-04 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64951/
---

Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, and Dmytro Sen.


Bugs: AMBARI-22724
https://issues.apache.org/jira/browse/AMBARI-22724


Repository: ambari


Description
---

Issue discovered alongside with another bugs which leads upgrade to fail in the 
middle with partially applying changes to DB. It leads to exception in code: 

{code}
  private void renameServiceDeletedColumn() throws AmbariException, 
SQLException {
if (dbAccessor.tableHasColumn(CLUSTER_CONFIG_TABLE, 
SERVICE_DELETED_COLUMN)) {
  dbAccessor.renameColumn(CLUSTER_CONFIG_TABLE, SERVICE_DELETED_COLUMN, new 
DBAccessor.DBColumnInfo(UNMAPPED_COLUMN, Short.class, null, 0, false));
}
  }
{code}


Exception:  ERROR: column "unmapped" of relation "clusterconfig" already exists 
  (err.png)

Table generated DDL from current state: 
{code}
-- auto-generated definition
CREATE TABLE clusterconfig
(
  config_id  INT8(19)   NOT NULL
CONSTRAINT pk_clusterconfig
PRIMARY KEY,
  version_tagVARCHAR(255)   NOT NULL,
  versionINT8(19)   NOT NULL,
  type_name  VARCHAR(255)   NOT NULL,
  cluster_id INT8(19)   NOT NULL
CONSTRAINT fk_clusterconfig_cluster_id
REFERENCES clusters,
  stack_id   INT8(19)   NOT NULL
CONSTRAINT fk_clusterconfig_stack_id
REFERENCES stack,
  config_dataTEXT(max)  NOT NULL,
  config_attributes  TEXT(max),
  create_timestamp   INT8(19)   NOT NULL,
  unmapped   INT2(5) DEFAULT 0  NOT NULL,
  selected   INT2(5) DEFAULT 0  NOT NULL,
  selected_timestamp INT8(19) DEFAULT 0 NOT NULL,
  service_deletedINT2(5) DEFAULT 0  NOT NULL
);

CREATE UNIQUE INDEX uq_config_type_tag
  ON clusterconfig (cluster_id, type_name, version_tag);

CREATE UNIQUE INDEX uq_config_type_version
  ON clusterconfig (cluster_id, type_name, version);


{code}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
 e6a7829 


Diff: https://reviews.apache.org/r/64951/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

2018-01-04 Thread Yussuf Shaikh



> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > 
> >
> > I'm no UI expert, but this entire new block seems to be doing repo 
> > stuff that already is on the UI.  Can you explain the gist here?
> 
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This 
> function makes an API call which gets information of all the bootstrapped 
> hosts .
> 
> Nate Cole wrote:
> I see.  We should probably have that returned as part of host 
> registration and read it from there instead of making another call.  Is that 
> possible in this patch?
> 
> Sonia Garudi wrote:
> The os types of the bootstrapped hosts can be obtained in the 
> registration success callback(isHostsRegisteredSuccessCallback) which would 
> eliminate the above API call. This would involve editing the 
> 'wizard.step3.is_hosts_registered' API call in ajax.js to include the 
> 'Hosts/os_type' field.
> Please let me know your suggestions.
> 
> Nate Cole wrote:
> That sounds reasonable instead of making another call.  Can we make that 
> an error/failure case after registration that we don't have a JAVA_HOME 
> matching the type?

Do you want us to fail the Host Registration if java home is not found for host 
os_type?
We were planning to just show a message on the host check warnings popup that 
Host does not have proper Java Home set of its Os type and default java home 
will be used. This assumption is because during normal(existing) flow Amabari 
show warning for incorrect Java Home and does not fail registration.


- Yussuf


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
---


On Jan. 4, 2018, 12:07 p.m., Sonia Garudi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> ---
> 
> (Updated Jan. 4, 2018, 12:07 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Includes UI changes in ambari-web to check if the repo is selected or 
> provides prompt to the user to enter the HDP and HDP-utils repo URL's. 
> Includes necessary validation checks for the repo urls, allows user to select 
> the public and local repository and also provides functionality to skip 
> validation checks.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step3_controller.js 55f4323 
>   ambari-web/app/styles/wizard.less 4e680ca 
>   ambari-web/app/templates/wizard/step3.hbs ff436a8 
>   ambari-web/app/utils/ajax/ajax.js 483be5e 
>   ambari-web/app/views/wizard/step3_view.js 3249b24 
>   ambari-web/test/controllers/wizard/step3_test.js b8bc794 
> 
> 
> Diff: https://reviews.apache.org/r/64769/diff/4/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-web
> 
> 
> Thanks,
> 
> Sonia Garudi
> 
>

Re: Review Request 64950: Ambari Upgrade failed in case if database have no cluster_version table already. The issue with idempotence

2018-01-04 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64950/#review194766
---


Ship it!




Ship It!

- Jonathan Hurley


On Jan. 4, 2018, 9:44 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64950/
> ---
> 
> (Updated Jan. 4, 2018, 9:44 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22723
> https://issues.apache.org/jira/browse/AMBARI-22723
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-21728 and AMBARI-22469 make the upgrade broken in case of several 
> upgrade tries, failing to follow the Idempotent upgrade paradigm.
> 
> Issue is with:
> {code}
> protected void executeDDLUpdates() throws AmbariException, SQLException {
> Integer currentVersionID = getCurrentVersionID();<--
> dropBrokenFK();
> updateServiceComponentDesiredStateTable(currentVersionID); 
> <--
> updateServiceDesiredStateTable(currentVersionID); <--
> addSelectedCollumsToClusterconfigTable();
> updateHostComponentDesiredStateTable();
> updateHostComponentStateTable();
> dropStaleTables();  <--
> updateUpgradeTable();
> createUpgradeHistoryTable();
> updateRepositoryVersionTable();
> renameServiceDeletedColumn();
> addLegacyColumn();
> expandUpgradeItemItemTextColumn();
> addViewUrlPKConstraint();
> removeStaleConstraints();
> }
> {code}
> 
> {{getCurrentVersionID()}} trying to query non-existing table and failing 
> whole upgrade
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 391a6f567e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  6ba1671cdf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
>  e93cd1303a 
> 
> 
> Diff: https://reviews.apache.org/r/64950/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> live cluster check
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

2018-01-04 Thread Nate Cole



> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > 
> >
> > I'm no UI expert, but this entire new block seems to be doing repo 
> > stuff that already is on the UI.  Can you explain the gist here?
> 
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This 
> function makes an API call which gets information of all the bootstrapped 
> hosts .
> 
> Nate Cole wrote:
> I see.  We should probably have that returned as part of host 
> registration and read it from there instead of making another call.  Is that 
> possible in this patch?
> 
> Sonia Garudi wrote:
> The os types of the bootstrapped hosts can be obtained in the 
> registration success callback(isHostsRegisteredSuccessCallback) which would 
> eliminate the above API call. This would involve editing the 
> 'wizard.step3.is_hosts_registered' API call in ajax.js to include the 
> 'Hosts/os_type' field.
> Please let me know your suggestions.

That sounds reasonable instead of making another call.  Can we make that an 
error/failure case after registration that we don't have a JAVA_HOME matching 
the type?


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
---


On Jan. 4, 2018, 7:07 a.m., Sonia Garudi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> ---
> 
> (Updated Jan. 4, 2018, 7:07 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Includes UI changes in ambari-web to check if the repo is selected or 
> provides prompt to the user to enter the HDP and HDP-utils repo URL's. 
> Includes necessary validation checks for the repo urls, allows user to select 
> the public and local repository and also provides functionality to skip 
> validation checks.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step3_controller.js 55f4323 
>   ambari-web/app/styles/wizard.less 4e680ca 
>   ambari-web/app/templates/wizard/step3.hbs ff436a8 
>   ambari-web/app/utils/ajax/ajax.js 483be5e 
>   ambari-web/app/views/wizard/step3_view.js 3249b24 
>   ambari-web/test/controllers/wizard/step3_test.js b8bc794 
> 
> 
> Diff: https://reviews.apache.org/r/64769/diff/4/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-web
> 
> 
> Thanks,
> 
> Sonia Garudi
> 
>

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-04 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64887/#review194764
---



This has been pushed.  Please close this review and jira.

- Nate Cole


On Jan. 3, 2018, 2:03 a.m., Yussuf Shaikh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64887/
> ---
> 
> (Updated Jan. 3, 2018, 2:03 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22403
> https://issues.apache.org/jira/browse/AMBARI-22403
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Java side changes required to read JAVA HOME value for each host depending on 
> the OS type eg: java.home.redhat7.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  182cd58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  c0a7a7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  c4df0b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  198b617 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  dcafdea 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
> b6287e6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  e47fcd2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  6bece66 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  e795d28 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  a1f28f1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  c5994c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  51035ba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java
>  670c187 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java
>  b90295d 
> 
> 
> Diff: https://reviews.apache.org/r/64887/diff/2/
> 
> 
> Testing
> ---
> 
> tests ran on ambari-server project.
> 
> 
> Thanks,
> 
> Yussuf Shaikh
> 
>

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-04 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64887/#review194763
---


Ship it!




Ship It!

- Nate Cole


On Jan. 3, 2018, 2:03 a.m., Yussuf Shaikh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64887/
> ---
> 
> (Updated Jan. 3, 2018, 2:03 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22403
> https://issues.apache.org/jira/browse/AMBARI-22403
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Java side changes required to read JAVA HOME value for each host depending on 
> the OS type eg: java.home.redhat7.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  182cd58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  c0a7a7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  c4df0b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  198b617 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  dcafdea 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
> b6287e6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  e47fcd2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  6bece66 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  e795d28 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  a1f28f1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  c5994c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  51035ba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java
>  670c187 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java
>  b90295d 
> 
> 
> Diff: https://reviews.apache.org/r/64887/diff/2/
> 
> 
> Testing
> ---
> 
> tests ran on ambari-server project.
> 
> 
> Thanks,
> 
> Yussuf Shaikh
> 
>

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-04 Thread Nate Cole



> On Jan. 2, 2018, 11:51 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java
> > Line 633 (original)
> > 
> >
> > It's much more convenient to keep JAVA_HOME in one place.  We want to 
> > centralize (as much as we can) the places where we have to remember to set 
> > JAVA_HOME.  Can you pass in the os type or OS (the object0 here instead?
> 
> Yussuf Shaikh wrote:
> Here we do not know the os type of each host. This method is  called 
> initially during stage creation. Hence had introduced a method in 
> Configuration class which is called in hosts loop later for different flows.

Fair enough


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64887/#review194635
---


On Jan. 3, 2018, 2:03 a.m., Yussuf Shaikh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64887/
> ---
> 
> (Updated Jan. 3, 2018, 2:03 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22403
> https://issues.apache.org/jira/browse/AMBARI-22403
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Java side changes required to read JAVA HOME value for each host depending on 
> the OS type eg: java.home.redhat7.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  182cd58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  c0a7a7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  c4df0b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  198b617 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  dcafdea 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
> b6287e6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  e47fcd2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  6bece66 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  e795d28 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  a1f28f1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  c5994c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  51035ba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java
>  670c187 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java
>  b90295d 
> 
> 
> Diff: https://reviews.apache.org/r/64887/diff/2/
> 
> 
> Testing
> ---
> 
> tests ran on ambari-server project.
> 
> 
> Thanks,
> 
> Yussuf Shaikh
> 
>

Re: Review Request 64948: Improved service/component dependency support (component level)

2018-01-04 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64948/#review194757
---


Fix it, then Ship it!




Ship It!


ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
Lines 120 (patched)


missing JavaDoc.  Claficiation of this property may be useful in the future.


- Robert Levas


On Jan. 4, 2018, 9:06 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64948/
> ---
> 
> (Updated Jan. 4, 2018, 9:06 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Nate Cole, Oleg Nechiporenko, 
> and Robert Levas.
> 
> 
> Bugs: AMBARI-22449
> https://issues.apache.org/jira/browse/AMBARI-22449
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari checks if a component needs certain client components before adding a 
> component. The dependency check should take compatible services (like 
> ONEFS_CLIENT - HDFS_CLIENT) into consideration. The componentType is used to 
> indicate HDFS compatiblity.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
>  75fac6e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
>  a221248 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> d361a29 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 6bbb583 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/metainfo.xml 
> 0c629f3 
>   ambari-web/app/controllers/main/host/details.js e3b5471 
>   ambari-web/app/controllers/wizard/step8_controller.js e64a09a 
>   ambari-web/app/mappers/stack_service_mapper.js 368a182 
>   ambari-web/app/models/stack_service_component.js 27aa8aa 
>   ambari-web/test/controllers/main/host/details_test.js f9df36d 
>   ambari-web/test/controllers/wizard/step8_test.js 2a52598 
> 
> 
> Diff: https://reviews.apache.org/r/64948/diff/1/
> 
> 
> Testing
> ---
> 
> 1. installed HBASE + ONEFS
> 2. checked if ONEFS_CLIENT was installed automatically on the host wher 
> HBASE_MASTER was located
> 
> 1. tried to add an HBASE_MASTER afterwards to a host where no ONEFS_CLIENT 
> was installed
> 2. ambari has shown a message about the missing client component
> 3. added a ONEFS_CLIENT to the host manually and retried adding HBASE_MASTER
> 4. HBASE_MASTER was successfully installed
> 
> existing tests: passed
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 64948: Improved service/component dependency support (component level)

2018-01-04 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64948/#review194760
---


Ship it!




Ship It!

- Nate Cole


On Jan. 4, 2018, 9:06 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64948/
> ---
> 
> (Updated Jan. 4, 2018, 9:06 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Nate Cole, Oleg Nechiporenko, 
> and Robert Levas.
> 
> 
> Bugs: AMBARI-22449
> https://issues.apache.org/jira/browse/AMBARI-22449
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari checks if a component needs certain client components before adding a 
> component. The dependency check should take compatible services (like 
> ONEFS_CLIENT - HDFS_CLIENT) into consideration. The componentType is used to 
> indicate HDFS compatiblity.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
>  75fac6e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
>  a221248 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> d361a29 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 6bbb583 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/metainfo.xml 
> 0c629f3 
>   ambari-web/app/controllers/main/host/details.js e3b5471 
>   ambari-web/app/controllers/wizard/step8_controller.js e64a09a 
>   ambari-web/app/mappers/stack_service_mapper.js 368a182 
>   ambari-web/app/models/stack_service_component.js 27aa8aa 
>   ambari-web/test/controllers/main/host/details_test.js f9df36d 
>   ambari-web/test/controllers/wizard/step8_test.js 2a52598 
> 
> 
> Diff: https://reviews.apache.org/r/64948/diff/1/
> 
> 
> Testing
> ---
> 
> 1. installed HBASE + ONEFS
> 2. checked if ONEFS_CLIENT was installed automatically on the host wher 
> HBASE_MASTER was located
> 
> 1. tried to add an HBASE_MASTER afterwards to a host where no ONEFS_CLIENT 
> was installed
> 2. ambari has shown a message about the missing client component
> 3. added a ONEFS_CLIENT to the host manually and retried adding HBASE_MASTER
> 4. HBASE_MASTER was successfully installed
> 
> existing tests: passed
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 64950: Ambari Upgrade failed in case if database have no cluster_version table already. The issue with idempotence

2018-01-04 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64950/#review194759
---


Ship it!




Ship It!

- Nate Cole


On Jan. 4, 2018, 9:44 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64950/
> ---
> 
> (Updated Jan. 4, 2018, 9:44 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22723
> https://issues.apache.org/jira/browse/AMBARI-22723
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-21728 and AMBARI-22469 make the upgrade broken in case of several 
> upgrade tries, failing to follow the Idempotent upgrade paradigm.
> 
> Issue is with:
> {code}
> protected void executeDDLUpdates() throws AmbariException, SQLException {
> Integer currentVersionID = getCurrentVersionID();<--
> dropBrokenFK();
> updateServiceComponentDesiredStateTable(currentVersionID); 
> <--
> updateServiceDesiredStateTable(currentVersionID); <--
> addSelectedCollumsToClusterconfigTable();
> updateHostComponentDesiredStateTable();
> updateHostComponentStateTable();
> dropStaleTables();  <--
> updateUpgradeTable();
> createUpgradeHistoryTable();
> updateRepositoryVersionTable();
> renameServiceDeletedColumn();
> addLegacyColumn();
> expandUpgradeItemItemTextColumn();
> addViewUrlPKConstraint();
> removeStaleConstraints();
> }
> {code}
> 
> {{getCurrentVersionID()}} trying to query non-existing table and failing 
> whole upgrade
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 391a6f567e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  6ba1671cdf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
>  e93cd1303a 
> 
> 
> Diff: https://reviews.apache.org/r/64950/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> live cluster check
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 64950: Ambari Upgrade failed in case if database have no cluster_version table already. The issue with idempotence

2018-01-04 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64950/
---

(Updated Jan. 4, 2018, 4:44 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22723
https://issues.apache.org/jira/browse/AMBARI-22723


Repository: ambari


Description
---

AMBARI-21728 and AMBARI-22469 make the upgrade broken in case of several 
upgrade tries, failing to follow the Idempotent upgrade paradigm.

Issue is with:
{code}
protected void executeDDLUpdates() throws AmbariException, SQLException {
Integer currentVersionID = getCurrentVersionID();<--
dropBrokenFK();
updateServiceComponentDesiredStateTable(currentVersionID); 
<--
updateServiceDesiredStateTable(currentVersionID); <--
addSelectedCollumsToClusterconfigTable();
updateHostComponentDesiredStateTable();
updateHostComponentStateTable();
dropStaleTables();  <--
updateUpgradeTable();
createUpgradeHistoryTable();
updateRepositoryVersionTable();
renameServiceDeletedColumn();
addLegacyColumn();
expandUpgradeItemItemTextColumn();
addViewUrlPKConstraint();
removeStaleConstraints();
}
{code}

{{getCurrentVersionID()}} trying to query non-existing table and failing whole 
upgrade


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
391a6f567e 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 6ba1671cdf 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
 e93cd1303a 


Diff: https://reviews.apache.org/r/64950/diff/1/


Testing (updated)
---

mvn clean test
live cluster check


Thanks,

Dmitro Lisnichenko

Review Request 64950: Ambari Upgrade failed in case if database have no cluster_version table already. The issue with idempotence

2018-01-04 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64950/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22723
https://issues.apache.org/jira/browse/AMBARI-22723


Repository: ambari


Description
---

AMBARI-21728 and AMBARI-22469 make the upgrade broken in case of several 
upgrade tries, failing to follow the Idempotent upgrade paradigm.

Issue is with:
{code}
protected void executeDDLUpdates() throws AmbariException, SQLException {
Integer currentVersionID = getCurrentVersionID();<--
dropBrokenFK();
updateServiceComponentDesiredStateTable(currentVersionID); 
<--
updateServiceDesiredStateTable(currentVersionID); <--
addSelectedCollumsToClusterconfigTable();
updateHostComponentDesiredStateTable();
updateHostComponentStateTable();
dropStaleTables();  <--
updateUpgradeTable();
createUpgradeHistoryTable();
updateRepositoryVersionTable();
renameServiceDeletedColumn();
addLegacyColumn();
expandUpgradeItemItemTextColumn();
addViewUrlPKConstraint();
removeStaleConstraints();
}
{code}

{{getCurrentVersionID()}} trying to query non-existing table and failing whole 
upgrade


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
391a6f567e 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 6ba1671cdf 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
 e93cd1303a 


Diff: https://reviews.apache.org/r/64950/diff/1/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

2018-01-04 Thread Sonia Garudi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/
---

(Updated Jan. 4, 2018, 12:07 p.m.)


Review request for Ambari and Nate Cole.


Changes
---

Removed the API call for getting the os_type for the bootstrapped hosts. 
Changed the registration check API to include the os_type field, which is later 
added to the respective hosts in 'bootHosts'.


Bugs: AMBARI-22406
https://issues.apache.org/jira/browse/AMBARI-22406


Repository: ambari


Description
---

Includes UI changes in ambari-web to check if the repo is selected or provides 
prompt to the user to enter the HDP and HDP-utils repo URL's. Includes 
necessary validation checks for the repo urls, allows user to select the public 
and local repository and also provides functionality to skip validation checks.


Diffs (updated)
-

  ambari-web/app/controllers/wizard/step3_controller.js 55f4323 
  ambari-web/app/styles/wizard.less 4e680ca 
  ambari-web/app/templates/wizard/step3.hbs ff436a8 
  ambari-web/app/utils/ajax/ajax.js 483be5e 
  ambari-web/app/views/wizard/step3_view.js 3249b24 
  ambari-web/test/controllers/wizard/step3_test.js b8bc794 


Diff: https://reviews.apache.org/r/64769/diff/4/

Changes: https://reviews.apache.org/r/64769/diff/3-4/


Testing
---

Tests were successful in ambari-web


Thanks,

Sonia Garudi

Re: Review Request 64948: Improved service/component dependency support (component level)

Re: Review Request 64951: Idempotent issue on Ambari Upgrade, renameServiceDeletedColumn failed with column already exists exception

Re: Review Request 64956: Update Hadoop RPC Encryption Properties During Kerberization and Upgrade

Re: Review Request 64956: Update Hadoop RPC Encryption Properties During Kerberization and Upgrade

Review Request 64956: Update Hadoop RPC Encryption Properties During Kerberization and Upgrade

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

Re: Review Request 64952: Disabling Kerberos after enabled during Blueprint install fails with missing data directory error

Review Request 64952: Disabling Kerberos after enabled during Blueprint install fails with missing data directory error

Review Request 64951: Idempotent issue on Ambari Upgrade, renameServiceDeletedColumn failed with column already exists exception

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

Re: Review Request 64950: Ambari Upgrade failed in case if database have no cluster_version table already. The issue with idempotence

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

Re: Review Request 64948: Improved service/component dependency support (component level)

Re: Review Request 64948: Improved service/component dependency support (component level)

Re: Review Request 64950: Ambari Upgrade failed in case if database have no cluster_version table already. The issue with idempotence

Re: Review Request 64950: Ambari Upgrade failed in case if database have no cluster_version table already. The issue with idempotence

Review Request 64950: Ambari Upgrade failed in case if database have no cluster_version table already. The issue with idempotence

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

21 matches

Site Navigation

Mail list logo

Footer information