Review Request 64196: Uploading a Zero KB file to HDFS via File View Fails
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64196/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore. Bugs: AMBARI-22490 https://issues.apache.org/jira/browse/AMBARI-22490 Repository: ambari Description --- Removed the empty file check. Diffs - contrib/views/files/src/main/resources/ui/app/components/upload-file.js 8a14272 Diff: https://reviews.apache.org/r/64196/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 64196: Uploading a Zero KB file to HDFS via File View Fails
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64196/#review192219 --- Ship it! Ship It! - Pallav Kulshreshtha On Nov. 30, 2017, 1:52 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64196/ > --- > > (Updated Nov. 30, 2017, 1:52 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj > Rathore. > > > Bugs: AMBARI-22490 > https://issues.apache.org/jira/browse/AMBARI-22490 > > > Repository: ambari > > > Description > --- > > Removed the empty file check. > > > Diffs > - > > contrib/views/files/src/main/resources/ui/app/components/upload-file.js > 8a14272 > > > Diff: https://reviews.apache.org/r/64196/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Review Request 64155: Update the version of Ember and jQuery for Hive View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64155/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore. Bugs: AMBARI-22542 https://issues.apache.org/jira/browse/AMBARI-22542 Repository: ambari Description --- Changed the ember and jquery versions. Diffs - contrib/views/files/src/main/resources/ui/bower.json f1472ee contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json 62861b2 Diff: https://reviews.apache.org/r/64155/diff/1/ Testing --- manually tested Thanks, Pallav Kulshreshtha
Re: Review Request 64035: Workflow Manager View - FS node will overwrite internal commands and replace them with blank "move" commands when reopening the node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64035/#review191778 --- Ship it! Ship It! - Pallav Kulshreshtha On Nov. 22, 2017, 5:24 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64035/ > --- > > (Updated Nov. 22, 2017, 5:24 p.m.) > > > Review request for Ambari, Gaurav Nagar, Padma Priya N, Pallav Kulshreshtha, > Prabhjyot Singh, and Rohit Choudhary. > > > Bugs: AMBARI-22502 > https://issues.apache.org/jira/browse/AMBARI-22502 > > > Repository: ambari > > > Description > --- > > Condition for importing single node have been added. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > 84a789d > > > Diff: https://reviews.apache.org/r/64035/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 62976: Zeppelin service check failed during EU from 2.5 to 2.6 as ZeppelinServer can not be instantiated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62976/#review188103 --- Ship it! Ship It! - Pallav Kulshreshtha On Oct. 13, 2017, 2:32 p.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62976/ > --- > > (Updated Oct. 13, 2017, 2:32 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, > Rohit Choudhary, Sumit Mohanty, and venkat sairam. > > > Bugs: AMBARI-22233 > https://issues.apache.org/jira/browse/AMBARI-22233 > > > Repository: ambari > > > Description > --- > > There are two issuse > - one a file can exists with zero byte, it should be treated as file not in > file system > - premission of interpreter.json should be 644 instead of 640 > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py > 6a84d7926b > ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py > 400350c4f0 > > > Diff: https://reviews.apache.org/r/62976/diff/1/ > > > Testing > --- > > Manually > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 62968: Handle upload of interpreter.json to remote storage in Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62968/#review187947 --- Ship it! Ship It! - Pallav Kulshreshtha On Oct. 13, 2017, 7:10 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62968/ > --- > > (Updated Oct. 13, 2017, 7:10 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, > Rohit Choudhary, Sumit Mohanty, and venkat sairam. > > > Bugs: AMBARI-9 > https://issues.apache.org/jira/browse/AMBARI-9 > > > Repository: ambari > > > Description > --- > > Zeppelin can read interpreter.json from HDFS based on hdfs-site.xml present > in classpath. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py > a8b1b321c8 > ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py > e5d024092b > > > Diff: https://reviews.apache.org/r/62968/diff/2/ > > > Testing > --- > > Manually > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 62924: Alter logic for storing interpreter.json
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62924/#review187764
---
Ship it!
Ship It!
- Pallav Kulshreshtha
On Oct. 12, 2017, 6:37 a.m., Prabhjyot Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62924/
> ---
>
> (Updated Oct. 12, 2017, 6:37 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya,
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
>
>
> Bugs: AMBARI-22212
> https://issues.apache.org/jira/browse/AMBARI-22212
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Right now Ambari assumes if "FileSystemNotebookRepo" is set for
> "zeppelin.notebook.storage" then both notebook and conf are in HDFS.
>
> But the right logic will be if ("zeppelin.config.fs.dir" is empty or
> "zeppelin.config.fs.dir" start with "file://") it is stored in FS else HDFS
> and also check for
> "/etc/zeppelin/conf/external-dependency-conf/hdfs-site.xml" if exists.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
> 09944bd277
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
> 3242f2621a
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py
> 3adb94ce1a
>
>
> Diff: https://reviews.apache.org/r/62924/diff/1/
>
>
> Testing
> ---
>
> Manually
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62925/#review187765 --- Ship it! Ship It! - Pallav Kulshreshtha On Oct. 12, 2017, 9:03 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62925/ > --- > > (Updated Oct. 12, 2017, 9:03 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, > Rohit Choudhary, Sumit Mohanty, and venkat sairam. > > > Bugs: AMBARI-22214 > https://issues.apache.org/jira/browse/AMBARI-22214 > > > Repository: ambari > > > Description > --- > > If Livy is running on https mode then Livy protocol to be set to https in > Zeppelin's interpreter setting. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py > 09944bd277 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py > 3242f2621a > > > Diff: https://reviews.apache.org/r/62925/diff/2/ > > > Testing > --- > > Manually > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 62885: Hive View 2.0 in Ambari 2.5.1 does not use the specified YARN queue when using the "Upload Table" feature.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62885/#review187644 --- Ship it! Ship It! - Pallav Kulshreshtha On Oct. 11, 2017, 10:44 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62885/ > --- > > (Updated Oct. 11, 2017, 10:44 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and venkat > sairam. > > > Bugs: AMBARI-22202 > https://issues.apache.org/jira/browse/AMBARI-22202 > > > Repository: ambari > > > Description > --- > > added global settings in all the system generated queries > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java > 77857f9628 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadService.java > 3164da09e1 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java > b74ba9b0c1 > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js > f47d820cbf > > > Diff: https://reviews.apache.org/r/62885/diff/1/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 62883: Zeppelin start fails due to permission denied error during kinit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62883/#review187640 --- Ship it! Ship It! - Pallav Kulshreshtha On Oct. 11, 2017, 9:01 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62883/ > --- > > (Updated Oct. 11, 2017, 9:01 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, > Rohit Choudhary, Sumit Mohanty, and venkat sairam. > > > Bugs: AMBARI-22199 > https://issues.apache.org/jira/browse/AMBARI-22199 > > > Repository: ambari > > > Description > --- > > Zeppelin fails to come up with following error in ambari stderr logs, on > kerberos enabled enviornment. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py > d615d06d5a > ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py > 3064880632 > > > Diff: https://reviews.apache.org/r/62883/diff/3/ > > > Testing > --- > > Tested manually > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 62676: Hive View 2.0 - Unable to update existing saved queries, view creates new records under saved queries tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62676/ --- (Updated Oct. 9, 2017, 3:42 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and venkat sairam. Bugs: AMBARI-22089 https://issues.apache.org/jira/browse/AMBARI-22089 Repository: ambari Description --- - Updating the same worksheet rather creating new one. Diffs (updated) - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java 3690683 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryService.java 7139ce8 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 9e8b6db contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 4b4b29e contrib/views/hive20/src/main/resources/ui/yarn.lock 477a15c Diff: https://reviews.apache.org/r/62676/diff/2/ Changes: https://reviews.apache.org/r/62676/diff/1-2/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 62694: Entries related to hive query are found in RM UI after killing or stopping the execution of the query.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62694/#review186775 --- Ship it! Ship It! - Pallav Kulshreshtha On Sept. 29, 2017, 5:05 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62694/ > --- > > (Updated Sept. 29, 2017, 5:05 p.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-22096 > https://issues.apache.org/jira/browse/AMBARI-22096 > > > Repository: ambari > > > Description > --- > > Ember data API changes are made and the exceptions on JS side are handled > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 291c335 > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 36abf49 > > > Diff: https://reviews.apache.org/r/62694/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 62683: Hive view2.0 Jobs worksheets doesn't have hyperlink whereas view1.5 History worksheets had hyperlinks pointing to fetched results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62683/#review186642 --- Ship it! Ship It! - Pallav Kulshreshtha On Sept. 29, 2017, 4:37 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62683/ > --- > > (Updated Sept. 29, 2017, 4:37 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-22091 > https://issues.apache.org/jira/browse/AMBARI-22091 > > > Repository: ambari > > > Description > --- > > Provided hyper link in jobs page which will fetch the jobs results. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/job-item.js > 42a3411 > contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js > 7e24843 > contrib/views/hive20/src/main/resources/ui/app/routes/jobs.js 3e88ac6 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js > 76a7439 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > f6256898 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 522b2d3 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs > 16caad0 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs > d29ca73 > contrib/views/hive20/src/main/resources/ui/app/templates/jobs.hbs 4382b7a > > > Diff: https://reviews.apache.org/r/62683/diff/1/ > > > Testing > --- > > Manual tetsing done > > > Thanks, > > venkat sairam > >
Review Request 62677: INCORROUT in Hive SELECT-JOIN query using Hive View 2.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62677/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and venkat sairam. Bugs: AMBARI-22090 https://issues.apache.org/jira/browse/AMBARI-22090 Repository: ambari Description --- minor code correction to make the unique key. Diffs - contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js be5c43a Diff: https://reviews.apache.org/r/62677/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 62676: Hive View 2.0 - Unable to update existing saved queries, view creates new records under saved queries tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62676/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and venkat sairam. Bugs: AMBARI-22089 https://issues.apache.org/jira/browse/AMBARI-22089 Repository: ambari Description --- - Updating the same worksheet rather creating new one. Diffs - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java 3690683 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js f6256898 contrib/views/hive20/src/main/resources/ui/yarn.lock 477a15c Diff: https://reviews.apache.org/r/62676/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 62429: Ambari Unit Tests Fail In trunk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62429/#review185780
---
Ship it!
Ship It!
- Pallav Kulshreshtha
On Sept. 20, 2017, 7:09 a.m., Prabhjyot Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62429/
> ---
>
> (Updated Sept. 20, 2017, 7:09 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya,
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
>
>
> Bugs: AMBARI-22002
> https://issues.apache.org/jira/browse/AMBARI-22002
>
>
> Repository: ambari
>
>
> Description
> ---
>
> The following unit tests are failing trunk builds:
> https://builds.apache.org/job/Ambari-trunk-Commit/8095/consoleFull
>
> OK
> --
> Failed tests:
> ERROR: test_configure_default (test_zeppelin_master.TestZeppelinMaster)
> --
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-common/src/test/python/mock/mock.py",
> line 1199, in patched
> return func(*args, **keywargs)
> File
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py",
> line 145, in test_configure_default
> target = RMFTestCase.TARGET_COMMON_SERVICES
> File
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
> line 126, in executeScript
> raise RuntimeError("Cannot load class %s from %s: %s" % (classname,
> norm_path, err.message))
>
>
> Diffs
> -
>
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py
> 9a28e686f5
>
>
> Diff: https://reviews.apache.org/r/62429/diff/1/
>
>
> Testing
> ---
>
> Tested locally
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 62205: Make Ambari changes for external-conf
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62205/#review185386
---
Ship it!
Ship It!
- Pallav Kulshreshtha
On Sept. 9, 2017, 5:15 p.m., Prabhjyot Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62205/
> ---
>
> (Updated Sept. 9, 2017, 5:15 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
>
>
> Bugs: AMBARI-21912
> https://issues.apache.org/jira/browse/AMBARI-21912
>
>
> Repository: ambari
>
>
> Description
> ---
>
> When the user upgrades from HDP-2.5.x to HDP-2.6.x, they have to do these
> manual steps listed here
> https://community.hortonworks.com/articles/115251/running-jdbc-intepreter-with-phoenix-causes-broken.html,
> to make JDBC(phoenix) works, i.e. to add `export
> ZEPPELIN_INTP_CLASSPATH_OVERRIDES="{{external_dependency_conf}}"` in
> zeppelin_env_content only in case of upgrade from HDP-2.5 to HDP-2.6
>
>
> Diffs
> -
>
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml
> f89654e5f5
>
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
> b79f644fd3
>
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
> 90a7d979b5
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml
> f3b1fa6b37
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml
> 5ee82c3c82
>
>
> Diff: https://reviews.apache.org/r/62205/diff/1/
>
>
> Testing
> ---
>
> Manually on CentOS
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 61205: Users randomly getting "HDFS020 Could not write file" exceptions while running query from Hive View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61205/#review183587 --- Ship it! Ship It! - Pallav Kulshreshtha On Aug. 21, 2017, 8:28 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61205/ > --- > > (Updated Aug. 21, 2017, 8:28 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-21569 > https://issues.apache.org/jira/browse/AMBARI-21569 > > > Repository: ambari > > > Description > --- > > ServiceFormattedException:100 - > org.apache.ambari.view.utils.hdfs.HdfsApiException: HDFS020 Could not write > file /user/user/hive/jobs/hive-job-5290-2017-03-22_02-35/logs > > org.apache.ambari.view.utils.hdfs.HdfsApiException: HDFS020 Could not write > file /user/user/hive/jobs/hive-job-5290-2017-03-22_02-35/logs > at > org.apache.ambari.view.utils.hdfs.HdfsUtil.putStringToFile(HdfsUtil.java:51) > at > org.apache.ambari.view.hive.resources.jobs.viewJobs.JobControllerImpl.updateOperationLogs(JobControllerImpl.java:202) > at > org.apache.ambari.view.hive.resources.jobs.viewJobs.JobControllerImpl.update(JobControllerImpl.java:160) > at > org.apache.ambari.view.hive.resources.jobs.viewJobs.JobResourceManager.read(JobResourceManager.java:79) > at > org.apache.ambari.view.hive.resources.jobs.viewJobs.JobResourceManager.readController(JobResourceManager.java:95) > at > org.apache.ambari.view.hive.resources.jobs.JobService.getOne(JobService.java:133) > at sun.reflect.GeneratedMethodAccessor191.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at > com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) > at > com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205) > at > com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) > at > com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.SubLocatorRule.accept(SubLocatorRule.java:137) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.SubLocatorRule.accept(SubLocatorRule.java:137) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.SubLocatorRule.accept(SubLocatorRule.java:137) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409) > at > com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > at > org.eclipse.jetty.
Re: Review Request 60459: Workflow Manager view build failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60459/#review178965 --- Ship it! Ship It! - Pallav Kulshreshtha On June 27, 2017, 9:22 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60459/ > --- > > (Updated June 27, 2017, 9:22 a.m.) > > > Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-21352 > https://issues.apache.org/jira/browse/AMBARI-21352 > > > Repository: ambari > > > Description > --- > > Changed pom.xml to fix the build failure > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/bower.json 06fc3e3 > > > Diff: https://reviews.apache.org/r/60459/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 60384: User should be prompted for confirmation before closing the browser window
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60384/ --- (Updated June 23, 2017, 6:17 a.m.) Review request for Ambari, Jaimin Jetly, venkat sairam, and Yusaku Sako. Bugs: AMBARI-20702 https://issues.apache.org/jira/browse/AMBARI-20702 Repository: ambari Description (updated) --- - Handled onbeforeunload event to show a warning message one last time before closing the window. - Unfortunately, there is not much scope of UI customization of the warning dialog. Here is stack overflow link for this https://stackoverflow.com/questions/276660/how-can-i-override-the-onbeforeunload-dialog-and-replace-it-with-my-own Diffs - ambari-web/app/assets/index.html efd3c64 Diff: https://reviews.apache.org/r/60384/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 60384: User should be prompted for confirmation before closing the browser window
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60384/ --- Review request for Ambari, Jaimin Jetly, venkat sairam, and Yusaku Sako. Bugs: AMBARI-20702 https://issues.apache.org/jira/browse/AMBARI-20702 Repository: ambari Description --- - Handled onbeforeunload event to show a warning message one last time before closing the window. - Unfortunately, there is not much scope of UI customization of the warning dialog. PFA screenshot of how it looks in our project. Here is stack overflow link for this https://stackoverflow.com/questions/276660/how-can-i-override-the-onbeforeunload-dialog-and-replace-it-with-my-own Diffs - ambari-web/app/assets/index.html efd3c64 Diff: https://reviews.apache.org/r/60384/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 60363: zeppelin jdbc interpreter gives error for 'doAs'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60363/#review178654 --- Ship it! Ship It! - Pallav Kulshreshtha On June 22, 2017, 10:46 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60363/ > --- > > (Updated June 22, 2017, 10:46 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and > venkat sairam. > > > Bugs: AMBARI-21306 > https://issues.apache.org/jira/browse/AMBARI-21306 > > > Repository: ambari > > > Description > --- > > While running paragraphs with %jdbc(hive_interactive) - we get exception in > doAs > However, it works with %jdbc(hive) > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 75ca6a5f89 > > > Diff: https://reviews.apache.org/r/60363/diff/1/ > > > Testing > --- > > Manually tested on CentOS 6.4 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 60362: Zeppelin should have a preconfigured %jdbc(spark) interpreter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60362/#review178653 --- Ship it! Ship It! - Pallav Kulshreshtha On June 22, 2017, 10:41 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60362/ > --- > > (Updated June 22, 2017, 10:41 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and > venkat sairam. > > > Bugs: AMBARI-21304 > https://issues.apache.org/jira/browse/AMBARI-21304 > > > Repository: ambari > > > Description > --- > > If you install Zeppelin and have spark installed with STS it should come with > pre-configured %jdbc(spark) to point to the installed STS server > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 75ca6a5f89 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 2340df9dea > > > Diff: https://reviews.apache.org/r/60362/diff/1/ > > > Testing > --- > > Manually on CENTOS 6.4 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 60152: Add "zeppelin.server.ssl.port" in Zeppelin's setting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60152/#review178482 --- Ship it! Ship It! - Pallav Kulshreshtha On June 19, 2017, 7:10 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60152/ > --- > > (Updated June 19, 2017, 7:10 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and > venkat sairam. > > > Bugs: AMBARI-21271 > https://issues.apache.org/jira/browse/AMBARI-21271 > > > Repository: ambari > > > Description > --- > > Add "zeppelin.server.ssl.port" in Zeppelin's setting. This is in associated > with the changes made in https://issues.apache.org/jira/browse/ZEPPELIN-1321. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml > 85f1859509 > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml > 564dead112 > ambari-server/src/test/python/stacks/2.6/configs/default.json 2570657b70 > > > Diff: https://reviews.apache.org/r/60152/diff/2/ > > > Testing > --- > > Manually on CentOS 6.4 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 60129: Workflow submission fails when action node names contain white space
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60129/#review178471 --- Ship it! Ship It! - Pallav Kulshreshtha On June 15, 2017, 7 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60129/ > --- > > (Updated June 15, 2017, 7 p.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-21266 > https://issues.apache.org/jira/browse/AMBARI-21266 > > > Repository: ambari > > > Description > --- > > Validations have been written to check for white space in action node name > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > a6e1eeb > > > Diff: https://reviews.apache.org/r/60129/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 60076: Improve Zeppelin startup time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60076/#review177878 --- Ship it! Ship It! - Pallav Kulshreshtha On June 14, 2017, 11:14 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60076/ > --- > > (Updated June 14, 2017, 11:14 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-21243 > https://issues.apache.org/jira/browse/AMBARI-21243 > > > Repository: ambari > > > Description > --- > > Currently Zeppelin takes more than 1 minute to start. The bulk of the time > during startup is spent with waiting on interpreter.json. > > So the idea of this patch is to have interpeter.json cached, and apply it > does not exists. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/interpreter_json_template.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 3d516b0c68 > > > Diff: https://reviews.apache.org/r/60076/diff/1/ > > > Testing > --- > > Manually on CentOS 6 > > > Thanks, > > Prabhjyot Singh > >
Review Request 59909: Hive2. Query result improvements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59909/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-21198 https://issues.apache.org/jira/browse/AMBARI-21198 Repository: ambari Description --- - Checking if there is current Job Id created, then only showing the result panel. Diffs - contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 12a681c contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 6b395ac contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/results.js df970fb contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 395987f contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 7b27ba7 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs e9f1a50 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs 966312c Diff: https://reviews.apache.org/r/59909/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 59679: Hdfs directory viewer should be changed from tree view to list view.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59679/#review176727 --- Fix it, then Ship it! Ship It! contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json Lines 41 (patched) <https://reviews.apache.org/r/59679/#comment250178> Is there no specific version# for emeber colledction? - Pallav Kulshreshtha On May 31, 2017, 6:32 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59679/ > --- > > (Updated May 31, 2017, 6:32 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-21153 > https://issues.apache.org/jira/browse/AMBARI-21153 > > > Repository: ambari > > > Description > --- > > Hdfs directory viewer have been changed from tree view to list view with > added views. > > > Diffs > - > > > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/components/directory-viewer.js > 991d122 > > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/styles/app.css > PRE-CREATION > > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs > 75339c5 > > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/utils/viewer-config.js > 64773c6 > > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/bower.json > f016904 > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/index.js > dc074d7 > > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json > 66a7b20 > > > Diff: https://reviews.apache.org/r/59679/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Review Request 59445: Hive view 2.0 does not work on IE 11 browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59445/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-21086 https://issues.apache.org/jira/browse/AMBARI-21086 Repository: ambari Description --- Added browser pollyfill. Diffs - contrib/views/hive20/src/main/resources/ui/ember-cli-build.js 01682e7 contrib/views/hive20/src/main/resources/ui/vendor/browser-pollyfills.js PRE-CREATION Diff: https://reviews.apache.org/r/59445/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 59444: Hive view 1.5 does not work in Safari8 and IE11
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59444/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20812 https://issues.apache.org/jira/browse/AMBARI-20812 Repository: ambari Description --- Added browser pollyfills. Diffs - contrib/views/hive-next/src/main/resources/ui/hive-web/Brocfile.js 318d1f8 contrib/views/hive-next/src/main/resources/ui/hive-web/vendor/browser-pollyfills.js PRE-CREATION Diff: https://reviews.apache.org/r/59444/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 59087: Hive View 2.0 and 1.5 : The downloaded file name will be shown as ____.csv when we download the query result with the unicode name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59087/#review174290 --- Ship it! Ship It! - Pallav Kulshreshtha On May 9, 2017, 10:07 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59087/ > --- > > (Updated May 9, 2017, 10:07 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20962 > https://issues.apache.org/jira/browse/AMBARI-20962 > > > Repository: ambari > > > Description > --- > > made fileName as path param instead of query param. Now downloaded file's > name preserves unicode characters. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java > 5fa96bb0a8 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js > 8250dbbd84 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java > f2e4ee9b6c > contrib/views/hive20/src/main/resources/ui/app/adapters/job.js e40c0ba4ac > > > Diff: https://reviews.apache.org/r/59087/diff/1/ > > > Testing > --- > > Done testing on various browsers manually. > > > Thanks, > > Nitiraj Rathore > >
Review Request 59059: Runtime filtering is not rendering properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59059/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20519 https://issues.apache.org/jira/browse/AMBARI-20519 Repository: ambari Description --- - Accomodate JSON interface changes. - fix arrow position for bloom filter queries. Diffs - contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js 1a6d4b3 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js c880614 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 57fff1e Diff: https://reviews.apache.org/r/59059/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 58983: Changes in Zeppelin JDBC config after ZEPPELIN-2367
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58983/#review173887 --- Ship it! Ship It! - Pallav Kulshreshtha On May 4, 2017, 6:21 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58983/ > --- > > (Updated May 4, 2017, 6:21 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-20929 > https://issues.apache.org/jira/browse/AMBARI-20929 > > > Repository: ambari > > > Description > --- > > After ZEPPELIN-2367 there are configuration parameter changes that required > to make user impersonation for JDBC interpreter. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > c2f816399b > > > Diff: https://reviews.apache.org/r/58983/diff/1/ > > > Testing > --- > > Manually tested on Cent6.6 > > > Thanks, > > Prabhjyot Singh > >
Review Request 58917: Unable to view visual explain details in Firefox browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58917/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20912 https://issues.apache.org/jira/browse/AMBARI-20912 Repository: ambari Description --- minor sequence change Diffs - contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 3a23226 Diff: https://reviews.apache.org/r/58917/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 58842: wrong ZK parent node (hbase-unsecure) getting configured as part of the jdbc(phoenix) URL on ubuntu secured cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58842/#review173565 --- Ship it! Ship It! - Pallav Kulshreshtha On April 28, 2017, noon, Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58842/ > --- > > (Updated April 28, 2017, noon) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty. > > > Bugs: AMBARI-20888 > https://issues.apache.org/jira/browse/AMBARI-20888 > > > Repository: ambari > > > Description > --- > > wrong ZK parent node (hbase-unsecure) getting configured as part of the > jdbc(phoenix) URL on ubuntu secured cluster the jdbc(phoenix) url was getting > appended as /hbase-unsecure which is not correct > If you check the hbase-site.xml > > zookeeper.znode.parent > /hbase-secure > > I think how the phoenix URL is being constructed is not consistent across the > configs and we need to see why. On some of the other platforms, I have seen > it getting configured correctly (for e.g. Centos6 secured wire-encrypted) > Options > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > fbf2246672 > > > Diff: https://reviews.apache.org/r/58842/diff/1/ > > > Testing > --- > > Manually on Cent6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 58882: Ambari build failure after npm to yarn package manager migration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58882/#review173465 --- Ship it! Ship It! - Pallav Kulshreshtha On May 1, 2017, 12:57 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58882/ > --- > > (Updated May 1, 2017, 12:57 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Rohit Choudhary. > > > Bugs: AMBARI-20902 > https://issues.apache.org/jira/browse/AMBARI-20902 > > > Repository: ambari > > > Description > --- > > Added yarn.lock in RAT skip section > > > Diffs > - > > pom.xml 1cf13f4 > > > Diff: https://reviews.apache.org/r/58882/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58876: Need to show data in sorted order in Hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58876/#review173445 --- Ship it! Ship It! - Pallav Kulshreshtha On April 30, 2017, 10:15 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58876/ > --- > > (Updated April 30, 2017, 10:15 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20139 > https://issues.apache.org/jira/browse/AMBARI-20139 > > > Repository: ambari > > > Description > --- > > Data is shown in the folowing way. > Case 1: Tables list view in 'Query' Tab and 'Tables' tab > Tables should be listed in alphabetical order > Case 2: Jobs should be sorted based on Job Id in 'Jobs' tab. I guess > descending order makes sense. > Case 3 : 'Saved Queries' and 'UDFs' tab > Result should be sorted based on user action time. Recent action should come > first. > Case 4: 'Settings' tab : > Lexicographical order based on KEY. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js > be2771c > contrib/views/hive20/src/main/resources/ui/app/components/setting-list.js > 72a83a3 > contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js dc99fd1 > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > e896348 > contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 68e06a9 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 766157a > > contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs > 338828e > > contrib/views/hive20/src/main/resources/ui/app/templates/components/setting-list.hbs > c3f9c76 > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > ce7315f > contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs f2efaca > > > Diff: https://reviews.apache.org/r/58876/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58875: Ambari Header misaligned when transitioned to view route
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58875/ --- (Updated April 30, 2017, 4:58 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20899 https://issues.apache.org/jira/browse/AMBARI-20899 Repository: ambari Description --- minor css adjustments Diffs (updated) - ambari-web/app/styles/application.less 716e272 ambari-web/app/styles/bootstrap_overrides.less 09e68b6 Diff: https://reviews.apache.org/r/58875/diff/2/ Changes: https://reviews.apache.org/r/58875/diff/1-2/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 58875: Ambari Header misaligned when transitioned to view route
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58875/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20899 https://issues.apache.org/jira/browse/AMBARI-20899 Repository: ambari Description --- minor css adjustments Diffs - ambari-web/app/styles/application.less 716e272 ambari-web/app/styles/bootstrap_overrides.less 09e68b6 Diff: https://reviews.apache.org/r/58875/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 58834: Flapping tables in table browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58834/#review173426 --- Ship it! Ship It! - Pallav Kulshreshtha On April 28, 2017, 7:48 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58834/ > --- > > (Updated April 28, 2017, 7:48 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20882 > https://issues.apache.org/jira/browse/AMBARI-20882 > > > Repository: ambari > > > Description > --- > > The list which holds the pending calls of database fetch have been cleared. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/services/auto-refresh.js > b3276e7 > > > Diff: https://reviews.apache.org/r/58834/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 58835: Visual explain issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58835/#review173427 --- Ship it! Ship It! - Pallav Kulshreshtha On April 29, 2017, 7:04 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58835/ > --- > > (Updated April 29, 2017, 7:04 a.m.) > > > Review request for Ambari, Abhishek Kumar, belliraj hb, Padma Priya N, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20883 > https://issues.apache.org/jira/browse/AMBARI-20883 > > > Repository: ambari > > > Description > --- > > Used directed arrows rather than simple lines in visual explain and Issue in > connection lines for simple queries in visual-explain in Firefox have been > fixed. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > 4d9eff4 > > > Diff: https://reviews.apache.org/r/58835/diff/2/ > > > Testing > --- > > Manual testing have been done > > > Thanks, > > venkat sairam > >
Re: Review Request 58836: HiveView2.0: Visual Explain graph zooms out on scrolling down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58836/ --- (Updated April 29, 2017, 7:03 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20146 https://issues.apache.org/jira/browse/AMBARI-20146 Repository: ambari Description --- Introducing manual zoom in and zoom out. Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 29646cc contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 2edeab2 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js 298366f contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 4d9eff4 Diff: https://reviews.apache.org/r/58836/diff/2/ Changes: https://reviews.apache.org/r/58836/diff/1-2/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 58841: UI - Ambari top nav width changes for views applications
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58841/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20887 https://issues.apache.org/jira/browse/AMBARI-20887 Repository: ambari Description --- minor css change. Diffs - ambari-web/app/styles/application.less 23c534b ambari-web/app/styles/bootstrap_overrides.less a856d82 Diff: https://reviews.apache.org/r/58841/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 58836: HiveView2.0: Visual Explain graph zooms out on scrolling down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58836/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20146 https://issues.apache.org/jira/browse/AMBARI-20146 Repository: ambari Description --- Introducing manual zoom in and zoom out. Diffs - contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 29646cc contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 2edeab2 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 4d9eff4 Diff: https://reviews.apache.org/r/58836/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 58695: HIVE 2 -UX changes- Part1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58695/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20842 https://issues.apache.org/jira/browse/AMBARI-20842 Repository: ambari Description --- Made CSS related chages. Diffs - contrib/views/hive20/src/main/resources/ui/app/adapters/application.js 42935fc contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js 6005444 contrib/views/hive20/src/main/resources/ui/app/styles/app.scss f4b63c5 contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs 014691e contrib/views/hive20/src/main/resources/ui/app/templates/components/notification-message.hbs c2b32a1 contrib/views/hive20/src/main/resources/ui/app/templates/components/table-rename-form.hbs b692a9c contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs cdcf762 contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-edit.hbs 24cb495 contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-item.hbs 929b91a contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-new.hbs ddf34d7 contrib/views/hive20/src/main/resources/ui/app/templates/databases.hbs ecedef5 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 989cfc3 contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs c0b5e82 contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs ef6a01c Diff: https://reviews.apache.org/r/58695/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 58206: Complete node name is not shown when node name is larger than 17 characters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58206/ --- (Updated April 21, 2017, 3:43 p.m.) Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20678 https://issues.apache.org/jira/browse/AMBARI-20678 Repository: ambari Description --- Introduced ellipsis css class and showing complete name as tooltip. Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/adapters/application.js 42935fc contrib/views/hive20/src/main/resources/ui/app/styles/app.scss f4b63c5 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 78aa39d Diff: https://reviews.apache.org/r/58206/diff/2/ Changes: https://reviews.apache.org/r/58206/diff/1-2/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 58616: Need a confirmation dialog for table / database delete
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58616/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20815 https://issues.apache.org/jira/browse/AMBARI-20815 Repository: ambari Description --- Added a dialog for taking confirmation from the user for table delete. Diffs - contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js 53055cf contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table.hbs 2fe3cfb Diff: https://reviews.apache.org/r/58616/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 58232: Hive view holds the operational logs open and also fills /tmp
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58232/#review172594 --- Ship it! Ship It! - Pallav Kulshreshtha On April 6, 2017, 1:02 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58232/ > --- > > (Updated April 6, 2017, 1:02 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20690 > https://issues.apache.org/jira/browse/AMBARI-20690 > > > Repository: ambari > > > Description > --- > > sync connections were not getting closed after 10 mins window of inactivity. > removed the incorrect call to stop scheduler > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/HiveActor.java > 36bc430b7f > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java > 997c28aab3 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/OperationController.java > 98e60f2610 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/HiveActor.java > 384b7982bd > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > f93ecbffb3 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/OperationController.java > f751d8f54b > > > Diff: https://reviews.apache.org/r/58232/diff/1/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Review Request 58206: Complete node name is not shown when node name is larger than 17 characters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58206/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20678 https://issues.apache.org/jira/browse/AMBARI-20678 Repository: ambari Description --- Introduced ellipsis css class and showing complete name as tooltip. Diffs - contrib/views/hive20/src/main/resources/ui/app/styles/app.scss f4b63c5 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 1cfcb15 Diff: https://reviews.apache.org/r/58206/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 58179: For sort/partition operator, if there is only 1 reducer, display just "sort" rather than "sort/partition"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58179/#review171095 --- Ship it! Ship It! - Pallav Kulshreshtha On April 4, 2017, 5:08 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58179/ > --- > > (Updated April 4, 2017, 5:08 p.m.) > > > Review request for Ambari, Abhishek Kumar, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20673 > https://issues.apache.org/jira/browse/AMBARI-20673 > > > Repository: ambari > > > Description > --- > > Now when we have only one reducer, the label for aort/partition will be > displayed as partition. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > 1cfcb15 > > > Diff: https://reviews.apache.org/r/58179/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Review Request 58144: HiveView2.0 scrolling in query tab does not work properly for a longer query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58144/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20660 https://issues.apache.org/jira/browse/AMBARI-20660 Repository: ambari Description --- Adding a bottom padding for fixing this issue. Diffs - contrib/views/hive20/src/main/resources/ui/app/styles/app.scss e083922 Diff: https://reviews.apache.org/r/58144/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 58140: Usability: screen jumps when you scroll down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58140/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20657 https://issues.apache.org/jira/browse/AMBARI-20657 Repository: ambari Description --- Made the css changes related to min-height of the container. Diffs - contrib/views/hive20/src/main/resources/ui/app/styles/app.scss e083922 contrib/views/hive20/src/main/resources/ui/app/styles/bootstrap-overrides.scss 4b7bec4 contrib/views/hive20/src/main/resources/ui/app/templates/application.hbs 53b2192 Diff: https://reviews.apache.org/r/58140/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 58100: Remove configuring JDBC dependencies that are getting configured for Zeppelin interpreter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58100/#review170682 --- Ship it! Ship It! - Pallav Kulshreshtha On March 31, 2017, 6:57 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58100/ > --- > > (Updated March 31, 2017, 6:57 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-20643 > https://issues.apache.org/jira/browse/AMBARI-20643 > > > Repository: ambari > > > Description > --- > > Remove configuring JDBC dependencies that are getting configured for Zeppelin > interpreter as it causes more confusion than the resolution. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 2b21f8fe1f > > > Diff: https://reviews.apache.org/r/58100/diff/1/ > > > Testing > --- > > Manuaully tested on Ubuntu 14.04 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 57979: hive view 2.0 handling partition table statistics support added in hive server 2.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/#review170286 --- Ship it! Ship It! - Pallav Kulshreshtha On March 27, 2017, 11:29 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57979/ > --- > > (Updated March 27, 2017, 11:29 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20598 > https://issues.apache.org/jira/browse/AMBARI-20598 > > > Repository: ambari > > > Description > --- > > added support for stats of partitioned table > for hive server version 2.1 and above > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/ConnectionDelegate.java > f3c4e91e0b > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveJdbcConnectionDelegate.java > 5cc60fbb75 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > 45fc786a38 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java > c3ed14b2a3 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/GetDatabaseMetadataJob.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/ResultInformation.java > 5b5e17c38d > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/job/Result.java > f8c3ba0fb4 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegator.java > baa82b4d12 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegatorImpl.java > ef4f100ab1 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DatabaseMetadataWrapper.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnStats.java > 190ecd36cb > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java > 3048d22190 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParser.java > aae23c8ba8 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java > f2a1933d98 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java > 0c93ba31c5 > > contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js > 0310cbc005 > contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js > 620bf9b61b > > contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs > 5f62fca4e7 > > > Diff: https://reviews.apache.org/r/57979/diff/1/ > > > Testing > --- > > manual testing done for hive 2.1 and hive 1.2 for partitioned and non > partitioned tables. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57956: Pig view doesn't load in older version of firefox
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57956/#review170171 --- Ship it! Ship It! - Pallav Kulshreshtha On March 27, 2017, 1:09 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57956/ > --- > > (Updated March 27, 2017, 1:09 p.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20584 > https://issues.apache.org/jira/browse/AMBARI-20584 > > > Repository: ambari > > > Description > --- > > ES6 syntax specifications which are not supported in older versions of > browsers are removed > > > Diffs > - > > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js > 4451b84 > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js > 5cfeac7 > > > Diff: https://reviews.apache.org/r/57956/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57957: Hive view(1.5) doesn't load in older version of firefox
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57957/#review170170 --- Ship it! Ship It! - Pallav Kulshreshtha On March 27, 2017, 1:12 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57957/ > --- > > (Updated March 27, 2017, 1:12 p.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20585 > https://issues.apache.org/jira/browse/AMBARI-20585 > > > Repository: ambari > > > Description > --- > > ES6 syntax specifications which are not supported in older versions of > browsers are removed > > > Diffs > - > > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/splash.js > 423a0e3 > contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js > 7e35340 > > > Diff: https://reviews.apache.org/r/57957/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57942: Issue in pig view after enabling strict mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57942/#review170137 --- Ship it! Ship It! - Pallav Kulshreshtha On March 27, 2017, 4:01 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57942/ > --- > > (Updated March 27, 2017, 4:01 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20576 > https://issues.apache.org/jira/browse/AMBARI-20576 > > > Repository: ambari > > > Description > --- > > Fixed vairable undefined errors after enabling strict mode > > > Diffs > - > > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js > 66e1c88 > > > Diff: https://reviews.apache.org/r/57942/diff/1/ > > > Testing > --- > > Manual tetsing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57930: Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed - 2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57930/#review170134 --- Ship it! Ship It! - Pallav Kulshreshtha On March 25, 2017, 6:16 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57930/ > --- > > (Updated March 25, 2017, 6:16 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-20539 > https://issues.apache.org/jira/browse/AMBARI-20539 > > > Repository: ambari > > > Description > --- > > Since https://reviews.apache.org/r/57872/ has already merged in trunk hence > openeing a new review, this in an incremental patch to that. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > eb6ec01 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 6ba2a87 > > > Diff: https://reviews.apache.org/r/57930/diff/1/ > > > Testing > --- > > Manually on centOS 6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 57914: upgrade frontend-maven-plugin to latest >= 1.3 to make use of ignore proxy feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57914/#review170120 --- Ship it! Ship It! - Pallav Kulshreshtha On March 26, 2017, 7:05 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57914/ > --- > > (Updated March 26, 2017, 7:05 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20549 > https://issues.apache.org/jira/browse/AMBARI-20549 > > > Repository: ambari > > > Description > --- > > We have changed the path for node modules in pom.xml and package.json > accordingly > > > Diffs > - > > contrib/views/capacity-scheduler/pom.xml b8c4dae > contrib/views/files/pom.xml b075ec7 > contrib/views/hawq/pom.xml 2aa04e0 > contrib/views/hive-next/pom.xml 50563ac > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 5c5435e > contrib/views/hive20/pom.xml e672b3f > contrib/views/hive20/src/main/resources/ui/package.json 98c465f > contrib/views/hueambarimigration/pom.xml f131b3b > contrib/views/jobs/pom.xml d58ce10 > contrib/views/pig/pom.xml 689909f > contrib/views/wfmanager/pom.xml 69784e3 > contrib/views/wfmanager/src/main/resources/ui/pom.xml 8bdb332 > > > Diff: https://reviews.apache.org/r/57914/diff/2/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57872: Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57872/#review169988 --- Ship it! Ship It! - Pallav Kulshreshtha On March 23, 2017, 11:26 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57872/ > --- > > (Updated March 23, 2017, 11:26 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-20539 > https://issues.apache.org/jira/browse/AMBARI-20539 > > > Repository: ambari > > > Description > --- > > Interpreters that are not listed under "zeppelin.interpreter.group.order" in > zeppelin-site.xml should not get installed and get configured. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml > 039c701 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 38bfeb4 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 0a0acdb > ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce > > > Diff: https://reviews.apache.org/r/57872/diff/1/ > > > Testing > --- > > Manually on CentOS6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 57811: Runtime filtering is not rendering properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57811/ --- (Updated March 22, 2017, 4:02 p.m.) Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20519 https://issues.apache.org/jira/browse/AMBARI-20519 Repository: ambari Description --- Found Pattern Group By -> Reduce -> Group By -> Broadcast and club them in a single node 'Build Bloom Filter' Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js f6d3704 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js ac592ec Diff: https://reviews.apache.org/r/57811/diff/2/ Changes: https://reviews.apache.org/r/57811/diff/1-2/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 57842: Tez view not loading in secure mode.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57842/ --- (Updated March 22, 2017, 1:40 p.m.) Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20530 https://issues.apache.org/jira/browse/AMBARI-20530 Repository: ambari Description --- Added a check in ENV, setting it empty if not found. Diffs - contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 0e0bdee Diff: https://reviews.apache.org/r/57842/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 57842: Tez view not loading in secure mode.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57842/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Repository: ambari Description --- Added a check in ENV, setting it empty if not found. Diffs - contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 0e0bdee Diff: https://reviews.apache.org/r/57842/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 57806: make home directory check as optional in hive20 view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57806/#review169694 --- Ship it! Ship It! - Pallav Kulshreshtha On March 21, 2017, 2:10 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57806/ > --- > > (Updated March 21, 2017, 2:10 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20517 > https://issues.apache.org/jira/browse/AMBARI-20517 > > > Repository: ambari > > > Description > --- > > added property > views.skip.home-directory-check.file-system.list to skip home directory > checks in hive20 view > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/Constants.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/HdfsApiSupplier.java > 8adac24 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/system/ServiceCheck.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/system/SystemService.java > dd5bb06 > contrib/views/hive20/src/main/resources/ui/app/adapters/service-check.js > 22bf1b6 > > contrib/views/hive20/src/main/resources/ui/app/configs/service-check-status.js > 2810e80 > contrib/views/hive20/src/main/resources/ui/app/controllers/service-check.js > 10552ea > contrib/views/hive20/src/main/resources/ui/app/routes/service-check.js > 83111cd > contrib/views/hive20/src/main/resources/ui/app/services/service-check.js > a5a4755 > contrib/views/hive20/src/main/resources/ui/app/templates/service-check.hbs > 2a867aa > > > Diff: https://reviews.apache.org/r/57806/diff/1/ > > > Testing > --- > > tested cases where no property is present or no filesystem is present in the > property. > also tested cases where no service checks are done or odd number of service > checks are done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57831: make home directory check as optional in hive view 1.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57831/#review169693 --- Ship it! Ship It! - Pallav Kulshreshtha On March 22, 2017, 7:32 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57831/ > --- > > (Updated March 22, 2017, 7:32 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Ashwin > Rajeev. > > > Bugs: AMBARI-20523 > https://issues.apache.org/jira/browse/AMBARI-20523 > > > Repository: ambari > > > Description > --- > > used the property views.skip.home-directory-check.file-system.list in > ambari-server.properties to exclude home directory test when connecting to > those filesystems. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/HelpService.java > afc2939 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/utils/Constants.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/utils/ServiceCheck.java > PRE-CREATION > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/service-check.js > PRE-CREATION > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/splash.js > 1bf6d42 > contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js > 179a912 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/splash.hbs > 5612542 > > > Diff: https://reviews.apache.org/r/57831/diff/1/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57835: make home directory check as optional in Pig view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57835/#review169692 --- Ship it! Ship It! - Pallav Kulshreshtha On March 22, 2017, 11:23 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57835/ > --- > > (Updated March 22, 2017, 11:23 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Renjith Kamath. > > > Bugs: AMBARI-20527 > https://issues.apache.org/jira/browse/AMBARI-20527 > > > Repository: ambari > > > Description > --- > > used property views.skip.home-directory-check.file-system.list in > ambari.properties to skip home directory test based on the filesystem set in > fs.defaultFS > > > Diffs > - > > ambari-server/conf/unix/ambari.properties 5866fe7 > ambari-server/conf/windows/ambari.properties c1c0a99 > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/services/HelpService.java > a67bfc5 > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/Constants.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/ServiceCheck.java > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js > d1b571d > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js > b30552d > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/splash.hbs > c97d724 > > > Diff: https://reviews.apache.org/r/57835/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57776: Hive View2.0: Upload table fails, if one column is deleted
> On March 20, 2017, 1:11 p.m., Nitiraj Rathore wrote: > > contrib/views/hive20/src/main/resources/ui/app/components/column-item.js > > Line 27 (original), 27 (patched) > > <https://reviews.apache.org/r/57776/diff/1/?file=1668371#file1668371line27> > > > > Make this options object instead. Niti, uploaded the code with suggested changes.Pls have a look. - Pallav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57776/#review169432 --- On March 20, 2017, 2:12 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57776/ > --- > > (Updated March 20, 2017, 2:12 p.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20497 > https://issues.apache.org/jira/browse/AMBARI-20497 > > > Repository: ambari > > > Description > --- > > Added a var 'fromUploadTable' as true when it comes from upload table > otherwise false. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js > e6b71fe > > contrib/views/hive20/src/main/resources/ui/app/templates/components/column-item.hbs > 762c77c > > contrib/views/hive20/src/main/resources/ui/app/templates/components/create-table.hbs > f369783 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/table-columns.hbs > b942136 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs > 0ee6b81 > > contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/upload-table.hbs > 0091ede > > > Diff: https://reviews.apache.org/r/57776/diff/2/ > > > Testing > --- > > manually test. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57776: Hive View2.0: Upload table fails, if one column is deleted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57776/ --- (Updated March 20, 2017, 2:12 p.m.) Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20497 https://issues.apache.org/jira/browse/AMBARI-20497 Repository: ambari Description --- Added a var 'fromUploadTable' as true when it comes from upload table otherwise false. Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js e6b71fe contrib/views/hive20/src/main/resources/ui/app/templates/components/column-item.hbs 762c77c contrib/views/hive20/src/main/resources/ui/app/templates/components/create-table.hbs f369783 contrib/views/hive20/src/main/resources/ui/app/templates/components/table-columns.hbs b942136 contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs 0ee6b81 contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/upload-table.hbs 0091ede Diff: https://reviews.apache.org/r/57776/diff/2/ Changes: https://reviews.apache.org/r/57776/diff/1-2/ Testing --- manually test. Thanks, Pallav Kulshreshtha
Review Request 57776: Hive View2.0: Upload table fails, if one column is deleted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57776/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20497 https://issues.apache.org/jira/browse/AMBARI-20497 Repository: ambari Description --- Added a var 'fromUploadTable' as true when it comes from upload table otherwise false. Diffs - contrib/views/hive20/src/main/resources/ui/app/components/column-item.js f2e45bd contrib/views/hive20/src/main/resources/ui/app/components/create-table.js 322aab5 contrib/views/hive20/src/main/resources/ui/app/components/table-columns.js 7d83353 contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js e6b71fe contrib/views/hive20/src/main/resources/ui/app/templates/components/column-item.hbs 762c77c contrib/views/hive20/src/main/resources/ui/app/templates/components/create-table.hbs f369783 contrib/views/hive20/src/main/resources/ui/app/templates/components/table-columns.hbs b942136 contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs 0ee6b81 contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/upload-table.hbs 0091ede Diff: https://reviews.apache.org/r/57776/diff/1/ Testing --- manually test. Thanks, Pallav Kulshreshtha
Re: Review Request 57590: Zeppelin: service def not using the correct value from hive.server2.support.dynamic.service.discovery for Hive interpreter config
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57590/#review169020 --- Ship it! Ship It! - Pallav Kulshreshtha On March 14, 2017, 8:58 a.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57590/ > --- > > (Updated March 14, 2017, 8:58 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-20439 > https://issues.apache.org/jira/browse/AMBARI-20439 > > > Repository: ambari > > > Description > --- > > Zeppelin: service def not using the correct value from > hive.server2.support.dynamic.service.discovery for Hive interpreter config > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > fdc96db17b > > > Diff: https://reviews.apache.org/r/57590/diff/1/ > > > Testing > --- > > Manual testing on CentOS > > > Thanks, > > Renjith Kamath > >
Re: Review Request 57075: hive-site.xml, hbase-site.xml, etc. are not found in class path for Zeppelin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57075/#review168990 --- Ship it! Ship It! - Pallav Kulshreshtha On March 14, 2017, 7:08 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57075/ > --- > > (Updated March 14, 2017, 7:08 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-20200 > https://issues.apache.org/jira/browse/AMBARI-20200 > > > Repository: ambari > > > Description > --- > > hive-site.xml, hbase-site.xml, etc. are not found in class path for > Zeppelin's interpreter. > > As a result of which JDBC:phoenix on kerberos mode doesn't work. > > > Diffs > - > > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml > 1f65fac > > > Diff: https://reviews.apache.org/r/57075/diff/7/ > > > Testing > --- > > Manually on CentOS6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 57515: Zeppelin: Spark2 and Livy2 interpreter config disappear during stack upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57515/#review168869 --- Ship it! Ship It! - Pallav Kulshreshtha On March 10, 2017, 5:47 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57515/ > --- > > (Updated March 10, 2017, 5:47 p.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-20397 > https://issues.apache.org/jira/browse/AMBARI-20397 > > > Repository: ambari > > > Description > --- > > During stack upgrade spark2 and livy2 interpreters are not present in > zeppelin by default. Typically for a fresh install- when spark2 service is > detected , those 2 interpreters are by default created for user out-of-the box > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > a460aecad0 > > > Diff: https://reviews.apache.org/r/57515/diff/1/ > > > Testing > --- > > Manually tested the stack upgrade on CentOS > > > Thanks, > > Renjith Kamath > >
Review Request 57555: Need some way to know a plan is vectorized
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57555/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20416 https://issues.apache.org/jira/browse/AMBARI-20416 Repository: ambari Description --- added property for determining vectorization. Diffs - contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js fd450cc contrib/views/hive20/src/main/resources/ui/app/routes/databases.js 02dbcac contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables.js f5940e3 contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain-detail.hbs 3df8e94 contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 30f9405 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js b36d7b4 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js d88de98 Diff: https://reviews.apache.org/r/57555/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 57454: WFM: Delete option in Manage recent list.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57454/#review168438 --- Ship it! Ship It! - Pallav Kulshreshtha On March 9, 2017, 10:44 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57454/ > --- > > (Updated March 9, 2017, 10:44 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20371 > https://issues.apache.org/jira/browse/AMBARI-20371 > > > Repository: ambari > > > Description > --- > > We have provided an option to delete the workflow from recent list. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 0e49d70 > contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js > 1d01e9b > > contrib/views/wfmanager/src/main/resources/ui/app/components/recent-projects.js > 18a57f6 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less a30833c > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs > c8d8dc3 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs > 632d6bd > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/recent-projects.hbs > cd8f6af > > > Diff: https://reviews.apache.org/r/57454/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57446: Enable Authentication in Zeppelin out of Box
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57446/#review168413 --- Ship it! Ship It! - Pallav Kulshreshtha On March 9, 2017, 6:32 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57446/ > --- > > (Updated March 9, 2017, 6:32 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty. > > > Bugs: AMBARI-20362 > https://issues.apache.org/jira/browse/AMBARI-20362 > > > Repository: ambari > > > Description > --- > > Enable Authentication in Zeppelin out of Box. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml > 3e2da1e > > > Diff: https://reviews.apache.org/r/57446/diff/1/ > > > Testing > --- > > Manually tested on CentOS 6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 57380: Zeppelin: Configure both Hive and Hive interactive interpreters whenever required
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57380/#review168407 --- Ship it! Ship It! - Pallav Kulshreshtha On March 7, 2017, 4:49 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57380/ > --- > > (Updated March 7, 2017, 4:49 p.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-20343 > https://issues.apache.org/jira/browse/AMBARI-20343 > > > Repository: ambari > > > Description > --- > > please ref JIRA > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > fc24918077 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 9fd105b0a1 > > > Diff: https://reviews.apache.org/r/57380/diff/1/ > > > Testing > --- > > Manually tested on CentOS > > > Thanks, > > Renjith Kamath > >
Re: Review Request 57416: [Hive2] JS error in udf delete
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57416/ --- (Updated March 8, 2017, 5:20 p.m.) Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20357 https://issues.apache.org/jira/browse/AMBARI-20357 Repository: ambari Description --- Change the code to make sure the data get persists and no operation happens in flight. Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js 44f56e5 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 80116da contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 138e85f contrib/views/hive20/src/main/resources/ui/app/routes/udfs/new.js 84733e8 contrib/views/hive20/src/main/resources/ui/app/services/auto-refresh.js 2e8ec62 contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-item.hbs fec48fb Diff: https://reviews.apache.org/r/57416/diff/2/ Changes: https://reviews.apache.org/r/57416/diff/1-2/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 57416: [Hive2] JS error in udf delete
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57416/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20357 https://issues.apache.org/jira/browse/AMBARI-20357 Repository: ambari Description --- Change the code to make sure the data get persists and no operation happens in flight. Diffs - contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js 44f56e5 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 08af7d4 contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 138e85f contrib/views/hive20/src/main/resources/ui/app/routes/udfs/new.js 84733e8 contrib/views/hive20/src/main/resources/ui/app/services/auto-refresh.js 2e8ec62 contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-item.hbs fec48fb contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs ef6a01c Diff: https://reviews.apache.org/r/57416/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 57413: WFM. Import/Export asset label changes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57413/#review168258 --- Ship it! Ship It! - Pallav Kulshreshtha On March 8, 2017, 8:01 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57413/ > --- > > (Updated March 8, 2017, 8:01 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20355 > https://issues.apache.org/jira/browse/AMBARI-20355 > > > Repository: ambari > > > Description > --- > > Labels has to be changed from > > Import Asset > Import Assets to HDFS > Publish Asset > Publish Asset to HDFS > Import from HDFS > > to > > Import Asset from Local Ambari Database > Import Asset from Shared File System > Save Asset to Local Ambari Database > Save Asset to Shared File System > Import from Shared File System > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > b5c3807 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs > 75ec872 > > > Diff: https://reviews.apache.org/r/57413/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57370: Issue with toggling of Execute/Stop button in query page while successful and failure execution of query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57370/#review168119 --- Ship it! Ship It! - Pallav Kulshreshtha On March 7, 2017, 11:40 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57370/ > --- > > (Updated March 7, 2017, 11:40 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20340 > https://issues.apache.org/jira/browse/AMBARI-20340 > > > Repository: ambari > > > Description > --- > > We have passed the scope of controller to the function to execute it in the > respecitve scope as closure. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > e1ab620 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1b18955 > > > Diff: https://reviews.apache.org/r/57370/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Review Request 57368: JS Lint warning removal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57368/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20339 https://issues.apache.org/jira/browse/AMBARI-20339 Repository: ambari Description --- Corrected all the errros/warnings came through JS Lint Diffs - contrib/views/hive20/src/main/resources/ui/.jshintrc d421faa contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js a25adc7 contrib/views/hive20/src/main/resources/ui/app/adapters/hdfs-viewer.js dcd52b8 contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 7559e9c contrib/views/hive20/src/main/resources/ui/app/adapters/query.js 4913fe2 contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js a25adc7 contrib/views/hive20/src/main/resources/ui/app/adapters/table-info.js 46e7591 contrib/views/hive20/src/main/resources/ui/app/adapters/table.js e133419 contrib/views/hive20/src/main/resources/ui/app/adapters/udf.js c929de7 contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js 3bfe15b contrib/views/hive20/src/main/resources/ui/app/components/create-table.js 670ebd7 contrib/views/hive20/src/main/resources/ui/app/components/edit-table.js 439dbcf contrib/views/hive20/src/main/resources/ui/app/components/export-result.js 517da1e contrib/views/hive20/src/main/resources/ui/app/components/fileresource-item.js 12cfb5b contrib/views/hive20/src/main/resources/ui/app/components/job-item.js 8a6d318 contrib/views/hive20/src/main/resources/ui/app/components/list-filter.js db0b5c0 contrib/views/hive20/src/main/resources/ui/app/components/notification-message.js 339e095 contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js c033e42 contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js a2eb349 contrib/views/hive20/src/main/resources/ui/app/components/table-advanced-settings.js 5e58cd8 contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js 9e11550 contrib/views/hive20/src/main/resources/ui/app/components/udf-new.js 285ef07 contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js 2379a15 contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 8f216d1 contrib/views/hive20/src/main/resources/ui/app/configs/datatypes.js 0d07ce2 contrib/views/hive20/src/main/resources/ui/app/controllers/service-check.js 8a621db contrib/views/hive20/src/main/resources/ui/app/helpers/extract-value.js 76b3dee contrib/views/hive20/src/main/resources/ui/app/helpers/format-column-size.js a24f797 contrib/views/hive20/src/main/resources/ui/app/models/table-property.js 751f55c contrib/views/hive20/src/main/resources/ui/app/router.js 250f945 contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js b29d863 contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js 2fa61b4 contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js e4c543b contrib/views/hive20/src/main/resources/ui/app/routes/jobs.js c27c74d contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js e1ab620 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/log.js 52f8dcc contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js f3b27c8 contrib/views/hive20/src/main/resources/ui/app/routes/settings.js f45881b contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js fdb2cad contrib/views/hive20/src/main/resources/ui/app/services/jobs.js fe1b596 contrib/views/hive20/src/main/resources/ui/app/services/query.js 6860f4d contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 2752375 contrib/views/hive20/src/main/resources/ui/app/services/service-check.js 608cafe contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js bb3ed3e contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 2071317 contrib/views/hive20/src/main/resources/ui/app/services/udf.js 915e3d0 contrib/views/hive20/src/main/resources/ui/app/templates/components/table-advanced-settings.hbs da1c0b4 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js a99b82e contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer-force.js a73d1b2 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 1f6ba3c contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 4a7df10 Diff: https://reviews.apache.org/r/57368/diff/1/ Testing --- manually tested. Thanks, Pallav
Re: Review Request 57291: HiveView2.0: Issues in worksheet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57291/#review167957 --- Ship it! Ship It! - Pallav Kulshreshtha On March 3, 2017, 3:11 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57291/ > --- > > (Updated March 3, 2017, 3:11 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20303 > https://issues.apache.org/jira/browse/AMBARI-20303 > > > Repository: ambari > > > Description > --- > > Worksheet tab is provided with the button to close the worksheet and upon > double-click of worksheet tab, rename modal will be opened. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js f820ea0 > contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 4ef3834 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js > 7bd2214 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > d08a47b > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6b7fc6a > contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs > b8e19da > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 8a771eb > > > Diff: https://reviews.apache.org/r/57291/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57289: AMBARI-20301. Ember should take node version specific to wfmanager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57289/#review167821 --- Ship it! Ship It! - Pallav Kulshreshtha On March 3, 2017, 1:47 p.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57289/ > --- > > (Updated March 3, 2017, 1:47 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20301 > https://issues.apache.org/jira/browse/AMBARI-20301 > > > Repository: ambari > > > Description > --- > > Changing the execution of ember from local node > > > Diffs > - > > contrib/views/wfmanager/pom.xml 564a82d > > > Diff: https://reviews.apache.org/r/57289/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57275: WFM FS editor needs to maintain order of FS operations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57275/#review167808 --- Ship it! Ship It! - Pallav Kulshreshtha On March 3, 2017, 10:40 a.m., belliraj hb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57275/ > --- > > (Updated March 3, 2017, 10:40 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-20293 > https://issues.apache.org/jira/browse/AMBARI-20293 > > > Repository: ambari > > > Description > --- > > WFM FS editor needs to maintain order of FS operations > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > 305861010c > contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js > 12d12d2754 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > dd63a3a995 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > 72235815e0 > > > Diff: https://reviews.apache.org/r/57275/diff/1/ > > > Testing > --- > > Manual testing. > > > Thanks, > > belliraj hb > >
Review Request 57279: Simple queries show "no tez plan found"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57279/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20294 https://issues.apache.org/jira/browse/AMBARI-20294 Repository: ambari Description --- Added condition for showing the plan for simple queries. Diffs - contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js fc7cf64 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js d08a47b contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js 2310b3c contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js 3513a23 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js 48706cb contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js f69b1d4 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js e6cf3f3 Diff: https://reviews.apache.org/r/57279/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 57248: Visual explain is not routing to visual explain tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57248/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20274 https://issues.apache.org/jira/browse/AMBARI-20274 Repository: ambari Description --- changed the logic to re-direct to visual explain route if 'visual explain' button is clicked. Diffs - contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js cf51ff7 Diff: https://reviews.apache.org/r/57248/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 57196: Tez UI throwing 404 error, Button to minimise TEZ UI, Worksheet save issues, creation of duplicate tabs and other tab issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57196/#review167271 --- Ship it! Ship It! - Pallav Kulshreshtha On March 1, 2017, 12:41 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57196/ > --- > > (Updated March 1, 2017, 12:41 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20251 > https://issues.apache.org/jira/browse/AMBARI-20251 > > > Repository: ambari > > > Description > --- > > Tez UI errors are handled in query page, button to maximise and minimise Tez > UI is given, issue of creation of duplicate tabs is solved by using ID in > route instead of title, issues in saving a query and opening the saved query > have been solved as we are now using tab instead if title. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js > f2af6bc > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 4ac93db > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js > c85db19 > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > 5369f8e > contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js > 943d002 > contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs > 6fc7486 > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs > edc1e8e > > > Diff: https://reviews.apache.org/r/57196/diff/2/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57198: HiveView2.0: Can not create a table with space in column name with upload table feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57198/#review167268 --- Ship it! Ship It! - Pallav Kulshreshtha On March 1, 2017, 10:23 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57198/ > --- > > (Updated March 1, 2017, 10:23 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20181 > https://issues.apache.org/jira/browse/AMBARI-20181 > > > Repository: ambari > > > Description > --- > > added back ticks in the query > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java > 9f179d1 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGenerator.java > eab3a4b > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java > 42cec0a > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGeneratorTest.java > f5a9778 > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGeneratorSpecTest.groovy > PRE-CREATION > > > Diff: https://reviews.apache.org/r/57198/diff/1/ > > > Testing > --- > > added InsertFromQueryGeneratorSpecTest.groovy test class > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57137: Table statistics is not getting computed when 'include columns' is checked
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57137/#review167269 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017, 11:24 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57137/ > --- > > (Updated Feb. 28, 2017, 11:24 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20091 > https://issues.apache.org/jira/browse/AMBARI-20091 > > > Repository: ambari > > > Description > --- > > 1) analyze table compute stats for columns > 2) analyze table compute stats > > First one is to collect column statistics and second one is to collect basic > stats. numRows, dataSize etc. is computed via 2) > To get all stats one has to run both statements. > > Hence implemented in that way. > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java > 902d959 > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy > PRE-CREATION > > > Diff: https://reviews.apache.org/r/57137/diff/1/ > > > Testing > --- > > added spock test AnalyzeTableQueryGeneratorSpecTest.groovy > > > Thanks, > > Nitiraj Rathore > >
Review Request 57188: HiveView2.0: Misplaced download results popup when result set is longer causing UI to appear as hung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57188/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20250 https://issues.apache.org/jira/browse/AMBARI-20250 Repository: ambari Description --- Added a CSS to ovveride the default css. Diffs - contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 2824dc6 Diff: https://reviews.apache.org/r/57188/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 57148: HiveView 2.0: save as HDFS shows success message on error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57148/#review167224 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017, 3:23 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57148/ > --- > > (Updated Feb. 28, 2017, 3:23 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20236 > https://issues.apache.org/jira/browse/AMBARI-20236 > > > Repository: ambari > > > Description > --- > > There is no error thrown from the backend in case of failure. Now handle this > case. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/backgroundjobs/BackgroundJobController.java > bd3bb23 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/backgroundjobs/BackgroundJobException.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java > 6eedcca > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/backgroundjobs/BackgroundJobController.java > 0b21a18 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/backgroundjobs/BackgroundJobException.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java > c5479e7 > > > Diff: https://reviews.apache.org/r/57148/diff/1/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 57136: Pom.xml change in Workflow manager to fix the version of front end plugin to make it compatible with the maven version used in ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57136/#review167100 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017, 11:24 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57136/ > --- > > (Updated Feb. 28, 2017, 11:24 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20230 > https://issues.apache.org/jira/browse/AMBARI-20230 > > > Repository: ambari > > > Description > --- > > The version for front end plugin has to be changed to make it compatible with > the maven version used in Amabri > > > Diffs > - > > contrib/views/wfmanager/pom.xml 6f0b848 > > Diff: https://reviews.apache.org/r/57136/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57120: Hive View 2.0 LogAggregator prints lots of warning logs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57120/#review167066 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017, 4:55 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57120/ > --- > > (Updated Feb. 28, 2017, 4:55 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20222 > https://issues.apache.org/jira/browse/AMBARI-20222 > > > Repository: ambari > > > Description > --- > > Stopping the statement executor after query end or failure. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java > d6d5d51 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveViewImpl.java > aee7d03 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > 61f0b66 > > Diff: https://reviews.apache.org/r/57120/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 57126: HiveView2.0: Logs tab is always empty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57126/#review167065 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017, 6:44 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57126/ > --- > > (Updated Feb. 28, 2017, 6:44 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20224 > https://issues.apache.org/jira/browse/AMBARI-20224 > > > Repository: ambari > > > Description > --- > > Remove extra '/' from url > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/query.js f878230 > > Diff: https://reviews.apache.org/r/57126/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 57124: Hive view 2.0 Fetch stats doesn't work when you point against LLAP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57124/#review167064 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017, 5:32 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57124/ > --- > > (Updated Feb. 28, 2017, 5:32 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20223 > https://issues.apache.org/jira/browse/AMBARI-20223 > > > Repository: ambari > > > Description > --- > > For fetching stats we are using old query syntax that wont work in Hive 2.0. > Changed the query to newer syntax. > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGenerator.java > b119f6a > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java > 902d959 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/FetchColumnStatsQueryGenerator.java > 73b3698 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java > 42cec0a > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGenerator.java > 3406b80 > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGeneratorTest.java > 35ea416 > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGeneratorSpecTest.groovy > cce9e6c > > Diff: https://reviews.apache.org/r/57124/diff/ > > > Testing > --- > > Manually Tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 57130: Clicking save button keeps the dialog window open, When job is submitted, the dialog stays open
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57130/#review167057 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017, 9:25 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57130/ > --- > > (Updated Feb. 28, 2017, 9:25 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20227 > https://issues.apache.org/jira/browse/AMBARI-20227 > > > Repository: ambari > > > Description > --- > > The dialog box will be closed on successful saving and submission of workflow > and the success message is shown on the parent window. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > e94d51a > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > f6e11b6 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 9eb20aa > contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js > 15c1fbf > contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js > 017bc61 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > 2d374a5 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs > 0e35d0e > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 4ff9d87 > > Diff: https://reviews.apache.org/r/57130/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Review Request 57141: Hive View 2.0: Code hints for query editor are not working
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57141/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-19673 https://issues.apache.org/jira/browse/AMBARI-19673 Repository: ambari Description --- User should be able to see code hints and syntax colorization while typing hive queries. Diffs - contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 3175a35 contrib/views/hive20/src/main/resources/ui/ember-cli-build.js c88799a Diff: https://reviews.apache.org/r/57141/diff/ Testing --- Manually tested Thanks, Pallav Kulshreshtha
Re: Review Request 57131: HiveView 2.0 : After download CSV, the pop-up persists
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57131/ --- (Updated Feb. 28, 2017, 11:32 a.m.) Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20228 https://issues.apache.org/jira/browse/AMBARI-20228 Repository: ambari Description --- - Changed the arguments - Handle promise for receiving terminating state. Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 9fc73a4 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 8f0085c contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/results.js 4b59a13 contrib/views/hive20/src/main/resources/ui/app/services/query.js 3bf10c0 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs ad44c5a Diff: https://reviews.apache.org/r/57131/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 57131: HiveView 2.0 : After download CSV, the pop-up persists
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57131/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20228 https://issues.apache.org/jira/browse/AMBARI-20228 Repository: ambari Description --- - Changed the arguments - Handle promise for receiving terminating state. Diffs - contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 9fc73a4 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 8f0085c contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/results.js 4b59a13 contrib/views/hive20/src/main/resources/ui/app/services/query.js 3bf10c0 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs ad44c5a Diff: https://reviews.apache.org/r/57131/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 57100: Select operators should not appear before fetch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57100/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20215 https://issues.apache.org/jira/browse/AMBARI-20215 Repository: ambari Description --- modified logic to show select node. Diffs - contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js a252498 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 196a514 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 01d6000 Diff: https://reviews.apache.org/r/57100/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
