from:"Sreenath Somarajapuram"

Re: Review Request 56379: AMBARI-19418: Support setup queue priority in Ambari - Capacity scheduler view

2017-02-10 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56379/#review165086
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On Feb. 10, 2017, 7:38 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56379/
> ---
> 
> (Updated Feb. 10, 2017, 7:38 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-19418
> https://issues.apache.org/jira/browse/AMBARI-19418
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Feature to support queue priority config settings in YARN
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js
>  589dcd0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js
>  2f9f2fe 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 9198aa5 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 940d0f8 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js dce00c1 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs
>  87f00d9 
> 
> Diff: https://reviews.apache.org/r/56379/diff/
> 
> 
> Testing
> ---
> 
> Manunal Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 55555: Ambari Yarn Queue Manager allows two same queue name

2017-01-17 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review161841
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On Jan. 16, 2017, 6:35 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated Jan. 16, 2017, 6:35 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-19556
> https://issues.apache.org/jira/browse/AMBARI-19556
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch fixes the RM exception thrown for RM restart because of duplicate 
> queue names.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/pathInput.js
>  e71d226 
> 
> Diff: https://reviews.apache.org/r/5/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 52688: Capacity Scheduler View: Calculating absolute capacity for node labels and showing in sunburst chart

2016-10-24 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52688/#review153680
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On Oct. 19, 2016, 11:42 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52688/
> ---
> 
> (Updated Oct. 19, 2016, 11:42 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18561
> https://issues.apache.org/jira/browse/AMBARI-18561
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Calculating absolute capacity for node labels
> Render sunburst chart based on node label capacity when selected
> Read-only mode for non-operator users in preemption and queue mappings
> Bug fixes
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  032b2ec 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  1d07351 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js
>  d5b19ae 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  af15fa5 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  631edbb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  9d84704 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  e7fba41 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  aa139b1 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> e2d67bd 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> d838958 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  1ab1740 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  9973708 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  6d398f6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  8fe627e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  f143911 
> 
> Diff: https://reviews.apache.org/r/52688/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 52688: Capacity Scheduler View: Calculating absolute capacity for node labels and showing in sunburst chart

2016-10-12 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52688/#review152284
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 (line 79)
<https://reviews.apache.org/r/52688/#comment221257>

Need not bind, can pass this as the second argument of forEach.



contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 (line 81)
<https://reviews.apache.org/r/52688/#comment221258>

forEach accepts this as second argument.



contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 (line 120)
<https://reviews.apache.org/r/52688/#comment221259>

Why is this conditional operator required?



contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 (line 252)
<https://reviews.apache.org/r/52688/#comment221260>

Is this conditional operator required?


- Sreenath Somarajapuram


On Oct. 10, 2016, 12:53 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52688/
> ---
> 
> (Updated Oct. 10, 2016, 12:53 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18561
> https://issues.apache.org/jira/browse/AMBARI-18561
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Calculating absolute capacity for node labels
> Render sunburst chart based on node label capacity when selected
> Read-only mode for non-operator users in preemption and queue mappings
> Bug fixes
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  032b2ec 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  1d07351 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js
>  d5b19ae 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  af15fa5 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  631edbb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  9d84704 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  e7fba41 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  aa139b1 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> e2d67bd 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> d838958 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  1ab1740 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  9973708 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  6d398f6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  8fe627e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  f143911 
> 
> Diff: https://reviews.apache.org/r/52688/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

2016-09-29 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51647/#review150829
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On Sept. 28, 2016, 12:44 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51647/
> ---
> 
> (Updated Sept. 28, 2016, 12:44 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18313
> https://issues.apache.org/jira/browse/AMBARI-18313
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> XML diff tool to show changes made.
> View capacity scheduler XML.
> Queue capacity chart - chart showing capacities of queue using sunburst chart.
> Bug fixes.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 8dd7108 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  7776452 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js
>  f8978c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  64a28343 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  107b377 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  2690c40 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/xmldiffViewer.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  c079079 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  447cae0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  7c62ef0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  6a6717a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  40e3e24 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 0f68a10 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> fd996ae 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  bd875ba 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 2c9609f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  14625c1 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  5a54d85 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  922e27e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  873fb6f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  d594c7e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  608758f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  809c1c0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  0c70ee5 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  66ef1ad 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  fb34d51 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  33540e9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  a7ae9b0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/sunburstChart.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/xmldiffViewer.hbs
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/bower.json 911856f 
> 
> Diff: https://reviews.apache.org/r/51647/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

2016-09-28 Thread Sreenath Somarajapuram



> On Sept. 23, 2016, 10:19 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/bower.json, line 16
> > <https://reviews.apache.org/r/51647/diff/1/?file=1491590#file1491590line16>
> >
> > Package versiosn must be fixed.
> 
> Akhil PB wrote:
> Blob has no versions in bower. Bower itself added '*' as version.

Then we please using the commit version.


- Sreenath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51647/#review150166
---


On Sept. 26, 2016, 2:32 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51647/
> ---
> 
> (Updated Sept. 26, 2016, 2:32 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18313
> https://issues.apache.org/jira/browse/AMBARI-18313
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> XML diff tool to show changes made.
> View capacity scheduler XML.
> Queue capacity chart - chart showing capacities of queue using sunburst chart.
> Bug fixes.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 8dd7108 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  7776452 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js
>  f8978c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  64a28343 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  107b377 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  2690c40 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/xmldiffViewer.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  c079079 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  447cae0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  7c62ef0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  6a6717a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  40e3e24 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 0f68a10 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> fd996ae 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  bd875ba 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 2c9609f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  14625c1 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  5a54d85 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  922e27e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  873fb6f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  d594c7e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  608758f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  809c1c0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  0c70ee5 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  66ef1ad 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  fb34d51 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  33540e9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  a7ae9b0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/sunburstChart.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/xmldiffViewer.hbs
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/bower.json 911856f 
> 
> Diff: https://reviews.apache.org/r/51647/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

2016-09-23 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51647/#review150166
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
 (line 32)
<https://reviews.apache.org/r/51647/#comment218037>

Check use of this property else remove.



contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 (line 157)
<https://reviews.apache.org/r/51647/#comment218036>

Please verify the use of this and following property and remove is not 
required.



contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 (line 50)
<https://reviews.apache.org/r/51647/#comment218034>

Looks like this property is not used, please verify and remove if not 
required.



contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 (line 58)
<https://reviews.apache.org/r/51647/#comment218035>

Looks like this function is not used is the above property is not used, 
please verify and remove if not required.



contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 (line 142)
<https://reviews.apache.org/r/51647/#comment218033>

Please check if this and the above computed properties are used. Else 
please remove the same.



contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
(line 246)
<https://reviews.apache.org/r/51647/#comment218032>

Just a comment, would be better to folow one standard for variables. Cammel 
case is what normally used.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 274)
<https://reviews.apache.org/r/51647/#comment218038>

PLease check where this action is called from.



contrib/views/capacity-scheduler/src/main/resources/ui/bower.json (line 16)
<https://reviews.apache.org/r/51647/#comment218031>

    Package versiosn must be fixed.


- Sreenath Somarajapuram


On Sept. 6, 2016, 9:26 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51647/
> ---
> 
> (Updated Sept. 6, 2016, 9:26 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18313
> https://issues.apache.org/jira/browse/AMBARI-18313
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> XML diff tool to show changes made.
> View capacity scheduler XML.
> Queue capacity chart - chart showing capacities of queue using sunburst chart.
> Bug fixes.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/index.html 
> 2cdfe39 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/javascripts/difflib.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/stylesheets/diffview.css
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 8dd7108 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  7776452 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js
>  f8978c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  64a28343 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  107b377 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  2690c40 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/xmldiffViewer.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  c079079 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  447cae0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  7c62ef0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  6a6717a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  40e3e24 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 0f68a10 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> fd996ae 
>   
> contrib/views/capaci

Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

2016-09-23 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51647/#review150165
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/javascripts/difflib.js
 (line 1)
<https://reviews.apache.org/r/51647/#comment218030>

External files shouldnt be added like this. Better to add them as 
dependencies in bower/npm as follows.

"jsdifflib": 
"https://github.com/cemerick/jsdifflib.git#ce74529f9d51943db440dbd7c15d515597cda2e1;


- Sreenath Somarajapuram


On Sept. 6, 2016, 9:26 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51647/
> ---
> 
> (Updated Sept. 6, 2016, 9:26 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18313
> https://issues.apache.org/jira/browse/AMBARI-18313
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> XML diff tool to show changes made.
> View capacity scheduler XML.
> Queue capacity chart - chart showing capacities of queue using sunburst chart.
> Bug fixes.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/index.html 
> 2cdfe39 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/javascripts/difflib.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/stylesheets/diffview.css
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 8dd7108 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  7776452 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js
>  f8978c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  64a28343 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  107b377 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  2690c40 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/xmldiffViewer.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  c079079 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  447cae0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  7c62ef0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  6a6717a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  40e3e24 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 0f68a10 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> fd996ae 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  bd875ba 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 2c9609f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  14625c1 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  5a54d85 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  922e27e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  873fb6f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  d594c7e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  608758f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  809c1c0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  0c70ee5 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  66ef1ad 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  fb34d51 
>   
> contrib/v

Re: Review Request 51452: AMBARI-18261: CapSched View: Showing warning icons to refresh or restart capsched once after configs are saved

2016-09-01 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51452/#review147561
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On Sept. 1, 2016, 1:28 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51452/
> ---
> 
> (Updated Sept. 1, 2016, 1:28 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18261
> https://issues.apache.org/jira/browse/AMBARI-18261
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Showing warning icons to refresh or restart capsched once after configs are 
> saved
> Bug fixes
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
> f300b5b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b86719f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  ed22c2b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  b244097 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  89e7cac 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  8118805 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  c15f100 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  ea5262d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  edd8a3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  dd46b2c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  a68a2aa 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  6638b4c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> acf6465 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> 0b13a8a 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 01a7d6a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  195b55d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  a9ef778 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  1f6fbda 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  9073910 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  73a9e21 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  7b25af3 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  262f380 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  1bc3380 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  7649512 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  a7901b8 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  fa35518 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  9c3ffd0 
> 
> Diff: https://reviews.apache.org/r/51452/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 51452: AMBARI-18261: CapSched View: Showing warning icons to refresh or restart capsched once after configs are saved

2016-08-31 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51452/#review147417
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 270)
<https://reviews.apache.org/r/51452/#comment214579>

- Why are we having this controller variable
- Indentation can be made better.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 300)
<https://reviews.apache.org/r/51452/#comment214581>

Guess it might be better to put all finds into a promise array.


- Sreenath Somarajapuram


On Aug. 26, 2016, 7:09 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51452/
> ---
> 
> (Updated Aug. 26, 2016, 7:09 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18261
> https://issues.apache.org/jira/browse/AMBARI-18261
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Showing warning icons to refresh or restart capsched once after configs are 
> saved
> Bug fixes
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
> f300b5b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b86719f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  ed22c2b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  b244097 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  89e7cac 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  8118805 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  c15f100 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  ea5262d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  edd8a3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  dd46b2c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  a68a2aa 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  6638b4c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> acf6465 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> 0b13a8a 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 01a7d6a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  195b55d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  a9ef778 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  1f6fbda 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  9073910 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  73a9e21 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  7b25af3 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  262f380 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  1bc3380 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  7649512 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  a7901b8 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  fa35518 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  9c3ffd0 
> 
> Diff: https://reviews.apache.org/r/51452/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 49755: AMBARI-17602: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation

2016-08-24 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49755/#review146662
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On Aug. 23, 2016, 7:18 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49755/
> ---
> 
> (Updated Aug. 23, 2016, 7:18 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17602
> https://issues.apache.org/jira/browse/AMBARI-17602
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fetching current rm configuration of queues.
> Updating queue states based on states in configuration.
> Preemption implementation.
> Bug fixes.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
>  e5f5cb5 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
> 770db51 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  bf74af6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  9b31e57 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  7bb3f82 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  bfcd4b6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  545d348 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  f42d2e4 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  683bc6f 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> e91c90f 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> 49363d4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> c3976b4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 36228a1 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  e849ad4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 6e310ad 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  b75237f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  e659f5c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  b4891cd 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  bb82025 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b1a8708 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  2848fed 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/trace.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  9e25cc6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  c430a44 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
>  96cbe99 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  bd49c50 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  ef5663d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> a5d0ef6 
> 
> Diff: https://reviews.apache.org/r/49755/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 51169: AMBARI-18178: yarn capacity scheduler queue issue

2016-08-17 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51169/#review145969
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On Aug. 17, 2016, 8:23 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51169/
> ---
> 
> (Updated Aug. 17, 2016, 8:23 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Pallav Kulshreshtha, and Sreenath 
> Somarajapuram.
> 
> 
> Bugs: AMBARI-18178
> https://issues.apache.org/jira/browse/AMBARI-18178
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> yarn capacity scheduler queue issue. Modified the consumes type to text/plain 
> and using raw json rather than json object.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
>  03520fe 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
> 86c1484 
> 
> Diff: https://reviews.apache.org/r/51169/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 50070: Capacity Scheduler View - Fix for nodelabel api compatibility issue in HDP-2.5

2016-07-15 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50070/#review142361
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On July 15, 2016, 10:30 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50070/
> ---
> 
> (Updated July 15, 2016, 10:30 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17731
> https://issues.apache.org/jira/browse/AMBARI-17731
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix for node label api compatibility issue in the HDP-2.5
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
> 068c241 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 4a9c6b0 
> 
> Diff: https://reviews.apache.org/r/50070/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 49755: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation

2016-07-11 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49755/#review141661
---




contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
 (line 286)
<https://reviews.apache.org/r/49755/#comment207035>

Trailing spaces.



contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
 (line 33)
<https://reviews.apache.org/r/49755/#comment207038>

Commented code.



contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
 (line 36)
<https://reviews.apache.org/r/49755/#comment207036>

Commented code.


- Sreenath Somarajapuram


On July 7, 2016, 1:10 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49755/
> ---
> 
> (Updated July 7, 2016, 1:10 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17602
> https://issues.apache.org/jira/browse/AMBARI-17602
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fetching current rm configuration of queues.
> Updating queue states based on states in configuration.
> Preemption implementation.
> Bug fixes.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
>  03520fe 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
> 068c241 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  bf74af6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  9b31e57 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  7bb3f82 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  bfcd4b6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  545d348 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  f42d2e4 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  683bc6f 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> e91c90f 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> 49363d4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> c3976b4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 4a9c6b0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  e849ad4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 6e310ad 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  b75237f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  e659f5c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  b4891cd 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  bb82025 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b1a8708 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  2848fed 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/trace.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  9e25cc6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  c430a44 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
>  96cbe99 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  bd49c50 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  ef5663d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> a5d0ef6 
> 
> Diff: https://reviews.apache.org/r/49755/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-07-04 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review140616
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On June 27, 2016, 5:36 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 27, 2016, 5:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-29 Thread Sreenath Somarajapuram



> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > <https://reviews.apache.org/r/48487/diff/1/?file=1412307#file1412307line26>
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?
> 
> Akhil PB wrote:
> versionPanel.hbs itself is a new file and class "versions-table-wrap" is 
> used for styling and styles are defined in application.less.
> views/queues.js would not break since queues.js uses above as id and 
> versionPanel uses as class name.
> 
> Sreenath Somarajapuram wrote:
> "versions-table-wrap is used for styling and styles are defined in 
> application.less" > Can you share the line number in application.less?
> 
> Akhil PB wrote:
> queues.hbs has id="versions-table-wrap" and css also (line:217 in 
> application.less).
> versionPanel.hbs has class="versions-table-wrap" and css are defined at 
> line:1259.
> So the new changes would not break old code.

Well, as-per your patch there are only 1252 line in application.less!


- Sreenath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 27, 2016, 5:36 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> -------
> 
> (Updated June 27, 2016, 5:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contri

Re: Review Request 48686: Tez View: Improve proxy logging

2016-06-23 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48686/
---

(Updated June 24, 2016, 4:45 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Hitesh Shah, and Pallav 
Kulshreshtha.


Changes
---

Correcting white-spaces in the exception message.


Bugs: AMBARI-17186
https://issues.apache.org/jira/browse/AMBARI-17186


Repository: ambari


Description
---

More log messages would help us to debug EARs faster.


Diffs (updated)
-

  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
 981353b 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ATSUrlFetchException.java
 9eb7c47 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ActiveRMFetchException.java
 cb6f2eb 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ProxyException.java
 aa006b2 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/TezWebAppException.java
 PRE-CREATION 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseProxyResource.java
 619f81e 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseRedirectionResource.java
 97ee01d 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/utils/ProxyHelper.java
 f642193 

Diff: https://reviews.apache.org/r/48686/diff/


Testing
---

Manual testing.
Verified the presence of debug and error logs in 
/var/log/ambari-server/tez-view/tez-view.log


Thanks,

Sreenath Somarajapuram

Re: Review Request 48686: Tez View: Improve proxy logging

2016-06-23 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48686/
---

(Updated June 23, 2016, 9:36 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Hitesh Shah, and Pallav 
Kulshreshtha.


Changes
---

Corrected a typo.


Bugs: AMBARI-17186
https://issues.apache.org/jira/browse/AMBARI-17186


Repository: ambari


Description
---

More log messages would help us to debug EARs faster.


Diffs (updated)
-

  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
 981353b 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ATSUrlFetchException.java
 9eb7c47 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ActiveRMFetchException.java
 cb6f2eb 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ProxyException.java
 aa006b2 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/TezWebAppException.java
 PRE-CREATION 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseProxyResource.java
 619f81e 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseRedirectionResource.java
 97ee01d 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/utils/ProxyHelper.java
 f642193 

Diff: https://reviews.apache.org/r/48686/diff/


Testing
---

Manual testing.
Verified the presence of debug and error logs in 
/var/log/ambari-server/tez-view/tez-view.log


Thanks,

Sreenath Somarajapuram

Re: Review Request 48686: Tez View: Improve proxy logging

2016-06-23 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48686/
---

(Updated June 23, 2016, 9:14 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Hitesh Shah, and Pallav 
Kulshreshtha.


Bugs: AMBARI-17186
https://issues.apache.org/jira/browse/AMBARI-17186


Repository: ambari


Description
---

More log messages would help us to debug EARs faster.


Diffs (updated)
-

  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
 981353b 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ATSUrlFetchException.java
 9eb7c47 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ActiveRMFetchException.java
 cb6f2eb 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ProxyException.java
 aa006b2 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/TezWebAppException.java
 PRE-CREATION 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseProxyResource.java
 619f81e 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseRedirectionResource.java
 97ee01d 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/utils/ProxyHelper.java
 f642193 

Diff: https://reviews.apache.org/r/48686/diff/


Testing
---

Manual testing.
Verified the presence of debug and error logs in 
/var/log/ambari-server/tez-view/tez-view.log


Thanks,

Sreenath Somarajapuram

Re: Review Request 48686: Tez View: Improve proxy logging

2016-06-23 Thread Sreenath Somarajapuram



> On June 23, 2016, 8:24 p.m., Hitesh Shah wrote:
> > contrib/views/tez/src/main/java/org/apache/ambari/view/tez/utils/ProxyHelper.java,
> >  line 64
> > <https://reviews.apache.org/r/48686/diff/4/?file=1428765#file1428765line64>
> >
> > Is there a debug message which logs which url was being tried to be 
> > fetched?

Yes, Line 63 in BaseProxyResource.


> On June 23, 2016, 8:24 p.m., Hitesh Shah wrote:
> > contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/TezWebAppException.java,
> >  line 96
> > <https://reviews.apache.org/r/48686/diff/4/?file=1428762#file1428762line96>
> >
> > Why is trace an object as compared to a String?

ExceptionUtils.getStackTrace was a resent change, before that we were just 
uding ex.getStackTrace.
Changing to string.


- Sreenath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48686/#review139293
-------


On June 23, 2016, 8:04 p.m., Sreenath Somarajapuram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48686/
> ---
> 
> (Updated June 23, 2016, 8:04 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Hitesh Shah, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-17186
> https://issues.apache.org/jira/browse/AMBARI-17186
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> More log messages would help us to debug EARs faster.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
>  981353b 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ATSUrlFetchException.java
>  9eb7c47 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ActiveRMFetchException.java
>  cb6f2eb 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ProxyException.java
>  aa006b2 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/TezWebAppException.java
>  PRE-CREATION 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseProxyResource.java
>  619f81e 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseRedirectionResource.java
>  97ee01d 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/utils/ProxyHelper.java
>  f642193 
> 
> Diff: https://reviews.apache.org/r/48686/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> Verified the presence of debug and error logs in 
> /var/log/ambari-server/tez-view/tez-view.log
> 
> 
> Thanks,
> 
> Sreenath Somarajapuram
> 
>

Re: Review Request 48686: Tez View: Improve proxy logging

2016-06-23 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48686/
---

(Updated June 23, 2016, 8:04 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.


Changes
---

Now we use a single class "TezWebAppException", with overloaded constructors 
for various kinds of exceptions.


Bugs: AMBARI-17186
https://issues.apache.org/jira/browse/AMBARI-17186


Repository: ambari


Description
---

More log messages would help us to debug EARs faster.


Diffs (updated)
-

  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
 981353b 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ATSUrlFetchException.java
 9eb7c47 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ActiveRMFetchException.java
 cb6f2eb 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ProxyException.java
 aa006b2 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/TezWebAppException.java
 PRE-CREATION 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseProxyResource.java
 619f81e 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseRedirectionResource.java
 97ee01d 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/utils/ProxyHelper.java
 f642193 

Diff: https://reviews.apache.org/r/48686/diff/


Testing
---

Manual testing.
Verified the presence of debug and error logs in 
/var/log/ambari-server/tez-view/tez-view.log


Thanks,

Sreenath Somarajapuram

Re: Review Request 49141: Capacity Scheduler View: Javascript error causing new queue creation failed in Yarn Capacity Scheduler

2016-06-23 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49141/#review139227
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On June 23, 2016, 9:19 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49141/
> ---
> 
> (Updated June 23, 2016, 9:19 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17395
> https://issues.apache.org/jira/browse/AMBARI-17395
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Throws javascript errors while creating new queue.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/totalCapacity.js
>  cb0c6b0 
> 
> Diff: https://reviews.apache.org/r/49141/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139051
---



- Sreenath Somarajapuram


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram



> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > <https://reviews.apache.org/r/48487/diff/1/?file=1412307#file1412307line26>
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?
> 
> Akhil PB wrote:
> versionPanel.hbs itself is a new file and class "versions-table-wrap" is 
> used for styling and styles are defined in application.less.
> views/queues.js would not break since queues.js uses above as id and 
> versionPanel uses as class name.

"versions-table-wrap is used for styling and styles are defined in 
application.less" > Can you share the line number in application.less?


- Sreenath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139046
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 (line 43)
<https://reviews.apache.org/r/48487/#comment204215>

Where is isNotOperator used?



contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js (line 290)
<https://reviews.apache.org/r/48487/#comment204213>

Where is the values of store passed?


- Sreenath Somarajapuram


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contr

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
 (line 25)
<https://reviews.apache.org/r/48487/#comment204211>

Trailing space must be removed.



contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js (line 290)
<https://reviews.apache.org/r/48487/#comment204206>

Technically, store must be a generic implementation without any 
entity/model specific code.
But as this is existing code, guess there is no other alternative.



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 (line 26)
<https://reviews.apache.org/r/48487/#comment204212>

Where is the versions-table-wrap class defined?
Wouldnt it cause the views/queues.js code to break?


- Sreenath Somarajapuram


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram



> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, 
> > line 164
> > <https://reviews.apache.org/r/48487/diff/1/?file=1412286#file1412286line164>
> >
> > Why are we having the + after ?
> 
> Akhil PB wrote:
> Converting string number to integer number.
> 
> Akhil PB wrote:
> + is for properties[cp]. ie +properties[cp]

Would have been better to use parseFloat. But as it is from an old code, lets 
leave it for the time being.


- Sreenath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139032
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139032
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js (line 
164)
<https://reviews.apache.org/r/48487/#comment204205>

Why are we having the + after ?


- Sreenath Somarajapuram


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/

Re: Review Request 48686: Tez View: Improve proxy logging

2016-06-20 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48686/
---

(Updated June 20, 2016, 11:21 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.


Changes
---

The build was failing as we had used something from java 1.8, fixed the same.


Bugs: AMBARI-17186
https://issues.apache.org/jira/browse/AMBARI-17186


Repository: ambari


Description
---

More log messages would help us to debug EARs faster.


Diffs (updated)
-

  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
 981353b 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ATSUrlFetchException.java
 9eb7c47 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ActiveRMFetchException.java
 cb6f2eb 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ConfigurationFetchException.java
 PRE-CREATION 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseProxyResource.java
 619f81e 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseRedirectionResource.java
 97ee01d 

Diff: https://reviews.apache.org/r/48686/diff/


Testing
---

Manual testing.
Verified the presence of debug and error logs in 
/var/log/ambari-server/tez-view/tez-view.log


Thanks,

Sreenath Somarajapuram

Review Request 48686: Tez View: Improve proxy logging

2016-06-14 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48686/
---

Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.


Bugs: AMBARI-17186
https://issues.apache.org/jira/browse/AMBARI-17186


Repository: ambari


Description
---

More log messages would help us to debug EARs faster.


Diffs
-

  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
 981353b 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/YARNProtocolFetchException.java
 PRE-CREATION 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseProxyResource.java
 619f81e 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseRedirectionResource.java
 97ee01d 

Diff: https://reviews.apache.org/r/48686/diff/


Testing
---

Manual testing.
Verified the presence of debug and error logs in 
/var/log/ambari-server/tez-view/tez-view.log


Thanks,

Sreenath Somarajapuram

Review Request 48582: Tez View: Load public host names

2016-06-11 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48582/
---

Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.


Bugs: AMBARI-17178
https://issues.apache.org/jira/browse/AMBARI-17178


Repository: ambari


Description
---

Load public_host_name, parse and set the cnames configuration.


Diffs
-

  contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 8bbcf01 

Diff: https://reviews.apache.org/r/48582/diff/


Testing
---

Manually tested


Thanks,

Sreenath Somarajapuram

Re: Review Request 48398: Capacity scheduler view - problem with queue percent rounding

2016-06-10 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48398/#review136986
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On June 10, 2016, 9:58 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48398/
> ---
> 
> (Updated June 10, 2016, 9:58 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17109
> https://issues.apache.org/jira/browse/AMBARI-17109
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity scheduler view - problem with queue percent rounding
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/totalCapacity.js
>  c36839c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js
>  4aeb442 
> 
> Diff: https://reviews.apache.org/r/48398/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 47643: Capacity Scheduler View - Edit and validate queue name

2016-05-23 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47643/#review134326
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On May 23, 2016, 5:25 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47643/
> ---
> 
> (Updated May 23, 2016, 5:25 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-16792
> https://issues.apache.org/jira/browse/AMBARI-16792
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Edit and validate queue name
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  02062a6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  69be18c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  89d0e89 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  a60d39d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  d57b2ba 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  c5c910a 
> 
> Diff: https://reviews.apache.org/r/47643/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 47643: Capacity Scheduler View - Edit and validate queue name

2016-05-20 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47643/#review134190
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 (line 50)
<https://reviews.apache.org/r/47643/#comment198832>

This need to be corrected.


- Sreenath Somarajapuram


On May 20, 2016, 9:57 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47643/
> ---
> 
> (Updated May 20, 2016, 9:57 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-16792
> https://issues.apache.org/jira/browse/AMBARI-16792
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Edit and validate queue name
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  02062a6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  69be18c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  89d0e89 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  a60d39d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  d57b2ba 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  c5c910a 
> 
> Diff: https://reviews.apache.org/r/47643/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Review Request 47097: Tez View : Update namespace to use version info

2016-05-08 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47097/
---

Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.


Bugs: AMBARI-16300
https://issues.apache.org/jira/browse/AMBARI-16300


Repository: ambari


Description
---

- am webService namespaces just uses v2 of Tez webservice
- Update the namespaces path to use other versions


Diffs
-

  contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 4b7d94d 

Diff: https://reviews.apache.org/r/47097/diff/


Testing
---


Thanks,

Sreenath Somarajapuram

Re: Review Request 46770: Capacity Scheduler View: New UI - queues save integration

2016-05-05 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46770/#review131811
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 (line 34)
<https://reviews.apache.org/r/46770/#comment195838>

Are we using _this, else can we remove.



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
 (line 21)
<https://reviews.apache.org/r/46770/#comment195837>

Can we get this removed?


- Sreenath Somarajapuram


On April 28, 2016, 11:43 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46770/
> ---
> 
> (Updated April 28, 2016, 11:43 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15877
> https://issues.apache.org/jira/browse/AMBARI-15877
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> CapSched View: Queues save integration in new UI
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  0f4d038 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  753fa9b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  8e278f0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  f25180f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  24f6938 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  b5c3c04 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  2628553 
> 
> Diff: https://reviews.apache.org/r/46770/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-27 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review130753
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On April 27, 2016, 9:45 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated April 27, 2016, 9:45 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44704/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-27 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review130740
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 (line 138)
<https://reviews.apache.org/r/44704/#comment194613>

Where is operation defined?


- Sreenath Somarajapuram


On April 26, 2016, 10:43 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated April 26, 2016, 10:43 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44704/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Review Request 46652: Tez View : Equip the tez view shim to work with both version 1 & 2 of Tez UI

2016-04-25 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46652/
---

Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.


Bugs: AMBARI-16103
https://issues.apache.org/jira/browse/AMBARI-16103


Repository: ambari


Description
---

Tez UI 1 would be soon replaced with Tez UI 2, and we need to ensure that the 
Ambari view can work with both versions of the UI.


Diffs
-

  contrib/views/tez/pom.xml 9e626b8 
  contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 
PRE-CREATION 
  contrib/views/tez/src/main/resources/ui/index.html ed0230a 
  contrib/views/tez/src/main/resources/ui/scripts/init-ambari-view.js 25d4da0 

Diff: https://reviews.apache.org/r/46652/diff/


Testing
---

Tested manually against Tez UI 1 & 2.


Thanks,

Sreenath Somarajapuram

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-04 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126813
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 (line 76)
<https://reviews.apache.org/r/44704/#comment189899>

Commented code.


- Sreenath Somarajapuram


On March 11, 2016, 10:41 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated March 11, 2016, 10:41 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingInterpreter.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44704/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-04 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126808
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 (line 27)
<https://reviews.apache.org/r/44704/#comment189892>

Intentation



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 (line 60)
<https://reviews.apache.org/r/44704/#comment189895>

Can use bunded conditional class names.



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 (line 33)
<https://reviews.apache.org/r/44704/#comment189890>

please correct the intentation.



contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
(line 28)
<https://reviews.apache.org/r/44704/#comment189893>

Better to off these listeners on willDestroy.


- Sreenath Somarajapuram


On March 11, 2016, 10:41 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated March 11, 2016, 10:41 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingInterpreter.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/template

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-04 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126795
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
 (line 19)
<https://reviews.apache.org/r/44704/#comment189884>

Looks like you can delete this file.
Even if the file name is queueMappingParser.js, this is same as 
queueMappingInterpreter.js.
Also correct th require.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 142)
<https://reviews.apache.org/r/44704/#comment189877>

We souldnt have commented code.
The line can be removed if not required.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 229)
<https://reviews.apache.org/r/44704/#comment189878>

All debug logs must be removed.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 241)
<https://reviews.apache.org/r/44704/#comment189879>

All debug logs must be removed.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 275)
<https://reviews.apache.org/r/44704/#comment189880>

Again remove comments.



contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 (line 887)
<https://reviews.apache.org/r/44704/#comment189885>

Intentation



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 (line 28)
<https://reviews.apache.org/r/44704/#comment189888>

Whay are we having an anchor tags inside link-to? And what is the purpose 
fo href="view.href".


- Sreenath Somarajapuram


On March 11, 2016, 10:41 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated March 11, 2016, 10:41 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingInterpreter.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/

42 matches

Mail list logo