Re: Review Request 47773: one very careless mistake for ambari agent cancel logic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47773/#review134694 --- Ship it! Ship It! - Sumit Mohanty On May 25, 2016, 2:18 a.m., chen jian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47773/ > --- > > (Updated May 25, 2016, 2:18 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Tom > Beerbower. > > > Bugs: AMBARI-16733 > https://issues.apache.org/jira/browse/AMBARI-16733 > > > Repository: ambari > > > Description > --- > > one very careless mistake for ambari agent cancel logic > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py 19bd18f > > Diff: https://reviews.apache.org/r/47773/diff/ > > > Testing > --- > > test cancel task in the installation on a live cluster. > but I tested in my own Ambari branch, the branch is used for quickly build > our own cloud system. > > > Thanks, > > chen jian > >
Re: Review Request 47773: one very careless mistake for ambari agent cancel logic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47773/ --- (Updated 五月 25, 2016, 2:18 a.m.) Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Tom Beerbower. Bugs: AMBARI-16733 https://issues.apache.org/jira/browse/AMBARI-16733 Repository: ambari Description --- one very careless mistake for ambari agent cancel logic Diffs - ambari-agent/src/main/python/ambari_agent/ActionQueue.py 19bd18f Diff: https://reviews.apache.org/r/47773/diff/ Testing (updated) --- test cancel task in the installation on a live cluster. but I tested in my own Ambari branch, the branch is used for quickly build our own cloud system. Thanks, chen jian
Re: Review Request 47773: one very careless mistake for ambari agent cancel logic
> On 五月 24, 2016, 1:23 p.m., Tom Beerbower wrote: > > The fix looks okay to me. How did you test it? Could you please complete > > the "testing done" section of the review? that's done, thanks. That is my first time commit for Ambari, Could you tell me what to do to close my jira issue. - chen --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47773/#review134576 --- On 五月 25, 2016, 12:10 a.m., chen jian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47773/ > --- > > (Updated 五月 25, 2016, 12:10 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Tom > Beerbower. > > > Bugs: AMBARI-16733 > https://issues.apache.org/jira/browse/AMBARI-16733 > > > Repository: ambari > > > Description > --- > > one very careless mistake for ambari agent cancel logic > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py 19bd18f > > Diff: https://reviews.apache.org/r/47773/diff/ > > > Testing > --- > > done. > > > Thanks, > > chen jian > >
Re: Review Request 47773: one very careless mistake for ambari agent cancel logic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47773/ --- (Updated 五月 25, 2016, 12:10 a.m.) Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Tom Beerbower. Bugs: AMBARI-16733 https://issues.apache.org/jira/browse/AMBARI-16733 Repository: ambari Description --- one very careless mistake for ambari agent cancel logic Diffs - ambari-agent/src/main/python/ambari_agent/ActionQueue.py 19bd18f Diff: https://reviews.apache.org/r/47773/diff/ Testing (updated) --- done. Thanks, chen jian
Re: Review Request 47773: one very careless mistake for ambari agent cancel logic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47773/#review134576 --- Ship it! The fix looks okay to me. How did you test it? Could you please complete the "testing done" section of the review? - Tom Beerbower On May 24, 2016, 1:13 p.m., chen jian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47773/ > --- > > (Updated May 24, 2016, 1:13 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Tom > Beerbower. > > > Repository: ambari > > > Description > --- > > one very careless mistake for ambari agent cancel logic > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py 19bd18f > > Diff: https://reviews.apache.org/r/47773/diff/ > > > Testing > --- > > > Thanks, > > chen jian > >
