Re: Review Request 55842: Regenerate Keytabs action does not set cluster-env/security_enabled to true

2017-01-24 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55842/#review162809
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 24, 2017, 4:20 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55842/
> ---
> 
> (Updated Jan. 24, 2017, 4:20 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19675
> https://issues.apache.org/jira/browse/AMBARI-19675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regenerate keytabs apply all configs but not security_enabled.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
>  931806d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
>  1a38d87 
> 
> Diff: https://reviews.apache.org/r/55842/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 55842: Regenerate Keytabs action does not set cluster-env/security_enabled to true

2017-01-24 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55842/
---

(Updated Jan. 24, 2017, 2:20 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
Brodetskyi.


Changes
---

added tests


Bugs: AMBARI-19675
https://issues.apache.org/jira/browse/AMBARI-19675


Repository: ambari


Description
---

Regenerate keytabs apply all configs but not security_enabled.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
 931806d 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
 1a38d87 

Diff: https://reviews.apache.org/r/55842/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 55842: Regenerate Keytabs action does not set cluster-env/security_enabled to true

2017-01-23 Thread Robert Levas 


> On Jan. 23, 2017, 9:39 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java,
> >  line 127
> > 
> >
> > I think there may be lots of similar places at our code. Maybe just add 
> > this config on cluster deployment?

@Dmitro... There are other places where something like this happens, but they 
occur in different work flows.  This cannot be done on cluster deploy since 
this needs to happen whenever the security type of the cluster changes.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55842/#review162629
---


On Jan. 23, 2017, 8:24 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55842/
> ---
> 
> (Updated Jan. 23, 2017, 8:24 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19675
> https://issues.apache.org/jira/browse/AMBARI-19675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regenerate keytabs apply all configs but not security_enabled.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
>  931806d 
> 
> Diff: https://reviews.apache.org/r/55842/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 55842: Regenerate Keytabs action does not set cluster-env/security_enabled to true

2017-01-23 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55842/#review162633
---


Fix it, then Ship it!




Ship It!


ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
 (lines 130 - 132)


I think we tend to try to say away from this notation.  

How about something like
```
map = propertiesToSet.get("cluster-env")
if(map == null) {
  map = new HashMap<>();
  propertiesToSet.put("cluster-env", map);
}

map.put("security_enabled", security_enabled);
```


- Robert Levas


On Jan. 23, 2017, 8:24 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55842/
> ---
> 
> (Updated Jan. 23, 2017, 8:24 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19675
> https://issues.apache.org/jira/browse/AMBARI-19675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regenerate keytabs apply all configs but not security_enabled.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
>  931806d 
> 
> Diff: https://reviews.apache.org/r/55842/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 55842: Regenerate Keytabs action does not set cluster-env/security_enabled to true

2017-01-23 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55842/#review162629
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
 (line 127)


I think there may be lots of similar places at our code. Maybe just add 
this config on cluster deployment?


- Dmitro Lisnichenko


On Jan. 23, 2017, 3:24 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55842/
> ---
> 
> (Updated Jan. 23, 2017, 3:24 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19675
> https://issues.apache.org/jira/browse/AMBARI-19675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regenerate keytabs apply all configs but not security_enabled.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
>  931806d 
> 
> Diff: https://reviews.apache.org/r/55842/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>