Re: Review Request 48332: Log search capability for Nifi

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48332/
---

(Updated June 8, 2016, 5:53 p.m.)


Review request for Ambari, Jayush Luniya, Oliver Szabo, Robert Nettleton, and 
Sumit Mohanty.


Bugs: AMBARI-17086
https://issues.apache.org/jira/browse/AMBARI-17086


Repository: ambari


Description
---

Giving users the ability to deploy a service to their cluster to collect, 
index, and explore those log files is needed to improve the ease of 
administration for the operators.
Add Log search capability for NiFi


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 34583ba 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 54e08e4 

Diff: https://reviews.apache.org/r/48332/diff/


Testing
---

Log Seaerch was installed and logs were loaded fine on local cluster with NiFi


Thanks,

Miklos Gergely

Re: Review Request 48332: Log search capability for Nifi

[Miklos Gergely]

> On June 7, 2016, 1:20 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py,
> >  line 233
> > 
> >
> > Is NiFi being added to Ambari in 2.4?  
> > 
> > If so, is there a patch for those changes being reviewed as well?
> 
> Robert Nettleton wrote:
> I'm dropping this issue, since Jayush explained that NiFi will be defined 
> in a separate management pack eventually. 
> 
> Thanks for the clarification.

It was suggested by Sumit and Jayush:
https://hortonworks.jira.com/browse/BUG-58446


- Miklos


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48332/#review136456
---


On June 7, 2016, 10:05 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48332/
> ---
> 
> (Updated June 7, 2016, 10:05 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Oliver Szabo, Robert Nettleton, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17086
> https://issues.apache.org/jira/browse/AMBARI-17086
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Giving users the ability to deploy a service to their cluster to collect, 
> index, and explore those log files is needed to improve the ease of 
> administration for the operators.
> Add Log search capability for NiFi
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  34583ba 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48332/diff/
> 
> 
> Testing
> ---
> 
> Log Seaerch was installed and logs were loaded fine on local cluster with NiFi
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 48332: Log search capability for Nifi

[Robert Nettleton]

> On June 7, 2016, 1:20 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py,
> >  line 233
> > 
> >
> > Is NiFi being added to Ambari in 2.4?  
> > 
> > If so, is there a patch for those changes being reviewed as well?

I'm dropping this issue, since Jayush explained that NiFi will be defined in a 
separate management pack eventually. 

Thanks for the clarification.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48332/#review136456
---


On June 7, 2016, 10:05 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48332/
> ---
> 
> (Updated June 7, 2016, 10:05 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Oliver Szabo, Robert Nettleton, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17086
> https://issues.apache.org/jira/browse/AMBARI-17086
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Giving users the ability to deploy a service to their cluster to collect, 
> index, and explore those log files is needed to improve the ease of 
> administration for the operators.
> Add Log search capability for NiFi
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  34583ba 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48332/diff/
> 
> 
> Testing
> ---
> 
> Log Seaerch was installed and logs were loaded fine on local cluster with NiFi
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 48332: Log search capability for Nifi

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48332/#review136499
---


Ship it!




Ship It!

- Jayush Luniya


On June 7, 2016, 10:05 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48332/
> ---
> 
> (Updated June 7, 2016, 10:05 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Oliver Szabo, Robert Nettleton, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17086
> https://issues.apache.org/jira/browse/AMBARI-17086
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Giving users the ability to deploy a service to their cluster to collect, 
> index, and explore those log files is needed to improve the ease of 
> administration for the operators.
> Add Log search capability for NiFi
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  34583ba 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48332/diff/
> 
> 
> Testing
> ---
> 
> Log Seaerch was installed and logs were loaded fine on local cluster with NiFi
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 48332: Log search capability for Nifi

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48332/#review136456
---


Fix it, then Ship it!




The patch looks fine to me, but I do have a question below about NiFi support 
in general.

Since Apache NiFi support has not yet been added to Ambari, it seems confusing 
to add the LogSearch support for it first. 

Thanks.


ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 (line 233)


Is NiFi being added to Ambari in 2.4?  

If so, is there a patch for those changes being reviewed as well?


- Robert Nettleton


On June 7, 2016, 10:05 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48332/
> ---
> 
> (Updated June 7, 2016, 10:05 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Oliver Szabo, Robert Nettleton, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17086
> https://issues.apache.org/jira/browse/AMBARI-17086
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Giving users the ability to deploy a service to their cluster to collect, 
> index, and explore those log files is needed to improve the ease of 
> administration for the operators.
> Add Log search capability for NiFi
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  34583ba 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48332/diff/
> 
> 
> Testing
> ---
> 
> Log Seaerch was installed and logs were loaded fine on local cluster with NiFi
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 48332: Log search capability for Nifi

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48332/#review136451
---


Ship it!




Ship It!

- Oliver Szabo


On June 7, 2016, 10:05 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48332/
> ---
> 
> (Updated June 7, 2016, 10:05 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Oliver Szabo, Robert Nettleton, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17086
> https://issues.apache.org/jira/browse/AMBARI-17086
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Giving users the ability to deploy a service to their cluster to collect, 
> index, and explore those log files is needed to improve the ease of 
> administration for the operators.
> Add Log search capability for NiFi
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  34583ba 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48332/diff/
> 
> 
> Testing
> ---
> 
> Log Seaerch was installed and logs were loaded fine on local cluster with NiFi
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 48332: Log search capability for Nifi

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48332/
---

Review request for Ambari, Jayush Luniya, Oliver Szabo, Robert Nettleton, and 
Sumit Mohanty.


Bugs: AMBARI-17086
https://issues.apache.org/jira/browse/AMBARI-17086


Repository: ambari


Description
---

Giving users the ability to deploy a service to their cluster to collect, 
index, and explore those log files is needed to improve the ease of 
administration for the operators.
Add Log search capability for NiFi


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 34583ba 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
 PRE-CREATION 

Diff: https://reviews.apache.org/r/48332/diff/


Testing
---

Log Seaerch was installed and logs were loaded fine on local cluster with NiFi


Thanks,

Miklos Gergely