Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-03 Thread Jungtaek Lim 


> On 7 4, 2016, 2:09 오전, Jungtaek Lim wrote:
> > Ship It!

Looks good to me overall. I assumed 'ambari-metrics-storm-legacy' is just a 
copy of previous 'ambari-metrics-storm'.


- Jungtaek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140599
---


On 7 3, 2016, 1:23 오후, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated 7 3, 2016, 1:23 오후)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 941c3aa 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-common/pom.xml 3e11e7f 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml ee4d2c3 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  8f98563 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  0ef09d6 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  4ea7396 
>   ambari-metrics/pom.xml 726a823 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  fac6331 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  ea8b1d0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 2fcb7e2 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 
> f7a2686 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-03 Thread Jungtaek Lim 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140599
---


Ship it!




Ship It!

- Jungtaek Lim


On 7 3, 2016, 1:23 오후, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated 7 3, 2016, 1:23 오후)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 941c3aa 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-common/pom.xml 3e11e7f 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml ee4d2c3 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  8f98563 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  0ef09d6 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  4ea7396 
>   ambari-metrics/pom.xml 726a823 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  fac6331 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  ea8b1d0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 2fcb7e2 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 
> f7a2686 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-03 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/
---

(Updated Июль 3, 2016, 1:23 п.п.)


Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.


Bugs: AMBARI-17080
https://issues.apache.org/jira/browse/AMBARI-17080


Repository: ambari


Description
---

Support 2 storm sinks.


Diffs (updated)
-

  ambari-metrics/ambari-metrics-assembly/pom.xml 941c3aa 
  ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
e82d2d4 
  ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
  ambari-metrics/ambari-metrics-common/pom.xml 3e11e7f 
  ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
PRE-CREATION 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 PRE-CREATION 
  ambari-metrics/ambari-metrics-storm-sink/pom.xml ee4d2c3 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
 4553224 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 8f98563 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 0ef09d6 
  
ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 4ea7396 
  ambari-metrics/pom.xml 726a823 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
 0d029e8 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 fac6331 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
 2d50767 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
 6551067 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
 ea8b1d0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
 f3bbce8 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 2fcb7e2 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 
f7a2686 

Diff: https://reviews.apache.org/r/49514/diff/


Testing
---

Unit testst passed


Thanks,

Dmytro Sen

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-03 Thread Dmytro Sen 


> On Июль 1, 2016, 11:10 п.п., Aravindan Vijayan wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml,
> >  line 58
> > 
> >
> > Just trying to understand this. 
> > 
> > Does this mean that on a new HDP 2.5 cluster or on a cluster that has 
> > been upgraded to HDP 2.5, upgrading Ambari 2.4.0 to a higher version will 
> > delete this config?

Yes


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140459
---


On Июль 1, 2016, 3:32 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated Июль 1, 2016, 3:32 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 5e2d819 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 1591d39 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  ab5f1e4 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  6ab12e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  e582a95 
>   ambari-metrics/pom.xml 7221ab5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  073bb1c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  9acf173 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-01 Thread Sriharsha Chintalapani 


> On July 1, 2016, 5:09 p.m., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml,
> >  line 40
> > 
> >
> > Does the parallelism = 1, mean 1 bolt getting all metric reports in a 
> > topology. Is it counter-intuitive for performance, something we should 
> > check with storm group.
> 
> Jungtaek Lim wrote:
> Its default value has been 1, so setting it explicitly means letting 
> users to modify it easily.

this is tricky config. We should expose this in ambari config page otherwise 
most users wouldn't notice that a metrics bolt running and can cause perf 
degradation if they go with 1 parallelism to prod.


- Sriharsha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140384
---


On July 1, 2016, 3:32 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated July 1, 2016, 3:32 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 5e2d819 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 1591d39 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  ab5f1e4 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  6ab12e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  e582a95 
>   ambari-metrics/pom.xml 7221ab5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  073bb1c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  9acf173 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-01 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140459
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
 (line 58)


Just trying to understand this. 

Does this mean that on a new HDP 2.5 cluster or on a cluster that has been 
upgraded to HDP 2.5, upgrading Ambari 2.4.0 to a higher version will delete 
this config?


- Aravindan Vijayan


On July 1, 2016, 3:32 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated July 1, 2016, 3:32 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 5e2d819 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 1591d39 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  ab5f1e4 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  6ab12e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  e582a95 
>   ambari-metrics/pom.xml 7221ab5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  073bb1c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  9acf173 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-01 Thread Jungtaek Lim 


> On July 1, 2016, 5:09 p.m., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml,
> >  line 40
> > 
> >
> > Does the parallelism = 1, mean 1 bolt getting all metric reports in a 
> > topology. Is it counter-intuitive for performance, something we should 
> > check with storm group.

Its default value has been 1, so setting it explicitly means letting users to 
modify it easily.


- Jungtaek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140384
---


On July 1, 2016, 3:32 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated July 1, 2016, 3:32 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 5e2d819 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 1591d39 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  ab5f1e4 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  6ab12e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  e582a95 
>   ambari-metrics/pom.xml 7221ab5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  073bb1c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  9acf173 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-01 Thread Jungtaek Lim 


> On July 1, 2016, 3:54 p.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java,
> >  line 194
> > 
> >
> > Good catch, however, why not look for "._" and replace that only if 
> > needed.
> 
> Dmytro Sen wrote:
> There is no change here. It's a copy of previous 
> StormTimelineMetricsSink.java

It's originally for escaping '._' but only escaping that case is not intuitive 
for users. Escaping all _ will make users to predict escaped metric name easily.


> On July 1, 2016, 3:54 p.m., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml,
> >  line 30
> > 
> >
> > So both old and new properties are ok to be present at the same time?
> 
> Dmytro Sen wrote:
> yes

yes since storm runs properly with unknown configs are presented.


- Jungtaek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140370
---


On July 1, 2016, 3:32 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated July 1, 2016, 3:32 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 5e2d819 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 1591d39 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  ab5f1e4 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  6ab12e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  e582a95 
>   ambari-metrics/pom.xml 7221ab5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  073bb1c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  9acf173 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-01 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140384
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
 (line 40)


Does the parallelism = 1, mean 1 bolt getting all metric reports in a 
topology. Is it counter-intuitive for performance, something we should check 
with storm group.


- Sid Wagle


On July 1, 2016, 3:32 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated July 1, 2016, 3:32 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 5e2d819 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 1591d39 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  ab5f1e4 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  6ab12e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  e582a95 
>   ambari-metrics/pom.xml 7221ab5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  073bb1c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  9acf173 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-01 Thread Dmytro Sen 


> On Июль 1, 2016, 3:54 п.п., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-storm-sink/pom.xml, line 35
> > 
> >
> > Since this isn't apache version, checking this in will break apache 
> > builds ?

Yes it will. we need storm-core 1.0.1.2.5.0.0-830 in public maven repo before 
commiting


> On Июль 1, 2016, 3:54 п.п., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml,
> >  line 30
> > 
> >
> > So both old and new properties are ok to be present at the same time?

yes


> On Июль 1, 2016, 3:54 п.п., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py,
> >  line 96
> > 
> >
> > No check for stack name?

I'll fix


> On Июль 1, 2016, 3:54 п.п., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java,
> >  line 194
> > 
> >
> > Good catch, however, why not look for "._" and replace that only if 
> > needed.

There is no change here. It's a copy of previous StormTimelineMetricsSink.java


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140370
---


On Июль 1, 2016, 3:32 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated Июль 1, 2016, 3:32 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 5e2d819 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 1591d39 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  ab5f1e4 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  6ab12e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  e582a95 
>   ambari-metrics/pom.xml 7221ab5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  073bb1c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  9acf173 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-01 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140370
---




ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 (line 194)


Good catch, however, why not look for "._" and replace that only if needed.



ambari-metrics/ambari-metrics-storm-sink/pom.xml (line 35)


Since this isn't apache version, checking this in will break apache builds ?



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
 (line 30)


So both old and new properties are ok to be present at the same time?



ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
 (line 96)


No check for stack name?


- Sid Wagle


On July 1, 2016, 3:32 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated July 1, 2016, 3:32 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 5e2d819 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 1591d39 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  ab5f1e4 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  6ab12e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  e582a95 
>   ambari-metrics/pom.xml 7221ab5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  073bb1c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  9acf173 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-01 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/
---

Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.


Bugs: AMBARI-17080
https://issues.apache.org/jira/browse/AMBARI-17080


Repository: ambari


Description
---

Support 2 storm sinks.


Diffs
-

  ambari-metrics/ambari-metrics-assembly/pom.xml 5e2d819 
  ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
e82d2d4 
  ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
  ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
PRE-CREATION 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 PRE-CREATION 
  ambari-metrics/ambari-metrics-storm-sink/pom.xml 1591d39 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
 4553224 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 ab5f1e4 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 6ab12e1 
  
ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 e582a95 
  ambari-metrics/pom.xml 7221ab5 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
 0d029e8 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 073bb1c 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
 2d50767 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
 6551067 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
 9acf173 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
 f3bbce8 

Diff: https://reviews.apache.org/r/49514/diff/


Testing
---

Unit testst passed


Thanks,

Dmytro Sen