Re: Review Request 49802: Host Namenode Rebalance HDFS failed

[wang yaoxin]

> On 九月 14, 2016, 5:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py,
> >  line 283
> > 
> >
> > Why would the json data be None?

Rebalance HDFS in the host web view, it will not show the Rebalance HDFS dialog 
to fill the disk capacity value, so the default threshold should be the default 
value, but the namenode.py not given a default value, so rebalance hdfs wil 
fail. It would be difficult to change from fore-end, moreover, the change may 
not fit into fore-end's design ,and I sense the bug is a serious issue, so I 
think it is better to give it the default value in the namenode.py .


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49802/#review148934
---


On 九月 14, 2016, 8:07 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49802/
> ---
> 
> (Updated 九月 14, 2016, 8:07 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, JaimejucoummaUW 
> JaimejucoummaUW, Zhe (Joe) Wang, Kuldeep Mishra, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17546
> https://issues.apache.org/jira/browse/AMBARI-17546
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> the host view ,excute namenode rebalance HDFS, json none lead fail
> 
> Rebalance HDFS in the host web view , it will not show the Rebalance HDFS 
> dialog to fill the disk capacity value, so rebalance hdfs wil fail. It would 
> be difficult to change from fore-end, moreover, the change may not fit into 
> fore-end's design ,and I sense the bug is a serious issue, so I think it is 
> better to give it the default value in the namenode.py .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  df02311 
> 
> Diff: https://reviews.apache.org/r/49802/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 49802: Host Namenode Rebalance HDFS failed

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49802/#review148934
---




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 (line 283)


Why would the json data be None?


- Alejandro Fernandez


On Sept. 14, 2016, 8:07 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49802/
> ---
> 
> (Updated Sept. 14, 2016, 8:07 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, JaimejucoummaUW 
> JaimejucoummaUW, Zhe (Joe) Wang, Kuldeep Mishra, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17546
> https://issues.apache.org/jira/browse/AMBARI-17546
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> the host view ,excute namenode rebalance HDFS, json none lead fail
> 
> Rebalance HDFS in the host web view , it will not show the Rebalance HDFS 
> dialog to fill the disk capacity value, so rebalance hdfs wil fail. It would 
> be difficult to change from fore-end, moreover, the change may not fit into 
> fore-end's design ,and I sense the bug is a serious issue, so I think it is 
> better to give it the default value in the namenode.py .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  df02311 
> 
> Diff: https://reviews.apache.org/r/49802/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 49802: Host Namenode Rebalance HDFS failed

[wang yaoxin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49802/
---

(Updated 九月 14, 2016, 8:07 a.m.)


Review request for Ambari, Alejandro Fernandez, JaimejucoummaUW 
JaimejucoummaUW, Zhe (Joe) Wang, Kuldeep Mishra, and Yusaku Sako.


Changes
---

It would be difficult to change from fore-end, moreover, the change may not fit 
into fore-end's design ,and I sense the bug is a serious issue


Bugs: AMBARI-17546
https://issues.apache.org/jira/browse/AMBARI-17546


Repository: ambari


Description (updated)
---

the host view ,excute namenode rebalance HDFS, json none lead fail

Rebalance HDFS in the host web view , it will not show the Rebalance HDFS 
dialog to fill the disk capacity value, so rebalance hdfs wil fail. It would be 
difficult to change from fore-end, moreover, the change may not fit into 
fore-end's design ,and I sense the bug is a serious issue, so I think it is 
better to give it the default value in the namenode.py .


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 df02311 

Diff: https://reviews.apache.org/r/49802/diff/


Testing
---

done


Thanks,

wang yaoxin

Re: Review Request 49802: Host Namenode Rebalance HDFS failed

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49802/#review146596
---




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 (line 283)


use "is None" instead
Or better yet, have a try-catch in which if the value is None, "", negative 
interger, etc. then the default value is 10

Under which conditions is this missing?
In other words, what is upstream that is causing this to fail?


- Alejandro Fernandez


On Aug. 24, 2016, 12:18 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49802/
> ---
> 
> (Updated Aug. 24, 2016, 12:18 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, JaimejucoummaUW 
> JaimejucoummaUW, and Kuldeep Mishra.
> 
> 
> Bugs: AMBARI-17546
> https://issues.apache.org/jira/browse/AMBARI-17546
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> the host view ,excute namenode rebalance HDFS, json none lead fail
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  df02311 
> 
> Diff: https://reviews.apache.org/r/49802/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Review Request 49802: Host Namenode Rebalance HDFS failed

[wang yaoxin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49802/
---

Review request for Ambari.


Bugs: AMBARI-17546
https://issues.apache.org/jira/browse/AMBARI-17546


Repository: ambari


Description
---

the host view ,excute namenode rebalance HDFS, json none lead fail


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 df02311 

Diff: https://reviews.apache.org/r/49802/diff/


Testing
---

done


Thanks,

wang yaoxin