Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
---

(Updated Oct. 17, 2016, 9:50 p.m.)


Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Jaimin Jetly, Zhe 
(Joe) Wang, Richard Zang, Xi Wang, and Yusaku Sako.


Changes
---

Resolved conflicts

Verified Manually.
Ambari-web unit tests pass.
30365 tests complete (3 minutes)
  151 tests pending


Bugs: AMBARI-17636
https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
---

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs (updated)
-

  ambari-web/app/styles/config_history_flow.less e2806ea 
  ambari-web/app/templates/common/configs/config_history_flow.hbs 59d6491 
  ambari-web/app/views/common/configs/config_history_flow.js 0674231 

Diff: https://reviews.apache.org/r/49838/diff/


Testing
---

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.

Local Ambari-web tests pass.
30364 tests complete (27 seconds)
151 tests pending
Verified manually


File Attachments


Gif of latest changes
  
https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/#review152958
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On Oct. 13, 2016, 12:35 a.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49838/
> ---
> 
> (Updated Oct. 13, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Jaimin Jetly, 
> Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17636
> https://issues.apache.org/jira/browse/AMBARI-17636
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Go to Service->Configs page (that have more than ~ 30 versions)
> * Open versions dropdown
> 
> *Result:*
> Number of visible versions limited by window height.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/config_history_flow.less 0b6dc3f 
>   ambari-web/app/templates/common/configs/config_history_flow.hbs fa67786 
>   ambari-web/app/views/common/configs/config_history_flow.js 5ad65ac 
> 
> Diff: https://reviews.apache.org/r/49838/diff/
> 
> 
> Testing
> ---
> 
> Local Ambari web test passed.
> 28944 tests complete (25 seconds)
> 154 tests pending
> Manual testing done.
> 
> Local Ambari-web tests pass.
> 30364 tests complete (27 seconds)
> 151 tests pending
> Verified manually
> 
> 
> File Attachments
> 
> 
> Gif of latest changes
>   
> https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
---

(Updated Oct. 13, 2016, 12:35 a.m.)


Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Jaimin Jetly, Zhe 
(Joe) Wang, Richard Zang, Xi Wang, and Yusaku Sako.


Changes
---

The patch fixes scrollbars visibility in all browsers across all the platforms. 

Verified manually.
Ambari-web unit tests pass.

30374 tests complete (30 seconds)
151 tests pending


Bugs: AMBARI-17636
https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
---

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs (updated)
-

  ambari-web/app/styles/config_history_flow.less 0b6dc3f 
  ambari-web/app/templates/common/configs/config_history_flow.hbs fa67786 
  ambari-web/app/views/common/configs/config_history_flow.js 5ad65ac 

Diff: https://reviews.apache.org/r/49838/diff/


Testing
---

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.

Local Ambari-web tests pass.
30364 tests complete (27 seconds)
151 tests pending
Verified manually


File Attachments


Gif of latest changes
  
https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
---

(Updated Sept. 29, 2016, 8:54 p.m.)


Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Jaimin Jetly, Zhe 
(Joe) Wang, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-17636
https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
---

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs
-

  ambari-web/app/styles/config_history_flow.less 0b6dc3f 

Diff: https://reviews.apache.org/r/49838/diff/


Testing
---

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.

Local Ambari-web tests pass.
30364 tests complete (27 seconds)
151 tests pending
Verified manually


File Attachments (updated)


Gif of latest changes
  
https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
---

(Updated Sept. 29, 2016, 8:01 p.m.)


Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.


Changes
---

Fixed a UI issue. Now minimum height of the the config versions box will extend 
based on the number of config versions present.


Bugs: AMBARI-17636
https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
---

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs (updated)
-

  ambari-web/app/styles/config_history_flow.less 0b6dc3f 

Diff: https://reviews.apache.org/r/49838/diff/


Testing (updated)
---

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.

Local Ambari-web tests pass.
30364 tests complete (27 seconds)
151 tests pending
Verified manually


File Attachments (updated)


Gif of latest changes
  
https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif
AMBARI-17636.v5.patch
  
https://reviews.apache.org/media/uploaded/files/2016/09/29/5f9a486d-f006-4a2a-890d-8cd2ac69efe9__AMBARI-17636.v5.patch


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/#review142419
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On July 15, 2016, 1:55 a.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49838/
> ---
> 
> (Updated July 15, 2016, 1:55 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17636
> https://issues.apache.org/jira/browse/AMBARI-17636
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Go to Service->Configs page (that have more than ~ 30 versions)
> * Open versions dropdown
> 
> *Result:*
> Number of visible versions limited by window height.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/config_history_flow.less fff3151 
>   ambari-web/app/templates/common/configs/config_history_dropdown_row.hbs 
> PRE-CREATION 
>   ambari-web/app/templates/common/configs/config_history_flow.hbs 73d6913 
>   ambari-web/app/views/common/configs/config_history_flow.js ad2b1ab 
> 
> Diff: https://reviews.apache.org/r/49838/diff/
> 
> 
> Testing
> ---
> 
> Local Ambari web test passed.
> 28944 tests complete (25 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> File Attachments
> 
> 
> Gif of latest changes
>   
> https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
---

(Updated July 15, 2016, 1:55 a.m.)


Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.


Changes
---

* Fixed a bug (Top bar buttons not working) 
* Handled click event in dropdown row view
* Ambari web tests pass
  29021 tests complete (25 seconds)
  154 tests pending
* Manual testing done


Bugs: AMBARI-17636
https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
---

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs (updated)
-

  ambari-web/app/styles/config_history_flow.less fff3151 
  ambari-web/app/templates/common/configs/config_history_dropdown_row.hbs 
PRE-CREATION 
  ambari-web/app/templates/common/configs/config_history_flow.hbs 73d6913 
  ambari-web/app/views/common/configs/config_history_flow.js ad2b1ab 

Diff: https://reviews.apache.org/r/49838/diff/


Testing
---

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.


File Attachments


Gif of latest changes
  
https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
---

(Updated July 14, 2016, 10:49 p.m.)


Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.


Changes
---

Video showing the change in UI


Bugs: AMBARI-17636
https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
---

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs
-

  ambari-web/app/styles/config_history_flow.less fff3151 
  ambari-web/app/templates/common/configs/config_history_dropdown_row.hbs 
PRE-CREATION 
  ambari-web/app/templates/common/configs/config_history_flow.hbs 73d6913 
  ambari-web/app/views/common/configs/config_history_flow.js ad2b1ab 

Diff: https://reviews.apache.org/r/49838/diff/


Testing
---

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.


File Attachments (updated)


Gif of latest changes
  
https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/#review142302
---




ambari-web/app/views/common/configs/config_history_flow.js (line 305)


this.get('hoveredServiceVersion.version')


- Zhe (Joe) Wang


On July 14, 2016, 10:21 p.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49838/
> ---
> 
> (Updated July 14, 2016, 10:21 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17636
> https://issues.apache.org/jira/browse/AMBARI-17636
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Go to Service->Configs page (that have more than ~ 30 versions)
> * Open versions dropdown
> 
> *Result:*
> Number of visible versions limited by window height.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/config_history_flow.less fff3151 
>   ambari-web/app/templates/common/configs/config_history_dropdown_row.hbs 
> PRE-CREATION 
>   ambari-web/app/templates/common/configs/config_history_flow.hbs 73d6913 
>   ambari-web/app/views/common/configs/config_history_flow.js ad2b1ab 
> 
> Diff: https://reviews.apache.org/r/49838/diff/
> 
> 
> Testing
> ---
> 
> Local Ambari web test passed.
> 28944 tests complete (25 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
---

(Updated July 14, 2016, 10:21 p.m.)


Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.


Changes
---

* Applied a workaround for a bug 
(http://stackoverflow.com/questions/21369752/safari-positionfixed-doesnt-breaks-element-from-scope/21440899#21440899)
 in Safari. 
* Removed top and bottom scroll buttons to enable auto-scrolling.
* Displaying sub-menu popup with respect to the window height.
* Added Firefox specific styles to be consistent across all browsers.
* Handled sub-menu display manually instead of using the twitter bootstrap 
framework.
* Refactored code.
* Ambari web test passed
  29021 tests complete (25 seconds)
  154 tests pending
* Manual testing done in the latest versions of Google Chrome, Mozilla Firefox 
and Safari.


Bugs: AMBARI-17636
https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
---

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs (updated)
-

  ambari-web/app/styles/config_history_flow.less fff3151 
  ambari-web/app/templates/common/configs/config_history_dropdown_row.hbs 
PRE-CREATION 
  ambari-web/app/templates/common/configs/config_history_flow.hbs 73d6913 
  ambari-web/app/views/common/configs/config_history_flow.js ad2b1ab 

Diff: https://reviews.apache.org/r/49838/diff/


Testing
---

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.


Thanks,

Vivek Ratnavel Subramanian

Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
---

Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.


Bugs: AMBARI-17636
https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
---

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs
-

  ambari-web/app/styles/config_history_flow.less fff3151 
  ambari-web/app/templates/common/configs/config_history_flow.hbs 73d6913 
  ambari-web/app/views/common/configs/config_history_flow.js ad2b1ab 

Diff: https://reviews.apache.org/r/49838/diff/


Testing
---

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.


Thanks,

Vivek Ratnavel Subramanian