Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review153220 --- Ship it! Ship It! - Richard Zang On Oct. 18, 2016, 11:37 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52495/ > --- > > (Updated Oct. 18, 2016, 11:37 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18245 > https://issues.apache.org/jira/browse/AMBARI-18245 > > > Repository: ambari > > > Description > --- > > We are currently using 0.10, which is very old and going EOL 2016-10-01: > https://github.com/nodejs/LTS > We should upgrade to Node 4.x: > Upgrade Node on Ambari Web > Upgrade Node on Ambari Admin > Upgrade Node on contrib/views/* modules > > > Diffs > - > > .gitignore d9f23de > ambari-admin/pom.xml e057178 > ambari-admin/src/main/resources/ui/admin-web/package.json 42f584e > ambari-web/app/styles/common.less a053d28 > ambari-web/karma.conf.js 7442b95 > ambari-web/package.json 94ded60 > ambari-web/pom.xml d3de055 > contrib/views/capacity-scheduler/pom.xml cd97dcf > contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 > contrib/views/files/pom.xml 383d90d > contrib/views/hawq/pom.xml 9a563f6 > contrib/views/hive-next/pom.xml 921990a > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hive/pom.xml 20b23f6 > contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hueambarimigration/pom.xml 3b28276 > contrib/views/jobs/pom.xml bd01753 > contrib/views/pig/pom.xml 595537a > contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 > contrib/views/wfmanager/pom.xml 389dc6c > > Diff: https://reviews.apache.org/r/52495/diff/ > > > Testing > --- > > Ran "mvn clean package", Ambari Server failed, which is irralevant to this > patch. > Then run "mvn clean install" individually: > > Ambari Web: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 3:08.144s > [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016 > [INFO] Final Memory: 16M/407M > [INFO] > > > 30366 tests complete (27 seconds) > 151 tests pending > > Ambari Admin: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 14.924s > [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016 > [INFO] Final Memory: 20M/284M > [INFO] > > > PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 > secs) > > contrib/views/ modules: > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s] > [INFO] Ambari View Utils . SUCCESS [4.714s] > [INFO] Ambari View Commons ... SUCCESS [0.286s] > [INFO] Files . SUCCESS [52.631s] > [INFO] Jobs .. SUCCESS [6.712s] > [INFO] Pig ... SUCCESS [1:07.799s] > [INFO] Slider SUCCESS [36.043s] > [INFO] Capacity Scheduler SUCCESS [53.446s] > [INFO] Tez ... SUCCESS [3.659s] > [INFO] HAWQ .. SUCCESS [2:24.060s] > [INFO] Storm_Monitoring .. SUCCESS [0.432s] > [INFO] Zeppelin .. SUCCESS [2.080s] > [INFO] hueambarimigration SUCCESS [20.801s] > [INFO] Hive Jdbc . SUCCESS [1:00.664s] > [INFO] WF Manager View ... SUCCESS [32.911s] > [INFO] Hive .. SUCCESS [51.542s] > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 9:58.964s > [INFO] Finished at: Mon Oct 03 17:22:59 PDT 2016 > [INFO]
Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/ --- (Updated Oct. 18, 2016, 11:37 p.m.) Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18245 https://issues.apache.org/jira/browse/AMBARI-18245 Repository: ambari Description --- We are currently using 0.10, which is very old and going EOL 2016-10-01: https://github.com/nodejs/LTS We should upgrade to Node 4.x: Upgrade Node on Ambari Web Upgrade Node on Ambari Admin Upgrade Node on contrib/views/* modules Diffs (updated) - .gitignore d9f23de ambari-admin/pom.xml e057178 ambari-admin/src/main/resources/ui/admin-web/package.json 42f584e ambari-web/app/styles/common.less a053d28 ambari-web/karma.conf.js 7442b95 ambari-web/package.json 94ded60 ambari-web/pom.xml d3de055 contrib/views/capacity-scheduler/pom.xml cd97dcf contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 contrib/views/files/pom.xml 383d90d contrib/views/hawq/pom.xml 9a563f6 contrib/views/hive-next/pom.xml 921990a contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 contrib/views/hive/pom.xml 20b23f6 contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 contrib/views/hueambarimigration/pom.xml 3b28276 contrib/views/jobs/pom.xml bd01753 contrib/views/pig/pom.xml 595537a contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 contrib/views/wfmanager/pom.xml 389dc6c Diff: https://reviews.apache.org/r/52495/diff/ Testing --- Ran "mvn clean package", Ambari Server failed, which is irralevant to this patch. Then run "mvn clean install" individually: Ambari Web: [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 3:08.144s [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016 [INFO] Final Memory: 16M/407M [INFO] 30366 tests complete (27 seconds) 151 tests pending Ambari Admin: [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 14.924s [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016 [INFO] Final Memory: 20M/284M [INFO] PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 secs) contrib/views/ modules: [INFO] [INFO] Reactor Summary: [INFO] [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s] [INFO] Ambari View Utils . SUCCESS [4.714s] [INFO] Ambari View Commons ... SUCCESS [0.286s] [INFO] Files . SUCCESS [52.631s] [INFO] Jobs .. SUCCESS [6.712s] [INFO] Pig ... SUCCESS [1:07.799s] [INFO] Slider SUCCESS [36.043s] [INFO] Capacity Scheduler SUCCESS [53.446s] [INFO] Tez ... SUCCESS [3.659s] [INFO] HAWQ .. SUCCESS [2:24.060s] [INFO] Storm_Monitoring .. SUCCESS [0.432s] [INFO] Zeppelin .. SUCCESS [2.080s] [INFO] hueambarimigration SUCCESS [20.801s] [INFO] Hive Jdbc . SUCCESS [1:00.664s] [INFO] WF Manager View ... SUCCESS [32.911s] [INFO] Hive .. SUCCESS [51.542s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 9:58.964s [INFO] Finished at: Mon Oct 03 17:22:59 PDT 2016 [INFO] Final Memory: 90M/404M [INFO] Thanks, Zhe (Joe) Wang
Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review151604 --- Ship it! Ship It! - Richard Zang On Oct. 4, 2016, 12:51 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52495/ > --- > > (Updated Oct. 4, 2016, 12:51 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18245 > https://issues.apache.org/jira/browse/AMBARI-18245 > > > Repository: ambari > > > Description > --- > > We are currently using 0.10, which is very old and going EOL 2016-10-01: > https://github.com/nodejs/LTS > We should upgrade to Node 4.x: > Upgrade Node on Ambari Web > Upgrade Node on Ambari Admin > Upgrade Node on contrib/views/* modules > > > Diffs > - > > .gitignore d9f23de > ambari-admin/pom.xml e057178 > ambari-web/app/styles/common.less bc11d4d > ambari-web/package.json 6702471 > ambari-web/pom.xml 759b63e > contrib/views/capacity-scheduler/pom.xml cd97dcf > contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 > contrib/views/files/pom.xml 383d90d > contrib/views/hawq/pom.xml 9a563f6 > contrib/views/hive-next/pom.xml 921990a > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hive/pom.xml 20b23f6 > contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hueambarimigration/pom.xml 3b28276 > contrib/views/jobs/pom.xml bd01753 > contrib/views/pig/pom.xml 595537a > contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 > contrib/views/wfmanager/pom.xml 389dc6c > > Diff: https://reviews.apache.org/r/52495/diff/ > > > Testing > --- > > Ran "mvn clean package", Ambari Server failed, which is irralevant to this > patch. > Then run "mvn clean install" individually: > > Ambari Web: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 3:08.144s > [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016 > [INFO] Final Memory: 16M/407M > [INFO] > > > 30366 tests complete (27 seconds) > 151 tests pending > > Ambari Admin: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 14.924s > [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016 > [INFO] Final Memory: 20M/284M > [INFO] > > > PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 > secs) > > contrib/views/ modules: > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s] > [INFO] Ambari View Utils . SUCCESS [4.714s] > [INFO] Ambari View Commons ... SUCCESS [0.286s] > [INFO] Files . SUCCESS [52.631s] > [INFO] Jobs .. SUCCESS [6.712s] > [INFO] Pig ... SUCCESS [1:07.799s] > [INFO] Slider SUCCESS [36.043s] > [INFO] Capacity Scheduler SUCCESS [53.446s] > [INFO] Tez ... SUCCESS [3.659s] > [INFO] HAWQ .. SUCCESS [2:24.060s] > [INFO] Storm_Monitoring .. SUCCESS [0.432s] > [INFO] Zeppelin .. SUCCESS [2.080s] > [INFO] hueambarimigration SUCCESS [20.801s] > [INFO] Hive Jdbc . SUCCESS [1:00.664s] > [INFO] WF Manager View ... SUCCESS [32.911s] > [INFO] Hive .. SUCCESS [51.542s] > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 9:58.964s > [INFO] Finished at: Mon Oct 03 17:22:59 PDT 2016 > [INFO] Final Memory: 90M/404M > [INFO] > > > >
Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
> On Oct. 3, 2016, 10:57 p.m., Yusaku Sako wrote: > > When you say "local testing done", what did that entail? > > Also, did you explicitly build all the contrib/views modules with the > > change? Added the details. Thank you. - Zhe (Joe) --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review151248 --- On Oct. 4, 2016, 12:51 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52495/ > --- > > (Updated Oct. 4, 2016, 12:51 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18245 > https://issues.apache.org/jira/browse/AMBARI-18245 > > > Repository: ambari > > > Description > --- > > We are currently using 0.10, which is very old and going EOL 2016-10-01: > https://github.com/nodejs/LTS > We should upgrade to Node 4.x: > Upgrade Node on Ambari Web > Upgrade Node on Ambari Admin > Upgrade Node on contrib/views/* modules > > > Diffs > - > > .gitignore d9f23de > ambari-admin/pom.xml e057178 > ambari-web/app/styles/common.less bc11d4d > ambari-web/package.json 6702471 > ambari-web/pom.xml 759b63e > contrib/views/capacity-scheduler/pom.xml cd97dcf > contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 > contrib/views/files/pom.xml 383d90d > contrib/views/hawq/pom.xml 9a563f6 > contrib/views/hive-next/pom.xml 921990a > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hive/pom.xml 20b23f6 > contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hueambarimigration/pom.xml 3b28276 > contrib/views/jobs/pom.xml bd01753 > contrib/views/pig/pom.xml 595537a > contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 > contrib/views/wfmanager/pom.xml 389dc6c > > Diff: https://reviews.apache.org/r/52495/diff/ > > > Testing > --- > > Ran "mvn clean package", Ambari Server failed, which is irralevant to this > patch. > Then run "mvn clean install" individually: > > Ambari Web: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 3:08.144s > [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016 > [INFO] Final Memory: 16M/407M > [INFO] > > > 30366 tests complete (27 seconds) > 151 tests pending > > Ambari Admin: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 14.924s > [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016 > [INFO] Final Memory: 20M/284M > [INFO] > > > PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 > secs) > > contrib/views/ modules: > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s] > [INFO] Ambari View Utils . SUCCESS [4.714s] > [INFO] Ambari View Commons ... SUCCESS [0.286s] > [INFO] Files . SUCCESS [52.631s] > [INFO] Jobs .. SUCCESS [6.712s] > [INFO] Pig ... SUCCESS [1:07.799s] > [INFO] Slider SUCCESS [36.043s] > [INFO] Capacity Scheduler SUCCESS [53.446s] > [INFO] Tez ... SUCCESS [3.659s] > [INFO] HAWQ .. SUCCESS [2:24.060s] > [INFO] Storm_Monitoring .. SUCCESS [0.432s] > [INFO] Zeppelin .. SUCCESS [2.080s] > [INFO] hueambarimigration SUCCESS [20.801s] > [INFO] Hive Jdbc . SUCCESS [1:00.664s] > [INFO] WF Manager View ... SUCCESS [32.911s] > [INFO] Hive .. SUCCESS [51.542s] > [INFO] > > [INFO] BUILD SUCCESS > [INFO] >
Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/ --- (Updated Oct. 4, 2016, 12:51 a.m.) Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18245 https://issues.apache.org/jira/browse/AMBARI-18245 Repository: ambari Description --- We are currently using 0.10, which is very old and going EOL 2016-10-01: https://github.com/nodejs/LTS We should upgrade to Node 4.x: Upgrade Node on Ambari Web Upgrade Node on Ambari Admin Upgrade Node on contrib/views/* modules Diffs (updated) - .gitignore d9f23de ambari-admin/pom.xml e057178 ambari-web/app/styles/common.less bc11d4d ambari-web/package.json 6702471 ambari-web/pom.xml 759b63e contrib/views/capacity-scheduler/pom.xml cd97dcf contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 contrib/views/files/pom.xml 383d90d contrib/views/hawq/pom.xml 9a563f6 contrib/views/hive-next/pom.xml 921990a contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 contrib/views/hive/pom.xml 20b23f6 contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 contrib/views/hueambarimigration/pom.xml 3b28276 contrib/views/jobs/pom.xml bd01753 contrib/views/pig/pom.xml 595537a contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 contrib/views/wfmanager/pom.xml 389dc6c Diff: https://reviews.apache.org/r/52495/diff/ Testing (updated) --- Ran "mvn clean package", Ambari Server failed, which is irralevant to this patch. Then run "mvn clean install" individually: Ambari Web: [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 3:08.144s [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016 [INFO] Final Memory: 16M/407M [INFO] 30366 tests complete (27 seconds) 151 tests pending Ambari Admin: [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 14.924s [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016 [INFO] Final Memory: 20M/284M [INFO] PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 secs) contrib/views/ modules: [INFO] [INFO] Reactor Summary: [INFO] [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s] [INFO] Ambari View Utils . SUCCESS [4.714s] [INFO] Ambari View Commons ... SUCCESS [0.286s] [INFO] Files . SUCCESS [52.631s] [INFO] Jobs .. SUCCESS [6.712s] [INFO] Pig ... SUCCESS [1:07.799s] [INFO] Slider SUCCESS [36.043s] [INFO] Capacity Scheduler SUCCESS [53.446s] [INFO] Tez ... SUCCESS [3.659s] [INFO] HAWQ .. SUCCESS [2:24.060s] [INFO] Storm_Monitoring .. SUCCESS [0.432s] [INFO] Zeppelin .. SUCCESS [2.080s] [INFO] hueambarimigration SUCCESS [20.801s] [INFO] Hive Jdbc . SUCCESS [1:00.664s] [INFO] WF Manager View ... SUCCESS [32.911s] [INFO] Hive .. SUCCESS [51.542s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 9:58.964s [INFO] Finished at: Mon Oct 03 17:22:59 PDT 2016 [INFO] Final Memory: 90M/404M [INFO] Thanks, Zhe (Joe) Wang
Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review151248 --- When you say "local testing done", what did that entail? Also, did you explicitly build all the contrib/views modules with the change? - Yusaku Sako On Oct. 3, 2016, 10:46 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52495/ > --- > > (Updated Oct. 3, 2016, 10:46 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18245 > https://issues.apache.org/jira/browse/AMBARI-18245 > > > Repository: ambari > > > Description > --- > > We are currently using 0.10, which is very old and going EOL 2016-10-01: > https://github.com/nodejs/LTS > We should upgrade to Node 4.x: > Upgrade Node on Ambari Web > Upgrade Node on Ambari Admin > Upgrade Node on contrib/views/* modules > > > Diffs > - > > .gitignore d9f23de > ambari-admin/pom.xml e057178 > ambari-web/app/styles/common.less bc11d4d > ambari-web/package.json 6702471 > ambari-web/pom.xml 759b63e > contrib/views/capacity-scheduler/pom.xml cd97dcf > contrib/views/files/pom.xml 383d90d > contrib/views/hawq/pom.xml 9a563f6 > contrib/views/hive-next/pom.xml 921990a > contrib/views/hive/pom.xml 20b23f6 > contrib/views/hueambarimigration/pom.xml 3b28276 > contrib/views/jobs/pom.xml bd01753 > contrib/views/pig/pom.xml 595537a > contrib/views/wfmanager/pom.xml 389dc6c > > Diff: https://reviews.apache.org/r/52495/diff/ > > > Testing > --- > > Local test passed. > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18245 https://issues.apache.org/jira/browse/AMBARI-18245 Repository: ambari Description --- We are currently using 0.10, which is very old and going EOL 2016-10-01: https://github.com/nodejs/LTS We should upgrade to Node 4.x: Upgrade Node on Ambari Web Upgrade Node on Ambari Admin Upgrade Node on contrib/views/* modules Diffs - .gitignore d9f23de ambari-admin/pom.xml e057178 ambari-web/app/styles/common.less bc11d4d ambari-web/package.json 6702471 ambari-web/pom.xml 759b63e contrib/views/capacity-scheduler/pom.xml cd97dcf contrib/views/files/pom.xml 383d90d contrib/views/hawq/pom.xml 9a563f6 contrib/views/hive-next/pom.xml 921990a contrib/views/hive/pom.xml 20b23f6 contrib/views/hueambarimigration/pom.xml 3b28276 contrib/views/jobs/pom.xml bd01753 contrib/views/pig/pom.xml 595537a contrib/views/wfmanager/pom.xml 389dc6c Diff: https://reviews.apache.org/r/52495/diff/ Testing --- Local test passed. Manual testing done. Thanks, Zhe (Joe) Wang
