Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

2017-06-20 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178395
---


Ship it!




Ship It!

- Jayush Luniya


On June 20, 2017, 3:48 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> ---
> 
> (Updated June 20, 2017, 3:48 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
> https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
> replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
> install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
> process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
> create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
> create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
> sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
> os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 160c91d 
>   ambari-server/src/test/python/TestAmbariServer.py 6bf5e43 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

2017-06-20 Thread Vitalyi Brodetskyi 


> On Червень 20, 2017, північ, Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server/serverUpgrade.py
> > Lines 569 (patched)
> > 
> >
> > Add a comment for what this does

Sorry, missed your note, will add comment during commit.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178330
---


On Червень 20, 2017, 3:48 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> ---
> 
> (Updated Червень 20, 2017, 3:48 після полудня)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
> https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
> replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
> install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
> process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
> create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
> create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
> sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
> os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 160c91d 
>   ambari-server/src/test/python/TestAmbariServer.py 6bf5e43 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

2017-06-20 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/
---

(Updated Червень 20, 2017, 3:48 після полудня)


Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.


Bugs: AMBARI-21263
https://issues.apache.org/jira/browse/AMBARI-21263


Repository: ambari


Description
---

{code}
INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
Traceback (most recent call last):
  File "/usr/sbin/ambari-server.py", line 941, in 
mainBody()
  File "/usr/sbin/ambari-server.py", line 911, in mainBody
main(options, args, parser)
  File "/usr/sbin/ambari-server.py", line 863, in main
action_obj.execute()
  File "/usr/sbin/ambari-server.py", line 78, in execute
self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", line 
363, in upgrade
replay_mpack_logs()
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
983, in replay_mpack_logs
install_mpack(replay_options, replay_mode=True)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
896, in install_mpack
(mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
mpack_archive_path) = _install_mpack(options, replay_mode)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
792, in _install_mpack
process_service_definitions_artifact(artifact, artifact_source_dir, options)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
515, in process_service_definitions_artifact
create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
file, options.force)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
235, in create_symlink
create_symlink_using_path(src_path, dest_link, force)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
247, in create_symlink_using_path
sudo.symlink(src_path, dest_link)
  File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
line 123, in symlink
os.symlink(source, link_name)
OSError: [Errno 17] File exists
{code}


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/serverUpgrade.py 160c91d 
  ambari-server/src/test/python/TestAmbariServer.py 6bf5e43 


Diff: https://reviews.apache.org/r/60126/diff/3/

Changes: https://reviews.apache.org/r/60126/diff/2-3/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

2017-06-19 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178330
---


Fix it, then Ship it!





ambari-server/src/main/python/ambari_server/serverUpgrade.py
Lines 569 (patched)


Add a comment for what this does


- Alejandro Fernandez


On June 19, 2017, 10:38 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> ---
> 
> (Updated June 19, 2017, 10:38 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
> https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
> replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
> install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
> process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
> create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
> create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
> sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
> os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 160c91d 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

2017-06-19 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178324
---


Ship it!




Ship It!

- Sumit Mohanty


On June 19, 2017, 10:38 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> ---
> 
> (Updated June 19, 2017, 10:38 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
> https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
> replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
> install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
> process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
> create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
> create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
> sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
> os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 160c91d 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

2017-06-19 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178323
---


Ship it!




Ship It!

- Jayush Luniya


On June 19, 2017, 10:38 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> ---
> 
> (Updated June 19, 2017, 10:38 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
> https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
> replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
> install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
> process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
> create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
> create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
> sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
> os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 160c91d 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

2017-06-19 Thread Vitalyi Brodetskyi 


> On Червень 19, 2017, 3:49 після полудня, Jayush Luniya wrote:
> > ambari-server/src/main/python/ambari_server/serverUpgrade.py
> > Line 428 (original), 428 (patched)
> > 
> >
> > Any unit tests to cover this?

Will add tomorrow.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178253
---


On Червень 19, 2017, 10:38 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> ---
> 
> (Updated Червень 19, 2017, 10:38 після полудня)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
> https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
> replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
> install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
> process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
> create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
> create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
> sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
> os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 160c91d 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

2017-06-19 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/
---

(Updated Червень 19, 2017, 10:38 після полудня)


Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.


Bugs: AMBARI-21263
https://issues.apache.org/jira/browse/AMBARI-21263


Repository: ambari


Description
---

{code}
INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
Traceback (most recent call last):
  File "/usr/sbin/ambari-server.py", line 941, in 
mainBody()
  File "/usr/sbin/ambari-server.py", line 911, in mainBody
main(options, args, parser)
  File "/usr/sbin/ambari-server.py", line 863, in main
action_obj.execute()
  File "/usr/sbin/ambari-server.py", line 78, in execute
self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", line 
363, in upgrade
replay_mpack_logs()
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
983, in replay_mpack_logs
install_mpack(replay_options, replay_mode=True)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
896, in install_mpack
(mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
mpack_archive_path) = _install_mpack(options, replay_mode)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
792, in _install_mpack
process_service_definitions_artifact(artifact, artifact_source_dir, options)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
515, in process_service_definitions_artifact
create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
file, options.force)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
235, in create_symlink
create_symlink_using_path(src_path, dest_link, force)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
247, in create_symlink_using_path
sudo.symlink(src_path, dest_link)
  File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
line 123, in symlink
os.symlink(source, link_name)
OSError: [Errno 17] File exists
{code}


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/serverUpgrade.py 160c91d 


Diff: https://reviews.apache.org/r/60126/diff/2/

Changes: https://reviews.apache.org/r/60126/diff/1-2/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

2017-06-19 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178253
---




ambari-server/src/main/python/ambari_server/serverUpgrade.py
Line 428 (original), 428 (patched)


Any unit tests to cover this?


- Jayush Luniya


On June 15, 2017, 5:11 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> ---
> 
> (Updated June 15, 2017, 5:11 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
> https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
> replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
> install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
> process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
> create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
> create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
> sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
> os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py b488ca6 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

2017-06-19 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178251
---




ambari-server/src/main/python/ambari_server/serverUpgrade.py
Lines 430 (patched)


We should not just check one version directory. It is possible that 
common-services/HDFS/2.1.0 is included in Ambari codebase and hence not a 
symlink but common-services/HDFS/3.0.0 is brought in via mpack and hence is a 
symlink.


- Jayush Luniya


On June 15, 2017, 5:11 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> ---
> 
> (Updated June 15, 2017, 5:11 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
> https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
> replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
> install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
> process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
> create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
> create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
> sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
> os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py b488ca6 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>