Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/
---

(Updated July 6, 2017, 5:17 p.m.)


Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan 
Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21351
https://issues.apache.org/jira/browse/AMBARI-21351


Repository: ambari


Description
---

Some stacks, such as BigInights, support MariaDB as the database for Hive. When 
upgrading from BigInights to another stack, such as HDP, this causes the 
following exception when starting the Hive service:
```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
Failed to stop mysqld.service: Unit mysqld.service not loaded.```
This looks to be caused by the hard-coded reliance of mysqld in the Python 
scripts.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 fd4fc64 


Diff: https://reviews.apache.org/r/60480/diff/5/

Changes: https://reviews.apache.org/r/60480/diff/4-5/


Testing
---

Tim and I patched a cluster with basically the same fix when migrating an IOP 
4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
that's to set StackFeature boolean in case this code gets merged back to trunk 
later on. 

If the code only stays in this branch, the StackFeature boolean change can be 
omitted.


Thanks,

Di Li

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179354
---


Ship it!




Ship It!

- Jonathan Hurley


On June 29, 2017, 11:47 a.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 29, 2017, 11:47 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/4/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

> On June 28, 2017, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> > Lines 118 (patched)
> > 
> >
> > This is missing 
> 
> Di Li wrote:
> right, I removed it per Jonathan's comment. Or I can add it back but set 
> to false ( not seeing the point of that comparing to not having the line at 
> all)
> 
> " This will cause upgrades to change configs and have Hive report 
> staleness and require a restart. Instead, it seems like we should default to 
> False if not found and use the upgrade packs to update this.
> 
> In other words; since Stack-A might need this when moving to Stack-B, 
> then it should provide this as a configuration setting. "
> 
> Di Li wrote:
> I think I misundertood Jonathan's comment. It should have been a Py only 
> change with default value to false and rely on config update during the 
> migration to tell Py to use mariadb instead of mysqld.
> 
> Jonathan Hurley wrote:
> Yes, my point was to track this in trunk. A cluster which has gone 
> through an upgrade with Ambari 2.5 will regress on Ambari 3.0. The problem is 
> that we should really be tracking this via a real config property. 
> Introducing the property is fine, but on-ambari-upgrade=false must be used 
> since it's not critical for Ambari's operation. This means it should have 
> sensible defaults and should be updated using the upgrade packs for stack 
> upgrade.
> 
> The whole problem centers around downtime. If a business has an outage 
> for an Ambari upgrade, they won't be able to restart Hive when it shows stale 
> configs.

How about the latest patch where the only change is in the Python script 
(default to false of the special property). It's then up to the upgrade pack or 
preupgrad manual step to set the value if cluster is a migrated one? 

This patch can then be applied to both the feature branch and trunk.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179157
---


On June 29, 2017, 3:47 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 29, 2017, 3:47 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/4/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Jonathan Hurley]

> On June 28, 2017, 3:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> > Lines 118 (patched)
> > 
> >
> > This is missing 
> 
> Di Li wrote:
> right, I removed it per Jonathan's comment. Or I can add it back but set 
> to false ( not seeing the point of that comparing to not having the line at 
> all)
> 
> " This will cause upgrades to change configs and have Hive report 
> staleness and require a restart. Instead, it seems like we should default to 
> False if not found and use the upgrade packs to update this.
> 
> In other words; since Stack-A might need this when moving to Stack-B, 
> then it should provide this as a configuration setting. "
> 
> Di Li wrote:
> I think I misundertood Jonathan's comment. It should have been a Py only 
> change with default value to false and rely on config update during the 
> migration to tell Py to use mariadb instead of mysqld.

Yes, my point was to track this in trunk. A cluster which has gone through an 
upgrade with Ambari 2.5 will regress on Ambari 3.0. The problem is that we 
should really be tracking this via a real config property. Introducing the 
property is fine, but on-ambari-upgrade=false must be used since it's not 
critical for Ambari's operation. This means it should have sensible defaults 
and should be updated using the upgrade packs for stack upgrade.

The whole problem centers around downtime. If a business has an outage for an 
Ambari upgrade, they won't be able to restart Hive when it shows stale configs.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179157
---


On June 29, 2017, 11:47 a.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 29, 2017, 11:47 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/4/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/
---

(Updated June 29, 2017, 3:47 p.m.)


Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan 
Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21351
https://issues.apache.org/jira/browse/AMBARI-21351


Repository: ambari


Description
---

Some stacks, such as BigInights, support MariaDB as the database for Hive. When 
upgrading from BigInights to another stack, such as HDP, this causes the 
following exception when starting the Hive service:
```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
Failed to stop mysqld.service: Unit mysqld.service not loaded.```
This looks to be caused by the hard-coded reliance of mysqld in the Python 
scripts.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 b7cb148 


Diff: https://reviews.apache.org/r/60480/diff/4/

Changes: https://reviews.apache.org/r/60480/diff/3-4/


Testing
---

Tim and I patched a cluster with basically the same fix when migrating an IOP 
4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
that's to set StackFeature boolean in case this code gets merged back to trunk 
later on. 

If the code only stays in this branch, the StackFeature boolean change can be 
omitted.


Thanks,

Di Li

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

> On June 28, 2017, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> > Lines 118 (patched)
> > 
> >
> > This is missing 
> 
> Di Li wrote:
> right, I removed it per Jonathan's comment. Or I can add it back but set 
> to false ( not seeing the point of that comparing to not having the line at 
> all)
> 
> " This will cause upgrades to change configs and have Hive report 
> staleness and require a restart. Instead, it seems like we should default to 
> False if not found and use the upgrade packs to update this.
> 
> In other words; since Stack-A might need this when moving to Stack-B, 
> then it should provide this as a configuration setting. "

I think I misundertood Jonathan's comment. It should have been a Py only change 
with default value to false and rely on config update during the migration to 
tell Py to use mariadb instead of mysqld.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179157
---


On June 28, 2017, 6:23 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 28, 2017, 6:23 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  1cf9016 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/3/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

> On June 28, 2017, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> > Lines 118 (patched)
> > 
> >
> > This is missing 

right, I removed it per Jonathan's comment. Or I can add it back but set to 
false ( not seeing the point of that comparing to not having the line at all)

" This will cause upgrades to change configs and have Hive report staleness and 
require a restart. Instead, it seems like we should default to False if not 
found and use the upgrade packs to update this.

In other words; since Stack-A might need this when moving to Stack-B, then it 
should provide this as a configuration setting. "


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179157
---


On June 28, 2017, 6:23 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 28, 2017, 6:23 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  1cf9016 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/3/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179157
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
Lines 118 (patched)


This is missing 


- Alejandro Fernandez


On June 28, 2017, 6:23 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 28, 2017, 6:23 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  1cf9016 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/3/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/
---

(Updated June 28, 2017, 6:23 p.m.)


Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan 
Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21351
https://issues.apache.org/jira/browse/AMBARI-21351


Repository: ambari


Description
---

Some stacks, such as BigInights, support MariaDB as the database for Hive. When 
upgrading from BigInights to another stack, such as HDP, this causes the 
following exception when starting the Hive service:
```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
Failed to stop mysqld.service: Unit mysqld.service not loaded.```
This looks to be caused by the hard-coded reliance of mysqld in the Python 
scripts.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
 1cf9016 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 b7cb148 


Diff: https://reviews.apache.org/r/60480/diff/3/

Changes: https://reviews.apache.org/r/60480/diff/2-3/


Testing
---

Tim and I patched a cluster with basically the same fix when migrating an IOP 
4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
that's to set StackFeature boolean in case this code gets merged back to trunk 
later on. 

If the code only stays in this branch, the StackFeature boolean change can be 
omitted.


Thanks,

Di Li

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179142
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
Lines 119 (patched)


This will cause upgrades to change configs and have Hive report staleness 
and require a restart. Instead, it seems like we should default to False if not 
found and use the upgrade packs to update this.

In other words; since Stack-A might need this when moving to Stack-B, then 
it should provide this as a configuration setting.


- Jonathan Hurley


On June 28, 2017, 1:31 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 28, 2017, 1:31 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  1cf9016 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/2/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

> On June 28, 2017, 2:48 p.m., Jonathan Hurley wrote:
> > Should this also be put into trunk? We would still need to support this 
> > moving forward. Maybe we need a Jira to track an actual property which 
> > governs which database executable to invoke.
> 
> Di Li wrote:
> An updated version should be pushed to trunk as HDP will probably have to 
> support Hive/MariaDB on migrated IOP clusters until all these clusters reach 
> the end of support terms. I can propose a new patch for trunk later on.

I just uploaded a new patch that uses a property to determine the daemon name - 
 mysqld vs mariadb. If we use this new patch, it'd be easier for HDP to future 
support this migrated clusters ( same patch to be pushed to trunk, no need to 
have special change for the feature branch.)


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179109
---


On June 28, 2017, 5:31 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 28, 2017, 5:31 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  1cf9016 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/2/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

> On June 28, 2017, 2:48 p.m., Jonathan Hurley wrote:
> > Should this also be put into trunk? We would still need to support this 
> > moving forward. Maybe we need a Jira to track an actual property which 
> > governs which database executable to invoke.

An updated version should be pushed to trunk as HDP will probably have to 
support Hive/MariaDB on migrated IOP clusters until all these clusters reach 
the end of support terms. I can propose a new patch for trunk later on.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179109
---


On June 27, 2017, 8:08 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 27, 2017, 8:08 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/1/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179109
---



Should this also be put into trunk? We would still need to support this moving 
forward. Maybe we need a Jira to track an actual property which governs which 
database executable to invoke.

- Jonathan Hurley


On June 27, 2017, 4:08 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 27, 2017, 4:08 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/1/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179108
---


Ship it!




Ship It!

- Jonathan Hurley


On June 27, 2017, 4:08 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 27, 2017, 4:08 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/1/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179055
---


Ship it!




Ship It!

- Tim Thorpe


On June 27, 2017, 8:08 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 27, 2017, 8:08 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/1/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179034
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 27, 2017, 8:08 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 27, 2017, 8:08 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/1/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/
---

Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan 
Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21351
https://issues.apache.org/jira/browse/AMBARI-21351


Repository: ambari


Description
---

Some stacks, such as BigInights, support MariaDB as the database for Hive. When 
upgrading from BigInights to another stack, such as HDP, this causes the 
following exception when starting the Hive service:
```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
Failed to stop mysqld.service: Unit mysqld.service not loaded.```
This looks to be caused by the hard-coded reliance of mysqld in the Python 
scripts.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 c74e029 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 b7cb148 


Diff: https://reviews.apache.org/r/60480/diff/1/


Testing
---

Tim and I patched a cluster with basically the same fix when migrating an IOP 
4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
that's to set StackFeature boolean in case this code gets merged back to trunk 
later on. 

If the code only stays in this branch, the StackFeature boolean change can be 
omitted.


Thanks,

Di Li