Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-21 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/#review183359
---


Ship it!




Ship It!

- Balázs Bence Sári


On Aug. 17, 2017, 9:40 p.m., Chandana Mirashi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61043/
> ---
> 
> (Updated Aug. 17, 2017, 9:40 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21325
> https://issues.apache.org/jira/browse/AMBARI-21325
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add quicklink support through Knox.
> Changes:
> 1. Add new json properties knox_url, knox_path, supports_knox
>a. knox_url: template to be used for urls that are proxied through Knox 
>b. knox_path: Knox gateway path that will be added to the proxy url.
>c. supports_knox: whether link will be redirected through Knox
> 2. Add above json properties to quicklinks.json
> 3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
> SPARKUI services to Knox topology template.
> 4. Automate protocol and port added to Knox topology file. Based on whether 
> SSL is enabled for the services listed above, the port and protocol in 
> params_linux.py will be updated.
> 5. Update quick_view_link_view.js so that when Knox is installed and 
> support_knox is true, quicklink url follows knox url template specified in 
> the quicklinks.json for the service/component.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  1d2e712 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  4558069 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
>  5568122 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
>  a4216e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
>  43cf641 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
>  36f71b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
>  0aca8e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
>  df4c1b4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
>   ambari-web/app/views/common/quick_view_link_view.js 5888acb 
> 
> 
> Diff: https://reviews.apache.org/r/61043/diff/3/
> 
> 
> Testing
> ---
> 
> 1. ambari-server: mvn test
> 2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
> 3. ambari-web: mvn test
>  21213 passing (54s)
>  128 pending
> 
> 
> Thanks,
> 
> Chandana Mirashi
> 
>

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-17 Thread Chandana Mirashi 
Done. Thanks Sid. 
 
Regards,
Chandana Mirashi
IBM Silicon Valley Laboratory
Phone: (408)463-2826 T/L: 543-2826




From:   Sid Wagle <swa...@hortonworks.com>
To: Sid Wagle <swa...@hortonworks.com>, Balázs Bence Sári 
<bs...@hortonworks.com>, Juanjo Marron <jmar...@us.ibm.com>
Cc: Chandana Mirashi <cmir...@us.ibm.com>, Alejandro Fernandez 
<afernan...@hortonworks.com>, Ambari <reviews@ambari.apache.org>
Date:   08/17/2017 02:45 PM
Subject:    Re: Review Request 61043: AMBARI-21325: Quicklink support 
through Knox
Sent by:Sid Wagle <nore...@reviews.apache.org>



This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/61043/ 

On July 28th, 2017, 2:41 p.m. UTC, Balázs Bence Sári wrote:

ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
(Diff revision 2) 


67
  private String supportsKnox;
Why not boolean?
On August 4th, 2017, 4:53 p.m. UTC, Chandana Mirashi wrote:
I followed similar property (require_username)) that was already added to 
Link.java. Ref AMBARI-11268.
Hi Chandana, Could you please mark the issues already fixed as Fixed and 
something like this as Dropped? Makes it easy for the next review.
Reviewer can reopen the issue if there is disagreement. Thanks.

- Sid

On August 17th, 2017, 9:40 p.m. UTC, Chandana Mirashi wrote:

Review request for Ambari, Balázs Bence Sári, Juanjo Marron, and Sid 
Wagle.
By Chandana Mirashi.
Updated Aug. 17, 2017, 9:40 p.m.
Bugs: AMBARI-21325 
Repository: ambari 
Description 

Add quicklink support through Knox.
Changes:
1. Add new json properties knox_url, knox_path, supports_knox
   a. knox_url: template to be used for urls that are proxied through Knox 

   b. knox_path: Knox gateway path that will be added to the proxy url.
   c. supports_knox: whether link will be redirected through Knox
2. Add above json properties to quicklinks.json
3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
SPARKUI services to Knox topology template.
4. Automate protocol and port added to Knox topology file. Based on 
whether SSL is enabled for the services listed above, the port and 
protocol in params_linux.py will be updated.
5. Update quick_view_link_view.js so that when Knox is installed and 
support_knox is true, quicklink url follows knox url template specified in 
the quicklinks.json for the service/component.
Testing 



1.  ambari-server: mvn test


2.  mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py 
test


3.  ambari-web: mvn test
 21213 passing (54s)
 128 pending


Diffs 
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
(1d2e712)
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 
(4558069)
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
 
(5568122)
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
 
(a4216e3)
ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
 
(43cf641)
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
 
(36f71b5)
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
 
(0aca8e3)
ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
 
(df4c1b4)
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/quicklinks/quicklinks.json
 
(PRE-CREATION)
ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 
(1805c3b)
ambari-web/app/views/common/quick_view_link_view.js (5888acb)
View Diff

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-17 Thread Sid Wagle 


> On July 28, 2017, 2:41 p.m., Balázs Bence Sári wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
> > Lines 67 (patched)
> > 
> >
> > Why not boolean?
> 
> Chandana Mirashi wrote:
> I followed similar property (require_username)) that was already added to 
> Link.java. Ref AMBARI-11268.

Hi Chandana, Could you please mark the issues already fixed as Fixed and 
something like this as Dropped? Makes it easy for the next review.
Reviewer can reopen the issue if there is disagreement. Thanks.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/#review181664
---


On Aug. 17, 2017, 9:40 p.m., Chandana Mirashi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61043/
> ---
> 
> (Updated Aug. 17, 2017, 9:40 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21325
> https://issues.apache.org/jira/browse/AMBARI-21325
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add quicklink support through Knox.
> Changes:
> 1. Add new json properties knox_url, knox_path, supports_knox
>a. knox_url: template to be used for urls that are proxied through Knox 
>b. knox_path: Knox gateway path that will be added to the proxy url.
>c. supports_knox: whether link will be redirected through Knox
> 2. Add above json properties to quicklinks.json
> 3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
> SPARKUI services to Knox topology template.
> 4. Automate protocol and port added to Knox topology file. Based on whether 
> SSL is enabled for the services listed above, the port and protocol in 
> params_linux.py will be updated.
> 5. Update quick_view_link_view.js so that when Knox is installed and 
> support_knox is true, quicklink url follows knox url template specified in 
> the quicklinks.json for the service/component.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  1d2e712 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  4558069 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
>  5568122 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
>  a4216e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
>  43cf641 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
>  36f71b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
>  0aca8e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
>  df4c1b4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
>   ambari-web/app/views/common/quick_view_link_view.js 5888acb 
> 
> 
> Diff: https://reviews.apache.org/r/61043/diff/3/
> 
> 
> Testing
> ---
> 
> 1. ambari-server: mvn test
> 2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
> 3. ambari-web: mvn test
>  21213 passing (54s)
>  128 pending
> 
> 
> Thanks,
> 
> Chandana Mirashi
> 
>

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-17 Thread Chandana Mirashi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/
---

(Updated Aug. 17, 2017, 9:40 p.m.)


Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.


Changes
---

Updated patch with Aug 15th build corresponding to new patch submitted to 
AMBARI-21325.


Bugs: AMBARI-21325
https://issues.apache.org/jira/browse/AMBARI-21325


Repository: ambari


Description
---

Add quicklink support through Knox.
Changes:
1. Add new json properties knox_url, knox_path, supports_knox
   a. knox_url: template to be used for urls that are proxied through Knox 
   b. knox_path: Knox gateway path that will be added to the proxy url.
   c. supports_knox: whether link will be redirected through Knox
2. Add above json properties to quicklinks.json
3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
SPARKUI services to Knox topology template.
4. Automate protocol and port added to Knox topology file. Based on whether SSL 
is enabled for the services listed above, the port and protocol in 
params_linux.py will be updated.
5. Update quick_view_link_view.js so that when Knox is installed and 
support_knox is true, quicklink url follows knox url template specified in the 
quicklinks.json for the service/component.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
1d2e712 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 4558069 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
 5568122 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
 a4216e3 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
 43cf641 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
 36f71b5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
 0aca8e3 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
 df4c1b4 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/quicklinks/quicklinks.json
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
  ambari-web/app/views/common/quick_view_link_view.js 5888acb 


Diff: https://reviews.apache.org/r/61043/diff/3/

Changes: https://reviews.apache.org/r/61043/diff/2-3/


Testing
---

1. ambari-server: mvn test
2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
3. ambari-web: mvn test
 21213 passing (54s)
 128 pending


Thanks,

Chandana Mirashi

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-04 Thread Chandana Mirashi 


> On July 28, 2017, 2:41 p.m., Balázs Bence Sári wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
> > Lines 67 (patched)
> > 
> >
> > Why not boolean?

I followed similar property (require_username)) that was already added to 
Link.java. Ref AMBARI-11268.


- Chandana


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/#review181664
---


On July 25, 2017, 12:53 a.m., Chandana Mirashi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61043/
> ---
> 
> (Updated July 25, 2017, 12:53 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21325
> https://issues.apache.org/jira/browse/AMBARI-21325
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add quicklink support through Knox.
> Changes:
> 1. Add new json properties knox_url, knox_path, supports_knox
>a. knox_url: template to be used for urls that are proxied through Knox 
>b. knox_path: Knox gateway path that will be added to the proxy url.
>c. supports_knox: whether link will be redirected through Knox
> 2. Add above json properties to quicklinks.json
> 3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
> SPARKUI services to Knox topology template.
> 4. Automate protocol and port added to Knox topology file. Based on whether 
> SSL is enabled for the services listed above, the port and protocol in 
> params_linux.py will be updated.
> 5. Update quick_view_link_view.js so that when Knox is installed and 
> support_knox is true, quicklink url follows knox url template specified in 
> the quicklinks.json for the service/component.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  1d2e712 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  4558069 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
>  5568122 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
>  a4216e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
>  81e7cbe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
>  36f71b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
>  0aca8e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
>  df4c1b4 
>   ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
>   ambari-web/app/views/common/quick_view_link_view.js e39f230 
> 
> 
> Diff: https://reviews.apache.org/r/61043/diff/2/
> 
> 
> Testing
> ---
> 
> 1. ambari-server: mvn test
> 2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
> 3. ambari-web: mvn test
>  21213 passing (54s)
>  128 pending
> 
> 
> Thanks,
> 
> Chandana Mirashi
> 
>

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-07-28 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/#review181664
---




ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
Lines 67 (patched)


Why not boolean?


- Balázs Bence Sári


On July 25, 2017, 12:53 a.m., Chandana Mirashi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61043/
> ---
> 
> (Updated July 25, 2017, 12:53 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21325
> https://issues.apache.org/jira/browse/AMBARI-21325
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add quicklink support through Knox.
> Changes:
> 1. Add new json properties knox_url, knox_path, supports_knox
>a. knox_url: template to be used for urls that are proxied through Knox 
>b. knox_path: Knox gateway path that will be added to the proxy url.
>c. supports_knox: whether link will be redirected through Knox
> 2. Add above json properties to quicklinks.json
> 3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
> SPARKUI services to Knox topology template.
> 4. Automate protocol and port added to Knox topology file. Based on whether 
> SSL is enabled for the services listed above, the port and protocol in 
> params_linux.py will be updated.
> 5. Update quick_view_link_view.js so that when Knox is installed and 
> support_knox is true, quicklink url follows knox url template specified in 
> the quicklinks.json for the service/component.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  1d2e712 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  4558069 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
>  5568122 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
>  a4216e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
>  81e7cbe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
>  36f71b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
>  0aca8e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
>  df4c1b4 
>   ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
>   ambari-web/app/views/common/quick_view_link_view.js e39f230 
> 
> 
> Diff: https://reviews.apache.org/r/61043/diff/2/
> 
> 
> Testing
> ---
> 
> 1. ambari-server: mvn test
> 2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
> 3. ambari-web: mvn test
>  21213 passing (54s)
>  128 pending
> 
> 
> Thanks,
> 
> Chandana Mirashi
> 
>

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-07-24 Thread Chandana Mirashi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/
---

(Updated July 25, 2017, 12:53 a.m.)


Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.


Changes
---

Updated Patch with requested changes.


Bugs: AMBARI-21325
https://issues.apache.org/jira/browse/AMBARI-21325


Repository: ambari


Description
---

Add quicklink support through Knox.
Changes:
1. Add new json properties knox_url, knox_path, supports_knox
   a. knox_url: template to be used for urls that are proxied through Knox 
   b. knox_path: Knox gateway path that will be added to the proxy url.
   c. supports_knox: whether link will be redirected through Knox
2. Add above json properties to quicklinks.json
3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
SPARKUI services to Knox topology template.
4. Automate protocol and port added to Knox topology file. Based on whether SSL 
is enabled for the services listed above, the port and protocol in 
params_linux.py will be updated.
5. Update quick_view_link_view.js so that when Knox is installed and 
support_knox is true, quicklink url follows knox url template specified in the 
quicklinks.json for the service/component.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
1d2e712 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 4558069 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
 5568122 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
 a4216e3 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
 81e7cbe 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
 36f71b5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
 0aca8e3 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
 df4c1b4 
  ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
  ambari-web/app/views/common/quick_view_link_view.js e39f230 


Diff: https://reviews.apache.org/r/61043/diff/2/

Changes: https://reviews.apache.org/r/61043/diff/1-2/


Testing
---

1. ambari-server: mvn test
2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
3. ambari-web: mvn test
 21213 passing (54s)
 128 pending


Thanks,

Chandana Mirashi

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-07-24 Thread Juanjo Marron 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/#review181235
---


Ship it!




It looks good to me. It is similar to the change set included as part of IOP 
supporting QuickLinks through Knox.
Can we make sure all the tests run by HadoopQA pass, even if they are not 
related to this change?

- Juanjo  Marron


On July 21, 2017, 6:57 p.m., Chandana Mirashi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61043/
> ---
> 
> (Updated July 21, 2017, 6:57 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21325
> https://issues.apache.org/jira/browse/AMBARI-21325
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add quicklink support through Knox.
> Changes:
> 1. Add new json properties knox_url, knox_path, supports_knox
>a. knox_url: template to be used for urls that are proxied through Knox 
>b. knox_path: Knox gateway path that will be added to the proxy url.
>c. supports_knox: whether link will be redirected through Knox
> 2. Add above json properties to quicklinks.json
> 3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
> SPARKUI services to Knox topology template.
> 4. Automate protocol and port added to Knox topology file. Based on whether 
> SSL is enabled for the services listed above, the port and protocol in 
> params_linux.py will be updated.
> 5. Update quick_view_link_view.js so that when Knox is installed and 
> support_knox is true, quicklink url follows knox url template specified in 
> the quicklinks.json for the service/component.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  1d2e712 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  4558069 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
>  5568122 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
>  a4216e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
>  81e7cbe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
>  36f71b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
>  0aca8e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
>  df4c1b4 
>   ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
>   ambari-web/app/views/common/quick_view_link_view.js e39f230 
> 
> 
> Diff: https://reviews.apache.org/r/61043/diff/1/
> 
> 
> Testing
> ---
> 
> 1. ambari-server: mvn test
> 2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
> 3. ambari-web: mvn test
>  21213 passing (54s)
>  128 pending
> 
> 
> Thanks,
> 
> Chandana Mirashi
> 
>

Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-07-21 Thread Chandana Mirashi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/
---

Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.


Bugs: AMBARI-21325
https://issues.apache.org/jira/browse/AMBARI-21325


Repository: ambari


Description
---

Add quicklink support through Knox.
Changes:
1. Add new json properties knox_url, knox_path, supports_knox
   a. knox_url: template to be used for urls that are proxied through Knox 
   b. knox_path: Knox gateway path that will be added to the proxy url.
   c. supports_knox: whether link will be redirected through Knox
2. Add above json properties to quicklinks.json
3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
SPARKUI services to Knox topology template.
4. Automate protocol and port added to Knox topology file. Based on whether SSL 
is enabled for the services listed above, the port and protocol in 
params_linux.py will be updated.
5. Update quick_view_link_view.js so that when Knox is installed and 
support_knox is true, quicklink url follows knox url template specified in the 
quicklinks.json for the service/component.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
1d2e712 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 4558069 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
 5568122 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
 a4216e3 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
 81e7cbe 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
 36f71b5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
 0aca8e3 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
 df4c1b4 
  ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
  ambari-web/app/views/common/quick_view_link_view.js e39f230 


Diff: https://reviews.apache.org/r/61043/diff/1/


Testing
---

1. ambari-server: mvn test
2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
3. ambari-web: mvn test
 21213 passing (54s)
 128 pending


Thanks,

Chandana Mirashi