Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

2017-08-29 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61917/#review184091
---


Ship it!




Ship It!

- Jayush Luniya


On Aug. 29, 2017, 7:37 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61917/
> ---
> 
> (Updated Aug. 29, 2017, 7:37 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-21824
> https://issues.apache.org/jira/browse/AMBARI-21824
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ServiceGroup was a new sub-resource added for cluster in AMBARI-21594.
> 
> This Task involves :
> - moving *Services* which was earlier a sub-resource of *Cluster* under 
> *ServiceGroup* now, and
> -  using *Servicegroup* while doing Creation, Update and retrieval of 
> *HostComponents* and *ServiceComponents*.
> -  UI changes which includes creating a *default ServiceGroup named 'core'*, 
> and all services created goes under it. Further, making UI calls SG aware, 
> while making a call.
> 
> The new API calls will be the following:
> 
> 
> ---
> **==**
> **Service:**
> **==**
> 
> New API calls: 
> 
> http://:/api/v1/clusters//*servicegroups/*/services
> http://:/api/v1/clusters//*servicegroups/*/services/
> 
> **POST**
> 
> Eg: 
> http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services
> 
> Request
> 
> {code}
> {
>   "ServiceInfo" : {
> "cluster_name": "c1",
> "service_group_name": "core",
> "service_name": "RANGER",
> "service_display_name": "RANGER"
>   }
> }
> {code}
> 
> Response
> 
> {code}
> {
>   "resources" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER";,
>   "ServiceInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "credential_store_enabled" : false,
> "credential_store_supported" : false,
> "desired_repository_version_id" : "2.6.1.0-129",
> "desired_stack" : "HDP-2.6",
> "maintenance_state" : "OFF",
> "repository_state" : "NOT_REQUIRED",
> "service_display_name" : "RANGER",
> "service_group_id" : 2,
> "service_group_name" : "core",
> "service_id" : 4,
> "service_name" : "RANGER",
> "state" : "INIT"
>   }
> }
>   ]
> }
> {code}
> 
> 
> **GET**
> 
> Eg: 
> http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services
> 
> Request
> 
> {code}
> {code}
> 
> Response
> 
> {code}
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services";,
>   "items" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER";,
>   "ServiceInfo" : {
> "cluster_name" : "c1",
> "service_display_name" : "RANGER",
> "service_group_name" : "core"
>   }
> }
>   ]
> }
> {code}
> 
> Eg: 
> http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER
> 
> Request
> 
> {code}
> {code}
> 
> Response
> 
> {code}
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER";,
>   "ServiceInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "credential_store_enabled" : "false",
> "credential_store_supported" : "false",
> "desired_repository_version_id" : 1,
> "desired_stack" : {
>   "stackName" : "HDP",
>   "stackVersion" : "2.6",
>   "stackId" : "HDP-2.6"
> },
> "maintenance_state" : "OFF",
> "repository_state" : "NOT_REQUIRED",
> "service_display_name" : "RANGER",
> "service_group_id" : 2,
> "service_group_name" : "core",
> "service_id" : 4,
> "service_name" : "RANGER",
> "state" : "UNKNOWN"
>   },
>   "alerts_summary" : {
> "CRITICAL" : 0,
> "MAINTENANCE" : 0,
> "OK" : 0,
> "UNKNOWN" : 0,
> "WARNING" : 0
>   },
>   "alerts" : [ ],
>   "components" : [ ],
>   "artifacts" : [ ]
> }
> {code}
> 
> 
> **DELETE**
> 
> Eg: 
> http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER
> Request
> 
> {code}
> {code}
> 
> Response
> {code}
> {
>   "deleteResult" : [
> {
>   "deleted" : {
> "key" : "service_name: RANGER"
>   }
> }
>   ]
> }
> {code}
> 
> 
> -
> 
> 
> ****
> **Service Compon

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

2017-08-29 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61917/
---

(Updated Aug. 29, 2017, 7:37 p.m.)


Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.


Changes
---

Updated Description.


Bugs: AMBARI-21824
https://issues.apache.org/jira/browse/AMBARI-21824


Repository: ambari


Description (updated)
---

ServiceGroup was a new sub-resource added for cluster in AMBARI-21594.

This Task involves :
- moving *Services* which was earlier a sub-resource of *Cluster* under 
*ServiceGroup* now, and
-  using *Servicegroup* while doing Creation, Update and retrieval of 
*HostComponents* and *ServiceComponents*.
-  UI changes which includes creating a *default ServiceGroup named 'core'*, 
and all services created goes under it. Further, making UI calls SG aware, 
while making a call.

The new API calls will be the following:


---
**==**
**Service:**
**==**

New API calls: 

http://:/api/v1/clusters//*servicegroups/*/services
http://:/api/v1/clusters//*servicegroups/*/services/

**POST**

Eg: 
http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services

Request

{code}
{
  "ServiceInfo" : {
"cluster_name": "c1",
"service_group_name": "core",
"service_name": "RANGER",
"service_display_name": "RANGER"
  }
}
{code}

Response

{code}
{
  "resources" : [
{
  "href" : 
"http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER";,
  "ServiceInfo" : {
"cluster_id" : 2,
"cluster_name" : "c1",
"credential_store_enabled" : false,
"credential_store_supported" : false,
"desired_repository_version_id" : "2.6.1.0-129",
"desired_stack" : "HDP-2.6",
"maintenance_state" : "OFF",
"repository_state" : "NOT_REQUIRED",
"service_display_name" : "RANGER",
"service_group_id" : 2,
"service_group_name" : "core",
"service_id" : 4,
"service_name" : "RANGER",
"state" : "INIT"
  }
}
  ]
}
{code}


**GET**

Eg: 
http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services

Request

{code}
{code}

Response

{code}
{
  "href" : 
"http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services";,
  "items" : [
{
  "href" : 
"http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER";,
  "ServiceInfo" : {
"cluster_name" : "c1",
"service_display_name" : "RANGER",
"service_group_name" : "core"
  }
}
  ]
}
{code}

Eg: 
http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER

Request

{code}
{code}

Response

{code}
{
  "href" : 
"http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER";,
  "ServiceInfo" : {
"cluster_id" : 2,
"cluster_name" : "c1",
"credential_store_enabled" : "false",
"credential_store_supported" : "false",
"desired_repository_version_id" : 1,
"desired_stack" : {
  "stackName" : "HDP",
  "stackVersion" : "2.6",
  "stackId" : "HDP-2.6"
},
"maintenance_state" : "OFF",
"repository_state" : "NOT_REQUIRED",
"service_display_name" : "RANGER",
"service_group_id" : 2,
"service_group_name" : "core",
"service_id" : 4,
"service_name" : "RANGER",
"state" : "UNKNOWN"
  },
  "alerts_summary" : {
"CRITICAL" : 0,
"MAINTENANCE" : 0,
"OK" : 0,
"UNKNOWN" : 0,
"WARNING" : 0
  },
  "alerts" : [ ],
  "components" : [ ],
  "artifacts" : [ ]
}
{code}


**DELETE**

Eg: 
http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER
Request

{code}
{code}

Response
{code}
{
  "deleteResult" : [
{
  "deleted" : {
"key" : "service_name: RANGER"
  }
}
  ]
}
{code}


-


****
**Service Component**
****

New API calls: 

http://:/api/v1/clusters//*servicegroups/*/services//components/
http://:/api/v1/clusters//*servicegroups/*/services//components/ZOOKEEPER_SERVER


**POST**

Eg: 
http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER/components/
Request

{code}
{
  "ServiceComponentInfo" : {
"component_name" : "RANGER_USERSYNC"
}
}   
{code}

Response

{code}
{
  "resources" : [
{
  "href" : 
"http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER/components/RANGER_USERSYNC/";,
  "ServiceComponentInfo" : {
"category" : nul

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

2017-08-29 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61917/
---

(Updated Aug. 29, 2017, 7:31 p.m.)


Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.


Changes
---

Renamed fn. 'findServiceName()' to appropriate name 'findServiceName()' as per 
Jayush's comment.


Bugs: AMBARI-21824
https://issues.apache.org/jira/browse/AMBARI-21824


Repository: ambari


Description
---

ServiceGroup was a new sub-resource added for cluster in AMBARI-21594.

This change involves :
- moving **Services** which was earlier a sub-resource of **Cluster** under 
**ServiceGroup** now, and
- using **Servicegroup** while doing Creation, Update and retrieval of 
**HostComponents** and **ServiceComponents**.

The new API calls will be the following:


-
**Service:**

http://:/api/v1/clusters//**servicegroups/**/services
http://:/api/v1/clusters//**servicegroups/**/services/

**ServiceComponent:**

http://:/api/v1/clusters//**servicegroups/**/services//components/
http://:/api/v1/clusters//**servicegroups/**/services//components/ZOOKEEPER_SERVER

-

**HostComponent:** (API remains same, but has notion of servicegroup in Ambari 
backend)

http://:/api/v1/clusters/c1/hosts//host_components/
http://:/api/v1/clusters/c1/hosts//host_components/


- The change also includes UI changes as well, which create a **default 
ServiceGroup named 'core'**, and all services created goes under it.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/ServiceComponentNotFoundException.java
 8f25cb1 
  
ambari-server/src/main/java/org/apache/ambari/server/ServiceNotFoundException.java
 6b18c09 
  
ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java 
03990a2 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 d83a5d1 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 2690008 
  ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
e8c0b05 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
 24c2810 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentResourceDefinition.java
 2a98a9c 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
 f686851 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 80bd58d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 c38489d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
 b489a15 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
 aa1270a 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
 6ab2704 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
 988fc78 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 b440c93 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
 543df26 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 6b03249 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 663d857 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 ca84826 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java
 3f75971 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 e09f433 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
 94b5985 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java
 7b75e06 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentRequest.java
 3a65ff8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java
 9bd3e44 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java
 3b3c940 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java
 ed1832a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

2017-08-29 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61917/
---

(Updated Aug. 29, 2017, 6:28 p.m.)


Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.


Changes
---

Updated the following:

Backend:
- For Service, HostComponent and Component, added code for response block on 
POST and DELETE.
- Commented code which checks for passed in SG and retrieved SG for Service in 
ServiceResourceProvider with TODO, to be opened when we don't want to support 
queries for servies and components at cluster level.UI as of now makes that 
calls for optimizations purposes.

Frontend:
- Updated UI code to use default Servicegroup while making POST call for 
Service and Components.


Bugs: AMBARI-21824
https://issues.apache.org/jira/browse/AMBARI-21824


Repository: ambari


Description
---

ServiceGroup was a new sub-resource added for cluster in AMBARI-21594.

This change involves :
- moving **Services** which was earlier a sub-resource of **Cluster** under 
**ServiceGroup** now, and
- using **Servicegroup** while doing Creation, Update and retrieval of 
**HostComponents** and **ServiceComponents**.

The new API calls will be the following:


-
**Service:**

http://:/api/v1/clusters//**servicegroups/**/services
http://:/api/v1/clusters//**servicegroups/**/services/

**ServiceComponent:**

http://:/api/v1/clusters//**servicegroups/**/services//components/
http://:/api/v1/clusters//**servicegroups/**/services//components/ZOOKEEPER_SERVER

-

**HostComponent:** (API remains same, but has notion of servicegroup in Ambari 
backend)

http://:/api/v1/clusters/c1/hosts//host_components/
http://:/api/v1/clusters/c1/hosts//host_components/


- The change also includes UI changes as well, which create a **default 
ServiceGroup named 'core'**, and all services created goes under it.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/ServiceComponentNotFoundException.java
 8f25cb1 
  
ambari-server/src/main/java/org/apache/ambari/server/ServiceNotFoundException.java
 6b18c09 
  
ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java 
03990a2 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 d83a5d1 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 2690008 
  ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
e8c0b05 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
 24c2810 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentResourceDefinition.java
 2a98a9c 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
 f686851 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 80bd58d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 c38489d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
 b489a15 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
 aa1270a 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
 6ab2704 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
 988fc78 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 b440c93 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
 543df26 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 6b03249 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 663d857 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 ca84826 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java
 3f75971 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 e09f433 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
 94b5985 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java
 7b75e06 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentRequest.java
 3a65ff8

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

2017-08-29 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61917/#review184047
---


Ship it!




Ship It!

- Jayush Luniya


On Aug. 28, 2017, 9:08 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61917/
> ---
> 
> (Updated Aug. 28, 2017, 9:08 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-21824
> https://issues.apache.org/jira/browse/AMBARI-21824
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ServiceGroup was a new sub-resource added for cluster in AMBARI-21594.
> 
> This change involves :
> - moving **Services** which was earlier a sub-resource of **Cluster** under 
> **ServiceGroup** now, and
> - using **Servicegroup** while doing Creation, Update and retrieval of 
> **HostComponents** and **ServiceComponents**.
> 
> The new API calls will be the following:
> 
> 
> -
> **Service:**
> 
> http://:/api/v1/clusters//**servicegroups/**/services
> http://:/api/v1/clusters//**servicegroups/**/services/
> 
> **ServiceComponent:**
> 
> http://:/api/v1/clusters//**servicegroups/**/services//components/
> http://:/api/v1/clusters//**servicegroups/**/services//components/ZOOKEEPER_SERVER
> 
> -
> 
> **HostComponent:** (API remains same, but has notion of servicegroup in 
> Ambari backend)
> 
> http://:/api/v1/clusters/c1/hosts//host_components/
> http://:/api/v1/clusters/c1/hosts//host_components/
> 
> 
> - The change also includes UI changes as well, which create a **default 
> ServiceGroup named 'core'**, and all services created goes under it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ServiceComponentNotFoundException.java
>  8f25cb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ServiceNotFoundException.java
>  6b18c09 
>   
> ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java
>  03990a2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  d83a5d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  2690008 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
> e8c0b05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  24c2810 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentResourceDefinition.java
>  2a98a9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
>  f686851 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  80bd58d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  c38489d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
>  b489a15 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
>  aa1270a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  6ab2704 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  988fc78 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  b440c93 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
>  543df26 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  6b03249 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  663d857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  ca84826 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java
>  3f75971 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  e09f433 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
>  94b5985 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java
>  7b75e06 
>   
> ambari-server/src/main/java/org/apache/amba

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

2017-08-29 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61917/#review184003
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Line 3555 (original), 3559 (patched)


Rename to findService?


- Jayush Luniya


On Aug. 28, 2017, 9:08 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61917/
> ---
> 
> (Updated Aug. 28, 2017, 9:08 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-21824
> https://issues.apache.org/jira/browse/AMBARI-21824
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ServiceGroup was a new sub-resource added for cluster in AMBARI-21594.
> 
> This change involves :
> - moving **Services** which was earlier a sub-resource of **Cluster** under 
> **ServiceGroup** now, and
> - using **Servicegroup** while doing Creation, Update and retrieval of 
> **HostComponents** and **ServiceComponents**.
> 
> The new API calls will be the following:
> 
> 
> -
> **Service:**
> 
> http://:/api/v1/clusters//**servicegroups/**/services
> http://:/api/v1/clusters//**servicegroups/**/services/
> 
> **ServiceComponent:**
> 
> http://:/api/v1/clusters//**servicegroups/**/services//components/
> http://:/api/v1/clusters//**servicegroups/**/services//components/ZOOKEEPER_SERVER
> 
> -
> 
> **HostComponent:** (API remains same, but has notion of servicegroup in 
> Ambari backend)
> 
> http://:/api/v1/clusters/c1/hosts//host_components/
> http://:/api/v1/clusters/c1/hosts//host_components/
> 
> 
> - The change also includes UI changes as well, which create a **default 
> ServiceGroup named 'core'**, and all services created goes under it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ServiceComponentNotFoundException.java
>  8f25cb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ServiceNotFoundException.java
>  6b18c09 
>   
> ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java
>  03990a2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  d83a5d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  2690008 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
> e8c0b05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  24c2810 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentResourceDefinition.java
>  2a98a9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
>  f686851 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  80bd58d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  c38489d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
>  b489a15 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
>  aa1270a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  6ab2704 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  988fc78 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  b440c93 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
>  543df26 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  6b03249 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  663d857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  ca84826 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java
>  3f75971 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  e09f433 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceCompone