Re: Review Request 64173: AMBARI-22550. Service install/start failure due to wrong version directory

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64173/
---

(Updated Nov. 29, 2017, 9:21 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.


Changes
---

doc


Bugs: AMBARI-22550
https://issues.apache.org/jira/browse/AMBARI-22550


Repository: ambari


Description
---

Only send `/commandParams/version` if it is resolved: using unresolved version 
eg. `2.6.3.0` only causes problems.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 212363b85f1ef4f4b3b91f0ddb2fe91cd897d5dc 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
 7630c553c0e55ffa314f02bc9c68337d502a93be 


Diff: https://reviews.apache.org/r/64173/diff/2/

Changes: https://reviews.apache.org/r/64173/diff/1-2/


Testing
---

* Tested cluster creation: verified that resolved version (eg. 2.6.3.0-235) is 
sent in "start" commands (and version is absent in "install" commands), and 
that WebHCat server is started OK.
* Tested service auto-restart for regression per steps in 
[AMBARI-22025](https://issues.apache.org/jira/browse/AMBARI-22025).
* Added unit test.  `Tests run: 4931, Failures: 0, Errors: 0, Skipped: 34`


Thanks,

Attila Doroszlai

Re: Review Request 64173: AMBARI-22550. Service install/start failure due to wrong version directory

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64173/#review192166
---


Ship it!




Ship It!

- Nate Cole


On Nov. 29, 2017, 3 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64173/
> ---
> 
> (Updated Nov. 29, 2017, 3 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22550
> https://issues.apache.org/jira/browse/AMBARI-22550
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Only send `/commandParams/version` if it is resolved: using unresolved 
> version eg. `2.6.3.0` only causes problems.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  212363b85f1ef4f4b3b91f0ddb2fe91cd897d5dc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
>  7630c553c0e55ffa314f02bc9c68337d502a93be 
> 
> 
> Diff: https://reviews.apache.org/r/64173/diff/1/
> 
> 
> Testing
> ---
> 
> * Tested cluster creation: verified that resolved version (eg. 2.6.3.0-235) 
> is sent in "start" commands (and version is absent in "install" commands), 
> and that WebHCat server is started OK.
> * Tested service auto-restart for regression per steps in 
> [AMBARI-22025](https://issues.apache.org/jira/browse/AMBARI-22025).
> * Added unit test.  `Tests run: 4931, Failures: 0, Errors: 0, Skipped: 34`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 64173: AMBARI-22550. Service install/start failure due to wrong version directory

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64173/#review192164
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
Lines 303-304 (original), 303-304 (patched)


Adjust documention to indicate why !resolved() is necessary.


- Jonathan Hurley


On Nov. 29, 2017, 3 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64173/
> ---
> 
> (Updated Nov. 29, 2017, 3 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22550
> https://issues.apache.org/jira/browse/AMBARI-22550
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Only send `/commandParams/version` if it is resolved: using unresolved 
> version eg. `2.6.3.0` only causes problems.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  212363b85f1ef4f4b3b91f0ddb2fe91cd897d5dc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
>  7630c553c0e55ffa314f02bc9c68337d502a93be 
> 
> 
> Diff: https://reviews.apache.org/r/64173/diff/1/
> 
> 
> Testing
> ---
> 
> * Tested cluster creation: verified that resolved version (eg. 2.6.3.0-235) 
> is sent in "start" commands (and version is absent in "install" commands), 
> and that WebHCat server is started OK.
> * Tested service auto-restart for regression per steps in 
> [AMBARI-22025](https://issues.apache.org/jira/browse/AMBARI-22025).
> * Added unit test.  `Tests run: 4931, Failures: 0, Errors: 0, Skipped: 34`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 64173: AMBARI-22550. Service install/start failure due to wrong version directory

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64173/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.


Bugs: AMBARI-22550
https://issues.apache.org/jira/browse/AMBARI-22550


Repository: ambari


Description
---

Only send `/commandParams/version` if it is resolved: using unresolved version 
eg. `2.6.3.0` only causes problems.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 212363b85f1ef4f4b3b91f0ddb2fe91cd897d5dc 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
 7630c553c0e55ffa314f02bc9c68337d502a93be 


Diff: https://reviews.apache.org/r/64173/diff/1/


Testing
---

* Tested cluster creation: verified that resolved version (eg. 2.6.3.0-235) is 
sent in "start" commands (and version is absent in "install" commands), and 
that WebHCat server is started OK.
* Tested service auto-restart for regression per steps in 
[AMBARI-22025](https://issues.apache.org/jira/browse/AMBARI-22025).
* Added unit test.  `Tests run: 4931, Failures: 0, Errors: 0, Skipped: 34`


Thanks,

Attila Doroszlai