Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192874 --- Ship it! Ship It! - Sid Wagle On Dec. 5, 2017, 11:04 a.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Dec. 5, 2017, 11:04 a.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > f2218e5e81 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py > 10a83d6c23 > ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json > 29cbddca55 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/2/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192843 --- The main difference between this patch and previous is in repository_util.py. Also some unit test fixes are added. ... def create_repo_files(template, command_repository): """ DEPRECATED. Is present for usage by old mpacks. Please use Script.repository_util.create_repo_files() instead. """ from resource_management.libraries.script import Script return RepositoryUtil(Script.get_config(), set()).create_repo_files() ... - Andrew Onischuk On Dec. 5, 2017, 11:04 a.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Dec. 5, 2017, 11:04 a.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > f2218e5e81 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py > 10a83d6c23 > ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json > 29cbddca55 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/2/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/ --- (Updated Dec. 5, 2017, 11:04 a.m.) Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle. Bugs: AMBARI-22561 https://issues.apache.org/jira/browse/AMBARI-22561 Repository: ambari Description --- * User denies the GPL license agreement, UI will still issue PUT call to create the repo * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo because it will break yum in local repo world. * Then the user accepts the license by running ambari-server setup * The repo file does not get updated on existing hosts * We need to push the HDP-GPL repo to the repo files on existing hosts only when the license is accepted Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py 68ee607b9b ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py f1c8ef1b04 ambari-common/src/main/python/resource_management/libraries/script/script.py ccb8a547f4 ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java e207ac5289 ambari-server/src/main/resources/custom_actions/scripts/install_packages.py f2218e5e81 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py 82e57aa4f4 ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 10a83d6c23 ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 29cbddca55 ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe Diff: https://reviews.apache.org/r/64209/diff/2/ Changes: https://reviews.apache.org/r/64209/diff/1-2/ Testing --- mvn clean test Thanks, Andrew Onischuk
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? > > Sid Wagle wrote: > We would still need to make sure existing hosts get the changes if user > denies license during setup and then accepts it. Present behavior is that we > do not update the repo for existing hosts. Thereby, I was ok with limiting > the changes to the agent vs server and agent. > > Nate Cole wrote: > The command repository is being sent down and processed on every command. > > Sid Wagle wrote: > Fair enough, also what about accept and then deny. Ambari should reflect > presence or absence of the repo info based on the flag. Do you think doing > this on the server would be cleaner? IMO, this is pretty custom repo handling > in any case, we do not have a repo-tag -> license-tag mapping anywhere so > wouldn't it be equally ugly? > > Sid Wagle wrote: > By license-tag I meant some lookup to figure out whether license was > accepted. > > Andrew Onischuk wrote: > IMO this looks pretty much the same whether the check is on server or > agent. However it may take some time while I re-implement this to server if > that's the approach you prefer. @Sid @Nate If you decide we need this, we can > create re-factoring jira (not for 2.6.1) and do this. > > Nate Cole wrote: > The whole point of CommandRepository was to send down to the agent ONLY > what is necessary to create the repo. Spreading logic around makes it > difficult to troubleshoot. It should either ALL be in java or ALL be in > python. > > Sid Wagle wrote: > @Andrew: NAte has avalid point I think we should address this in trunk to > handled completely on the server side. Would you be able to open an Apache > Jira for tracking this? Thanks. Sure. Created a jira. Added CC for you and Nate. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192365 --- On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Nov. 30, 2017, 1:28 p.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? > > Sid Wagle wrote: > We would still need to make sure existing hosts get the changes if user > denies license during setup and then accepts it. Present behavior is that we > do not update the repo for existing hosts. Thereby, I was ok with limiting > the changes to the agent vs server and agent. > > Nate Cole wrote: > The command repository is being sent down and processed on every command. > > Sid Wagle wrote: > Fair enough, also what about accept and then deny. Ambari should reflect > presence or absence of the repo info based on the flag. Do you think doing > this on the server would be cleaner? IMO, this is pretty custom repo handling > in any case, we do not have a repo-tag -> license-tag mapping anywhere so > wouldn't it be equally ugly? > > Sid Wagle wrote: > By license-tag I meant some lookup to figure out whether license was > accepted. > > Andrew Onischuk wrote: > IMO this looks pretty much the same whether the check is on server or > agent. However it may take some time while I re-implement this to server if > that's the approach you prefer. @Sid @Nate If you decide we need this, we can > create re-factoring jira (not for 2.6.1) and do this. > > Nate Cole wrote: > The whole point of CommandRepository was to send down to the agent ONLY > what is necessary to create the repo. Spreading logic around makes it > difficult to troubleshoot. It should either ALL be in java or ALL be in > python. @Andrew: NAte has avalid point I think we should address this in trunk to handled completely on the server side. Would you be able to open an Apache Jira for tracking this? Thanks. - Sid --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192365 --- On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Nov. 30, 2017, 1:28 p.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? > > Sid Wagle wrote: > We would still need to make sure existing hosts get the changes if user > denies license during setup and then accepts it. Present behavior is that we > do not update the repo for existing hosts. Thereby, I was ok with limiting > the changes to the agent vs server and agent. > > Nate Cole wrote: > The command repository is being sent down and processed on every command. > > Sid Wagle wrote: > Fair enough, also what about accept and then deny. Ambari should reflect > presence or absence of the repo info based on the flag. Do you think doing > this on the server would be cleaner? IMO, this is pretty custom repo handling > in any case, we do not have a repo-tag -> license-tag mapping anywhere so > wouldn't it be equally ugly? > > Sid Wagle wrote: > By license-tag I meant some lookup to figure out whether license was > accepted. IMO this looks pretty much the same whether the check is on server or agent. However it may take some time while I re-implement this to server if that's the approach you prefer. @Sid @Nate If you decide we need this, we can create re-factoring jira (not for 2.6.1) and do this. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192365 --- On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Nov. 30, 2017, 1:28 p.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
> On Nov. 30, 2017, 7:12 p.m., Sid Wagle wrote: > > Can you provide some notes on the manual testing effort on this? I did happy scenario. Also I did the one described in jira. Meaning: 1. Deny the license install Ambari 2. Check that gpl repos are not written to agent filesystem 3. Accept the license and restart server 4. Restart Datanode. 5. Make sure lzo packages are installed and gpl repos and present. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192335 --- On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Nov. 30, 2017, 1:28 p.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? > > Sid Wagle wrote: > We would still need to make sure existing hosts get the changes if user > denies license during setup and then accepts it. Present behavior is that we > do not update the repo for existing hosts. Thereby, I was ok with limiting > the changes to the agent vs server and agent. > > Nate Cole wrote: > The command repository is being sent down and processed on every command. > > Sid Wagle wrote: > Fair enough, also what about accept and then deny. Ambari should reflect > presence or absence of the repo info based on the flag. Do you think doing > this on the server would be cleaner? IMO, this is pretty custom repo handling > in any case, we do not have a repo-tag -> license-tag mapping anywhere so > wouldn't it be equally ugly? By license-tag I meant some lookup to figure out whether license was accepted. - Sid --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192365 --- On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Nov. 30, 2017, 1:28 p.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? > > Sid Wagle wrote: > We would still need to make sure existing hosts get the changes if user > denies license during setup and then accepts it. Present behavior is that we > do not update the repo for existing hosts. Thereby, I was ok with limiting > the changes to the agent vs server and agent. > > Nate Cole wrote: > The command repository is being sent down and processed on every command. Fair enough, also what about accept and then deny. Ambari should reflect presence or absence of the repo info based on the flag. Do you think doing this on the server would be cleaner? IMO, this is pretty custom repo handling in any case, we do not have a repo-tag -> license-tag mapping anywhere so wouldn't it be equally ugly? - Sid --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192365 --- On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Nov. 30, 2017, 1:28 p.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192371 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лис. 30, 2017, 3:28 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Лис. 30, 2017, 3:28 після полудня) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
> On Nov. 30, 2017, 4:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? > > Sid Wagle wrote: > We would still need to make sure existing hosts get the changes if user > denies license during setup and then accepts it. Present behavior is that we > do not update the repo for existing hosts. Thereby, I was ok with limiting > the changes to the agent vs server and agent. The command repository is being sent down and processed on every command. - Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192365 --- On Nov. 30, 2017, 8:28 a.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Nov. 30, 2017, 8:28 a.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? We would still need to make sure existing hosts get the changes if user denies license during setup and then accepts it. Present behavior is that we do not update the repo for existing hosts. Thereby, I was ok with limiting the changes to the agent vs server and agent. - Sid --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192365 --- On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Nov. 30, 2017, 1:28 p.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192365 --- This is making the agent-side do the logic. Shouldn't we check these things and not include GPL repos in the command to the agent? - Nate Cole On Nov. 30, 2017, 8:28 a.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Nov. 30, 2017, 8:28 a.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192335 --- Ship it! Can you provide some notes on the manual testing effort on this? - Sid Wagle On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Nov. 30, 2017, 1:28 p.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/ --- Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle. Bugs: AMBARI-22561 https://issues.apache.org/jira/browse/AMBARI-22561 Repository: ambari Description --- * User denies the GPL license agreement, UI will still issue PUT call to create the repo * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo because it will break yum in local repo world. * Then the user accepts the license by running ambari-server setup * The repo file does not get updated on existing hosts * We need to push the HDP-GPL repo to the repo files on existing hosts only when the license is accepted Diffs - ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py 68ee607b9b ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py f1c8ef1b04 ambari-common/src/main/python/resource_management/libraries/script/script.py ccb8a547f4 ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java e207ac5289 ambari-server/src/main/resources/custom_actions/scripts/install_packages.py b819dcad96 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py 82e57aa4f4 ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe Diff: https://reviews.apache.org/r/64209/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk
