date:20171212


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64531/#review193537
---


Ship it!




Pobably that would be better if we would clone all of the mapper types as well. 
But that wont hurt so +1

- Oliver Szabo


On Dec. 12, 2017, 9:39 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64531/
> ---
> 
> (Updated Dec. 12, 2017, 9:39 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Oliver Szabo, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22633
> https://issues.apache.org/jira/browse/AMBARI-22633
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In AMBARI-22600, we cloned the Filter instance to assign the instance per 
> child thread, which also clones the map of Mapper. Other Mapper implements 
> only have String(s) type of fields hence thread-safe, but MapperDate has 
> SimpleDateFormat type of fields which is known as non thread-safe, so cloning 
> the Filter which has one or more MapperDate and using them concurrently makes 
> multi-threads issue.
> 
> Replacing SimpleDateFormat with FastDateFormat in commons-lang3 would resolve 
> the issue.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml a06ae902fc 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
>  6a7fad7b70 
> 
> 
> Diff: https://reviews.apache.org/r/64531/diff/1/
> 
> 
> Testing
> ---
> 
> - existing unit tests
> - manual tests (manually deploying to cluster)
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Review Request 64544: Migrate user data for upgrade to improved user account management

2017-12-12 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64544/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.


Bugs: AMBARI-22577
https://issues.apache.org/jira/browse/AMBARI-22577


Repository: ambari


Description
---

Migrate data from the users table (pre-Ambari 3.0.0) to the updated users table 
and user_authentication tables.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
549c0fd7e8 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
 513e78200d 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
 27514f648c 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
 20a06ccd54 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
 2de60957bc 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e58a04e4b2 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql cc589e47f2 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7cd083db4c 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql ff232ebe3e 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql d7c09f3381 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql b4929b308d 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
 29f9d917e8 
  ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 
96cf64e53c 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDNWithSpaceTest.java
 10076b0876 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
 43d4d6b0c0 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
 747f99b618 


Diff: https://reviews.apache.org/r/64544/diff/1/


Testing
---

manually tested

# Local test results: 
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 27:21 min
[INFO] Finished at: 2017-12-11T17:30:31-05:00
[INFO] Final Memory: 100M/2019M
[INFO] 
```

# Jenkins test results: PENDING


Thanks,

Robert Levas

Review Request 64542: Kerberos support for OneFS

2017-12-12 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/
---

Review request for Ambari, Eugene Chekanskiy, Nate Cole, Robert Levas, and 
Sandor Molnar.


Bugs: AMBARI-22634
https://issues.apache.org/jira/browse/AMBARI-22634


Repository: ambari


Description
---

When kerberos is enabled, the OneFS service check should do a kinit before 
executing hdfs commands. I also removed some unused code from the servicecheck 
script.


Diffs
-

  ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 
9c864a8f48889515d5b72c0feaf340b7b9e1fe31 
  ambari-web/app/messages.js b3051962f56951fc6bae169b63c5f029c1ef301d 
  
contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/kerberos.json
 PRE-CREATION 
  
contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/params_linux.py
 b823fc54b84e1149164e17504046a7a32070df1c 
  
contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/service_check.py
 3d798a3342ced3d99a4a2c955a6aca27108c 


Diff: https://reviews.apache.org/r/64542/diff/1/


Testing
---

- enabled kerberos, ran service checks on onefs


Thanks,

Attila Magyar

Review Request 64547: Hive MetaStore does not start even after passing the mysql-connector to ambari-server

2017-12-12 Thread Myroslav Papirkovskyy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64547/
---

Review request for Ambari, Andrew Onischuk and Sid Wagle.


Bugs: AMBARI-22631
https://issues.apache.org/jira/browse/AMBARI-22631


Repository: ambari


Description
---

Agent should always download jdbc driver for Hive from server resources.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 082232011950bd0eb5ad361bf7aa6a1cd761db41 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
a2b983ed8c37b37d5d12ab4ac1b0673e2f66e040 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 
dca7c18017011ecc8133323510a6352031fc4adb 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
73f5fe62c870f79d2f55d39a06279e977fb61115 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
4eb16c2a3c146ac4d2e61370eb5f3121c7a5331f 


Diff: https://reviews.apache.org/r/64547/diff/1/


Testing
---

mvn clean test
manual check


Thanks,

Myroslav Papirkovskyy

Re: Review Request 64547: Hive MetaStore does not start even after passing the mysql-connector to ambari-server

2017-12-12 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64547/#review193546
---


Ship it!




Ship It!

- Andrew Onischuk


On Dec. 12, 2017, 3:49 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64547/
> ---
> 
> (Updated Dec. 12, 2017, 3:49 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Sid Wagle.
> 
> 
> Bugs: AMBARI-22631
> https://issues.apache.org/jira/browse/AMBARI-22631
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Agent should always download jdbc driver for Hive from server resources.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  082232011950bd0eb5ad361bf7aa6a1cd761db41 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> a2b983ed8c37b37d5d12ab4ac1b0673e2f66e040 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 
> dca7c18017011ecc8133323510a6352031fc4adb 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> 73f5fe62c870f79d2f55d39a06279e977fb61115 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 4eb16c2a3c146ac4d2e61370eb5f3121c7a5331f 
> 
> 
> Diff: https://reviews.apache.org/r/64547/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64407: AMBARI-22592: Set ambari.repo. in ambari-server setup script


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64407/#review193547
---


Ship it!




Ship It!

- Nate Cole


On Dec. 8, 2017, 5:57 a.m., Sneha Kanekar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64407/
> ---
> 
> (Updated Dec. 8, 2017, 5:57 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22592
> https://issues.apache.org/jira/browse/AMBARI-22592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The ambari-server setup script is updated to allow the user to store/update 
> Ambari repo base URL in ambari.properties file for each OS type through 
> command line. The command to set Ambari repo URL : ambari-server setup 
> --ambari-repo 
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari-server.py 188910e 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 27b4472 
>   ambari-server/src/main/python/ambari_server/serverSetup.py 3b41fff 
>   ambari-server/src/test/python/TestAmbariServer.py ad4e371 
> 
> 
> Diff: https://reviews.apache.org/r/64407/diff/2/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-server.
> 
> 
> Thanks,
> 
> Sneha Kanekar
> 
>

Re: Review Request 64242: AMBARI-22476: Modify bootstrap API to pass Ambari repo URL from UI and retrieve Host OS types


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64242/#review193548
---


Ship it!




Will mark this as Ship It, but the repo url should be cleaned up, and 
(hopefully) doesn't need to be a json structure.

- Nate Cole


On Dec. 1, 2017, 2:47 a.m., Sonia Garudi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64242/
> ---
> 
> (Updated Dec. 1, 2017, 2:47 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22476
> https://issues.apache.org/jira/browse/AMBARI-22476
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The hosts failing with error code 44 are bootstrapped along with the ambari 
> repository URLs. The required java beans are changed to include the ambari 
> repository URLs to be passed to bootstrap.py.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 
> c7976ee5bb48209478258625532e3420973b4b8c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java
>  86888f499f15aa23807067ee1af745525b9d4619 
>   ambari-server/src/main/python/bootstrap.py 
> f1c53ce45316843fd38624536eed656b029a230a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java
>  b9da013524fee556c6faa2f0236d2c0c4b032750 
>   ambari-server/src/test/python/TestBootstrap.py 
> bea47f498cbb523fbe24622c63b48918d433c717 
>   ambari-web/app/controllers/wizard/step3_controller.js 
> 5ff2cdc1b4bb9da20565fe387765b4fc6728e096 
>   ambari-web/test/controllers/wizard/step3_test.js 
> be1affe28fdcdb3404ebd3fb3fc6e61315483ed2 
> 
> 
> Diff: https://reviews.apache.org/r/64242/diff/1/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-web and ambari-server.
> 
> 
> Thanks,
> 
> Sonia Garudi
> 
>

Re: Review Request 64407: AMBARI-22592: Set ambari.repo. in ambari-server setup script


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64407/#review193549
---



This has been pushed.  Please close this review and associated JIRA.

- Nate Cole


On Dec. 8, 2017, 5:57 a.m., Sneha Kanekar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64407/
> ---
> 
> (Updated Dec. 8, 2017, 5:57 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22592
> https://issues.apache.org/jira/browse/AMBARI-22592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The ambari-server setup script is updated to allow the user to store/update 
> Ambari repo base URL in ambari.properties file for each OS type through 
> command line. The command to set Ambari repo URL : ambari-server setup 
> --ambari-repo 
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari-server.py 188910e 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 27b4472 
>   ambari-server/src/main/python/ambari_server/serverSetup.py 3b41fff 
>   ambari-server/src/test/python/TestAmbariServer.py ad4e371 
> 
> 
> Diff: https://reviews.apache.org/r/64407/diff/2/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-server.
> 
> 
> Thanks,
> 
> Sneha Kanekar
> 
>

Re: Review Request 64242: AMBARI-22476: Modify bootstrap API to pass Ambari repo URL from UI and retrieve Host OS types


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64242/#review193550
---



This has been pushed.  Please close this review and associated JIRA.

- Nate Cole


On Dec. 1, 2017, 2:47 a.m., Sonia Garudi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64242/
> ---
> 
> (Updated Dec. 1, 2017, 2:47 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22476
> https://issues.apache.org/jira/browse/AMBARI-22476
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The hosts failing with error code 44 are bootstrapped along with the ambari 
> repository URLs. The required java beans are changed to include the ambari 
> repository URLs to be passed to bootstrap.py.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 
> c7976ee5bb48209478258625532e3420973b4b8c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java
>  86888f499f15aa23807067ee1af745525b9d4619 
>   ambari-server/src/main/python/bootstrap.py 
> f1c53ce45316843fd38624536eed656b029a230a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java
>  b9da013524fee556c6faa2f0236d2c0c4b032750 
>   ambari-server/src/test/python/TestBootstrap.py 
> bea47f498cbb523fbe24622c63b48918d433c717 
>   ambari-web/app/controllers/wizard/step3_controller.js 
> 5ff2cdc1b4bb9da20565fe387765b4fc6728e096 
>   ambari-web/test/controllers/wizard/step3_test.js 
> be1affe28fdcdb3404ebd3fb3fc6e61315483ed2 
> 
> 
> Diff: https://reviews.apache.org/r/64242/diff/1/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-web and ambari-server.
> 
> 
> Thanks,
> 
> Sonia Garudi
> 
>

Re: Review Request 64542: Kerberos support for OneFS


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/#review193551
---


Fix it, then Ship it!





ambari-web/app/controllers/main/admin/kerberos/step1_controller.js
Lines 45-47 (patched)


Is this, or can this be made to show conditionally if isilon is chosen?


- Nate Cole


On Dec. 12, 2017, 10:38 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64542/
> ---
> 
> (Updated Dec. 12, 2017, 10:38 a.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Nate Cole, Robert Levas, and 
> Sandor Molnar.
> 
> 
> Bugs: AMBARI-22634
> https://issues.apache.org/jira/browse/AMBARI-22634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the OneFS service check should do a kinit before 
> executing hdfs commands. I also removed some unused code from the 
> servicecheck script.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 
> 9c864a8f48889515d5b72c0feaf340b7b9e1fe31 
>   ambari-web/app/messages.js b3051962f56951fc6bae169b63c5f029c1ef301d 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/kerberos.json
>  PRE-CREATION 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/params_linux.py
>  b823fc54b84e1149164e17504046a7a32070df1c 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/service_check.py
>  3d798a3342ced3d99a4a2c955a6aca27108c 
> 
> 
> Diff: https://reviews.apache.org/r/64542/diff/1/
> 
> 
> Testing
> ---
> 
> - enabled kerberos, ran service checks on onefs
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 64544: Migrate user data for upgrade to improved user account management


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64544/#review193553
---


Ship it!




Ship It!

- Nate Cole


On Dec. 12, 2017, 9:35 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64544/
> ---
> 
> (Updated Dec. 12, 2017, 9:35 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.
> 
> 
> Bugs: AMBARI-22577
> https://issues.apache.org/jira/browse/AMBARI-22577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate data from the users table (pre-Ambari 3.0.0) to the updated users 
> table and user_authentication tables.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> 549c0fd7e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  513e78200d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  27514f648c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  20a06ccd54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  2de60957bc 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e58a04e4b2 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql cc589e47f2 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7cd083db4c 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql ff232ebe3e 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> d7c09f3381 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql b4929b308d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  29f9d917e8 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 
> 96cf64e53c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDNWithSpaceTest.java
>  10076b0876 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
>  43d4d6b0c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  747f99b618 
> 
> 
> Diff: https://reviews.apache.org/r/64544/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 27:21 min
> [INFO] Finished at: 2017-12-11T17:30:31-05:00
> [INFO] Final Memory: 100M/2019M
> [INFO] 
> 
> ```
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 64528: Zeppelin Interpreter settings are getting updated after zeppelin restart


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64528/#review193554
---


Ship it!




Ship It!

- Sid Wagle


On Dec. 12, 2017, 7:39 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64528/
> ---
> 
> (Updated Dec. 12, 2017, 7:39 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22626
> https://issues.apache.org/jira/browse/AMBARI-22626
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin Interpreter settings are getting updated after zeppelin restart.
> 
> Steps to reproduce :
> 1) Update the zeppelin.pyspark.python to /base/tools/python-2.7.14/bin/python 
> for spark2 interpreter
> 2) Restart zeppelin
> 3) After restart zeppelin.pyspark.python is getting overridden with value 
> 'python'.
> Same is observed with livy2 interpreter.
> 
> But same steps for spark interpreter is working fine even after zeppelin 
> restart.
> 
> So looks like issue is happening only for spark2 and livy2 interpreter.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
>  713db232b1 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
>  c9030bd33e 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  bb4c5b227b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/spark2_config_template.py
>  28a63c6f1b 
>   
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py
>  4b4dc1fe48 
> 
> 
> Diff: https://reviews.apache.org/r/64528/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 64513: Update the default storm log search configuration (use wildcards)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64513/#review193555
---


Ship it!




Ship It!

- Sid Wagle


On Dec. 11, 2017, 11:47 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64513/
> ---
> 
> (Updated Dec. 11, 2017, 11:47 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22630
> https://issues.apache.org/jira/browse/AMBARI-22630
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> set the storm config defaults for logseach as other teams needs it.
> 
> this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can 
> be used in a hotfix
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml
>  d485017 
> 
> 
> Diff: https://reviews.apache.org/r/64513/diff/1/
> 
> 
> Testing
> ---
> 
> not yet.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 64513: Update the default storm log search configuration (use wildcards)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64513/
---

(Updated Dec. 12, 2017, 4:19 p.m.)


Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle.


Changes
---

update with the commented block


Bugs: AMBARI-22630
https://issues.apache.org/jira/browse/AMBARI-22630


Repository: ambari


Description
---

set the storm config defaults for logseach as other teams needs it.

this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can be 
used in a hotfix


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml
 d485017 


Diff: https://reviews.apache.org/r/64513/diff/2/

Changes: https://reviews.apache.org/r/64513/diff/1-2/


Testing
---

not yet.


Thanks,

Oliver Szabo

Re: Review Request 64528: Zeppelin Interpreter settings are getting updated after zeppelin restart

2017-12-12 Thread Prabhjyot Singh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64528/
---

(Updated Dec. 12, 2017, 9:51 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22626
https://issues.apache.org/jira/browse/AMBARI-22626


Repository: ambari


Description
---

Zeppelin Interpreter settings are getting updated after zeppelin restart.

Steps to reproduce :
1) Update the zeppelin.pyspark.python to /base/tools/python-2.7.14/bin/python 
for spark2 interpreter
2) Restart zeppelin
3) After restart zeppelin.pyspark.python is getting overridden with value 
'python'.
Same is observed with livy2 interpreter.

But same steps for spark interpreter is working fine even after zeppelin 
restart.

So looks like issue is happening only for spark2 and livy2 interpreter.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
 713db232b1 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
 c9030bd33e 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 bb4c5b227b 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/spark2_config_template.py
 28a63c6f1b 
  
ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py 
4b4dc1fe48 


Diff: https://reviews.apache.org/r/64528/diff/1/


Testing
---

Manually


File Attachments (updated)


AMBARI-22626_branch-2.6_v1.patch
  
https://reviews.apache.org/media/uploaded/files/2017/12/12/6c85f9cf-ad03-466d-9dee-6813260b1275__AMBARI-22626_branch-2.6_v1.patch


Thanks,

Prabhjyot Singh

Re: Review Request 64513: Update the default storm log search configuration (use wildcards)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64513/#review193556
---



Last revision has noly whitespace changes?

- Sid Wagle


On Dec. 12, 2017, 4:19 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64513/
> ---
> 
> (Updated Dec. 12, 2017, 4:19 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22630
> https://issues.apache.org/jira/browse/AMBARI-22630
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> set the storm config defaults for logseach as other teams needs it.
> 
> this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can 
> be used in a hotfix
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml
>  d485017 
> 
> 
> Diff: https://reviews.apache.org/r/64513/diff/2/
> 
> 
> Testing
> ---
> 
> not yet.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 64513: Update the default storm log search configuration (use wildcards)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64513/
---

(Updated Dec. 12, 2017, 4:24 p.m.)


Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle.


Changes
---

upload the correct patch


Bugs: AMBARI-22630
https://issues.apache.org/jira/browse/AMBARI-22630


Repository: ambari


Description
---

set the storm config defaults for logseach as other teams needs it.

this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can be 
used in a hotfix


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml
 d485017 


Diff: https://reviews.apache.org/r/64513/diff/3/

Changes: https://reviews.apache.org/r/64513/diff/2-3/


Testing
---

not yet.


Thanks,

Oliver Szabo

Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy core-site.xml for Ranger plugins when namenode is not installed.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/#review193559
---



Instead of putting empty files on the classpath isn't it easier to check for 
file existence on plugin side and defaul to "simple" auth?

- Sid Wagle


On Dec. 12, 2017, 12:35 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64537/
> ---
> 
> (Updated Dec. 12, 2017, 12:35 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, 
> Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-22635
> https://issues.apache.org/jira/browse/AMBARI-22635
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For Ranger plugins to work properly in kerberised environments where HDFS is 
> not installed. We need to create a core-site.xml for Storm and Kafka plugins 
> so that the plugins can work to fetch latest policies from with kerberised 
> calls from Ranger.
> Attached patch is for trunk branch, seperate patch for branch-2.6 is attached 
> to Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py
>  e9719aa 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
>  9aa09df 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  c04496e 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py
>  c04496e 
> 
> 
> Diff: https://reviews.apache.org/r/64537/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with installation on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy core-site.xml for Ranger plugins when namenode is not installed.



> On Dec. 12, 2017, 4:36 p.m., Sid Wagle wrote:
> > Instead of putting empty files on the classpath isn't it easier to check 
> > for file existence on plugin side and defaul to "simple" auth?

Correction not empty I meant dummy file.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/#review193559
---


On Dec. 12, 2017, 12:35 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64537/
> ---
> 
> (Updated Dec. 12, 2017, 12:35 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, 
> Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-22635
> https://issues.apache.org/jira/browse/AMBARI-22635
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For Ranger plugins to work properly in kerberised environments where HDFS is 
> not installed. We need to create a core-site.xml for Storm and Kafka plugins 
> so that the plugins can work to fetch latest policies from with kerberised 
> calls from Ranger.
> Attached patch is for trunk branch, seperate patch for branch-2.6 is attached 
> to Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py
>  e9719aa 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
>  9aa09df 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  c04496e 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py
>  c04496e 
> 
> 
> Diff: https://reviews.apache.org/r/64537/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with installation on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 64407: AMBARI-22592: Set ambari.repo. in ambari-server setup script

2017-12-12 Thread Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64407/#review193562
---




ambari-server/src/test/python/TestAmbariServer.py
Lines 3703 (patched)


`with self.assertRaises(FatalException):`



ambari-server/src/test/python/TestAmbariServer.py
Lines 3884 (patched)


`with self.assertRaises(FatalException):`


- Matt


On Dec. 8, 2017, 2:57 a.m., Sneha Kanekar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64407/
> ---
> 
> (Updated Dec. 8, 2017, 2:57 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22592
> https://issues.apache.org/jira/browse/AMBARI-22592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The ambari-server setup script is updated to allow the user to store/update 
> Ambari repo base URL in ambari.properties file for each OS type through 
> command line. The command to set Ambari repo URL : ambari-server setup 
> --ambari-repo 
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari-server.py 188910e 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 27b4472 
>   ambari-server/src/main/python/ambari_server/serverSetup.py 3b41fff 
>   ambari-server/src/test/python/TestAmbariServer.py ad4e371 
> 
> 
> Diff: https://reviews.apache.org/r/64407/diff/2/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-server.
> 
> 
> Thanks,
> 
> Sneha Kanekar
> 
>

Re: Review Request 64544: Migrate user data for upgrade to improved user account management

2017-12-12 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64544/#review193564
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
Lines 175-192 (patched)


Interesting .. is this idempotent? Typically nested-selects with inserts 
are not if they could violate PKs. Maybe you need to breakt this out into 2 
queries and ensure you're only inserting when necessary?

Then again, maybe I don't quite see what this query is doing and it's ok... 
Thought I'd flag it for discussion.



ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
Lines 291 (patched)


You should create the FK declarations inside the table declarations.


- Jonathan Hurley


On Dec. 12, 2017, 9:35 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64544/
> ---
> 
> (Updated Dec. 12, 2017, 9:35 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.
> 
> 
> Bugs: AMBARI-22577
> https://issues.apache.org/jira/browse/AMBARI-22577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate data from the users table (pre-Ambari 3.0.0) to the updated users 
> table and user_authentication tables.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> 549c0fd7e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  513e78200d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  27514f648c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  20a06ccd54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  2de60957bc 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e58a04e4b2 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql cc589e47f2 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7cd083db4c 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql ff232ebe3e 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> d7c09f3381 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql b4929b308d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  29f9d917e8 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 
> 96cf64e53c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDNWithSpaceTest.java
>  10076b0876 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
>  43d4d6b0c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  747f99b618 
> 
> 
> Diff: https://reviews.apache.org/r/64544/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 27:21 min
> [INFO] Finished at: 2017-12-11T17:30:31-05:00
> [INFO] Final Memory: 100M/2019M
> [INFO] 
> 
> ```
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy core-site.xml for Ranger plugins when namenode is not installed.

2017-12-12 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/#review193566
---



Seems like lots of code duplication, can you centralize this in a ranger 
function and just invoke it?

Also - shouldn't ranger just ship with a default core-site.xml in these cases? 
Seems kind of odd to have to create a dummy one...

- Jonathan Hurley


On Dec. 12, 2017, 7:35 a.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64537/
> ---
> 
> (Updated Dec. 12, 2017, 7:35 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, 
> Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-22635
> https://issues.apache.org/jira/browse/AMBARI-22635
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For Ranger plugins to work properly in kerberised environments where HDFS is 
> not installed. We need to create a core-site.xml for Storm and Kafka plugins 
> so that the plugins can work to fetch latest policies from with kerberised 
> calls from Ranger.
> Attached patch is for trunk branch, seperate patch for branch-2.6 is attached 
> to Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py
>  e9719aa 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
>  9aa09df 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  c04496e 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py
>  c04496e 
> 
> 
> Diff: https://reviews.apache.org/r/64537/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with installation on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 64528: Zeppelin Interpreter settings are getting updated after zeppelin restart

2017-12-12 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64528/#review193570
---


Ship it!




Ship It!

- Jayush Luniya


On Dec. 12, 2017, 4:21 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64528/
> ---
> 
> (Updated Dec. 12, 2017, 4:21 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22626
> https://issues.apache.org/jira/browse/AMBARI-22626
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin Interpreter settings are getting updated after zeppelin restart.
> 
> Steps to reproduce :
> 1) Update the zeppelin.pyspark.python to /base/tools/python-2.7.14/bin/python 
> for spark2 interpreter
> 2) Restart zeppelin
> 3) After restart zeppelin.pyspark.python is getting overridden with value 
> 'python'.
> Same is observed with livy2 interpreter.
> 
> But same steps for spark interpreter is working fine even after zeppelin 
> restart.
> 
> So looks like issue is happening only for spark2 and livy2 interpreter.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
>  713db232b1 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
>  c9030bd33e 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  bb4c5b227b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/spark2_config_template.py
>  28a63c6f1b 
>   
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py
>  4b4dc1fe48 
> 
> 
> Diff: https://reviews.apache.org/r/64528/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> File Attachments
> 
> 
> AMBARI-22626_branch-2.6_v1.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/12/12/6c85f9cf-ad03-466d-9dee-6813260b1275__AMBARI-22626_branch-2.6_v1.patch
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 64544: Migrate user data for upgrade to improved user account management

2017-12-12 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64544/#review193572
---


Ship it!




Ship It!

- Attila Magyar


On Dec. 12, 2017, 2:35 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64544/
> ---
> 
> (Updated Dec. 12, 2017, 2:35 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.
> 
> 
> Bugs: AMBARI-22577
> https://issues.apache.org/jira/browse/AMBARI-22577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate data from the users table (pre-Ambari 3.0.0) to the updated users 
> table and user_authentication tables.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> 549c0fd7e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  513e78200d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  27514f648c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  20a06ccd54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  2de60957bc 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e58a04e4b2 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql cc589e47f2 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7cd083db4c 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql ff232ebe3e 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> d7c09f3381 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql b4929b308d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  29f9d917e8 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 
> 96cf64e53c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDNWithSpaceTest.java
>  10076b0876 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
>  43d4d6b0c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  747f99b618 
> 
> 
> Diff: https://reviews.apache.org/r/64544/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 27:21 min
> [INFO] Finished at: 2017-12-11T17:30:31-05:00
> [INFO] Final Memory: 100M/2019M
> [INFO] 
> 
> ```
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 64513: Update the default storm log search configuration (use wildcards)

2017-12-12 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64513/#review193574
---


Ship it!




Ship It!

- Robert Nettleton


On Dec. 12, 2017, 4:24 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64513/
> ---
> 
> (Updated Dec. 12, 2017, 4:24 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22630
> https://issues.apache.org/jira/browse/AMBARI-22630
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> set the storm config defaults for logseach as other teams needs it.
> 
> this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can 
> be used in a hotfix
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml
>  d485017 
> 
> 
> Diff: https://reviews.apache.org/r/64513/diff/3/
> 
> 
> Testing
> ---
> 
> not yet.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 64118: Refactor internal code of handling info between kerberos wizard actions

2017-12-12 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/#review193576
---



This is looking really good.  Upgrade logic to the appropriate UpgradeCatalog 
class.


ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
Line 605 (original), 603 (patched)


Change thChange this to use `DigestUtils.sha256Hex` for security concious 
folks... I know this is not being used in a security-related context, but SHA1 
is being frowned upon.is to `DigestUtils.sha256`



ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
Lines 456-464 (patched)


Did you intend to leave this here, or will it be fixed before this is 
committed?



ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
Line 127 (original), 137 (patched)


Change this to use `DigestUtils.sha256Hex` for security concious folks... I 
know this is not being used in a security-related context, but SHA1 is being 
frowned upon.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
Line 121 (original), 119 (patched)


We should change from SHA1 to SHA256 for security concious people.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
Line 209 (original), 205 (patched)


Change this to use `DigestUtils.sha256Hex` for security concious folks... I 
know this is not being used in a security-related context, but SHA1 is being 
frowned upon.


- Robert Levas


On Dec. 6, 2017, 5:21 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64118/
> ---
> 
> (Updated Dec. 6, 2017, 5:21 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
> 
> 
> Bugs: AMBARI-22530
> https://issues.apache.org/jira/browse/AMBARI-22530
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Moved out of data files for principal generation.
> Now before every kerberos action all info written to database.
> 
> Server actions determine what principals to process based on filters passed 
> to action, this allow:
> 
> * selective generation
> * split generation process per-host/per-service/per-component basis and make 
> generation concurrent for seperate parts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  53cceb0ded 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  83d2c9808d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  a7b9d80df0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  749943dc00 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  ab85aa1d7c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
>  52ab9b56ae 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
>  a8723b7bfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
>  81e4b3d0bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
>  f27dc48ea4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java
>  0898133bb5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
>  a25931b946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabServiceMappingEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java
>  5dd54ca30c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
>  d4e80c65d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java
>  7e57e4ae95 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Abst

Review Request 64552: Fix misuses of os.path.dirname(path) in yarn.py

2017-12-12 Thread Akira Ajisaka

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64552/
---

Review request for Ambari, Andrew Onischuk and Dmytro Sen.

Bugs: AMBARI-22637
https://issues.apache.org/jira/browse/AMBARI-22637

Repository: ambari

Description
---

os.path.dirname(path) does not return parent directory if the path ends with
'/'.
We should use os.path.dirname(os.path.abspath(path)) to get parent directory.

Diffs
-

ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
d077c848f2

ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/yarn.py
7731aeb09b

contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn.py
147fb38dc2

Diff: https://reviews.apache.org/r/64552/diff/1/

Testing
---

Jenkins result

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12901718/AMBARI-22637.001.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

+1 core tests. The patch passed unit tests in ambari-server.

Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/12831//console

Thanks,

Akira Ajisaka

Review Request 64554: HBase Cannot Find LZO Classes After Being Patched

2017-12-12 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64554/
---

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-22640
https://issues.apache.org/jira/browse/AMBARI-22640


Repository: ambari


Description
---

After patching HBase where LZO compression is being used, the following is seen:

```
2017-12-10 22:31:09,244|INFO|MainThread|machine.py:164 - 
run()||GUID=37b565a7-e164-4641-b335-19884c614ffd|Exception in thread "main" 
java.lang.RuntimeException: java.lang.ClassNotFoundException: 
com.hadoop.compression.lzo.LzoCodec
2017-12-10 22:31:09,245|INFO|MainThread|machine.py:164 - 
run()||GUID=37b565a7-e164-4641-b335-19884c614ffd|at 
org.apache.hadoop.hbase.io.compress.Compression$Algorithm$1.buildCodec(Compression.java:130)
2017-12-10 22:31:09,245|INFO|MainThread|machine.py:164 - 
run()||GUID=37b565a7-e164-4641-b335-19884c614ffd|at 
org.apache.hadoop.hbase.io.compress.Compression$Algorithm$1.getCodec(Compression.java:116)
2017-12-10 22:31:09,245|INFO|MainThread|machine.py:164 - 
run()||GUID=37b565a7-e164-4641-b335-19884c614ffd|at 
org.apache.hadoop.hbase.io.compress.Compression$Algorithm.getCompressor(Compression.java:301)
2017-12-10 22:31:09,245|INFO|MainThread|machine.py:164 - 
run()||GUID=37b565a7-e164-4641-b335-19884c614ffd|at 
org.apache.hadoop.hbase.io.encoding.HFileBlockDefaultEncodingContext.2017-12-10
 22:31:09,267|INFO|MainThread|machine.py:164 - 
run()||GUID=37b565a7-e164-4641-b335-19884c614ffd|at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
2017-12-10 22:31:09,268|INFO|MainThread|machine.py:164 - 
run()||GUID=37b565a7-e164-4641-b335-19884c614ffd|at 
java.util.concurrent.FutureTask.run(FutureTask.java:266)
2017-12-10 22:31:09,268|INFO|MainThread|machine.py:164 - 
run()||GUID=37b565a7-e164-4641-b335-19884c614ffd|at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
2017-12-10 22:31:09,268|INFO|MainThread|machine.py:164 - 
run()||GUID=37b565a7-e164-4641-b335-19884c614ffd|at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
2017-12-10 22:31:09,268|INFO|MainThread|machine.py:164 - 
run()||GUID=37b565a7-e164-4641-b335-19884c614ffd|at 
java.lang.Thread.run(Thread.java:745)
2017-12-10 22:31:09,741|INFO|MainThread|machine.py:189 - 
run()||GUID=37b565a7-e164-4641-b335-19884c614ffd|Exit Code: 1
```


Diffs
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
 ac71ce4b36 


Diff: https://reviews.apache.org/r/64554/diff/1/


Testing
---

Manual testing on Hbase cluster.


Thanks,

Jonathan Hurley

Review Request 64553: Log Feeder refactor: integrate with spring boot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64553/
---

Review request for Ambari, Krisztian Kasa and Sid Wagle.


Bugs: AMBARI-22639
https://issues.apache.org/jira/browse/AMBARI-22639


Repository: ambari


Description
---

First patch for refactor logfeeder - Spring Boot support

Add spring boot support, the goal is to get rid of LogFeederPropertiesUtil and 
let Spring to handle configs & beans.
- remove LogFeederPropertiesUtil
- move logfeeder properties fields into mutliple POJOs
- update some tests & remove one test (needs to rewrite it)
- convert singleton classes to spring beans
- let Spring to handle application pid file

(it does not contain any real changes regarding to input-filter-output blocks)

Next patch will be focus on the usage of start scritps (in ambari-logsearch and 
ambari-server stack code)


Diffs
-

  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java
 a84a97b 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigLogFeeder.java
 6ed36fd 
  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 01710bf 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
 5114743 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederCommandLine.java
 d996f98 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java
 243b344 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigItem.java
 5c20a8e 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogEntryParseTester.java
 ec29f69 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
 a76 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
 8e8834b 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
 fc7a565 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
 8e5aee8 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
 b021c37 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 972011d 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
 8f8c4fd 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
 f1b422f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
 df6c941 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java
 6173f53 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java
 e44873b 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java
 c832358 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java
 6e8ac04 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputFile.java
 e1a0bb9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
 ba4d60a 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputKafka.java
 52fc6f8 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
 48716fa 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputS3File.java
 5b213e8 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
 38219df 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederPropertiesUtil.java
 1636653 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
 6bcaac9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
 115778b 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/filter/FilterGrokTest.java
 8d7e86c 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/filter/FilterJSONTest.java
 acc3d4d 
  
ambari-logsearch/ambari-logsearch-lo

Re: Review Request 64553: Log Feeder refactor: integrate with spring boot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64553/
---

(Updated Dec. 12, 2017, 9:36 p.m.)


Review request for Ambari, Krisztian Kasa and Sid Wagle.


Changes
---

indluce new files


Bugs: AMBARI-22639
https://issues.apache.org/jira/browse/AMBARI-22639


Repository: ambari


Description (updated)
---

First patch for refactor logfeeder - Spring Boot support

Add spring boot support, the goal is to get rid of LogFeederPropertiesUtil and 
let Spring to handle configs & beans.
- remove LogFeederPropertiesUtil
- move logfeeder properties fields into mutliple POJOs
- update some tests & remove one test (needs to rewrite it)
- convert singleton classes to spring beans
- let Spring to handle application pid file
- convert some internal threads to classes (like StatsLogger)

(it does not contain any real changes regarding to input-filter-output blocks)

Next patch will be focus on the usage of start scritps (in ambari-logsearch and 
ambari-server stack code)


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java
 a84a97b 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigLogFeeder.java
 6ed36fd 
  ambari-logsearch/ambari-logsearch-logfeeder/.gitignore PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 01710bf 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
 5114743 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederCommandLine.java
 d996f98 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java
 243b344 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigItem.java
 5c20a8e 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogEntryParseTester.java
 ec29f69 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
 a76 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/ApplicationConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/InputSimulateConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogEntryCacheConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederSecurityConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/MetricsCollectorConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
 8e8834b 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
 fc7a565 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
 8e5aee8 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
 b021c37 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 972011d 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
 8f8c4fd 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
 f1b422f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
 df6c941 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java
 6173f53 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java
 e44873b 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java
 c832358 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java
 6e8ac04 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/StatsLogger.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputFile.java
 e1a0bb9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Ou

Re: Review Request 64553: Log Feeder refactor: integrate with spring boot