Re: Review Request 44574: Rename Service Action 'HAWQ Check' to 'HAWQ Config Check'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44574/#review122747 --- Ship it! Ship It! - Lav Jain On March 9, 2016, 5:16 p.m., Goutam Tadi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44574/ > --- > > (Updated March 9, 2016, 5:16 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Lav Jain, > and Matt. > > > Bugs: AMBARI-15357 > https://issues.apache.org/jira/browse/AMBARI-15357 > > > Repository: ambari > > > Description > --- > > Rename Service Action 'HAWQ Check' to 'HAWQ Config Check' > > > Diffs > - > > ambari-web/app/messages.js 8e69dd0 > > Diff: https://reviews.apache.org/r/44574/diff/ > > > Testing > --- > > Yeah done. > > > Thanks, > > Goutam Tadi > >
Re: Review Request 44575: Enable bulk operation for HAWQ Segments and PXF on Hosts page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44575/#review122793 --- Ship it! Ship It! - Lav Jain On March 9, 2016, 5:52 p.m., Goutam Tadi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44575/ > --- > > (Updated March 9, 2016, 5:52 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Lav Jain, > and Matt. > > > Bugs: AMBARI-15358 > https://issues.apache.org/jira/browse/AMBARI-15358 > > > Repository: ambari > > > Description > --- > > Enable bulk operation for HAWQ Segments and PXF on Hosts page > > > Diffs > - > > ambari-web/app/messages.js 8e69dd0 > ambari-web/app/views/main/host/hosts_table_menu_view.js 5670814 > > Diff: https://reviews.apache.org/r/44575/diff/ > > > Testing > --- > > Yes, done > > > Thanks, > > Goutam Tadi > >
Review Request 44695: Alert for updating HAWQ namespace after enabling HDFS HA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44695/ --- Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. Bugs: AMBARI-15382 https://issues.apache.org/jira/browse/AMBARI-15382 Repository: ambari Description --- Alert user on step1 of the wizard (conditional if HAWQ is installed). Repeat the message when the namenode HA wizard is done. Diffs - ambari-web/app/controllers/main/admin/highAvailability/nameNode/step1_controller.js 91a35b2 ambari-web/app/messages.js 5778d04 ambari-web/app/routes/high_availability_routes.js 6da53fe ambari-web/app/templates/main/admin/highAvailability/nameNode/step1.hbs 2f03ce3 Diff: https://reviews.apache.org/r/44695/diff/ Testing --- Manually tested Thanks, Lav Jain
Re: Review Request 44695: Alert for updating HAWQ namespace after enabling HDFS HA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44695/ --- (Updated March 11, 2016, 9:30 p.m.) Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton Alex, Oleksandr Diachenko, Richard Zang, Srimanth Gunturi, and Yusaku Sako. Changes --- Reomve "If HAWQ is installed" since the message is conditional. Bugs: AMBARI-15382 https://issues.apache.org/jira/browse/AMBARI-15382 Repository: ambari Description --- Alert user on step1 of the wizard (conditional if HAWQ is installed). Repeat the message when the namenode HA wizard is done. Diffs (updated) - ambari-web/app/controllers/main/admin/highAvailability/nameNode/step1_controller.js 91a35b2 ambari-web/app/messages.js 5778d04 ambari-web/app/routes/high_availability_routes.js 6da53fe ambari-web/app/templates/main/admin/highAvailability/nameNode/step1.hbs 2f03ce3 Diff: https://reviews.apache.org/r/44695/diff/ Testing --- Manually tested Thanks, Lav Jain
Review Request 44769: Config recommendations for installed services are getting cleared out
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44769/ --- Review request for Ambari, Andriy Babiichuk, Alexandr Antonenko, Andrii Tkach, and Srimanth Gunturi. Bugs: AMBARI-15396 https://issues.apache.org/jira/browse/AMBARI-15396 Repository: ambari Description --- As part of AMBARI-15189, dfs.allow.truncate was set to true if HAWQ service is being installed. However, the recommendation is getting cleared in ambari-web because HDFS is already installed. Diffs - ambari-web/app/mixins/common/configs/enhanced_configs.js 1ee4526 Diff: https://reviews.apache.org/r/44769/diff/ Testing --- Tested manually with and without HAWQ. Thanks, Lav Jain
Re: Review Request 44695: Alert for updating HAWQ namespace after enabling HDFS HA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44695/ --- (Updated March 14, 2016, 6:37 p.m.) Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton Alex, Oleksandr Diachenko, Richard Zang, Srimanth Gunturi, and Yusaku Sako. Bugs: AMBARI-15382 https://issues.apache.org/jira/browse/AMBARI-15382 Repository: ambari Description --- Alert user on step1 of the wizard (conditional if HAWQ is installed). Repeat the message when the namenode HA wizard is done. Diffs - ambari-web/app/controllers/main/admin/highAvailability/nameNode/step1_controller.js 91a35b2 ambari-web/app/messages.js 5778d04 ambari-web/app/routes/high_availability_routes.js 6da53fe ambari-web/app/templates/main/admin/highAvailability/nameNode/step1.hbs 2f03ce3 Diff: https://reviews.apache.org/r/44695/diff/ Testing (updated) --- Manually tested Screenshots are attached to the JIRA. Requesting comments for review... Thanks, Lav Jain
Re: Review Request 44868: Changed HAWQ directory descriptions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44868/#review123784 --- Ship it! Ship It! - Lav Jain On March 15, 2016, 10:51 p.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44868/ > --- > > (Updated March 15, 2016, 10:51 p.m.) > > > Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, Jayush Luniya, Lav Jain, Oleksandr Diachenko, and Sumit > Mohanty. > > > Bugs: AMBARI-15433 > https://issues.apache.org/jira/browse/AMBARI-15433 > > > Repository: ambari > > > Description > --- > > Changed HAWQ directory descriptions > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > d3aa0ed > > Diff: https://reviews.apache.org/r/44868/diff/ > > > Testing > --- > > manual. > > > Thanks, > > Alexander Denissov > >
Re: Review Request 45012: Recommendation and validation logic for HAWQ hdfs-client.xml output.replace-datanode-on-failure property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45012/#review124225 --- Ship it! Ship It! - Lav Jain On March 18, 2016, 2:01 a.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45012/ > --- > > (Updated March 18, 2016, 2:01 a.m.) > > > Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, Jayush Luniya, Lav Jain, and Sumit Mohanty. > > > Bugs: AMBARI-15499 > https://issues.apache.org/jira/browse/AMBARI-15499 > > > Repository: ambari > > > Description > --- > > Recommendation and validation logic for HAWQ hdfs-client.xml > output.replace-datanode-on-failure property > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml > c2a756a > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > c0bc4e2 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 4f0b4b7 > > Diff: https://reviews.apache.org/r/45012/diff/ > > > Testing > --- > > manual > > -- > Ran 253 tests in 7.111s > > OK > -- > Total run:927 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alexander Denissov > >
Re: Review Request 45124: Update logic for HAWQ 'output.replace-datanode-on-failure' property with threshold of 3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45124/#review124651 --- Ship it! Ship It! - Lav Jain On March 21, 2016, 7:29 p.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45124/ > --- > > (Updated March 21, 2016, 7:29 p.m.) > > > Review request for Ambari, bhuvnesh chaudhary, Goutam Tadi, and Lav Jain. > > > Bugs: AMBARI-15494 > https://issues.apache.org/jira/browse/AMBARI-15494 > > > Repository: ambari > > > Description > --- > > Update logic for HAWQ 'output.replace-datanode-on-failure' property with > threshold of 3 > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml > 6754fcd > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 171a6b6 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > b5cf1a6 > > Diff: https://reviews.apache.org/r/45124/diff/ > > > Testing > --- > > Manual. > > -- > Ran 246 tests in 7.028s > OK > -- > Total run:911 > Total errors:0 > Total failures:0 > > > Thanks, > > Alexander Denissov > >
Review Request 45252: PXF service checks fails on secured cluster without YARN
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45252/
---
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh
chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton
Alex, and Oleksandr Diachenko.
Bugs: AMBARI-15542
https://issues.apache.org/jira/browse/AMBARI-15542
Repository: ambari
Description
---
PXF service checks fails on secured cluster
```
2016-03-11 23:37:35,588 - HdfsResource[None] {'security_enabled': True,
'keytab': '/etc/security/keytabs/hdfs.headless.keytab', 'default_fs':
'hdfs://c6401.ambari.apache.org:8020', 'hdfs_site': ..., 'kinit_path_local':
'/usr/bin/kinit', 'principal_name': 'hdfs-...@ambari.apache.org', 'user':
'hdfs', 'action': ['execute']}
2016-03-11 23:37:35,588 - Testing PXF HDFS read
2016-03-11 23:37:35,675 - Error code: 500
2016-03-11 23:37:35,675 - HDFS test Failed: Exception occurred in HDFS test:
PXF data read failed: HTTP Error 500: Internal Server Error
```
Pxf log says
```
SEVERE: Servlet.service() for servlet [PXF REST Service] in context with path
[/pxf] threw exception [java.io.IOException: Can't get Master Kerberos
principal for use as renewer] with root cause
java.io.IOException: Can't get Master Kerberos principal for use as renewer
at
org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodesInternal(TokenCache.java:116)
at
org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodesInternal(TokenCache.java:100)
at
org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodes(TokenCache.java:80)
at
org.apache.hadoop.mapred.FileInputFormat.listStatus(FileInputFormat.java:206)
at
org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:315)
at
org.apache.hawq.pxf.plugins.hdfs.HdfsDataFragmenter.getSplits(HdfsDataFragmenter.java:108)
at
org.apache.hawq.pxf.plugins.hdfs.HdfsDataFragmenter.getFragments(HdfsDataFragmenter.java:69)
at
org.apache.hawq.pxf.service.rest.FragmenterResource.getFragments(FragmenterResource.java:84)
```
Diffs
-
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py
eed2d18
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
40e6d6f
Diff: https://reviews.apache.org/r/45252/diff/
Testing
---
Tested manually with and without YARN, with and without security.
Thanks,
Lav Jain
Re: Review Request 45252: PXF service checks fails on secured cluster without YARN
> On March 24, 2016, 1:18 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py,
> > line 154
> > <https://reviews.apache.org/r/45252/diff/1/?file=1312544#file1312544line154>
> >
> > Does YARN have to be functional (green status), or just installed so
> > that libraries are available?
YARN libraries are already present. It has to be configured (to populate
yarn-site.xml).
- Lav
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45252/#review125170
-------
On March 23, 2016, 10:23 p.m., Lav Jain wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45252/
> ---
>
> (Updated March 23, 2016, 10:23 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh
> chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton
> Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15542
> https://issues.apache.org/jira/browse/AMBARI-15542
>
>
> Repository: ambari
>
>
> Description
> ---
>
> PXF service checks fails on secured cluster
> ```
> 2016-03-11 23:37:35,588 - HdfsResource[None] {'security_enabled': True,
> 'keytab': '/etc/security/keytabs/hdfs.headless.keytab', 'default_fs':
> 'hdfs://c6401.ambari.apache.org:8020', 'hdfs_site': ..., 'kinit_path_local':
> '/usr/bin/kinit', 'principal_name': 'hdfs-...@ambari.apache.org', 'user':
> 'hdfs', 'action': ['execute']}
> 2016-03-11 23:37:35,588 - Testing PXF HDFS read
> 2016-03-11 23:37:35,675 - Error code: 500
> 2016-03-11 23:37:35,675 - HDFS test Failed: Exception occurred in HDFS test:
> PXF data read failed: HTTP Error 500: Internal Server Error
> ```
>
> Pxf log says
> ```
> SEVERE: Servlet.service() for servlet [PXF REST Service] in context with path
> [/pxf] threw exception [java.io.IOException: Can't get Master Kerberos
> principal for use as renewer] with root cause
> java.io.IOException: Can't get Master Kerberos principal for use as renewer
> at
> org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodesInternal(TokenCache.java:116)
> at
> org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodesInternal(TokenCache.java:100)
> at
> org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodes(TokenCache.java:80)
> at
> org.apache.hadoop.mapred.FileInputFormat.listStatus(FileInputFormat.java:206)
> at
> org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:315)
> at
> org.apache.hawq.pxf.plugins.hdfs.HdfsDataFragmenter.getSplits(HdfsDataFragmenter.java:108)
> at
> org.apache.hawq.pxf.plugins.hdfs.HdfsDataFragmenter.getFragments(HdfsDataFragmenter.java:69)
> at
> org.apache.hawq.pxf.service.rest.FragmenterResource.getFragments(FragmenterResource.java:84)
> ```
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py
> eed2d18
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
> 40e6d6f
>
> Diff: https://reviews.apache.org/r/45252/diff/
>
>
> Testing
> ---
>
> Tested manually with and without YARN, with and without security.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 45252: PXF service checks fails on secured cluster without YARN
> On March 24, 2016, 1:40 a.m., bhuvnesh chaudhary wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py,
> > line 156
> > <https://reviews.apache.org/r/45252/diff/1/?file=1312544#file1312544line156>
> >
> > is it a test or pre-requisite to execute test ?
The test fails unless YARN is there. We are pre-catching the exception and
giving a more meaningful message.
- Lav
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45252/#review125175
-------
On March 23, 2016, 10:23 p.m., Lav Jain wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45252/
> ---
>
> (Updated March 23, 2016, 10:23 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh
> chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton
> Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15542
> https://issues.apache.org/jira/browse/AMBARI-15542
>
>
> Repository: ambari
>
>
> Description
> ---
>
> PXF service checks fails on secured cluster
> ```
> 2016-03-11 23:37:35,588 - HdfsResource[None] {'security_enabled': True,
> 'keytab': '/etc/security/keytabs/hdfs.headless.keytab', 'default_fs':
> 'hdfs://c6401.ambari.apache.org:8020', 'hdfs_site': ..., 'kinit_path_local':
> '/usr/bin/kinit', 'principal_name': 'hdfs-...@ambari.apache.org', 'user':
> 'hdfs', 'action': ['execute']}
> 2016-03-11 23:37:35,588 - Testing PXF HDFS read
> 2016-03-11 23:37:35,675 - Error code: 500
> 2016-03-11 23:37:35,675 - HDFS test Failed: Exception occurred in HDFS test:
> PXF data read failed: HTTP Error 500: Internal Server Error
> ```
>
> Pxf log says
> ```
> SEVERE: Servlet.service() for servlet [PXF REST Service] in context with path
> [/pxf] threw exception [java.io.IOException: Can't get Master Kerberos
> principal for use as renewer] with root cause
> java.io.IOException: Can't get Master Kerberos principal for use as renewer
> at
> org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodesInternal(TokenCache.java:116)
> at
> org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodesInternal(TokenCache.java:100)
> at
> org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodes(TokenCache.java:80)
> at
> org.apache.hadoop.mapred.FileInputFormat.listStatus(FileInputFormat.java:206)
> at
> org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:315)
> at
> org.apache.hawq.pxf.plugins.hdfs.HdfsDataFragmenter.getSplits(HdfsDataFragmenter.java:108)
> at
> org.apache.hawq.pxf.plugins.hdfs.HdfsDataFragmenter.getFragments(HdfsDataFragmenter.java:69)
> at
> org.apache.hawq.pxf.service.rest.FragmenterResource.getFragments(FragmenterResource.java:84)
> ```
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py
> eed2d18
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
> 40e6d6f
>
> Diff: https://reviews.apache.org/r/45252/diff/
>
>
> Testing
> ---
>
> Tested manually with and without YARN, with and without security.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 45252: PXF service checks fails on secured cluster without YARN
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45252/
---
(Updated March 25, 2016, 8:50 p.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh
chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton
Alex, and Oleksandr Diachenko.
Bugs: AMBARI-15542
https://issues.apache.org/jira/browse/AMBARI-15542
Repository: ambari
Description
---
PXF service checks fails on secured cluster
```
2016-03-11 23:37:35,588 - HdfsResource[None] {'security_enabled': True,
'keytab': '/etc/security/keytabs/hdfs.headless.keytab', 'default_fs':
'hdfs://c6401.ambari.apache.org:8020', 'hdfs_site': ..., 'kinit_path_local':
'/usr/bin/kinit', 'principal_name': 'hdfs-...@ambari.apache.org', 'user':
'hdfs', 'action': ['execute']}
2016-03-11 23:37:35,588 - Testing PXF HDFS read
2016-03-11 23:37:35,675 - Error code: 500
2016-03-11 23:37:35,675 - HDFS test Failed: Exception occurred in HDFS test:
PXF data read failed: HTTP Error 500: Internal Server Error
```
Pxf log says
```
SEVERE: Servlet.service() for servlet [PXF REST Service] in context with path
[/pxf] threw exception [java.io.IOException: Can't get Master Kerberos
principal for use as renewer] with root cause
java.io.IOException: Can't get Master Kerberos principal for use as renewer
at
org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodesInternal(TokenCache.java:116)
at
org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodesInternal(TokenCache.java:100)
at
org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodes(TokenCache.java:80)
at
org.apache.hadoop.mapred.FileInputFormat.listStatus(FileInputFormat.java:206)
at
org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:315)
at
org.apache.hawq.pxf.plugins.hdfs.HdfsDataFragmenter.getSplits(HdfsDataFragmenter.java:108)
at
org.apache.hawq.pxf.plugins.hdfs.HdfsDataFragmenter.getFragments(HdfsDataFragmenter.java:69)
at
org.apache.hawq.pxf.service.rest.FragmenterResource.getFragments(FragmenterResource.java:84)
```
Diffs (updated)
-
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py
eed2d18
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
40e6d6f
Diff: https://reviews.apache.org/r/45252/diff/
Testing
---
Tested manually with and without YARN, with and without security.
Thanks,
Lav Jain
Review Request 45566: HAWQ config should not allow multiple Master/Segment directories
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45566/ --- Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. Bugs: AMBARI-15657 https://issues.apache.org/jira/browse/AMBARI-15657 Repository: ambari Description --- User can add multiple space delimited directories, but after installation, it shows a comma in between. however, only first directory goes into effect, that too with a comma in the end. ``` [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml hawq_master_directory /data/hawq/master,/data/hawq/master2 hawq_segment_directory /data/hawq/segment,/data/hawq/segment2 [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq drwxr-xr-x 3 root root 4096 Mar 12 01:00 master, drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment, ``` Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml ec7275f ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json a23afe6 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 741011c ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py d415b6f ambari-web/app/messages.js ea06bf3 ambari-web/app/mixins/common/serverValidator.js 99a5921 ambari-web/app/models/configs/objects/service_config_property.js a437c98 ambari-web/app/styles/application.less a6b79ce ambari-web/app/templates/common/modal_popups/config_recommendation_popup.hbs f58e086 ambari-web/app/views/common/configs/service_config_layout_tab_view.js 694e883 Diff: https://reviews.apache.org/r/45566/diff/ Testing --- Manually tested the UI. Unit test added for stack advisor. Thanks, Lav Jain
Re: Review Request 45566: HAWQ config should not allow multiple Master/Segment directories
> On April 1, 2016, 3:58 a.m., Matt wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py, > > line 972 > > <https://reviews.apache.org/r/45566/diff/1/?file=1321482#file1321482line972> > > > > Is trailing space valid or invalid? > > > > If it is valid, you may want to use strip() before splitting Trailing spaces will be invalidated by UI. - Lav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45566/#review126532 ------- On March 31, 2016, 10:09 p.m., Lav Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45566/ > --- > > (Updated March 31, 2016, 10:09 p.m.) > > > Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr > Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, > Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. > > > Bugs: AMBARI-15657 > https://issues.apache.org/jira/browse/AMBARI-15657 > > > Repository: ambari > > > Description > --- > > User can add multiple space delimited directories, but after installation, it > shows a comma in between. however, only first directory goes into effect, > that too with a comma in the end. > ``` > [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml > > hawq_master_directory > /data/hawq/master,/data/hawq/master2 > > > > hawq_segment_directory > /data/hawq/segment,/data/hawq/segment2 > > [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq > drwxr-xr-x 3 root root 4096 Mar 12 01:00 master, > drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment, > ``` > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > ec7275f > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json > a23afe6 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 741011c > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > d415b6f > ambari-web/app/messages.js ea06bf3 > ambari-web/app/mixins/common/serverValidator.js 99a5921 > ambari-web/app/models/configs/objects/service_config_property.js a437c98 > ambari-web/app/styles/application.less a6b79ce > > ambari-web/app/templates/common/modal_popups/config_recommendation_popup.hbs > f58e086 > ambari-web/app/views/common/configs/service_config_layout_tab_view.js > 694e883 > > Diff: https://reviews.apache.org/r/45566/diff/ > > > Testing > --- > > Manually tested the UI. > > Unit test added for stack advisor. > > > Thanks, > > Lav Jain > >
Re: Review Request 45566: HAWQ config should not allow multiple Master/Segment directories
> On April 1, 2016, 3:58 a.m., Matt wrote: > > ambari-web/app/views/common/configs/service_config_layout_tab_view.js, line > > 56 > > <https://reviews.apache.org/r/45566/diff/1/?file=1321489#file1321489line56> > > > > Can you please confirm if the help text is displayed when you hover > > over the directory box? No issues with displaying the help text. - Lav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45566/#review126532 ------- On March 31, 2016, 10:09 p.m., Lav Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45566/ > --- > > (Updated March 31, 2016, 10:09 p.m.) > > > Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr > Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, > Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. > > > Bugs: AMBARI-15657 > https://issues.apache.org/jira/browse/AMBARI-15657 > > > Repository: ambari > > > Description > --- > > User can add multiple space delimited directories, but after installation, it > shows a comma in between. however, only first directory goes into effect, > that too with a comma in the end. > ``` > [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml > > hawq_master_directory > /data/hawq/master,/data/hawq/master2 > > > > hawq_segment_directory > /data/hawq/segment,/data/hawq/segment2 > > [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq > drwxr-xr-x 3 root root 4096 Mar 12 01:00 master, > drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment, > ``` > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > ec7275f > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json > a23afe6 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 741011c > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > d415b6f > ambari-web/app/messages.js ea06bf3 > ambari-web/app/mixins/common/serverValidator.js 99a5921 > ambari-web/app/models/configs/objects/service_config_property.js a437c98 > ambari-web/app/styles/application.less a6b79ce > > ambari-web/app/templates/common/modal_popups/config_recommendation_popup.hbs > f58e086 > ambari-web/app/views/common/configs/service_config_layout_tab_view.js > 694e883 > > Diff: https://reviews.apache.org/r/45566/diff/ > > > Testing > --- > > Manually tested the UI. > > Unit test added for stack advisor. > > > Thanks, > > Lav Jain > >
Re: Review Request 45566: HAWQ config should not allow multiple Master/Segment directories
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45566/ --- (Updated April 1, 2016, 9:39 p.m.) Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. Bugs: AMBARI-15657 https://issues.apache.org/jira/browse/AMBARI-15657 Repository: ambari Description --- User can add multiple space delimited directories, but after installation, it shows a comma in between. however, only first directory goes into effect, that too with a comma in the end. ``` [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml hawq_master_directory /data/hawq/master,/data/hawq/master2 hawq_segment_directory /data/hawq/segment,/data/hawq/segment2 [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq drwxr-xr-x 3 root root 4096 Mar 12 01:00 master, drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment, ``` Diffs (updated) - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml ec7275f ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json a23afe6 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 741011c ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py d415b6f ambari-web/app/messages.js ea06bf3 ambari-web/app/mixins/common/serverValidator.js 99a5921 ambari-web/app/models/configs/objects/service_config_property.js a437c98 ambari-web/app/styles/application.less a6b79ce ambari-web/app/templates/common/modal_popups/config_recommendation_popup.hbs f58e086 ambari-web/app/views/common/configs/service_config_layout_tab_view.js 694e883 Diff: https://reviews.apache.org/r/45566/diff/ Testing --- Manually tested the UI. Unit test added for stack advisor. Thanks, Lav Jain
Re: Review Request 45724: Activate Standby option should not be shown on HAWQ Standby component on host summary page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45724/#review127037 --- Ship it! Ship It! - Lav Jain On April 5, 2016, 2:38 a.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45724/ > --- > > (Updated April 5, 2016, 2:38 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam > Tadi, and Lav Jain. > > > Bugs: AMBARI-15705 > https://issues.apache.org/jira/browse/AMBARI-15705 > > > Repository: ambari > > > Description > --- > > Activate Standby option should not be shown on HAWQ Standby component on host > summary page > > > Diffs > - > > ambari-web/app/models/host_component.js 7a5805c > > Diff: https://reviews.apache.org/r/45724/diff/ > > > Testing > --- > > Manually Tested. > > Ran unit tests: > 25609 tests complete (22 seconds) > 154 tests pending > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 55.352 s > [INFO] Finished at: 2016-04-04T19:35:54-07:00 > [INFO] Final Memory: 12M/311M > [INFO] > > > > Thanks, > > Matt > >
Re: Review Request 45826: Descriptions for HAWQ sysctl params mention incorrect default values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45826/#review127405 --- Ship it! - Lav Jain On April 6, 2016, 6:04 p.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45826/ > --- > > (Updated April 6, 2016, 6:04 p.m.) > > > Review request for Ambari, bhuvnesh chaudhary, Goutam Tadi, Lav Jain, and > Matt. > > > Bugs: AMBARI-15738 > https://issues.apache.org/jira/browse/AMBARI-15738 > > > Repository: ambari > > > Description > --- > > Descriptions for HAWQ sysctl params mention incorrect default values > > kernel.shmmax and net.ipv4.ip_local_port_range have incorrect default values > in their descriptions > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml > 365fa86 > > Diff: https://reviews.apache.org/r/45826/diff/ > > > Testing > --- > > Manual, tests ran OK > > -- > Ran 246 tests in 7.005s > > OK > -- > Total run:921 > Total errors:0 > Total failures:0 > > > Thanks, > > Alexander Denissov > >
Review Request 45878: Remove PHD references from HAWQ
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45878/ --- Review request for Ambari. Bugs: AMBARI-15741 https://issues.apache.org/jira/browse/AMBARI-15741 Repository: ambari Description --- Remove any reference to PHD (pivotal) stack in HAWQ codebase as it has been obsoleted. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py 4edf64f Diff: https://reviews.apache.org/r/45878/diff/ Testing --- Python test result --- Ran 253 tests in 6.818s OK -- Total run:944 Total errors:0 Total failures:0 OK Thanks, Lav Jain
Re: Review Request 45906: HAWQ fails to connect to YARN in HA+SEC mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45906/#review127693 --- Ship it! Ship It! - Lav Jain On April 7, 2016, 11 p.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45906/ > --- > > (Updated April 7, 2016, 11 p.m.) > > > Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam > Tadi, Jayush Luniya, Lav Jain, Matt, Sumit Mohanty, and Srimanth Gunturi. > > > Bugs: AMBARI-15770 > https://issues.apache.org/jira/browse/AMBARI-15770 > > > Repository: ambari > > > Description > --- > > When HAWQ is in the cluster with YARN HA and Kerberos enabled, the segments > are down as they cannot connect to YARN RM. > > The following updates are required: > 1. add hadoop.security.authentication = kerberos in yarn-client.xml > > 2. add 2 properties to core-site.xml: > > hadoop.proxyuser.postgres.hosts > * > > > hadoop.proxyuser.postgres.groups > hadoop > > > 3. on every HAWQ node: > sudo useradd postgres > sudo usermod -a -G hadoop postgres > > > Diffs > - > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json > da11986 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py > 2ec4903 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py > 2a671da > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 5a5ee8d > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py c212b7d > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 1eb335e > > Diff: https://reviews.apache.org/r/45906/diff/ > > > Testing > --- > > Tested manually and updates python tests: > -- > Ran 246 tests in 7.061s > OK > -- > Total run:923 > Total errors:0 > Total failures:0 > > > Thanks, > > Alexander Denissov > >
Re: Review Request 45899: After enabling NN HA with HAWQ installed, duplicate properties are seen on HAWQ config tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45899/#review127701 --- Ship it! Ship It! - Lav Jain On April 7, 2016, 10:26 p.m., Goutam Tadi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45899/ > --- > > (Updated April 7, 2016, 10:26 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Lav Jain, > and Matt. > > > Bugs: AMBARI-15771 > https://issues.apache.org/jira/browse/AMBARI-15771 > > > Repository: ambari > > > Description > --- > > After enabling NN HA with HAWQ installed, duplicate properties are seen on > HAWQ config tab > > > Diffs > - > > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js > d004ba1 > > Diff: https://reviews.apache.org/r/45899/diff/ > > > Testing > --- > > Yes. > 10491 tests complete (11 seconds) > 121 tests pending > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 41.245 s > [INFO] Finished at: 2016-04-07T14:59:25-07:00 > [INFO] Final Memory: 15M/422M > [INFO] -- > > > Thanks, > > Goutam Tadi > >
Review Request 45973: HAWQ Resync on Standby Fails after NN HA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45973/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. Bugs: AMBARI-15784 https://issues.apache.org/jira/browse/AMBARI-15784 Repository: ambari Description --- When testing Ambari with NN HA, removed and initialized a HAWQ standby on different host. When standby went out of sync, triggered the service action to resync, which eventually failed. But when ran the resync command from master, resync went successful. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml e35b7d8 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py a080158 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py db155a0 ambari-web/app/models/host_component.js 5e070ec ambari-web/app/views/main/service/item.js 5d82fb9 Diff: https://reviews.apache.org/r/45973/diff/ Testing --- Tested manually. Thanks, Lav Jain
Re: Review Request 46062: PXF service check must occur only after PXF is started
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46062/#review128285 --- Ship it! Ship It! - Lav Jain On April 11, 2016, 11:23 p.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46062/ > --- > > (Updated April 11, 2016, 11:23 p.m.) > > > Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, Jayush Luniya, Lav Jain, Matt, Sumit Mohanty, and Srimanth > Gunturi. > > > Bugs: AMBARI-15817 > https://issues.apache.org/jira/browse/AMBARI-15817 > > > Repository: ambari > > > Description > --- > > PXF service check must occur only after PXF is started > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json > b179d1c > > Diff: https://reviews.apache.org/r/46062/diff/ > > > Testing > --- > > Tested manually, ran tests: > -- > Ran 246 tests in 7.222s > OK > -- > Total run:925 > Total errors:0 > Total failures:0 > > > Thanks, > > Alexander Denissov > >
Re: Review Request 46072: HAWQ HDFS directory should be owned by postgres user if secured
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46072/#review128475 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py (line 105) <https://reviews.apache.org/r/46072/#comment191892> This code is already part of init_component in common.py - Lav Jain On April 12, 2016, 6:27 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46072/ > --- > > (Updated April 12, 2016, 6:27 a.m.) > > > Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, and > Oleksandr Diachenko. > > > Bugs: AMBARI-15820 > https://issues.apache.org/jira/browse/AMBARI-15820 > > > Repository: ambari > > > Description > --- > > HAWQ HDFS directory should be owned by postgres user if secured. Currently, > it is owned by gpadmin even when the cluster is secured. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py > 98dedf1 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py > 87d3c8a > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 9017d24 > > Diff: https://reviews.apache.org/r/46072/diff/ > > > Testing > --- > > yes > > bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-11 > 23:28:50,081 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys > is either set to false or is not available in hawq-env.xml > ok > test_stop_default (test_hawqmaster.TestHawqMaster) ... ok > test_configure_default (test_hawqsegment.TestHawqSegment) ... ok > test_install_default (test_hawqsegment.TestHawqSegment) ... ok > test_start_default (test_hawqsegment.TestHawqSegment) ... ok > test_stop_default (test_hawqsegment.TestHawqSegment) ... ok > test_configure_default (test_hawqstandby.TestHawqStandby) ... ok > test_install_default (test_hawqstandby.TestHawqStandby) ... ok > test_start_default (test_hawqstandby.TestHawqStandby) ... ok > test_stop_default (test_hawqstandby.TestHawqStandby) ... ok > > -- > Ran 34 tests in 0.140s > > OK > > > Thanks, > > bhuvnesh chaudhary > >
Review Request 46170: HAWQ Segment Registration Status Alert shows false alert
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46170/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. Bugs: AMBARI-15794 https://issues.apache.org/jira/browse/AMBARI-15794 Repository: ambari Description --- Steps to reproduce: Install HAWQ with HAWQSEGMENT on the same host as HAWQMASTER Segment registration would show an alert saying that localhost is not registered. localhost is returned by gp_segment_configuration for that HAWQSEGMENT, but in the slaves file, there is no entry 'localhost' Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py 4d09763 Diff: https://reviews.apache.org/r/46170/diff/ Testing --- Manually tested. Thanks, Lav Jain
Re: Review Request 46170: HAWQ Segment Registration Status Alert shows false alert
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46170/ --- (Updated April 14, 2016, 11:52 p.m.) Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. Bugs: AMBARI-15794 https://issues.apache.org/jira/browse/AMBARI-15794 Repository: ambari Description --- Steps to reproduce: Install HAWQ with HAWQSEGMENT on the same host as HAWQMASTER Segment registration would show an alert saying that localhost is not registered. localhost is returned by gp_segment_configuration for that HAWQSEGMENT, but in the slaves file, there is no entry 'localhost' Diffs (updated) - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py 4d09763 Diff: https://reviews.apache.org/r/46170/diff/ Testing --- Manually tested. Thanks, Lav Jain
Re: Review Request 46170: HAWQ Segment Registration Status Alert shows false alert
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46170/ --- (Updated April 15, 2016, 12:05 a.m.) Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. Bugs: AMBARI-15794 https://issues.apache.org/jira/browse/AMBARI-15794 Repository: ambari Description --- Steps to reproduce: Install HAWQ with HAWQSEGMENT on the same host as HAWQMASTER Segment registration would show an alert saying that localhost is not registered. localhost is returned by gp_segment_configuration for that HAWQSEGMENT, but in the slaves file, there is no entry 'localhost' Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py 4d09763 Diff: https://reviews.apache.org/r/46170/diff/ Testing (updated) --- Manually tested. -- Ran 246 tests in 7.230s OK -- Total run:925 Total errors:0 Total failures:0 OK Thanks, Lav Jain
Re: Review Request 46253: Add ignore-bad-hosts flag to hawq remove standby custom action to avoid failures when a segment host is down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46253/#review129136 --- Ship it! Ship It! - Lav Jain On April 15, 2016, 5:59 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46253/ > --- > > (Updated April 15, 2016, 5:59 a.m.) > > > Review request for Ambari, Alexander Denissov, Alejandro Fernandez, jun aoki, > Jayush Luniya, and Matt. > > > Bugs: AMBARI-15905 > https://issues.apache.org/jira/browse/AMBARI-15905 > > > Repository: ambari > > > Description > --- > > Add ignore-bad-hosts flag to hawq remove standby custom action to avoid > failures when a segment host is down > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py > f2ec914 > > Diff: https://reviews.apache.org/r/46253/diff/ > > > Testing > --- > > yes. > > bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-14 > 23:01:10,891 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys > is either set to false or is not available in hawq-env.xml > ok > test_stop_default (test_hawqmaster.TestHawqMaster) ... ok > test_configure_default (test_hawqsegment.TestHawqSegment) ... ok > test_install_default (test_hawqsegment.TestHawqSegment) ... ok > test_start_default (test_hawqsegment.TestHawqSegment) ... ok > test_stop_default (test_hawqsegment.TestHawqSegment) ... ok > test_configure_default (test_hawqstandby.TestHawqStandby) ... ok > test_install_default (test_hawqstandby.TestHawqStandby) ... ok > test_start_default (test_hawqstandby.TestHawqStandby) ... ok > test_stop_default (test_hawqstandby.TestHawqStandby) ... ok > > -- > Ran 34 tests in 0.147s > > OK > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 46283: hawq init master fails to syncup hawq-site xml if there is a segment host down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46283/#review129202 --- Ship it! Ship It! - Lav Jain On April 15, 2016, 10:15 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46283/ > --- > > (Updated April 15, 2016, 10:15 p.m.) > > > Review request for Ambari, Alexander Denissov, Alejandro Fernandez, jun aoki, > Jayush Luniya, Matt, Oleksandr Diachenko, and Srimanth Gunturi. > > > Bugs: AMBARI-15930 > https://issues.apache.org/jira/browse/AMBARI-15930 > > > Repository: ambari > > > Description > --- > > In hawq init command, default bucket number is calculated and the updated > hawq-site.xml is copied to all the other nodes, if there is a segment host > down it will fail to syncup the fail. > Including the option to skip bad hosts as ambari will override this file > whenever the segment host is brought online and started. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py > b929430 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 5f7f085 > > Diff: https://reviews.apache.org/r/46283/diff/ > > > Testing > --- > > yes. > bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-15 > 15:16:22,910 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys > is either set to false or is not available in hawq-env.xml > ok > test_stop_default (test_hawqmaster.TestHawqMaster) ... ok > test_configure_default (test_hawqsegment.TestHawqSegment) ... ok > test_install_default (test_hawqsegment.TestHawqSegment) ... ok > test_start_default (test_hawqsegment.TestHawqSegment) ... ok > test_stop_default (test_hawqsegment.TestHawqSegment) ... ok > test_configure_default (test_hawqstandby.TestHawqStandby) ... ok > test_install_default (test_hawqstandby.TestHawqStandby) ... ok > test_start_default (test_hawqstandby.TestHawqStandby) ... ok > test_stop_default (test_hawqstandby.TestHawqStandby) ... ok > test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok > > -- > Ran 35 tests in 0.148s > > OK > > > Thanks, > > bhuvnesh chaudhary > >
Review Request 46350: PXF Check fails on Kerberized cluster without a YARN component
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46350/ --- Review request for Ambari. Bugs: AMBARI-15954 https://issues.apache.org/jira/browse/AMBARI-15954 Repository: ambari Description --- If the PXF component is not co-located with a YARN component, PXF service check would fail. This is because it requires yarn-site on that host. Diffs - ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py ae0c80c ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py fe3c17e Diff: https://reviews.apache.org/r/46350/diff/ Testing --- Tested manually Thanks, Lav Jain
Re: Review Request 46359: HAWQ Immediate Stop cluster fails with key error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46359/#review129469 --- Ship it! Ship It! - Lav Jain On April 19, 2016, 1:20 a.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46359/ > --- > > (Updated April 19, 2016, 1:20 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, and Lav Jain. > > > Bugs: AMBARI-15960 > https://issues.apache.org/jira/browse/AMBARI-15960 > > > Repository: ambari > > > Description > --- > > Error log from running the wizard: > > > stderr: > Traceback (most recent call last): > File > "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py", > line 98, in > HawqMaster().execute() > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 219, in execute > method(env) > File > "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py", > line 69, in immediate_stop_hawq_service > common.stop_component(hawq_constants.CLUSTER, hawq_constants.IMMEDIATE) > File > "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/common.py", > line 309, in stop_component > port_property_name = > hawq_constants.COMPONENT_ATTRIBUTES_MAP[component_name]['port_property'] > KeyError: 'cluster' > stdout: > None > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py > 4ce0c94 > > Diff: https://reviews.apache.org/r/46359/diff/ > > > Testing > --- > > Manually Tested. Unit Tests passed. > > > Thanks, > > Matt > >
Re: Review Request 46350: PXF Check fails on Kerberized cluster without a YARN component
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46350/ --- (Updated April 19, 2016, 9:12 p.m.) Review request for Ambari. Bugs: AMBARI-15954 https://issues.apache.org/jira/browse/AMBARI-15954 Repository: ambari Description --- If the PXF component is not co-located with a YARN component, PXF service check would fail. This is because it requires yarn-site on that host. Diffs (updated) - ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py ae0c80c ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py fe3c17e Diff: https://reviews.apache.org/r/46350/diff/ Testing --- Tested manually Thanks, Lav Jain
Re: Review Request 46350: PXF Check fails on Kerberized cluster without a YARN component
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46350/ --- (Updated April 19, 2016, 9:18 p.m.) Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. Bugs: AMBARI-15954 https://issues.apache.org/jira/browse/AMBARI-15954 Repository: ambari Description --- If the PXF component is not co-located with a YARN component, PXF service check would fail. This is because it requires yarn-site on that host. Diffs - ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py ae0c80c ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py fe3c17e Diff: https://reviews.apache.org/r/46350/diff/ Testing --- Tested manually Thanks, Lav Jain
Re: Review Request 46585: Show number of PXFs Live widget on main dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46585/#review130491 --- Ship it! Ship It! - Lav Jain On April 22, 2016, 11:51 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46585/ > --- > > (Updated April 22, 2016, 11:51 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, and Lav Jain. > > > Bugs: AMBARI-16074 > https://issues.apache.org/jira/browse/AMBARI-16074 > > > Repository: ambari > > > Description > --- > > Show number of PXFs Live widget on main dashboard > > > Diffs > - > > ambari-web/app/assets/test/tests.js 33e7f1c > ambari-web/app/mappers/components_state_mapper.js 755c0f5 > ambari-web/app/messages.js 907d9ae > ambari-web/app/views.js 6bb2774 > ambari-web/app/views/main/dashboard/widgets.js 067607f > ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js bec98c6 > ambari-web/app/views/main/dashboard/widgets/pxf_live.js PRE-CREATION > ambari-web/test/views/main/dashboard/widgets/pxf_live_test.js PRE-CREATION > > Diff: https://reviews.apache.org/r/46585/diff/ > > > Testing > --- > > Manually Tested > > Added Unit test. > > Unit test Results: > > 27538 tests complete (22 seconds) > 154 tests pending > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 01:11 min > [INFO] Finished at: 2016-04-22T16:50:37-07:00 > [INFO] Final Memory: 12M/310M > [INFO] > > > > Thanks, > > Matt > >
Re: Review Request 46752: Ambari Web Service installation does not comply with Final Attribute. (isFinal is skipped)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46752/#review130865 --- Ship it! Ship It! - Lav Jain On April 27, 2016, 11:16 p.m., Goutam Tadi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46752/ > --- > > (Updated April 27, 2016, 11:16 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, > Lav Jain, and Matt. > > > Bugs: AMBARI-16147 > https://issues.apache.org/jira/browse/AMBARI-16147 > > > Repository: ambari > > > Description > --- > > When installing HDFS/HIVE/any service the properties that are marked final > before installation are marked as de-finalized post installation. This occurs > at the last step of installation i.e deploy stage. > > > Diffs > - > > ambari-web/app/controllers/wizard.js 52fb241 > > Diff: https://reviews.apache.org/r/46752/diff/ > > > Testing > --- > > Yes, Tested manually. > > 27704 tests complete (25 seconds) > INFO] > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 57.007s > [INFO] Finished at: Wed Apr 27 22:00:48 UTC 2016 > [INFO] Final Memory: 9M/43M > [INFO] > > > > Thanks, > > Goutam Tadi > >
Re: Review Request 46742: Use additional flags for HAWQ Check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46742/#review131178 --- Ship it! Ship It! - Lav Jain On April 29, 2016, 6:48 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46742/ > --- > > (Updated April 29, 2016, 6:48 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, and Lav Jain. > > > Bugs: AMBARI-16106 > https://issues.apache.org/jira/browse/AMBARI-16106 > > > Repository: ambari > > > Description > --- > > Make changes to HAWQ Check implementation based on HAWQ-668 > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py > 15ceaa2 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py > 76a5885 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 03323df > > Diff: https://reviews.apache.org/r/46742/diff/ > > > Testing > --- > > Manually tested. > > Added 15 unit tests. > > Ran unit tests: > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_remove_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Remove HAWQ Standby ... 2016-04-29 11:48:07,197 - Removing > HAWQ Standby Master ... > ok > test_resync_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Resync HAWQ Standby ... 2016-04-29 11:48:07,201 - HAWQ > Standby Master Re-Sync started in fast mode... > ok > test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not > Kerberized ... 2016-04-29 11:48:07,205 - Executing HAWQ Check ... > ok > test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, > Kerberized ... 2016-04-29 11:48:07,213 - Executing HAWQ Check ... > ok > test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not > Kerberized ... 2016-04-29 11:48:07,221 - Executing HAWQ Check ... > ok > test_run_hawq_check_case12 (test_hawqmaster
Review Request 46857: 'Restart All' for HAWQ should follow role_command_order
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46857/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Jayush Luniya, Matt, and Srimanth Gunturi. Bugs: AMBARI-16192 https://issues.apache.org/jira/browse/AMBARI-16192 Repository: ambari Description --- The current implementation in Ambari, 'Restart All' service action does not follow role_command_order. For example, all HAWQSEGMENTs start before HAWQMASTER and HAWQSTANDBY starts. Diffs - ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json da4146a Diff: https://reviews.apache.org/r/46857/diff/ Testing --- Tested manually. Thanks, Lav Jain
Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review131409 --- ambari-server/src/main/resources/stacks/stack_advisor.py (line 619) <https://reviews.apache.org/r/44210/#comment195368> This method is not being called because the corresponding method in 2.0.6 stack advisor is overriding it. - Lav Jain On April 29, 2016, 8:11 p.m., Tim Thorpe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44210/ > --- > > (Updated April 29, 2016, 8:11 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush > Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako. > > > Bugs: AMBARI-15226 > https://issues.apache.org/jira/browse/AMBARI-15226 > > > Repository: ambari > > > Description > --- > > Currently the stack advisor is defined under each stack version such as > HDP/2.3. The problem with this is that it restricts the services that can be > added to the stack. If a custom service is to be added, they would need to > modify the stack advisor. If the configuration recommendation and validation > can be done at the service level then the custom service could just include > their own recommendations and validations separately. > > > Diffs > - > > ambari-server/src/main/assemblies/server.xml e1a4919 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > df65010 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > 00c8696 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > ca1968e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java > 6c6fa91 > > ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java > 636de37 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java > 356adb1 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java > b7e09a9 > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java > d27e52a > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > 5a2bf84 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py > PRE-CREATION > ambari-server/src/main/resources/properties.json eac0dbd > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 1680f21 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > f475798 > ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION > ambari-server/src/main/resources/stacks/stack_advisor.py 9979e7e > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 2080c52 > > Diff: https://reviews.apache.org/r/44210/diff/ > > > Testing > --- > > Ran all the non java unit tests. > > Total run:945 > Total errors:0 > Total failures:0 > > Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure > their service advisors were called. > > > Thanks, > > Tim Thorpe > >
Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services
> On May 2, 2016, 11:07 p.m., Lav Jain wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py, line 644 > > <https://reviews.apache.org/r/44210/diff/6/?file=1367511#file1367511line644> > > > > This method is not being called because the corresponding method in > > 2.0.6 stack advisor is overriding it. > > Tim Thorpe wrote: > Hi Lav, I don't see the 2.0.6 stack advisor overriding this method (def > validateComponentLayout). It does override the method > getComponentLayoutValidations which gets called by validateComponentLayout > but in that method it calls super getComponentLayoutValidations first: > def getComponentLayoutValidations(self, services, hosts): > """Returns array of Validation objects about issues with hostnames > components assigned to""" > items = super(HDP206StackAdvisor, > self).getComponentLayoutValidations(services, hosts) Hi Tim, The method being overridden is getConfigurationsValidationItems(): https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py#L929-L956 - Lav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review131409 --- On May 3, 2016, 2:21 p.m., Tim Thorpe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44210/ > --- > > (Updated May 3, 2016, 2:21 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush > Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako. > > > Bugs: AMBARI-15226 > https://issues.apache.org/jira/browse/AMBARI-15226 > > > Repository: ambari > > > Description > --- > > Currently the stack advisor is defined under each stack version such as > HDP/2.3. The problem with this is that it restricts the services that can be > added to the stack. If a custom service is to be added, they would need to > modify the stack advisor. If the configuration recommendation and validation > can be done at the service level then the custom service could just include > their own recommendations and validations separately. > > > Diffs > - > > ambari-server/src/main/assemblies/server.xml e1a4919 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > df65010 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > 00c8696 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > ca1968e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java > 6c6fa91 > > ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java > 636de37 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java > 356adb1 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java > b7e09a9 > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java > d27e52a > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > 5a2bf84 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 1680f21 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > f475798 > ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION > ambari-server/src/main/resources/stacks/stack_advisor.py 9979e7e > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 2080c52 > > Diff: https://reviews.apache.org/r/44210/diff/ > > > Testing > --- > > Ran all the non java unit tests. > > Total run:945 > Total errors:0 > Total failures:0 > > Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure > their service advisors were called. > > > Thanks, > > Tim Thorpe > >
Re: Review Request 46996: HAWQ service can be stopped and checked even when STANDBY MASTER is stopped
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46996/#review131764 --- Ship it! Ship It! - Lav Jain On May 4, 2016, 11:52 p.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46996/ > --- > > (Updated May 4, 2016, 11:52 p.m.) > > > Review request for Ambari, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Lav > Jain, and Matt. > > > Bugs: AMBARI-16236 > https://issues.apache.org/jira/browse/AMBARI-16236 > > > Repository: ambari > > > Description > --- > > HAWQ service can be stopped and checked even when STANDBY MASTER is stopped > > > Diffs > - > > ambari-web/app/controllers/main/service/item.js bfede8a > ambari-web/test/controllers/main/service/item_test.js 4bac784 > > Diff: https://reviews.apache.org/r/46996/diff/ > > > Testing > --- > > manual. added unit tests: > > 27532 tests complete (29 seconds) > 154 tests pending > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 45.229 s > [INFO] Finished at: 2016-05-04T16:25:14-08:00 > > > Thanks, > > Alexander Denissov > >
Review Request 47138: stackadvisor uses getHostsForSlaveComponent with wrong parameter name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47138/ --- Review request for Ambari. Bugs: AMBARI-16378 https://issues.apache.org/jira/browse/AMBARI-16378 Repository: ambari Description --- ``` def getHostsForSlaveComponent(self, services, hosts, component, hostsList, hostsComponentsMap, freeHosts): componentName = component["StackServiceComponents"]["component_name"] if component["StackServiceComponents"]["cardinality"] == "ALL": return hostsList componentIsPopulated = self.isComponentHostsPopulated(component) if componentIsPopulated: return component["StackServiceComponents"]["hostnames"] hostsForComponent = [] if self.isSlaveComponent(component): cardinality = str(component["StackServiceComponents"]["cardinality"]) if self.isComponentUsingCardinalityForLayout(component) and cardinality: # cardinality types: 1+, 1-2, 1 ``` The correct parameter name is comonentName (instead of component) Diffs - ambari-server/src/main/resources/stacks/stack_advisor.py 00b9d79 Diff: https://reviews.apache.org/r/47138/diff/ Testing --- Tested manually Thanks, Lav Jain
Re: Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47160/#review132511 --- ambari-web/test/controllers/main/service/reassign/step6_controller_test.js (line 235) <https://reviews.apache.org/r/47160/#comment196731> +1 for comprehensive test code - Lav Jain On May 10, 2016, 7:26 a.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47160/ > --- > > (Updated May 10, 2016, 7:26 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, and Lav Jain. > > > Bugs: AMBARI-16419 > https://issues.apache.org/jira/browse/AMBARI-16419 > > > Repository: ambari > > > Description > --- > > After move NAMENODE wizard is executed, > - PXF should be installed on the target host. > - If the source host does not have a DATANODE, PXF should be removed from the > source host. > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step6_controller.js > f718d46 > ambari-web/app/messages.js e388526 > ambari-web/test/controllers/main/service/reassign/step6_controller_test.js > 89e2325 > > Diff: https://reviews.apache.org/r/47160/diff/ > > > Testing > --- > > Added unit tests. > > 27727 tests complete (25 seconds) > 154 tests pending > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 01:14 min > [INFO] Finished at: 2016-05-10T00:20:54-07:00 > [INFO] Final Memory: 12M/310M > [INFO] > > > > Thanks, > > Matt > >
Re: Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47160/#review132512 --- Ship it! Ship It! - Lav Jain On May 10, 2016, 7:26 a.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47160/ > --- > > (Updated May 10, 2016, 7:26 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, and Lav Jain. > > > Bugs: AMBARI-16419 > https://issues.apache.org/jira/browse/AMBARI-16419 > > > Repository: ambari > > > Description > --- > > After move NAMENODE wizard is executed, > - PXF should be installed on the target host. > - If the source host does not have a DATANODE, PXF should be removed from the > source host. > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step6_controller.js > f718d46 > ambari-web/app/messages.js e388526 > ambari-web/test/controllers/main/service/reassign/step6_controller_test.js > 89e2325 > > Diff: https://reviews.apache.org/r/47160/diff/ > > > Testing > --- > > Added unit tests. > > 27727 tests complete (25 seconds) > 154 tests pending > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 01:14 min > [INFO] Finished at: 2016-05-10T00:20:54-07:00 > [INFO] Final Memory: 12M/310M > [INFO] > > > > Thanks, > > Matt > >
Re: Review Request 47156: More information for Standby sync alert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/#review132547
---
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
(line 93)
<https://reviews.apache.org/r/47156/#comment196768>
Please try to use one SQL statement. Delimiter can be defined using -F
option. E.g.:
```
source /usr/local/hawq/greenplum_path.sh && psql -F $'##' --no-align -t -d
template1 -c "SELECT summary_state, error_message FROM gp_master_mirroring"
Not Synchronized##error received sending data to standby master: server
closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
```
- Lav Jain
On May 10, 2016, 4:27 a.m., jun aoki wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47156/
> ---
>
> (Updated May 10, 2016, 4:27 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-16417
> https://issues.apache.org/jira/browse/AMBARI-16417
>
>
> Repository: ambari
>
>
> Description
> ---
>
> When Standby master is down (actually I removed it through API, and it got
> deleted but somehow the configuration has the old IP) the hawq alert pops
> up(, which is good) but only saying "HAWQSTANDBY is not in sync with
> HAWQMASTER".
>
> If you take a close look at gp_master_mirroring table, it has more detailed
> information. (in this case, connection issue)
> {code}
> [gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from
> gp_master_mirroring;"
> summary_state | detail_state |log_time|
>error_message
> --+--++--
> Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error
> received sending data to standby master: server closed the connection
> unexpectedly
> : This
> probably means the server terminated abnormally
> :
> before or while processing the request.
> :
> (1 row)
> {code}
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
> c94be9e
>
> Diff: https://reviews.apache.org/r/47156/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 47156: More information for Standby sync alert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/#review132557
---
Ship it!
Ship It!
- Lav Jain
On May 10, 2016, 10:22 p.m., jun aoki wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47156/
> ---
>
> (Updated May 10, 2016, 10:22 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-16417
> https://issues.apache.org/jira/browse/AMBARI-16417
>
>
> Repository: ambari
>
>
> Description
> ---
>
> When Standby master is down (actually I removed it through API, and it got
> deleted but somehow the configuration has the old IP) the hawq alert pops
> up(, which is good) but only saying "HAWQSTANDBY is not in sync with
> HAWQMASTER".
>
> If you take a close look at gp_master_mirroring table, it has more detailed
> information. (in this case, connection issue)
> {code}
> [gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from
> gp_master_mirroring;"
> summary_state | detail_state |log_time|
>error_message
> --+--++--
> Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error
> received sending data to standby master: server closed the connection
> unexpectedly
> : This
> probably means the server terminated abnormally
> :
> before or while processing the request.
> :
> (1 row)
> {code}
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
> c94be9e
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py
> 7d030dc
>
> Diff: https://reviews.apache.org/r/47156/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47252/#review132794 --- Ship it! Ship It! - Lav Jain On May 11, 2016, 7:04 p.m., Goutam Tadi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47252/ > --- > > (Updated May 11, 2016, 7:04 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, > Lav Jain, and Matt. > > > Bugs: AMBARI-16461 > https://issues.apache.org/jira/browse/AMBARI-16461 > > > Repository: ambari > > > Description > --- > > PXF Agents Live Widget on Dashboard needs custom widget to display only > single threshold i.e., Green/Red only > > > Diffs > - > > ambari-web/app/messages.js c5e1145 > ambari-web/app/mixins.js cf8cef6 > ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 97b6330 > ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js > PRE-CREATION > ambari-web/app/styles/modal_popups.less 5e89dbc > > ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs > PRE-CREATION > ambari-web/app/views.js 127a996 > ambari-web/app/views/main/dashboard/widgets.js 38181c0 > ambari-web/app/views/main/dashboard/widgets/pxf_live.js 75f5886 > ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/47252/diff/ > > > Testing > --- > > Yes, All tests passed. Test was already in place. > > > Thanks, > > Goutam Tadi > >
Re: Review Request 47277: hawq_ssh_exkeys config should be a checkbox on UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47277/#review132809 --- Ship it! Ship It! - Lav Jain On May 12, 2016, 1:05 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47277/ > --- > > (Updated May 12, 2016, 1:05 a.m.) > > > Review request for Ambari, Alexander Denissov, jun aoki, and Matt. > > > Bugs: AMBARI-16624 > https://issues.apache.org/jira/browse/AMBARI-16624 > > > Repository: ambari > > > Description > --- > > hawq_ssh_exkeys config should be a checkbox on UI. Currently it accepts a > string. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml > d2da5b2 > > Diff: https://reviews.apache.org/r/47277/diff/ > > > Testing > --- > > yes. manual. > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 47564: Activate HAWQSTANDBY fails on retry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47564/#review133857 --- ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py (line 197) <https://reviews.apache.org/r/47564/#comment198505> You may want to take this opportunity to refactor the test code. ExecuteScript can be a separate function with command passed in as parameter. Similarily, common.stop_component can be refactored into a separate function with both test_stop_default and test_activate_hawq_standby calling it. If you want to go one step further, create a base class of TestHawqCommon(RMFTestCase) that defines the corresponding routines in common.py with TestHawqStandby(TestHawqCommon). assertResourceCalled can be defined using functools.partial - Lav Jain On May 18, 2016, 11:28 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47564/ > --- > > (Updated May 18, 2016, 11:28 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16750 > https://issues.apache.org/jira/browse/AMBARI-16750 > > > Repository: ambari > > > Description > --- > > If wizard failed on the Activate Standby step, retrying the step would cause > a failure, because the master hosts have been switched already in the > configuration. > Resolution: Before retrying the command, rewrite the configuration with > current topology. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py > 45dcff0 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py e247d28 > > Diff: https://reviews.apache.org/r/47564/diff/ > > > Testing > --- > > Manually Tested. > > Added unit test. > > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_remove_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Remove HAWQ Standby ... 2016-05-18 16:27:14,657 - Removing > HAWQ Standby Master ... > ok > test_resync_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Resync HAWQ Standby ... 2016-05-18 16:27:14,661 - HAWQ > Standby Master Re-Sync started i
Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47580/#review133974 --- ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py (line 29) <https://reviews.apache.org/r/47580/#comment198646> Not sure if loading of PXFServiceAdvisor is necessary. The test should call stackAdvisor directly and that should automatically load PXF service advisor for the corresponding routines. - Lav Jain On May 19, 2016, 6:11 a.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47580/ > --- > > (Updated May 19, 2016, 6:11 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16752 > https://issues.apache.org/jira/browse/AMBARI-16752 > > > Repository: ambari > > > Description > --- > > In service install wizard, pxf-hbase.jar should be added to the > HBASE_CLASSPATH (recommendation and validation) > > > Diffs > - > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py > e2510eb > ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/47580/diff/ > > > Testing > --- > > Manually Tested. > > Unit tests added. > > Hadoop QA: > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12804840/AMBARI-16752-trunk-orig.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6889//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6889//console > This message is automatically generated. > ``` > > > Thanks, > > Matt > >
Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47580/#review133985 --- Should we create a services/PXF directory under ambari-server/src/test/python/stacks or continue to put the common-services tests under 2.3 stack? - Lav Jain On May 19, 2016, 6:11 a.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47580/ > --- > > (Updated May 19, 2016, 6:11 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16752 > https://issues.apache.org/jira/browse/AMBARI-16752 > > > Repository: ambari > > > Description > --- > > In service install wizard, pxf-hbase.jar should be added to the > HBASE_CLASSPATH (recommendation and validation) > > > Diffs > - > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py > e2510eb > ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/47580/diff/ > > > Testing > --- > > Manually Tested. > > Unit tests added. > > Hadoop QA: > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12804840/AMBARI-16752-trunk-orig.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6889//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6889//console > This message is automatically generated. > ``` > > > Thanks, > > Matt > >
Re: Review Request 47379: PXF operations considers the agent status
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47379/#review134003 --- ambari-web/app/models/host_component.js (line 298) <https://reviews.apache.org/r/47379/#comment198663> The logic for disabled can be extracted into a separate function. - Lav Jain On May 14, 2016, 12:27 a.m., Goutam Tadi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47379/ > --- > > (Updated May 14, 2016, 12:27 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, > Lav Jain, and Matt. > > > Bugs: AMBARI-16670 > https://issues.apache.org/jira/browse/AMBARI-16670 > > > Repository: ambari > > > Description > --- > > PXF operations considers the agent status > > > Diffs > - > > ambari-web/app/controllers/main/service/item.js 9250bfc > ambari-web/app/models/host_component.js 569879f > ambari-web/test/controllers/main/service/item_test.js 383aa2f > > Diff: https://reviews.apache.org/r/47379/diff/ > > > Testing > --- > > Yes. > > User should be able to do the following ops on PXF: > Start PXF slaves if one or more slaves are down > Stop PXF slaves if one or more slaves are up > Start disabled if all agents are up > Stop disabled if all agents are down > Service Check disabled if one or more slaves are down > Service Check enabled if all agents are up > > > Thanks, > > Goutam Tadi > >
Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47580/#review134019 --- Ship it! Ship It! - Lav Jain On May 19, 2016, 6:58 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47580/ > --- > > (Updated May 19, 2016, 6:58 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16752 > https://issues.apache.org/jira/browse/AMBARI-16752 > > > Repository: ambari > > > Description > --- > > In service install wizard, pxf-hbase.jar should be added to the > HBASE_CLASSPATH (recommendation and validation) > > > Diffs > - > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py > e2510eb > ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/47580/diff/ > > > Testing > --- > > Manually Tested. > > Unit tests added. > > ``` > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_sparkts_no_hive > (test_stack_advisor.TestHDP23StackAdvisor) > Test Sp
Re: Review Request 47379: PXF operations considers the agent status
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47379/#review134021 --- ambari-web/app/controllers/main/service/item.js (line 1000) <https://reviews.apache.org/r/47379/#comment198678> Does it make sense to create isServiceCheckDisabled function here and move the PXF logic from host_component.js? - Lav Jain On May 14, 2016, 12:27 a.m., Goutam Tadi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47379/ > --- > > (Updated May 14, 2016, 12:27 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, > Lav Jain, and Matt. > > > Bugs: AMBARI-16670 > https://issues.apache.org/jira/browse/AMBARI-16670 > > > Repository: ambari > > > Description > --- > > PXF operations considers the agent status > > > Diffs > - > > ambari-web/app/controllers/main/service/item.js 9250bfc > ambari-web/app/models/host_component.js 569879f > ambari-web/test/controllers/main/service/item_test.js 383aa2f > > Diff: https://reviews.apache.org/r/47379/diff/ > > > Testing > --- > > Yes. > > User should be able to do the following ops on PXF: > Start PXF slaves if one or more slaves are down > Stop PXF slaves if one or more slaves are up > Start disabled if all agents are up > Stop disabled if all agents are down > Service Check disabled if one or more slaves are down > Service Check enabled if all agents are up > > > Thanks, > > Goutam Tadi > >
Re: Review Request 47379: PXF operations considers the agent status
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47379/#review134022 --- ambari-web/app/controllers/main/service/item.js (line 1008) <https://reviews.apache.org/r/47379/#comment198679> App.HostComponentStatus.started instead of 'STARTED' (in case the constant is updated to include 'STARTING') - Lav Jain On May 14, 2016, 12:27 a.m., Goutam Tadi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47379/ > --- > > (Updated May 14, 2016, 12:27 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, > Lav Jain, and Matt. > > > Bugs: AMBARI-16670 > https://issues.apache.org/jira/browse/AMBARI-16670 > > > Repository: ambari > > > Description > --- > > PXF operations considers the agent status > > > Diffs > - > > ambari-web/app/controllers/main/service/item.js 9250bfc > ambari-web/app/models/host_component.js 569879f > ambari-web/test/controllers/main/service/item_test.js 383aa2f > > Diff: https://reviews.apache.org/r/47379/diff/ > > > Testing > --- > > Yes. > > User should be able to do the following ops on PXF: > Start PXF slaves if one or more slaves are down > Stop PXF slaves if one or more slaves are up > Start disabled if all agents are up > Stop disabled if all agents are down > Service Check disabled if one or more slaves are down > Service Check enabled if all agents are up > > > Thanks, > > Goutam Tadi > >
Re: Review Request 47616: Remove ams-ssl-client from HAWQ metainfo.xml
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47616/#review134055 --- Ship it! Ship It! - Lav Jain On May 19, 2016, 9:50 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47616/ > --- > > (Updated May 19, 2016, 9:50 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16783 > https://issues.apache.org/jira/browse/AMBARI-16783 > > > Repository: ambari > > > Description > --- > > Remove ams-ssl-client from HAWQ metainfo.xml > > > Diffs > - > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml > 1ea2ed1 > > Diff: https://reviews.apache.org/r/47616/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Matt > >
Re: Review Request 47657: Hawq password to use !h flag to ensure that its only hidden and no special processing is done for it.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47657/#review134207 --- Ship it! Ship It! - Lav Jain On May 20, 2016, 6:59 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47657/ > --- > > (Updated May 20, 2016, 6:59 p.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-16800 > https://issues.apache.org/jira/browse/AMBARI-16800 > > > Repository: ambari > > > Description > --- > > Hawq password to use !h flag to ensure that its only hidden and no special > processing is done for it. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py > b52b477 > > Diff: https://reviews.apache.org/r/47657/diff/ > > > Testing > --- > > yes. > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 47627: hawq_standby_address_host property should be removed from configuration if HAWQSTANDBY component does not exist in BP
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47627/#review134208
---
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
(line 7244)
<https://reviews.apache.org/r/47627/#comment198844>
hawqSite.containsKey("hawq_standby_address_host")
- Lav Jain
On May 20, 2016, 2:09 a.m., bhuvnesh chaudhary wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47627/
> ---
>
> (Updated May 20, 2016, 2:09 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Matt, and Robert Nettleton.
>
>
> Bugs: AMBARI-16786
> https://issues.apache.org/jira/browse/AMBARI-16786
>
>
> Repository: ambari
>
>
> Description
> ---
>
> hawq_standby_address_host property should be removed from configuration if
> HAWQSTANDBY component does not exist in BP
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> 1ddc4e1
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
> 5c6aeaf
>
> Diff: https://reviews.apache.org/r/47627/diff/
>
>
> Testing
> ---
>
> yes. test case added.
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 47627: hawq_standby_address_host property should be removed from configuration if HAWQSTANDBY component does not exist in BP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47627/#review134209 --- Ship it! Ship It! - Lav Jain On May 20, 2016, 10:11 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47627/ > --- > > (Updated May 20, 2016, 10:11 p.m.) > > > Review request for Ambari, Alexander Denissov, Matt, and Robert Nettleton. > > > Bugs: AMBARI-16786 > https://issues.apache.org/jira/browse/AMBARI-16786 > > > Repository: ambari > > > Description > --- > > hawq_standby_address_host property should be removed from configuration if > HAWQSTANDBY component does not exist in BP > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 1ddc4e1 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 5c6aeaf > > Diff: https://reviews.apache.org/r/47627/diff/ > > > Testing > --- > > yes. test case added. > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 47642: Add HAWQ Standby wizard should recommend HAWQSTANDBY correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47642/#review134212 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py (line 56) <https://reviews.apache.org/r/47642/#comment198845> return list(ambariServerHost) - Lav Jain On May 20, 2016, 8:13 a.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47642/ > --- > > (Updated May 20, 2016, 8:13 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16790 > https://issues.apache.org/jira/browse/AMBARI-16790 > > > Repository: ambari > > > Description > --- > > On assign masters page of Add HAWQ Standby wizard, a best effort should be > made such that HAWQSTANDBY is not co-located with HAWQMASTER or AMBARI_SERVER. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 0590604 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 905d455 > > Diff: https://reviews.apache.org/r/47642/diff/ > > > Testing > --- > > Manually tested. > > Added unit tests: > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn > (test_stack_advisor.TestHDP23StackAdvisor)
Re: Review Request 47749: Warning for HAWQSTANDBY does not show up on Assign Masters page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47749/#review134490 --- Ship it! Ship It! - Lav Jain On May 23, 2016, 11:44 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47749/ > --- > > (Updated May 23, 2016, 11:44 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16829 > https://issues.apache.org/jira/browse/AMBARI-16829 > > > Repository: ambari > > > Description > --- > > Warning for HAWQSTANDBY does not show up on Assign Masters page > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > c5813ad > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > c33a223 > > Diff: https://reviews.apache.org/r/47749/diff/ > > > Testing > --- > > Manually tested. > > Added new test case. > > ``` > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_sparkts_no_hive > (test_stack_advisor.TestHDP23StackAdvisor) > Test SparkTS is picked when Hive is not installed ... ok > t
Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/#review134670 --- Ship it! Ship It! - Lav Jain On May 25, 2016, 12:17 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47802/ > --- > > (Updated May 25, 2016, 12:17 a.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-16827 > https://issues.apache.org/jira/browse/AMBARI-16827 > > > Repository: ambari > > > Description > --- > > expose vm.overcommit_ratio on hawq-sysctl-env > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml > c51b012 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 836144c > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json > e4d1c45 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 53c5574 > > Diff: https://reviews.apache.org/r/47802/diff/ > > > Testing > --- > > yes. test case added. > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 47840: Change location of HAWQ tmp directories
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47840/#review134807 --- Change also needed in https://github.com/Pivotal-DataFabric/ambari/blob/trunk/ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py#L43 - Lav Jain On May 25, 2016, 6:37 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47840/ > --- > > (Updated May 25, 2016, 6:37 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16885 > https://issues.apache.org/jira/browse/AMBARI-16885 > > > Repository: ambari > > > Description > --- > > Update HAWQ temp directories to /data/hawq/tmp/master and > /data/hawq/tmp/segment respectively > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > c3b1f82 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 5cf2d2f > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py fde5fd3 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 4e2a9cd > ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json 36513c5 > > Diff: https://reviews.apache.org/r/47840/diff/ > > > Testing > --- > > Updated unit tests: > ``` > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is n
Re: Review Request 47840: Change location of HAWQ tmp directories
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47840/#review134817 --- Ship it! Ship It! - Lav Jain On May 25, 2016, 7:25 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47840/ > --- > > (Updated May 25, 2016, 7:25 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16885 > https://issues.apache.org/jira/browse/AMBARI-16885 > > > Repository: ambari > > > Description > --- > > Update HAWQ temp directories to /data/hawq/tmp/master and > /data/hawq/tmp/segment respectively > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > c3b1f82 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py > 919d7d8 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 5cf2d2f > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py fde5fd3 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 4e2a9cd > ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json 36513c5 > > Diff: https://reviews.apache.org/r/47840/diff/ > > > Testing > --- > > Updated unit tests: > ``` > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE ... ok > test_getComponentLayoutVali
Review Request 47858: Cache service advisors when stack advisor is loaded
HawqMaster) Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, Kerberized ... 2016-05-26 11:47:27,528 - Executing HAWQ Check ... ok test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not Kerberized ... 2016-05-26 11:47:27,535 - Executing HAWQ Check ... ok test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, Kerberized ... 2016-05-26 11:47:27,541 - Executing HAWQ Check ... ok test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, Kerberized ... 2016-05-26 11:47:27,553 - Executing HAWQ Check ... ok test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-05-26 11:47:27,561 - Executing HAWQ Check ... ok test_run_hawq_check_case4 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Management Non YARN_HA, Kerberized ... 2016-05-26 11:47:27,567 - Executing HAWQ Check ... ok test_run_hawq_check_case5 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 5: Non HDFS-HA, YARN Resource Management YARN_HA, Not Kerberized ... 2016-05-26 11:47:27,573 - Executing HAWQ Check ... ok test_run_hawq_check_case6 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 6: Non HDFS-HA, YARN Resource Management YARN_HA, Kerberized ... 2016-05-26 11:47:27,579 - Executing HAWQ Check ... ok test_run_hawq_check_case7 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 7: HDFS-HA, Standalone Resource Management, Not Kerberized ... 2016-05-26 11:47:27,591 - Executing HAWQ Check ... ok test_run_hawq_check_case8 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 8: HDFS-HA, Standalone Resource Management, Kerberized ... 2016-05-26 11:47:27,598 - Executing HAWQ Check ... ok test_run_hawq_check_case9 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 9: HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-05-26 11:47:27,605 - Executing HAWQ Check ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-05-26 11:47:27,613 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_cluster_immediate (test_hawqmaster.TestHawqMaster) Run Stop HAWQ Cluster Immediate Mode ... ok test_stop_default (test_hawqmaster.TestHawqMaster) Run Stop HAWQMASTER ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_activate_hawq_standby (test_hawqstandby.TestHawqStandby) Test Activate HAWQ Standby Command ... 2016-05-26 11:47:27,675 - Activating HAWQ standby... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok test_getHostsForMasterComponent (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_getServiceConfigurationRecommendations (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 53 tests in 0.470s OK Thanks, Lav Jain
Re: Review Request 47926: Use postgres database instead of template1 during service check in HAWQ
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47926/#review135116 --- Ship it! Ship It! - Lav Jain On May 26, 2016, 11:24 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47926/ > --- > > (Updated May 26, 2016, 11:24 p.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-16917 > https://issues.apache.org/jira/browse/AMBARI-16917 > > > Repository: ambari > > > Description > --- > > Use postgres database instead of template1 during service check in HAWQ. > template1 database is used as a default template while creating new > databases, so anything in template1 gets carried over to the new database. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py > 17724bc > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py > e916f07 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py > 4a75a78 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py > f37b13f > > Diff: https://reviews.apache.org/r/47926/diff/ > > > Testing > --- > > yes. > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 47858: Cache service advisors when stack advisor is loaded
eck_case10 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, Kerberized ... 2016-05-26 11:47:27,528 - Executing HAWQ Check ... ok test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not Kerberized ... 2016-05-26 11:47:27,535 - Executing HAWQ Check ... ok test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, Kerberized ... 2016-05-26 11:47:27,541 - Executing HAWQ Check ... ok test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, Kerberized ... 2016-05-26 11:47:27,553 - Executing HAWQ Check ... ok test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-05-26 11:47:27,561 - Executing HAWQ Check ... ok test_run_hawq_check_case4 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Management Non YARN_HA, Kerberized ... 2016-05-26 11:47:27,567 - Executing HAWQ Check ... ok test_run_hawq_check_case5 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 5: Non HDFS-HA, YARN Resource Management YARN_HA, Not Kerberized ... 2016-05-26 11:47:27,573 - Executing HAWQ Check ... ok test_run_hawq_check_case6 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 6: Non HDFS-HA, YARN Resource Management YARN_HA, Kerberized ... 2016-05-26 11:47:27,579 - Executing HAWQ Check ... ok test_run_hawq_check_case7 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 7: HDFS-HA, Standalone Resource Management, Not Kerberized ... 2016-05-26 11:47:27,591 - Executing HAWQ Check ... ok test_run_hawq_check_case8 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 8: HDFS-HA, Standalone Resource Management, Kerberized ... 2016-05-26 11:47:27,598 - Executing HAWQ Check ... ok test_run_hawq_check_case9 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 9: HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-05-26 11:47:27,605 - Executing HAWQ Check ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-05-26 11:47:27,613 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_cluster_immediate (test_hawqmaster.TestHawqMaster) Run Stop HAWQ Cluster Immediate Mode ... ok test_stop_default (test_hawqmaster.TestHawqMaster) Run Stop HAWQMASTER ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_activate_hawq_standby (test_hawqstandby.TestHawqStandby) Test Activate HAWQ Standby Command ... 2016-05-26 11:47:27,675 - Activating HAWQ standby... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok test_getHostsForMasterComponent (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_getServiceConfigurationRecommendations (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 53 tests in 0.470s OK Thanks, Lav Jain
Re: Review Request 47975: BP deploy to put default password for hawq_password
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47975/#review135306 --- Ship it! Ship It! - Lav Jain On May 27, 2016, 7:48 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47975/ > --- > > (Updated May 27, 2016, 7:48 p.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-16936 > https://issues.apache.org/jira/browse/AMBARI-16936 > > > Repository: ambari > > > Description > --- > > BP deploy to put default password for hawq_password > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml > 56d2b26 > > Diff: https://reviews.apache.org/r/47975/diff/ > > > Testing > --- > > yes. > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 48091: Update derivation of hawq_rm_memory_limit_perseg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48091/#review135814 --- Ship it! Ship It! - Lav Jain On May 31, 2016, 8:31 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48091/ > --- > > (Updated May 31, 2016, 8:31 p.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-16970 > https://issues.apache.org/jira/browse/AMBARI-16970 > > > Repository: ambari > > > Description > --- > > Update derivation of hawq_rm_memory_limit_perseg. It should be calculated > based on vm.overcommit_ratio, vm.overcommit_memory and the available system > memory. It should also have a default value. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > b096702 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml > 2ec145f > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > a634062 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 1d6a85c > > Diff: https://reviews.apache.org/r/48091/diff/ > > > Testing > --- > > yes test case updated. > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 48194: Update name of PXF component to PXF Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48194/#review136025 --- Ship it! Ship It! - Lav Jain On June 3, 2016, 1:10 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48194/ > --- > > (Updated June 3, 2016, 1:10 a.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-17024 > https://issues.apache.org/jira/browse/AMBARI-17024 > > > Repository: ambari > > > Description > --- > > Update name of PXF component to PXF Agent > > > Diffs > - > > ambari-server/src/main/resources/common-services/PXF/3.0.0/metainfo.xml > ba1c58e > > Diff: https://reviews.apache.org/r/48194/diff/ > > > Testing > --- > > yes. > > > Thanks, > > bhuvnesh chaudhary > >
Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor
visor.TestHAWQ200ServiceAdvisor) ...
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org', 'c6404.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org', 'c6404.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org']
['c6401.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org']
ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok
--
Ran 53 tests in 0.982s
test_execute (test_alerts_api_status.TestAlertsApiStatus) ... No handlers could
be found for logger "ambari_alerts"
ok
test_get_pxf_protocol_version (test_alerts_api_status.TestAlertsApiStatus) ...
ok
test_configure_default (test_pxf.TestPxf) ... ok
test_install_default (test_pxf.TestPxf) ... ok
test_start_default (test_pxf.TestPxf) ... ok
test_status_default (test_pxf.TestPxf) ... ok
test_stop_default (test_pxf.TestPxf) ... ok
test_getConfigurationsValidationItems
(test_service_advisor.TestPXF300ServiceAdvisor) ... SiteName: hbase-env,
method: validatePXFHBaseEnvConfigurations
Site properties: {'content': '# Some hbase-env content text'}
Recommendations: {'content': '# Some hbase-env content text'}
ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestPXF300ServiceAdvisor) ... ok
--
Ran 9 tests in 0.027s
OK
Thanks,
Lav Jain
Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor
est_stop_default (test_hawqstandby.TestHawqStandby) ... ok
test_getHostsForMasterComponent
(test_service_advisor.TestHAWQ200ServiceAdvisor) ...
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org', 'c6404.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org', 'c6404.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org']
['c6401.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org']
ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok
--
Ran 53 tests in 0.982s
test_execute (test_alerts_api_status.TestAlertsApiStatus) ... No handlers could
be found for logger "ambari_alerts"
ok
test_get_pxf_protocol_version (test_alerts_api_status.TestAlertsApiStatus) ...
ok
test_configure_default (test_pxf.TestPxf) ... ok
test_install_default (test_pxf.TestPxf) ... ok
test_start_default (test_pxf.TestPxf) ... ok
test_status_default (test_pxf.TestPxf) ... ok
test_stop_default (test_pxf.TestPxf) ... ok
test_getConfigurationsValidationItems
(test_service_advisor.TestPXF300ServiceAdvisor) ... SiteName: hbase-env,
method: validatePXFHBaseEnvConfigurations
Site properties: {'content': '# Some hbase-env content text'}
Recommendations: {'content': '# Some hbase-env content text'}
ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestPXF300ServiceAdvisor) ... ok
--
Ran 9 tests in 0.027s
OK
Thanks,
Lav Jain
Re: Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48235/#review136150 --- ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py <https://reviews.apache.org/r/48235/#comment201175> hawq_rm_nvcore_limit_perseg (same for hawq_rm_memory_limit_perseg) should be set only when rm_type is none. Any particular reason for removing this test? - Lav Jain On June 3, 2016, 10:49 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48235/ > --- > > (Updated June 3, 2016, 10:49 p.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-17023 > https://issues.apache.org/jira/browse/AMBARI-17023 > > > Repository: ambari > > > Description > --- > > Show only relevant properties based on the status of HAWQ Resource Manager. > When Yarn mode is enable, only two parameters should be invisible. > hawq_rm_memory_limit_perseg > hawq_rm_nvcore_limit_perseg > When standalone mode is enabled, four parameters should be invisible. what > you list are correct. > hawq_rm_yarn_app_name > hawq_rm_yarn_queue_name > hawq_rm_yarn_scheduler_address > hawq_rm_yarn_address > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 3ac4e89 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 28eb82f > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 5750938 > > Diff: https://reviews.apache.org/r/48235/diff/ > > > Testing > --- > > yes. > Now testing > /Users/bhuvneshchaudhary/github/ambari-toolbox/vagrant/ambari/ambari-server/src/test/python/stacks/2.3/HAWQ > ~/github/ambari-toolbox/vagrant/ambari/ambari-server/src/test/python/stacks/2.3/HAWQ > ~/github/ambari-toolbox/vagrant/ambari > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_remove_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Remove HAWQ Standby ... 2016-06-03 15:50:22,295 - Removing > HAWQ Standby Master ... > ok > test_resync_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Resync HAWQ Standby ...
Re: Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48235/#review136151 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py (line 179) <https://reviews.apache.org/r/48235/#comment201176> Minor! Line 179 can be moved next to line 212. - Lav Jain On June 3, 2016, 10:49 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48235/ > --- > > (Updated June 3, 2016, 10:49 p.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-17023 > https://issues.apache.org/jira/browse/AMBARI-17023 > > > Repository: ambari > > > Description > --- > > Show only relevant properties based on the status of HAWQ Resource Manager. > When Yarn mode is enable, only two parameters should be invisible. > hawq_rm_memory_limit_perseg > hawq_rm_nvcore_limit_perseg > When standalone mode is enabled, four parameters should be invisible. what > you list are correct. > hawq_rm_yarn_app_name > hawq_rm_yarn_queue_name > hawq_rm_yarn_scheduler_address > hawq_rm_yarn_address > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 3ac4e89 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 28eb82f > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 5750938 > > Diff: https://reviews.apache.org/r/48235/diff/ > > > Testing > --- > > yes. > Now testing > /Users/bhuvneshchaudhary/github/ambari-toolbox/vagrant/ambari/ambari-server/src/test/python/stacks/2.3/HAWQ > ~/github/ambari-toolbox/vagrant/ambari/ambari-server/src/test/python/stacks/2.3/HAWQ > ~/github/ambari-toolbox/vagrant/ambari > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_remove_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Remove HAWQ Standby ... 2016-06-03 15:50:22,295 - Removing > HAWQ Standby Master ... > ok > test_resync_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Resync HAWQ Standby ... 2016-06-03 15:50:22,301 - HAWQ > Standby Master Re-Sync started in fast mode... &
Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor
dby) ... ok
test_start_default (test_hawqstandby.TestHawqStandby) ... ok
test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
test_getHostsForMasterComponent
(test_service_advisor.TestHAWQ200ServiceAdvisor) ...
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org', 'c6404.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org', 'c6404.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org']
['c6401.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org']
ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok
--
Ran 53 tests in 0.982s
test_execute (test_alerts_api_status.TestAlertsApiStatus) ... No handlers could
be found for logger "ambari_alerts"
ok
test_get_pxf_protocol_version (test_alerts_api_status.TestAlertsApiStatus) ...
ok
test_configure_default (test_pxf.TestPxf) ... ok
test_install_default (test_pxf.TestPxf) ... ok
test_start_default (test_pxf.TestPxf) ... ok
test_status_default (test_pxf.TestPxf) ... ok
test_stop_default (test_pxf.TestPxf) ... ok
test_getConfigurationsValidationItems
(test_service_advisor.TestPXF300ServiceAdvisor) ... SiteName: hbase-env,
method: validatePXFHBaseEnvConfigurations
Site properties: {'content': '# Some hbase-env content text'}
Recommendations: {'content': '# Some hbase-env content text'}
ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestPXF300ServiceAdvisor) ... ok
--
Ran 9 tests in 0.027s
OK
Thanks,
Lav Jain
Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor
> On June 6, 2016, 12:43 p.m., Tim Thorpe wrote: > > ambari-server/src/main/resources/stacks/service_advisor.py, line 67 > > <https://reviews.apache.org/r/48229/diff/3/?file=1406751#file1406751line67> > > > > I originally had implemented the service advisor like this. I had > > modified it specifically NOT to inherit from the DefaultStackAdvisor after > > comments suggesting that the inheritance didn't make sense. > > > > The way I see it both the stack advisor and service advisor should > > inherit the core functions from a generic advisor but this implementation > > is the easiest. There seems to be a lot of duplicate code and this effort is streamlining it with minimal intrusion to the stack advisor. - Lav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/#review136240 ------- On June 5, 2016, 10:18 p.m., Lav Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48229/ > --- > > (Updated June 5, 2016, 10:18 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush > Luniya, Matt, and Tim Thorpe. > > > Bugs: AMBARI-16663 > https://issues.apache.org/jira/browse/AMBARI-16663 > > > Repository: ambari > > > Description > --- > > The original intent was to move the common functions that are used by both > stack and service advisors to a separate utils file to avoid passing > stack_advisor class into service advisor apis. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 28eb82f > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py > 9b34171 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 1dedf3d > ambari-server/src/main/resources/stacks/service_advisor.py 3d6c293 > ambari-server/src/main/resources/stacks/stack_advisor.py beba225 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 5750938 > ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py > c3a63cc > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 424a386 > > Diff: https://reviews.apache.org/r/48229/diff/ > > > Testing > --- > > Lavs-MacBook-Pro:common ljain$ python -m discover -v > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation > for service HAWQ was loaded > [u'c6401.ambari.apache.org'] > [u'c6401.ambari.apache.org'] > ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor > implementation for service HAWQ was loaded > [u'c6401.ambari.apache.org', u'c6402.ambari.apache.org', > u'c6403.ambari.apache.org'] > [u'c6401.ambari.apache.org', u'c6402.ambari.apache.org', > u'c6403.ambari.apache.org'] > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ServiceAdvisor implementation for > service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ServiceAdvisor implementation for > service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ServiceAdvisor > implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during
Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor
tandby.TestHawqStandby) ... ok
test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
test_getHostsForMasterComponent
(test_service_advisor.TestHAWQ200ServiceAdvisor) ...
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org', 'c6404.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org', 'c6404.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org']
['c6401.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org']
ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok
--
Ran 53 tests in 0.982s
test_execute (test_alerts_api_status.TestAlertsApiStatus) ... No handlers could
be found for logger "ambari_alerts"
ok
test_get_pxf_protocol_version (test_alerts_api_status.TestAlertsApiStatus) ...
ok
test_configure_default (test_pxf.TestPxf) ... ok
test_install_default (test_pxf.TestPxf) ... ok
test_start_default (test_pxf.TestPxf) ... ok
test_status_default (test_pxf.TestPxf) ... ok
test_stop_default (test_pxf.TestPxf) ... ok
test_getConfigurationsValidationItems
(test_service_advisor.TestPXF300ServiceAdvisor) ... SiteName: hbase-env,
method: validatePXFHBaseEnvConfigurations
Site properties: {'content': '# Some hbase-env content text'}
Recommendations: {'content': '# Some hbase-env content text'}
ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestPXF300ServiceAdvisor) ... ok
--
Ran 9 tests in 0.027s
OK
Thanks,
Lav Jain
Re: Review Request 48290: Change HAWQ DFS Url from hawq_default to hawq_data
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48290/#review136395 --- Ship it! Ship It! - Lav Jain On June 6, 2016, 7:17 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48290/ > --- > > (Updated June 6, 2016, 7:17 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-17070 > https://issues.apache.org/jira/browse/AMBARI-17070 > > > Repository: ambari > > > Description > --- > > Change HAWQ DFS Url from hawq_default to hawq_data > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 3ac4e89 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py > a8a4487 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > ec04fd2 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 70d7ed1 > ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json b839de6 > ambari-web/app/data/HDP2/ha_properties.js 18c5a68 > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js > ca55a32 > ambari-web/test/utils/configs/config_initializer_test.js 48eae23 > > Diff: https://reviews.apache.org/r/48290/diff/ > > > Testing > --- > > Waiting for results from Hadoop QA > > > Thanks, > > Matt > >
Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor
dby) ... ok
test_start_default (test_hawqstandby.TestHawqStandby) ... ok
test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
test_getHostsForMasterComponent
(test_service_advisor.TestHAWQ200ServiceAdvisor) ...
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org', 'c6404.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org', 'c6404.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org']
['c6401.ambari.apache.org']
['c6401.ambari.apache.org', 'c6402.ambari.apache.org',
'c6403.ambari.apache.org']
ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok
--
Ran 53 tests in 0.982s
test_execute (test_alerts_api_status.TestAlertsApiStatus) ... No handlers could
be found for logger "ambari_alerts"
ok
test_get_pxf_protocol_version (test_alerts_api_status.TestAlertsApiStatus) ...
ok
test_configure_default (test_pxf.TestPxf) ... ok
test_install_default (test_pxf.TestPxf) ... ok
test_start_default (test_pxf.TestPxf) ... ok
test_status_default (test_pxf.TestPxf) ... ok
test_stop_default (test_pxf.TestPxf) ... ok
test_getConfigurationsValidationItems
(test_service_advisor.TestPXF300ServiceAdvisor) ... SiteName: hbase-env,
method: validatePXFHBaseEnvConfigurations
Site properties: {'content': '# Some hbase-env content text'}
Recommendations: {'content': '# Some hbase-env content text'}
ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestPXF300ServiceAdvisor) ... ok
--
Ran 9 tests in 0.027s
OK
Thanks,
Lav Jain
Re: Review Request 49362: Add additional parameters to hawq-site.xml
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49362/#review139977 --- Ship it! Ship It! - Lav Jain On June 29, 2016, 10:04 a.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49362/ > --- > > (Updated June 29, 2016, 10:04 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-17473 > https://issues.apache.org/jira/browse/AMBARI-17473 > > > Repository: ambari > > > Description > --- > > Add additional parameters to hawq-site.xml > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 6e21d84 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml > 1d27052 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json > d7940a1 > > Diff: https://reviews.apache.org/r/49362/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Matt > >
Review Request 49521: Move service advisor tests for HAWQ and PXF
/python/stacks/2.3/common/services-normal-nohawq-3-hosts.json 2149317 ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 92a8e58 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 62d926e ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json ebff461 ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json 10cd9a4 Diff: https://reviews.apache.org/r/49521/diff/ Testing --- Total run:1005 Total errors:0 Total failures:0 OK Thanks, Lav Jain
Re: Review Request 49521: Move service advisor tests for HAWQ and PXF
/2.3/common/services-normal-hawq-3-hosts.json 5495d77 ambari-server/src/test/python/stacks/2.3/common/services-normal-nohawq-3-hosts.json 2149317 ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 92a8e58 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2944f6f ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json ebff461 ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json 10cd9a4 Diff: https://reviews.apache.org/r/49521/diff/ Testing --- Total run:1005 Total errors:0 Total failures:0 OK Thanks, Lav Jain
Re: Review Request 49521: Move service advisor tests for HAWQ and PXF
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49521/ --- (Updated July 2, 2016, 8:31 p.m.) Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush Luniya, Matt, and Tim Thorpe. Changes --- Removed excess configurations (2 lines) Bugs: AMBARI-16647 https://issues.apache.org/jira/browse/AMBARI-16647 Repository: ambari Description --- Currently the service advisor tests for HAWQ and PXF are under ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py Move the tests to the service specific service_advisor files: ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py ambari-server/src/test/python/common-services/PXF/test_service_advisor.py Diffs (updated) - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py e254094 ambari-server/src/main/resources/stacks/stack_advisor.py d8685c3 ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py PRE-CREATION ambari-server/src/test/python/common-services/PXF/test_service_advisor.py PRE-CREATION ambari-server/src/test/python/common-services/configs/hawq_default.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-hawq-3-hosts.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-hawq-pxf-hdfs.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-master_ambari_colo-3-hosts.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-master_standby_colo-3-hosts.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-nohawq-3-hosts.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-normal-hawq-3-hosts.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-normal-nohawq-3-hosts.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-standby_ambari_colo-3-hosts.json PRE-CREATION ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_component_status.py ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_segment_registration_status.py 6bb5930 ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py fd4f474 ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 88fb008 ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 8639ca5 ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py b406723 ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 8d97baa ambari-server/src/test/python/stacks/2.3/HAWQ/test_utils.py ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py ambari-server/src/test/python/stacks/2.3/PXF/test_pxf.py 1147a7e ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 4ea3bfb ambari-server/src/test/python/stacks/2.3/common/hosts-1-host.json ambari-server/src/test/python/stacks/2.3/common/hosts-3-hosts.json ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json 515ba7d ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json 515ba7d ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json 0bf459d ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json 1657ccf ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json cd5d02c ambari-server/src/test/python/stacks/2.3/common/services-nohawq-3-hosts.json beeb62d ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json 5495d77 ambari-server/src/test/python/stacks/2.3/common/services-normal-nohawq-3-hosts.json 2149317 ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 92a8e58 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2944f6f ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json ebff461 ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json Diff: https://reviews.apache.org/r/49521/diff/ Testing --- Total run:1005 Total errors:0 Total failures:0 OK Thanks, Lav Jain
Re: Review Request 49521: Move service advisor tests for HAWQ and PXF
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49521/ --- (Updated July 4, 2016, 12:33 a.m.) Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush Luniya, Matt, and Tim Thorpe. Bugs: AMBARI-16647 https://issues.apache.org/jira/browse/AMBARI-16647 Repository: ambari Description --- Currently the service advisor tests for HAWQ and PXF are under ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py Move the tests to the service specific service_advisor files: ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py ambari-server/src/test/python/common-services/PXF/test_service_advisor.py Diffs (updated) - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py e254094 ambari-server/src/main/resources/stacks/stack_advisor.py d8685c3 ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py PRE-CREATION ambari-server/src/test/python/common-services/PXF/test_service_advisor.py PRE-CREATION ambari-server/src/test/python/common-services/configs/hawq_default.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-hawq-3-hosts.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-hawq-pxf-hdfs.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-master_ambari_colo-3-hosts.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-master_standby_colo-3-hosts.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-nohawq-3-hosts.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-normal-hawq-3-hosts.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-normal-nohawq-3-hosts.json PRE-CREATION ambari-server/src/test/python/common-services/configs/services-standby_ambari_colo-3-hosts.json PRE-CREATION ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_component_status.py ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_segment_registration_status.py 6bb5930 ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py fd4f474 ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 88fb008 ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 8639ca5 ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py b406723 ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 8d97baa ambari-server/src/test/python/stacks/2.3/HAWQ/test_utils.py ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py ambari-server/src/test/python/stacks/2.3/PXF/test_pxf.py 1147a7e ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 4ea3bfb ambari-server/src/test/python/stacks/2.3/common/hosts-1-host.json ambari-server/src/test/python/stacks/2.3/common/hosts-3-hosts.json ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json 515ba7d ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json 515ba7d ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json 0bf459d ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json 1657ccf ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json cd5d02c ambari-server/src/test/python/stacks/2.3/common/services-nohawq-3-hosts.json beeb62d ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json 5495d77 ambari-server/src/test/python/stacks/2.3/common/services-normal-nohawq-3-hosts.json 2149317 ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 92a8e58 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2944f6f ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json ebff461 ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json Diff: https://reviews.apache.org/r/49521/diff/ Testing --- Total run:1005 Total errors:0 Total failures:0 OK Thanks, Lav Jain
Re: Review Request 49659: Update config update message for Activate HAWQ Standby wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49659/#review140947 --- Ship it! Ship It! - Lav Jain On July 5, 2016, 9:39 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49659/ > --- > > (Updated July 5, 2016, 9:39 p.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-17569 > https://issues.apache.org/jira/browse/AMBARI-17569 > > > Repository: ambari > > > Description > --- > > Update config update message for Activate HAWQ Standby wizard > > > Diffs > - > > > ambari-web/app/controllers/main/admin/highAvailability/hawq/activateStandby/step3_controller.js > 326b704 > ambari-web/app/messages.js dcf0426 > > Diff: https://reviews.apache.org/r/49659/diff/ > > > Testing > --- > > ok > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 49662: Show gpadmin as hawq service account user on Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49662/#review140953 --- Ship it! Ship It! - Lav Jain On July 5, 2016, 10:21 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49662/ > --- > > (Updated July 5, 2016, 10:21 p.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-17571 > https://issues.apache.org/jira/browse/AMBARI-17571 > > > Repository: ambari > > > Description > --- > > Show gpadmin as hawq service account user on Ambari > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml > cfab63f > > Diff: https://reviews.apache.org/r/49662/diff/ > > > Testing > --- > > manual. > > > Thanks, > > bhuvnesh chaudhary > >
Review Request 50086: Slider range for should be dynamic on HAWQ settings page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50086/ --- Review request for Ambari, Alexander Denissov, Jayush Luniya, Matt, and Tim Thorpe. Bugs: AMBARI-17700 https://issues.apache.org/jira/browse/AMBARI-17700 Repository: ambari Description --- Ambari should dynamically update the slider range on HAWQ parameters on settings page depending on the cluster size because the static range isn't usable and does not allow selecting a smaller desired value. E.g. the maximum value of 1 is too large when setting it to less than 10. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml 150b2c6 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 16e2952 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 3c8a897 Diff: https://reviews.apache.org/r/50086/diff/ Testing --- Manually tested Thanks, Lav Jain
Review Request 50087: Ambari should have a script to add new repository and service to existing stack
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50087/ --- Review request for Ambari, Alexander Denissov, Jayush Luniya, Matt, and Tim Thorpe. Bugs: AMBARI-17717 https://issues.apache.org/jira/browse/AMBARI-17717 Repository: ambari Description --- Ambari should have a script that users can run to add a custom service and repository to the stack or an existing cluster. ``` Lavs-MacBook-Pro:scripts ljain$ ./add_common_service.py -h Usage: add_common_service.py [options] Options: -h, --helpshow this help message and exit -u USER, --user=USER Ambari login username (Required) -p PASSWORD, --password=PASSWORD Ambari login password. Providing password through command line is not recommended. The script prompts for the password. -t STACK, --stack=STACK Stack Name and Version to be added (Required).(Eg: HDP-2.4 or HDP-2.5) -s SERVICE, --service=SERVICE Service Name and Version to be added.(Eg: HAWQ/2.0.0 or PXF/3.0.0) -r REPOURL, --repourl=REPOURL Repository URL which points to the rpm packages -i REPOID, --repoid=REPOID Repository ID of the new repository -o OSTYPE, --ostype=OSTYPE OS for the new repository (Eg: redhat6) ``` Diffs - ambari-server/src/main/resources/scripts/add_common_service.py PRE-CREATION Diff: https://reviews.apache.org/r/50087/diff/ Testing --- Tested manually with various combinations Thanks, Lav Jain
Re: Review Request 50097: HAWQ install should recommend required values for HDFS properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50097/#review142604 --- Ship it! Ship It! - Lav Jain On July 16, 2016, 12:06 a.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50097/ > --- > > (Updated July 16, 2016, 12:06 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Lav Jain, and > Matt. > > > Bugs: AMBARI-17719 > https://issues.apache.org/jira/browse/AMBARI-17719 > > > Repository: ambari > > > Description > --- > > HAWQ install should recommend required values for HDFS properties > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 16e2952 > ambari-server/src/main/resources/stacks/stack_advisor.py 47f4500 > ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py > 780370d > > Diff: https://reviews.apache.org/r/50097/diff/ > > > Testing > --- > > Tested manually, updated unit tests. > > > Thanks, > > Alexander Denissov > >
Re: Review Request 50087: Ambari should have a script to add new repository and service to existing stack
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50087/ --- (Updated July 18, 2016, 8:51 p.m.) Review request for Ambari, Alexander Denissov, Jayush Luniya, Matt, and Tim Thorpe. Bugs: AMBARI-17717 https://issues.apache.org/jira/browse/AMBARI-17717 Repository: ambari Description --- Ambari should have a script that users can run to add a custom service and repository to the stack or an existing cluster. ``` Lavs-MacBook-Pro:scripts ljain$ ./add_common_service.py -h Usage: add_common_service.py [options] Options: -h, --helpshow this help message and exit -u USER, --user=USER Ambari login username (Required) -p PASSWORD, --password=PASSWORD Ambari login password. Providing password through command line is not recommended. The script prompts for the password. -t STACK, --stack=STACK Stack Name and Version to be added (Required).(Eg: HDP-2.4 or HDP-2.5) -s SERVICE, --service=SERVICE Service Name and Version to be added.(Eg: HAWQ/2.0.0 or PXF/3.0.0) -r REPOURL, --repourl=REPOURL Repository URL which points to the rpm packages -i REPOID, --repoid=REPOID Repository ID of the new repository -o OSTYPE, --ostype=OSTYPE OS for the new repository (Eg: redhat6) ``` Diffs (updated) - ambari-server/src/main/resources/scripts/add_common_service.py PRE-CREATION Diff: https://reviews.apache.org/r/50087/diff/ Testing --- Tested manually with various combinations Thanks, Lav Jain
Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50198/#review142849 --- Ship it! Ship It! - Lav Jain On July 19, 2016, 7:15 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50198/ > --- > > (Updated July 19, 2016, 7:15 p.m.) > > > Review request for Ambari, Alexander Denissov and Lav Jain. > > > Bugs: AMBARI-17720 > https://issues.apache.org/jira/browse/AMBARI-17720 > > > Repository: ambari > > > Description > --- > > When a user is running on vagrant or single node with low system memory, > configurations are not sufficient to allocate containers for "default" 6 > vsegs per node especially during HASH dist table query or external table > query. > > Stack advisor should adjust the config values to ensure service checks and > queries (including Random tables, HASH dist tables, PXF ext tables) do not > fail. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 0bddb07 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > dffe57d > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py > 4089b75 > ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py > f8a9468 > ambari-server/src/test/python/common-services/PXF/test_service_advisor.py > 7510e5f > > Diff: https://reviews.apache.org/r/50198/diff/ > > > Testing > --- > > Tested on Live cluster > > Added unit tests: > ``` > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_remove_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Remove HAWQ Standby ... 2016-07-19 12:12:33,657 - Removing > HAWQ Standby Master ... > ok > test_resync_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Resync HAWQ Standby ... 2016-07-19 12:12:33,660 - HAWQ > Standby Master Re-Sync started in fast mode... > ok > test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not > Kerberized ... 2016-07-19 12:12:33,663 - Executing HAWQ
Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50198/#review142847 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py (line 392) <https://reviews.apache.org/r/50198/#comment208522> Should config-name be set to hawq_rm_memory_limit_perseg? ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py (line 378) <https://reviews.apache.org/r/50198/#comment208523> Should line 378 be hosts["items"][2] instead of hosts["items"][3]? Same for line 390. - Lav Jain On July 19, 2016, 7:15 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50198/ > --- > > (Updated July 19, 2016, 7:15 p.m.) > > > Review request for Ambari, Alexander Denissov and Lav Jain. > > > Bugs: AMBARI-17720 > https://issues.apache.org/jira/browse/AMBARI-17720 > > > Repository: ambari > > > Description > --- > > When a user is running on vagrant or single node with low system memory, > configurations are not sufficient to allocate containers for "default" 6 > vsegs per node especially during HASH dist table query or external table > query. > > Stack advisor should adjust the config values to ensure service checks and > queries (including Random tables, HASH dist tables, PXF ext tables) do not > fail. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 0bddb07 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > dffe57d > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py > 4089b75 > ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py > f8a9468 > ambari-server/src/test/python/common-services/PXF/test_service_advisor.py > 7510e5f > > Diff: https://reviews.apache.org/r/50198/diff/ > > > Testing > --- > > Tested on Live cluster > > Added unit tests: > ``` > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_remove_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Remove HAWQ Standby ... 2016-07-19 12:12:33,65
Review Request 50544: Ambari install/init should create a new gpadmin database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50544/ --- Review request for Ambari, Alexander Denissov and Matt. Bugs: AMBARI-17937 https://issues.apache.org/jira/browse/AMBARI-17937 Repository: ambari Description --- If you are logged in as gpadmin on the master and type in "psql" to connect to the database, it will fail. psql assumes you want to connect to the database named "gpadmin" which matches your username. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 8c43555 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 55a5982 Diff: https://reviews.apache.org/r/50544/diff/ Testing --- Tested manually. Thanks, Lav Jain
Review Request 50545: Ambari should not recursively chown for HAWQ hdfs upon every start
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50545/ --- Review request for Ambari, Alexander Denissov and Matt. Bugs: AMBARI-17938 https://issues.apache.org/jira/browse/AMBARI-17938 Repository: ambari Description --- This results in changing of owner even if the owner value is same. The operation is very costly if there are a lot of subdirectories. The owner value only changes when you switch from regular mode to secure mode and vice-versa. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 8c43555 Diff: https://reviews.apache.org/r/50545/diff/ Testing --- In progress. Thanks, Lav Jain
Re: Review Request 50545: Ambari should not recursively chown for HAWQ hdfs upon every start
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50545/ --- (Updated Aug. 3, 2016, 9:18 p.m.) Review request for Ambari, Alexander Denissov and Matt. Bugs: AMBARI-17938 https://issues.apache.org/jira/browse/AMBARI-17938 Repository: ambari Description --- This results in changing of owner even if the owner value is same. The operation is very costly if there are a lot of subdirectories. The owner value only changes when you switch from regular mode to secure mode and vice-versa. Diffs (updated) - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 8c43555 Diff: https://reviews.apache.org/r/50545/diff/ Testing --- In progress. Thanks, Lav Jain
Re: Review Request 50545: Ambari should not recursively chown for HAWQ hdfs upon every start
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50545/ --- (Updated Aug. 3, 2016, 9:28 p.m.) Review request for Ambari, Alexander Denissov and Matt. Bugs: AMBARI-17938 https://issues.apache.org/jira/browse/AMBARI-17938 Repository: ambari Description --- This results in changing of owner even if the owner value is same. The operation is very costly if there are a lot of subdirectories. The owner value only changes when you switch from regular mode to secure mode and vice-versa. Diffs (updated) - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 298513c Diff: https://reviews.apache.org/r/50545/diff/ Testing --- In progress. Thanks, Lav Jain
Re: Review Request 50731: HAWQ service advisor shows wrong recommendations on edge cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50731/#review144709 --- Ship it! Ship It! - Lav Jain On Aug. 4, 2016, 1:11 a.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50731/ > --- > > (Updated Aug. 4, 2016, 1:11 a.m.) > > > Review request for Ambari, Alexander Denissov and Lav Jain. > > > Bugs: AMBARI-17996 > https://issues.apache.org/jira/browse/AMBARI-17996 > > > Repository: ambari > > > Description > --- > > HAWQ service advisor shows wrong recommendations on edge cases > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 9baaa1c > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 0777dc6 > ambari-server/src/main/resources/stacks/stack_advisor.py 437fe4f > ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py > 7ececa0 > > Diff: https://reviews.apache.org/r/50731/diff/ > > > Testing > --- > > Manually tested on live cluster. > > Added unit tests > ``` > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_remove_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Remove HAWQ Standby ... 2016-08-02 18:01:23,293 - Removing > HAWQ Standby Master ... > ok > test_resync_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Resync HAWQ Standby ... 2016-08-02 18:01:23,295 - HAWQ > Standby Master Re-Sync started in fast mode... > ok > test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not > Kerberized ... 2016-08-02 18:01:23,298 - Executing HAWQ Check ... > ok > test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, > Kerberized ... 2016-08-02 18:01:23,304 - Executing HAWQ Check ... > ok > test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not > Kerberized ... 2016-08-02 18:01:23,309 - Executing HAWQ Check ... > ok > test_run_hawq_c
Re: Review Request 50777: AMBARI-18014: PXF service definition is missing pxf-json profile
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50777/#review144711 --- Ship it! Ship It! - Lav Jain On Aug. 4, 2016, 1:24 a.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50777/ > --- > > (Updated Aug. 4, 2016, 1:24 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Lav Jain, and > Matt. > > > Bugs: AMBARI-18014 > https://issues.apache.org/jira/browse/AMBARI-18014 > > > Repository: ambari > > > Description > --- > > PXF service definition is missing pxf-json profile > > > Diffs > - > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml > 69e3228 > ambari-server/src/main/resources/common-services/PXF/3.0.0/metainfo.xml > 5978d0b > ambari-server/src/test/python/common-services/PXF/test_pxf.py 49df75d > ambari-server/src/test/python/common-services/configs/pxf_default.json > 10cd9a4 > > Diff: https://reviews.apache.org/r/50777/diff/ > > > Testing > --- > > -- > Ran 16 tests in 0.050s > > OK > > > Thanks, > > Alexander Denissov > >
Review Request 50965: Ambari unit tests for HAWQ are not being called
Advisor) ... ok test_validateHDFSSiteConfigurations (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 65 tests in 0.241s OK ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded Running tests for stack:None service:PXF test_execute (test_alerts_api_status.TestAlertsApiStatus) ... No handlers could be found for logger "ambari_alerts" ok test_get_pxf_protocol_version (test_alerts_api_status.TestAlertsApiStatus) ... ok test_configure_default (test_pxf.TestPxf) ... ok test_install_default (test_pxf.TestPxf) ... ok test_start_default (test_pxf.TestPxf) ... ok test_status_default (test_pxf.TestPxf) ... ok test_stop_default (test_pxf.TestPxf) ... ok test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed (test_service_advisor.TestPXF300ServiceAdvisor) Test that PXF does not get recommended during Add Service Wizard, when PXF has already been installed ... ok test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed (test_service_advisor.TestPXF300ServiceAdvisor) Test that PXF gets recommended correctly during Add Service Wizard, when PXF is selected for installation ... ok test_createComponentLayoutRecommendations_pxf_cluster_install (test_service_advisor.TestPXF300ServiceAdvisor) Test that PXF gets recommended correctly during Cluster Install Wizard, when PXF is selected for installation ... ok test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn (test_service_advisor.TestPXF300ServiceAdvisor) Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE ... ok test_getComponentLayoutValidations_pxf_not_co_located_with_dn (test_service_advisor.TestPXF300ServiceAdvisor) Test warning is generated when PXF is not co-located with NAMENODE or DATANODE ... ok test_getComponentLayoutValidations_pxf_not_co_located_with_nn (test_service_advisor.TestPXF300ServiceAdvisor) Test warning is generated when PXF is not co-located with NAMENODE ... ok test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn (test_service_advisor.TestPXF300ServiceAdvisor) Test warning is generated when PXF is not co-located with NAMENODE or DATANODE ... ok test_getConfigurationsValidationItems (test_service_advisor.TestPXF300ServiceAdvisor) ... ok test_getServiceConfigurationRecommendations (test_service_advisor.TestPXF300ServiceAdvisor) ... ok -- Ran 16 tests in 0.038s OK ServiceAdvisor implementation for service PXF was loaded ServiceAdvisor implementation for service PXF was loaded ServiceAdvisor implementation for service PXF was loaded ``` ``` Total run:1115 Total errors:0 Total failures:0 OK [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:01 min [INFO] Finished at: 2016-08-10T13:20:41-07:00 [INFO] Final Memory: 81M/1275M [INFO] -------- ``` Thanks, Lav Jain
Re: Review Request 50965: Ambari unit tests for HAWQ are not being called
tConfigurations (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_validateHAWQSiteConfigurations (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_validateHDFSSiteConfigurations (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 65 tests in 0.241s OK ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded Running tests for stack:None service:PXF test_execute (test_alerts_api_status.TestAlertsApiStatus) ... No handlers could be found for logger "ambari_alerts" ok test_get_pxf_protocol_version (test_alerts_api_status.TestAlertsApiStatus) ... ok test_configure_default (test_pxf.TestPxf) ... ok test_install_default (test_pxf.TestPxf) ... ok test_start_default (test_pxf.TestPxf) ... ok test_status_default (test_pxf.TestPxf) ... ok test_stop_default (test_pxf.TestPxf) ... ok test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed (test_service_advisor.TestPXF300ServiceAdvisor) Test that PXF does not get recommended during Add Service Wizard, when PXF has already been installed ... ok test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed (test_service_advisor.TestPXF300ServiceAdvisor) Test that PXF gets recommended correctly during Add Service Wizard, when PXF is selected for installation ... ok test_createComponentLayoutRecommendations_pxf_cluster_install (test_service_advisor.TestPXF300ServiceAdvisor) Test that PXF gets recommended correctly during Cluster Install Wizard, when PXF is selected for installation ... ok test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn (test_service_advisor.TestPXF300ServiceAdvisor) Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE ... ok test_getComponentLayoutValidations_pxf_not_co_located_with_dn (test_service_advisor.TestPXF300ServiceAdvisor) Test warning is generated when PXF is not co-located with NAMENODE or DATANODE ... ok test_getComponentLayoutValidations_pxf_not_co_located_with_nn (test_service_advisor.TestPXF300ServiceAdvisor) Test warning is generated when PXF is not co-located with NAMENODE ... ok test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn (test_service_advisor.TestPXF300ServiceAdvisor) Test warning is generated when PXF is not co-located with NAMENODE or DATANODE ... ok test_getConfigurationsValidationItems (test_service_advisor.TestPXF300ServiceAdvisor) ... ok test_getServiceConfigurationRecommendations (test_service_advisor.TestPXF300ServiceAdvisor) ... ok -- Ran 16 tests in 0.038s OK ServiceAdvisor implementation for service PXF was loaded ServiceAdvisor implementation for service PXF was loaded ServiceAdvisor implementation for service PXF was loaded ``` ``` Total run:1115 Total errors:0 Total failures:0 OK [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:01 min [INFO] Finished at: 2016-08-10T13:20:41-07:00 [INFO] Final Memory: 81M/1275M [INFO] -------- ``` Thanks, Lav Jain
