Review Request 37807: Move packages from com.twitter.common to org.apache.aurora.common
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37807/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1442 https://issues.apache.org/jira/browse/AURORA-1442 Repository: aurora Description --- Change the namespace of the forked Twitter Commons from com.twitter.common to org.apache.aurora.common. IntellJ's refactoring capability was used to do the rename. Diffs - commons-args/src/main/java/com/twitter/common/args/Arg.java 6269c7f18ace30b0c91fb22fe930c7caa65bf2c2 commons-args/src/main/java/com/twitter/common/args/ArgParser.java f1b412ff4499dc11129637e4a750ebcced84771e commons-args/src/main/java/com/twitter/common/args/CmdLine.java 68c7e5841ef687a84cdf0612da668a0fa990329a commons-args/src/main/java/com/twitter/common/args/NoParser.java d0bebc1879b778d89799b68880f41e6333830a45 commons-args/src/main/java/com/twitter/common/args/Parser.java cd1eebbeec10c3e405d4cffb146397f15a0fc033 commons-args/src/main/java/com/twitter/common/args/ParserOracle.java 0d8fe46db2cd0a6eea411c0197810f89a98986cf commons-args/src/main/java/com/twitter/common/args/Positional.java d62b98c4faafaf0d79439bf0c2a37a743ae99029 commons-args/src/main/java/com/twitter/common/args/Verifier.java fc7ada12dce62c266d24e0243aba1621791861e9 commons-args/src/main/java/com/twitter/common/args/VerifierFor.java 0ac2383cc0e0cacf6c4c52a407affcf0b4f34551 commons-args/src/main/java/com/twitter/common/args/apt/CmdLineProcessor.java 0e793ef807ccdc011dc4047fb5f36abe12578b68 commons-args/src/main/java/com/twitter/common/args/apt/Configuration.java d19940a90a9aa917f2144cdcf4561ac01202428c commons-args/src/main/java/org/apache/aurora/common/args/Arg.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/ArgParser.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/CmdLine.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/NoParser.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/Parser.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/ParserOracle.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/Positional.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/Verifier.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/VerifierFor.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java PRE-CREATION commons-args/src/main/resources/META-INF/services/javax.annotation.processing.Processor bc5a75665841642a10237dac89441ac6d135fad0 commons/src/main/java/com/twitter/common/application/AbstractApplication.java 17514e31acf9ee8acf68ed2b44b914edfe16cd64 commons/src/main/java/com/twitter/common/application/AppLauncher.java 700454fb99839dd764e0381c058751c681970024 commons/src/main/java/com/twitter/common/application/Application.java 5a2a9b8da33e1e2cc010db3236ba1aef4a9951d5 commons/src/main/java/com/twitter/common/application/Lifecycle.java 5c7af1f8079ec8057b240b125dc34f04107bf381 commons/src/main/java/com/twitter/common/application/ShutdownRegistry.java dc20861f4e73b92440b6991cd75b8e58f0b3276a commons/src/main/java/com/twitter/common/application/ShutdownStage.java 09a7229a784e22b4b4bc0b36340aaf11f8438b5c commons/src/main/java/com/twitter/common/application/StartupRegistry.java 943c7af2e983dadf38eaf07231e1dde767d1697d commons/src/main/java/com/twitter/common/application/StartupStage.java 0938cee4150c360d5e899ee725212b460e8a5570 commons/src/main/java/com/twitter/common/application/http/DefaultQuitHandler.java 544b4dc9ae9418ff073a8d439c52d038b9575fe7 commons/src/main/java/com/twitter/common/application/http/GraphViewer.java adb1ddc0f0069568aed47b9d04a10a9a3e6854fb commons/src/main/java/com/twitter/common/application/http/HttpAssetConfig.java ed7a2bde472b05be91cfd9d35f1efab34b74ec93 commons/src/main/java/com/twitter/common/application/http/HttpFilterConfig.java 59b746f06f28cab6915b780849fb4a76a4af9fd4 commons/src/main/java/com/twitter/common/application/http/HttpServletConfig.java d3b882967b3d142c4e7821fef19cf5b494ca5504 commons/src/main/java/com/twitter/common/application/http/Registration.java fef5d09df013a85b77a9227c6985123a51a6701b commons/src/main/java/com/twitter/common/application/modules/AppLauncherModule.java 5c95fa2f8388f1cad613ee7f4dcc118c275e9b77 commons/src/main/java/com/twitter/common/application/modules/LifecycleModule.java 1d9af17bd6c9c8b32343fec3c1882b62725bd991 commons/src/main/java/com/twitter/common/application/modules/LocalServiceRegistry.java baa785f73f2a7a841c5f34964cc8549ca002a2ca
Re: Review Request 37807: Move packages from com.twitter.common to org.apache.aurora.common
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37807/ --- (Updated Aug. 26, 2015, 12:26 p.m.) Review request for Aurora and Bill Farner. Changes --- Rebase. Bugs: AURORA-1442 https://issues.apache.org/jira/browse/AURORA-1442 Repository: aurora Description --- Change the namespace of the forked Twitter Commons from com.twitter.common to org.apache.aurora.common. IntellJ's refactoring capability was used to do the rename. Diffs (updated) - commons-args/src/main/java/com/twitter/common/args/Arg.java 6269c7f18ace30b0c91fb22fe930c7caa65bf2c2 commons-args/src/main/java/com/twitter/common/args/ArgParser.java f1b412ff4499dc11129637e4a750ebcced84771e commons-args/src/main/java/com/twitter/common/args/CmdLine.java 68c7e5841ef687a84cdf0612da668a0fa990329a commons-args/src/main/java/com/twitter/common/args/NoParser.java d0bebc1879b778d89799b68880f41e6333830a45 commons-args/src/main/java/com/twitter/common/args/Parser.java cd1eebbeec10c3e405d4cffb146397f15a0fc033 commons-args/src/main/java/com/twitter/common/args/ParserOracle.java 0d8fe46db2cd0a6eea411c0197810f89a98986cf commons-args/src/main/java/com/twitter/common/args/Positional.java d62b98c4faafaf0d79439bf0c2a37a743ae99029 commons-args/src/main/java/com/twitter/common/args/Verifier.java fc7ada12dce62c266d24e0243aba1621791861e9 commons-args/src/main/java/com/twitter/common/args/VerifierFor.java 0ac2383cc0e0cacf6c4c52a407affcf0b4f34551 commons-args/src/main/java/com/twitter/common/args/apt/CmdLineProcessor.java 0e793ef807ccdc011dc4047fb5f36abe12578b68 commons-args/src/main/java/com/twitter/common/args/apt/Configuration.java d19940a90a9aa917f2144cdcf4561ac01202428c commons-args/src/main/resources/META-INF/services/javax.annotation.processing.Processor bc5a75665841642a10237dac89441ac6d135fad0 commons/src/main/java/com/twitter/common/application/AbstractApplication.java 17514e31acf9ee8acf68ed2b44b914edfe16cd64 commons/src/main/java/com/twitter/common/application/AppLauncher.java 700454fb99839dd764e0381c058751c681970024 commons/src/main/java/com/twitter/common/application/Application.java 5a2a9b8da33e1e2cc010db3236ba1aef4a9951d5 commons/src/main/java/com/twitter/common/application/Lifecycle.java 5c7af1f8079ec8057b240b125dc34f04107bf381 commons/src/main/java/com/twitter/common/application/ShutdownRegistry.java dc20861f4e73b92440b6991cd75b8e58f0b3276a commons/src/main/java/com/twitter/common/application/ShutdownStage.java 09a7229a784e22b4b4bc0b36340aaf11f8438b5c commons/src/main/java/com/twitter/common/application/StartupRegistry.java 943c7af2e983dadf38eaf07231e1dde767d1697d commons/src/main/java/com/twitter/common/application/StartupStage.java 0938cee4150c360d5e899ee725212b460e8a5570 commons/src/main/java/com/twitter/common/application/http/DefaultQuitHandler.java 544b4dc9ae9418ff073a8d439c52d038b9575fe7 commons/src/main/java/com/twitter/common/application/http/GraphViewer.java adb1ddc0f0069568aed47b9d04a10a9a3e6854fb commons/src/main/java/com/twitter/common/application/http/HttpAssetConfig.java ed7a2bde472b05be91cfd9d35f1efab34b74ec93 commons/src/main/java/com/twitter/common/application/http/HttpFilterConfig.java 59b746f06f28cab6915b780849fb4a76a4af9fd4 commons/src/main/java/com/twitter/common/application/http/HttpServletConfig.java d3b882967b3d142c4e7821fef19cf5b494ca5504 commons/src/main/java/com/twitter/common/application/http/Registration.java fef5d09df013a85b77a9227c6985123a51a6701b commons/src/main/java/com/twitter/common/application/modules/AppLauncherModule.java 5c95fa2f8388f1cad613ee7f4dcc118c275e9b77 commons/src/main/java/com/twitter/common/application/modules/LifecycleModule.java 1d9af17bd6c9c8b32343fec3c1882b62725bd991 commons/src/main/java/com/twitter/common/application/modules/LocalServiceRegistry.java baa785f73f2a7a841c5f34964cc8549ca002a2ca commons/src/main/java/com/twitter/common/application/modules/LogModule.java e324b99b71675b00086afdf8f9b8818a3609e5b0 commons/src/main/java/com/twitter/common/application/modules/StatsExportModule.java 10fe24a215c6927bda71f6d14a6a1b582ed1b9e5 commons/src/main/java/com/twitter/common/application/modules/StatsModule.java ba7d206795a9e6d9f89194bbbfca6c92603cfe11 commons/src/main/java/com/twitter/common/application/modules/ThriftModule.java aeb5bedc1934d3f40d7be801fc8c752a1d5904f0 commons/src/main/java/com/twitter/common/args/ArgFilters.java cd11332a01da5ea7088c451a0804a1e3548cc7bb commons/src/main/java/com/twitter/common/args/ArgScanner.java 6b50ed9572f24d188e438e1f24121af0763232c5 commons/src/main/java/com/twitter/common/args/Args.java 9fe546d441718f3797e4d7162fe21f4641218fe2 commons/src/main/java/com/twitter/common/args/ArgumentInfo.java
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files
On Aug. 26, 2015, 5:39 p.m., Maxim Khutornenko wrote:
src/test/python/apache/aurora/config/test_thrift.py, line 177
https://reviews.apache.org/r/37801/diff/1/?file=1053308#file1053308line177
Would be great to have a non-empty hostname as well to explicitly
assert its value.
Is there a good way to test this other than something gross like:
str(String({{mesos.hostname}}).bind(*instance.scopes())). Here the hostname
is in the binding context but not on any inspectable field on the instance
itself.
- Steve
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96560
---
On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
---
(Updated Aug. 26, 2015, 5:05 p.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
---
Added support for {{mesos.hostname}} in aur files
Diffs
-
src/main/python/apache/aurora/config/schema/base.py
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py
082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py
5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py
f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
---
Thanks,
Steve Niemitz
Review Request 37800: Reset deb changelog.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37800/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora-packaging Description --- Per jfarrell's advice, i'm resetting the debian package changelog since it refers to releases we did not officially make, and cannot be found. Diffs - specs/debian/changelog 84464646dcd0e0998763af7301b85cdbca742edc Diff: https://reviews.apache.org/r/37800/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 37800: Reset deb changelog.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37800/#review96550 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 26, 2015, 4:44 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37800/ --- (Updated Aug. 26, 2015, 4:44 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora-packaging Description --- Per jfarrell's advice, i'm resetting the debian package changelog since it refers to releases we did not officially make, and cannot be found. Diffs - specs/debian/changelog 84464646dcd0e0998763af7301b85cdbca742edc Diff: https://reviews.apache.org/r/37800/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 37807: Move packages from com.twitter.common to org.apache.aurora.common
On None, Maxim Khutornenko wrote: Checkstyle is not enabled in commons, is it? Would it make sense to set it up to at least enforce the header rule? https://github.com/apache/aurora/blob/827b9abea48babe53ad5b2c521757c60f04c6dfc/config/checkstyle/checkstyle.xml#L83-L86 The licence plugin does this for gradle AFAIK. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37807/#review96576 --- On Aug. 26, 2015, 11:54 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37807/ --- (Updated Aug. 26, 2015, 11:54 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1442 https://issues.apache.org/jira/browse/AURORA-1442 Repository: aurora Description --- Change the namespace of the forked Twitter Commons from com.twitter.common to org.apache.aurora.common. IntellJ's refactoring capability was used to do the rename. Diffs - commons-args/src/main/java/com/twitter/common/args/Arg.java 6269c7f18ace30b0c91fb22fe930c7caa65bf2c2 commons-args/src/main/java/com/twitter/common/args/ArgParser.java f1b412ff4499dc11129637e4a750ebcced84771e commons-args/src/main/java/com/twitter/common/args/CmdLine.java 68c7e5841ef687a84cdf0612da668a0fa990329a commons-args/src/main/java/com/twitter/common/args/NoParser.java d0bebc1879b778d89799b68880f41e6333830a45 commons-args/src/main/java/com/twitter/common/args/Parser.java cd1eebbeec10c3e405d4cffb146397f15a0fc033 commons-args/src/main/java/com/twitter/common/args/ParserOracle.java 0d8fe46db2cd0a6eea411c0197810f89a98986cf commons-args/src/main/java/com/twitter/common/args/Positional.java d62b98c4faafaf0d79439bf0c2a37a743ae99029 commons-args/src/main/java/com/twitter/common/args/Verifier.java fc7ada12dce62c266d24e0243aba1621791861e9 commons-args/src/main/java/com/twitter/common/args/VerifierFor.java 0ac2383cc0e0cacf6c4c52a407affcf0b4f34551 commons-args/src/main/java/com/twitter/common/args/apt/CmdLineProcessor.java 0e793ef807ccdc011dc4047fb5f36abe12578b68 commons-args/src/main/java/com/twitter/common/args/apt/Configuration.java d19940a90a9aa917f2144cdcf4561ac01202428c commons-args/src/main/java/org/apache/aurora/common/args/Arg.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/ArgParser.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/CmdLine.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/NoParser.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/Parser.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/ParserOracle.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/Positional.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/Verifier.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/VerifierFor.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java PRE-CREATION commons-args/src/main/resources/META-INF/services/javax.annotation.processing.Processor bc5a75665841642a10237dac89441ac6d135fad0 commons/src/main/java/com/twitter/common/application/AbstractApplication.java 17514e31acf9ee8acf68ed2b44b914edfe16cd64 commons/src/main/java/com/twitter/common/application/AppLauncher.java 700454fb99839dd764e0381c058751c681970024 commons/src/main/java/com/twitter/common/application/Application.java 5a2a9b8da33e1e2cc010db3236ba1aef4a9951d5 commons/src/main/java/com/twitter/common/application/Lifecycle.java 5c7af1f8079ec8057b240b125dc34f04107bf381 commons/src/main/java/com/twitter/common/application/ShutdownRegistry.java dc20861f4e73b92440b6991cd75b8e58f0b3276a commons/src/main/java/com/twitter/common/application/ShutdownStage.java 09a7229a784e22b4b4bc0b36340aaf11f8438b5c commons/src/main/java/com/twitter/common/application/StartupRegistry.java 943c7af2e983dadf38eaf07231e1dde767d1697d commons/src/main/java/com/twitter/common/application/StartupStage.java 0938cee4150c360d5e899ee725212b460e8a5570 commons/src/main/java/com/twitter/common/application/http/DefaultQuitHandler.java 544b4dc9ae9418ff073a8d439c52d038b9575fe7 commons/src/main/java/com/twitter/common/application/http/GraphViewer.java adb1ddc0f0069568aed47b9d04a10a9a3e6854fb commons/src/main/java/com/twitter/common/application/http/HttpAssetConfig.java ed7a2bde472b05be91cfd9d35f1efab34b74ec93
Review Request 37809: Use a copy of the table config to avoid contaminating pagination settings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37809/ --- Review request for Aurora and David McLaughlin. Repository: aurora Description --- Use a copy of the table config to avoid contaminating pagination settings. Diffs - src/main/resources/scheduler/assets/js/services.js 085a3d9a290211e11ec88a678155e7881d4983dc Diff: https://reviews.apache.org/r/37809/diff/ Testing --- Set page size to 2, verified that 3 active tasks were paginated but 2 completed tasks (for the same job) did not. Thanks, Joshua Cohen
Re: Review Request 37807: Move packages from com.twitter.common to org.apache.aurora.common
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37807/#review96576 --- Checkstyle is not enabled in commons, is it? Would it make sense to set it up to at least enforce the header rule? https://github.com/apache/aurora/blob/827b9abea48babe53ad5b2c521757c60f04c6dfc/config/checkstyle/checkstyle.xml#L83-L86 - Maxim Khutornenko On Aug. 26, 2015, 6:54 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37807/ --- (Updated Aug. 26, 2015, 6:54 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1442 https://issues.apache.org/jira/browse/AURORA-1442 Repository: aurora Description --- Change the namespace of the forked Twitter Commons from com.twitter.common to org.apache.aurora.common. IntellJ's refactoring capability was used to do the rename. Diffs - commons-args/src/main/java/com/twitter/common/args/Arg.java 6269c7f18ace30b0c91fb22fe930c7caa65bf2c2 commons-args/src/main/java/com/twitter/common/args/ArgParser.java f1b412ff4499dc11129637e4a750ebcced84771e commons-args/src/main/java/com/twitter/common/args/CmdLine.java 68c7e5841ef687a84cdf0612da668a0fa990329a commons-args/src/main/java/com/twitter/common/args/NoParser.java d0bebc1879b778d89799b68880f41e6333830a45 commons-args/src/main/java/com/twitter/common/args/Parser.java cd1eebbeec10c3e405d4cffb146397f15a0fc033 commons-args/src/main/java/com/twitter/common/args/ParserOracle.java 0d8fe46db2cd0a6eea411c0197810f89a98986cf commons-args/src/main/java/com/twitter/common/args/Positional.java d62b98c4faafaf0d79439bf0c2a37a743ae99029 commons-args/src/main/java/com/twitter/common/args/Verifier.java fc7ada12dce62c266d24e0243aba1621791861e9 commons-args/src/main/java/com/twitter/common/args/VerifierFor.java 0ac2383cc0e0cacf6c4c52a407affcf0b4f34551 commons-args/src/main/java/com/twitter/common/args/apt/CmdLineProcessor.java 0e793ef807ccdc011dc4047fb5f36abe12578b68 commons-args/src/main/java/com/twitter/common/args/apt/Configuration.java d19940a90a9aa917f2144cdcf4561ac01202428c commons-args/src/main/java/org/apache/aurora/common/args/Arg.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/ArgParser.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/CmdLine.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/NoParser.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/Parser.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/ParserOracle.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/Positional.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/Verifier.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/VerifierFor.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java PRE-CREATION commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java PRE-CREATION commons-args/src/main/resources/META-INF/services/javax.annotation.processing.Processor bc5a75665841642a10237dac89441ac6d135fad0 commons/src/main/java/com/twitter/common/application/AbstractApplication.java 17514e31acf9ee8acf68ed2b44b914edfe16cd64 commons/src/main/java/com/twitter/common/application/AppLauncher.java 700454fb99839dd764e0381c058751c681970024 commons/src/main/java/com/twitter/common/application/Application.java 5a2a9b8da33e1e2cc010db3236ba1aef4a9951d5 commons/src/main/java/com/twitter/common/application/Lifecycle.java 5c7af1f8079ec8057b240b125dc34f04107bf381 commons/src/main/java/com/twitter/common/application/ShutdownRegistry.java dc20861f4e73b92440b6991cd75b8e58f0b3276a commons/src/main/java/com/twitter/common/application/ShutdownStage.java 09a7229a784e22b4b4bc0b36340aaf11f8438b5c commons/src/main/java/com/twitter/common/application/StartupRegistry.java 943c7af2e983dadf38eaf07231e1dde767d1697d commons/src/main/java/com/twitter/common/application/StartupStage.java 0938cee4150c360d5e899ee725212b460e8a5570 commons/src/main/java/com/twitter/common/application/http/DefaultQuitHandler.java 544b4dc9ae9418ff073a8d439c52d038b9575fe7 commons/src/main/java/com/twitter/common/application/http/GraphViewer.java adb1ddc0f0069568aed47b9d04a10a9a3e6854fb commons/src/main/java/com/twitter/common/application/http/HttpAssetConfig.java ed7a2bde472b05be91cfd9d35f1efab34b74ec93
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files
On Aug. 26, 2015, 5:39 p.m., Maxim Khutornenko wrote:
src/test/python/apache/aurora/config/test_thrift.py, line 177
https://reviews.apache.org/r/37801/diff/1/?file=1053308#file1053308line177
Would be great to have a non-empty hostname as well to explicitly
assert its value.
Steve Niemitz wrote:
Is there a good way to test this other than something gross like:
str(String({{mesos.hostname}}).bind(*instance.scopes())). Here the
hostname is in the binding context but not on any inspectable field on the
instance itself.
nm, I figured out a good test here. I'll submit it once I can beat reviewboard
into submission.
- Steve
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96560
---
On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
---
(Updated Aug. 26, 2015, 5:05 p.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
---
Added support for {{mesos.hostname}} in aur files
Diffs
-
src/main/python/apache/aurora/config/schema/base.py
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py
082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py
5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py
f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
---
Thanks,
Steve Niemitz
Re: Review Request 37807: Move packages from com.twitter.common to org.apache.aurora.common
On Aug. 26, 2015, 7:18 p.m., Maxim Khutornenko wrote: Checkstyle is not enabled in commons, is it? Would it make sense to set it up to at least enforce the header rule? https://github.com/apache/aurora/blob/827b9abea48babe53ad5b2c521757c60f04c6dfc/config/checkstyle/checkstyle.xml#L83-L86 Zameer Manji wrote: The licence plugin does this for gradle AFAIK. Right, but it needs to be configured to do so: https://github.com/apache/aurora/blob/master/build.gradle#L487-L490 - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37807/#review96576 --- On Aug. 26, 2015, 7:26 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37807/ --- (Updated Aug. 26, 2015, 7:26 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1442 https://issues.apache.org/jira/browse/AURORA-1442 Repository: aurora Description --- Change the namespace of the forked Twitter Commons from com.twitter.common to org.apache.aurora.common. IntellJ's refactoring capability was used to do the rename. Diffs - commons-args/src/main/java/com/twitter/common/args/Arg.java 6269c7f18ace30b0c91fb22fe930c7caa65bf2c2 commons-args/src/main/java/com/twitter/common/args/ArgParser.java f1b412ff4499dc11129637e4a750ebcced84771e commons-args/src/main/java/com/twitter/common/args/CmdLine.java 68c7e5841ef687a84cdf0612da668a0fa990329a commons-args/src/main/java/com/twitter/common/args/NoParser.java d0bebc1879b778d89799b68880f41e6333830a45 commons-args/src/main/java/com/twitter/common/args/Parser.java cd1eebbeec10c3e405d4cffb146397f15a0fc033 commons-args/src/main/java/com/twitter/common/args/ParserOracle.java 0d8fe46db2cd0a6eea411c0197810f89a98986cf commons-args/src/main/java/com/twitter/common/args/Positional.java d62b98c4faafaf0d79439bf0c2a37a743ae99029 commons-args/src/main/java/com/twitter/common/args/Verifier.java fc7ada12dce62c266d24e0243aba1621791861e9 commons-args/src/main/java/com/twitter/common/args/VerifierFor.java 0ac2383cc0e0cacf6c4c52a407affcf0b4f34551 commons-args/src/main/java/com/twitter/common/args/apt/CmdLineProcessor.java 0e793ef807ccdc011dc4047fb5f36abe12578b68 commons-args/src/main/java/com/twitter/common/args/apt/Configuration.java d19940a90a9aa917f2144cdcf4561ac01202428c commons-args/src/main/resources/META-INF/services/javax.annotation.processing.Processor bc5a75665841642a10237dac89441ac6d135fad0 commons/src/main/java/com/twitter/common/application/AbstractApplication.java 17514e31acf9ee8acf68ed2b44b914edfe16cd64 commons/src/main/java/com/twitter/common/application/AppLauncher.java 700454fb99839dd764e0381c058751c681970024 commons/src/main/java/com/twitter/common/application/Application.java 5a2a9b8da33e1e2cc010db3236ba1aef4a9951d5 commons/src/main/java/com/twitter/common/application/Lifecycle.java 5c7af1f8079ec8057b240b125dc34f04107bf381 commons/src/main/java/com/twitter/common/application/ShutdownRegistry.java dc20861f4e73b92440b6991cd75b8e58f0b3276a commons/src/main/java/com/twitter/common/application/ShutdownStage.java 09a7229a784e22b4b4bc0b36340aaf11f8438b5c commons/src/main/java/com/twitter/common/application/StartupRegistry.java 943c7af2e983dadf38eaf07231e1dde767d1697d commons/src/main/java/com/twitter/common/application/StartupStage.java 0938cee4150c360d5e899ee725212b460e8a5570 commons/src/main/java/com/twitter/common/application/http/DefaultQuitHandler.java 544b4dc9ae9418ff073a8d439c52d038b9575fe7 commons/src/main/java/com/twitter/common/application/http/GraphViewer.java adb1ddc0f0069568aed47b9d04a10a9a3e6854fb commons/src/main/java/com/twitter/common/application/http/HttpAssetConfig.java ed7a2bde472b05be91cfd9d35f1efab34b74ec93 commons/src/main/java/com/twitter/common/application/http/HttpFilterConfig.java 59b746f06f28cab6915b780849fb4a76a4af9fd4 commons/src/main/java/com/twitter/common/application/http/HttpServletConfig.java d3b882967b3d142c4e7821fef19cf5b494ca5504 commons/src/main/java/com/twitter/common/application/http/Registration.java fef5d09df013a85b77a9227c6985123a51a6701b commons/src/main/java/com/twitter/common/application/modules/AppLauncherModule.java 5c95fa2f8388f1cad613ee7f4dcc118c275e9b77 commons/src/main/java/com/twitter/common/application/modules/LifecycleModule.java 1d9af17bd6c9c8b32343fec3c1882b62725bd991 commons/src/main/java/com/twitter/common/application/modules/LocalServiceRegistry.java baa785f73f2a7a841c5f34964cc8549ca002a2ca
Review Request 37789: Refer to shared task_configs table for job updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37789/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-647 https://issues.apache.org/jira/browse/AURORA-647 Repository: aurora Description --- Unfortunately the reference forced me to move the location of tables in schema.sql, making the delta look much bigger there. Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 7728684560d3111edaa2e29d9738f71bc1d7a9ff src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 02ea355539d6f56c1c861ac83293b649285f43f4 src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java 2f58357dd63c46eb69de6a6daedcf027712d7b2e src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java 9afc3f3fcdcc1b60af2207888993411a55984c8e src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 6ffb54f5beef332097fd5c2390b56873a82f0aa9 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql d971aa19982e6095fbf514714df670cabd523d9d src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 Diff: https://reviews.apache.org/r/37789/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 37772: Fix RPM building.
On Aug. 25, 2015, 9:45 p.m., Maxim Khutornenko wrote: specs/rpm/aurora.spec, lines 62-72 https://reviews.apache.org/r/37772/diff/2/?file=1053012#file1053012line62 nit: could be easier to follow if source definitions matched the below install sequence. Done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37772/#review96494 --- On Aug. 25, 2015, 9:38 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37772/ --- (Updated Aug. 25, 2015, 9:38 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-851 https://issues.apache.org/jira/browse/AURORA-851 Repository: aurora-packaging Description --- Fix references when copying package sources files. Diffs - builder/deb/ubuntu-trusty/build.sh 9c162c728a11a52fb3918dc41f899eb64e3c1084 specs/rpm/Makefile 77605fe4817ada3cb4601b754a5e4980f8fd1e45 specs/rpm/README.md 2432dc7d1de0ae1becd36a914a446a4211f6c177 specs/rpm/aurora.init.sh specs/rpm/aurora.logrotate specs/rpm/aurora.service specs/rpm/aurora.spec 22c107e4dd012d516a11e25a1d1cb6e702e6a24e specs/rpm/aurora.startup.sh specs/rpm/aurora.sysconfig specs/rpm/clusters.json specs/rpm/thermos-observer.init.sh specs/rpm/thermos-observer.logrotate specs/rpm/thermos-observer.service specs/rpm/thermos-observer.startup.sh specs/rpm/thermos-observer.sysconfig Diff: https://reviews.apache.org/r/37772/diff/ Testing --- Successfully ran ``` ./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0_SNAPSHOT.2015.08.25.tar.gz 0.10.0_SNAPSHOT.2015.08.25 ``` Thanks, Bill Farner
Re: Review Request 37772: Fix RPM building.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37772/ --- (Updated Aug. 26, 2015, 10:45 a.m.) Review request for Aurora and Maxim Khutornenko. Changes --- Numerically arranged source files. Bugs: AURORA-851 https://issues.apache.org/jira/browse/AURORA-851 Repository: aurora-packaging Description --- Fix references when copying package sources files. Diffs (updated) - builder/deb/ubuntu-trusty/build.sh bb2b79962db90fe864ea89b824e92d1a91b5a6cb specs/rpm/Makefile 77605fe4817ada3cb4601b754a5e4980f8fd1e45 specs/rpm/README.md 2432dc7d1de0ae1becd36a914a446a4211f6c177 specs/rpm/aurora.init.sh specs/rpm/aurora.logrotate specs/rpm/aurora.service specs/rpm/aurora.spec 22c107e4dd012d516a11e25a1d1cb6e702e6a24e specs/rpm/aurora.startup.sh specs/rpm/aurora.sysconfig specs/rpm/clusters.json specs/rpm/thermos-observer.init.sh specs/rpm/thermos-observer.logrotate specs/rpm/thermos-observer.service specs/rpm/thermos-observer.startup.sh specs/rpm/thermos-observer.sysconfig Diff: https://reviews.apache.org/r/37772/diff/ Testing --- Successfully ran ``` ./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0_SNAPSHOT.2015.08.25.tar.gz 0.10.0_SNAPSHOT.2015.08.25 ``` Thanks, Bill Farner
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files
On Aug. 26, 2015, 5:55 p.m., Zameer Manji wrote:
The ticket referenced also talks about {{mesos.ip}}, will you also add
support for that?
It's not exposed anywhere by mesos AFAIK. If someone can correct me I can add
it in another review.
- Steve
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96565
---
On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
---
(Updated Aug. 26, 2015, 5:05 p.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
---
Added support for {{mesos.hostname}} in aur files
Diffs
-
src/main/python/apache/aurora/config/schema/base.py
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py
082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py
5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py
f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
---
Thanks,
Steve Niemitz
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96565
---
The ticket referenced also talks about {{mesos.ip}}, will you also add support
for that?
- Zameer Manji
On Aug. 26, 2015, 10:05 a.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
---
(Updated Aug. 26, 2015, 10:05 a.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
---
Added support for {{mesos.hostname}} in aur files
Diffs
-
src/main/python/apache/aurora/config/schema/base.py
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py
082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py
5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py
f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
---
Thanks,
Steve Niemitz
Re: Review Request 37788: Deb: Clean up changelog generation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37788/#review96551 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 26, 2015, 5:01 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37788/ --- (Updated Aug. 26, 2015, 5:01 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora-packaging Description --- This sets the maintainer fields, and ensures we mark the changelog entry as released. Diffs - builder/deb/ubuntu-trusty/build.sh 9c162c728a11a52fb3918dc41f899eb64e3c1084 Diff: https://reviews.apache.org/r/37788/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 37776: Setting revocable flag on a TaskInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37776/#review96566 --- Ship it! Ship It! - Zameer Manji On Aug. 25, 2015, 4:05 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37776/ --- (Updated Aug. 25, 2015, 4:05 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora Description --- In order to be launched by Mesos a BE task resources must have a `revocable` flag set. The ExecutorInfo revocable flag is not strictly necessary but using the same approach simplifies resource handling. Diffs - src/jmh/java/org/apache/aurora/benchmark/Offers.java 9f3ce1643c583ea4160478c57da9c559beb38c4a src/main/java/org/apache/aurora/scheduler/ResourceSlot.java e5953bbf02fc2b08fbdff5c25b5389c5a209dfca src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ff6eb980292c05e35dcf68104c870a7bef95629a src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 50e7fc91108993e547869df5b9e5c925fb89a225 src/test/java/org/apache/aurora/scheduler/ResourcesTest.java c48d0968970601b86b2e99cc1e3defaddd24bf28 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 02fe96445148d1e14d85dc7a6fa386d84a8a8c70 src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 8a1599a0c71bc598bb19c69a36bb380d49387710 Diff: https://reviews.apache.org/r/37776/diff/ Testing --- Thanks, Maxim Khutornenko
Re: Review Request 37788: Deb: Clean up changelog generation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37788/#review96555 --- Ship it! Ship It! - Kevin Sweeney On Aug. 26, 2015, 10:01 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37788/ --- (Updated Aug. 26, 2015, 10:01 a.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora-packaging Description --- This sets the maintainer fields, and ensures we mark the changelog entry as released. Diffs - builder/deb/ubuntu-trusty/build.sh 9c162c728a11a52fb3918dc41f899eb64e3c1084 Diff: https://reviews.apache.org/r/37788/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
---
(Updated Aug. 26, 2015, 5:05 p.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
---
Added support for {{mesos.hostname}} in aur files
Diffs
-
src/main/python/apache/aurora/config/schema/base.py
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py
082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py
5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py
f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
---
Thanks,
Steve Niemitz
Re: Review Request 37789: Refer to shared task_configs table for job updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37789/#review96558 --- Ship it! Ship It! src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java (line 160) https://reviews.apache.org/r/37789/#comment152067 Inline this method reference. - Kevin Sweeney On Aug. 25, 2015, 11:41 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37789/ --- (Updated Aug. 25, 2015, 11:41 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-647 https://issues.apache.org/jira/browse/AURORA-647 Repository: aurora Description --- Unfortunately the reference forced me to move the location of tables in schema.sql, making the delta look much bigger there. Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 7728684560d3111edaa2e29d9738f71bc1d7a9ff src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 02ea355539d6f56c1c861ac83293b649285f43f4 src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java 2f58357dd63c46eb69de6a6daedcf027712d7b2e src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java 9afc3f3fcdcc1b60af2207888993411a55984c8e src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 6ffb54f5beef332097fd5c2390b56873a82f0aa9 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql d971aa19982e6095fbf514714df670cabd523d9d src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 Diff: https://reviews.apache.org/r/37789/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96560
---
src/test/python/apache/aurora/config/test_thrift.py (line 177)
https://reviews.apache.org/r/37801/#comment152072
Would be great to have a non-empty hostname as well to explicitly assert
its value.
- Maxim Khutornenko
On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
---
(Updated Aug. 26, 2015, 5:05 p.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
---
Added support for {{mesos.hostname}} in aur files
Diffs
-
src/main/python/apache/aurora/config/schema/base.py
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py
082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py
5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py
f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
---
Thanks,
Steve Niemitz
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96595
---
Ship it!
Master (1a3ed7f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing @ReviewBot
retry
- Aurora ReviewBot
On Aug. 26, 2015, 7:37 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
---
(Updated Aug. 26, 2015, 7:37 p.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
---
Added support for {{mesos.hostname}} in aur files
Diffs
-
src/main/python/apache/aurora/config/schema/base.py
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py
082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py
5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py
f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
---
Thanks,
Steve Niemitz
Re: Review Request 37809: Use a copy of the table config to avoid contaminating pagination settings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37809/#review96587 --- Master (3fdbc8c) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 26, 2015, 8:03 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37809/ --- (Updated Aug. 26, 2015, 8:03 p.m.) Review request for Aurora and David McLaughlin. Repository: aurora Description --- Use a copy of the table config to avoid contaminating pagination settings. Diffs - src/main/resources/scheduler/assets/js/services.js 085a3d9a290211e11ec88a678155e7881d4983dc Diff: https://reviews.apache.org/r/37809/diff/ Testing --- Set page size to 2, verified that 3 active tasks were paginated but 2 completed tasks (for the same job) did not. Thanks, Joshua Cohen
Re: Review Request 37807: Move packages from com.twitter.common to org.apache.aurora.common
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37807/#review96590 --- Ship it! Ship It! - Bill Farner On Aug. 26, 2015, 12:26 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37807/ --- (Updated Aug. 26, 2015, 12:26 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1442 https://issues.apache.org/jira/browse/AURORA-1442 Repository: aurora Description --- Change the namespace of the forked Twitter Commons from com.twitter.common to org.apache.aurora.common. IntellJ's refactoring capability was used to do the rename. Diffs - commons-args/src/main/java/com/twitter/common/args/Arg.java 6269c7f18ace30b0c91fb22fe930c7caa65bf2c2 commons-args/src/main/java/com/twitter/common/args/ArgParser.java f1b412ff4499dc11129637e4a750ebcced84771e commons-args/src/main/java/com/twitter/common/args/CmdLine.java 68c7e5841ef687a84cdf0612da668a0fa990329a commons-args/src/main/java/com/twitter/common/args/NoParser.java d0bebc1879b778d89799b68880f41e6333830a45 commons-args/src/main/java/com/twitter/common/args/Parser.java cd1eebbeec10c3e405d4cffb146397f15a0fc033 commons-args/src/main/java/com/twitter/common/args/ParserOracle.java 0d8fe46db2cd0a6eea411c0197810f89a98986cf commons-args/src/main/java/com/twitter/common/args/Positional.java d62b98c4faafaf0d79439bf0c2a37a743ae99029 commons-args/src/main/java/com/twitter/common/args/Verifier.java fc7ada12dce62c266d24e0243aba1621791861e9 commons-args/src/main/java/com/twitter/common/args/VerifierFor.java 0ac2383cc0e0cacf6c4c52a407affcf0b4f34551 commons-args/src/main/java/com/twitter/common/args/apt/CmdLineProcessor.java 0e793ef807ccdc011dc4047fb5f36abe12578b68 commons-args/src/main/java/com/twitter/common/args/apt/Configuration.java d19940a90a9aa917f2144cdcf4561ac01202428c commons-args/src/main/resources/META-INF/services/javax.annotation.processing.Processor bc5a75665841642a10237dac89441ac6d135fad0 commons/src/main/java/com/twitter/common/application/AbstractApplication.java 17514e31acf9ee8acf68ed2b44b914edfe16cd64 commons/src/main/java/com/twitter/common/application/AppLauncher.java 700454fb99839dd764e0381c058751c681970024 commons/src/main/java/com/twitter/common/application/Application.java 5a2a9b8da33e1e2cc010db3236ba1aef4a9951d5 commons/src/main/java/com/twitter/common/application/Lifecycle.java 5c7af1f8079ec8057b240b125dc34f04107bf381 commons/src/main/java/com/twitter/common/application/ShutdownRegistry.java dc20861f4e73b92440b6991cd75b8e58f0b3276a commons/src/main/java/com/twitter/common/application/ShutdownStage.java 09a7229a784e22b4b4bc0b36340aaf11f8438b5c commons/src/main/java/com/twitter/common/application/StartupRegistry.java 943c7af2e983dadf38eaf07231e1dde767d1697d commons/src/main/java/com/twitter/common/application/StartupStage.java 0938cee4150c360d5e899ee725212b460e8a5570 commons/src/main/java/com/twitter/common/application/http/DefaultQuitHandler.java 544b4dc9ae9418ff073a8d439c52d038b9575fe7 commons/src/main/java/com/twitter/common/application/http/GraphViewer.java adb1ddc0f0069568aed47b9d04a10a9a3e6854fb commons/src/main/java/com/twitter/common/application/http/HttpAssetConfig.java ed7a2bde472b05be91cfd9d35f1efab34b74ec93 commons/src/main/java/com/twitter/common/application/http/HttpFilterConfig.java 59b746f06f28cab6915b780849fb4a76a4af9fd4 commons/src/main/java/com/twitter/common/application/http/HttpServletConfig.java d3b882967b3d142c4e7821fef19cf5b494ca5504 commons/src/main/java/com/twitter/common/application/http/Registration.java fef5d09df013a85b77a9227c6985123a51a6701b commons/src/main/java/com/twitter/common/application/modules/AppLauncherModule.java 5c95fa2f8388f1cad613ee7f4dcc118c275e9b77 commons/src/main/java/com/twitter/common/application/modules/LifecycleModule.java 1d9af17bd6c9c8b32343fec3c1882b62725bd991 commons/src/main/java/com/twitter/common/application/modules/LocalServiceRegistry.java baa785f73f2a7a841c5f34964cc8549ca002a2ca commons/src/main/java/com/twitter/common/application/modules/LogModule.java e324b99b71675b00086afdf8f9b8818a3609e5b0 commons/src/main/java/com/twitter/common/application/modules/StatsExportModule.java 10fe24a215c6927bda71f6d14a6a1b582ed1b9e5 commons/src/main/java/com/twitter/common/application/modules/StatsModule.java ba7d206795a9e6d9f89194bbbfca6c92603cfe11 commons/src/main/java/com/twitter/common/application/modules/ThriftModule.java aeb5bedc1934d3f40d7be801fc8c752a1d5904f0
Review Request 37818: Moved executor settings configuration to loadable JSON
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/ --- Review request for Aurora. Repository: aurora Description --- This is the first stage in a series of patches to create support for custom executors. In an effort to expedite the review process, I have decided to break down my patch into multiple pieces that when/if commited won't break the trunk. This patch includes the ability to load configuration from a JSON file. A JSON example file is included in examples/vagrant/executors-config.json Command line arguments have been eliminated and moved over to the JSON file. GSON is leveraged and does most of the work with the aid of a few custom deserializers that were needed. Note that right now a global container mount that does not follow specification will cause the scheduler to detect the error an exit early. It is up for discussion if this is the desired behavior or if we should just ignore said mount. Diffs - examples/vagrant/executors-config-new.json PRE-CREATION examples/vagrant/executors-config.json PRE-CREATION examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 0c440b5cd5b939872c1ee05d048bf739bfa977cb src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java b3c913892248e4a9a8111412307463985f5ca97f src/test/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoaderTest.java PRE-CREATION src/test/resources/org/apache/aurora/scheduler/configuration/executor-settings-thermos-no-observer.json PRE-CREATION src/test/resources/org/apache/aurora/scheduler/configuration/thermos-settings-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37818/diff/ Testing --- ./build-support/jenkins/build.sh: directory sandbox failed but it may be a flaky test bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Renan DelValle
Re: Review Request 37818: Moved executor settings configuration to loadable JSON
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/#review96605 --- Quick (incomplete) review on the design of the config object examples/vagrant/executors-config-new.json (lines 13 - 15) https://reviews.apache.org/r/37818/#comment152193 do these have defaults that we can omit? also I don't think we want to cache in the vagrant environment as we want changes to be reflected in new tasks immediately when developing. examples/vagrant/executors-config-new.json (line 14) https://reviews.apache.org/r/37818/#comment152195 don't extract this examples/vagrant/executors-config-new.json (line 18) https://reviews.apache.org/r/37818/#comment152194 this isn't a global property - can it be pushed into a custom configuration object? examples/vagrant/executors-config-new.json (line 19) https://reviews.apache.org/r/37818/#comment152192 It would be ergnomically nice to default this to an empty list if it's left unset. examples/vagrant/executors-config.json (line 1) https://reviews.apache.org/r/37818/#comment152191 delete this file? It looks like it has been superceded by the new format below src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java (line 114) https://reviews.apache.org/r/37818/#comment152196 drop redundant use of `this`, here and below. - Kevin Sweeney On Aug. 26, 2015, 3:19 p.m., Renan DelValle wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/ --- (Updated Aug. 26, 2015, 3:19 p.m.) Review request for Aurora. Repository: aurora Description --- This is the first stage in a series of patches to create support for custom executors. In an effort to expedite the review process, I have decided to break down my patch into multiple pieces that when/if commited won't break the trunk. This patch includes the ability to load configuration from a JSON file. A JSON example file is included in examples/vagrant/executors-config.json Command line arguments have been eliminated and moved over to the JSON file. GSON is leveraged and does most of the work with the aid of a few custom deserializers that were needed. Note that right now a global container mount that does not follow specification will cause the scheduler to detect the error an exit early. It is up for discussion if this is the desired behavior or if we should just ignore said mount. Diffs - examples/vagrant/executors-config-new.json PRE-CREATION examples/vagrant/executors-config.json PRE-CREATION examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 0c440b5cd5b939872c1ee05d048bf739bfa977cb src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java b3c913892248e4a9a8111412307463985f5ca97f src/test/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoaderTest.java PRE-CREATION src/test/resources/org/apache/aurora/scheduler/configuration/executor-settings-thermos-no-observer.json PRE-CREATION src/test/resources/org/apache/aurora/scheduler/configuration/thermos-settings-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37818/diff/ Testing --- ./build-support/jenkins/build.sh: directory sandbox failed but it may be a flaky test bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Renan DelValle
Re: Review Request 37807: Move packages from com.twitter.common to org.apache.aurora.common
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37807/#review96589 --- Ship it! Master (3fdbc8c) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 26, 2015, 7:26 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37807/ --- (Updated Aug. 26, 2015, 7:26 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1442 https://issues.apache.org/jira/browse/AURORA-1442 Repository: aurora Description --- Change the namespace of the forked Twitter Commons from com.twitter.common to org.apache.aurora.common. IntellJ's refactoring capability was used to do the rename. Diffs - commons-args/src/main/java/com/twitter/common/args/Arg.java 6269c7f18ace30b0c91fb22fe930c7caa65bf2c2 commons-args/src/main/java/com/twitter/common/args/ArgParser.java f1b412ff4499dc11129637e4a750ebcced84771e commons-args/src/main/java/com/twitter/common/args/CmdLine.java 68c7e5841ef687a84cdf0612da668a0fa990329a commons-args/src/main/java/com/twitter/common/args/NoParser.java d0bebc1879b778d89799b68880f41e6333830a45 commons-args/src/main/java/com/twitter/common/args/Parser.java cd1eebbeec10c3e405d4cffb146397f15a0fc033 commons-args/src/main/java/com/twitter/common/args/ParserOracle.java 0d8fe46db2cd0a6eea411c0197810f89a98986cf commons-args/src/main/java/com/twitter/common/args/Positional.java d62b98c4faafaf0d79439bf0c2a37a743ae99029 commons-args/src/main/java/com/twitter/common/args/Verifier.java fc7ada12dce62c266d24e0243aba1621791861e9 commons-args/src/main/java/com/twitter/common/args/VerifierFor.java 0ac2383cc0e0cacf6c4c52a407affcf0b4f34551 commons-args/src/main/java/com/twitter/common/args/apt/CmdLineProcessor.java 0e793ef807ccdc011dc4047fb5f36abe12578b68 commons-args/src/main/java/com/twitter/common/args/apt/Configuration.java d19940a90a9aa917f2144cdcf4561ac01202428c commons-args/src/main/resources/META-INF/services/javax.annotation.processing.Processor bc5a75665841642a10237dac89441ac6d135fad0 commons/src/main/java/com/twitter/common/application/AbstractApplication.java 17514e31acf9ee8acf68ed2b44b914edfe16cd64 commons/src/main/java/com/twitter/common/application/AppLauncher.java 700454fb99839dd764e0381c058751c681970024 commons/src/main/java/com/twitter/common/application/Application.java 5a2a9b8da33e1e2cc010db3236ba1aef4a9951d5 commons/src/main/java/com/twitter/common/application/Lifecycle.java 5c7af1f8079ec8057b240b125dc34f04107bf381 commons/src/main/java/com/twitter/common/application/ShutdownRegistry.java dc20861f4e73b92440b6991cd75b8e58f0b3276a commons/src/main/java/com/twitter/common/application/ShutdownStage.java 09a7229a784e22b4b4bc0b36340aaf11f8438b5c commons/src/main/java/com/twitter/common/application/StartupRegistry.java 943c7af2e983dadf38eaf07231e1dde767d1697d commons/src/main/java/com/twitter/common/application/StartupStage.java 0938cee4150c360d5e899ee725212b460e8a5570 commons/src/main/java/com/twitter/common/application/http/DefaultQuitHandler.java 544b4dc9ae9418ff073a8d439c52d038b9575fe7 commons/src/main/java/com/twitter/common/application/http/GraphViewer.java adb1ddc0f0069568aed47b9d04a10a9a3e6854fb commons/src/main/java/com/twitter/common/application/http/HttpAssetConfig.java ed7a2bde472b05be91cfd9d35f1efab34b74ec93 commons/src/main/java/com/twitter/common/application/http/HttpFilterConfig.java 59b746f06f28cab6915b780849fb4a76a4af9fd4 commons/src/main/java/com/twitter/common/application/http/HttpServletConfig.java d3b882967b3d142c4e7821fef19cf5b494ca5504 commons/src/main/java/com/twitter/common/application/http/Registration.java fef5d09df013a85b77a9227c6985123a51a6701b commons/src/main/java/com/twitter/common/application/modules/AppLauncherModule.java 5c95fa2f8388f1cad613ee7f4dcc118c275e9b77 commons/src/main/java/com/twitter/common/application/modules/LifecycleModule.java 1d9af17bd6c9c8b32343fec3c1882b62725bd991 commons/src/main/java/com/twitter/common/application/modules/LocalServiceRegistry.java baa785f73f2a7a841c5f34964cc8549ca002a2ca commons/src/main/java/com/twitter/common/application/modules/LogModule.java e324b99b71675b00086afdf8f9b8818a3609e5b0 commons/src/main/java/com/twitter/common/application/modules/StatsExportModule.java 10fe24a215c6927bda71f6d14a6a1b582ed1b9e5 commons/src/main/java/com/twitter/common/application/modules/StatsModule.java ba7d206795a9e6d9f89194bbbfca6c92603cfe11
Re: Review Request 37789: Refer to shared task_configs table for job updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37789/#review96529 --- Ship it! Master (d901347) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 26, 2015, 6:41 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37789/ --- (Updated Aug. 26, 2015, 6:41 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-647 https://issues.apache.org/jira/browse/AURORA-647 Repository: aurora Description --- Unfortunately the reference forced me to move the location of tables in schema.sql, making the delta look much bigger there. Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 7728684560d3111edaa2e29d9738f71bc1d7a9ff src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 02ea355539d6f56c1c861ac83293b649285f43f4 src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java 2f58357dd63c46eb69de6a6daedcf027712d7b2e src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java 9afc3f3fcdcc1b60af2207888993411a55984c8e src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 6ffb54f5beef332097fd5c2390b56873a82f0aa9 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql d971aa19982e6095fbf514714df670cabd523d9d src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 Diff: https://reviews.apache.org/r/37789/diff/ Testing --- Thanks, Bill Farner
Review Request 37825: Adding minimal implementation of the external tier config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- The external config file is optional for now as tiers are not fully defined yet. Diffs - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37825/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37818: Moved executor settings configuration to loadable JSON
On Aug. 26, 2015, 10:27 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java, line 114 https://reviews.apache.org/r/37818/diff/1/?file=1055427#file1055427line114 drop redundant use of `this`, here and below. Done, apologies, this one slipped through the cracks from the previous reviews. On Aug. 26, 2015, 10:27 p.m., Kevin Sweeney wrote: examples/vagrant/executors-config.json, line 1 https://reviews.apache.org/r/37818/diff/1/?file=1055422#file1055422line1 delete this file? It looks like it has been superceded by the new format below This first cut wasn't supposed to include the new schema. I was gonna implement it in the second patch but I guess now is as good a time as any to get this in. On Aug. 26, 2015, 10:27 p.m., Kevin Sweeney wrote: examples/vagrant/executors-config-new.json, line 19 https://reviews.apache.org/r/37818/diff/1/?file=1055421#file1055421line19 It would be ergnomically nice to default this to an empty list if it's left unset. I'll see if there's a way of doing that. If you come across anything, let me know. On Aug. 26, 2015, 10:27 p.m., Kevin Sweeney wrote: examples/vagrant/executors-config-new.json, line 18 https://reviews.apache.org/r/37818/diff/1/?file=1055421#file1055421line18 this isn't a global property - can it be pushed into a custom configuration object? We can, but this change causes a ripple effect. If we push this into a custom schema, we have to provide a way of unpacking custom configuration object into useful mesos data fields or information usefol to the executor. We need to come to a decision on the best way of doing this if we go for it. Tangentially, as far as I can tell this is only used when building container volumes. On Aug. 26, 2015, 10:27 p.m., Kevin Sweeney wrote: examples/vagrant/executors-config-new.json, lines 13-15 https://reviews.apache.org/r/37818/diff/1/?file=1055421#file1055421line13 do these have defaults that we can omit? also I don't think we want to cache in the vagrant environment as we want changes to be reflected in new tasks immediately when developing. As per the mesos documentation, all options but the string value are optional. What isn't very clear is how the extract is true by default if it is optional. (source: https://github.com/apache/mesos/blob/master/docs/fetcher.md) - Renan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/#review96605 --- On Aug. 26, 2015, 10:19 p.m., Renan DelValle wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/ --- (Updated Aug. 26, 2015, 10:19 p.m.) Review request for Aurora. Repository: aurora Description --- This is the first stage in a series of patches to create support for custom executors. In an effort to expedite the review process, I have decided to break down my patch into multiple pieces that when/if commited won't break the trunk. This patch includes the ability to load configuration from a JSON file. A JSON example file is included in examples/vagrant/executors-config.json Command line arguments have been eliminated and moved over to the JSON file. GSON is leveraged and does most of the work with the aid of a few custom deserializers that were needed. Note that right now a global container mount that does not follow specification will cause the scheduler to detect the error an exit early. It is up for discussion if this is the desired behavior or if we should just ignore said mount. Diffs - examples/vagrant/executors-config-new.json PRE-CREATION examples/vagrant/executors-config.json PRE-CREATION examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 0c440b5cd5b939872c1ee05d048bf739bfa977cb src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java b3c913892248e4a9a8111412307463985f5ca97f src/test/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoaderTest.java PRE-CREATION src/test/resources/org/apache/aurora/scheduler/configuration/executor-settings-thermos-no-observer.json PRE-CREATION src/test/resources/org/apache/aurora/scheduler/configuration/thermos-settings-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37818/diff/ Testing ---
