Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-08 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/#review109390
---

Ship it!


Master (2e23714) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 8, 2015, 8:31 p.m., Tengfei Mu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41048/
> ---
> 
> (Updated Dec. 8, 2015, 8:31 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1547
> https://issues.apache.org/jira/browse/AURORA-1547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> set TaskStatus.slave_id field in TaskReconsiler
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> c797914ded51cd123dddef188373fe58e190773a 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  1308a1c9884e7759e6139787710b367bbf9cd4e9 
> 
> Diff: https://reviews.apache.org/r/41048/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Tengfei Mu
> 
>

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-08 Thread Maxim Khutornenko 


> On Dec. 8, 2015, 8:40 p.m., Maxim Khutornenko wrote:
> > Ship It!

Will merge once ReviewBot catches up.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/#review109383
---


On Dec. 8, 2015, 8:31 p.m., Tengfei Mu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41048/
> ---
> 
> (Updated Dec. 8, 2015, 8:31 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1547
> https://issues.apache.org/jira/browse/AURORA-1547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> set TaskStatus.slave_id field in TaskReconsiler
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> c797914ded51cd123dddef188373fe58e190773a 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  1308a1c9884e7759e6139787710b367bbf9cd4e9 
> 
> Diff: https://reviews.apache.org/r/41048/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Tengfei Mu
> 
>

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-08 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/#review109383
---

Ship it!


Ship It!

- Maxim Khutornenko


On Dec. 8, 2015, 8:31 p.m., Tengfei Mu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41048/
> ---
> 
> (Updated Dec. 8, 2015, 8:31 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1547
> https://issues.apache.org/jira/browse/AURORA-1547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> set TaskStatus.slave_id field in TaskReconsiler
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> c797914ded51cd123dddef188373fe58e190773a 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  1308a1c9884e7759e6139787710b367bbf9cd4e9 
> 
> Diff: https://reviews.apache.org/r/41048/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Tengfei Mu
> 
>

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-08 Thread Tengfei Mu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/
---

(Updated Dec. 8, 2015, 8:31 p.m.)


Review request for Aurora and Maxim Khutornenko.


Changes
---

make helper func private.


Bugs: AURORA-1547
https://issues.apache.org/jira/browse/AURORA-1547


Repository: aurora


Description
---

set TaskStatus.slave_id field in TaskReconsiler


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
c797914ded51cd123dddef188373fe58e190773a 
  
src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
 1308a1c9884e7759e6139787710b367bbf9cd4e9 

Diff: https://reviews.apache.org/r/41048/diff/


Testing
---

./gradlew -Pq build


Thanks,

Tengfei Mu

Re: Review Request 41074: Use lambdas throughout the project.

2015-12-08 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41074/#review109359
---

Ship it!


Master (d7a1619) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 8, 2015, 6:01 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41074/
> ---
> 
> (Updated Dec. 8, 2015, 6:01 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is almost entirely IDE-assisted.  There were some spots that required 
> hand-editing (notably casting the argument to `storage.write`).
> 
> The overall stats are nice, a reduction of about 1300 lines:
> ```
>  114 files changed, 1982 insertions(+), 3292 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java
>  5abb06b1d41f3265d9d46c600ba193ce19d21188 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java
>  d06ec69cb57d9c411ae33b301489f6460197dcc7 
>   commons/src/main/java/org/apache/aurora/common/args/ArgFilters.java 
> 9a4d441023fd9eea868fd069c197eb002d98f0ab 
>   commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
> cc4710cb5f559a108b140489a981a9d2c195b75b 
>   commons/src/main/java/org/apache/aurora/common/args/Args.java 
> ad0b299057e787a9587822e7778bd360f77e1678 
>   commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java 
> 051e3f93ef17de90b7bffaa74fc6b54965927424 
>   commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 
> c1fe1c73c46da21c471b2669dbb8207b7c468054 
>   commons/src/main/java/org/apache/aurora/common/args/Parsers.java 
> 62564a62d255e640e5790ed2e103ba8425a4c15b 
>   commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
> 3da1812abfdb30f12737b19f5e87bc14a02d4c3f 
>   
> commons/src/main/java/org/apache/aurora/common/args/constraints/RangeNumberVerifier.java
>  27250944a60f906a4c220771e9948ed0297ee76c 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
> 02c10ed067c8395a2688cd69d4d73d5fd17774ff 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
> 1e12b06e284cd2e33b63b3690abd3dcd78f9e777 
>   commons/src/main/java/org/apache/aurora/common/base/Closures.java 
> d6cb82a30a8c6292bab0fa007dce2f54f6b66435 
>   commons/src/main/java/org/apache/aurora/common/base/Commands.java 
> 8a88ae336f57fcdafb984cc3418dcd960da0028d 
>   commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
> 072159e79b2d8872f39dfbba9f6a1d27295f1a7a 
>   commons/src/main/java/org/apache/aurora/common/collections/Pair.java 
> b1f9b6336aa8b8d0ff9e611dc2ad1dc8068ef7f3 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java
>  348a8c923118da3b4399afb1a6f09d904c3b 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSource.java
>  8039def73377b0e56c3106876dc89e9183cd55a1 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/VarsHandler.java
>  d1f23de1a440d47a7754af2c8418e2c4e96bbb84 
>   commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
> 03df9b6f7d31d8567a6bd135654eb39026c375d7 
>   commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
> ff29c39863f044db7fde0fff315621644393429d 
>   commons/src/main/java/org/apache/aurora/common/stats/Ratio.java 
> c332dd3af5712bfb8ed174c2285cac4d30394acc 
>   
> commons/src/main/java/org/apache/aurora/common/testing/easymock/EasyMockTest.java
>  403147527eab46e9c23ab5690d885a6c1deb1c30 
>   commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
> e789f804ecc0053d4605927dc981311af1df94c8 
>   commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 
> 9fbfbb9012414a19cf752d69b48f2e937f4497e7 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
> b10a40327a062b354b42249097c89bf3fbecb1e8 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
> 99a15fe8d58138ebd264d858bff842316928db06 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
> bb6fbced0adc0920592ec14f03a84895829d8812 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> 1761ab70a32656af13a311bcc02f716fdc0ad067 
>   config/legacy_untested_classes.txt 07e49b11050f8b9be63d5b95cfcdb7800e15c7e5 
>   src/main/java/org/apache/aurora/GuiceUtils.java 
> 78b60c26231ff070f08f236f38c8fb58ca9f8d60 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> 7003b2f0b73bf050ae243da4da4c8

Re: Review Request 41074: Use lambdas throughout the project.

2015-12-08 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41074/#review109356
---

Ship it!


Ship It!

- Zameer Manji


On Dec. 8, 2015, 10:01 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41074/
> ---
> 
> (Updated Dec. 8, 2015, 10:01 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is almost entirely IDE-assisted.  There were some spots that required 
> hand-editing (notably casting the argument to `storage.write`).
> 
> The overall stats are nice, a reduction of about 1300 lines:
> ```
>  114 files changed, 1982 insertions(+), 3292 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java
>  5abb06b1d41f3265d9d46c600ba193ce19d21188 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java
>  d06ec69cb57d9c411ae33b301489f6460197dcc7 
>   commons/src/main/java/org/apache/aurora/common/args/ArgFilters.java 
> 9a4d441023fd9eea868fd069c197eb002d98f0ab 
>   commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
> cc4710cb5f559a108b140489a981a9d2c195b75b 
>   commons/src/main/java/org/apache/aurora/common/args/Args.java 
> ad0b299057e787a9587822e7778bd360f77e1678 
>   commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java 
> 051e3f93ef17de90b7bffaa74fc6b54965927424 
>   commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 
> c1fe1c73c46da21c471b2669dbb8207b7c468054 
>   commons/src/main/java/org/apache/aurora/common/args/Parsers.java 
> 62564a62d255e640e5790ed2e103ba8425a4c15b 
>   commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
> 3da1812abfdb30f12737b19f5e87bc14a02d4c3f 
>   
> commons/src/main/java/org/apache/aurora/common/args/constraints/RangeNumberVerifier.java
>  27250944a60f906a4c220771e9948ed0297ee76c 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
> 02c10ed067c8395a2688cd69d4d73d5fd17774ff 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
> 1e12b06e284cd2e33b63b3690abd3dcd78f9e777 
>   commons/src/main/java/org/apache/aurora/common/base/Closures.java 
> d6cb82a30a8c6292bab0fa007dce2f54f6b66435 
>   commons/src/main/java/org/apache/aurora/common/base/Commands.java 
> 8a88ae336f57fcdafb984cc3418dcd960da0028d 
>   commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
> 072159e79b2d8872f39dfbba9f6a1d27295f1a7a 
>   commons/src/main/java/org/apache/aurora/common/collections/Pair.java 
> b1f9b6336aa8b8d0ff9e611dc2ad1dc8068ef7f3 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java
>  348a8c923118da3b4399afb1a6f09d904c3b 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSource.java
>  8039def73377b0e56c3106876dc89e9183cd55a1 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/VarsHandler.java
>  d1f23de1a440d47a7754af2c8418e2c4e96bbb84 
>   commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
> 03df9b6f7d31d8567a6bd135654eb39026c375d7 
>   commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
> ff29c39863f044db7fde0fff315621644393429d 
>   commons/src/main/java/org/apache/aurora/common/stats/Ratio.java 
> c332dd3af5712bfb8ed174c2285cac4d30394acc 
>   
> commons/src/main/java/org/apache/aurora/common/testing/easymock/EasyMockTest.java
>  403147527eab46e9c23ab5690d885a6c1deb1c30 
>   commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
> e789f804ecc0053d4605927dc981311af1df94c8 
>   commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 
> 9fbfbb9012414a19cf752d69b48f2e937f4497e7 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
> b10a40327a062b354b42249097c89bf3fbecb1e8 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
> 99a15fe8d58138ebd264d858bff842316928db06 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
> bb6fbced0adc0920592ec14f03a84895829d8812 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> 1761ab70a32656af13a311bcc02f716fdc0ad067 
>   config/legacy_untested_classes.txt 07e49b11050f8b9be63d5b95cfcdb7800e15c7e5 
>   src/main/java/org/apache/aurora/GuiceUtils.java 
> 78b60c26231ff070f08f236f38c8fb58ca9f8d60 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> 7003b2f0b73bf050ae243da4da4c844e77cdb04b 
>   src/main/java/org/apache/aurora/scheduler/Resources.java 
> f7d105eca961da2b5b445d4a0670e3d5e9bf89b2 
>   src/main/java/org/apache/aurora/sc

Re: Review Request 41074: Use lambdas throughout the project.

2015-12-08 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41074/
---

(Updated Dec. 8, 2015, 10:01 a.m.)


Review request for Aurora and Zameer Manji.


Changes
---

Maxim's comments + used method references where possible.


Repository: aurora


Description
---

This is almost entirely IDE-assisted.  There were some spots that required 
hand-editing (notably casting the argument to `storage.write`).

The overall stats are nice, a reduction of about 1300 lines:
```
 114 files changed, 1982 insertions(+), 3292 deletions(-)
```


Diffs (updated)
-

  
commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java
 5abb06b1d41f3265d9d46c600ba193ce19d21188 
  
commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java 
d06ec69cb57d9c411ae33b301489f6460197dcc7 
  commons/src/main/java/org/apache/aurora/common/args/ArgFilters.java 
9a4d441023fd9eea868fd069c197eb002d98f0ab 
  commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
cc4710cb5f559a108b140489a981a9d2c195b75b 
  commons/src/main/java/org/apache/aurora/common/args/Args.java 
ad0b299057e787a9587822e7778bd360f77e1678 
  commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java 
051e3f93ef17de90b7bffaa74fc6b54965927424 
  commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 
c1fe1c73c46da21c471b2669dbb8207b7c468054 
  commons/src/main/java/org/apache/aurora/common/args/Parsers.java 
62564a62d255e640e5790ed2e103ba8425a4c15b 
  commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
3da1812abfdb30f12737b19f5e87bc14a02d4c3f 
  
commons/src/main/java/org/apache/aurora/common/args/constraints/RangeNumberVerifier.java
 27250944a60f906a4c220771e9948ed0297ee76c 
  commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
02c10ed067c8395a2688cd69d4d73d5fd17774ff 
  commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
1e12b06e284cd2e33b63b3690abd3dcd78f9e777 
  commons/src/main/java/org/apache/aurora/common/base/Closures.java 
d6cb82a30a8c6292bab0fa007dce2f54f6b66435 
  commons/src/main/java/org/apache/aurora/common/base/Commands.java 
8a88ae336f57fcdafb984cc3418dcd960da0028d 
  commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
072159e79b2d8872f39dfbba9f6a1d27295f1a7a 
  commons/src/main/java/org/apache/aurora/common/collections/Pair.java 
b1f9b6336aa8b8d0ff9e611dc2ad1dc8068ef7f3 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java 
348a8c923118da3b4399afb1a6f09d904c3b 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSource.java
 8039def73377b0e56c3106876dc89e9183cd55a1 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/VarsHandler.java
 d1f23de1a440d47a7754af2c8418e2c4e96bbb84 
  commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
03df9b6f7d31d8567a6bd135654eb39026c375d7 
  commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
ff29c39863f044db7fde0fff315621644393429d 
  commons/src/main/java/org/apache/aurora/common/stats/Ratio.java 
c332dd3af5712bfb8ed174c2285cac4d30394acc 
  
commons/src/main/java/org/apache/aurora/common/testing/easymock/EasyMockTest.java
 403147527eab46e9c23ab5690d885a6c1deb1c30 
  commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
e789f804ecc0053d4605927dc981311af1df94c8 
  commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 
9fbfbb9012414a19cf752d69b48f2e937f4497e7 
  commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
b10a40327a062b354b42249097c89bf3fbecb1e8 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
99a15fe8d58138ebd264d858bff842316928db06 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
bb6fbced0adc0920592ec14f03a84895829d8812 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
1761ab70a32656af13a311bcc02f716fdc0ad067 
  config/legacy_untested_classes.txt 07e49b11050f8b9be63d5b95cfcdb7800e15c7e5 
  src/main/java/org/apache/aurora/GuiceUtils.java 
78b60c26231ff070f08f236f38c8fb58ca9f8d60 
  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
7003b2f0b73bf050ae243da4da4c844e77cdb04b 
  src/main/java/org/apache/aurora/scheduler/Resources.java 
f7d105eca961da2b5b445d4a0670e3d5e9bf89b2 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
29331e075b29f0994b4ce4dc8ce602b01b307f0a 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
6d940d17fcb95a221d7d125cc13423e384e4144e 
  src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
311257921df7dca9c2002fbf4c8569d297207c58 
  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
da9f22279a4cd1005a85e8b78398ed57ac6cac34 
  src/main/java/org/apache/aurora/schedul

Re: Review Request 41074: Use lambdas throughout the project.

2015-12-08 Thread Maxim Khutornenko 


> On Dec. 8, 2015, 5:31 p.m., Maxim Khutornenko wrote:
> > commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java, line 99
> > 
> >
> > Fits to previous line.
> 
> Bill Farner wrote:
> Done, also converted to method reference.  Also ran a broader search for 
> conversions to method refs and found/converted ~50.

Thanks! I was going to mention but somehow it escaped me.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41074/#review109346
---


On Dec. 8, 2015, 5:08 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41074/
> ---
> 
> (Updated Dec. 8, 2015, 5:08 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is almost entirely IDE-assisted.  There were some spots that required 
> hand-editing (notably casting the argument to `storage.write`).
> 
> The overall stats are nice, a reduction of about 1300 lines:
> ```
>  114 files changed, 1982 insertions(+), 3292 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java
>  5abb06b1d41f3265d9d46c600ba193ce19d21188 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java
>  d06ec69cb57d9c411ae33b301489f6460197dcc7 
>   commons/src/main/java/org/apache/aurora/common/args/ArgFilters.java 
> 9a4d441023fd9eea868fd069c197eb002d98f0ab 
>   commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
> cc4710cb5f559a108b140489a981a9d2c195b75b 
>   commons/src/main/java/org/apache/aurora/common/args/Args.java 
> ad0b299057e787a9587822e7778bd360f77e1678 
>   commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java 
> 051e3f93ef17de90b7bffaa74fc6b54965927424 
>   commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 
> c1fe1c73c46da21c471b2669dbb8207b7c468054 
>   commons/src/main/java/org/apache/aurora/common/args/Parsers.java 
> 62564a62d255e640e5790ed2e103ba8425a4c15b 
>   commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
> 3da1812abfdb30f12737b19f5e87bc14a02d4c3f 
>   
> commons/src/main/java/org/apache/aurora/common/args/constraints/RangeNumberVerifier.java
>  27250944a60f906a4c220771e9948ed0297ee76c 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
> 02c10ed067c8395a2688cd69d4d73d5fd17774ff 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
> 1e12b06e284cd2e33b63b3690abd3dcd78f9e777 
>   commons/src/main/java/org/apache/aurora/common/base/Closures.java 
> d6cb82a30a8c6292bab0fa007dce2f54f6b66435 
>   commons/src/main/java/org/apache/aurora/common/base/Commands.java 
> 8a88ae336f57fcdafb984cc3418dcd960da0028d 
>   commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
> 072159e79b2d8872f39dfbba9f6a1d27295f1a7a 
>   commons/src/main/java/org/apache/aurora/common/collections/Pair.java 
> b1f9b6336aa8b8d0ff9e611dc2ad1dc8068ef7f3 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java
>  348a8c923118da3b4399afb1a6f09d904c3b 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSource.java
>  8039def73377b0e56c3106876dc89e9183cd55a1 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/VarsHandler.java
>  d1f23de1a440d47a7754af2c8418e2c4e96bbb84 
>   commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
> 03df9b6f7d31d8567a6bd135654eb39026c375d7 
>   commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
> ff29c39863f044db7fde0fff315621644393429d 
>   commons/src/main/java/org/apache/aurora/common/stats/Ratio.java 
> c332dd3af5712bfb8ed174c2285cac4d30394acc 
>   
> commons/src/main/java/org/apache/aurora/common/testing/easymock/EasyMockTest.java
>  403147527eab46e9c23ab5690d885a6c1deb1c30 
>   commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
> e789f804ecc0053d4605927dc981311af1df94c8 
>   commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 
> 9fbfbb9012414a19cf752d69b48f2e937f4497e7 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
> b10a40327a062b354b42249097c89bf3fbecb1e8 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
> 99a15fe8d58138ebd264d858bff842316928db06 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
> bb6fbced0adc0920592ec14f03a84895829d8812 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> 1761ab70a32656af13a311bcc02f716

Re: Review Request 41074: Use lambdas throughout the project.

2015-12-08 Thread Bill Farner 


> On Dec. 8, 2015, 9:31 a.m., Maxim Khutornenko wrote:
> > commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java, line 99
> > 
> >
> > Fits to previous line.

Done, also converted to method reference.  Also ran a broader search for 
conversions to method refs and found/converted ~50.


> On Dec. 8, 2015, 9:31 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/http/Offers.java, line 65
> > 
> >
> > same here

Done, also converted to method reference.


> On Dec. 8, 2015, 9:31 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, 
> > line 153
> > 
> >
> > same

Done.


> On Dec. 8, 2015, 9:31 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, 
> > line 294
> > 
> >
> > same

Done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41074/#review109346
---


On Dec. 7, 2015, 9:08 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41074/
> ---
> 
> (Updated Dec. 7, 2015, 9:08 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is almost entirely IDE-assisted.  There were some spots that required 
> hand-editing (notably casting the argument to `storage.write`).
> 
> The overall stats are nice, a reduction of about 1300 lines:
> ```
>  114 files changed, 1982 insertions(+), 3292 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java
>  5abb06b1d41f3265d9d46c600ba193ce19d21188 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java
>  d06ec69cb57d9c411ae33b301489f6460197dcc7 
>   commons/src/main/java/org/apache/aurora/common/args/ArgFilters.java 
> 9a4d441023fd9eea868fd069c197eb002d98f0ab 
>   commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
> cc4710cb5f559a108b140489a981a9d2c195b75b 
>   commons/src/main/java/org/apache/aurora/common/args/Args.java 
> ad0b299057e787a9587822e7778bd360f77e1678 
>   commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java 
> 051e3f93ef17de90b7bffaa74fc6b54965927424 
>   commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 
> c1fe1c73c46da21c471b2669dbb8207b7c468054 
>   commons/src/main/java/org/apache/aurora/common/args/Parsers.java 
> 62564a62d255e640e5790ed2e103ba8425a4c15b 
>   commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
> 3da1812abfdb30f12737b19f5e87bc14a02d4c3f 
>   
> commons/src/main/java/org/apache/aurora/common/args/constraints/RangeNumberVerifier.java
>  27250944a60f906a4c220771e9948ed0297ee76c 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
> 02c10ed067c8395a2688cd69d4d73d5fd17774ff 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
> 1e12b06e284cd2e33b63b3690abd3dcd78f9e777 
>   commons/src/main/java/org/apache/aurora/common/base/Closures.java 
> d6cb82a30a8c6292bab0fa007dce2f54f6b66435 
>   commons/src/main/java/org/apache/aurora/common/base/Commands.java 
> 8a88ae336f57fcdafb984cc3418dcd960da0028d 
>   commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
> 072159e79b2d8872f39dfbba9f6a1d27295f1a7a 
>   commons/src/main/java/org/apache/aurora/common/collections/Pair.java 
> b1f9b6336aa8b8d0ff9e611dc2ad1dc8068ef7f3 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java
>  348a8c923118da3b4399afb1a6f09d904c3b 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSource.java
>  8039def73377b0e56c3106876dc89e9183cd55a1 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/VarsHandler.java
>  d1f23de1a440d47a7754af2c8418e2c4e96bbb84 
>   commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
> 03df9b6f7d31d8567a6bd135654eb39026c375d7 
>   commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
> ff29c39863f044db7fde0fff315621644393429d 
>   commons/src/main/java/org/apache/aurora/common/stats/Ratio.java 
> c332dd3af5712bfb8ed174c2285cac4d30394acc 
>   
> commons/src/main/java/org/apache/aurora/common/testing/easymock/EasyMockTest.java
>  403147527eab46e9c23ab5690d885a6c1deb1c30 
>   commons/src/main/java/org/apache

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-08 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/#review109348
---


Thanks for following up! Minor change left before we can ship it.


src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
 (line 71)


s/public/private

Also, please move it to the end of the file as we tend to keep private 
helpers there.


- Maxim Khutornenko


On Dec. 8, 2015, 3:46 a.m., Tengfei Mu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41048/
> ---
> 
> (Updated Dec. 8, 2015, 3:46 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1547
> https://issues.apache.org/jira/browse/AURORA-1547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> set TaskStatus.slave_id field in TaskReconsiler
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> c797914ded51cd123dddef188373fe58e190773a 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  1308a1c9884e7759e6139787710b367bbf9cd4e9 
> 
> Diff: https://reviews.apache.org/r/41048/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Tengfei Mu
> 
>

Re: Review Request 41074: Use lambdas throughout the project.

2015-12-08 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41074/#review109346
---

Ship it!



commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java (line 91)


Fits to previous line.



src/main/java/org/apache/aurora/scheduler/http/Offers.java (line 65)


same here



src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java (line 
143)


same



src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java (line 
279)


same


- Maxim Khutornenko


On Dec. 8, 2015, 5:08 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41074/
> ---
> 
> (Updated Dec. 8, 2015, 5:08 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is almost entirely IDE-assisted.  There were some spots that required 
> hand-editing (notably casting the argument to `storage.write`).
> 
> The overall stats are nice, a reduction of about 1300 lines:
> ```
>  114 files changed, 1982 insertions(+), 3292 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java
>  5abb06b1d41f3265d9d46c600ba193ce19d21188 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java
>  d06ec69cb57d9c411ae33b301489f6460197dcc7 
>   commons/src/main/java/org/apache/aurora/common/args/ArgFilters.java 
> 9a4d441023fd9eea868fd069c197eb002d98f0ab 
>   commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
> cc4710cb5f559a108b140489a981a9d2c195b75b 
>   commons/src/main/java/org/apache/aurora/common/args/Args.java 
> ad0b299057e787a9587822e7778bd360f77e1678 
>   commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java 
> 051e3f93ef17de90b7bffaa74fc6b54965927424 
>   commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 
> c1fe1c73c46da21c471b2669dbb8207b7c468054 
>   commons/src/main/java/org/apache/aurora/common/args/Parsers.java 
> 62564a62d255e640e5790ed2e103ba8425a4c15b 
>   commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
> 3da1812abfdb30f12737b19f5e87bc14a02d4c3f 
>   
> commons/src/main/java/org/apache/aurora/common/args/constraints/RangeNumberVerifier.java
>  27250944a60f906a4c220771e9948ed0297ee76c 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
> 02c10ed067c8395a2688cd69d4d73d5fd17774ff 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
> 1e12b06e284cd2e33b63b3690abd3dcd78f9e777 
>   commons/src/main/java/org/apache/aurora/common/base/Closures.java 
> d6cb82a30a8c6292bab0fa007dce2f54f6b66435 
>   commons/src/main/java/org/apache/aurora/common/base/Commands.java 
> 8a88ae336f57fcdafb984cc3418dcd960da0028d 
>   commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
> 072159e79b2d8872f39dfbba9f6a1d27295f1a7a 
>   commons/src/main/java/org/apache/aurora/common/collections/Pair.java 
> b1f9b6336aa8b8d0ff9e611dc2ad1dc8068ef7f3 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java
>  348a8c923118da3b4399afb1a6f09d904c3b 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSource.java
>  8039def73377b0e56c3106876dc89e9183cd55a1 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/VarsHandler.java
>  d1f23de1a440d47a7754af2c8418e2c4e96bbb84 
>   commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
> 03df9b6f7d31d8567a6bd135654eb39026c375d7 
>   commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
> ff29c39863f044db7fde0fff315621644393429d 
>   commons/src/main/java/org/apache/aurora/common/stats/Ratio.java 
> c332dd3af5712bfb8ed174c2285cac4d30394acc 
>   
> commons/src/main/java/org/apache/aurora/common/testing/easymock/EasyMockTest.java
>  403147527eab46e9c23ab5690d885a6c1deb1c30 
>   commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
> e789f804ecc0053d4605927dc981311af1df94c8 
>   commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 
> 9fbfbb9012414a19cf752d69b48f2e937f4497e7 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
> b10a40327a062b354b42249097c89bf3fbecb1e8 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
> 99a15fe8d58138ebd264d858bff842316928db06 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
> bb6fbced0adc