Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review122021
---


Ship it!




Master (3a3415e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 4, 2016, 6:14 a.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 4, 2016, 6:14 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> f4084535f5fc9e3c183cc75a569ec37b4ce90e32 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Amol Deshmukh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/
---

(Updated March 3, 2016, 10:14 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Addressed the last round of review comments:
- Removed the NEWS entry.
- Read default tier config as a ``Resource`` rather than ``File``.


Repository: aurora


Description
---

AURORA-1616: [part 2] make tier_config mandatory argument when starting up the 
scheduler.


Diffs (updated)
-

  docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
  examples/vagrant/upstart/aurora-scheduler.conf 
54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
45ab76b9331a79699979c6386c93bbc763f64e2e 
  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
f4084535f5fc9e3c183cc75a569ec37b4ce90e32 
  src/main/java/org/apache/aurora/scheduler/TierManager.java 
fce6e51548b23b7bc3e33468c2b3a9627a68debd 
  src/main/java/org/apache/aurora/scheduler/TierModule.java 
b5f065ec433b4df50a5c1ca7ef87d51292816db6 
  src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
  src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
  src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
  src/test/resources/org/apache/aurora/scheduler/tiers.json 
21407738fafc9bc5e6ce7888b4b9c32b2f005bca 

Diff: https://reviews.apache.org/r/43925/diff/


Testing
---

# Java build with checkstyle:
```
$ ./gradlew build -Pq
...
BUILD SUCCESSFUL

Total time: 3 mins 44.365 secs
```

# End-to-end tests:
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***

```

# Ensure affected benchmarks run:
```
$ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
...
Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt

$ ls -1 dist/reports/jmh/human.txt
dist/reports/jmh/human.txt
...

```

# Python client tests:
```
./pants test.pytest --no-fast src/test/python/apache/aurora::
...
   SUCCESS
```


Thanks,

Amol Deshmukh

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Amol Deshmukh 


> On March 3, 2016, 6:07 p.m., Bill Farner wrote:
> > NEWS, line 9
> > 
> >
> > This is a kind of lackluster news entry.  What does this actually 
> > _mean_ for users?  Will i see different behavior?  Is there a new 
> > capability i can use?

Agreed. The NEWS entry seemed essential since the original change aimed to make 
the argument required. Now since that is not the case, I will defer adding the 
NEWS entry with the change that actually introduces the ``preemptible`` flag in 
the ``tiers.json`` file.


> On March 3, 2016, 6:07 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TierModule.java, line 75
> > 
> >
> > This code is a bit roundabout, Resource->File->String.  How about:
> > 
> > ```
> > return TIER_CONFIG_FILE.hasAppliedValue()
> > ? Files.toString(TIER_CONFIG_FILE.get())
> > : Resources.toString(
> >   
> > TierModule.class.getClassLoader().getResource(TIER_CONFIG_PATH));
> > ```

Agree, the suggested alternative reads better.


- Amol


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121990
---


On March 2, 2016, 10:53 a.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 10:53 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 43622: Updating scheduler backup restore instructions.

2016-03-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review121997
---


Ship it!




Master (98a2bc1) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 4, 2016, 1:52 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> ---
> 
> (Updated March 4, 2016, 1:52 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
> https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md fe3ee567d085cdfde67dc3efb7c4161f7d5f1999 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 44347: Install thrift package from the offical debs.

2016-03-03 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44347/#review121993
---


Ship it!




Ship It!

- Bill Farner


On March 3, 2016, 10:56 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44347/
> ---
> 
> (Updated March 3, 2016, 10:56 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> `twopercent` pointed out on IRC that due to the people.a.o change our vagrant 
> provisioning was broken. This ports the change from aurora-packaging to our 
> vagrant script.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/provision-dev-cluster.sh 
> 7f71af25d8c32892dc662af732f30f239c4b6e5b 
> 
> Diff: https://reviews.apache.org/r/44347/diff/
> 
> 
> Testing
> ---
> 
> vagrant up
> checked thrift was installed
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121990
---



Code LGTM, only blocker for me is the NEWS.


NEWS (line 8)


remove trailing WS



NEWS (line 9)


This is a kind of lackluster news entry.  What does this actually _mean_ 
for users?  Will i see different behavior?  Is there a new capability i can use?



src/main/java/org/apache/aurora/scheduler/TierModule.java (line 74)


This code is a bit roundabout, Resource->File->String.  How about:

```
return TIER_CONFIG_FILE.hasAppliedValue()
? Files.toString(TIER_CONFIG_FILE.get())
: Resources.toString(
  TierModule.class.getClassLoader().getResource(TIER_CONFIG_PATH));
```


- Bill Farner


On March 2, 2016, 10:53 a.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 10:53 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 43622: Updating scheduler backup restore instructions.

2016-03-03 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/
---

(Updated March 4, 2016, 1:52 a.m.)


Review request for Aurora, John Sirois and Stephan Erb.


Changes
---

Stephan's comments.


Bugs: AURORA-1605
https://issues.apache.org/jira/browse/AURORA-1605


Repository: aurora


Description
---

Updating scheduler backup restore instructions.


Diffs (updated)
-

  docs/client-commands.md fe3ee567d085cdfde67dc3efb7c4161f7d5f1999 
  docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
  docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 

Diff: https://reviews.apache.org/r/43622/diff/


Testing
---

https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup


Thanks,

Maxim Khutornenko

Re: Review Request 43622: Updating scheduler backup restore instructions.

2016-03-03 Thread Maxim Khutornenko 


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 99
> > 
> >
> > I'd propose to move this section after the point "Identify the leading 
> > scheduler". Only at that point it is clear what what scheduler URL to put 
> > there.
> > 
> > Slight nitpick: the sentence is difficult to read due to the duplicate 
> > `aurora_admin`. One of those can be dropped.

I'd rather keep it here as preparation steps may require scheduler restart, 
which will likely change the leader. I've added a sentence suggesting changes 
on all replicas though. This way all preparation steps could easily get 
automated (this is in fact how we do things internally).


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 101
> > 
> >
> > There is a small bug in the referenced documentation snippet. The 
> > `scheduler_url` must contain the schema (`http://`) otherwise `aurora_admin 
> > scheduler_stage_recovery` won't work.

Thanks for pointing out. Fixed.


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 103
> > 
> >
> > Addition regarding my first statement: This sub-section probably does 
> > not need to be moved. In can be kept in the preperation section.

I'd rather keep preparation steps together to logically distiguish potentially 
automatable prep steps from manual restore actions.


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 121
> > 
> >
> > I think we might leave thos one out. Does not seem necessary.

This was supposed to be start not restart. Fixed.


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 143
> > 
> >
> > Two important points are missing here:
> > 
> > * has to be copied into the db backup folder
> > * the `scheduler-backup...` is the file name and not a path

> has to be copied into the db backup folder

Thanks, clarified.

> the scheduler-backup... is the file name and not a path

I thought that's obvious from the command example listed below, no?


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review120329
---


On Feb. 16, 2016, 11:10 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> ---
> 
> (Updated Feb. 16, 2016, 11:10 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
> https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -
> 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

2016-03-03 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121984
---



I think the test failure is because subject is a mock, so you need to add an 
expectation to the test for the `subject.getPrincipal()` call you added to 
generate the response entity?

- Joshua Cohen


On March 3, 2016, 8:16 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> ---
> 
> (Updated March 3, 2016, 8:16 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
> https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
>  3043dfacfe824551b15595a070a1a4fdb7967d3a 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44368: Dropping bulkLoad() from Storage

2016-03-03 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44368/#review121963
---


Ship it!




Ship It!

- Bill Farner


On March 3, 2016, 3:28 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44368/
> ---
> 
> (Updated March 3, 2016, 3:28 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1324
> https://issues.apache.org/jira/browse/AURORA-1324
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This has proven useless and will become even more so with the upcoming 
> MVStore switch in AURORA-1627. Undo log is not honored in MVStore at all per 
> http://www.h2database.com/html/mvstore.html#logStructured
> 
> Master:
> ```
> Benchmark   (updateCount)   
> Mode  Cnt  Score   Error  Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  1  
> thrpt5  4.833 ± 0.313  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  5  
> thrpt5  0.945 ± 0.040  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10  
> thrpt5  0.461 ± 0.054  ops/s
> ```
> 
> This patch:
> ```
> Benchmark   (updateCount)   
> Mode  Cnt  Score   Error  Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  1  
> thrpt5  4.876 ± 0.403  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  5  
> thrpt5  0.942 ± 0.032  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10  
> thrpt5  0.436 ± 0.040  ops/s
> ```
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
> 293b88f462183cc85b02aaf875e887d21f4552c5 
>   
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
>  de4ada431634fb171fab109f1923da810b361205 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 578bb37de8853c4228e76b31f601430b7170946a 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> c0f8d352a56ede9ce96e4dfeb75dab6b97a6 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 243c8a03e72f070538e072afbd3a69f9517f8c26 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java
>  0768ec37bbc6c3c101aa04a953a36a4af7b25963 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 
> 420d444061ba50678fb77fd454a3fe02a8ba189a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 7382eca281eeab17d407ed140f16d6a633d8ad72 
> 
> Diff: https://reviews.apache.org/r/44368/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 44368: Dropping bulkLoad() from Storage

2016-03-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44368/#review121962
---


Ship it!




Master (98a2bc1) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 3, 2016, 11:28 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44368/
> ---
> 
> (Updated March 3, 2016, 11:28 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1324
> https://issues.apache.org/jira/browse/AURORA-1324
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This has proven useless and will become even more so with the upcoming 
> MVStore switch in AURORA-1627. Undo log is not honored in MVStore at all per 
> http://www.h2database.com/html/mvstore.html#logStructured
> 
> Master:
> ```
> Benchmark   (updateCount)   
> Mode  Cnt  Score   Error  Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  1  
> thrpt5  4.833 ± 0.313  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  5  
> thrpt5  0.945 ± 0.040  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10  
> thrpt5  0.461 ± 0.054  ops/s
> ```
> 
> This patch:
> ```
> Benchmark   (updateCount)   
> Mode  Cnt  Score   Error  Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  1  
> thrpt5  4.876 ± 0.403  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  5  
> thrpt5  0.942 ± 0.032  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10  
> thrpt5  0.436 ± 0.040  ops/s
> ```
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
> 293b88f462183cc85b02aaf875e887d21f4552c5 
>   
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
>  de4ada431634fb171fab109f1923da810b361205 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 578bb37de8853c4228e76b31f601430b7170946a 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> c0f8d352a56ede9ce96e4dfeb75dab6b97a6 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 243c8a03e72f070538e072afbd3a69f9517f8c26 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java
>  0768ec37bbc6c3c101aa04a953a36a4af7b25963 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 
> 420d444061ba50678fb77fd454a3fe02a8ba189a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 7382eca281eeab17d407ed140f16d6a633d8ad72 
> 
> Diff: https://reviews.apache.org/r/44368/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 44368: Dropping bulkLoad() from Storage

2016-03-03 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44368/#review121959
---


Ship it!




Ship It!

- Zameer Manji


On March 3, 2016, 3:28 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44368/
> ---
> 
> (Updated March 3, 2016, 3:28 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1324
> https://issues.apache.org/jira/browse/AURORA-1324
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This has proven useless and will become even more so with the upcoming 
> MVStore switch in AURORA-1627. Undo log is not honored in MVStore at all per 
> http://www.h2database.com/html/mvstore.html#logStructured
> 
> Master:
> ```
> Benchmark   (updateCount)   
> Mode  Cnt  Score   Error  Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  1  
> thrpt5  4.833 ± 0.313  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  5  
> thrpt5  0.945 ± 0.040  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10  
> thrpt5  0.461 ± 0.054  ops/s
> ```
> 
> This patch:
> ```
> Benchmark   (updateCount)   
> Mode  Cnt  Score   Error  Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  1  
> thrpt5  4.876 ± 0.403  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  5  
> thrpt5  0.942 ± 0.032  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10  
> thrpt5  0.436 ± 0.040  ops/s
> ```
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
> 293b88f462183cc85b02aaf875e887d21f4552c5 
>   
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
>  de4ada431634fb171fab109f1923da810b361205 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 578bb37de8853c4228e76b31f601430b7170946a 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> c0f8d352a56ede9ce96e4dfeb75dab6b97a6 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 243c8a03e72f070538e072afbd3a69f9517f8c26 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java
>  0768ec37bbc6c3c101aa04a953a36a4af7b25963 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 
> 420d444061ba50678fb77fd454a3fe02a8ba189a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 7382eca281eeab17d407ed140f16d6a633d8ad72 
> 
> Diff: https://reviews.apache.org/r/44368/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 44368: Dropping bulkLoad() from Storage

2016-03-03 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44368/#review121958
---


Ship it!




Ship It!

- Joshua Cohen


On March 3, 2016, 11:28 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44368/
> ---
> 
> (Updated March 3, 2016, 11:28 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1324
> https://issues.apache.org/jira/browse/AURORA-1324
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This has proven useless and will become even more so with the upcoming 
> MVStore switch in AURORA-1627. Undo log is not honored in MVStore at all per 
> http://www.h2database.com/html/mvstore.html#logStructured
> 
> Master:
> ```
> Benchmark   (updateCount)   
> Mode  Cnt  Score   Error  Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  1  
> thrpt5  4.833 ± 0.313  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  5  
> thrpt5  0.945 ± 0.040  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10  
> thrpt5  0.461 ± 0.054  ops/s
> ```
> 
> This patch:
> ```
> Benchmark   (updateCount)   
> Mode  Cnt  Score   Error  Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  1  
> thrpt5  4.876 ± 0.403  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  5  
> thrpt5  0.942 ± 0.032  ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10  
> thrpt5  0.436 ± 0.040  ops/s
> ```
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
> 293b88f462183cc85b02aaf875e887d21f4552c5 
>   
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
>  de4ada431634fb171fab109f1923da810b361205 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 578bb37de8853c4228e76b31f601430b7170946a 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> c0f8d352a56ede9ce96e4dfeb75dab6b97a6 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 243c8a03e72f070538e072afbd3a69f9517f8c26 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java
>  0768ec37bbc6c3c101aa04a953a36a4af7b25963 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 
> 420d444061ba50678fb77fd454a3fe02a8ba189a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 7382eca281eeab17d407ed140f16d6a633d8ad72 
> 
> Diff: https://reviews.apache.org/r/44368/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 44368: Dropping bulkLoad() from Storage

2016-03-03 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44368/
---

Review request for Aurora, Joshua Cohen and Zameer Manji.


Bugs: AURORA-1324
https://issues.apache.org/jira/browse/AURORA-1324


Repository: aurora


Description
---

This has proven useless and will become even more so with the upcoming MVStore 
switch in AURORA-1627. Undo log is not honored in MVStore at all per 
http://www.h2database.com/html/mvstore.html#logStructured

Master:
```
Benchmark   (updateCount)   
Mode  Cnt  Score   Error  Units
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  1  
thrpt5  4.833 ± 0.313  ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  5  
thrpt5  0.945 ± 0.040  ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10  
thrpt5  0.461 ± 0.054  ops/s
```

This patch:
```
Benchmark   (updateCount)   
Mode  Cnt  Score   Error  Units
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  1  
thrpt5  4.876 ± 0.403  ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run  5  
thrpt5  0.942 ± 0.032  ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10  
thrpt5  0.436 ± 0.040  ops/s
```


Diffs
-

  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
dc1ef82bce9e8e243974f8b97165f4417d870a7e 
  src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
293b88f462183cc85b02aaf875e887d21f4552c5 
  
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
 de4ada431634fb171fab109f1923da810b361205 
  src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
578bb37de8853c4228e76b31f601430b7170946a 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
c0f8d352a56ede9ce96e4dfeb75dab6b97a6 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
243c8a03e72f070538e072afbd3a69f9517f8c26 
  
src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java 
0768ec37bbc6c3c101aa04a953a36a4af7b25963 
  src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 
420d444061ba50678fb77fd454a3fe02a8ba189a 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
7382eca281eeab17d407ed140f16d6a633d8ad72 

Diff: https://reviews.apache.org/r/44368/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121951
---



Master (98a2bc1) is red with this patch.
  ./build-support/jenkins/build.sh

+ date
Thu Mar  3 22:58:59 UTC 2016
+ ./gradlew -Pq clean build
:buildSrc:clean UP-TO-DATE
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'aurora'.
> Could not open proj class cache for build file 
> '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' 
> (/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/proj).
   > Timeout waiting to lock proj class cache for build file 
'/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' 
(/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/proj).
 It is currently in use by another Gradle instance.
 Owner PID: unknown
 Our PID: 29449
 Owner Operation: unknown
 Our operation: Initialize cache
 Lock file: 
/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/proj/cache.properties.lock

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 29.795 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 2, 2016, 6:53 p.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 6:53 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Amol Deshmukh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121949
---



@ReviewBot retry

Apologies for the spam, but ``$ ./build-support/jenkins/build.sh`` is a success 
in my local branch. I'm guessing this is some kind of a transient error.

- Amol Deshmukh


On March 2, 2016, 10:53 a.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 10:53 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

2016-03-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121943
---



Master (98a2bc1) is red with this patch.
  ./build-support/jenkins/build.sh


:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
:pmdTest
:test

org.apache.aurora.scheduler.http.api.security.ShiroAuthorizingParamInterceptorTest
 > testKillTasksWithTargetedPermission FAILED
java.lang.AssertionError at ShiroAuthorizingParamInterceptorTest.java:153
I0303 21:43:46.663 [ShutdownHook, SchedulerMain:99] Stopping scheduler 
services. 

937 tests completed, 1 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: 
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage is 0.8892392016103606, but must be greater than 0.89
Branch coverage is 0.8216764548852109, but must be greater than 0.835

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 10 mins 48.991 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 3, 2016, 8:16 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> ---
> 
> (Updated March 3, 2016, 8:16 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
> https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
>  3043dfacfe824551b15595a070a1a4fdb7967d3a 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

2016-03-03 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121941
---



@ReviewBot retry

- Zameer Manji


On March 3, 2016, 12:16 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> ---
> 
> (Updated March 3, 2016, 12:16 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
> https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
>  3043dfacfe824551b15595a070a1a4fdb7967d3a 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

2016-03-03 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121935
---



Is the build failure related? Code change itself looks fine (thus the ship it 
above).

- Stephan Erb


On März 3, 2016, 9:16 nachm., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> ---
> 
> (Updated März 3, 2016, 9:16 nachm.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
> https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
>  3043dfacfe824551b15595a070a1a4fdb7967d3a 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

2016-03-03 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121934
---


Ship it!




Ship It!

- Stephan Erb


On März 3, 2016, 9:16 nachm., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> ---
> 
> (Updated März 3, 2016, 9:16 nachm.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
> https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
>  3043dfacfe824551b15595a070a1a4fdb7967d3a 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

2016-03-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121931
---



Master (98a2bc1) is red with this patch.
  ./build-support/jenkins/build.sh

:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
:pmdTest
:test

org.apache.aurora.scheduler.http.api.security.ShiroAuthorizingParamInterceptorTest
 > testKillTasksWithTargetedPermission FAILED
java.lang.AssertionError at ShiroAuthorizingParamInterceptorTest.java:153
I0303 20:23:09.577 [ShutdownHook, SchedulerMain:99] Stopping scheduler 
services. 
I0303 20:23:09.769 [RedirectMonitor STARTING-SendThread(localhost:34478), 
ClientCnxn$SendThread:975] Opening socket connection to server 
localhost/127.0.0.1:34478. Will not attempt to authenticate using SASL (unknown 
error) 
W0303 20:23:09.771 [RedirectMonitor STARTING-SendThread(localhost:34478), 
ClientCnxn$SendThread:1102] Session 0x1533e2537af for server null, 
unexpected error, closing socket connection and attempting reconnect 
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
~[na:1.8.0_45]
at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
~[na:1.8.0_45]
at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
 ~[zookeeper-3.4.6.jar:3.4.6-1569965]
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081) 
~[zookeeper-3.4.6.jar:3.4.6-1569965]


937 tests completed, 1 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: 
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage is 0.889190696772003, but must be greater than 0.89
Branch coverage is 0.8211425520555259, but must be greater than 0.835

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 10 mins 24.721 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 3, 2016, 8:16 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> ---
> 
> (Updated March 3, 2016, 8:16 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
> https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
>  3043dfacfe824551b15595a070a1a4fdb7967d3a 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121929
---



Master (98a2bc1) is red with this patch.
  ./build-support/jenkins/build.sh

   
self._clock.converge(threads=[hct.threaded_health_checker])
   
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)
 
   assert hct._total_latency == 0
   assert 
hct.metrics.sample()['total_latency_secs'] == 0
 
   # start the health check (during health check it 
is still 0)
   epsilon = 0.001
   self._clock.tick(1.0 + epsilon)
   
self._clock.converge(threads=[hct.threaded_health_checker])
   
self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)
   assert hct._total_latency == 0
   assert 
hct.metrics.sample()['total_latency_secs'] == 0
   assert hct.metrics.sample()['checks'] == 0
 
   # finish the health check
   self._clock.tick(0.5 + epsilon)
   
self._clock.converge(threads=[hct.threaded_health_checker])
   
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # 
interval_secs
 > assert hct._total_latency == 0.5
 E AssertionError: assert 0.5009 
== 0.5
 E  +  where 0.5009 = 
._total_latency
 
 
src/test/python/apache/aurora/executor/common/test_health_checker.py:174: 
AssertionError
 -- Captured stderr call --
 [] Time now: 0.0
 [] Time now: 0.0
 [] Time now: 1.0
 [] Time now: 1.001
 [] Time now: 1.001
 [] Time now: 1.501
 [] Time now: 1.502
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  1 failed, 660 passed, 5 skipped, 1 warnings in 
406.90 seconds 
 
FAILURE


20:13:21 07:48   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 2, 2016, 6:53 p.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 6:53 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ..

Review Request 44354: Show principal in auth failure messaage.

2016-03-03 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/
---

Review request for Aurora and Stephan Erb.


Bugs: AURORA-1628
https://issues.apache.org/jira/browse/AURORA-1628


Repository: aurora


Description
---

Show principal in auth failure messaage.


Diffs
-

  
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
 3043dfacfe824551b15595a070a1a4fdb7967d3a 

Diff: https://reviews.apache.org/r/44354/diff/


Testing
---


Thanks,

Zameer Manji

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Amol Deshmukh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121924
---



@ReviewBot retry

- Amol Deshmukh


On March 2, 2016, 10:53 a.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 10:53 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 44347: Install thrift package from the offical debs.

2016-03-03 Thread Jake Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44347/#review121917
---


Ship it!




Ship It!

- Jake Farrell


On March 3, 2016, 6:56 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44347/
> ---
> 
> (Updated March 3, 2016, 6:56 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> `twopercent` pointed out on IRC that due to the people.a.o change our vagrant 
> provisioning was broken. This ports the change from aurora-packaging to our 
> vagrant script.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/provision-dev-cluster.sh 
> 7f71af25d8c32892dc662af732f30f239c4b6e5b 
> 
> Diff: https://reviews.apache.org/r/44347/diff/
> 
> 
> Testing
> ---
> 
> vagrant up
> checked thrift was installed
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44347: Install thrift package from the offical debs.

2016-03-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44347/#review121911
---


Ship it!




Master (98a2bc1) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 3, 2016, 6:56 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44347/
> ---
> 
> (Updated March 3, 2016, 6:56 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> `twopercent` pointed out on IRC that due to the people.a.o change our vagrant 
> provisioning was broken. This ports the change from aurora-packaging to our 
> vagrant script.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/provision-dev-cluster.sh 
> 7f71af25d8c32892dc662af732f30f239c4b6e5b 
> 
> Diff: https://reviews.apache.org/r/44347/diff/
> 
> 
> Testing
> ---
> 
> vagrant up
> checked thrift was installed
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Review Request 44347: Install thrift package from the offical debs.

2016-03-03 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44347/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

`twopercent` pointed out on IRC that due to the people.a.o change our vagrant 
provisioning was broken. This ports the change from aurora-packaging to our 
vagrant script.


Diffs
-

  examples/vagrant/provision-dev-cluster.sh 
7f71af25d8c32892dc662af732f30f239c4b6e5b 

Diff: https://reviews.apache.org/r/44347/diff/


Testing
---

vagrant up
checked thrift was installed


Thanks,

Zameer Manji

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Amol Deshmukh 


> On March 2, 2016, 11:15 a.m., Aurora ReviewBot wrote:
> > Master (8f98e6e) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >    self._clock.tick(0.5 + epsilon)
> >    
> > self._clock.converge(threads=[hct.threaded_health_checker])
> >    
> > self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # 
> > interval_secs
> >    assert hct._total_latency == 0.5
> >    assert 
> > hct.metrics.sample()['total_latency_secs'] == 0.5
> >    assert hct.metrics.sample()['checks'] == 
> > 1
> >  
> >    # tick again
> >    self._clock.tick(1.0 + epsilon)
> >    
> > self._clock.converge(threads=[hct.threaded_health_checker])
> >    self._clock.tick(0.5 + epsilon)
> >    
> > self._clock.converge(threads=[hct.threaded_health_checker])
> >    
> > self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # 
> > interval_secs
> >  > assert hct._total_latency == 1.0
> >  E AssertionError: assert 1.001 == 1.0
> >  E  +  where 1.001 = 
> >  > 0x7faff1015990>._total_latency
> >  
> >  
> > src/test/python/apache/aurora/executor/common/test_health_checker.py:184: 
> > AssertionError
> >  -- Captured stderr call --
> >  [ > 0x7faff1015fd0>] Time now: 0.0
> >  [ > 0x7faff1015fd0>] Time now: 0.0
> >  [ > 0x7faff1015fd0>] Time now: 1.0
> >  [ > 0x7faff1015fd0>] Time now: 1.001
> >  [ > 0x7faff1015fd0>] Time now: 1.001
> >  [ > 0x7faff1015fd0>] Time now: 1.501
> >  [ > 0x7faff1015fd0>] Time now: 1.502
> >  [ > 0x7faff1015fd0>] Time now: 1.502
> >  [ > 0x7faff1015fd0>] Time now: 2.502
> >  [ > 0x7faff1015fd0>] Time now: 2.503
> >  [ > 0x7faff1015fd0>] Time now: 2.503
> >  [ > 0x7faff1015fd0>] Time now: 3.003
> >  [ > 0x7faff1015fd0>] Time now: 3.004
> >   generated xml file: 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
> >  
> >   1 failed, 660 passed, 5 skipped, 1 warnings 
> > in 412.03 seconds 
> >  
> > FAILURE
> > 
> > 
> > 19:08:49 08:02   [complete]
> >FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

@ReviewBot retry


- Amol


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121694
---


On March 2, 2016, 10:53 a.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 10:53 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89a

Re: Review Request 44341: Updating documentation Update configuration-reference.md documentation on supporting private docker registry.

2016-03-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44341/#review121875
---



Master (8f98e6e) is red with this patch.
  ./build-support/jenkins/build.sh

   
self._clock.converge(threads=[hct.threaded_health_checker])
   
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)
 
   assert hct._total_latency == 0
   assert 
hct.metrics.sample()['total_latency_secs'] == 0
 
   # start the health check (during health check it 
is still 0)
   epsilon = 0.001
   self._clock.tick(1.0 + epsilon)
   
self._clock.converge(threads=[hct.threaded_health_checker])
   
self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)
   assert hct._total_latency == 0
   assert 
hct.metrics.sample()['total_latency_secs'] == 0
   assert hct.metrics.sample()['checks'] == 0
 
   # finish the health check
   self._clock.tick(0.5 + epsilon)
   
self._clock.converge(threads=[hct.threaded_health_checker])
   
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # 
interval_secs
 > assert hct._total_latency == 0.5
 E AssertionError: assert 0.5009 
== 0.5
 E  +  where 0.5009 = 
._total_latency
 
 
src/test/python/apache/aurora/executor/common/test_health_checker.py:174: 
AssertionError
 -- Captured stderr call --
 [] Time now: 0.0
 [] Time now: 0.0
 [] Time now: 1.0
 [] Time now: 1.001
 [] Time now: 1.001
 [] Time now: 1.501
 [] Time now: 1.502
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  1 failed, 660 passed, 5 skipped, 1 warnings in 
336.71 seconds 
 
FAILURE


16:47:38 06:34   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 3, 2016, 4:27 p.m., krish i wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44341/
> ---
> 
> (Updated March 3, 2016, 4:27 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating documentation Update configuration-reference.md documentation on 
> supporting private docker registry.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md 3f023d77e1f8a1cc13abeaba9a4b69879f42bba4 
> 
> Diff: https://reviews.apache.org/r/44341/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> krish i
> 
>

Re: Review Request 44341: Updating documentation Update configuration-reference.md documentation on supporting private docker registry.

2016-03-03 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44341/#review121873
---


Ship it!




Ship It!

- Bill Farner


On March 3, 2016, 8:27 a.m., krish i wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44341/
> ---
> 
> (Updated March 3, 2016, 8:27 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating documentation Update configuration-reference.md documentation on 
> supporting private docker registry.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md 3f023d77e1f8a1cc13abeaba9a4b69879f42bba4 
> 
> Diff: https://reviews.apache.org/r/44341/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> krish i
> 
>

Review Request 44341: Updating documentation Update configuration-reference.md documentation on supporting private docker registry.

2016-03-03 Thread krish i 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44341/
---

Review request for Aurora.


Repository: aurora


Description
---

Updating documentation Update configuration-reference.md documentation on 
supporting private docker registry.


Diffs
-

  docs/configuration-reference.md 3f023d77e1f8a1cc13abeaba9a4b69879f42bba4 

Diff: https://reviews.apache.org/r/44341/diff/


Testing
---


Thanks,

krish i