Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

2016-06-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49413/#review140090
---


Ship it!




Master (6f93ae2) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 30, 2016, 12:10 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49413/
> ---
> 
> (Updated June 30, 2016, 12:10 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> docs/operations/installation.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 
> 
> Diff: https://reviews.apache.org/r/49413/diff/
> 
> 
> Testing
> ---
> 
> Came across the issue testing the 0.13.0 and 0.14.0 releases.
> 
> Rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

2016-06-29 Thread John Sirois 


> On June 29, 2016, 6:23 p.m., John Sirois wrote:
> > @ReviewBot retry
> 
> John Sirois wrote:
> FWIW: The failures that lead to this sort of "coverage missing" are all 
> intergation test connect errors to an in-process servlet engine:
>   https://gist.github.com/jsirois/32f629a2e950d28e8910fe3d62e928d8
>   
> I'll see if this is not something obviously fixable.

Nothing obviously wrong, ephemeral ports appear to be used in these tests 
exclusively.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49413/#review140080
---


On June 29, 2016, 6:10 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49413/
> ---
> 
> (Updated June 29, 2016, 6:10 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> docs/operations/installation.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 
> 
> Diff: https://reviews.apache.org/r/49413/diff/
> 
> 
> Testing
> ---
> 
> Came across the issue testing the 0.13.0 and 0.14.0 releases.
> 
> Rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

2016-06-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49413/#review140086
---



Master (6f93ae2) is red with this patch.
  ./build-support/jenkins/build.sh

thrift-0.9.1/tutorial/py/Makefile.am
thrift-0.9.1/tutorial/py/Makefile.in
thrift-0.9.1/tutorial/py/PythonClient.py
thrift-0.9.1/tutorial/py/PythonServer.py
thrift-0.9.1/tutorial/py.tornado/
thrift-0.9.1/tutorial/py.tornado/Makefile.am
thrift-0.9.1/tutorial/py.tornado/Makefile.in
thrift-0.9.1/tutorial/py.tornado/PythonClient.py
thrift-0.9.1/tutorial/py.tornado/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/
thrift-0.9.1/tutorial/py.twisted/Makefile.am
thrift-0.9.1/tutorial/py.twisted/Makefile.in
thrift-0.9.1/tutorial/py.twisted/PythonClient.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.tac
thrift-0.9.1/tutorial/rb/
thrift-0.9.1/tutorial/rb/Makefile.am
thrift-0.9.1/tutorial/rb/Makefile.in
thrift-0.9.1/tutorial/rb/RubyClient.rb
thrift-0.9.1/tutorial/rb/RubyServer.rb
thrift-0.9.1/tutorial/README
thrift-0.9.1/tutorial/shared.thrift
thrift-0.9.1/tutorial/tutorial.thrift
thrift-0.9.1/ylwrap
make: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
make: *** [thrift-0.9.1/compiler/cpp/thrift] Error 1
:api:generateThriftJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':api:generateThriftJava'.
> Process 'command 
> '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thriftw''
>  finished with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 16.027 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 30, 2016, 12:10 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49413/
> ---
> 
> (Updated June 30, 2016, 12:10 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> docs/operations/installation.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 
> 
> Diff: https://reviews.apache.org/r/49413/diff/
> 
> 
> Testing
> ---
> 
> Came across the issue testing the 0.13.0 and 0.14.0 releases.
> 
> Rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

2016-06-29 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49413/#review140085
---



@ReviewBot retry

- John Sirois


On June 29, 2016, 6:10 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49413/
> ---
> 
> (Updated June 29, 2016, 6:10 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> docs/operations/installation.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 
> 
> Diff: https://reviews.apache.org/r/49413/diff/
> 
> 
> Testing
> ---
> 
> Came across the issue testing the 0.13.0 and 0.14.0 releases.
> 
> Rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

2016-06-29 Thread John Sirois 


> On June 29, 2016, 6:23 p.m., John Sirois wrote:
> > @ReviewBot retry

FWIW: The failures that lead to this sort of "coverage missing" are all 
intergation test connect errors to an in-process servlet engine:
  https://gist.github.com/jsirois/32f629a2e950d28e8910fe3d62e928d8
  
I'll see if this is not something obviously fixable.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49413/#review140080
---


On June 29, 2016, 6:10 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49413/
> ---
> 
> (Updated June 29, 2016, 6:10 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> docs/operations/installation.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 
> 
> Diff: https://reviews.apache.org/r/49413/diff/
> 
> 
> Testing
> ---
> 
> Came across the issue testing the 0.13.0 and 0.14.0 releases.
> 
> Rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

2016-06-29 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49413/#review140080
---



@ReviewBot retry

- John Sirois


On June 29, 2016, 6:10 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49413/
> ---
> 
> (Updated June 29, 2016, 6:10 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> docs/operations/installation.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 
> 
> Diff: https://reviews.apache.org/r/49413/diff/
> 
> 
> Testing
> ---
> 
> Came across the issue testing the 0.13.0 and 0.14.0 releases.
> 
> Rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

2016-06-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49413/#review140078
---



Master (6f93ae2) is red with this patch.
  ./build-support/jenkins/build.sh

1014 tests completed, 31 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: 
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage is 0.8706842152708916, but must be greater than 0.89
Branch coverage is 0.7772420443587271, but must be greater than 0.835
:analyzeReport FAILED

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
---
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

2: Task failed with an exception.
---
* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for 
> org/apache/aurora/scheduler/http/LeaderRedirectFilter
  Test coverage missing for org/apache/aurora/scheduler/http/HttpStatsFilter
  Test coverage missing for org/apache/aurora/scheduler/http/HttpStatsFilter$1
  Test coverage missing for 
org/apache/aurora/scheduler/http/HttpStatsFilter$ResponseWithStatus
  Test coverage missing for 
org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter
  Test coverage missing for 
org/apache/aurora/scheduler/http/api/security/ShiroKerberosPermissiveAuthenticationFilter
  Test coverage missing for org/apache/aurora/scheduler/http/api/ApiBeta

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

BUILD FAILED

Total time: 6 mins 30.748 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 30, 2016, 12:10 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49413/
> ---
> 
> (Updated June 30, 2016, 12:10 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> docs/operations/installation.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 
> 
> Diff: https://reviews.apache.org/r/49413/diff/
> 
> 
> Testing
> ---
> 
> Came across the issue testing the 0.13.0 and 0.14.0 releases.
> 
> Rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

2016-06-29 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49413/#review140077
---



NB: The packaging change was here:
  
https://git-wip-us.apache.org/repos/asf?p=aurora-packaging.git;a=commit;h=a665227c0d1634fe69bb9c45559f7d1ff69a4c03

- John Sirois


On June 29, 2016, 6:10 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49413/
> ---
> 
> (Updated June 29, 2016, 6:10 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> docs/operations/installation.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 
> 
> Diff: https://reviews.apache.org/r/49413/diff/
> 
> 
> Testing
> ---
> 
> Came across the issue testing the 0.13.0 and 0.14.0 releases.
> 
> Rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

2016-06-29 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49413/
---

Review request for Aurora and Stephan Erb.


Repository: aurora


Description
---

docs/operations/installation.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Diffs
-

  docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 

Diff: https://reviews.apache.org/r/49413/diff/


Testing
---

Came across the issue testing the 0.13.0 and 0.14.0 releases.

Rendered here:
  
https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2


Thanks,

John Sirois

Re: Review Request 49399: Fix Process log configuration handling.

2016-06-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49399/#review140070
---


Ship it!




Master (6f93ae2) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 29, 2016, 11 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49399/
> ---
> 
> (Updated June 29, 2016, 11 p.m.)
> 
> 
> Review request for Aurora, George Sirois, Martin Hrabovcin, and Stephan Erb.
> 
> 
> Bugs: AURORA-1724
> https://issues.apache.org/jira/browse/AURORA-1724
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Previously flagged configuration of Process logging mode would
> blow up and claimed defaulting of the rotation policy did not
> occur.
> 
>  docs/operations/configuration.md|   9 +-
>  docs/reference/configuration.md |  33 
> 
>  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py |  21 
> ++---
>  src/main/python/apache/thermos/core/runner.py   |  40 
> ++---
>  src/main/python/apache/thermos/testing/runner.py|  16 
> ++--
>  src/test/python/apache/thermos/core/BUILD   |   2 +
>  src/test/python/apache/thermos/core/test_runner_log_config.py   | 230 
> ++
>  7 files changed, 293 insertions(+), 58 deletions(-)
> 
> 
> Diffs
> -
> 
>   docs/operations/configuration.md e332f864aeb25790f860bc1961a7a2c49b29004e 
>   docs/reference/configuration.md c4b1d387435e4b8fd59a296bd5d6d203bb50cbde 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 203fc47d74840889a1192dc867fef5584b704685 
>   src/main/python/apache/thermos/core/runner.py 
> 3ebf86ebd12ed3b68f543d4b9a45615e4681ba7f 
>   src/main/python/apache/thermos/testing/runner.py 
> 8b6ba730acedf284a61e4bde60ab480950f92ede 
>   src/test/python/apache/thermos/core/BUILD 
> acfb79b6c411744be7f8b3bb364f0c8d049f1694 
>   src/test/python/apache/thermos/core/test_runner_log_config.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49399/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the cases in
>   https://issues.apache.org/jira/browse/AURORA-1724.
> 
> Also ran the following green locally:
> ```
> ./pants test src/test/python/apache/thermos/core
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> Doc edits are rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/reference/configuration.md#logger
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/operations/configuration.md#process-logs
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49399: Fix Process log configuration handling.

2016-06-29 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49399/#review140067
---



@ReviewBot retry

- John Sirois


On June 29, 2016, 5 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49399/
> ---
> 
> (Updated June 29, 2016, 5 p.m.)
> 
> 
> Review request for Aurora, George Sirois, Martin Hrabovcin, and Stephan Erb.
> 
> 
> Bugs: AURORA-1724
> https://issues.apache.org/jira/browse/AURORA-1724
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Previously flagged configuration of Process logging mode would
> blow up and claimed defaulting of the rotation policy did not
> occur.
> 
>  docs/operations/configuration.md|   9 +-
>  docs/reference/configuration.md |  33 
> 
>  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py |  21 
> ++---
>  src/main/python/apache/thermos/core/runner.py   |  40 
> ++---
>  src/main/python/apache/thermos/testing/runner.py|  16 
> ++--
>  src/test/python/apache/thermos/core/BUILD   |   2 +
>  src/test/python/apache/thermos/core/test_runner_log_config.py   | 230 
> ++
>  7 files changed, 293 insertions(+), 58 deletions(-)
> 
> 
> Diffs
> -
> 
>   docs/operations/configuration.md e332f864aeb25790f860bc1961a7a2c49b29004e 
>   docs/reference/configuration.md c4b1d387435e4b8fd59a296bd5d6d203bb50cbde 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 203fc47d74840889a1192dc867fef5584b704685 
>   src/main/python/apache/thermos/core/runner.py 
> 3ebf86ebd12ed3b68f543d4b9a45615e4681ba7f 
>   src/main/python/apache/thermos/testing/runner.py 
> 8b6ba730acedf284a61e4bde60ab480950f92ede 
>   src/test/python/apache/thermos/core/BUILD 
> acfb79b6c411744be7f8b3bb364f0c8d049f1694 
>   src/test/python/apache/thermos/core/test_runner_log_config.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49399/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the cases in
>   https://issues.apache.org/jira/browse/AURORA-1724.
> 
> Also ran the following green locally:
> ```
> ./pants test src/test/python/apache/thermos/core
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> Doc edits are rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/reference/configuration.md#logger
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/operations/configuration.md#process-logs
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49399: Fix Process log configuration handling.

2016-06-29 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49399/
---

(Updated June 29, 2016, 5 p.m.)


Review request for Aurora, George Sirois, Martin Hrabovcin, and Stephan Erb.


Changes
---

Remove predecessor RBs from `Depends On` to allow AuroraBot to test this RB:
  https://reviews.apache.org/r/30695/
  https://reviews.apache.org/r/40922/


Bugs: AURORA-1724
https://issues.apache.org/jira/browse/AURORA-1724


Repository: aurora


Description
---

Previously flagged configuration of Process logging mode would
blow up and claimed defaulting of the rotation policy did not
occur.

 docs/operations/configuration.md|   9 +-
 docs/reference/configuration.md |  33 

 src/main/python/apache/aurora/executor/bin/thermos_executor_main.py |  21 ++---
 src/main/python/apache/thermos/core/runner.py   |  40 
++---
 src/main/python/apache/thermos/testing/runner.py|  16 ++--
 src/test/python/apache/thermos/core/BUILD   |   2 +
 src/test/python/apache/thermos/core/test_runner_log_config.py   | 230 
++
 7 files changed, 293 insertions(+), 58 deletions(-)


Diffs
-

  docs/operations/configuration.md e332f864aeb25790f860bc1961a7a2c49b29004e 
  docs/reference/configuration.md c4b1d387435e4b8fd59a296bd5d6d203bb50cbde 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
203fc47d74840889a1192dc867fef5584b704685 
  src/main/python/apache/thermos/core/runner.py 
3ebf86ebd12ed3b68f543d4b9a45615e4681ba7f 
  src/main/python/apache/thermos/testing/runner.py 
8b6ba730acedf284a61e4bde60ab480950f92ede 
  src/test/python/apache/thermos/core/BUILD 
acfb79b6c411744be7f8b3bb364f0c8d049f1694 
  src/test/python/apache/thermos/core/test_runner_log_config.py PRE-CREATION 

Diff: https://reviews.apache.org/r/49399/diff/


Testing
---

Manually tested the cases in
  https://issues.apache.org/jira/browse/AURORA-1724.

Also ran the following green locally:
```
./pants test src/test/python/apache/thermos/core
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```

Doc edits are rendered here:
  
https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/reference/configuration.md#logger
  
https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/operations/configuration.md#process-logs


Thanks,

John Sirois

Re: Review Request 49399: Fix Process log configuration handling.

2016-06-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49399/#review140066
---



Can only test reviews with 1 parent, found 2:
https://reviews.apache.org/api/review-requests/40922/
https://reviews.apache.org/api/review-requests/30695/

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 29, 2016, 10:53 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49399/
> ---
> 
> (Updated June 29, 2016, 10:53 p.m.)
> 
> 
> Review request for Aurora, George Sirois, Martin Hrabovcin, and Stephan Erb.
> 
> 
> Bugs: AURORA-1724
> https://issues.apache.org/jira/browse/AURORA-1724
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Previously flagged configuration of Process logging mode would
> blow up and claimed defaulting of the rotation policy did not
> occur.
> 
>  docs/operations/configuration.md|   9 +-
>  docs/reference/configuration.md |  33 
> 
>  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py |  21 
> ++---
>  src/main/python/apache/thermos/core/runner.py   |  40 
> ++---
>  src/main/python/apache/thermos/testing/runner.py|  16 
> ++--
>  src/test/python/apache/thermos/core/BUILD   |   2 +
>  src/test/python/apache/thermos/core/test_runner_log_config.py   | 230 
> ++
>  7 files changed, 293 insertions(+), 58 deletions(-)
> 
> 
> Diffs
> -
> 
>   docs/operations/configuration.md e332f864aeb25790f860bc1961a7a2c49b29004e 
>   docs/reference/configuration.md c4b1d387435e4b8fd59a296bd5d6d203bb50cbde 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 203fc47d74840889a1192dc867fef5584b704685 
>   src/main/python/apache/thermos/core/runner.py 
> 3ebf86ebd12ed3b68f543d4b9a45615e4681ba7f 
>   src/main/python/apache/thermos/testing/runner.py 
> 8b6ba730acedf284a61e4bde60ab480950f92ede 
>   src/test/python/apache/thermos/core/BUILD 
> acfb79b6c411744be7f8b3bb364f0c8d049f1694 
>   src/test/python/apache/thermos/core/test_runner_log_config.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49399/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the cases in
>   https://issues.apache.org/jira/browse/AURORA-1724.
> 
> Also ran the following green locally:
> ```
> ./pants test src/test/python/apache/thermos/core
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> Doc edits are rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/reference/configuration.md#logger
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/operations/configuration.md#process-logs
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49399: Fix Process log configuration handling.

2016-06-29 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49399/#review140065
---




src/main/python/apache/thermos/core/runner.py (line 747)


NB: The trailing comma here on the LHS formed a 1-tuple leading to the 
initial bug report (wrong type).


- John Sirois


On June 29, 2016, 4:53 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49399/
> ---
> 
> (Updated June 29, 2016, 4:53 p.m.)
> 
> 
> Review request for Aurora, George Sirois, Martin Hrabovcin, and Stephan Erb.
> 
> 
> Bugs: AURORA-1724
> https://issues.apache.org/jira/browse/AURORA-1724
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Previously flagged configuration of Process logging mode would
> blow up and claimed defaulting of the rotation policy did not
> occur.
> 
>  docs/operations/configuration.md|   9 +-
>  docs/reference/configuration.md |  33 
> 
>  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py |  21 
> ++---
>  src/main/python/apache/thermos/core/runner.py   |  40 
> ++---
>  src/main/python/apache/thermos/testing/runner.py|  16 
> ++--
>  src/test/python/apache/thermos/core/BUILD   |   2 +
>  src/test/python/apache/thermos/core/test_runner_log_config.py   | 230 
> ++
>  7 files changed, 293 insertions(+), 58 deletions(-)
> 
> 
> Diffs
> -
> 
>   docs/operations/configuration.md e332f864aeb25790f860bc1961a7a2c49b29004e 
>   docs/reference/configuration.md c4b1d387435e4b8fd59a296bd5d6d203bb50cbde 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 203fc47d74840889a1192dc867fef5584b704685 
>   src/main/python/apache/thermos/core/runner.py 
> 3ebf86ebd12ed3b68f543d4b9a45615e4681ba7f 
>   src/main/python/apache/thermos/testing/runner.py 
> 8b6ba730acedf284a61e4bde60ab480950f92ede 
>   src/test/python/apache/thermos/core/BUILD 
> acfb79b6c411744be7f8b3bb364f0c8d049f1694 
>   src/test/python/apache/thermos/core/test_runner_log_config.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49399/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the cases in
>   https://issues.apache.org/jira/browse/AURORA-1724.
> 
> Also ran the following green locally:
> ```
> ./pants test src/test/python/apache/thermos/core
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> Doc edits are rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/reference/configuration.md#logger
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/operations/configuration.md#process-logs
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Review Request 49399: Fix Process log configuration handling.

2016-06-29 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49399/
---

Review request for Aurora, George Sirois, Martin Hrabovcin, and Stephan Erb.


Bugs: AURORA-1724
https://issues.apache.org/jira/browse/AURORA-1724


Repository: aurora


Description
---

Previously flagged configuration of Process logging mode would
blow up and claimed defaulting of the rotation policy did not
occur.

 docs/operations/configuration.md|   9 +-
 docs/reference/configuration.md |  33 

 src/main/python/apache/aurora/executor/bin/thermos_executor_main.py |  21 ++---
 src/main/python/apache/thermos/core/runner.py   |  40 
++---
 src/main/python/apache/thermos/testing/runner.py|  16 ++--
 src/test/python/apache/thermos/core/BUILD   |   2 +
 src/test/python/apache/thermos/core/test_runner_log_config.py   | 230 
++
 7 files changed, 293 insertions(+), 58 deletions(-)


Diffs
-

  docs/operations/configuration.md e332f864aeb25790f860bc1961a7a2c49b29004e 
  docs/reference/configuration.md c4b1d387435e4b8fd59a296bd5d6d203bb50cbde 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
203fc47d74840889a1192dc867fef5584b704685 
  src/main/python/apache/thermos/core/runner.py 
3ebf86ebd12ed3b68f543d4b9a45615e4681ba7f 
  src/main/python/apache/thermos/testing/runner.py 
8b6ba730acedf284a61e4bde60ab480950f92ede 
  src/test/python/apache/thermos/core/BUILD 
acfb79b6c411744be7f8b3bb364f0c8d049f1694 
  src/test/python/apache/thermos/core/test_runner_log_config.py PRE-CREATION 

Diff: https://reviews.apache.org/r/49399/diff/


Testing
---

Manually tested the cases in
  https://issues.apache.org/jira/browse/AURORA-1724.

Also ran the following green locally:
```
./pants test src/test/python/apache/thermos/core
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```

Doc edits are rendered here:
  
https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/reference/configuration.md#logger
  
https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/operations/configuration.md#process-logs


Thanks,

John Sirois

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

2016-06-29 Thread Joshua Cohen 


> On June 29, 2016, 5:33 p.m., Maxim Khutornenko wrote:
> > @ReviewBot retry

I just ran the jenkins script locally and it passed ok, so I'm going to merge 
this.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140022
---


On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49384/
> ---
> 
> (Updated June 29, 2016, 4:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade to Mesos 0.28.2.
> 
> Release notes: http://mesos.apache.org/blog/mesos-0-28-0-released/, 
> http://mesos.apache.org/blog/mesos-0-28-2-released/
> 
> Upgrade instructions here: 
> http://mesos.apache.org/documentation/latest/upgrades/. Maxim: do we need to 
> do anything about 
> http://mesos.apache.org/documentation/latest/upgrades/#0-28-x-resource-precision?
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 85db569b43a4a121ed6c6b14688e19dd0278e145 
>   RELEASE-NOTES.md 5beda5dcb50ad1d6f50c3deb322587df58bc27d5 
>   Vagrantfile e7e113def27f241fa48a550885eff8faba52375a 
>   build-support/packer/build.sh 2a01d77a08959652a1607f1ade2bb8fbe7555762 
>   build.gradle 0d0d94a80613965282724dd82e61b2363d6a5361 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
> f2ff7abb51101c603df1bd1b21c4920a348743e1 
> 
> Diff: https://reviews.apache.org/r/49384/diff/
> 
> 
> Testing
> ---
> 
> e2e
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

2016-06-29 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140022
---



@ReviewBot retry

- Maxim Khutornenko


On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49384/
> ---
> 
> (Updated June 29, 2016, 4:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade to Mesos 0.28.2.
> 
> Release notes: http://mesos.apache.org/blog/mesos-0-28-0-released/, 
> http://mesos.apache.org/blog/mesos-0-28-2-released/
> 
> Upgrade instructions here: 
> http://mesos.apache.org/documentation/latest/upgrades/. Maxim: do we need to 
> do anything about 
> http://mesos.apache.org/documentation/latest/upgrades/#0-28-x-resource-precision?
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 85db569b43a4a121ed6c6b14688e19dd0278e145 
>   RELEASE-NOTES.md 5beda5dcb50ad1d6f50c3deb322587df58bc27d5 
>   Vagrantfile e7e113def27f241fa48a550885eff8faba52375a 
>   build-support/packer/build.sh 2a01d77a08959652a1607f1ade2bb8fbe7555762 
>   build.gradle 0d0d94a80613965282724dd82e61b2363d6a5361 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
> f2ff7abb51101c603df1bd1b21c4920a348743e1 
> 
> Diff: https://reviews.apache.org/r/49384/diff/
> 
> 
> Testing
> ---
> 
> e2e
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

2016-06-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140018
---



Master (4e28b9c) is red with this patch.
  ./build-support/jenkins/build.sh

   with temporary_dir() as checkpoint_root:
 te = AuroraExecutor(
 >   
runner_provider=make_provider(checkpoint_root),
 
sandbox_provider=DefaultTestSandboxProvider())
 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:580: 
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in 
make_provider
 pex_location=thermos_runner_path(),
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
 build = True
 
 def thermos_runner_path(build=True):
   if not build:
 return getattr(thermos_runner_path, 'value', 
None)
 
   if not hasattr(thermos_runner_path, 'value'):
 pex_dir = safe_mkdtemp()
 >   assert subprocess.call(["./pants", 
"--pants-distdir=%s" % pex_dir, "binary",
   
"src/main/python/apache/thermos/runner:thermos_runner"]) == 0
 E   assert 1 == 0
 E+  where 1 = (['./pants', '--pants-distdir=/tmp/tmp4T5Wpj', 'binary', 
'src/main/python/apache/thermos/runner:thermos_runner'])
 E+where  = subprocess.call
 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: 
AssertionError
 -- Captured stderr call --
 Traceback (most recent call last):
   File 
"/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants", 
line 7, in 
 from pants.bin.pants_exe import main
 ImportError: No module named pants.bin.pants_exe
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  16 failed, 638 passed, 6 skipped, 1 warnings, 8 
error in 122.55 seconds 
 
FAILURE


   Waiting for background workers to finish.
17:21:35 02:45   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49384/
> ---
> 
> (Updated June 29, 2016, 4:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade to Mesos 0.28.2.
> 
> Release notes: http://mesos.apache.org/blog/mesos-0-28-0-released/, 
> http://mesos.apache.org/blog/mesos-0-28-2-released/
> 
> Upgrade instructions here: 
> http://mesos.apache.org/documentation/latest/upgrades/. Maxim: do we need to 
> do anything about 
> http://mesos.apache.org/documentation/latest/upgrades/#0-28-x-resource-precision?
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 85db569b43a4a121ed6c6b14688e19dd0278e145 
>   RELEASE-NOTES.md 5beda5dcb50ad1d6f50c3deb322587df58bc27d5 
>   Vagrantfile e7e113def27f241fa48a550885eff8faba52375a 
>   build-support/packer/build.sh 2a01d77a08959652a1607f1ade2bb8fbe7555762 
>   build.gradle 0d0d94a80613965282724dd82e61b2363d6a5361 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
> f2ff7abb51101c603df1bd1b21c4920a348743e1 
> 
> Diff: https://reviews.apache.org/r/49384/diff/
> 
> 
> Testing
> ---
> 
> e2e
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

2016-06-29 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140014
---


Ship it!




Ship It!

- Maxim Khutornenko


On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49384/
> ---
> 
> (Updated June 29, 2016, 4:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade to Mesos 0.28.2.
> 
> Release notes: http://mesos.apache.org/blog/mesos-0-28-0-released/, 
> http://mesos.apache.org/blog/mesos-0-28-2-released/
> 
> Upgrade instructions here: 
> http://mesos.apache.org/documentation/latest/upgrades/. Maxim: do we need to 
> do anything about 
> http://mesos.apache.org/documentation/latest/upgrades/#0-28-x-resource-precision?
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 85db569b43a4a121ed6c6b14688e19dd0278e145 
>   RELEASE-NOTES.md 5beda5dcb50ad1d6f50c3deb322587df58bc27d5 
>   Vagrantfile e7e113def27f241fa48a550885eff8faba52375a 
>   build-support/packer/build.sh 2a01d77a08959652a1607f1ade2bb8fbe7555762 
>   build.gradle 0d0d94a80613965282724dd82e61b2363d6a5361 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
> f2ff7abb51101c603df1bd1b21c4920a348743e1 
> 
> Diff: https://reviews.apache.org/r/49384/diff/
> 
> 
> Testing
> ---
> 
> e2e
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

2016-06-29 Thread Maxim Khutornenko 


> On June 29, 2016, 4:44 p.m., Maxim Khutornenko wrote:
> > build.gradle, line 368
> > 
> >
> > Should this be 0.28.3 instead? Looking at the changelog I don't see any 
> > relevant changes for us but in case it's easy to bump the version up it 
> > would be great to have the most recent release linked to 0.15.0.
> > 
> > https://github.com/apache/mesos/blob/master/CHANGELOG#L571?
> 
> Joshua Cohen wrote:
> As far as I can tell mesos 0.28.3 has not yet been released. Am I missing 
> something? Latest release [here](http://mesos.apache.org/downloads/) is 
> 0.28.2. Same [here](https://mesosphere.com/downloads/) for the Mesosphere 
> rpms? More than happy to bump up to 0.28.3 when it does actually get 
> released, but it doesn't seem to be available yet.

Ah, that's what I wasn't sure about. Agree, not worth waiting for.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140007
---


On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49384/
> ---
> 
> (Updated June 29, 2016, 4:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade to Mesos 0.28.2.
> 
> Release notes: http://mesos.apache.org/blog/mesos-0-28-0-released/, 
> http://mesos.apache.org/blog/mesos-0-28-2-released/
> 
> Upgrade instructions here: 
> http://mesos.apache.org/documentation/latest/upgrades/. Maxim: do we need to 
> do anything about 
> http://mesos.apache.org/documentation/latest/upgrades/#0-28-x-resource-precision?
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 85db569b43a4a121ed6c6b14688e19dd0278e145 
>   RELEASE-NOTES.md 5beda5dcb50ad1d6f50c3deb322587df58bc27d5 
>   Vagrantfile e7e113def27f241fa48a550885eff8faba52375a 
>   build-support/packer/build.sh 2a01d77a08959652a1607f1ade2bb8fbe7555762 
>   build.gradle 0d0d94a80613965282724dd82e61b2363d6a5361 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
> f2ff7abb51101c603df1bd1b21c4920a348743e1 
> 
> Diff: https://reviews.apache.org/r/49384/diff/
> 
> 
> Testing
> ---
> 
> e2e
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

2016-06-29 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140012
---



@ReviewBot retry

- Joshua Cohen


On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49384/
> ---
> 
> (Updated June 29, 2016, 4:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade to Mesos 0.28.2.
> 
> Release notes: http://mesos.apache.org/blog/mesos-0-28-0-released/, 
> http://mesos.apache.org/blog/mesos-0-28-2-released/
> 
> Upgrade instructions here: 
> http://mesos.apache.org/documentation/latest/upgrades/. Maxim: do we need to 
> do anything about 
> http://mesos.apache.org/documentation/latest/upgrades/#0-28-x-resource-precision?
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 85db569b43a4a121ed6c6b14688e19dd0278e145 
>   RELEASE-NOTES.md 5beda5dcb50ad1d6f50c3deb322587df58bc27d5 
>   Vagrantfile e7e113def27f241fa48a550885eff8faba52375a 
>   build-support/packer/build.sh 2a01d77a08959652a1607f1ade2bb8fbe7555762 
>   build.gradle 0d0d94a80613965282724dd82e61b2363d6a5361 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
> f2ff7abb51101c603df1bd1b21c4920a348743e1 
> 
> Diff: https://reviews.apache.org/r/49384/diff/
> 
> 
> Testing
> ---
> 
> e2e
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

2016-06-29 Thread Joshua Cohen 


> On June 29, 2016, 4:44 p.m., Maxim Khutornenko wrote:
> > build.gradle, line 368
> > 
> >
> > Should this be 0.28.3 instead? Looking at the changelog I don't see any 
> > relevant changes for us but in case it's easy to bump the version up it 
> > would be great to have the most recent release linked to 0.15.0.
> > 
> > https://github.com/apache/mesos/blob/master/CHANGELOG#L571?

As far as I can tell mesos 0.28.3 has not yet been released. Am I missing 
something? Latest release [here](http://mesos.apache.org/downloads/) is 0.28.2. 
Same [here](https://mesosphere.com/downloads/) for the Mesosphere rpms? More 
than happy to bump up to 0.28.3 when it does actually get released, but it 
doesn't seem to be available yet.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140007
---


On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49384/
> ---
> 
> (Updated June 29, 2016, 4:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade to Mesos 0.28.2.
> 
> Release notes: http://mesos.apache.org/blog/mesos-0-28-0-released/, 
> http://mesos.apache.org/blog/mesos-0-28-2-released/
> 
> Upgrade instructions here: 
> http://mesos.apache.org/documentation/latest/upgrades/. Maxim: do we need to 
> do anything about 
> http://mesos.apache.org/documentation/latest/upgrades/#0-28-x-resource-precision?
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 85db569b43a4a121ed6c6b14688e19dd0278e145 
>   RELEASE-NOTES.md 5beda5dcb50ad1d6f50c3deb322587df58bc27d5 
>   Vagrantfile e7e113def27f241fa48a550885eff8faba52375a 
>   build-support/packer/build.sh 2a01d77a08959652a1607f1ade2bb8fbe7555762 
>   build.gradle 0d0d94a80613965282724dd82e61b2363d6a5361 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
> f2ff7abb51101c603df1bd1b21c4920a348743e1 
> 
> Diff: https://reviews.apache.org/r/49384/diff/
> 
> 
> Testing
> ---
> 
> e2e
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

2016-06-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140008
---



Master (4e28b9c) is red with this patch.
  ./build-support/jenkins/build.sh

   with temporary_dir() as checkpoint_root:
 te = AuroraExecutor(
 >   
runner_provider=make_provider(checkpoint_root),
 
sandbox_provider=DefaultTestSandboxProvider())
 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:580: 
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in 
make_provider
 pex_location=thermos_runner_path(),
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
 build = True
 
 def thermos_runner_path(build=True):
   if not build:
 return getattr(thermos_runner_path, 'value', 
None)
 
   if not hasattr(thermos_runner_path, 'value'):
 pex_dir = safe_mkdtemp()
 >   assert subprocess.call(["./pants", 
"--pants-distdir=%s" % pex_dir, "binary",
   
"src/main/python/apache/thermos/runner:thermos_runner"]) == 0
 E   assert 1 == 0
 E+  where 1 = (['./pants', '--pants-distdir=/tmp/user/10021/tmpAt85gp', 
'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
 E+where  = subprocess.call
 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: 
AssertionError
 -- Captured stderr call --
 Traceback (most recent call last):
   File 
"/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants", 
line 7, in 
 from pants.bin.pants_exe import main
 ImportError: No module named pants.bin.pants_exe
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  16 failed, 638 passed, 6 skipped, 1 warnings, 8 
error in 136.00 seconds 
 
FAILURE


   Waiting for background workers to finish.
16:55:29 03:07   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49384/
> ---
> 
> (Updated June 29, 2016, 4:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade to Mesos 0.28.2.
> 
> Release notes: http://mesos.apache.org/blog/mesos-0-28-0-released/, 
> http://mesos.apache.org/blog/mesos-0-28-2-released/
> 
> Upgrade instructions here: 
> http://mesos.apache.org/documentation/latest/upgrades/. Maxim: do we need to 
> do anything about 
> http://mesos.apache.org/documentation/latest/upgrades/#0-28-x-resource-precision?
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 85db569b43a4a121ed6c6b14688e19dd0278e145 
>   RELEASE-NOTES.md 5beda5dcb50ad1d6f50c3deb322587df58bc27d5 
>   Vagrantfile e7e113def27f241fa48a550885eff8faba52375a 
>   build-support/packer/build.sh 2a01d77a08959652a1607f1ade2bb8fbe7555762 
>   build.gradle 0d0d94a80613965282724dd82e61b2363d6a5361 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
> f2ff7abb51101c603df1bd1b21c4920a348743e1 
> 
> Diff: https://reviews.apache.org/r/49384/diff/
> 
> 
> Testing
> ---
> 
> e2e
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

2016-06-29 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140007
---



> do we need to do anything about

My understanding is that Mesos rounds up values to the lowest supported of 
0.001. Also, our `-thermos_executor_cpu` default value of 0.25 already exceeds 
the min threshold.


build.gradle (line 368)


Should this be 0.28.3 instead? Looking at the changelog I don't see any 
relevant changes for us but in case it's easy to bump the version up it would 
be great to have the most recent release linked to 0.15.0.

https://github.com/apache/mesos/blob/master/CHANGELOG#L571?


- Maxim Khutornenko


On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49384/
> ---
> 
> (Updated June 29, 2016, 4:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade to Mesos 0.28.2.
> 
> Release notes: http://mesos.apache.org/blog/mesos-0-28-0-released/, 
> http://mesos.apache.org/blog/mesos-0-28-2-released/
> 
> Upgrade instructions here: 
> http://mesos.apache.org/documentation/latest/upgrades/. Maxim: do we need to 
> do anything about 
> http://mesos.apache.org/documentation/latest/upgrades/#0-28-x-resource-precision?
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 85db569b43a4a121ed6c6b14688e19dd0278e145 
>   RELEASE-NOTES.md 5beda5dcb50ad1d6f50c3deb322587df58bc27d5 
>   Vagrantfile e7e113def27f241fa48a550885eff8faba52375a 
>   build-support/packer/build.sh 2a01d77a08959652a1607f1ade2bb8fbe7555762 
>   build.gradle 0d0d94a80613965282724dd82e61b2363d6a5361 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
> f2ff7abb51101c603df1bd1b21c4920a348743e1 
> 
> Diff: https://reviews.apache.org/r/49384/diff/
> 
> 
> Testing
> ---
> 
> e2e
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

2016-06-29 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140006
---



@ReviewBot retry

- Joshua Cohen


On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49384/
> ---
> 
> (Updated June 29, 2016, 4:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade to Mesos 0.28.2.
> 
> Release notes: http://mesos.apache.org/blog/mesos-0-28-0-released/, 
> http://mesos.apache.org/blog/mesos-0-28-2-released/
> 
> Upgrade instructions here: 
> http://mesos.apache.org/documentation/latest/upgrades/. Maxim: do we need to 
> do anything about 
> http://mesos.apache.org/documentation/latest/upgrades/#0-28-x-resource-precision?
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 85db569b43a4a121ed6c6b14688e19dd0278e145 
>   RELEASE-NOTES.md 5beda5dcb50ad1d6f50c3deb322587df58bc27d5 
>   Vagrantfile e7e113def27f241fa48a550885eff8faba52375a 
>   build-support/packer/build.sh 2a01d77a08959652a1607f1ade2bb8fbe7555762 
>   build.gradle 0d0d94a80613965282724dd82e61b2363d6a5361 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
> f2ff7abb51101c603df1bd1b21c4920a348743e1 
> 
> Diff: https://reviews.apache.org/r/49384/diff/
> 
> 
> Testing
> ---
> 
> e2e
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

2016-06-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140005
---



Master (4e28b9c) is red with this patch.
  ./build-support/jenkins/build.sh

thrift-0.9.1/tutorial/py/Makefile.am
thrift-0.9.1/tutorial/py/Makefile.in
thrift-0.9.1/tutorial/py/PythonClient.py
thrift-0.9.1/tutorial/py/PythonServer.py
thrift-0.9.1/tutorial/py.tornado/
thrift-0.9.1/tutorial/py.tornado/Makefile.am
thrift-0.9.1/tutorial/py.tornado/Makefile.in
thrift-0.9.1/tutorial/py.tornado/PythonClient.py
thrift-0.9.1/tutorial/py.tornado/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/
thrift-0.9.1/tutorial/py.twisted/Makefile.am
thrift-0.9.1/tutorial/py.twisted/Makefile.in
thrift-0.9.1/tutorial/py.twisted/PythonClient.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.tac
thrift-0.9.1/tutorial/rb/
thrift-0.9.1/tutorial/rb/Makefile.am
thrift-0.9.1/tutorial/rb/Makefile.in
thrift-0.9.1/tutorial/rb/RubyClient.rb
thrift-0.9.1/tutorial/rb/RubyServer.rb
thrift-0.9.1/tutorial/README
thrift-0.9.1/tutorial/shared.thrift
thrift-0.9.1/tutorial/tutorial.thrift
thrift-0.9.1/ylwrap
make: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
make: *** [thrift-0.9.1/compiler/cpp/thrift] Error 1
:api:generateThriftJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':api:generateThriftJava'.
> Process 'command 
> '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thriftw''
>  finished with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 2 mins 11.206 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49384/
> ---
> 
> (Updated June 29, 2016, 4:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade to Mesos 0.28.2.
> 
> Release notes: http://mesos.apache.org/blog/mesos-0-28-0-released/, 
> http://mesos.apache.org/blog/mesos-0-28-2-released/
> 
> Upgrade instructions here: 
> http://mesos.apache.org/documentation/latest/upgrades/. Maxim: do we need to 
> do anything about 
> http://mesos.apache.org/documentation/latest/upgrades/#0-28-x-resource-precision?
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 85db569b43a4a121ed6c6b14688e19dd0278e145 
>   RELEASE-NOTES.md 5beda5dcb50ad1d6f50c3deb322587df58bc27d5 
>   Vagrantfile e7e113def27f241fa48a550885eff8faba52375a 
>   build-support/packer/build.sh 2a01d77a08959652a1607f1ade2bb8fbe7555762 
>   build.gradle 0d0d94a80613965282724dd82e61b2363d6a5361 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
> f2ff7abb51101c603df1bd1b21c4920a348743e1 
> 
> Diff: https://reviews.apache.org/r/49384/diff/
> 
> 
> Testing
> ---
> 
> e2e
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Review Request 49384: Upgrade to Mesos 0.28.2.

2016-06-29 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/
---

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

Upgrade to Mesos 0.28.2.

Release notes: http://mesos.apache.org/blog/mesos-0-28-0-released/, 
http://mesos.apache.org/blog/mesos-0-28-2-released/

Upgrade instructions here: 
http://mesos.apache.org/documentation/latest/upgrades/. Maxim: do we need to do 
anything about 
http://mesos.apache.org/documentation/latest/upgrades/#0-28-x-resource-precision?


Diffs
-

  3rdparty/python/BUILD 85db569b43a4a121ed6c6b14688e19dd0278e145 
  RELEASE-NOTES.md 5beda5dcb50ad1d6f50c3deb322587df58bc27d5 
  Vagrantfile e7e113def27f241fa48a550885eff8faba52375a 
  build-support/packer/build.sh 2a01d77a08959652a1607f1ade2bb8fbe7555762 
  build.gradle 0d0d94a80613965282724dd82e61b2363d6a5361 
  src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
f2ff7abb51101c603df1bd1b21c4920a348743e1 

Diff: https://reviews.apache.org/r/49384/diff/


Testing
---

e2e
./gradlew build -Pq


Thanks,

Joshua Cohen