Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52921/#review152814 --- Master (ac8b802) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 16, 2016, 11:04 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52921/ > --- > > (Updated Oct. 16, 2016, 11:04 p.m.) > > > Review request for Aurora and John Sirois. > > > Repository: aurora > > > Description > --- > > I saw THRIFT-3868 and thought we could apply the same micro-optimization > as well. Details: https://github.com/apache/thrift/pull/1106 > > Example of a generated equals method (in ITaskConfig): > > @Override > public boolean equals(Object o) { > if (this == o) { > return true; > } > if (!(o instanceof ITaskConfig)) { > return false; > } > ITaskConfig other = (ITaskConfig) o; > return Objects.equals(job, other.job) > && Objects.equals(owner, other.owner) > && Objects.equals(isService, other.isService) > && Objects.equals(numCpus, other.numCpus) > && Objects.equals(ramMb, other.ramMb) > && Objects.equals(diskMb, other.diskMb) > && Objects.equals(priority, other.priority) > && Objects.equals(maxTaskFailures, other.maxTaskFailures) > && Objects.equals(production, other.production) > && Objects.equals(tier, other.tier) > && Objects.equals(resources, other.resources) > && Objects.equals(constraints, other.constraints) > && Objects.equals(requestedPorts, other.requestedPorts) > && Objects.equals(mesosFetcherUris, other.mesosFetcherUris) > && Objects.equals(taskLinks, other.taskLinks) > && Objects.equals(contactEmail, other.contactEmail) > && Objects.equals(executorConfig, other.executorConfig) > && Objects.equals(metadata, other.metadata) > && Objects.equals(container, other.container); > } > > > Diffs > - > > src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py > 7c281800b00b973351659ecacd5b7f6e55e46bba > > Diff: https://reviews.apache.org/r/52921/diff/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52921/ --- (Updated Oct. 17, 2016, 1:04 a.m.) Review request for Aurora. Repository: aurora Description (updated) --- I saw THRIFT-3868 and thought we could apply the same micro-optimization as well. Details: https://github.com/apache/thrift/pull/1106 Example of a generated equals method (in ITaskConfig): @Override public boolean equals(Object o) { if (this == o) { return true; } if (!(o instanceof ITaskConfig)) { return false; } ITaskConfig other = (ITaskConfig) o; return Objects.equals(job, other.job) && Objects.equals(owner, other.owner) && Objects.equals(isService, other.isService) && Objects.equals(numCpus, other.numCpus) && Objects.equals(ramMb, other.ramMb) && Objects.equals(diskMb, other.diskMb) && Objects.equals(priority, other.priority) && Objects.equals(maxTaskFailures, other.maxTaskFailures) && Objects.equals(production, other.production) && Objects.equals(tier, other.tier) && Objects.equals(resources, other.resources) && Objects.equals(constraints, other.constraints) && Objects.equals(requestedPorts, other.requestedPorts) && Objects.equals(mesosFetcherUris, other.mesosFetcherUris) && Objects.equals(taskLinks, other.taskLinks) && Objects.equals(contactEmail, other.contactEmail) && Objects.equals(executorConfig, other.executorConfig) && Objects.equals(metadata, other.metadata) && Objects.equals(container, other.container); } Diffs - src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 7c281800b00b973351659ecacd5b7f6e55e46bba Diff: https://reviews.apache.org/r/52921/diff/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb
Re: Review Request 52915: Upgrade pants to the 1.3.0 dev series.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52915/#review152808 --- Ship it! Ship It! - Stephan Erb On Oct. 16, 2016, 12:42 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52915/ > --- > > (Updated Oct. 16, 2016, 12:42 a.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This gets rid of an impossible to work around warning emitted by every > pants invocation and prepares for consuming an upcoming pants change > that will allow Aurora to use the thrift binary selected by > `build-support/thrift/thriftw` consistently everywhere. > > Release notes are here: > http://www.pantsbuild.org/notes-master.html > > pants.ini | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > > Diffs > - > > pants.ini 6ed4186780c485f2d023d8e398429e570e9e5a0c > > Diff: https://reviews.apache.org/r/52915/diff/ > > > Testing > --- > > Locally green: > ``` > ./build-support/jenkins/build.sh > ./build-support/python/make-pycharm-virtualenv > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >