Re: Review Request 67657: Introduce a `countdown-ms` param in Coordinator request.

2018-06-19 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67657/#review205038
---


Ship it!




Master (3140448) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 19, 2018, 10:30 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67657/
> ---
> 
> (Updated June 19, 2018, 10:30 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Franck Cuny, and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> With the introduction of `timeoutSecs` for HostMaintenanceRequest
> and the `CoordinatorSlaPolicy`, it will be beneficial to expose the
> time remaining until forced maintenance to the Coordinator. Send
> the time remaining until force task maintenance as an extra query
> param to the Coordinator.
> 
> 
> Diffs
> -
> 
>   docs/features/sla-requirements.md 555b174d2324b0b1b596a3da72b0a5a67fcca153 
>   
> src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceController.java
>  626a68263d6118f138cd6012fd49e033b09b75f0 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 
> 9c5caf4af8e8c8bad408100af2bc4fe045603340 
>   
> src/test/java/org/apache/aurora/scheduler/maintenance/MaintenanceControllerImplTest.java
>  c9390df25f7eacbab14a508b1926a05aac8112d6 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaManagerTest.java 
> 759a1bca4814b2cf70a20eac26aaabfcef682332 
> 
> 
> Diff: https://reviews.apache.org/r/67657/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew test
> 
> **Tested on Vagrant**
> 
> ***Logs from Coordinator***
> Request received for {'countdown-ms': ['94784'], 'task': 
> ['devcluster/vagrant/test/coordinator/1']}
> Responded: False
> Request received for {'countdown-ms': ['34777'], 'task': 
> ['devcluster/vagrant/test/coordinator/1']}
> Responded: False
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Review Request 67657: Introduce a `countdown-ms` param in Coordinator request.

2018-06-19 Thread Santhosh Kumar Shanmugham 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67657/
---

Review request for Aurora, David McLaughlin, Franck Cuny, and Jordan Ly.


Repository: aurora


Description
---

With the introduction of `timeoutSecs` for HostMaintenanceRequest
and the `CoordinatorSlaPolicy`, it will be beneficial to expose the
time remaining until forced maintenance to the Coordinator. Send
the time remaining until force task maintenance as an extra query
param to the Coordinator.


Diffs
-

  docs/features/sla-requirements.md 555b174d2324b0b1b596a3da72b0a5a67fcca153 
  
src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceController.java
 626a68263d6118f138cd6012fd49e033b09b75f0 
  src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 
9c5caf4af8e8c8bad408100af2bc4fe045603340 
  
src/test/java/org/apache/aurora/scheduler/maintenance/MaintenanceControllerImplTest.java
 c9390df25f7eacbab14a508b1926a05aac8112d6 
  src/test/java/org/apache/aurora/scheduler/sla/SlaManagerTest.java 
759a1bca4814b2cf70a20eac26aaabfcef682332 


Diff: https://reviews.apache.org/r/67657/diff/1/


Testing
---

./gradlew test

**Tested on Vagrant**

***Logs from Coordinator***
Request received for {'countdown-ms': ['94784'], 'task': 
['devcluster/vagrant/test/coordinator/1']}
Responded: False
Request received for {'countdown-ms': ['34777'], 'task': 
['devcluster/vagrant/test/coordinator/1']}
Responded: False


Thanks,

Santhosh Kumar Shanmugham

Re: Review Request 67639: Export count-down to forceful Maintenace as a metric.

2018-06-19 Thread Jordan Ly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67639/#review205005
---


Ship it!




Ship It!

- Jordan Ly


On June 19, 2018, 1:21 a.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67639/
> ---
> 
> (Updated June 19, 2018, 1:21 a.m.)
> 
> 
> Review request for Aurora, Franck Cuny and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Since the scheduler enforces a maximum timeout on each
> maintenance request and we now allow CoordinatorSlaPolicy
> to block maintenance, we need to know which tasks are
> running into the force maintenance timeout. Export maintenace
> count down time as a metric brokwen down by task keys.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java 
> b12ac83168401c15fb1d30179ea8e4816f09cd3d 
>   
> src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceController.java
>  7fc5990dfb04c5528a44142c3efdd6d60d08188d 
> 
> 
> Diff: https://reviews.apache.org/r/67639/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew test
> 
> **Tested in Vagrant**
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | 
> grep maintenance_countdown
>  
> 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 24476
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | 
> grep maintenance_countdown
>  
> 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 24476
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | 
> grep maintenance_countdown
>  
> 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 0
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 67639: Export count-down to forceful Maintenace as a metric.

2018-06-19 Thread Franck Cuny via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67639/#review205002
---


Ship it!




Thanks, I think this will be useful for SO to track on a dashboard and enable 
them to act manually if needed.

- Franck Cuny


On June 19, 2018, 1:21 a.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67639/
> ---
> 
> (Updated June 19, 2018, 1:21 a.m.)
> 
> 
> Review request for Aurora, Franck Cuny and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Since the scheduler enforces a maximum timeout on each
> maintenance request and we now allow CoordinatorSlaPolicy
> to block maintenance, we need to know which tasks are
> running into the force maintenance timeout. Export maintenace
> count down time as a metric brokwen down by task keys.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java 
> b12ac83168401c15fb1d30179ea8e4816f09cd3d 
>   
> src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceController.java
>  7fc5990dfb04c5528a44142c3efdd6d60d08188d 
> 
> 
> Diff: https://reviews.apache.org/r/67639/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew test
> 
> **Tested in Vagrant**
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | 
> grep maintenance_countdown
>  
> 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 24476
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | 
> grep maintenance_countdown
>  
> 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 24476
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | 
> grep maintenance_countdown
>  
> 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 0
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>