Re: Review Request 54754: Fixed starting cron jobs when using default_docker_parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54754/#review163337 --- Wow I forgot I even submitted this! - Steve Niemitz On Dec. 15, 2016, 5:48 p.m., Steve Niemitz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54754/ > --- > > (Updated Dec. 15, 2016, 5:48 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1684 > https://issues.apache.org/jira/browse/AURORA-1684 > > > Repository: aurora > > > Description > --- > > Fixed starting cron jobs when using default_docker_parameters > > The code was previously attempting to re-sanitize the configuration read from > storage rather than just using it as is. This causes issues if after > sanitization the job no longer passes sanitization (which is the case here w/ > default_docker_parameters). > > We've been running this in our branch forever. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java > 5873983479c39a011eb363f7fd442867f0794b17 > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java > 650facecc2e02be7bb3cd5ea9ff0f094e006bcb3 > > src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java > fb06c282c4e94639c521658682c5da3e4dd4baf7 > > Diff: https://reviews.apache.org/r/54754/diff/ > > > Testing > --- > > > Thanks, > > Steve Niemitz > >
Re: Review Request 45392: Reorganize Documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45392/#review125734 --- Ship it! Ship It! - Steve Niemitz On March 28, 2016, 6:12 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45392/ > --- > > (Updated March 28, 2016, 6:12 p.m.) > > > Review request for Aurora, John Sirois and Bill Farner. > > > Repository: aurora > > > Description > --- > > This started as a spike to structure the documentation in a way that makes it > more approachable. In addition, I believe the new structure will allow us to > extend and improve the documentation more easily, as the different sections > have more room to grow into something useful (eg. service discovery). > > The new structure was inspired by the documentation of Hubspot's Singularity > scheduler. What I have done was mostly to cut & paste documentation and code > examples and embedded those into the following: > > * getting-started: the most basic information for all users > * features: proper explanation of our most important features. This should > make it much easier for people to discover Aurora's unique selling points. > * operators: stuff only the operatos will care about > * developers: stuff only contributors and committers acare about. > * references: the details. > > The diff is almost impossible review as I was not very diligent in keeping it > clean. Sorry for that. If you believe this is unacceptable, we can move to a > more piecewise review. > > > Diffs > - > > README.md e2b5632d42129d448d4fc237da9d939ca9dd564c > docs/README.md 673c854825a0443a3bc7b13c04640dd85ad147f5 > docs/build-system.md 39c231dc9e222ebf409280199fe12d75449157fe > docs/client-cluster-configuration.md > 88b9d772c9140178cd195875136408399e0ee52b > docs/client-commands.md 156fe4cf2462735218bcdc80655ce3ec5e9cd4f5 > docs/committers.md f69a898d434abb0295e68682e290bc3f966d3654 > docs/configuration-reference.md 7bcf22d6ec8266568a1e3692fdbc451a58388967 > docs/configuration-tutorial.md 97664f39a5b2fce8c4829d5ba1c3ec7f4b8fc63b > docs/cron-jobs.md 0f9842529ad075c9fbd153a13c2b07c94c391052 > docs/deploying-aurora-scheduler.md 03bfdbab927c924486b04c42df2ad236c0f414a0 > docs/design-documents.md 4d14caa4dde1a48d8d90b6b7c9104efd629d715c > docs/design/command-hooks.md > docs/developing-aurora-client.md 27f1c97c1b7c199c1c496e11ef8995ca3b1b437c > docs/developing-aurora-scheduler.md > a703871a68b51e43cb51379df0856911dbe91c8b > docs/development/thermos.md PRE-CREATION > docs/development/ui.md PRE-CREATION > docs/features/constraints.md PRE-CREATION > docs/features/containers.md PRE-CREATION > docs/features/job-updates.md PRE-CREATION > docs/features/multitenancy.md PRE-CREATION > docs/features/service-discovery.md PRE-CREATION > docs/features/services.md PRE-CREATION > docs/getting-started/overview.md PRE-CREATION > docs/hooks.md 28307ab3d45721ccc97a3d01148129c22d1f1998 > docs/installing.md 5cc153ab8c7c8043efd07a7cb9fa44c84e31a7a8 > docs/monitoring.md > docs/operations/configuration.md PRE-CREATION > docs/presentations.md 84756a24e258a38cebad1dac7c6e51f7d6d187bd > docs/reference/configuration-best-practices.md PRE-CREATION > docs/reference/configuration-templating.md PRE-CREATION > docs/reference/configuration-tutorial.md PRE-CREATION > docs/reference/scheduler-configuration.md PRE-CREATION > docs/resources.md 27a267828d8222623ae77e084e1d5f602075838e > docs/scheduler-configuration.md 7e3d801251262a5eedbca8890316aa9f44be8314 > docs/security.md 32bea426fbceec83187e851a5db11e82df55e962 > docs/sla.md a558e0098e73172801d9fad927f1f85d0476413f > docs/storage-config.md 7c6484183ce88eca6ab1a25805c86af1fcd64ee1 > docs/storage.md 6ffed541d1579a8131ce642b082be602431329d3 > docs/task-lifecycle.md 5d6456cb6647acb2c2c0f9024c744e37ccc55d1c > docs/test-resource-generation.md e78e742542508389e8161d00ee0e4ddb7084e72d > docs/thrift-deprecation.md 62a71bcf10704c92fd26a8fd74729a8dc51b988c > docs/tools.md 2ae550db35835ac2ebe5a95dbcc18e86d7bc4642 > docs/tutorial.md 95539ef299792068de2ad9d38b39d66e162fbc21 > docs/user-guide.md 656296cc84622d44d6dd43fc1496496da15b5d08 > docs/vagrant.md 3bc201f17977dbc402eeac307500db5cc9d6bb27 > > Diff: https://reviews.apache.org/r/45392/diff/ > > > Testing > --- > > Rendered version available at: > https://github.com/StephanErb/aurora/tree/userguide_docu/docs > > > Thanks, > > Stephan Erb > >
Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125722 --- RELEASE-NOTES.md (line 14) <https://reviews.apache.org/r/45396/#comment188580> In the future I think we should revisit this and make this the default behavior. The only reason I think it shouldn't be enabled by default now is because the mesos.native lib inside the pex is massive, and duplicating it into every sandbox is 1) slow, and 2) a waste of space. However, once my patch lands, the lib goes down to ~8 MB, which I think is worth duplicating, especially to get rid of any weird race conditions with multiple executors launching. - Steve Niemitz On March 28, 2016, 6:21 p.m., George Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45396/ > --- > > (Updated March 28, 2016, 6:21 p.m.) > > > Review request for Aurora, Joshua Cohen, Steve Niemitz, and Bill Farner. > > > Repository: aurora > > > Description > --- > > In instances where the root filesystem is read-only, it is desirable to > have the executor/runner extract themselves into the sandbox. > > > Diffs > - > > RELEASE-NOTES.md 34f28a165aae4ae24fa95ef19b4972e088fd63a0 > docs/deploying-aurora-scheduler.md 03bfdbab927c924486b04c42df2ad236c0f414a0 > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java > 949c299bdbc54f976db994266fb97f3099256f13 > > Diff: https://reviews.apache.org/r/45396/diff/ > > > Testing > --- > > > Thanks, > > George Sirois > >
Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125726 --- Ship it! Ship It! - Steve Niemitz On March 28, 2016, 6:21 p.m., George Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45396/ > --- > > (Updated March 28, 2016, 6:21 p.m.) > > > Review request for Aurora, Joshua Cohen, Steve Niemitz, and Bill Farner. > > > Repository: aurora > > > Description > --- > > In instances where the root filesystem is read-only, it is desirable to > have the executor/runner extract themselves into the sandbox. > > > Diffs > - > > RELEASE-NOTES.md 34f28a165aae4ae24fa95ef19b4972e088fd63a0 > docs/deploying-aurora-scheduler.md 03bfdbab927c924486b04c42df2ad236c0f414a0 > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java > 949c299bdbc54f976db994266fb97f3099256f13 > > Diff: https://reviews.apache.org/r/45396/diff/ > > > Testing > --- > > > Thanks, > > George Sirois > >
Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44602/#review122841 --- Ship it! Oh neat, we're doing this? We've been running this patch for 6+ months now with no issues. - Steve Niemitz On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44602/ > --- > > (Updated March 10, 2016, 12:25 a.m.) > > > Review request for Aurora, Steve Niemitz and Bill Farner. > > > Repository: aurora > > > Description > --- > > Ported from > https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562. > > > Diffs > - > > NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb > docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9 > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > 6300e5f83b039a9798e7093f6b46c84566e507e0 > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > d2789d0eaaeba99fcff3412f1abdd29a09d6514d > > Diff: https://reviews.apache.org/r/44602/diff/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 40889: Changed mesos native lib to use mesos.executor instead
> On Dec. 3, 2015, 12:36 a.m., Maxim Khutornenko wrote: > > 3rdparty/python/BUILD, line 14 > > <https://reviews.apache.org/r/40889/diff/1/?file=1151864#file1151864line14> > > > > Am I reading this as revving up mesos native version in Aurora? If so, > > we should also update build.gradle and possibly update > > make-mesos-native-egg script. Previous effort as a reference: > > https://reviews.apache.org/r/37379 > > Bill Farner wrote: > You're right, Maxim. I think it's safe to say this patch is still in PoC > stage, as it can't land until some changes go into mesos. I think Steve is > not expecting ship-its just yet. > > Steve Niemitz wrote: > Correct, I'll ping when I'm ready for more eyes on it. > > Zameer Manji wrote: > If you do want to do this, please assign > https://issues.apache.org/jira/browse/AURORA-1543 to yourself. The version number here is pretty much a placeholder, what it ends up being is going to depend on how we want to support the mesos native library. I see a couple options (and maybe there's others): 1. Wait for my patch (which I'm about to submit (1)) to land in mesos and let the normal aurora->mesos upgrade cycle get it. It will be at least 0.26.0 in this case, as 0.25.0 is already released. 2. Host our own builds of mesos.executor somewhere, and download/use that when doing the thermos build. We could build it off of pretty much any mesos version, including the current 0.23.0. Seeing as mesos proper doesn't provide debs/rpms anyways (mesospehere does instead), and the same mesos.executor egg *should* work in either centos or ubuntu, option 2 might make the most sense, especially if we want to get this out sometime soon. (1): https://issues.apache.org/jira/browse/MESOS-4090 - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40889/#review108758 ------- On Dec. 2, 2015, 11:57 p.m., Steve Niemitz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40889/ > --- > > (Updated Dec. 2, 2015, 11:57 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > Changed mesos native lib to use mesos.executor instead > > Without any context this doesnt really make any sense. > > I've created a seperate mesos native lib that only contains a minimal set of > code needed to run the ExecutorDriver. This library has very few > requirements, making it a much better option for running in docker > containers, as well as allowing a thermos_executor.pex built on one linux > distro to run on most others. > > The mesos side of this is here: > https://github.com/tellapart/mesos/commit/46bedd5db73b535a0e4efe94730500b6da2ec7d8 > and I'll be opening a RB request on the mesos side soon. > > > Diffs > - > > 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 > src/main/python/apache/aurora/executor/BUILD > 0be65fc7c180d15f5a94bef268652ef7b868dcf7 > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py > b3e8bf1e924999306e0b8a1314273b22c51028e7 > > Diff: https://reviews.apache.org/r/40889/diff/ > > > Testing > --- > > > Thanks, > > Steve Niemitz > >
Re: Review Request 40889: Changed mesos native lib to use mesos.executor instead
> On Dec. 3, 2015, 12:36 a.m., Maxim Khutornenko wrote: > > 3rdparty/python/BUILD, line 14 > > <https://reviews.apache.org/r/40889/diff/1/?file=1151864#file1151864line14> > > > > Am I reading this as revving up mesos native version in Aurora? If so, > > we should also update build.gradle and possibly update > > make-mesos-native-egg script. Previous effort as a reference: > > https://reviews.apache.org/r/37379 > > Bill Farner wrote: > You're right, Maxim. I think it's safe to say this patch is still in PoC > stage, as it can't land until some changes go into mesos. I think Steve is > not expecting ship-its just yet. > > Steve Niemitz wrote: > Correct, I'll ping when I'm ready for more eyes on it. > > Zameer Manji wrote: > If you do want to do this, please assign > https://issues.apache.org/jira/browse/AURORA-1543 to yourself. > > Steve Niemitz wrote: > The version number here is pretty much a placeholder, what it ends up > being is going to depend on how we want to support the mesos native library. > I see a couple options (and maybe there's others): > 1. Wait for my patch (which I'm about to submit (1)) to land in mesos and > let the normal aurora->mesos upgrade cycle get it. It will be at least > 0.26.0 in this case, as 0.25.0 is already released. > 2. Host our own builds of mesos.executor somewhere, and download/use that > when doing the thermos build. We could build it off of pretty much any mesos > version, including the current 0.23.0. > > Seeing as mesos proper doesn't provide debs/rpms anyways (mesospehere > does instead), and the same mesos.executor egg *should* work in either centos > or ubuntu, option 2 might make the most sense, especially if we want to get > this out sometime soon. > > (1): https://issues.apache.org/jira/browse/MESOS-4090 > > Bill Farner wrote: > I could be convinced of (2), so long as we can point to the sha we built > from + patch we applied. Thoughts on where would you want to host it from? It looks like the current native egg is downloaded from svn.apache.org for the vagrant build, would we want to follow the same pattern? I could supply a dockerfile to build it in aurora/build-support as well. - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40889/#review108758 --- On Dec. 2, 2015, 11:57 p.m., Steve Niemitz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40889/ > --- > > (Updated Dec. 2, 2015, 11:57 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > Changed mesos native lib to use mesos.executor instead > > Without any context this doesnt really make any sense. > > I've created a seperate mesos native lib that only contains a minimal set of > code needed to run the ExecutorDriver. This library has very few > requirements, making it a much better option for running in docker > containers, as well as allowing a thermos_executor.pex built on one linux > distro to run on most others. > > The mesos side of this is here: > https://github.com/tellapart/mesos/commit/46bedd5db73b535a0e4efe94730500b6da2ec7d8 > and I'll be opening a RB request on the mesos side soon. > > > Diffs > - > > 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 > src/main/python/apache/aurora/executor/BUILD > 0be65fc7c180d15f5a94bef268652ef7b868dcf7 > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py > b3e8bf1e924999306e0b8a1314273b22c51028e7 > > Diff: https://reviews.apache.org/r/40889/diff/ > > > Testing > --- > > > Thanks, > > Steve Niemitz > >
Re: Review Request 40889: Changed mesos native lib to use mesos.executor instead
> On Dec. 3, 2015, 12:36 a.m., Maxim Khutornenko wrote: > > 3rdparty/python/BUILD, line 14 > > <https://reviews.apache.org/r/40889/diff/1/?file=1151864#file1151864line14> > > > > Am I reading this as revving up mesos native version in Aurora? If so, > > we should also update build.gradle and possibly update > > make-mesos-native-egg script. Previous effort as a reference: > > https://reviews.apache.org/r/37379 > > Bill Farner wrote: > You're right, Maxim. I think it's safe to say this patch is still in PoC > stage, as it can't land until some changes go into mesos. I think Steve is > not expecting ship-its just yet. Correct, I'll ping when I'm ready for more eyes on it. - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40889/#review108758 ------- On Dec. 2, 2015, 11:57 p.m., Steve Niemitz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40889/ > --- > > (Updated Dec. 2, 2015, 11:57 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > Changed mesos native lib to use mesos.executor instead > > Without any context this doesnt really make any sense. > > I've created a seperate mesos native lib that only contains a minimal set of > code needed to run the ExecutorDriver. This library has very few > requirements, making it a much better option for running in docker > containers, as well as allowing a thermos_executor.pex built on one linux > distro to run on most others. > > The mesos side of this is here: > https://github.com/tellapart/mesos/commit/46bedd5db73b535a0e4efe94730500b6da2ec7d8 > and I'll be opening a RB request on the mesos side soon. > > > Diffs > - > > 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 > src/main/python/apache/aurora/executor/BUILD > 0be65fc7c180d15f5a94bef268652ef7b868dcf7 > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py > b3e8bf1e924999306e0b8a1314273b22c51028e7 > > Diff: https://reviews.apache.org/r/40889/diff/ > > > Testing > --- > > > Thanks, > > Steve Niemitz > >
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files
On Aug. 26, 2015, 5:39 p.m., Maxim Khutornenko wrote:
src/test/python/apache/aurora/config/test_thrift.py, line 177
https://reviews.apache.org/r/37801/diff/1/?file=1053308#file1053308line177
Would be great to have a non-empty hostname as well to explicitly
assert its value.
Is there a good way to test this other than something gross like:
str(String({{mesos.hostname}}).bind(*instance.scopes())). Here the hostname
is in the binding context but not on any inspectable field on the instance
itself.
- Steve
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96560
---
On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
---
(Updated Aug. 26, 2015, 5:05 p.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
---
Added support for {{mesos.hostname}} in aur files
Diffs
-
src/main/python/apache/aurora/config/schema/base.py
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py
082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py
5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py
f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
---
Thanks,
Steve Niemitz
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files
On Aug. 26, 2015, 5:39 p.m., Maxim Khutornenko wrote:
src/test/python/apache/aurora/config/test_thrift.py, line 177
https://reviews.apache.org/r/37801/diff/1/?file=1053308#file1053308line177
Would be great to have a non-empty hostname as well to explicitly
assert its value.
Steve Niemitz wrote:
Is there a good way to test this other than something gross like:
str(String({{mesos.hostname}}).bind(*instance.scopes())). Here the
hostname is in the binding context but not on any inspectable field on the
instance itself.
nm, I figured out a good test here. I'll submit it once I can beat reviewboard
into submission.
- Steve
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96560
---
On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
---
(Updated Aug. 26, 2015, 5:05 p.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
---
Added support for {{mesos.hostname}} in aur files
Diffs
-
src/main/python/apache/aurora/config/schema/base.py
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py
082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py
5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py
f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
---
Thanks,
Steve Niemitz
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files
On Aug. 26, 2015, 5:55 p.m., Zameer Manji wrote:
The ticket referenced also talks about {{mesos.ip}}, will you also add
support for that?
It's not exposed anywhere by mesos AFAIK. If someone can correct me I can add
it in another review.
- Steve
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96565
---
On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
---
(Updated Aug. 26, 2015, 5:05 p.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
---
Added support for {{mesos.hostname}} in aur files
Diffs
-
src/main/python/apache/aurora/config/schema/base.py
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py
082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py
5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py
f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
---
Thanks,
Steve Niemitz
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
---
(Updated Aug. 26, 2015, 5:05 p.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
---
Added support for {{mesos.hostname}} in aur files
Diffs
-
src/main/python/apache/aurora/config/schema/base.py
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py
082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py
5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py
f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
---
Thanks,
Steve Niemitz
Re: Review Request 36785: Add retroactive NEWS entry for 0.8.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36785/#review92948 --- Ship it! Ship It! - Steve Niemitz On July 24, 2015, 6 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36785/ --- (Updated July 24, 2015, 6 p.m.) Review request for Aurora and Steve Niemitz. Bugs: AURORA-1403 https://issues.apache.org/jira/browse/AURORA-1403 Repository: aurora Description --- Add retroactive NEWS entry for 0.8.0. Diffs - NEWS d780d8c6b85534181545466cc9bbc1ba7f6967b2 Diff: https://reviews.apache.org/r/36785/diff/ Testing --- Thanks, Bill Farner
