Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-04 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review122108
---


Ship it!




Maxim, feel free to land this to move Amol along.  Otherwise I will be able to 
do it this evening.

- Bill Farner


On March 3, 2016, 10:14 p.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 3, 2016, 10:14 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> f4084535f5fc9e3c183cc75a569ec37b4ce90e32 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review122021
---


Ship it!




Master (3a3415e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 4, 2016, 6:14 a.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 4, 2016, 6:14 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> f4084535f5fc9e3c183cc75a569ec37b4ce90e32 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Amol Deshmukh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/
---

(Updated March 3, 2016, 10:14 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Addressed the last round of review comments:
- Removed the NEWS entry.
- Read default tier config as a ``Resource`` rather than ``File``.


Repository: aurora


Description
---

AURORA-1616: [part 2] make tier_config mandatory argument when starting up the 
scheduler.


Diffs (updated)
-

  docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
  examples/vagrant/upstart/aurora-scheduler.conf 
54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
45ab76b9331a79699979c6386c93bbc763f64e2e 
  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
f4084535f5fc9e3c183cc75a569ec37b4ce90e32 
  src/main/java/org/apache/aurora/scheduler/TierManager.java 
fce6e51548b23b7bc3e33468c2b3a9627a68debd 
  src/main/java/org/apache/aurora/scheduler/TierModule.java 
b5f065ec433b4df50a5c1ca7ef87d51292816db6 
  src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
  src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
  src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
  src/test/resources/org/apache/aurora/scheduler/tiers.json 
21407738fafc9bc5e6ce7888b4b9c32b2f005bca 

Diff: https://reviews.apache.org/r/43925/diff/


Testing
---

# Java build with checkstyle:
```
$ ./gradlew build -Pq
...
BUILD SUCCESSFUL

Total time: 3 mins 44.365 secs
```

# End-to-end tests:
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***

```

# Ensure affected benchmarks run:
```
$ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
...
Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt

$ ls -1 dist/reports/jmh/human.txt
dist/reports/jmh/human.txt
...

```

# Python client tests:
```
./pants test.pytest --no-fast src/test/python/apache/aurora::
...
   SUCCESS
```


Thanks,

Amol Deshmukh

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Amol Deshmukh 


> On March 3, 2016, 6:07 p.m., Bill Farner wrote:
> > NEWS, line 9
> > 
> >
> > This is a kind of lackluster news entry.  What does this actually 
> > _mean_ for users?  Will i see different behavior?  Is there a new 
> > capability i can use?

Agreed. The NEWS entry seemed essential since the original change aimed to make 
the argument required. Now since that is not the case, I will defer adding the 
NEWS entry with the change that actually introduces the ``preemptible`` flag in 
the ``tiers.json`` file.


> On March 3, 2016, 6:07 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TierModule.java, line 75
> > 
> >
> > This code is a bit roundabout, Resource->File->String.  How about:
> > 
> > ```
> > return TIER_CONFIG_FILE.hasAppliedValue()
> > ? Files.toString(TIER_CONFIG_FILE.get())
> > : Resources.toString(
> >   
> > TierModule.class.getClassLoader().getResource(TIER_CONFIG_PATH));
> > ```

Agree, the suggested alternative reads better.


- Amol


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121990
---


On March 2, 2016, 10:53 a.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 10:53 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121990
---



Code LGTM, only blocker for me is the NEWS.


NEWS (line 8)


remove trailing WS



NEWS (line 9)


This is a kind of lackluster news entry.  What does this actually _mean_ 
for users?  Will i see different behavior?  Is there a new capability i can use?



src/main/java/org/apache/aurora/scheduler/TierModule.java (line 74)


This code is a bit roundabout, Resource->File->String.  How about:

```
return TIER_CONFIG_FILE.hasAppliedValue()
? Files.toString(TIER_CONFIG_FILE.get())
: Resources.toString(
  TierModule.class.getClassLoader().getResource(TIER_CONFIG_PATH));
```


- Bill Farner


On March 2, 2016, 10:53 a.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 10:53 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121951
---



Master (98a2bc1) is red with this patch.
  ./build-support/jenkins/build.sh

+ date
Thu Mar  3 22:58:59 UTC 2016
+ ./gradlew -Pq clean build
:buildSrc:clean UP-TO-DATE
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'aurora'.
> Could not open proj class cache for build file 
> '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' 
> (/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/proj).
   > Timeout waiting to lock proj class cache for build file 
'/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' 
(/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/proj).
 It is currently in use by another Gradle instance.
 Owner PID: unknown
 Our PID: 29449
 Owner Operation: unknown
 Our operation: Initialize cache
 Lock file: 
/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/proj/cache.properties.lock

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 29.795 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 2, 2016, 6:53 p.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 6:53 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121929
---



Master (98a2bc1) is red with this patch.
  ./build-support/jenkins/build.sh

   
self._clock.converge(threads=[hct.threaded_health_checker])
   
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)
 
   assert hct._total_latency == 0
   assert 
hct.metrics.sample()['total_latency_secs'] == 0
 
   # start the health check (during health check it 
is still 0)
   epsilon = 0.001
   self._clock.tick(1.0 + epsilon)
   
self._clock.converge(threads=[hct.threaded_health_checker])
   
self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)
   assert hct._total_latency == 0
   assert 
hct.metrics.sample()['total_latency_secs'] == 0
   assert hct.metrics.sample()['checks'] == 0
 
   # finish the health check
   self._clock.tick(0.5 + epsilon)
   
self._clock.converge(threads=[hct.threaded_health_checker])
   
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # 
interval_secs
 > assert hct._total_latency == 0.5
 E AssertionError: assert 0.5009 
== 0.5
 E  +  where 0.5009 = 
._total_latency
 
 
src/test/python/apache/aurora/executor/common/test_health_checker.py:174: 
AssertionError
 -- Captured stderr call --
 [] Time now: 0.0
 [] Time now: 0.0
 [] Time now: 1.0
 [] Time now: 1.001
 [] Time now: 1.001
 [] Time now: 1.501
 [] Time now: 1.502
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  1 failed, 660 passed, 5 skipped, 1 warnings in 
406.90 seconds 
 
FAILURE


20:13:21 07:48   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 2, 2016, 6:53 p.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 6:53 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Amol Deshmukh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121924
---



@ReviewBot retry

- Amol Deshmukh


On March 2, 2016, 10:53 a.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 10:53 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-03 Thread Amol Deshmukh 


> On March 2, 2016, 11:15 a.m., Aurora ReviewBot wrote:
> > Master (8f98e6e) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >    self._clock.tick(0.5 + epsilon)
> >    
> > self._clock.converge(threads=[hct.threaded_health_checker])
> >    
> > self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # 
> > interval_secs
> >    assert hct._total_latency == 0.5
> >    assert 
> > hct.metrics.sample()['total_latency_secs'] == 0.5
> >    assert hct.metrics.sample()['checks'] == 
> > 1
> >  
> >    # tick again
> >    self._clock.tick(1.0 + epsilon)
> >    
> > self._clock.converge(threads=[hct.threaded_health_checker])
> >    self._clock.tick(0.5 + epsilon)
> >    
> > self._clock.converge(threads=[hct.threaded_health_checker])
> >    
> > self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # 
> > interval_secs
> >  > assert hct._total_latency == 1.0
> >  E AssertionError: assert 1.001 == 1.0
> >  E  +  where 1.001 = 
> >  > 0x7faff1015990>._total_latency
> >  
> >  
> > src/test/python/apache/aurora/executor/common/test_health_checker.py:184: 
> > AssertionError
> >  -- Captured stderr call --
> >  [ > 0x7faff1015fd0>] Time now: 0.0
> >  [ > 0x7faff1015fd0>] Time now: 0.0
> >  [ > 0x7faff1015fd0>] Time now: 1.0
> >  [ > 0x7faff1015fd0>] Time now: 1.001
> >  [ > 0x7faff1015fd0>] Time now: 1.001
> >  [ > 0x7faff1015fd0>] Time now: 1.501
> >  [ > 0x7faff1015fd0>] Time now: 1.502
> >  [ > 0x7faff1015fd0>] Time now: 1.502
> >  [ > 0x7faff1015fd0>] Time now: 2.502
> >  [ > 0x7faff1015fd0>] Time now: 2.503
> >  [ > 0x7faff1015fd0>] Time now: 2.503
> >  [ > 0x7faff1015fd0>] Time now: 3.003
> >  [ > 0x7faff1015fd0>] Time now: 3.004
> >   generated xml file: 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
> >  
> >   1 failed, 660 passed, 5 skipped, 1 warnings 
> > in 412.03 seconds 
> >  
> > FAILURE
> > 
> > 
> > 19:08:49 08:02   [complete]
> >FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

@ReviewBot retry


- Amol


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121694
---


On March 2, 2016, 10:53 a.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 10:53 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-03-02 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121694
---



Master (8f98e6e) is red with this patch.
  ./build-support/jenkins/build.sh

   self._clock.tick(0.5 + epsilon)
   
self._clock.converge(threads=[hct.threaded_health_checker])
   
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # 
interval_secs
   assert hct._total_latency == 0.5
   assert 
hct.metrics.sample()['total_latency_secs'] == 0.5
   assert hct.metrics.sample()['checks'] == 1
 
   # tick again
   self._clock.tick(1.0 + epsilon)
   
self._clock.converge(threads=[hct.threaded_health_checker])
   self._clock.tick(0.5 + epsilon)
   
self._clock.converge(threads=[hct.threaded_health_checker])
   
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # 
interval_secs
 > assert hct._total_latency == 1.0
 E AssertionError: assert 1.001 == 1.0
 E  +  where 1.001 = 
._total_latency
 
 
src/test/python/apache/aurora/executor/common/test_health_checker.py:184: 
AssertionError
 -- Captured stderr call --
 [] Time now: 0.0
 [] Time now: 0.0
 [] Time now: 1.0
 [] Time now: 1.001
 [] Time now: 1.001
 [] Time now: 1.501
 [] Time now: 1.502
 [] Time now: 1.502
 [] Time now: 2.502
 [] Time now: 2.503
 [] Time now: 2.503
 [] Time now: 3.003
 [] Time now: 3.004
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  1 failed, 660 passed, 5 skipped, 1 warnings in 
412.03 seconds 
 
FAILURE


19:08:49 08:02   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 2, 2016, 6:53 p.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated March 2, 2016, 6:53 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> d57ef371cd423c55bd80bb0b0803cfaf7a261c74 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed)

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-02-29 Thread Bill Farner 


> On Feb. 26, 2016, 4:57 p.m., Bill Farner wrote:
> > Is there a reason this needs to be required as opposed to providing a sane 
> > default (preferably matching current behavior)?
> 
> Amol Deshmukh wrote:
> You are right, at the moment it would be possible to provide a default 
> value without loss of functionality.
> 
> The rationale was that, since we would want to make this "required" 
> eventually, it would be easier for cluster operators to deal with this now 
> rather than being struck with the full-complexity of tier management later. I 
> have to admit though, I have been on the fence on this.
> 
> If making this a required option does not appear sufficiently justified, 
> let me know if providing a default like below seems like a reasonable 
> alternative:
> ```
> # Provide Arg-default pointing to the default tiers.json file in 
> classpath.
> # This will involve moving tiers.json from src/test/... to src/main/...
> 
> private static final Arg TIER_CONFIG_FILE = Arg.create(new File(
> TierModule.class
> .getClassLoader()
> .getResource("org/apache/aurora/scheduler/tiers.json")
> .getFile()));
> ```

I suggest make that the effective default, but not via `Arg.create(...)` just 
because it's unlikely to present well in help output.  Just handle empty/null 
when you read the `TIER_CONFIG_FILE` value.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121023
---


On Feb. 26, 2016, 2:20 p.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated Feb. 26, 2016, 2:20 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-02-29 Thread Amol Deshmukh 


> On Feb. 26, 2016, 4:57 p.m., Bill Farner wrote:
> > Is there a reason this needs to be required as opposed to providing a sane 
> > default (preferably matching current behavior)?

You are right, at the moment it would be possible to provide a default value 
without loss of functionality.

The rationale was that, since we would want to make this "required" eventually, 
it would be easier for cluster operators to deal with this now rather than 
being struck with the full-complexity of tier management later. I have to admit 
though, I have been on the fence on this.

If making this a required option does not appear sufficiently justified, let me 
know if providing a default like below seems like a reasonable alternative:
```
# Provide Arg-default pointing to the default tiers.json file in classpath.
# This will involve moving tiers.json from src/test/... to src/main/...

private static final Arg TIER_CONFIG_FILE = Arg.create(new File(
TierModule.class
.getClassLoader()
.getResource("org/apache/aurora/scheduler/tiers.json")
.getFile()));
```


- Amol


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121023
---


On Feb. 26, 2016, 2:20 p.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated Feb. 26, 2016, 2:20 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

2016-02-26 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43925/#review121023
---



Is there a reason this needs to be required as opposed to providing a sane 
default (preferably matching current behavior)?

- Bill Farner


On Feb. 26, 2016, 2:20 p.m., Amol Deshmukh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43925/
> ---
> 
> (Updated Feb. 26, 2016, 2:20 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1616: [part 2] make tier_config mandatory argument when starting up 
> the scheduler.
> 
> 
> Diffs
> -
> 
>   NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> dc1ef82bce9e8e243974f8b97165f4417d870a7e 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> fce6e51548b23b7bc3e33468c2b3a9627a68debd 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 
> b5f065ec433b4df50a5c1ca7ef87d51292816db6 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
> aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 
>   src/test/resources/org/apache/aurora/scheduler/tiers.json 
> 21407738fafc9bc5e6ce7888b4b9c32b2f005bca 
> 
> Diff: https://reviews.apache.org/r/43925/diff/
> 
> 
> Testing
> ---
> 
> # Java build with checkstyle:
> ```
> $ ./gradlew build -Pq
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 44.365 secs
> ```
> 
> # End-to-end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> 
> ```
> 
> # Ensure affected benchmarks run:
> ```
> $ ./gradlew -q jmh  -Pbenchmarks='S.*Benchmark.?'
> ...
> Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt
> 
> $ ls -1 dist/reports/jmh/human.txt
> dist/reports/jmh/human.txt
> ...
> 
> ```
> 
> # Python client tests:
> ```
> ./pants test.pytest --no-fast src/test/python/apache/aurora::
> ...
>SUCCESS
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>