Re: Review Request 51192: Moving custom executors documentation to features, adding gorealis to tools

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51192/#review146119
---


Ship it!




Master (a4fdf28) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 18, 2016, 6:51 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51192/
> ---
> 
> (Updated Aug. 18, 2016, 6:51 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Moved custom executor documentation from docs/operations/configuration.md 
> since it grew out of proportion.
> Added an explaination on how a thrift object needs to be configured in a 
> createJob call and referenced using a custom Client for now.
> 
> 
> Diffs
> -
> 
>   docs/additional-resources/tools.md 64a4f74f38240fa85336105fd4f1c8c6771de852 
>   docs/features/custom-executors.md PRE-CREATION 
>   docs/operations/configuration.md bbcffac686cddb97f8a137afce1ed50a260b7359 
> 
> Diff: https://reviews.apache.org/r/51192/diff/
> 
> 
> Testing
> ---
> 
> None, doc changes only.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 51192: Moving custom executors documentation to features, adding gorealis to tools

[Renan DelValle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51192/
---

(Updated Aug. 18, 2016, 11:51 a.m.)


Review request for Aurora.


Changes
---

Implementing feedback.


Repository: aurora


Description
---

Moved custom executor documentation from docs/operations/configuration.md since 
it grew out of proportion.
Added an explaination on how a thrift object needs to be configured in a 
createJob call and referenced using a custom Client for now.


Diffs (updated)
-

  docs/additional-resources/tools.md 64a4f74f38240fa85336105fd4f1c8c6771de852 
  docs/features/custom-executors.md PRE-CREATION 
  docs/operations/configuration.md bbcffac686cddb97f8a137afce1ed50a260b7359 

Diff: https://reviews.apache.org/r/51192/diff/


Testing
---

None, doc changes only.


Thanks,

Renan DelValle

Re: Review Request 51192: Moving custom executors documentation to features, adding gorealis to tools

[Renan DelValle]

> On Aug. 18, 2016, 7:48 a.m., Joshua Cohen wrote:
> > docs/operations/configuration.md, lines 145-149
> > 
> >
> > I'd say leave something along these lines this in this file with a link 
> > to the full documentation?

That's actually a great idea. I'll go ahead and do that.


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51192/#review146082
---


On Aug. 17, 2016, 3:52 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51192/
> ---
> 
> (Updated Aug. 17, 2016, 3:52 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Moved custom executor documentation from docs/operations/configuration.md 
> since it grew out of proportion.
> Added an explaination on how a thrift object needs to be configured in a 
> createJob call and referenced using a custom Client for now.
> 
> 
> Diffs
> -
> 
>   docs/additional-resources/tools.md 64a4f74f38240fa85336105fd4f1c8c6771de852 
>   docs/features/custom-executors.md PRE-CREATION 
>   docs/operations/configuration.md bbcffac686cddb97f8a137afce1ed50a260b7359 
> 
> Diff: https://reviews.apache.org/r/51192/diff/
> 
> 
> Testing
> ---
> 
> None, doc changes only.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 51192: Moving custom executors documentation to features, adding gorealis to tools

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51192/#review146082
---


Ship it!




lgtm modulo the below.


docs/operations/configuration.md 


I'd say leave something along these lines this in this file with a link to 
the full documentation?


- Joshua Cohen


On Aug. 17, 2016, 10:52 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51192/
> ---
> 
> (Updated Aug. 17, 2016, 10:52 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Moved custom executor documentation from docs/operations/configuration.md 
> since it grew out of proportion.
> Added an explaination on how a thrift object needs to be configured in a 
> createJob call and referenced using a custom Client for now.
> 
> 
> Diffs
> -
> 
>   docs/additional-resources/tools.md 64a4f74f38240fa85336105fd4f1c8c6771de852 
>   docs/features/custom-executors.md PRE-CREATION 
>   docs/operations/configuration.md bbcffac686cddb97f8a137afce1ed50a260b7359 
> 
> Diff: https://reviews.apache.org/r/51192/diff/
> 
> 
> Testing
> ---
> 
> None, doc changes only.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 51192: Moving custom executors documentation to features, adding gorealis to tools

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51192/#review146051
---


Ship it!




Master (a4fdf28) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 17, 2016, 10:52 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51192/
> ---
> 
> (Updated Aug. 17, 2016, 10:52 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Moved custom executor documentation from docs/operations/configuration.md 
> since it grew out of proportion.
> Added an explaination on how a thrift object needs to be configured in a 
> createJob call and referenced using a custom Client for now.
> 
> 
> Diffs
> -
> 
>   docs/additional-resources/tools.md 64a4f74f38240fa85336105fd4f1c8c6771de852 
>   docs/features/custom-executors.md PRE-CREATION 
>   docs/operations/configuration.md bbcffac686cddb97f8a137afce1ed50a260b7359 
> 
> Diff: https://reviews.apache.org/r/51192/diff/
> 
> 
> Testing
> ---
> 
> None, doc changes only.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>