Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-06 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151684
---


Ship it!




Ship It!

- Joshua Cohen


On Oct. 6, 2016, 4:26 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 6, 2016, 4:26 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>|   8 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java   
>|   8 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java
>|   7 +-
>  src/main/java/org/apache/aurora/scheduler/{app => 
> discovery}/ServiceGroupMonitor.java   
>   |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java
>|  10 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
>  |   9 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java  
>  |  51 +++
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
>|   9 +-
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
>  |  22 +--
>  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java   
>

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151677
---



Master (fdb536a) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 6, 2016, 4:26 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 6, 2016, 4:26 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>|   8 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java   
>|   8 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java
>|   7 +-
>  src/main/java/org/apache/aurora/scheduler/{app => 
> discovery}/ServiceGroupMonitor.java   
>   |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java
>|  10 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
>  |   9 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java  
>  |  51 +++
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
>|   9 +-
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
>  |  22 +--
>  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
>

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-06 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/
---

(Updated Oct. 6, 2016, 10:26 a.m.)


Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.


Changes
---

Fix comment typos.

 config/findbugs/excludeFilter.xml   | 2 +-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


Bugs: AURORA-1669
https://issues.apache.org/jira/browse/AURORA-1669


Repository: aurora


Description
---

Remove unused code and restrict visibility where possible. Also fix up
various warnings.

 build.gradle   
   |  13 +-
 commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java  
   | 372 
--
 commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java   
   | 167 
--
 
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
 | 140 ---
 
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
 | 210 

 
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
  | 139 
---
 config/findbugs/excludeFilter.xml  
   |   8 ++
 docs/features/service-discovery.md 
   |   2 +-
 src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java  
   |   6 +-
 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java   
   |   4 +-
 {commons/src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java   
 |  30 ++--
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
|   6 +-
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
   |   1 -
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
  |   1 -
 
src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java 
  |   8 +-
 {commons/src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java 
 |   8 +-
 
src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java 
  |   7 +-
 src/main/java/org/apache/aurora/scheduler/{app => 
discovery}/ServiceGroupMonitor.java 
|   4 +-
 {commons/src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java  
 |  10 +-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java   
   |   9 +-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java
   |  51 +++
 .../src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
   |   9 +-
 .../src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
 |  22 +--
 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java  
   |   2 +-
 src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
   |   4 +-
 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java  
   |   4 +-
 src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151670
---



Master (fdb536a) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 6, 2016, 4:01 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 6, 2016, 4:01 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>|   8 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java   
>|   8 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java
>|   7 +-
>  src/main/java/org/apache/aurora/scheduler/{app => 
> discovery}/ServiceGroupMonitor.java   
>   |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java
>|  10 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
>  |   9 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java  
>  |  51 +++
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
>|   9 +-
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
>  |  22 +--
>  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
>

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-06 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151668
---


Ship it!




Ship It!

- Stephan Erb


On Okt. 6, 2016, 6:01 nachm., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Okt. 6, 2016, 6:01 nachm.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>|   8 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java   
>|   8 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java
>|   7 +-
>  src/main/java/org/apache/aurora/scheduler/{app => 
> discovery}/ServiceGroupMonitor.java   
>   |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java
>|  10 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
>  |   9 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java  
>  |  51 +++
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
>|   9 +-
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
>  |  22 +--
>  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java   
>

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-06 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/
---

(Updated Oct. 6, 2016, 10:01 a.m.)


Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.


Changes
---

Fixup missing logback dep and kill obsolete Twitter verbiage.

 build.gradle| 4 
+++-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)


Bugs: AURORA-1669
https://issues.apache.org/jira/browse/AURORA-1669


Repository: aurora


Description
---

Remove unused code and restrict visibility where possible. Also fix up
various warnings.

 build.gradle   
   |  13 +-
 commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java  
   | 372 
--
 commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java   
   | 167 
--
 
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
 | 140 ---
 
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
 | 210 

 
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
  | 139 
---
 config/findbugs/excludeFilter.xml  
   |   8 ++
 docs/features/service-discovery.md 
   |   2 +-
 src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java  
   |   6 +-
 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java   
   |   4 +-
 {commons/src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java   
 |  30 ++--
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
|   6 +-
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
   |   1 -
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
  |   1 -
 
src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java 
  |   8 +-
 {commons/src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java 
 |   8 +-
 
src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java 
  |   7 +-
 src/main/java/org/apache/aurora/scheduler/{app => 
discovery}/ServiceGroupMonitor.java 
|   4 +-
 {commons/src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java  
 |  10 +-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java   
   |   9 +-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java
   |  51 +++
 .../src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
   |   9 +-
 .../src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
 |  22 +--
 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java  
   |   2 +-
 src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
   |   4 +-
 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java  
   |   4 +-
 src/test/java/org/apache/aurora/schedu

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-06 Thread John Sirois 


> On Oct. 5, 2016, 10:52 p.m., Aurora ReviewBot wrote:
> > Master (e91130e) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > 
> > org.apache.aurora.common.stats.RateTest > testZeroDelta FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testInputsRegistered FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:69
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testVariableRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testRateOfRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:166
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testFixedRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testNegativeRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > 141 tests completed, 77 failed
> > :commons:test FAILED
> > 
> > FAILURE: Build failed with an exception.
> > 
> > * What went wrong:
> > Execution failed for task ':commons:test'.
> > > There were failing tests. See the report at: 
> > > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/reports/tests/index.html
> > 
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or 
> > --debug option to get more log output.
> > 
> > BUILD FAILED
> > 
> > Total time: 9 mins 5.824 secs
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"
> 
> John Sirois wrote:
> Aha - this failure only happens under gradle 3.x... digging, but likely a 
> dependency scope issue.

Not sure exactly how my change triggered this, but it was in fact an old 
missing dep in :commons combined with new stricter gradle isolation.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151627
---


On Oct. 5, 2016, 9:29 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 5, 2016, 9:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/o

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-06 Thread John Sirois 


> On Oct. 5, 2016, 10:07 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java, 
> > line 29
> > 
> >
> > Maybe we can remove the 'Twitter' reference here?

Removed.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151626
---


On Oct. 5, 2016, 9:29 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 5, 2016, 9:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>|   8 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java   
>|   8 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java
>|   7 +-
>  src/main/java/org/apache/aurora/scheduler/{app => 
> discovery}/ServiceGroupMonitor.java   
>   |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java
>|  10 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
>  |   9 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java  
>  |  51 +++
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
>|   9 +-
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
>  |  22 +--
>  src/main/java/org/apache/a

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-06 Thread John Sirois 


> On Oct. 5, 2016, 10:52 p.m., Aurora ReviewBot wrote:
> > Master (e91130e) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > 
> > org.apache.aurora.common.stats.RateTest > testZeroDelta FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testInputsRegistered FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:69
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testVariableRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testRateOfRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:166
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testFixedRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testNegativeRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > 141 tests completed, 77 failed
> > :commons:test FAILED
> > 
> > FAILURE: Build failed with an exception.
> > 
> > * What went wrong:
> > Execution failed for task ':commons:test'.
> > > There were failing tests. See the report at: 
> > > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/reports/tests/index.html
> > 
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or 
> > --debug option to get more log output.
> > 
> > BUILD FAILED
> > 
> > Total time: 9 mins 5.824 secs
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

Aha - this failure only happens under gradle 3.x... digging, but likely a 
dependency scope issue.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151627
---


On Oct. 5, 2016, 9:29 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 5, 2016, 9:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/auror

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-05 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151627
---



Master (e91130e) is red with this patch.
  ./build-support/jenkins/build.sh


org.apache.aurora.common.stats.RateTest > testZeroDelta FAILED
java.lang.NoClassDefFoundError at RateTest.java:229
java.lang.NoClassDefFoundError at RateTest.java:58

org.apache.aurora.common.stats.RateTest > testInputsRegistered FAILED
java.lang.NoClassDefFoundError at RateTest.java:69
java.lang.NoClassDefFoundError at RateTest.java:58

org.apache.aurora.common.stats.RateTest > testVariableRate FAILED
java.lang.NoClassDefFoundError at RateTest.java:229
java.lang.NoClassDefFoundError at RateTest.java:58

org.apache.aurora.common.stats.RateTest > testRateOfRate FAILED
java.lang.NoClassDefFoundError at RateTest.java:166
java.lang.NoClassDefFoundError at RateTest.java:58

org.apache.aurora.common.stats.RateTest > testFixedRate FAILED
java.lang.NoClassDefFoundError at RateTest.java:229
java.lang.NoClassDefFoundError at RateTest.java:58

org.apache.aurora.common.stats.RateTest > testNegativeRate FAILED
java.lang.NoClassDefFoundError at RateTest.java:229
java.lang.NoClassDefFoundError at RateTest.java:58

141 tests completed, 77 failed
:commons:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':commons:test'.
> There were failing tests. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/reports/tests/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 9 mins 5.824 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 6, 2016, 3:29 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 6, 2016, 3:29 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-05 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151626
---


Ship it!





src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java (line 
29)


Maybe we can remove the 'Twitter' reference here?


- Zameer Manji


On Oct. 5, 2016, 8:29 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 5, 2016, 8:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>|   8 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java   
>|   8 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java
>|   7 +-
>  src/main/java/org/apache/aurora/scheduler/{app => 
> discovery}/ServiceGroupMonitor.java   
>   |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java
>|  10 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
>  |   9 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java  
>  |  51 +++
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
>|   9 +-
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
>  |  22 +--
>  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
>

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-05 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151624
---



@ReviewBot retry

- John Sirois


On Oct. 5, 2016, 9:29 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 5, 2016, 9:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>|   8 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java   
>|   8 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java
>|   7 +-
>  src/main/java/org/apache/aurora/scheduler/{app => 
> discovery}/ServiceGroupMonitor.java   
>   |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java
>|  10 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
>  |   9 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java  
>  |  51 +++
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
>|   9 +-
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
>  |  22 +--
>  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java   
>

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-05 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151623
---



Master (e91130e) is red with this patch.
  ./build-support/jenkins/build.sh


org.apache.aurora.common.stats.RateTest > testZeroDelta FAILED
java.lang.NoClassDefFoundError at RateTest.java:229
java.lang.NoClassDefFoundError at RateTest.java:58

org.apache.aurora.common.stats.RateTest > testInputsRegistered FAILED
java.lang.NoClassDefFoundError at RateTest.java:69
java.lang.NoClassDefFoundError at RateTest.java:58

org.apache.aurora.common.stats.RateTest > testVariableRate FAILED
java.lang.NoClassDefFoundError at RateTest.java:229
java.lang.NoClassDefFoundError at RateTest.java:58

org.apache.aurora.common.stats.RateTest > testRateOfRate FAILED
java.lang.NoClassDefFoundError at RateTest.java:166
java.lang.NoClassDefFoundError at RateTest.java:58

org.apache.aurora.common.stats.RateTest > testFixedRate FAILED
java.lang.NoClassDefFoundError at RateTest.java:229
java.lang.NoClassDefFoundError at RateTest.java:58

org.apache.aurora.common.stats.RateTest > testNegativeRate FAILED
java.lang.NoClassDefFoundError at RateTest.java:229
java.lang.NoClassDefFoundError at RateTest.java:58

141 tests completed, 77 failed
:commons:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':commons:test'.
> There were failing tests. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/reports/tests/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 7 mins 2.529 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 6, 2016, 3:29 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 6, 2016, 3:29 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/