Re: Review Request 37956: Only process instances if there's been a change.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37956/#review97500 --- Ship it! Ship It! - David McLaughlin On Sept. 1, 2015, 4:03 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37956/ > --- > > (Updated Sept. 1, 2015, 4:03 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1345 > https://issues.apache.org/jira/browse/AURORA-1345 > > > Repository: aurora > > > Description > --- > > The `true` parameter to `scope.$watch` tells Angular to only execute the > supplied function if the watched data has changed. Given our 15s polling > interval is likely less than time it takes for any progress to be made on an > update, this removes the majority of (no-op) DOM operations. > > > Diffs > - > > src/main/resources/scheduler/assets/js/directives.js > d8f722c441b9399e7eacd6ae29966b3fb24a422d > > Diff: https://reviews.apache.org/r/37956/diff/ > > > Testing > --- > > Left tab open continually polling a job with ~3000 instances, confirmed that > memory usage did not grow beyond ~200MB. > > > Thanks, > > Joshua Cohen > >
Re: Review Request 37956: Only process instances if there's been a change.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37956/#review97479 --- Ship it! Ship It! - Bill Farner On Sept. 1, 2015, 9:03 a.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37956/ > --- > > (Updated Sept. 1, 2015, 9:03 a.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1345 > https://issues.apache.org/jira/browse/AURORA-1345 > > > Repository: aurora > > > Description > --- > > The `true` parameter to `scope.$watch` tells Angular to only execute the > supplied function if the watched data has changed. Given our 15s polling > interval is likely less than time it takes for any progress to be made on an > update, this removes the majority of (no-op) DOM operations. > > > Diffs > - > > src/main/resources/scheduler/assets/js/directives.js > d8f722c441b9399e7eacd6ae29966b3fb24a422d > > Diff: https://reviews.apache.org/r/37956/diff/ > > > Testing > --- > > Left tab open continually polling a job with ~3000 instances, confirmed that > memory usage did not grow beyond ~200MB. > > > Thanks, > > Joshua Cohen > >
Re: Review Request 37956: Only process instances if there's been a change.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37956/#review97503 --- Master (64c00f1) is red with this patch. ./build-support/jenkins/build.sh page = self.process_index(url, page) File "/usr/lib/python2.7/dist-packages/setuptools/package_index.py", line 405, in process_index self.scan_url(new_url) File "/usr/lib/python2.7/dist-packages/setuptools/package_index.py", line 769, in scan_url self.process_url(url, True) File "/usr/lib/python2.7/dist-packages/setuptools/package_index.py", line 313, in process_url page = f.read() File "/usr/lib/python2.7/socket.py", line 351, in read data = self._sock.recv(rbufsize) File "/usr/lib/python2.7/httplib.py", line 543, in read return self._read_chunked(amt) File "/usr/lib/python2.7/httplib.py", line 603, in _read_chunked value.append(self._safe_read(amt)) File "/usr/lib/python2.7/httplib.py", line 658, in _safe_read chunk = self.fp.read(min(amt, MAXAMOUNT)) File "/usr/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left) socket.timeout: timed out Cleaning up... Command python setup.py egg_info failed with error code 1 in /tmp/user/2/pip_build_jenkins/protobuf Storing debug log for failure in /home/jenkins/.pip/pip.log I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 2, 2015, 6:09 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37956/ > --- > > (Updated Sept. 2, 2015, 6:09 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1345 > https://issues.apache.org/jira/browse/AURORA-1345 > > > Repository: aurora > > > Description > --- > > The `true` parameter to `scope.$watch` tells Angular to only execute the > supplied function if the watched data has changed. Given our 15s polling > interval is likely less than time it takes for any progress to be made on an > update, this removes the majority of (no-op) DOM operations. > > > Diffs > - > > src/main/resources/scheduler/assets/js/directives.js > c02c26f51ec4f190e61a1e79e4e045e9765bc2a5 > > Diff: https://reviews.apache.org/r/37956/diff/ > > > Testing > --- > > Left tab open continually polling a job with ~3000 instances, confirmed that > memory usage did not grow beyond ~200MB. > > > Thanks, > > Joshua Cohen > >
Review Request 37956: Only process instances if there's been a change.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37956/ --- Review request for Aurora and David McLaughlin. Bugs: AURORA-1345 https://issues.apache.org/jira/browse/AURORA-1345 Repository: aurora Description --- The `true` parameter to `scope.$watch` tells Angular to only execute the supplied function if the watched data has changed. Given our 15s polling interval is likely less than time it takes for any progress to be made on an update, this removes the majority of (no-op) DOM operations. Diffs - src/main/resources/scheduler/assets/js/directives.js d8f722c441b9399e7eacd6ae29966b3fb24a422d Diff: https://reviews.apache.org/r/37956/diff/ Testing --- Left tab open continually polling a job with ~3000 instances, confirmed that memory usage did not grow beyond ~200MB. Thanks, Joshua Cohen
Re: Review Request 37956: Only process instances if there's been a change.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37956/#review97125 --- Master (04b6858) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 31, 2015, 6:50 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37956/ > --- > > (Updated Aug. 31, 2015, 6:50 p.m.) > > > Review request for Aurora and David McLaughlin. > > > Bugs: AURORA-1345 > https://issues.apache.org/jira/browse/AURORA-1345 > > > Repository: aurora > > > Description > --- > > The `true` parameter to `scope.$watch` tells Angular to only execute the > supplied function if the watched data has changed. Given our 15s polling > interval is likely less than time it takes for any progress to be made on an > update, this removes the majority of (no-op) DOM operations. > > > Diffs > - > > src/main/resources/scheduler/assets/js/directives.js > d8f722c441b9399e7eacd6ae29966b3fb24a422d > > Diff: https://reviews.apache.org/r/37956/diff/ > > > Testing > --- > > Left tab open continually polling a job with ~3000 instances, confirmed that > memory usage did not grow beyond ~200MB. > > > Thanks, > > Joshua Cohen > >
