Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147900
---



This change is now on master at `0c90c862a14c3a5efe0fdf0f30ee41c01b96b434`.

- Zameer Manji


On Sept. 5, 2016, 11:56 a.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 5, 2016, 11:56 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147899
---


Ship it!




Ship It!

- Zameer Manji


On Sept. 5, 2016, 11:56 a.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 5, 2016, 11:56 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147855
---


Ship it!




Ship It!

- Joshua Cohen


On Sept. 5, 2016, 6:56 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 5, 2016, 6:56 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147853
---


Ship it!




Ship It!

- Maxim Khutornenko


On Sept. 5, 2016, 6:56 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 5, 2016, 6:56 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147781
---


Ship it!




Ship It!

- Stephan Erb


On Sept. 5, 2016, 8:56 nachm., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 5, 2016, 8:56 nachm.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Kai Huang]

> On Sept. 3, 2016, 10:14 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java, line 76
> > 
> >
> > Please update the documentation to cover the new SLA metric 
> > https://github.com/apache/aurora/blob/master/docs/features/sla-metrics.md

Updated the documentation to cover MTTS. ResourceAggregates.java has been 
deprecated, updated it as ResourceBag.java.


- Kai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147730
---


On Sept. 5, 2016, 6:56 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 5, 2016, 6:56 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review14
---


Ship it!




Master (5d3f945) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 5, 2016, 6:56 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 5, 2016, 6:56 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Kai Huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/
---

(Updated Sept. 5, 2016, 6:56 p.m.)


Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.


Changes
---

Updated the documentation to cover the new metric MTTS. Fixed some deprecated 
links in the readme.


Repository: aurora


Description
---

A new MTTS (Median Time To Starting) metric is added to the sla module in 
addition to MTTA and MTTR.

This review request is related to my previous review request: 
https://reviews.apache.org/r/51536

In the new implementation, the executor starts health check at STARTING, if a 
successful health check is performed before initial_interval_sec expires, it 
transitions into RUNNING state. Therefore, MTTS gives us an idea of how long it 
takes for a task to become active, whereas the difference between MTTR and MTTS 
represents the warm-up period for a task.

See the following issues for more backgrounds:

https://issues.apache.org/jira/browse/AURORA-1221

https://issues.apache.org/jira/browse/AURORA-1222

The new metrics represents the median time spent waiting for a set of tasks to 
reach STARTING status within a time frame(including the tasks turning into 
RUNNING state within the time frame).

Here I regard STARTING as an active state. However, STARTING state is account 
for platform and job uptime calculations.


Diffs (updated)
-

  docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
4f243aab5a2c2f86ec795025e86302a09f864e2d 
  src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
90ea3a169dadc72e7d7493544ab865ec59d4d425 

Diff: https://reviews.apache.org/r/51580/diff/


Testing (updated)
---

./gradlew build

./gradlew :test

./build-support/jenkins/build.sh


Thanks,

Kai Huang

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Kai Huang]

> On Sept. 1, 2016, 7:53 p.m., Zameer Manji wrote:
> > Can you set the depends on field of this review to be `51536`? So we know 
> > that this patch is blocked on that review landing first?
> 
> Stephan Erb wrote:
> Is it really blocked? Nothing would be wrong or broken if we submit this 
> right away.

I agree.


- Kai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147598
---


On Sept. 1, 2016, 8:19 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 1, 2016, 8:19 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test --tests 
> "org.apache.aurora.scheduler.updater.InstanceUpdaterTest"
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147730
---




src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java (line 76)


Please update the documentation to cover the new SLA metric 
https://github.com/apache/aurora/blob/master/docs/features/sla-metrics.md


- Stephan Erb


On Sept. 1, 2016, 10:19 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 1, 2016, 10:19 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test --tests 
> "org.apache.aurora.scheduler.updater.InstanceUpdaterTest"
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Stephan Erb]

> On Sept. 1, 2016, 9:53 p.m., Zameer Manji wrote:
> > Can you set the depends on field of this review to be `51536`? So we know 
> > that this patch is blocked on that review landing first?

Is it really blocked? Nothing would be wrong or broken if we submit this right 
away.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147598
---


On Sept. 1, 2016, 10:19 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 1, 2016, 10:19 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test --tests 
> "org.apache.aurora.scheduler.updater.InstanceUpdaterTest"
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Kai Huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/
---

(Updated Sept. 1, 2016, 8:19 p.m.)


Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.


Changes
---

This review request depends on 51536


Repository: aurora


Description
---

A new MTTS (Median Time To Starting) metric is added to the sla module in 
addition to MTTA and MTTR.

This review request is related to my previous review request: 
https://reviews.apache.org/r/51536

In the new implementation, the executor starts health check at STARTING, if a 
successful health check is performed before initial_interval_sec expires, it 
transitions into RUNNING state. Therefore, MTTS gives us an idea of how long it 
takes for a task to become active, whereas the difference between MTTR and MTTS 
represents the warm-up period for a task.

See the following issues for more backgrounds:

https://issues.apache.org/jira/browse/AURORA-1221

https://issues.apache.org/jira/browse/AURORA-1222

The new metrics represents the median time spent waiting for a set of tasks to 
reach STARTING status within a time frame(including the tasks turning into 
RUNNING state within the time frame).

Here I regard STARTING as an active state. However, STARTING state is account 
for platform and job uptime calculations.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
4f243aab5a2c2f86ec795025e86302a09f864e2d 
  src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
90ea3a169dadc72e7d7493544ab865ec59d4d425 

Diff: https://reviews.apache.org/r/51580/diff/


Testing
---

./gradlew build

./gradlew :test --tests 
"org.apache.aurora.scheduler.updater.InstanceUpdaterTest"

./build-support/jenkins/build.sh


Thanks,

Kai Huang

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147600
---


Ship it!




Master (bd11b1c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 1, 2016, 7:37 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 1, 2016, 7:37 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test --tests 
> "org.apache.aurora.scheduler.updater.InstanceUpdaterTest"
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147598
---



Can you set the depends on field of this review to be `51536`? So we know that 
this patch is blocked on that review landing first?

- Zameer Manji


On Sept. 1, 2016, 12:37 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 1, 2016, 12:37 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test --tests 
> "org.apache.aurora.scheduler.updater.InstanceUpdaterTest"
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Kai Huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/
---

(Updated Sept. 1, 2016, 7:37 p.m.)


Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.


Changes
---

Updated description.


Repository: aurora


Description (updated)
---

A new MTTS (Median Time To Starting) metric is added to the sla module in 
addition to MTTA and MTTR.

This review request is related to my previous review request: 
https://reviews.apache.org/r/51536

In the new implementation, the executor starts health check at STARTING, if a 
successful health check is performed before initial_interval_sec expires, it 
transitions into RUNNING state. Therefore, MTTS gives us an idea of how long it 
takes for a task to become active, whereas the difference between MTTR and MTTS 
represents the warm-up period for a task.

See the following issues for more backgrounds:

https://issues.apache.org/jira/browse/AURORA-1221

https://issues.apache.org/jira/browse/AURORA-1222

The new metrics represents the median time spent waiting for a set of tasks to 
reach STARTING status within a time frame(including the tasks turning into 
RUNNING state within the time frame).

Here I regard STARTING as an active state. However, STARTING state is account 
for platform and job uptime calculations.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
4f243aab5a2c2f86ec795025e86302a09f864e2d 
  src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
90ea3a169dadc72e7d7493544ab865ec59d4d425 

Diff: https://reviews.apache.org/r/51580/diff/


Testing
---

./gradlew build

./gradlew :test --tests 
"org.apache.aurora.scheduler.updater.InstanceUpdaterTest"

./build-support/jenkins/build.sh


Thanks,

Kai Huang

Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

[Kai Huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/
---

Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.


Repository: aurora


Description
---

A new MTTS (Median Time To Starting) metric is added to the sla module in 
addition to MTTA and MTTR.

This review request is related to my previous review request: 
https://reviews.apache.org/r/51536

In the new implementation, the executor starts health check at STARTING, if a 
successful health check is performed before initial_interval_sec expires, it 
transitions into RUNNING state. Therefore, MTTS gives us an idea of how long it 
takes for a task to become active.

See the following issues for more backgrounds:

https://issues.apache.org/jira/browse/AURORA-1221

https://issues.apache.org/jira/browse/AURORA-1222

The new metrics represents the median time spent waiting for a set of tasks to 
reach STARTING status within a time frame(including the tasks turning into 
RUNNING state within the time frame).

Here I regard STARTING as an active state. However, STARTING state is account 
for platform and job uptime calculations.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
4f243aab5a2c2f86ec795025e86302a09f864e2d 
  src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
90ea3a169dadc72e7d7493544ab865ec59d4d425 

Diff: https://reviews.apache.org/r/51580/diff/


Testing
---

./gradlew build

./gradlew :test --tests 
"org.apache.aurora.scheduler.updater.InstanceUpdaterTest"

./build-support/jenkins/build.sh


Thanks,

Kai Huang