Re: Review Request 48211: fix containers doc example

2016-06-03 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48211/#review136069
---



Thanks for noticing!


docs/features/containers.md (line 13)


Shouldn't that be `hello_world_proc` instead?


- Stephan Erb


On June 3, 2016, 5:43 p.m., Raymond Khalife wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48211/
> ---
> 
> (Updated June 3, 2016, 5:43 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> fix containers doc example
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md f774f18356d4c1c8b81edd97a90b9891fc7dbfaf 
> 
> Diff: https://reviews.apache.org/r/48211/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Raymond Khalife
> 
>

Re: Review Request 48211: fix containers doc example

2016-06-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48211/#review136071
---


Ship it!




Master (edd47d0) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 3, 2016, 4:07 p.m., Raymond Khalife wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48211/
> ---
> 
> (Updated June 3, 2016, 4:07 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> fix containers doc example
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md f774f18356d4c1c8b81edd97a90b9891fc7dbfaf 
> 
> Diff: https://reviews.apache.org/r/48211/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Raymond Khalife
> 
>

Review Request 48210: fix container docs example

2016-06-03 Thread Raymond Khalife 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48210/
---

Review request for Aurora.


Repository: aurora


Description
---

fix container docs example


Diffs
-

  docs/features/containers.md f774f18356d4c1c8b81edd97a90b9891fc7dbfaf 

Diff: https://reviews.apache.org/r/48210/diff/


Testing
---

N/A


Thanks,

Raymond Khalife

Re: Review Request 48211: fix containers doc example

2016-06-03 Thread Raymond Khalife 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48211/
---

(Updated June 3, 2016, 4:07 p.m.)


Review request for Aurora and Stephan Erb.


Changes
---

crap, sorry


Repository: aurora


Description
---

fix containers doc example


Diffs (updated)
-

  docs/features/containers.md f774f18356d4c1c8b81edd97a90b9891fc7dbfaf 

Diff: https://reviews.apache.org/r/48211/diff/


Testing
---

N/A


Thanks,

Raymond Khalife

Re: Review Request 48210: fix container docs example

2016-06-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48210/#review136070
---


Ship it!




Master (edd47d0) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 3, 2016, 3:38 p.m., Raymond Khalife wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48210/
> ---
> 
> (Updated June 3, 2016, 3:38 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> fix container docs example
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md f774f18356d4c1c8b81edd97a90b9891fc7dbfaf 
> 
> Diff: https://reviews.apache.org/r/48210/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Raymond Khalife
> 
>

Re: Review Request 48211: fix containers doc example

2016-06-03 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48211/#review136072
---


Ship it!




Ship It!

- Stephan Erb


On June 3, 2016, 6:07 p.m., Raymond Khalife wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48211/
> ---
> 
> (Updated June 3, 2016, 6:07 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> fix containers doc example
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md f774f18356d4c1c8b81edd97a90b9891fc7dbfaf 
> 
> Diff: https://reviews.apache.org/r/48211/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Raymond Khalife
> 
>

Review Request 48211: fix containers doc example

2016-06-03 Thread Raymond Khalife 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48211/
---

Review request for Aurora.


Repository: aurora


Description
---

fix containers doc example


Diffs
-

  docs/features/containers.md f774f18356d4c1c8b81edd97a90b9891fc7dbfaf 

Diff: https://reviews.apache.org/r/48211/diff/


Testing
---

N/A


Thanks,

Raymond Khalife

Review Request 48218: Document the logfile locations used in the vagrant box

2016-06-03 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48218/
---

Review request for Aurora and Joshua Cohen.


Repository: aurora


Description
---

Document the logfile locations used in the vagrant box


Diffs
-

  docs/getting-started/vagrant.md 44606009759a68cb142be4f2c7061ad8d0a39066 

Diff: https://reviews.apache.org/r/48218/diff/


Testing
---


Thanks,

Stephan Erb

Review Request 48216: Change the UI to refer to Mesos Agents instead of Mesos Slaves.

2016-06-03 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48216/
---

Review request for Aurora and Joshua Cohen.


Bugs: AURORA-1449 and AURORA-1450
https://issues.apache.org/jira/browse/AURORA-1449
https://issues.apache.org/jira/browse/AURORA-1450


Repository: aurora


Description
---

Change the UI to refer to Mesos Agents instead of Mesos Slaves.

This change also moves the /slaves endpoint to /agents and adds a compatibility 
redirect.


Diffs
-

  RELEASE-NOTES.md 21a141f1acadfdaa94247b75de2f734b11868137 
  config/legacy_untested_classes.txt 10e8b77a8a66372a6ec514c2dac2774c77eecd52 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
4faf53fac63b3657b9cb3ce805ae390972283a50 
  src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
f63fb7be35e2d538d34f6c4a88fb191916d7ab6e 
  
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
 93bc672cdf4151f2dc5bd63fbf4a8ce708ed5f42 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
85ca0ea723095fedf522e90d55e46e9de156f602 
  src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
577edcbf362493d577e2f12c876f1dbb9387ad79 
  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
5be39814901f92100176f7f6ea847d5042adb201 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
1ddc11732fce22fac2b068e0846a29ee2646719b 
  src/main/python/apache/aurora/client/base.py 
901335b0934fbde9769e2e93c06b27de428dd302 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
b2cc78d8ed6782928eb85e56c51b503c85e1796e 
  src/main/resources/org/apache/aurora/scheduler/http/slaves.st 
009e5af5ebecde8875f2651f8fe33ef4bc79457a 
  src/main/resources/org/apache/aurora/scheduler/http/utilization.st 
ae497a7c2b5c76a74e5b7ed07b98286a2542aa12 
  src/main/resources/scheduler/assets/index.html 
5679b19b18d6dcb480682be72309f922636868b0 
  src/main/resources/scheduler/assets/js/filters.js 
ec35d81537b44b7bf76cf4cf134b96d44904fee1 

Diff: https://reviews.apache.org/r/48216/diff/


Testing
---

* ran ./build-support/jenkins/build.sh
* checked in the Vagrant box that /slaves and /agents are both working.


Thanks,

Stephan Erb

Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-03 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48082/#review136092
---



Looks good to me in general. Mostly nits below...


src/main/java/org/apache/aurora/scheduler/TierManager.java (lines 46 - 48)


Add javadoc for both of these.



src/main/java/org/apache/aurora/scheduler/TierManager.java (lines 60 - 61)


Style nit, our continuation indent style is:

public TierConfig(
@JsonProperty("...") String defaultTier,
...) {

  // first line of method body here, note blank line above.



src/main/java/org/apache/aurora/scheduler/TierManager.java (line 62)


nit: s/Default/Default tier



src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
(lines 381 - 385)


`Tier` should be generated with a constructor that takes all of these args? 
Can we just do...

TierInfo tierInfo = entry.getValue();
return new Tier(entry.getKey(), tierInfo.isPreemptible(), 
tierInfo.isRevocable());



src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
(lines 391 - 392)


Should fit on one line?


- Joshua Cohen


On May 31, 2016, 7:02 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48082/
> ---
> 
> (Updated May 31, 2016, 7:02 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1624 Make 'tier' required and remove support for 'production' flag in 
> Job configuration - New thrift API for retrieving tier configuration
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ed94f249d85ac0e438213924c777cf7c029a119a 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> b96189be0ada1623665c2bff2550c1d72d7bc3dd 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> e431b58c933886f46c095240704d3eb0ceea2d80 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 0d4f04403ec20c21b7cfacd706557cd191579f0a 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  4d032b96d55dd0b92fab338220e66628e38cbb11 
>   src/main/resources/org/apache/aurora/scheduler/tiers.json 
> f724c5ad03a1315bc55dac35d98fdef45625e017 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 95174bb7454a9e7c075ebaa6a4f84bf55fbc2652 
>   src/test/java/org/apache/aurora/scheduler/TierModuleTest.java 
> 6b4e7a0d5e64d0632c66273ad516f737b2ef4a92 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  2122f744089adaee24328a634a2f786d1ef9720f 
> 
> Diff: https://reviews.apache.org/r/48082/diff/
> 
> 
> Testing
> ---
> 
> Manual/Explorative: Invoked from CLI-side to see if the new API call works as 
> intended
> Integration: ./build-support/jenkins/build.sh
> E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 48216: Change the UI to refer to Mesos Agents instead of Mesos Slaves.

2016-06-03 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48216/#review136096
---


Ship it!




Ship It!

- Joshua Cohen


On June 3, 2016, 6:30 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48216/
> ---
> 
> (Updated June 3, 2016, 6:30 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1449 and AURORA-1450
> https://issues.apache.org/jira/browse/AURORA-1449
> https://issues.apache.org/jira/browse/AURORA-1450
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Change the UI to refer to Mesos Agents instead of Mesos Slaves.
> 
> This change also moves the /slaves endpoint to /agents and adds a 
> compatibility redirect.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 21a141f1acadfdaa94247b75de2f734b11868137 
>   config/legacy_untested_classes.txt 10e8b77a8a66372a6ec514c2dac2774c77eecd52 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 4faf53fac63b3657b9cb3ce805ae390972283a50 
>   src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
> f63fb7be35e2d538d34f6c4a88fb191916d7ab6e 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  93bc672cdf4151f2dc5bd63fbf4a8ce708ed5f42 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> 85ca0ea723095fedf522e90d55e46e9de156f602 
>   src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
> 577edcbf362493d577e2f12c876f1dbb9387ad79 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 5be39814901f92100176f7f6ea847d5042adb201 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 1ddc11732fce22fac2b068e0846a29ee2646719b 
>   src/main/python/apache/aurora/client/base.py 
> 901335b0934fbde9769e2e93c06b27de428dd302 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> b2cc78d8ed6782928eb85e56c51b503c85e1796e 
>   src/main/resources/org/apache/aurora/scheduler/http/slaves.st 
> 009e5af5ebecde8875f2651f8fe33ef4bc79457a 
>   src/main/resources/org/apache/aurora/scheduler/http/utilization.st 
> ae497a7c2b5c76a74e5b7ed07b98286a2542aa12 
>   src/main/resources/scheduler/assets/index.html 
> 5679b19b18d6dcb480682be72309f922636868b0 
>   src/main/resources/scheduler/assets/js/filters.js 
> ec35d81537b44b7bf76cf4cf134b96d44904fee1 
> 
> Diff: https://reviews.apache.org/r/48216/diff/
> 
> 
> Testing
> ---
> 
> * ran ./build-support/jenkins/build.sh
> * checked in the Vagrant box that /slaves and /agents are both working.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 48216: Change the UI to refer to Mesos Agents instead of Mesos Slaves.

2016-06-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48216/#review136093
---



Master (692b5d1) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 3, 2016, 6:30 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48216/
> ---
> 
> (Updated June 3, 2016, 6:30 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1449 and AURORA-1450
> https://issues.apache.org/jira/browse/AURORA-1449
> https://issues.apache.org/jira/browse/AURORA-1450
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Change the UI to refer to Mesos Agents instead of Mesos Slaves.
> 
> This change also moves the /slaves endpoint to /agents and adds a 
> compatibility redirect.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 21a141f1acadfdaa94247b75de2f734b11868137 
>   config/legacy_untested_classes.txt 10e8b77a8a66372a6ec514c2dac2774c77eecd52 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 4faf53fac63b3657b9cb3ce805ae390972283a50 
>   src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
> f63fb7be35e2d538d34f6c4a88fb191916d7ab6e 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  93bc672cdf4151f2dc5bd63fbf4a8ce708ed5f42 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> 85ca0ea723095fedf522e90d55e46e9de156f602 
>   src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
> 577edcbf362493d577e2f12c876f1dbb9387ad79 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 5be39814901f92100176f7f6ea847d5042adb201 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 1ddc11732fce22fac2b068e0846a29ee2646719b 
>   src/main/python/apache/aurora/client/base.py 
> 901335b0934fbde9769e2e93c06b27de428dd302 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> b2cc78d8ed6782928eb85e56c51b503c85e1796e 
>   src/main/resources/org/apache/aurora/scheduler/http/slaves.st 
> 009e5af5ebecde8875f2651f8fe33ef4bc79457a 
>   src/main/resources/org/apache/aurora/scheduler/http/utilization.st 
> ae497a7c2b5c76a74e5b7ed07b98286a2542aa12 
>   src/main/resources/scheduler/assets/index.html 
> 5679b19b18d6dcb480682be72309f922636868b0 
>   src/main/resources/scheduler/assets/js/filters.js 
> ec35d81537b44b7bf76cf4cf134b96d44904fee1 
> 
> Diff: https://reviews.apache.org/r/48216/diff/
> 
> 
> Testing
> ---
> 
> * ran ./build-support/jenkins/build.sh
> * checked in the Vagrant box that /slaves and /agents are both working.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 48218: Document the logfile locations used in the vagrant box

2016-06-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48218/#review136099
---


Ship it!




Master (692b5d1) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 3, 2016, 7:20 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48218/
> ---
> 
> (Updated June 3, 2016, 7:20 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Document the logfile locations used in the vagrant box
> 
> 
> Diffs
> -
> 
>   docs/getting-started/vagrant.md 44606009759a68cb142be4f2c7061ad8d0a39066 
> 
> Diff: https://reviews.apache.org/r/48218/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-03 Thread Dmitriy Shirchenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47440/
---

(Updated June 3, 2016, 10:17 p.m.)


Review request for Aurora, Maxim Khutornenko and Stephan Erb.


Bugs: AURORA-1683
https://issues.apache.org/jira/browse/AURORA-1683


Repository: aurora


Description
---

Looking for some feedback whether I'm on the correct path in adding a webhook. 
All comments are welcome!


Diffs (updated)
-

  RELEASE-NOTES.md 4cbf92e6556d4d84053292e26f65755d971089c0 
  docs/features/webhooks.md PRE-CREATION 
  docs/reference/scheduler-configuration.md 
f7d676d0ed6bc536f4341dbb9365cf50e8607efb 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
9ebfe230836e88a97bc60092373f72f176a8f6f2 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
2a4c0665e48d30e0655de00bd7f6f9b49f01eafc 
  src/main/java/org/apache/aurora/scheduler/events/Webhook.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/47440/diff/


Testing
---

Need to fix tests.


Thanks,

Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47440/#review136144
---


Ship it!




Master (692b5d1) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 3, 2016, 11:54 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47440/
> ---
> 
> (Updated June 3, 2016, 11:54 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Stephan Erb.
> 
> 
> Bugs: AURORA-1683
> https://issues.apache.org/jira/browse/AURORA-1683
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Looking for some feedback whether I'm on the correct path in adding a 
> webhook. All comments are welcome!
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 21a141f1acadfdaa94247b75de2f734b11868137 
>   docs/features/webhooks.md PRE-CREATION 
>   docs/reference/scheduler-configuration.md 
> f7d676d0ed6bc536f4341dbb9365cf50e8607efb 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 9ebfe230836e88a97bc60092373f72f176a8f6f2 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 2a4c0665e48d30e0655de00bd7f6f9b49f01eafc 
>   src/main/java/org/apache/aurora/scheduler/events/Webhook.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47440/diff/
> 
> 
> Testing
> ---
> 
> Need to fix tests.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-03 Thread Dmitriy Shirchenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47440/
---

(Updated June 3, 2016, 11:54 p.m.)


Review request for Aurora, Maxim Khutornenko and Stephan Erb.


Bugs: AURORA-1683
https://issues.apache.org/jira/browse/AURORA-1683


Repository: aurora


Description
---

Looking for some feedback whether I'm on the correct path in adding a webhook. 
All comments are welcome!


Diffs (updated)
-

  RELEASE-NOTES.md 21a141f1acadfdaa94247b75de2f734b11868137 
  docs/features/webhooks.md PRE-CREATION 
  docs/reference/scheduler-configuration.md 
f7d676d0ed6bc536f4341dbb9365cf50e8607efb 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
9ebfe230836e88a97bc60092373f72f176a8f6f2 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
2a4c0665e48d30e0655de00bd7f6f9b49f01eafc 
  src/main/java/org/apache/aurora/scheduler/events/Webhook.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/47440/diff/


Testing
---

Need to fix tests.


Thanks,

Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-03 Thread Dmitriy Shirchenko 


> On May 27, 2016, 2 p.m., Stephan Erb wrote:
> > Repeating from my previous review: Would be great if you could add
> > 
> > * an entry to the release notes
> > * a minimal docs/features/webhooks.md that shows a valid webhook config and 
> > how a dispatched event would look like.

Done.


> On May 27, 2016, 2 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java, line 71
> > 
> >
> > Is it intentional that you use multiple names for the timeout here? 
> > (`connectTimeout` vs `timeoutMsec`)

Yea, I followed Maxim's suggestion to make it more clear that the timeout value 
is in milliseconds, and connectTimeout corresponds to the value 
`HttpURLConnection` expects. How does that sound? Or still too confusing?


> On May 27, 2016, 2 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 72
> > 
> >
> > This will fail with a `NullPointerException` when 
> > `initializeConnection()` returns `None`. Same applies to other places in 
> > the content of the try block.

Done.


- Dmitriy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47440/#review135233
---


On June 3, 2016, 10:17 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47440/
> ---
> 
> (Updated June 3, 2016, 10:17 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Stephan Erb.
> 
> 
> Bugs: AURORA-1683
> https://issues.apache.org/jira/browse/AURORA-1683
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Looking for some feedback whether I'm on the correct path in adding a 
> webhook. All comments are welcome!
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 4cbf92e6556d4d84053292e26f65755d971089c0 
>   docs/features/webhooks.md PRE-CREATION 
>   docs/reference/scheduler-configuration.md 
> f7d676d0ed6bc536f4341dbb9365cf50e8607efb 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 9ebfe230836e88a97bc60092373f72f176a8f6f2 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 2a4c0665e48d30e0655de00bd7f6f9b49f01eafc 
>   src/main/java/org/apache/aurora/scheduler/events/Webhook.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47440/diff/
> 
> 
> Testing
> ---
> 
> Need to fix tests.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 48218: Document the logfile locations used in the vagrant box

2016-06-03 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48218/#review136098
---


Ship it!





docs/getting-started/vagrant.md (lines 153 - 154)


Might be worth mentioning the other log levels for mesos? Problems are 
often found in the WARN logs, right?


- Joshua Cohen


On June 3, 2016, 7:20 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48218/
> ---
> 
> (Updated June 3, 2016, 7:20 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Document the logfile locations used in the vagrant box
> 
> 
> Diffs
> -
> 
>   docs/getting-started/vagrant.md 44606009759a68cb142be4f2c7061ad8d0a39066 
> 
> Diff: https://reviews.apache.org/r/48218/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>